Re: [PATCH, RFC] MAINTAINERS: update OSD entries

2017-05-03 Thread Benny Halevy
) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 1bb06c5f7716..28dd83a1d9e2 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -9418,10 +9418,6 @@ F:drivers/net/wireless/intersil/orinoco/ > >> > >> OSD LIBRARY

Re: [PATCH, RFC] MAINTAINERS: update OSD entries

2017-05-03 Thread Benny Halevy
AINTAINERS > >> index 1bb06c5f7716..28dd83a1d9e2 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -9418,10 +9418,6 @@ F:drivers/net/wireless/intersil/orinoco/ > >> > >> OSD LIBRARY and FILESYSTEM > >> M: Boaz Harrosh &

Re: [PATCH] MAINTAINERS: Update email address for bhalevy

2014-02-16 Thread Benny Halevy
On 02/13/2014 07:59 PM, Boaz Harrosh wrote: > On 02/10/2014 11:57 AM, Benny Halevy wrote: >> Tonian is now Primary Data. >> > > Benny hi > > Do you need a push from my tree? Yes please. Makes most sense. Benny > > Boaz > >> Signed-off-by: Benny H

Re: [PATCH] MAINTAINERS: Update email address for bhalevy

2014-02-16 Thread Benny Halevy
On 02/13/2014 07:59 PM, Boaz Harrosh wrote: On 02/10/2014 11:57 AM, Benny Halevy wrote: Tonian is now Primary Data. Benny hi Do you need a push from my tree? Yes please. Makes most sense. Benny Boaz Signed-off-by: Benny Halevy bhal...@primarydata.com --- MAINTAINERS | 2 +- 1

[PATCH] MAINTAINERS: Update email address for bhalevy

2014-02-10 Thread Benny Halevy
Tonian is now Primary Data. Signed-off-by: Benny Halevy --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6a6e4ac..b42174d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6336,7 +6336,7 @@ F:drivers/net/wireless/orinoco

[PATCH] MAINTAINERS: Update email address for bhalevy

2014-02-10 Thread Benny Halevy
Tonian is now Primary Data. Signed-off-by: Benny Halevy bhal...@primarydata.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6a6e4ac..b42174d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6336,7 +6336,7 @@ F:drivers

[PATCH] MAINTAINERS: Update email address for Benny Halevy

2013-08-20 Thread Benny Halevy
Update my email address to new company name. Cc: Boaz Harrosh Signed-off-by: Benny Halevy --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 229c66b..0a754ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6125,7 +6125,7 @@ F

[PATCH] MAINTAINERS: Update email address for Benny Halevy

2013-08-20 Thread Benny Halevy
Update my email address to new company name. Cc: Boaz Harrosh bharr...@panasas.com Signed-off-by: Benny Halevy bhal...@primarydata.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 229c66b..0a754ea 100644 --- a/MAINTAINERS

Re: [PATCH 1/2] Revert "IB/fmr_pool: ib_fmr_pool_flush() should flush all dirty FMRs"

2008-02-26 Thread Benny Halevy
Diabolical ;-) Thanks for the pointer! Benny On Feb. 26, 2008, 11:39 -0800, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Tue, Feb 26, 2008 at 11:23:01AM -0800, Benny Halevy wrote: >> Pete, the subject says "PATCH 1/2" but I didn't see any follow-up message >>

Re: [PATCH 1/2] Revert "IB/fmr_pool: ib_fmr_pool_flush() should flush all dirty FMRs"

2008-02-26 Thread Benny Halevy
Pete, the subject says "PATCH 1/2" but I didn't see any follow-up message for PATCH 2/2. Just wondering :) Benny On Feb. 26, 2008, 10:27 -0800, Pete Wyckoff <[EMAIL PROTECTED]> wrote: > This reverts commit a3cd7d9070be417a21905c997ee32d756d999b38. > > The original commit breaks iSER reliably,

Re: [PATCH 1/2] Revert IB/fmr_pool: ib_fmr_pool_flush() should flush all dirty FMRs

2008-02-26 Thread Benny Halevy
Pete, the subject says PATCH 1/2 but I didn't see any follow-up message for PATCH 2/2. Just wondering :) Benny On Feb. 26, 2008, 10:27 -0800, Pete Wyckoff [EMAIL PROTECTED] wrote: This reverts commit a3cd7d9070be417a21905c997ee32d756d999b38. The original commit breaks iSER reliably, making

Re: [PATCH 1/2] Revert IB/fmr_pool: ib_fmr_pool_flush() should flush all dirty FMRs

2008-02-26 Thread Benny Halevy
Diabolical ;-) Thanks for the pointer! Benny On Feb. 26, 2008, 11:39 -0800, Matthew Wilcox [EMAIL PROTECTED] wrote: On Tue, Feb 26, 2008 at 11:23:01AM -0800, Benny Halevy wrote: Pete, the subject says PATCH 1/2 but I didn't see any follow-up message for PATCH 2/2. Just wondering :) I think

Re: Tabs, spaces, indent and 80 character lines

2008-02-25 Thread Benny Halevy
On Feb. 25, 2008, 13:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: > Benny Halevy wrote: >> On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: >> >>> Krzysztof Halasa wrote: >>> >

Re: Tabs, spaces, indent and 80 character lines

2008-02-25 Thread Benny Halevy
On Feb. 25, 2008, 13:40 -0800, Richard Knutsson [EMAIL PROTECTED] wrote: Benny Halevy wrote: On Feb. 24, 2008, 7:40 -0800, Richard Knutsson [EMAIL PROTECTED] wrote: Krzysztof Halasa wrote: Richard Knutsson [EMAIL PROTECTED] writes: Why hinder a developer who prefer 2

Re: [PATCH] Change a WARN message in checkpatch

2008-02-24 Thread Benny Halevy
On Feb. 24, 2008, 19:29 -0800, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote: >> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <[EMAIL PROTECTED]> wrote: >> [...] >>> How about: >>> -

Re: Tabs, spaces, indent and 80 character lines

2008-02-24 Thread Benny Halevy
On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: > Krzysztof Halasa wrote: >> Richard Knutsson <[EMAIL PROTECTED]> writes: >> >> >>> Why hinder a developer who prefer >>> 2, 4, 6 or any other != 8 width? >>> >> I guess we could use tabs only at the line start, for

Re: [PATCH] Change a WARN message in checkpatch

2008-02-24 Thread Benny Halevy
On Feb. 23, 2008, 5:38 -0800, "Paolo Ciarrocchi" <[EMAIL PROTECTED]> wrote: > On Mon, Jan 28, 2008 at 4:13 PM, Paolo Ciarrocchi > <[EMAIL PROTECTED]> wrote: >> On Jan 28, 2008 3:56 PM, Andy Whitcroft <[EMAIL PROTECTED]> wrote: >> > On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:

Re: [PATCH] Change a WARN message in checkpatch

2008-02-24 Thread Benny Halevy
On Feb. 23, 2008, 5:38 -0800, Paolo Ciarrocchi [EMAIL PROTECTED] wrote: On Mon, Jan 28, 2008 at 4:13 PM, Paolo Ciarrocchi [EMAIL PROTECTED] wrote: On Jan 28, 2008 3:56 PM, Andy Whitcroft [EMAIL PROTECTED] wrote: On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote: Hi Andy,

Re: Tabs, spaces, indent and 80 character lines

2008-02-24 Thread Benny Halevy
On Feb. 24, 2008, 7:40 -0800, Richard Knutsson [EMAIL PROTECTED] wrote: Krzysztof Halasa wrote: Richard Knutsson [EMAIL PROTECTED] writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only at the line start, for indentation only.

Re: [PATCH] Change a WARN message in checkpatch

2008-02-24 Thread Benny Halevy
On Feb. 24, 2008, 19:29 -0800, Andy Whitcroft [EMAIL PROTECTED] wrote: On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote: On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy [EMAIL PROTECTED] wrote: [...] How about: - WARN(no space between function

Re: linux-next: first tree

2008-02-14 Thread Benny Halevy
On Feb. 14, 2008, 20:29 +0200, "Yinghai Lu" <[EMAIL PROTECTED]> wrote: > On Thu, Feb 14, 2008 at 5:35 AM, Stephen Rothwell <[EMAIL PROTECTED]> wrote: >> Hi all, >> >> I have created the first cut of the linux-next tree at >> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. >> >>

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-14 Thread Benny Halevy
On Feb. 13, 2008, 19:52 +0200, "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > On Tue, Feb 12, 2008 at 09:43:10PM -0800, Linus Torvalds wrote: >> So just the fact that the right commit gets blamed when somebody does a >> "git bisect" is I think a big issue. It's just fundamentally more fair to >>

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-14 Thread Benny Halevy
On Feb. 13, 2008, 19:52 +0200, J. Bruce Fields [EMAIL PROTECTED] wrote: On Tue, Feb 12, 2008 at 09:43:10PM -0800, Linus Torvalds wrote: So just the fact that the right commit gets blamed when somebody does a git bisect is I think a big issue. It's just fundamentally more fair to everybody.

Re: linux-next: first tree

2008-02-14 Thread Benny Halevy
On Feb. 14, 2008, 20:29 +0200, Yinghai Lu [EMAIL PROTECTED] wrote: On Thu, Feb 14, 2008 at 5:35 AM, Stephen Rothwell [EMAIL PROTECTED] wrote: Hi all, I have created the first cut of the linux-next tree at git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. Things to know

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 20:36 +0200, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Tue, 12 Feb 2008, Benny Halevy wrote: >> IMHO, this base tree should typically be based off of linus' tree >> and kept rebased on top of it. This way you get the mainline fixes >> thr

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 19:41 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 09:09 -0800, Linus Torvalds wrote: >> (a) create a base tree with _just_ that fundamental infrastructure change, >> and make sure that base branch is so obviously good that there is no >>

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 18:36 +0200, Jeff Garzik <[EMAIL PROTECTED]> wrote: > David Miller wrote: >> This is why, with the networking, we've just tossed all of the network >> driver stuff in there too. I can rebase freely, remove changesets, >> rework them, etc. and this causes a very low amount of

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 17:07 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-11 at 21:53 -0800, Greg KH wrote: >>> this is why you need specific trees for just the API change, and these >>> need to EXPLICITLY go first before EVERYTHING ELSE. Yes this needs a >>> bit of coordination,

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-12 Thread Benny Halevy
On Feb. 11, 2008, 20:42 +0200, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote: >> OK, but the return type doesn't have to be in the patched line, it could be >> in >> a synchronization line or even missing if th

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-12 Thread Benny Halevy
On Feb. 11, 2008, 20:42 +0200, Andy Whitcroft [EMAIL PROTECTED] wrote: On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote: OK, but the return type doesn't have to be in the patched line, it could be in a synchronization line or even missing if the function has a long multi-line

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 20:36 +0200, Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 12 Feb 2008, Benny Halevy wrote: IMHO, this base tree should typically be based off of linus' tree and kept rebased on top of it. This way you get the mainline fixes through the integration base tree. Hell

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 19:41 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 09:09 -0800, Linus Torvalds wrote: (a) create a base tree with _just_ that fundamental infrastructure change, and make sure that base branch is so obviously good that there is no question

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 18:36 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: David Miller wrote: This is why, with the networking, we've just tossed all of the network driver stuff in there too. I can rebase freely, remove changesets, rework them, etc. and this causes a very low amount of pain for

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Benny Halevy
On Feb. 12, 2008, 17:07 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-02-11 at 21:53 -0800, Greg KH wrote: this is why you need specific trees for just the API change, and these need to EXPLICITLY go first before EVERYTHING ELSE. Yes this needs a bit of coordination, but it's

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-11 Thread Benny Halevy
Seriously, can't you just add a disclaimer to the README file? In http://lkml.org/lkml/2008/2/9/29, Luben Tuikov made an interesting point that in many cases "illegal" refers to a valid value that violates the specification, so the term "invalid" may be technically incorrect. Benny On Feb. 11,

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-11 Thread Benny Halevy
On Feb. 11, 2008, 18:40 +0200, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote: >> I saw this too with checkpatch.pl version 0.12 >> It seems like checkpatch.pl knows only about types derived >> from @typeList by

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-11 Thread Benny Halevy
I saw this too with checkpatch.pl version 0.12 It seems like checkpatch.pl knows only about types derived from @typeList by build_types. Example below... Benny $ cat < wrote: > On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote: >> Hi >> >> Checkpatch in current mainline outputs

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-11 Thread Benny Halevy
I saw this too with checkpatch.pl version 0.12 It seems like checkpatch.pl knows only about types derived from @typeList by build_types. Example below... Benny $ cat EOF | scripts/checkpatch.pl - Signed-off-by: [EMAIL PROTECTED] --- diff a/f.c b/f.c --- a/f.c +++ b/f.c @@ -1,0 +1,2 @@ +foo(int

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-11 Thread Benny Halevy
Seriously, can't you just add a disclaimer to the README file? In http://lkml.org/lkml/2008/2/9/29, Luben Tuikov made an interesting point that in many cases illegal refers to a valid value that violates the specification, so the term invalid may be technically incorrect. Benny On Feb. 11,

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-11 Thread Benny Halevy
On Feb. 11, 2008, 18:40 +0200, Andy Whitcroft [EMAIL PROTECTED] wrote: On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote: I saw this too with checkpatch.pl version 0.12 It seems like checkpatch.pl knows only about types derived from @typeList by build_types. Example below

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Benny Halevy
On Feb. 06, 2008, 14:16 +0200, "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > On Feb 5, 2008 6:01 PM, Erez Zilber <[EMAIL PROTECTED]> wrote: >> Using such large values for FirstBurstLength will give you poor >> performance numbers for WRITE commands (with iSER). FirstBurstLength >> means how much

Re: [PATCH] update checkpatch.pl to version 0.14

2008-02-06 Thread Benny Halevy
On Feb. 06, 2008, 16:43 +0200, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Tue, Feb 05, 2008 at 09:26:47PM +0200, Benny Halevy wrote: >> Was version 0.13 NACKed? > > It was picked up by Andrew for -mm according to my email. I do not > think there has been an -mm re

Re: [PATCH] update checkpatch.pl to version 0.14

2008-02-06 Thread Benny Halevy
On Feb. 06, 2008, 16:43 +0200, Andy Whitcroft [EMAIL PROTECTED] wrote: On Tue, Feb 05, 2008 at 09:26:47PM +0200, Benny Halevy wrote: Was version 0.13 NACKed? It was picked up by Andrew for -mm according to my email. I do not think there has been an -mm release since then however

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Benny Halevy
On Feb. 06, 2008, 14:16 +0200, Bart Van Assche [EMAIL PROTECTED] wrote: On Feb 5, 2008 6:01 PM, Erez Zilber [EMAIL PROTECTED] wrote: Using such large values for FirstBurstLength will give you poor performance numbers for WRITE commands (with iSER). FirstBurstLength means how much data should

Re: [PATCH] update checkpatch.pl to version 0.14

2008-02-05 Thread Benny Halevy
Was version 0.13 NACKed? Benny -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] update checkpatch.pl to version 0.14

2008-02-05 Thread Benny Halevy
Was version 0.13 NACKed? Benny -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re:

2008-02-03 Thread Benny Halevy
am kara wrote: > hello, > > If kernel does kmap_atomic(temporary kernel mapping) > on behalf of a process by a cpu, does the process will > continue to run and no other process can be scheduled > to switch it off?(till kunmap_atomic is done) Effectively, kmap_atomic implementations call

Re:

2008-02-03 Thread Benny Halevy
am kara wrote: hello, If kernel does kmap_atomic(temporary kernel mapping) on behalf of a process by a cpu, does the process will continue to run and no other process can be scheduled to switch it off?(till kunmap_atomic is done) Effectively, kmap_atomic implementations call

Re: [PATCH] update checkpatch.pl to version 0.13

2008-01-18 Thread Benny Halevy
On Jan. 18, 2008, 13:37 +0200, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote: >> On Thu, 17 Jan 2008 16:23:51 - Andy Whitcroft <[EMAIL PROTECTED]> wrote: >> >>> This version brings a large number of fixes which have built up over >>>

Re: [PATCH] update checkpatch.pl to version 0.13

2008-01-18 Thread Benny Halevy
On Jan. 18, 2008, 13:37 +0200, Andy Whitcroft [EMAIL PROTECTED] wrote: On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote: On Thu, 17 Jan 2008 16:23:51 - Andy Whitcroft [EMAIL PROTECTED] wrote: This version brings a large number of fixes which have built up over the Christmas

Re: Checkpatch.pl failure

2008-01-14 Thread Benny Halevy
On Jan. 14, 2008, 17:48 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > This error: > > ERROR: no space before that close parenthesis ')' > #501: FILE: drivers/scsi/dpt_i2o.c:2299: > + if (dev_status == 0x02 /*CHECK_CONDITION*/) { > > Is definitely wrong. I think it's stripped

Re: Checkpatch.pl failure

2008-01-14 Thread Benny Halevy
On Jan. 14, 2008, 17:48 +0200, James Bottomley [EMAIL PROTECTED] wrote: This error: ERROR: no space before that close parenthesis ')' #501: FILE: drivers/scsi/dpt_i2o.c:2299: + if (dev_status == 0x02 /*CHECK_CONDITION*/) { Is definitely wrong. I think it's stripped the

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Benny Halevy
On Jan. 03, 2008, 14:30 +0200, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: >> On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: >>> We have had some stabs at changing this, but no consensus was reached

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Benny Halevy
On Jan. 03, 2008, 14:30 +0200, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: We have had some stabs at changing this, but no consensus was reached on

[PATCH] checkpatch.pl: recognize the #elif preprocessor directive

2008-01-01 Thread Benny Halevy
*p[1] = { #if defined(X) #elif defined(Y) #else #endif }; } Signed-off-by: Benny Halevy <[EMAIL PROTECTED]> --- scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl

[PATCH] checkpatch.pl: recognize the #elif preprocessor directive

2008-01-01 Thread Benny Halevy
] = { #if defined(X) x #elif defined(Y) y #else z #endif }; } Signed-off-by: Benny Halevy [EMAIL PROTECTED] --- scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts

Re: void* arithmnetic

2007-11-28 Thread Benny Halevy
On Nov. 29, 2007, 3:19 +0200, "Ming Lei" <[EMAIL PROTECTED]> wrote: > 2007/11/29, Jan Engelhardt <[EMAIL PROTECTED]>: >> On Nov 29 2007 01:05, J.A. Magallón wrote: >>> Since begin of the ages the build of the nvidia driver says things like >>> this: >>> >> Explicitly adding -Wpointer-arith to ones

Re: void* arithmnetic

2007-11-28 Thread Benny Halevy
On Nov. 29, 2007, 3:19 +0200, Ming Lei [EMAIL PROTECTED] wrote: 2007/11/29, Jan Engelhardt [EMAIL PROTECTED]: On Nov 29 2007 01:05, J.A. Magallón wrote: Since begin of the ages the build of the nvidia driver says things like this: Explicitly adding -Wpointer-arith to ones own Makefile is

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Benny Halevy
I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Benny On Nov. 14, 2007, 9:04 +0200, Chris Wedgwood <[EMAIL PROTECTED]> wrote: > With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) > see a hang when accessing some NFS

Re: 2.6.24-rc2 XFS nfsd hang

2007-11-13 Thread Benny Halevy
I wonder if this is a similar hang to what Christian was seeing here: http://lkml.org/lkml/2007/11/13/319 Benny On Nov. 14, 2007, 9:04 +0200, Chris Wedgwood [EMAIL PROTECTED] wrote: With 2.6.24-rc2 (amd64) I sometimes (usually but perhaps not always) see a hang when accessing some NFS exported

Re: linux-nfs created at vger

2007-11-12 Thread Benny Halevy
Dave, this sounds like a good idea. How about cross posting this message also to [EMAIL PROTECTED] Benny On Nov. 12, 2007, 10:16 +0200, David Miller <[EMAIL PROTECTED]> wrote: > Because the sourceforge lists are a huge collection of spam and > subscriber-posting only, and someone reminded me of

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 08, 2007, 17:58 +0200, Chris Snook <[EMAIL PROTECTED]> wrote: > Benny Halevy wrote: >> Greetings, >> >> I would like to hear peoples opinion about the indentation convention >> described below that I personally found the most practical with >> se

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 11, 2007, 11:23 +0200, James Courtier-Dutton <[EMAIL PROTECTED]> wrote: > DervishD wrote: >> Bonjour Xavier :) >> >> * Xavier Bestel <[EMAIL PROTECTED]> dixit: >> >>> Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit :

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 11, 2007, 11:23 +0200, James Courtier-Dutton [EMAIL PROTECTED] wrote: DervishD wrote: Bonjour Xavier :) * Xavier Bestel [EMAIL PROTECTED] dixit: Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : * Benny Halevy [EMAIL PROTECTED] dixit: I would like

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 08, 2007, 17:58 +0200, Chris Snook [EMAIL PROTECTED] wrote: Benny Halevy wrote: Greetings, I would like to hear peoples opinion about the indentation convention described below that I personally found the most practical with several different editors. The gist of it is that tabs

Re: linux-nfs created at vger

2007-11-12 Thread Benny Halevy
Dave, this sounds like a good idea. How about cross posting this message also to [EMAIL PROTECTED] Benny On Nov. 12, 2007, 10:16 +0200, David Miller [EMAIL PROTECTED] wrote: Because the sourceforge lists are a huge collection of spam and subscriber-posting only, and someone reminded me of this

Re: Coding Style: indenting with tabs vs. spaces

2007-11-11 Thread Benny Halevy
On Nov. 10, 2007, 14:27 +0200, Xavier Bestel <[EMAIL PROTECTED]> wrote: > Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : >> Hi Benny :) >> >> * Benny Halevy <[EMAIL PROTECTED]> dixit: >>> I would like to hear peoples opinion about the

Re: Coding Style: indenting with tabs vs. spaces

2007-11-11 Thread Benny Halevy
On Nov. 10, 2007, 14:27 +0200, Xavier Bestel [EMAIL PROTECTED] wrote: Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : Hi Benny :) * Benny Halevy [EMAIL PROTECTED] dixit: I would like to hear peoples opinion about the indentation convention described below that I personally

Coding Style: indenting with tabs vs. spaces

2007-11-08 Thread Benny Halevy
Greetings, I would like to hear peoples opinion about the indentation convention described below that I personally found the most practical with several different editors. The gist of it is that tabs should be used for nesting, not for decoration. Indent your code with as many tabs as your

Coding Style: indenting with tabs vs. spaces

2007-11-08 Thread Benny Halevy
Greetings, I would like to hear peoples opinion about the indentation convention described below that I personally found the most practical with several different editors. The gist of it is that tabs should be used for nesting, not for decoration. Indent your code with as many tabs as your

Re: [PATCH] NFS: Stop sillyname renames and unmounts from racing

2007-11-06 Thread Benny Halevy
On Nov. 06, 2007, 7:06 +0200, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 03 Nov 2007 07:09:25 -0400 Steve Dickson <[EMAIL PROTECTED]> wrote: > >> The following patch stops NFS sillyname renames and umounts from racing. > > (appropriate cc's added) > >> I have a test script does the

Re: [PATCH] NFS: Stop sillyname renames and unmounts from racing

2007-11-06 Thread Benny Halevy
On Nov. 06, 2007, 7:06 +0200, Andrew Morton [EMAIL PROTECTED] wrote: On Sat, 03 Nov 2007 07:09:25 -0400 Steve Dickson [EMAIL PROTECTED] wrote: The following patch stops NFS sillyname renames and umounts from racing. (appropriate cc's added) I have a test script does the following:

Re: [PATCH 09/10] Change table chaining layout

2007-10-25 Thread Benny Halevy
On Oct. 25, 2007, 17:40 +0200, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Thu, 25 Oct 2007, Rusty Russell wrote: >> On Wednesday 24 October 2007 01:22:55 Linus Torvalds wrote: >>> Well, I'd personally actually prefer to *not* have the count be passed >>> down explicitly, because it's just

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

2007-10-25 Thread Benny Halevy
On Oct. 24, 2007, 10:50 +0200, Benny Halevy <[EMAIL PROTECTED]> wrote: > On Oct. 24, 2007, 10:32 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: >> On Wed, Oct 24 2007, FUJITA Tomonori wrote: >>> On Tue, 23 Oct 2007 20:49:40 +0530 >>> Kamalesh Babulal

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

2007-10-25 Thread Benny Halevy
On Oct. 24, 2007, 10:50 +0200, Benny Halevy [EMAIL PROTECTED] wrote: On Oct. 24, 2007, 10:32 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 24 2007, FUJITA Tomonori wrote: On Tue, 23 Oct 2007 20:49:40 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote: Hi, Kernel oops is triggered

Re: [PATCH 09/10] Change table chaining layout

2007-10-25 Thread Benny Halevy
On Oct. 25, 2007, 17:40 +0200, Linus Torvalds [EMAIL PROTECTED] wrote: On Thu, 25 Oct 2007, Rusty Russell wrote: On Wednesday 24 October 2007 01:22:55 Linus Torvalds wrote: Well, I'd personally actually prefer to *not* have the count be passed down explicitly, because it's just too error

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

2007-10-24 Thread Benny Halevy
On Oct. 24, 2007, 10:32 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Oct 24 2007, FUJITA Tomonori wrote: >> On Tue, 23 Oct 2007 20:49:40 +0530 >> Kamalesh Babulal <[EMAIL PROTECTED]> wrote: >> >>> Hi, >>> >>> Kernel oops is triggered while running fsx-linux test, followed by cpu >>>

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

2007-10-24 Thread Benny Halevy
On Oct. 24, 2007, 10:32 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 24 2007, FUJITA Tomonori wrote: On Tue, 23 Oct 2007 20:49:40 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote: Hi, Kernel oops is triggered while running fsx-linux test, followed by cpu softlock over the AMD box

Re: [PATCH 09/10] Change table chaining layout

2007-10-22 Thread Benny Halevy
On Oct. 22, 2007, 22:16 +0200, Alan Cox <[EMAIL PROTECTED]> wrote: > On Mon, 22 Oct 2007 12:49:40 -0700 (PDT) > Linus Torvalds <[EMAIL PROTECTED]> wrote: > >> >> On Mon, 22 Oct 2007, Geert Uytterhoeven wrote: >>> Better safe than sorry... >>> >>> Is it possible that a chain entry pointer has bit

Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers

2007-10-22 Thread Benny Halevy
It looks like it could be nice to define and use a helper for page_address(sg_page(sg)) (although 11 call sites could use it after this patch) #define sg_pgaddr(sg) page_address(sg_page(sg)) Note that mips sg_{un,}map_sg checked for page_address(sg->page) != 0 before calling __dma_sync(addr +

Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers

2007-10-22 Thread Benny Halevy
It looks like it could be nice to define and use a helper for page_address(sg_page(sg)) (although 11 call sites could use it after this patch) #define sg_pgaddr(sg) page_address(sg_page(sg)) Note that mips sg_{un,}map_sg checked for page_address(sg-page) != 0 before calling __dma_sync(addr +

Re: [PATCH 09/10] Change table chaining layout

2007-10-22 Thread Benny Halevy
On Oct. 22, 2007, 22:16 +0200, Alan Cox [EMAIL PROTECTED] wrote: On Mon, 22 Oct 2007 12:49:40 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 22 Oct 2007, Geert Uytterhoeven wrote: Better safe than sorry... Is it possible that a chain entry pointer has bit 1 set on

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 16:05 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Thu, Oct 18 2007, Jens Axboe wrote: >> On Thu, Oct 18 2007, Benny Halevy wrote: >>>>return sg; >>>> } >>>> @@ -83,6 +96,9 @@ static inline struct scatterlist *sg_last

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 15:32 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > static inline struct scatterlist *sg_next(struct scatterlist *sg) > { > - sg++; > - > - if (unlikely(sg_is_chain(sg))) > +#ifdef CONFIG_DEBUG_SG > + BUG_ON(sg->sg_magic != SG_MAGIC); > +#endif > + if

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 14:15 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > /** > * sg_next - return the next scatterlist entry in a list > @@ -43,10 +51,15 @@ static inline void sg_init_one(struct scatterlist *sg, > const void *buf, > */ > static inline struct scatterlist *sg_next(struct

Re: [bug] block subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 17, 2007, 20:22 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Oct 17 2007, Linus Torvalds wrote: >> >> On Wed, 17 Oct 2007, Jens Axboe wrote: So avoiding the "sg_next()" on the last entry is pointless. >>> Yeah, I didn't quite understand why if sg was valid, why

Re: [bug] block subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 17, 2007, 20:22 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 17 2007, Linus Torvalds wrote: On Wed, 17 Oct 2007, Jens Axboe wrote: So avoiding the sg_next() on the last entry is pointless. Yeah, I didn't quite understand why if sg was valid, why dereferencing *(sg +

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 14:15 +0200, Jens Axboe [EMAIL PROTECTED] wrote: snip /** * sg_next - return the next scatterlist entry in a list @@ -43,10 +51,15 @@ static inline void sg_init_one(struct scatterlist *sg, const void *buf, */ static inline struct scatterlist *sg_next(struct

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 15:32 +0200, Jens Axboe [EMAIL PROTECTED] wrote: static inline struct scatterlist *sg_next(struct scatterlist *sg) { - sg++; - - if (unlikely(sg_is_chain(sg))) +#ifdef CONFIG_DEBUG_SG + BUG_ON(sg-sg_magic != SG_MAGIC); +#endif + if (sg_is_last(sg)) +

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread Benny Halevy
On Oct. 18, 2007, 16:05 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Oct 18 2007, Jens Axboe wrote: On Thu, Oct 18 2007, Benny Halevy wrote: return sg; } @@ -83,6 +96,9 @@ static inline struct scatterlist *sg_last(struct scatterlist *sgl, ret = sg; #endif +#ifdef

Re: [PATCH] x86-64: pci-gart iommu sg chaining zeroes wrong sg.

2007-09-30 Thread Benny Halevy
On Sep 27, 2007, 18:46 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Fri, 28 Sep 2007 01:38:27 +0900 > FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > >> This patch is for Jens' block tree (sg chaining branch). >> >> I don't have the hardware but this looks like a bug. >> >> --- >> From:

Re: [PATCH] x86-64: pci-gart iommu sg chaining zeroes wrong sg.

2007-09-30 Thread Benny Halevy
On Sep 27, 2007, 18:46 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Fri, 28 Sep 2007 01:38:27 +0900 FUJITA Tomonori [EMAIL PROTECTED] wrote: This patch is for Jens' block tree (sg chaining branch). I don't have the hardware but this looks like a bug. --- From: FUJITA Tomonori

Re: printk format "%4.4s"

2007-09-17 Thread Benny Halevy
On Sep 17, 2007, 2:57 +0200, shinkoi2005a <[EMAIL PROTECTED]> wrote: > Hi, all > > I have a question about printk format. > > Can printk format use "%4.4s"? Yes it can. The precision part of the format determines the max number of characters to copy from the string. The 4 byte signature array

Re: printk format %4.4s

2007-09-17 Thread Benny Halevy
On Sep 17, 2007, 2:57 +0200, shinkoi2005a [EMAIL PROTECTED] wrote: Hi, all I have a question about printk format. Can printk format use %4.4s? Yes it can. The precision part of the format determines the max number of characters to copy from the string. The 4 byte signature array might not

Re: [PATCH] Chaining sg lists for big IO commands v5

2007-05-21 Thread Benny Halevy
Jens Axboe wrote: > On Mon, May 21 2007, Jens Axboe wrote: >> On Fri, May 18 2007, Badari Pulavarty wrote: >>> On Fri, 2007-05-18 at 09:35 +0200, Jens Axboe wrote: On Thu, May 17 2007, Badari Pulavarty wrote: > On Thu, 2007-05-17 at 08:27 +0200, Jens Axboe wrote: >> On Wed, May 16

Re: [PATCH 8/12] x86-64: update iommu/dma mapping functions to sg helpers

2007-05-21 Thread Benny Halevy
Jens Axboe wrote: > On Thu, May 10 2007, Benny Halevy wrote: >> @@ -411,12 +406,13 @@ int gart_map_sg(struct device *dev, struct scatterlist >> *sg, int nents, int dir) >> boundary and the new one doesn't have an offset. */ >>

Re: [PATCH 8/12] x86-64: update iommu/dma mapping functions to sg helpers

2007-05-21 Thread Benny Halevy
Jens Axboe wrote: On Thu, May 10 2007, Benny Halevy wrote: @@ -411,12 +406,13 @@ int gart_map_sg(struct device *dev, struct scatterlist *sg, int nents, int dir) boundary and the new one doesn't have an offset. */ if (!iommu_merge || !nextneed

Re: [PATCH] Chaining sg lists for big IO commands v5

2007-05-21 Thread Benny Halevy
Jens Axboe wrote: On Mon, May 21 2007, Jens Axboe wrote: On Fri, May 18 2007, Badari Pulavarty wrote: On Fri, 2007-05-18 at 09:35 +0200, Jens Axboe wrote: On Thu, May 17 2007, Badari Pulavarty wrote: On Thu, 2007-05-17 at 08:27 +0200, Jens Axboe wrote: On Wed, May 16 2007, Badari Pulavarty

synchronization in usb_serial_put

2007-05-15 Thread Benny Halevy
this fix? >From b91b9cffd8bbb727c6480dfb18f79655806237e6 Mon Sep 17 00:00:00 2001 From: Benny Halevy <[EMAIL PROTECTED]> Date: Tue, 15 May 2007 10:41:31 +0300 Subject: [PATCH] fix usb_serial_put synchronization Signed-off-by: Benny Halevy <[EMAIL PROTECTED]> --- drivers/usb/seri

synchronization in usb_serial_put

2007-05-15 Thread Benny Halevy
this fix? From b91b9cffd8bbb727c6480dfb18f79655806237e6 Mon Sep 17 00:00:00 2001 From: Benny Halevy [EMAIL PROTECTED] Date: Tue, 15 May 2007 10:41:31 +0300 Subject: [PATCH] fix usb_serial_put synchronization Signed-off-by: Benny Halevy [EMAIL PROTECTED] --- drivers/usb/serial/usb-serial.c |4

  1   2   >