[irqchip: irq/irqchip-next] irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller

2021-02-04 Thread irqchip-bot for Bert Vermeulen
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 9f3a0f34b84ad1b9a8f2bdae44b66f16685b2143 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9f3a0f34b84ad1b9a8f2bdae44b66f16685b2143 Author:Bert Vermeulen

[irqchip: irq/irqchip-next] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support

2021-02-04 Thread irqchip-bot for Bert Vermeulen
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 4a2b92a5d3519fc2c1edda4d4aa0e05bff41e8de Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/4a2b92a5d3519fc2c1edda4d4aa0e05bff41e8de Author:Bert Vermeulen

Re: [PATCH] arch: mips: kernel: Made couple of spelling fixes and a sentence construction in smp.c

2021-02-01 Thread Bert Vermeulen
On 2/1/21 12:17 PM, Bhaskar Chowdhury wrote: > s/debugees/debuge's/ Definitely not. -- Bert Vermeulen b...@biot.com

[PATCH v4 0/2] Realtek RTL838x/RTL839x interrupt controller driver

2021-01-22 Thread Bert Vermeulen
routing symbols to device tree interrupt-map. Parsing is done similar to the renesas,rza1-irqc driver. Bert Vermeulen (2): dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller .../realtek,rtl-intc.yaml

[PATCH v4 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support

2021-01-22 Thread Bert Vermeulen
Reviewed-by: Rob Herring Signed-off-by: Bert Vermeulen --- .../realtek,rtl-intc.yaml | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml diff --git a/Documentation

[PATCH v4 2/2] irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller

2021-01-22 Thread Bert Vermeulen
This is a standard IRQ driver with only status and mask registers. The mapping from SoC interrupts (18-31) to MIPS core interrupts is done via an interrupt-map in device tree. Signed-off-by: Bert Vermeulen Signed-off-by: Birger Koblitz --- drivers/irqchip/Makefile | 1 + drivers

[PATCH] spdxcheck.py: Use Python 3

2021-01-21 Thread Bert Vermeulen
Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by. Signed-off-by: Bert Vermeulen --- scripts/spdxcheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index

[PATCH v5 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2021-01-20 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../bindings/spi/realtek,rtl-spi.yaml | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml diff --git a/Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml b

[PATCH v5 0/2] spi: Add support for Realtek RTL838x/RTL839x SoC SPI

2021-01-20 Thread Bert Vermeulen
to build the driver, since there's no point booting without the SPI-connected flash. v2: - Rewrote from spi-nor driver to regular spi driver, implementing only set_cs() and transfer_one(). (Thanks Chuanhong Guo!) Bert Vermeulen (2): dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller spi

[PATCH v5 2/2] spi: realtek-rtl: Add support for Realtek RTL838x/RTL839x SPI controllers

2021-01-20 Thread Bert Vermeulen
controller. The hardware appears to have a vestigial second chip-select control, but it hasn't been seen in the wild and is thus not supported. Signed-off-by: Bert Vermeulen --- drivers/spi/Makefile | 1 + drivers/spi/spi-realtek-rtl.c | 209 ++ 2 files changed

[PATCH v3 2/2] irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller

2021-01-20 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-realtek-rtl.c | 180 ++ 2 files changed, 181 insertions(+) create mode 100644 drivers/irqchip/irq-realtek-rtl.c diff --git a/drivers/irqchip/Makefile b/drivers/irqchip

[PATCH v3 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support

2021-01-20 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../realtek,rtl-intc.yaml | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml diff --git a/Documentation/devicetree/bindings/interrupt

[PATCH v3 0/2] Realtek RTL838x/RTL839x interrupt controller driver

2021-01-20 Thread Bert Vermeulen
v3: - Fixed syntax and maxItems problems in DT bindings. v2: - Addressed all comments by Marc Zyngier. - Moved interrupt routing symbols to device tree interrupt-map. Parsing is done similar to the renesas,rza1-irqc driver. Bert Vermeulen (2): dt-bindings: interrupt-controller: Add Realtek

[PATCH v4 4/5] dt-bindings: Add Cisco prefix to vendor list

2021-01-19 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 041ae90b0d8f..e6e3a51fc2e3 100644

[PATCH v4 2/5] Add support for Realtek RTL838x/RTL839x switch SoCs

2021-01-19 Thread Bert Vermeulen
are already written and functional, and work to get them upstream is already in progress. Signed-off-by: Birger Koblitz Signed-off-by: Bert Vermeulen Signed-off-by: John Crispin Signed-off-by: Sander Vanheule --- arch/mips/boot/dts/Makefile | 1 + arch/mips/boot/dts/realtek

[PATCH v4 1/5] dt-bindings: mips: Add support for RTL83xx SoC series

2021-01-19 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../devicetree/bindings/mips/realtek-rtl.yaml | 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/realtek-rtl.yaml diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b

[PATCH v4 0/5] Add support for Realtek RTL838x/RTL839x switch SoCs

2021-01-19 Thread Bert Vermeulen
. This will be further filled out, and bindings documented, as drivers get merged. Bert Vermeulen (5): dt-bindings: mips: Add support for RTL83xx SoC series Add support for Realtek RTL838x/RTL839x switch SoCs MIPS: Add Realtek RTL838x/RTL839x support as generic MIPS system dt-bindings: Add Cisco

[PATCH v4 5/5] mips: dts: Add support for Cisco SG220-26 switch

2021-01-19 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- arch/mips/Kconfig | 10 arch/mips/boot/dts/realtek/Makefile | 2 ++ arch/mips/boot/dts/realtek/cisco_sg220-26.dts | 25 +++ 3 files changed, 37 insertions(+) create mode 100644 arch/mips/boot/dts

[PATCH v4 3/5] MIPS: Add Realtek RTL838x/RTL839x support as generic MIPS system

2021-01-19 Thread Bert Vermeulen
This is just enough system to boot the kernel with earlycon working. Signed-off-by: Bert Vermeulen Signed-off-by: Sander Vanheule --- arch/mips/Kconfig | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 0a17bedf4f0d

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support

2021-01-06 Thread Bert Vermeulen
On 1/5/21 6:04 PM, Rob Herring wrote: On Mon, 04 Jan 2021 14:17:54 +0100, Bert Vermeulen wrote: Signed-off-by: Bert Vermeulen --- .../realtek,rtl-intc.yaml | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2021-01-05 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../bindings/spi/realtek,rtl-spi.yaml | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml diff --git a/Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml b

[PATCH v4 2/2] spi: realtek-rtl: Add support for Realtek RTL838x/RTL839x SoC SPI controllers

2021-01-05 Thread Bert Vermeulen
controller. The hardware appears to have a vestigial second chip-select control, but it hasn't been seen in the wild and is thus not supported. Signed-off-by: Bert Vermeulen --- MAINTAINERS | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-realtek-rtl.c | 206

[PATCH v4 0/2] spi: Add support for Realtek RTL838x/RTL839x SoC SPI

2021-01-05 Thread Bert Vermeulen
without the SPI-connected flash. v2: - Rewrote from spi-nor driver to regular spi driver, implementing only set_cs() and transfer_one(). (Thanks Chuanhong Guo!) Bert Vermeulen (2): dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller spi: realtek-rtl: Add support for Realtek RTL838x

Re: [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2021-01-05 Thread Bert Vermeulen
On 1/4/21 10:31 PM, Mark Brown wrote: On Fri, Jan 01, 2021 at 02:24:31PM +0100, Bert Vermeulen wrote: + compatible: +const: realtek,rtl-spi This is still just using rtl-spi as the compatible string, please address the feedback on the previous version. Mark, The rtl prefix really

[PATCH v2 2/2] irqchip: Add support for Realtek RTL838x/RTL839x IRQ controller

2021-01-04 Thread Bert Vermeulen
This is a standard IRQ driver with only status and mask registers. The mapping from SoC interrupts (18-31) to MIPS core interrupts is done via an interrupt-map in device tree. Signed-off-by: Bert Vermeulen --- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-realtek-rtl.c | 180

[PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support

2021-01-04 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../realtek,rtl-intc.yaml | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml diff --git a/Documentation/devicetree/bindings/interrupt

[PATCH v2 0/2] Realtek RTL838x/RTL839x IRQ driver

2021-01-04 Thread Bert Vermeulen
v2: - Addressed all comments by Marc Zyngier. - Moved interrupt routing symbols to device tree interrupt-map. Parsing is done similar to the renesas,rza1-irqc driver. Bert Vermeulen (2): dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support irqchip: Add support for Realtek

[PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2021-01-01 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- .../bindings/spi/realtek,rtl-spi.yaml | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml diff --git a/Documentation/devicetree/bindings/spi/realtek,rtl-spi.yaml b

[PATCH v3 2/2] spi: realtek-rtl: Add support for Realtek RTL838x/RTL839x SoC SPI controllers

2021-01-01 Thread Bert Vermeulen
controller. The hardware appears to have a vestigial second chip-select control, but it hasn't been seen in the wild and is thus not supported. Signed-off-by: Bert Vermeulen --- MAINTAINERS | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-realtek-rtl.c | 205

[PATCH v3 0/2] spi: Add support for Realtek RTL838x/RTL839x SoC SPI

2021-01-01 Thread Bert Vermeulen
-nor driver to regular spi driver, implementing only set_cs() and transfer_one(). (Thanks Chuanhong Guo!) Bert Vermeulen (2): dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller spi: realtek-rtl: Add support for Realtek RTL838x/RTL839x SoC SPI controllers .../bindings/spi/realtek

Re: [PATCH RESEND v2 2/2] Add support for Realtek RTL838x/RTL839x SoC SPI controllers

2021-01-01 Thread Bert Vermeulen
On 12/31/20 3:23 PM, Lukas Wunner wrote: On Wed, Dec 30, 2020 at 12:19:04AM +0100, Bert Vermeulen wrote: +static inline void wait_ready(struct rtspi *rtspi) +{ + while (!(readl(REG(RTL8380_SPI_SFCSR)) & RTL8380_SPI_SFCSR_RDY)) + ; +} I'd suggest calling cpu_r

Re: [PATCH RESEND v2 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2020-12-31 Thread Bert Vermeulen
On 12/30/20 2:51 PM, Mark Brown wrote: > On Wed, Dec 30, 2020 at 12:19:03AM +0100, Bert Vermeulen wrote: > >> +properties: >> + compatible: >> +const: realtek,spi > > It is possibled Realtek might make other SPI controllers, there should > be some more s

Re: [PATCH v3 1/4] Add support for Realtek RTL838x/RTL839x switch SoCs

2020-12-30 Thread Bert Vermeulen
On 12/30/20 10:22 PM, Bert Vermeulen wrote: The RTL838x/839x family of SoCs are Realtek switches with an embedded MIPS core. Oops, forgot patch version note: v3: - all code removed, the base system is now only device tree files and docs and some build config. - ioremap.h restored to the v1

[PATCH v3 1/4] Add support for Realtek RTL838x/RTL839x switch SoCs

2020-12-30 Thread Bert Vermeulen
are already written and functional, and work to get them upstream is already in progress. Signed-off-by: Birger Koblitz Signed-off-by: Bert Vermeulen Signed-off-by: John Crispin Signed-off-by: Sander Vanheule --- .../devicetree/bindings/mips/realtek-rtl.yaml | 24 ++ arch/mips/boot/dts

[PATCH v3 2/4] MIPS: Add Realtek RTL838x/RTL839x support as generic MIPS system

2020-12-30 Thread Bert Vermeulen
This is just enough system to boot the kernel with earlycon working. Signed-off-by: Bert Vermeulen Signed-off-by: Sander Vanheule --- arch/mips/Kconfig | 21 ++ arch/mips/generic/Platform | 1 + arch/mips/include/asm/realtek/ioremap.h | 29

[PATCH v3 3/4] dt-bindings: Add Cisco prefix to vendor list

2020-12-30 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen Signed-off-by: Sander Vanheule --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCH v3 4/4] dts: Add support for Cisco SG220-26 switch

2020-12-30 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen Signed-off-by: Sander Vanheule --- arch/mips/Kconfig | 10 +++ arch/mips/boot/dts/realtek/Makefile | 2 + arch/mips/boot/dts/realtek/cisco_sg220-26.dts | 81 +++ 3 files changed, 93 insertions(+) create mode

[PATCH RESEND v2 2/2] Add support for Realtek RTL838x/RTL839x SoC SPI controllers

2020-12-29 Thread Bert Vermeulen
controller. The hardware appears to have a vestigial second chip-select control, but it hasn't been seen in the wild and is thus not supported. Signed-off-by: Bert Vermeulen --- (resent due to mail trouble) Notes: v2: rewrote from spi-nor driver to regular spi driver, implementing only set_cs

[PATCH RESEND v2 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2020-12-29 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- (resent due to mail trouble) .../devicetree/bindings/spi/realtek,spi.yaml | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/realtek,spi.yaml diff --git a/Documentation/devicetree/bindings/spi

Re: [PATCH v2] Add support for Realtek RTL838x/RTL839x switch SoCs

2020-12-26 Thread Bert Vermeulen
On 12/23/20 5:18 PM, Marc Zyngier wrote: Marc, Thanks for reviewing. We will rework as needed, however: On Wed, 23 Dec 2020 15:06:24 +, Bert Vermeulen wrote: [...] +/* Interrupt numbers/bits */ +#define RTL8380_IRQ_UART0 31 +#define RTL8380_IRQ_UART1 30

[PATCH] arch: mips: Remove unused BOARD_INGENIC Kconfig option

2020-12-22 Thread Bert Vermeulen
Board support depends on MACH_INGENIC, not BOARD_INGENIC. Signed-off-by: Bert Vermeulen --- arch/mips/generic/Kconfig | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/mips/generic/Kconfig b/arch/mips/generic/Kconfig index 55d9aed7ced9..5216c850b7e2 100644 --- a/arch/mips/generic

Re: [PATCH] Add spi-nor driver for Realtek RTL838x/RTL839x switch SoCs

2020-12-20 Thread Bert Vermeulen
On 12/20/20 9:51 AM, Chuanhong Guo wrote: Hi! On Sun, Dec 20, 2020 at 7:01 AM Bert Vermeulen wrote: On 12/16/20 9:30 AM, tudor.amba...@microchip.com wrote: > On 12/15/20 11:46 PM, Bert Vermeulen wrote: >> This driver supports the spiflash core in all RTL838x/RTL839x SoCs, >>

Re: [PATCH] Add spi-nor driver for Realtek RTL838x/RTL839x switch SoCs

2020-12-19 Thread Bert Vermeulen
On 12/16/20 9:30 AM, tudor.amba...@microchip.com wrote: On 12/15/20 11:46 PM, Bert Vermeulen wrote: This driver supports the spiflash core in all RTL838x/RTL839x SoCs, and likely some older models as well (RTL8196C). Can we use SPIMEM and move this under drivers/spi/ instead? I wasn't aware

Re: [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs

2020-12-17 Thread Bert Vermeulen
On 12/15/20 11:11 PM, Oleksij Rempel wrote: Hello Bert, thank you for your work. Here are some comments.. Thanks for reviewing. I will send in a V2 with your comments all handled. I assume, after applying all needed changes, there will be no files within arch/mips/include/asm/mach-realtek

[PATCH] Add spi-nor driver for Realtek RTL838x/RTL839x switch SoCs

2020-12-15 Thread Bert Vermeulen
This driver supports the spiflash core in all RTL838x/RTL839x SoCs, and likely some older models as well (RTL8196C). Signed-off-by: Bert Vermeulen --- drivers/mtd/spi-nor/controllers/Kconfig | 7 + drivers/mtd/spi-nor/controllers/Makefile | 1 + .../spi-nor/controllers/rtl8380

[PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs

2020-12-15 Thread Bert Vermeulen
Signed-off-by: Bert Vermeulen --- arch/mips/Kbuild.platforms| 1 + arch/mips/Kconfig | 20 +++ arch/mips/include/asm/mach-realtek/ioremap.h | 29 arch/mips/include/asm/mach-realtek/irq.h | 69 .../include/asm/mach-realtek

[RESEND PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB

2020-10-06 Thread Bert Vermeulen
fault to addr_width of 3 for configurable widths") Signed-off-by: Bert Vermeulen Reviewed-by: Tudor Ambarus --- drivers/mtd/spi-nor/core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 03

[PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB

2020-10-04 Thread Bert Vermeulen
If a flash chip has more than 16MB capacity but its BFPT reports BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3. The check in spi_nor_set_addr_width() doesn't catch it because addr_width did get set. This fixes that check. Signed-off-by: Bert Vermeulen --- drivers/mtd

Re: [PATCH] mtd: spi-nor: Fix 3-or-4 address byte mode logic

2020-10-04 Thread Bert Vermeulen
On 10/2/20 9:50 AM, David Laight wrote: > From: Bert Vermeulen >> The SoCs I'm dealing with have an SPI_ADDR_SEL pin, indicating whether it >> should be in 3 or 4-byte mode. The vendor's hacked-up U-Boot sets the mode >> accordingly, as does their BSP. It seems to me like a m

Re: [PATCH] mtd: spi-nor: Fix 3-or-4 address byte mode logic

2020-10-01 Thread Bert Vermeulen
000) { + /* enable 4-byte addressing if the device exceeds 16MiB */ + nor->addr_width = 4; + } + Still fixes the general case, but I'm not sure what the SMPT parsing problem is -- would this still trigger it? -- Bert Vermeulen b...@biot.com

[PATCH] mtd: spi-nor: Fix 3-or-4 address byte mode logic

2020-09-30 Thread Bert Vermeulen
hen BFPT_DWORD1_ADDRESS_BYTES_3_OR_4 is found fixes the problem for all such cases. Signed-off-by: Bert Vermeulen --- drivers/mtd/spi-nor/sfdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c index e2a43d39eb5f..6fedc425bcf7 100

Re: [PATCH AUTOSEL 3.18 12/16] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-19 Thread Bert Kenward
dward Cree > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin I don't think this particularly needs to go to stable, but if it does it should be accompanied by: c65285428b6e ("sfc: initialise found bitmap in efx_ef10_mtd_probe") Bert. > --- > drivers/net/ethern

Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any

2019-02-14 Thread Bert Kenward
message fixups look good, but apart from that: Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index c3ad564..ed551f0 100644 >

Re: [PATCH] net: sfc: checks status of efx_mcdi_rpc

2019-01-02 Thread Bert Kenward
x_mcdi_rpc() already issues an error message on failure, so this doesn't add anything beyond that. Are you trying to address a particular issue with this patch? Thanks, Bert.

Re: [PATCH] net: sfc: remove redundant variable start

2017-11-09 Thread Bert Kenward
'start' > is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Bert Kenward <bkenw...@solarflare.com> Thanks Colin. > --- > drivers/net/ethernet/sfc/ptp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net

Re: [PATCH] net: sfc: remove redundant variable start

2017-11-09 Thread Bert Kenward
t; Signed-off-by: Colin Ian King Acked-by: Bert Kenward Thanks Colin. > --- > drivers/net/ethernet/sfc/ptp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c > index 56c2db398def..caa89bf7603e 100644 &

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

2017-10-24 Thread Bert Kenward
<linux-net-driv...@solarflare.com> > Cc: Edward Cree <ec...@solarflare.com> > Cc: Bert Kenward <bkenw...@solarflare.com> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Eric Dumazet <eduma...@google.com> > Cc: Jiri Pirko <j...@mellanox.com> &g

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

2017-10-24 Thread Bert Kenward
Edward Cree > Cc: Bert Kenward > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jiri Pirko > Cc: Jamal Hadi Salim > Cc: Ingo Molnar > Cc: net...@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/efx

Re: [PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-21 Thread Bert Kenward
pause frames (bidirectional and respond-only) */ ethtool_link_ksettings_add_link_mode(cmd, supported, Pause); ethtool_link_ksettings_add_link_mode(cmd, supported, Asym_Pause); if (LOOPBACK_INTERNAL(efx)) { cmd->base.speed = link_state->speed; cmd->base.duplex = link_state->fd ? DUPLEX_FULL : DUPLEX_HALF; } return 0; } Thanks, Bert.

Re: [PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-21 Thread Bert Kenward
ectional and respond-only) */ ethtool_link_ksettings_add_link_mode(cmd, supported, Pause); ethtool_link_ksettings_add_link_mode(cmd, supported, Asym_Pause); if (LOOPBACK_INTERNAL(efx)) { cmd->base.speed = link_state->speed; cmd->base.duplex = link_state->fd ? DUPLEX_FULL : DUPLEX_HALF; } return 0; } Thanks, Bert.

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
On 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes <trem...@gmail.com> Tested-by: Bert Kenward <bkenw...@solarflare.com> Acked

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
On 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Tested-by: Bert Kenward Acked-by: Bert Kenward

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
n 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes <trem...@gmail.com> Thanks Philippe. We'll get some testing done on this. Bert.

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
n 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Thanks Philippe. We'll get some testing done on this. Bert.

Re: [PATCH 11/15] sfc: use IS_ENABLED() instead of checking for built-in or module

2016-09-12 Thread Bert Kenward
of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Bert Kenward <bkenw...@solarflare.com> Thanks, Bert.

Re: [PATCH 11/15] sfc: use IS_ENABLED() instead of checking for built-in or module

2016-09-12 Thread Bert Kenward
of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas Acked-by: Bert Kenward Thanks, Bert.

Zprava pro vas!

2016-06-21 Thread Philp Bert
Jsem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: philp...@gmail.com

Zprava pro vas!

2016-06-21 Thread Philp Bert
Jsem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: philp...@gmail.com

Re: [PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-16 Thread Bert Kenward
] > ethernet/sfc/farch.c:124:731: error: comparison of unsigned expression < 0 is > always false [-Werror=type-limits] > > The macro and the caller are both correct, but we can avoid the > warning by changing the index variable to a signed type. > > Signed-off-by: Arnd Bergmann &

Re: [PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-16 Thread Bert Kenward
] > ethernet/sfc/farch.c:124:731: error: comparison of unsigned expression < 0 is > always false [-Werror=type-limits] > > The macro and the caller are both correct, but we can avoid the > warning by changing the index variable to a signed type. > > Signed-off-by: Arnd Bergma

[PATCH net v2] sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
7000-series SFC NICs connected with an SFP+ module currently fail to report any supported link speeds. Reported-by: Jarod Wilson <ja...@redhat.com> Signed-off-by: Bert Kenward <bkenw...@solarflare.com> --- drivers/net/ethernet/sfc/mcdi_port.c | 7 --- 1 file changed, 4 inse

[PATCH net v2] sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
7000-series SFC NICs connected with an SFP+ module currently fail to report any supported link speeds. Reported-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi_port.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
We probably shouldn't be claiming KX/KX4 here, because it isn't. I'll post an updated patch shortly. Bert.

Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
We probably shouldn't be claiming KX/KX4 here, because it isn't. I'll post an updated patch shortly. Bert.

Ahoj?

2016-05-23 Thread Bert
isem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: pbrt...@gmail.com

Ahoj?

2016-05-23 Thread Bert
isem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: pbrt...@gmail.com

[PATCH net] MAINTAINERS: net: update sfc maintainers

2016-04-25 Thread Bert Kenward
Add myself and Edward Cree as maintainers. Remove Shradha Shah, who is on extended leave. Cc: David S. Miller <da...@davemloft.net> Cc: Edward Cree <ec...@solarflare.com> Cc: Shradha Shah <ss...@solarflare.com> Signed-off-by: Bert Kenward <bkenw...@solarflare.com> --- MAI

[PATCH net] MAINTAINERS: net: update sfc maintainers

2016-04-25 Thread Bert Kenward
Add myself and Edward Cree as maintainers. Remove Shradha Shah, who is on extended leave. Cc: David S. Miller Cc: Edward Cree Cc: Shradha Shah Signed-off-by: Bert Kenward --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v4] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. Signed-off-by: Bert Vermeulen <b...@biot.com> --- Changes from v3: - added comment noting eth1 is connected to switch as well Changes from v2: - added linksys to filename - added make rule Changes from v1: - changed c

[PATCH v4] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. Signed-off-by: Bert Vermeulen --- Changes from v3: - added comment noting eth1 is connected to switch as well Changes from v2: - added linksys to filename - added make rule Changes from v1: - changed console to stdout-path

[PATCH v3] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. --- Changes from v2: - added linksys to filename - added make rule Changes from v1: - changed console to stdout-path - removed unnecesarry @0 from dsa node, and fixed dsa/switch node - fixed partitions according to the official

[PATCH v3] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. --- Changes from v2: - added linksys to filename - added make rule Changes from v1: - changed console to stdout-path - removed unnecesarry @0 from dsa node, and fixed dsa/switch node - fixed partitions according to the official

Re: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
On 04/02/2016 06:16 PM, Andrew Lunn wrote: On Sat, Apr 02, 2016 at 02:55:52PM +0200, Bert Vermeulen wrote: + * (c) 2013 Jonas Gorski <j...@openwrt.org> + * (c) 2013 Deutsche Telekom Innovation Laboratories + * (c) 2014 Luka Perkov <l...@openwrt.org> + * (c) 2014 Randy C. Wil

Re: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
On 04/02/2016 06:16 PM, Andrew Lunn wrote: On Sat, Apr 02, 2016 at 02:55:52PM +0200, Bert Vermeulen wrote: + * (c) 2013 Jonas Gorski + * (c) 2013 Deutsche Telekom Innovation Laboratories + * (c) 2014 Luka Perkov + * (c) 2014 Randy C. Will + * + * This file is licensed under the terms

[PATCH v2] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. --- arch/arm/boot/dts/kirkwood-viper.dts | 236 +++ 1 file changed, 236 insertions(+) create mode 100644 arch/arm/boot/dts/kirkwood-viper.dts diff --git a/arch/arm/boot/dts/kirkwood-viper.dts

[PATCH v2] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-04 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. --- arch/arm/boot/dts/kirkwood-viper.dts | 236 +++ 1 file changed, 236 insertions(+) create mode 100644 arch/arm/boot/dts/kirkwood-viper.dts diff --git a/arch/arm/boot/dts/kirkwood-viper.dts

[PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-02 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. The DSA port labels follow the switchdev convention. Signed-off-by: Bert Vermeulen <b...@biot.com> --- arch/arm/boot/dts/kirkwood-candyhouse.dts | 228 ++ 1 file changed, 228 insertions(+)

[PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500

2016-04-02 Thread Bert Vermeulen
This platform is based on a Marvell 88E6282 SoC and 88E6171 switch. The DSA port labels follow the switchdev convention. Signed-off-by: Bert Vermeulen --- arch/arm/boot/dts/kirkwood-candyhouse.dts | 228 ++ 1 file changed, 228 insertions(+) create mode 100644 arch

[PATCH] sfc: check warm_boot_count after other functions have been reset

2015-12-02 Thread Bert Kenward
as that is unnecessary since the PFs that have been reset will each receive an MC reboot notification. In that case, the driver re-reads the unchanged value. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[PATCH] sfc: check warm_boot_count after other functions have been reset

2015-12-02 Thread Bert Kenward
rmware doesn't change as that is unnecessary since the PFs that have been reset will each receive an MC reboot notification. In that case, the driver re-reads the unchanged value. Signed-off-by: Bert Kenward <bkenw...@solarflare.com> --- drivers/net/ethernet/sfc/ef10.c | 15 +-- 1

Re: [PATCH net-next] sfc: use ALIGN macro for aligning frame sizes

2015-12-01 Thread Bert Kenward
On 30/11/15 22:12, Jarod Wilson wrote: > Don't open-code it. > > CC: Solarflare linux maintainers > CC: Shradha Shah > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/net_driver.h | 3 ++- > 1 file

Re: [PATCH net-next] sfc: use ALIGN macro for aligning frame sizes

2015-12-01 Thread Bert Kenward
On 30/11/15 22:12, Jarod Wilson wrote: > Don't open-code it. > > CC: Solarflare linux maintainers <linux-net-driv...@solarflare.com> > CC: Shradha Shah <ss...@solarflare.com> > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson <ja...@redhat.co

Re: [PATCH 11/15] sfc: don't call dma_supported

2015-10-05 Thread Bert Kenward
On 03/10/15 16:19, Christoph Hellwig wrote: dma_set_mask already checks for a supported DMA mask before updating it, the call to dma_supported is redundant. Signed-off-by: Christoph Hellwig Acked-by: Bert Kenward -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 11/15] sfc: don't call dma_supported

2015-10-05 Thread Bert Kenward
On 03/10/15 16:19, Christoph Hellwig wrote: dma_set_mask already checks for a supported DMA mask before updating it, the call to dma_supported is redundant. Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Bert Kenward <bkenw...@solarflare.com> -- To unsubscribe from thi

Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id

2015-05-08 Thread Bert Vermeulen
On 05/08/2015 05:48 PM, Andrew Lunn wrote: > On Fri, May 08, 2015 at 04:18:49PM +0200, Bert Vermeulen wrote: >> When the bus id was supplied via a struct platform_device, the driver wasn't >> handling -1 to mean an unspecified id of the only instance of this driver, >>

Re: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards

2015-05-08 Thread Bert Vermeulen
On 05/08/2015 12:14 PM, Frans Klaver wrote: > On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen wrote: >> + >> + info->chip.priv = info; >> + info->mtd.priv = >chip; >> + info->mtd.owner = THIS_MODULE; > > If you should respin, c

[PATCH] net: mdio-gpio: Allow for unspecified bus id

2015-05-08 Thread Bert Vermeulen
When the bus id was supplied via a struct platform_device, the driver wasn't handling -1 to mean an unspecified id of the only instance of this driver, as the platform spec requires. Signed-off-by: Bert Vermeulen --- drivers/net/phy/mdio-gpio.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards

2015-05-08 Thread Bert Vermeulen
On 05/08/2015 12:14 PM, Frans Klaver wrote: On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen b...@biot.com wrote: + + info-chip.priv = info; + info-mtd.priv = info-chip; + info-mtd.owner = THIS_MODULE; If you should respin, could you add info-mtd.dev.parent = pdev-dev

[PATCH] net: mdio-gpio: Allow for unspecified bus id

2015-05-08 Thread Bert Vermeulen
When the bus id was supplied via a struct platform_device, the driver wasn't handling -1 to mean an unspecified id of the only instance of this driver, as the platform spec requires. Signed-off-by: Bert Vermeulen b...@biot.com --- drivers/net/phy/mdio-gpio.c | 5 - 1 file changed, 4

Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id

2015-05-08 Thread Bert Vermeulen
On 05/08/2015 05:48 PM, Andrew Lunn wrote: On Fri, May 08, 2015 at 04:18:49PM +0200, Bert Vermeulen wrote: When the bus id was supplied via a struct platform_device, the driver wasn't handling -1 to mean an unspecified id of the only instance of this driver, as the platform spec requires

  1   2   3   4   5   >