Re: [PATCH] net: stmmac: Use mutex instead of spinlock

s lock to be a spinlock, convert it to a mutex instead. Fixes: e6ea2d16fc61 ("net: stmmac: dwc-qos: Add Tegra186 support") Reported-by: Jon Hunter <jonath...@nvidia.com> Signed-off-by: Thierry Reding <tred...@nvidia.com> --- Tested on P3310 Tegra186 platform. Tested-by: Bhadra

Re: [PATCH] net: stmmac: Use mutex instead of spinlock

, convert it to a mutex instead. Fixes: e6ea2d16fc61 ("net: stmmac: dwc-qos: Add Tegra186 support") Reported-by: Jon Hunter Signed-off-by: Thierry Reding --- Tested on P3310 Tegra186 platform. Tested-by: Bhadram Varka -- Bhadram

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi Andrew/Jisheng, On 4/26/2018 6:10 PM, Andrew Lunn wrote: hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel requires WOL should be "stick". I see two different cases: Suspend/resume: The WoL state in the kernel is probably kept across such a cycle. If so, you would expect

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi Andrew/Jisheng, On 4/26/2018 6:10 PM, Andrew Lunn wrote: hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel requires WOL should be "stick". I see two different cases: Suspend/resume: The WoL state in the kernel is probably kept across such a cycle. If so, you would expect

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/26/2018 11:56 AM, Bhadram Varka wrote: Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou <jin

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/26/2018 11:56 AM, Bhadram Varka wrote: Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou <jingju@synaptics.com> If WOL event happene

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before

Re: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before enabling it. Signed-off-by:

Re: [PATCH] net: phy: marvell: clear wol event before setting it

HiJisheng, On 4/19/2018 2:39 PM, Jisheng Zhang wrote: On Thu, 19 Apr 2018 09:00:40 + Bhadram Varka wrote: Hi, -Original Message- From: Jisheng Zhang <jisheng.zh...@synaptics.com> Sent: Thursday, April 19, 2018 2:24 PM To: Bhadram Varka <vbhad...@nvidia.com> Cc:

Re: [PATCH] net: phy: marvell: clear wol event before setting it

HiJisheng, On 4/19/2018 2:39 PM, Jisheng Zhang wrote: On Thu, 19 Apr 2018 09:00:40 + Bhadram Varka wrote: Hi, -Original Message- From: Jisheng Zhang Sent: Thursday, April 19, 2018 2:24 PM To: Bhadram Varka Cc: Andrew Lunn ; Florian Fainelli ; David S. Miller ; net

RE: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, > -Original Message- > From: Jisheng Zhang <jisheng.zh...@synaptics.com> > Sent: Thursday, April 19, 2018 2:24 PM > To: Bhadram Varka <vbhad...@nvidia.com> > Cc: Andrew Lunn <and...@lunn.ch>; Florian Fainelli <f.faine...@gmail.com>; >

RE: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, > -Original Message- > From: Jisheng Zhang > Sent: Thursday, April 19, 2018 2:24 PM > To: Bhadram Varka > Cc: Andrew Lunn ; Florian Fainelli ; > David S. Miller ; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Jingju Hou > Subject: Re: [PATCH] net:

RE: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jisheng Zhang > Sent: Thursday, April 19, 2018 1:33 PM > To: Andrew Lunn ; Florian Fainelli ; > David S. Miller > Cc:

RE: [PATCH] net: phy: marvell: clear wol event before setting it

Hi, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jisheng Zhang > Sent: Thursday, April 19, 2018 1:33 PM > To: Andrew Lunn ; Florian Fainelli ; > David S. Miller > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jingju Hou > > Subject: [PATCH] net:

RE: [PATCH] net: phy: marvell: Enable interrupt function on LED2 pin

Hi Esben, -Original Message- From: netdev-ow...@vger.kernel.org On Behalf Of Esben Haabendal Sent: Thursday, April 05, 2018 7:05 PM To: net...@vger.kernel.org Cc: Esben Haabendal ; Rasmus Villemoes ; Andrew Lunn

RE: [PATCH] net: phy: marvell: Enable interrupt function on LED2 pin

Hi Esben, -Original Message- From: netdev-ow...@vger.kernel.org On Behalf Of Esben Haabendal Sent: Thursday, April 05, 2018 7:05 PM To: net...@vger.kernel.org Cc: Esben Haabendal ; Rasmus Villemoes ; Andrew Lunn ; Florian Fainelli ; open list Subject: [PATCH] net: phy: marvell:

[PATCH net-next] stmmac: copy unicast mac address to MAC registers

Currently stmmac driver not copying the valid ethernet MAC address to MAC registers. This patch takes care of updating the MAC register with MAC address. Signed-off-by: Bhadram Varka <vbhad...@nvidia.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 +++- 1 file c

[PATCH net-next] stmmac: copy unicast mac address to MAC registers

Currently stmmac driver not copying the valid ethernet MAC address to MAC registers. This patch takes care of updating the MAC register with MAC address. Signed-off-by: Bhadram Varka --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 +++- 1 file changed, 15 insertions(+), 1

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

Hi Jose, > -Original Message- > From: Jose Abreu [mailto:jose.ab...@synopsys.com] > Sent: Thursday, October 26, 2017 5:19 PM > To: Bhadram Varka <vbhad...@nvidia.com>; net...@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: Joao Pinto <joao.pi...@synopsys.

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

Hi Jose, > -Original Message- > From: Jose Abreu [mailto:jose.ab...@synopsys.com] > Sent: Thursday, October 26, 2017 5:19 PM > To: Bhadram Varka ; net...@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: Joao Pinto ; David S. Miller > ; Giuseppe Cavallaro

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

Hi Jose, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jose Abreu > Sent: Thursday, October 26, 2017 2:37 PM > To: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Jose Abreu ; Joao Pinto

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

Hi Jose, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jose Abreu > Sent: Thursday, October 26, 2017 2:37 PM > To: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Jose Abreu ; Joao Pinto > ; David S. Miller ; >