[PATCH 01/13] Don't touch fs_struct in drivers

2007-10-22 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]> The sound drivers and the pnpbios core test for current->root != NULL. This test seems to be unnecessary since we always have rootfs mounted before initializing the drivers. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharat

[PATCH 00/13] Use struct path in struct nameidata

2007-10-22 Thread Bharata B Rao
Hi Andrew, Could you please consider these patches for -mm ? These patches apply on 2.6.23-mm1 and are mostly a repost of earlier patches. Patches 1 to 11 have been Acked by Christoph Hellwig. Patch 12 is another instance where (vfsmnt, dentry) to path conversion is possible. Patch 13 is a

[PATCH 00/13] Use struct path in struct nameidata

2007-10-22 Thread Bharata B Rao
Hi Andrew, Could you please consider these patches for -mm ? These patches apply on 2.6.23-mm1 and are mostly a repost of earlier patches. Patches 1 to 11 have been Acked by Christoph Hellwig. Patch 12 is another instance where (vfsmnt, dentry) to path conversion is possible. Patch 13 is a

[PATCH 01/13] Don't touch fs_struct in drivers

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] The sound drivers and the pnpbios core test for current-root != NULL. This test seems to be unnecessary since we always have rootfs mounted before initializing the drivers. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL

[PATCH 02/13] Don't touch fs_struct in usermodehelper

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] This test seems to be unnecessary since we always have rootfs mounted before calling a usermodehelper. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Acked

[PATCH 03/13] Remove path_release_on_umount()

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] path_release_on_umount() should only be called from sys_umount(). I merged the function into sys_umount() instead of having in in namei.c. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Acked-by: Christoph Hellwig

[PATCH 04/13] Move struct path into its own header

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] Move the definition of struct path into its own header file for further patches. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Acked-by: Christoph Hellwig [EMAIL

[PATCH 06/13] Introduce path_put()

2007-10-22 Thread Bharata B Rao
] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- arch/alpha/kernel/osf_sys.c |2 arch/mips/kernel/sysirix.c |6 +- arch/parisc/hpux/sys_hpux.c |2 arch/powerpc/platforms/cell

[PATCH 07/13] Use path_put() in a few places instead of {mnt,d}put()

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] Use path_put() in a few places instead of {mnt,d}put() Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Acked-by: Christoph Hellwig [EMAIL PROTECTED] --- fs/afs

[PATCH 08/13] Introduce path_get()

2007-10-22 Thread Bharata B Rao
B Rao [EMAIL PROTECTED] Acked-by: Christoph Hellwig [EMAIL PROTECTED] --- fs/namei.c| 17 +++-- fs/unionfs/super.c|2 +- include/linux/namei.h |6 -- include/linux/path.h |1 + 4 files changed, 17 insertions(+), 9 deletions(-) --- a/fs/namei.c +++ b

[PATCH 09/13] Use struct path in fs_struct

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] * Use struct path in fs_struct. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Acked-by: Christoph Hellwig [EMAIL PROTECTED] --- fs/dcache.c | 34

[PATCH 10/13] Make set_fs_{root,pwd} take a struct path

2007-10-22 Thread Bharata B Rao
From: Jan Blunck [EMAIL PROTECTED] In nearly all cases the set_fs_{root,pwd}() calls work on a struct path. Change the function to reflect this and use path_get() here. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Bharata B Rao

[PATCH 11/13] Make __d_path() to take a struct path argument

2007-10-22 Thread Bharata B Rao
From: Andreas Gruenbacher [EMAIL PROTECTED] One less argument to __d_path. All callers to __d_path pass the dentry and vfsmount of a struct path to __d_path. Pass the struct path directly, instead. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL

[PATCH 12/13] Use struct path argument in proc_get_link()

2007-10-22 Thread Bharata B Rao
Replace the (vfsmnt, dentry) arguments in proc_inode operation proc_get_link() by struct path. Also, this should eventually allow do_proc_readlink() to call d_path() with a struct path argument. Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- fs/proc/base.c | 60

[PATCH 13/13] Rename {__}d_path() to {__}print_path() and fix comments

2007-10-22 Thread Bharata B Rao
Changes the name of d_path() and __d_path() to print_path() and __print_path() respectively and fixes the kerneldoc comments for print_path(). Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- arch/blackfin/kernel/traps.c |2 - drivers/md/bitmap.c |2 - drivers/usb

Re: [PATCH 00/13] Use struct path in struct nameidata

2007-10-22 Thread Bharata B Rao
On Mon, Oct 22, 2007 at 03:57:58PM +0200, Christoph Hellwig wrote: Any reason we've got this patchset posted by three people now? :) Two reasons actually ! - The set of patches posted by Jan last was on 2.6.23-rc8-mm1. So I thought let me help Andrew a bit by making them available on latest

Re: [RFC] Union Mount: Readdir approaches

2007-09-09 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 01:54:18PM -0400, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, "Josef 'Jeff' Sipek" writes: > > On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: > > > On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrot

Re: [RFC] Union Mount: Readdir approaches

2007-09-09 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 01:39:41PM -0400, Josef 'Jeff' Sipek wrote: > On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: > > On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: > > > > > > When the first readdir is issued: > > > - c

Re: [RFC] Union Mount: Readdir approaches

2007-09-09 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 01:39:41PM -0400, Josef 'Jeff' Sipek wrote: On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: When the first readdir is issued: - call vfs_readdir for every underlying opened dir

Re: [RFC] Union Mount: Readdir approaches

2007-09-09 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 01:54:18PM -0400, Erez Zadok wrote: In message [EMAIL PROTECTED], Josef 'Jeff' Sipek writes: On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: When the first readdir is issued

Re: [RFC] Union Mount: Readdir approaches

2007-09-07 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: > > When the first readdir is issued: > - call vfs_readdir for every underlying opened dir (file) object. > - store every entry to either the hash table for the result or the > whiteout, when the same-named entry didn't exist in

Re: [RFC] Union Mount: Readdir approaches

2007-09-07 Thread Bharata B Rao
On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: When the first readdir is issued: - call vfs_readdir for every underlying opened dir (file) object. - store every entry to either the hash table for the result or the whiteout, when the same-named entry didn't exist in the

[RFC] Union Mount: Readdir approaches

2007-09-06 Thread Bharata B Rao
Hi, Any filesystem namespace unification solution (Union Mount, Unionfs) needs to provide a unified or merged view of directory contents. Typically this is done by reading the directory entries of all the union'ed layers (starting from the top and working downwards) and merging the result by

[RFC] Union Mount: Readdir approaches

2007-09-06 Thread Bharata B Rao
Hi, Any filesystem namespace unification solution (Union Mount, Unionfs) needs to provide a unified or merged view of directory contents. Typically this is done by reading the directory entries of all the union'ed layers (starting from the top and working downwards) and merging the result by

Re: [RFC 19/26] union-mount: Make lookup work for union-mounted file systems

2007-08-08 Thread Bharata B Rao
On Mon, Jul 30, 2007 at 06:13:42PM +0200, Jan Blunck wrote: > On union-mounted file systems the lookup function must also visit lower layers > of the union-stack when doing a lookup. This patches add support for > union-mounts to cached lookups and real lookups. > > We have 3 different styles of

Re: [RFC 18/26] union-mount: Changes to the namespace handling

2007-08-08 Thread Bharata B Rao
ant to allow pivot_root of union mount points. Here is an attempt to achieve that. From: Bharata B Rao <[EMAIL PROTECTED]> Allow pivot_root to work with union mount points. If the current root filesystem is a union, then allow pivot_root only if it's last component is a root, which allows

Re: [RFC 18/26] union-mount: Changes to the namespace handling

2007-08-08 Thread Bharata B Rao
pivot_root of union mount points. Here is an attempt to achieve that. From: Bharata B Rao [EMAIL PROTECTED] Allow pivot_root to work with union mount points. If the current root filesystem is a union, then allow pivot_root only if it's last component is a root, which allows it to be detached

Re: [RFC 19/26] union-mount: Make lookup work for union-mounted file systems

2007-08-08 Thread Bharata B Rao
On Mon, Jul 30, 2007 at 06:13:42PM +0200, Jan Blunck wrote: On union-mounted file systems the lookup function must also visit lower layers of the union-stack when doing a lookup. This patches add support for union-mounts to cached lookups and real lookups. We have 3 different styles of

Re: [RFC 20/26] union-mount: Simple union-mount readdir implementation

2007-08-06 Thread Bharata B Rao
res = file->f_op->readdir(file, buf, filler); > + file_accessed(file); > + } > + mutex_unlock(>i_mutex); > + } > + > + return res; > +} Here you are doing readdir_union for all the directories under a union mount point, whic

Re: [RFC 20/26] union-mount: Simple union-mount readdir implementation

2007-08-06 Thread Bharata B Rao
-i_mutex); + } + + return res; +} Here you are doing readdir_union for all the directories under a union mount point, which is an overhead (building the readdir cache). Here is the fix: From: Bharata B Rao [EMAIL PROTECTED] Within a union mount point, there can be directories which don't

Re: [RFC 16/26] union-mount: Introduce union_mount structure

2007-08-05 Thread Bharata B Rao
ks if we append to union stack from outside of the union. A particular case I hit is with a 3 layer union with a subdir union between topmost and bottom layer. Now if you create the same-named directory in the middle layer from outside of this union, you hit the above BUG_ON. The below patch fixes this and

Re: [RFC 16/26] union-mount: Introduce union_mount structure

2007-08-05 Thread Bharata B Rao
union with a subdir union between topmost and bottom layer. Now if you create the same-named directory in the middle layer from outside of this union, you hit the above BUG_ON. The below patch fixes this and it applies on top of all of your patches. From: Bharata B Rao [EMAIL PROTECTED] Direct

Re: [RFC 00/26] VFS based Union Mount (V2)

2007-08-02 Thread Bharata B Rao
On Mon, Jul 30, 2007 at 06:13:23PM +0200, Jan Blunck wrote: > Here is another post of the VFS based union mount implementation. Unlike the > traditional mount which hides the contents of the mount point, union mounts > present the merged view of the mount point and the mounted filesytem. Doesn't

Re: [RFC 00/26] VFS based Union Mount (V2)

2007-08-02 Thread Bharata B Rao
On Mon, Jul 30, 2007 at 06:13:23PM +0200, Jan Blunck wrote: Here is another post of the VFS based union mount implementation. Unlike the traditional mount which hides the contents of the mount point, union mounts present the merged view of the mount point and the mounted filesytem. Doesn't

Re: [PATCH] Fix for bad lock balance in Containers

2007-06-27 Thread Bharata B Rao
On Tue, Jun 26, 2007 at 10:30:11AM +0530, Dhaval Giani wrote: > > --- linux-2.6.22-rc4/kernel/container.c 2007-06-13 15:38:32.0 > +0530 > +++ old/kernel/container.c2007-06-25 00:55:03.0 +0530 > @@ -995,6 +995,7 @@ static int container_get_sb(struct file_ >

Re: [PATCH] Fix for bad lock balance in Containers

2007-06-27 Thread Bharata B Rao
On Tue, Jun 26, 2007 at 10:30:11AM +0530, Dhaval Giani wrote: --- linux-2.6.22-rc4/kernel/container.c 2007-06-13 15:38:32.0 +0530 +++ old/kernel/container.c2007-06-25 00:55:03.0 +0530 @@ -995,6 +995,7 @@ static int container_get_sb(struct file_

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Erez Zadok <[EMAIL PROTECTED]> wrote: In message <[EMAIL PROTECTED]>, Jan Blunck writes: > On Tue, 19 Jun 2007 22:59:51 -0700, Arjan van de Ven wrote: > > > first of all I'm happy to see that people are still working on unionfs; > > I'd love to have functionality like this show up in

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Jan Blunck <[EMAIL PROTECTED]> wrote: On Wed, 20 Jun 2007 11:21:57 +0530, Bharata B Rao wrote: Well done. I like your approach much more than the simple chaining of dentries. When I told you about the idea of maintaining a list of objects I always though about one big str

Re: [RFC PATCH 3/4] Lookup changes to support union mount.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Jan Blunck <[EMAIL PROTECTED]> wrote: On Wed, 20 Jun 2007 11:23:26 +0530, Bharata B Rao wrote: > +/* > + * Looks for the given @name in dcache by walking through all the layers > + * of the union stack, starting from the top. > + * FIXME: If we don't find the dentr

Re: [RFC PATCH 2/4] Mount changes to support union mount.

2007-06-20 Thread Bharata B Rao
(replying from a different ID as you didn't copy me on reply) On 6/20/07, Jan Blunck <[EMAIL PROTECTED]> wrote: On Wed, 20 Jun 2007 11:22:41 +0530, Bharata B Rao wrote: > +/* > + * When propagating mount events to peer group, this is called under > + * vfsmount_lock. Hence u

Re: [RFC PATCH 2/4] Mount changes to support union mount.

2007-06-20 Thread Bharata B Rao
(replying from a different ID as you didn't copy me on reply) On 6/20/07, Jan Blunck [EMAIL PROTECTED] wrote: On Wed, 20 Jun 2007 11:22:41 +0530, Bharata B Rao wrote: +/* + * When propagating mount events to peer group, this is called under + * vfsmount_lock. Hence using GFP_ATOMIC

Re: [RFC PATCH 3/4] Lookup changes to support union mount.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Jan Blunck [EMAIL PROTECTED] wrote: On Wed, 20 Jun 2007 11:23:26 +0530, Bharata B Rao wrote: +/* + * Looks for the given @name in dcache by walking through all the layers + * of the union stack, starting from the top. + * FIXME: If we don't find the dentry in a upper layer, we

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Jan Blunck [EMAIL PROTECTED] wrote: On Wed, 20 Jun 2007 11:21:57 +0530, Bharata B Rao wrote: snip Well done. I like your approach much more than the simple chaining of dentries. When I told you about the idea of maintaining a list of dentry,vfsmount objects I always though about one

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Bharata B Rao
On 6/20/07, Erez Zadok [EMAIL PROTECTED] wrote: In message [EMAIL PROTECTED], Jan Blunck writes: On Tue, 19 Jun 2007 22:59:51 -0700, Arjan van de Ven wrote: first of all I'm happy to see that people are still working on unionfs; I'd love to have functionality like this show up in Linux.

[RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Directory listing support for union mounted directories. Modifies readdir()/getdents() to support union mounted directories. This patch adds support to readdir()/getdents() to read directory entries from all the directories of the union

[RFC PATCH 3/4] Lookup changes to support union mount.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Lookup changes to support union mount. Adds support for looking up dentries inside a union mount point. This patch modifies the do_lookup() routine to look beyond the top layer for union mount points/directories. Union mount versions of

[RFC PATCH 2/4] Mount changes to support union mount.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Mount changes to support union mount. Adds union mount support. This patch adds a new mount type for union mount (MNT_UNION) and changes the mount path to build a union stack during mount. The routines for supporting the creation, tra

[RFC PATCH 1/4] Union mount documentation.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Union mount documentation. Adds union mount documentation. Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- Documentation/union-mounts.txt | 232 + 1 files changed, 232 insertions(+) -

[RFC PATCH 0/4] New approach to VFS based union mount

2007-06-19 Thread Bharata B Rao
Hi, The earlier approach to VFS based union mounts posted here didn't work for all cases of mounts (specially bind mounts). Hence, I have worked on this new approach which is more generic and hopefully should work in most cases. This approach fundamentally changes the way union stacks are

[RFC PATCH 0/4] New approach to VFS based union mount

2007-06-19 Thread Bharata B Rao
Hi, The earlier approach to VFS based union mounts posted here didn't work for all cases of mounts (specially bind mounts). Hence, I have worked on this new approach which is more generic and hopefully should work in most cases. This approach fundamentally changes the way union stacks are

[RFC PATCH 1/4] Union mount documentation.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] Subject: Union mount documentation. Adds union mount documentation. Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- Documentation/union-mounts.txt | 232 + 1 files changed, 232 insertions(+) --- /dev/null +++ b

[RFC PATCH 2/4] Mount changes to support union mount.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] Subject: Mount changes to support union mount. Adds union mount support. This patch adds a new mount type for union mount (MNT_UNION) and changes the mount path to build a union stack during mount. The routines for supporting the creation, traversal

[RFC PATCH 3/4] Lookup changes to support union mount.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] Subject: Lookup changes to support union mount. Adds support for looking up dentries inside a union mount point. This patch modifies the do_lookup() routine to look beyond the top layer for union mount points/directories. Union mount versions of dcache

[RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] Subject: Directory listing support for union mounted directories. Modifies readdir()/getdents() to support union mounted directories. This patch adds support to readdir()/getdents() to read directory entries from all the directories of the union stack

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-23 Thread Bharata B Rao
On Tue, May 22, 2007 at 08:35:17AM -0400, Shaya Potter wrote: > Bharata B Rao wrote: > > > >In case of regular files, when we copyup a file, we are actually preventing > >any writes to the lower layers (which we have designated as read only). > > > >Applying the

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-23 Thread Bharata B Rao
On Tue, May 22, 2007 at 08:35:17AM -0400, Shaya Potter wrote: Bharata B Rao wrote: In case of regular files, when we copyup a file, we are actually preventing any writes to the lower layers (which we have designated as read only). Applying the same logic to devices, what do we achieve

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-22 Thread Bharata B Rao
On Tue, May 22, 2007 at 08:25:16AM +0200, Jan Engelhardt wrote: > > On May 22 2007 08:43, Bharata B Rao wrote: > >On Fri, May 18, 2007 at 09:47:31AM -0400, Shaya Potter wrote: > >> Bharata B Rao wrote: > >> > >> > > >> >Not really. This

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-22 Thread Bharata B Rao
On Tue, May 22, 2007 at 08:25:16AM +0200, Jan Engelhardt wrote: On May 22 2007 08:43, Bharata B Rao wrote: On Fri, May 18, 2007 at 09:47:31AM -0400, Shaya Potter wrote: Bharata B Rao wrote: Not really. This is called during copyup of a file residing in a lower layer

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-21 Thread Bharata B Rao
On Fri, May 18, 2007 at 09:47:31AM -0400, Shaya Potter wrote: > Bharata B Rao wrote: > > > > >Not really. This is called during copyup of a file residing in a lower > >layer. And that is done only for regular files. > > That is broken. But it only breaks the sema

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-21 Thread Bharata B Rao
On Fri, May 18, 2007 at 09:47:31AM -0400, Shaya Potter wrote: Bharata B Rao wrote: Not really. This is called during copyup of a file residing in a lower layer. And that is done only for regular files. That is broken. But it only breaks the semantics (in other cases we allow writes only

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-18 Thread Bharata B Rao
On Wed, May 16, 2007 at 09:57:28AM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:13, Bharata B Rao wrote: > >+ > >+if (flag & 0x2) { > >+error = union_copyup(nd, flag); > >+if (error) > >+goto exit; >

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-18 Thread Bharata B Rao
On Tue, May 15, 2007 at 10:00:45AM -0400, Trond Myklebust wrote: > On Mon, 2007-05-14 at 15:12 +0530, Bharata B Rao wrote: > > From: Jan Blunck <[EMAIL PROTECTED]> > > Subject: Union-mount lookup > > > > Modifies the vfs lookup routines to wo

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-18 Thread Bharata B Rao
On Wed, May 16, 2007 at 09:57:28AM +0200, Jan Engelhardt wrote: On May 14 2007 15:13, Bharata B Rao wrote: + +if (flag 0x2) { +error = union_copyup(nd, flag); +if (error) +goto exit; +} What I dislike (and that also goes for fs

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-18 Thread Bharata B Rao
On Tue, May 15, 2007 at 10:00:45AM -0400, Trond Myklebust wrote: On Mon, 2007-05-14 at 15:12 +0530, Bharata B Rao wrote: From: Jan Blunck [EMAIL PROTECTED] Subject: Union-mount lookup Modifies the vfs lookup routines to work with union mounted directories. The existing lookup

Re: Convert namespace_sem to a mutex

2007-05-17 Thread Bharata B Rao
On Thu, May 17, 2007 at 06:00:46AM +0100, Al Viro wrote: > On Thu, May 17, 2007 at 10:20:41AM +0530, Bharata B Rao wrote: > > From: Bharata B Rao <[EMAIL PROTECTED]> > > > > namespace_sem is a rwsem. It is acquired as read sem at only one place(used > > by /pro

Re: Convert namespace_sem to a mutex

2007-05-17 Thread Bharata B Rao
On Thu, May 17, 2007 at 06:00:46AM +0100, Al Viro wrote: On Thu, May 17, 2007 at 10:20:41AM +0530, Bharata B Rao wrote: From: Bharata B Rao [EMAIL PROTECTED] namespace_sem is a rwsem. It is acquired as read sem at only one place(used by /proc/mounts, /proc/pid/mounts and /proc/pid

Convert namespace_sem to a mutex

2007-05-16 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> namespace_sem is a rwsem. It is acquired as read sem at only one place(used by /proc/mounts, /proc//mounts and /proc//mountstats). In all other cases it is acquired as a write sem. So, as there is not more than one reader for this sem, this can be a g

Re: 2.6.22-rc1-mm1

2007-05-16 Thread Bharata B Rao
On 5/16/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Andy Whitcroft wrote: > Getting this on both x86 and x86_64 boxes, they are the older boxen so > likely older compilers: Please give the gcc version number. > CC arch/x86_64/boot/memory.o > arch/i386/boot/memory.c: In function

Re: 2.6.22-rc1-mm1

2007-05-16 Thread Bharata B Rao
On 5/16/07, H. Peter Anvin [EMAIL PROTECTED] wrote: Andy Whitcroft wrote: Getting this on both x86 and x86_64 boxes, they are the older boxen so likely older compilers: Please give the gcc version number. CC arch/x86_64/boot/memory.o arch/i386/boot/memory.c: In function

Convert namespace_sem to a mutex

2007-05-16 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] namespace_sem is a rwsem. It is acquired as read sem at only one place(used by /proc/mounts, /proc/pid/mounts and /proc/pid/mountstats). In all other cases it is acquired as a write sem. So, as there is not more than one reader for this sem, this can

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:57:24AM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:12, Bharata B Rao wrote: > > > >+struct dentry * d_lookup_single(struct dentry *parent, struct qstr *name) > >+{ > >+struct dentry *dentry; > >+un

Re: [RFC][PATCH 7/14] Union-mount mounting

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:29:39AM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:11, Bharata B Rao wrote: > > > >TODO: bind and move mounts aren't yet supported with union mounts. > > Are the semantics already set? Not yet. > > >@@ -294,6 +294,10 @@

Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 10:38:46PM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:09, Bharata B Rao wrote: > > > >Introduce MNT_UNION, MS_UNION and FS_WHT flags. There are the necessary flags > >for doing > > > >mount /dev/hda3 /mnt -o union > &g

Re: [RFC][PATCH 5/14] Introduce union stack

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 03:40:57PM -0700, Badari Pulavarty wrote: > On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote: < snip > > > + > > +/* Shouldn't be called with last reference to union_info */ > > +static inline void union_put_and_unlo

Re: [RFC][PATCH 13/14] ext3 whiteout support

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 01:16:57PM -0700, Badari Pulavarty wrote: > On Mon, 2007-05-14 at 15:14 +0530, Bharata B Rao wrote: > > From: Bharata B Rao <[EMAIL PROTECTED]> > > Subject: ext3 whiteout support > > > > Introduce whiteout support for ext3. > > &

Re: [RFC][PATCH 13/14] ext3 whiteout support

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 01:16:57PM -0700, Badari Pulavarty wrote: On Mon, 2007-05-14 at 15:14 +0530, Bharata B Rao wrote: From: Bharata B Rao [EMAIL PROTECTED] Subject: ext3 whiteout support Introduce whiteout support for ext3. Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Signed

Re: [RFC][PATCH 5/14] Introduce union stack

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 03:40:57PM -0700, Badari Pulavarty wrote: On Mon, 2007-05-14 at 15:10 +0530, Bharata B Rao wrote: snip + +/* Shouldn't be called with last reference to union_info */ +static inline void union_put_and_unlock(struct union_info *uinfo) +{ + union_put(uinfo

Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 10:38:46PM +0200, Jan Engelhardt wrote: On May 14 2007 15:09, Bharata B Rao wrote: Introduce MNT_UNION, MS_UNION and FS_WHT flags. There are the necessary flags for doing mount /dev/hda3 /mnt -o union You need additional patches for util-linux

Re: [RFC][PATCH 7/14] Union-mount mounting

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:29:39AM +0200, Jan Engelhardt wrote: On May 14 2007 15:11, Bharata B Rao wrote: TODO: bind and move mounts aren't yet supported with union mounts. Are the semantics already set? Not yet. @@ -294,6 +294,10 @@ static struct vfsmount *clone_mnt(struct

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:57:24AM +0200, Jan Engelhardt wrote: On May 14 2007 15:12, Bharata B Rao wrote: +struct dentry * d_lookup_single(struct dentry *parent, struct qstr *name) +{ +struct dentry *dentry; +unsigned long seq; + +do { +seq

Re: [RFC][PATCH 9/14] Union-mount readdir

2007-05-14 Thread Bharata B Rao
On Mon, May 14, 2007 at 12:43:43PM +0200, Carsten Otte wrote: > On 5/14/07, Bharata B Rao <[EMAIL PROTECTED]> wrote: > >+/* This is a copy from fs/readdir.c */ > >+struct getdents_callback { > >+ struct linux_dirent __user *current_dir; > >+ str

[RFC][PATCH 13/14] ext3 whiteout support

2007-05-14 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: ext3 whiteout support Introduce whiteout support for ext3. Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/ext3/dir.c |2 - fs/ext3/name

[RFC][PATCH 14/14] tmpfs whiteout support

2007-05-14 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]> Subject: tmpfs whiteout support Introduce whiteout support to tmpfs. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- mm/shmem.c |9 - 1 files changed, 8 insertions(+), 1 del

[RFC][PATCH 11/14] VFS whiteout handling

2007-05-14 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]> Subject: VFS whiteout handling Introduce white-out handling in the VFS. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/inode.c| 17 + fs/namei.c

[RFC][PATCH 12/14] ext2 whiteout support

2007-05-14 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]> Subject: ext2 whiteout support Introduce whiteout support to ext2. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/ext2/dir.c |2 ++ fs/ext2/namei.c | 17

[RFC][PATCH 9/14] Union-mount readdir

2007-05-14 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Union mount readdir This modifies the readdir()/getdents() routines to read directory entries from toplevel and the lower directories of a union and present a merged view. The directory entries are read starting from the top

[RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-14 Thread Bharata B Rao
copied to the topmost union layer first. This patch uses the do_splice_direct() for doing the in-kernel file copy. Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c| 46 + fs/union.c

[RFC][PATCH 8/14] Union-mount lookup

2007-05-14 Thread Bharata B Rao
search for the pathname in the entire union mounted stack. Also they have been modified to setup the union stack during lookup from dcache cache and from real_lookup(). Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/dcache.c|

[RFC][PATCH 7/14] Union-mount mounting

2007-05-14 Thread Bharata B Rao
Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/namespace.c| 90 ++ fs/union.c| 71 +++ include/linux/fs.h|3 + include/li

[RFC][PATCH 5/14] Introduce union stack

2007-05-14 Thread Bharata B Rao
From: Jan Blunck <[EMAIL PROTECTED]> Subject: Introduce union stack. Adds union stack infrastructure to the dentry structure and provides locking routines to walk the union stack. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]>

[RFC][PATCH 6/14] Union-mount dentry reference counting

2007-05-14 Thread Bharata B Rao
y: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/dcache.c | 43 ++- fs/dnotify.c |5 fs/inotify.c |8 + fs/namei.c | 42 +-- fs/namespace.c

[RFC][PATCH 3/14] Add the whiteout file type

2007-05-14 Thread Bharata B Rao
delete (white-out) files by creating a file with this file type. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- include/linux/stat.h |2 ++ 1 files changed, 2 insertions(+) --- a/include/linux/stat.h +++ b/include/linux/sta

[RFC][PATCH 4/14] Add config options for union mount

2007-05-14 Thread Bharata B Rao
needs some work. printk'ing isn't the right method for getting good debugging output. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/Kconfig | 16 + include/linux/un

[RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-14 Thread Bharata B Rao
ed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/namespace.c| 14 +- include/linux/fs.h|2 ++ include/linux/mount.h |1 + 3 files changed, 16 insertions(+), 1 deletion(-) --- a/fs/namespace.c +++ b/fs/nam

[RFC][PATCH 1/14] Add union mount documentation

2007-05-14 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Add union mount documentation. This is an attempt to document some of the implementation details and issues of union mount. Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- D

[RFC][PATCH 0/14] VFS based Union Mount(v1)

2007-05-14 Thread Bharata B Rao
Here is another post of vfs based union mount implementation. Union mount provides the filesytem namespace unification feature. Unlike the traditional mounts which hide the contents of the mount point, the union mount presents the merged view of the mount point and the mounted filesytem. These

[RFC][PATCH 0/14] VFS based Union Mount(v1)

2007-05-14 Thread Bharata B Rao
Here is another post of vfs based union mount implementation. Union mount provides the filesytem namespace unification feature. Unlike the traditional mounts which hide the contents of the mount point, the union mount presents the merged view of the mount point and the mounted filesytem. These

[RFC][PATCH 1/14] Add union mount documentation

2007-05-14 Thread Bharata B Rao
From: Bharata B Rao [EMAIL PROTECTED] Subject: Add union mount documentation. This is an attempt to document some of the implementation details and issues of union mount. Signed-off-by: Bharata B Rao [EMAIL PROTECTED] Signed-off-by: Jan Blunck [EMAIL PROTECTED] --- Documentation/union

[RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-14 Thread Bharata B Rao
-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- fs/namespace.c| 14 +- include/linux/fs.h|2 ++ include/linux/mount.h |1 + 3 files changed, 16 insertions(+), 1 deletion(-) --- a/fs/namespace.c +++ b/fs/namespace.c @@ -442,6 +442,7

[RFC][PATCH 3/14] Add the whiteout file type

2007-05-14 Thread Bharata B Rao
-out) files by creating a file with this file type. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Bharata B Rao [EMAIL PROTECTED] --- include/linux/stat.h |2 ++ 1 files changed, 2 insertions(+) --- a/include/linux/stat.h +++ b/include/linux/stat.h @@ -10,6 +10,7 @@ #if defined

<    1   2   3   >