Re: [PATCH 2/3] remoteproc: qcom: wcss: populate driver data for IPQ6018

2021-03-17 Thread Bjorn Andersson
On Fri 29 Jan 11:11 CST 2021, Gokul Sriram Palanisamy wrote: > Populate hardcoded param using driver data for IPQ6018 SoCs. > > Signed-off-by: Gokul Sriram Palanisamy > --- > drivers/remoteproc/qcom_q6v5_wcss.c | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-) > >

Re: [PATCH v8 2/9] remoteproc: qcom: Add secure PIL support

2021-03-17 Thread Bjorn Andersson
On Fri 29 Jan 23:20 CST 2021, Gokul Sriram Palanisamy wrote: > IPQ8074 uses secure PIL. Hence, adding the support for the same. > Sorry for not giving this a proper review before Gokul, I've look at it but been uncertain about what feedback to offer. > Signed-off-by: Gokul Sriram Palanisamy >

Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc

2021-03-17 Thread Bjorn Andersson
On Wed 17 Mar 09:02 CDT 2021, Marc Zyngier wrote: > On Wed, 17 Mar 2021 09:48:09 +, > Maulik Shah wrote: > > > > Hi Marc, > > > > On 3/17/2021 2:47 PM, Marc Zyngier wrote: > > > On Wed, 17 Mar 2021 05:29:54 +, > > > Maulik Shah wrote: > > >> PDC interrupt controller driver do not use

[PATCH] drm/msm: Remove need for reiterating the compatibles

2021-03-16 Thread Bjorn Andersson
des the DPU platform_device. Replace the open coded test for compatibles with a check against the match data of the mdss device to save others this trouble in the future. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/msm_drv.c | 15 +-- 1 file changed, 9 insertions(+)

Re: [PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS

2021-03-13 Thread Bjorn Andersson
On Sat 13 Mar 15:46 CST 2021, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-03-08 21:51:51) > > Add miscellaneous nodes to boot the Wireless Processor Subsystem on > > Maybe add (WPSS) after the name so we know they're related. > > > SC7280 SoCs. > > > > Signed-off-by: Sibi Sankar > > --- >

[PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

2021-03-12 Thread Bjorn Andersson
and then piecemeal patch this up on the various devices, push the configuration of these regions out to the individual device dts files. Signed-off-by: Bjorn Andersson --- Changes since v1: - Added lost memory-region to the db845c wlan node, as spotted by Doug. arch/arm64/boot/dts/qcom/sdm845

[PATCH v2 2/2] arm64: dts: qcom: sdm850-yoga: Enable IPA

2021-03-12 Thread Bjorn Andersson
), so some shuffling and trial and error was used to come up with acceptable regions. With this in order, enable the IPA device. Signed-off-by: Bjorn Andersson --- Changes since v1: - None .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 26 +-- 1 file changed, 13 inserti

[PATCH v2] remoteproc: qcom_q6v5_mss: Validate p_filesz in ELF loader

2021-03-12 Thread Bjorn Andersson
5_mss: Validate modem blob firmware size before load") Signed-off-by: Bjorn Andersson --- Changes since v1: - Don't just break the loop, goto release_firmware. - Release seg_fw as well. drivers/remoteproc/qcom_q6v5_mss.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-12 Thread Bjorn Andersson
On Thu 11 Mar 04:40 CST 2021, satya priya wrote: > Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, > GPIOs, RTC and other PMIC infra modules for SC7280. > Overall this looks good, just two small things below. > Signed-off-by: satya priya > --- > This patch depends on base DT and

Re: [PATCH] dt-bindings: mailbox: Add compatible for SM8350 IPCC

2021-03-12 Thread Bjorn Andersson
On Thu 11 Mar 23:12 CST 2021, Vinod Koul wrote: Adding Jassi as recipient. Please let Vinod know if you want him to resend this patch to you. (I send a patch for MAINTAINERS yesterday) > Add the compatible string for SM8350 IPCC block on this SoC > Reviewed-by: Bjorn Andersson Regards,

Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings

2021-03-12 Thread Bjorn Andersson
Resource Power Manager. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Mahesh Sivasubramanian > Signed-off-by: Lina Iyer > Signed-off-by: Maulik Shah > Reviewed-by: Rob Herring > Reviewed-by: Bjorn Andersson > Reviewed-by: Stephen Boyd > --- > .../bindin

Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings

2021-03-12 Thread Bjorn Andersson
On Mon 08 Feb 18:23 CST 2021, Stephen Boyd wrote: > Quoting Maulik Shah (2021-02-04 06:21:45) > > + > > +description: > > + Always On Processor/Resource Power Manager maintains statistics of the > > SoC > > + sleep modes involving powering down of the rails and oscillator clock. > > + > > +

Re: [PATCH net] net: ipa: terminate message handler arrays

2021-03-12 Thread Bjorn Andersson
; > Fix this bug, by properly terminating the message handler arrays > provided when QMI handles are set up by the IPA driver. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 530f9216a9537 ("soc: qcom: ipa: AP/modem communications") > Reported-by: Sujit Kautkar > Sig

[PATCH 2/2] arm64: dts: qcom: sm8350: Add wakeup-parent to tlmm

2021-03-11 Thread Bjorn Andersson
Now that TLMM has the wakeup table, specify the Power Domain Controller to be the wakeup-parent of TLMM. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 1/2] pinctrl: qcom: sm8350: add GPIO wakeup interrupt map

2021-03-11 Thread Bjorn Andersson
From: Lina Iyer GPIOs that can be configured as wakeup sources, have their interrupt lines routed to PDC interrupt controller. Provide the interrupt map of the GPIO to its wakeup capable interrupt parent. Signed-off-by: Lina Iyer Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

2021-03-11 Thread Bjorn Andersson
> thought. The things that pre-enable does are well defined and well > understood and there should be no problems with doing them early nor > with doing them before userspace requests anything. > > Fixes: 58074b08c04a ("drm/bridge: ti-sn65dsi86: Read EDID blob over DDC") >

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix

2021-03-11 Thread Bjorn Andersson
On Thu 04 Mar 17:52 CST 2021, Douglas Anderson wrote: > This patch is _only_ code motion to prepare for the patch > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > refclk") and make it easier to understand. > Reviewed-by: Bjorn Andersson Regard

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling

2021-03-11 Thread Bjorn Andersson
the enable case anyway so why not avoid the extra > call? > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/

Re: [PATCH 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants

2021-03-11 Thread Bjorn Andersson
On Fri 05 Mar 00:29 CST 2021, satya priya wrote: > Add PM7325, PM8350c, PMK8350 and PMR735A compatibles for GPIO > support. > Acked-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: satya priya > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 > 1 file

[PATCH 3/5] soc: qcom: wcnss_ctrl: Introduce local variable "dev"

2021-03-11 Thread Bjorn Andersson
Introduce a local variable to carry the struct device *, to reduce the line lengths in the next patch. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/wcnss_ctrl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom

[PATCH 4/5] soc: qcom: wcnss_ctrl: Allow reading firmware-name from DT

2021-03-11 Thread Bjorn Andersson
to the old filename if the property isn't specified. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/wcnss_ctrl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c index 358526b9de06..2a06d631e415 100644

[PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi

2021-03-11 Thread Bjorn Andersson
Enable the modem and WiFi subsystems and specify msm8916 specific firmware path for these and the WCNSS control service. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- 2 files changed, 13

[PATCH 2/5] wcn36xx: Allow firmware name to be overridden by DT

2021-03-11 Thread Bjorn Andersson
to upload this blob, so rather than specifying the same information in both nodes wcn36xx reads the string from the parent's of_node. Signed-off-by: Bjorn Andersson --- This patch can be applied independently of the others, but relates to the acceptance of the addition to the DT binding (in patch 1/5

[PATCH 1/5] dt-bindings: soc: qcom: wcnss: Add firmware-name property

2021-03-11 Thread Bjorn Andersson
The WCNSS needs firmware which differs between platforms, and possibly boards. Add a new property "firmware-name" to allow the DT to specify the platform/board specific path to this firmware file. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/soc/qcom/qcom,wcn

[PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-11 Thread Bjorn Andersson
The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others needs platform-, and perhaps even board-, specific firmware. Add support for providing this in devicetree. Bjorn Andersson (5): dt-bindings: soc: qcom: wcnss: Add firmware-name property wcn36xx: Allow firmware name

[PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing

2021-03-11 Thread Bjorn Andersson
Failing to read the "firmware-name" DT property without informing the developer is annoying, add some helpful debug prints. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_q6v5_mss.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v2] remoteproc: qcom: wcnss: Allow specifying firmware-name

2021-03-11 Thread Bjorn Andersson
Introduce a firmware-name property, in order to be able to support device/platform specific firmware for the wireless connectivity subsystem; in line with other Qualcomm remoteproc drivers. Acked-by: Mathieu Poirier Signed-off-by: Bjorn Andersson --- Changes since v1: - Rebased patch - Added

[PATCH] remoteproc: qcom: wcnss: Fix race with iris probe

2021-03-11 Thread Bjorn Andersson
DEFER back to the wcnss device's probe. Reported-by: Anibal Limon Reported-by: Loic Poulain Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_wcnss.c | 52 drivers/remoteproc/qcom_wcnss.h | 4 +- drivers/remoteproc/qcom_wcnss_iris.c | 120 +---

Re: [PATCH 0/6] rpmsg: enable the use of the rpmsg_char device for the Virtio backend

2021-03-11 Thread Bjorn Andersson
part of the char dev and create the rpmsg_ctrl.c >file > - Introduce the RPMSG_CREATE_DEV_IOCTL IOCTL to instantiate RPMsg devices > > > [1]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523 > Reviewed-by: Bjorn Andersson Regards, Bjo

Re: [PATCHv2 2/2] iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

2021-03-11 Thread Bjorn Andersson
On Sat 27 Feb 07:53 CST 2021, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2021-02-27 00:44, Bjorn Andersson wrote: > > On Fri 26 Feb 12:23 CST 2021, Rob Clark wrote: > > > > > > The current logic picks one of: > > 1) is the compatible menti

Re: [PATCH] arm64: dts: sc7280: Add qspi, qupv3_0 and qupv3_1 nodes

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 15:54 CST 2021, Doug Anderson wrote: > Hi, > > On Wed, Mar 10, 2021 at 7:41 PM Roja Rani Yarubandi > wrote: > > > > +_cs0 { > > + pinconf { > > + pins = "gpio15"; > > + bias-disable; > > + }; > > The "pinconf" / "pinmux" subnode shouldn't

Re: [PATCH 0/9] qcom/sc7280: Enable various hardware blocks on SC7280 SoC

2021-03-11 Thread Bjorn Andersson
On Thu 25 Feb 03:30 CST 2021, Sai Prakash Ranjan wrote: > This series enables various hardware blocks such as LLCC, IPCC, AOSS QMP > and Coresight on SC7280 SoC. > > This series is dependent on the base support added for SC7280 in [1]. > I've picked some of these patches... It would be

[PATCH] MAINTAINERS: Add DT bindings directory to mailbox

2021-03-11 Thread Bjorn Andersson
DT bindings related to mailbox drivers are typically picked by the mailbox maintainer, so add the binding folder to the maintainers entry to make sure get_maintainer finds it. Signed-off-by: Bjorn Andersson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 11:38 CST 2021, Mathieu Poirier wrote: > On Thu, Mar 11, 2021 at 01:26:25AM +, Peng Fan (OSS) wrote: > > Mathieu, > > > > > Subject: Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M > > > > > > On Sat, Mar 06, 2021 at 07:24:15PM +0800, peng@oss.nxp.com wrote:

Re: [PATCH 3/3] dt-bindings: mfd: Add compatible for pmk8350 rtc

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 01:29 CST 2021, satya priya wrote: > Add compatible string for pmk8350 rtc support. > Reviewed-by: Bjorn Andersson If you add this before doing the yaml binding migration it might be possible for the maintainer to merge the functional additions while we're still

Re: [PATCH 2/3] dt-bindings: mfd: Convert pm8xxx bindings to yaml

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 01:29 CST 2021, satya priya wrote: > Convert pm8xxx rtc bindings from .txt to .yaml format. > Wonderful initiative, thank you! > Signed-off-by: satya priya > --- > .../devicetree/bindings/mfd/qcom-pm8xxx.txt| 99 --- >

Re: [PATCH 1/3] rtc: pm8xxx: Add RTC support for PMIC PMK8350

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 01:29 CST 2021, satya priya wrote: > Add the comaptible string for PMIC PMK8350. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: satya priya > --- > drivers/rtc/rtc-pm8xxx.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff

Re: [PATCH v3 07/14] dt-bindings: arm-smmu: Add compatible for SC7280 SoC

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 05:25 CST 2021, Rajendra Nayak wrote: > From: Sai Prakash Ranjan > > Add the SoC specific compatible for SC7280 implementing > arm,mmu-500. > > Signed-off-by: Sai Prakash Ranjan > Signed-off-by: Rajendra Nayak > Reviewed-by: Stephen Boyd > Acked-by: Rob Herring This should

Re: [PATCH v3 10/14] dt-bindings: watchdog: Add compatible for SC7280 SoC

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 05:25 CST 2021, Rajendra Nayak wrote: > From: Sai Prakash Ranjan > > Add compatible for watchdog timer on SC7280 SoC. > > Signed-off-by: Sai Prakash Ranjan > Signed-off-by: Rajendra Nayak > Reviewed-by: Stephen Boyd > Acked-by: Rob Herring > --- And this should be merged

Re: [PATCH v3 04/14] dt-bindings: qcom,pdc: Add compatible for sc7280

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 05:25 CST 2021, Rajendra Nayak wrote: > Add the compatible string for sc7180 SoC from Qualcomm > > Signed-off-by: Rajendra Nayak > Reviewed-by: Stephen Boyd > Acked-by: Rob Herring This would better be merged through the irq tree, so please repost it alone. Thanks, Bjorn >

Re: [PATCH 00/13] Add binding updates and DT files for SC7280 SoC

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 03:15 CST 2021, Rajendra Nayak wrote: > > On 3/11/2021 5:43 AM, Bjorn Andersson wrote: > > On Fri 12 Feb 01:28 CST 2021, Rajendra Nayak wrote: > > > > > This series includes a few minor binding updates and base device tree > > > files (to boot

Re: [PATCH V1 2/6] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 04:06 CST 2021, schow...@codeaurora.org wrote: > On 2021-03-11 04:49, Bjorn Andersson wrote: > > On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > > > > > The DCC is a DMA Engine designed to capture and store data > > > during system cr

Re: [PATCH V1 2/6] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)

2021-03-11 Thread Bjorn Andersson
On Thu 11 Mar 00:19 CST 2021, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2021-03-11 04:49, Bjorn Andersson wrote: > > On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > > > > > The DCC is a DMA Engine designed to capture and store data > > > d

Re: [PATCH 00/13] Add binding updates and DT files for SC7280 SoC

2021-03-10 Thread Bjorn Andersson
On Fri 12 Feb 01:28 CST 2021, Rajendra Nayak wrote: > This series includes a few minor binding updates and base device tree > files (to boot to shell) for SC7280 SoC and the IDP board using this SoC. > > The series is dependent on a few driver patches to merge first, for > gcc, rpmhcc and

Re: [PATCH v3 2/2] arm64: dts: qcom: sm8250: fix display nodes

2021-03-10 Thread Bjorn Andersson
On Tue 16 Feb 15:14 CST 2021, Dmitry Baryshkov wrote: > Except for the compatible value changes: > > Reviewed-by: Dmitry Baryshkov > > May I suggest to split the compatibility name changes into a separate > series from this patch (without it the patch stands a chance of being > accepted into

Re: [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs

2021-03-10 Thread Bjorn Andersson
ent way of specifying the function config > in Device-Tree, add the missing three definitions in the > appropriate dt-bindings header as: > GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}. > Reviewed-by: Bjorn Andersson > Signed-off-by: AngeloGioacchino Del Regno > > Signed-off-by: K

Re: [PATCH v7 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 15:10 CST 2021, Mathieu Poirier wrote: > When a remote processor that was attached to is stopped, special care > must be taken to make sure the shutdown process is similar to what > it would be had it been started by the remoteproc core. > > This patch takes care of that by making

Re: [PATCH v2] gpio: wcd934x: Fix shift-out-of-bounds error

2021-03-10 Thread Bjorn Andersson
4:14 > > Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller") > Signed-off-by: Srinivas Kandagatla > Reviewed-by: Andy Shevchenko Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > changes since v1: > - removed unnecessary dump stack from log

Re: [PATCH V1 4/6] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > The DCC is a DMA engine designed to store register values either in > case of a system crash or in case of software triggers manually done > by the user. Using DCC hardware and the sysfs interface of the driver > the user can exploit

Re: [PATCH V1 2/6] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > The DCC is a DMA Engine designed to capture and store data > during system crash or software triggers. The DCC operates > based on link list entries which provides it with data and > addresses and the function it needs to perform. These >

Re: [PATCH V1 1/6] dt-bindings: Added the yaml bindings for DCC

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Signed-off-by: Souradeep Chowdhury > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 > ++ > 1 file changed,

Re: [PATCH RESEND 0/2] Common protected-clocks implementation

2021-03-10 Thread Bjorn Andersson
On Tue 09 Mar 02:03 CST 2021, Rasmus Villemoes wrote: > On 03/09/2020 06.00, Samuel Holland wrote: > > Stephen, Maxime, > > > > You previously asked me to implement the protected-clocks property in a > > driver-independent way: > > > > https://www.spinics.net/lists/arm-kernel/msg753832.html > >

Re: [PATCH] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 01:37 CST 2021, Rakesh Pillai wrote: > Add the WPSS remoteproc node in dts for > PIL loading. > > Signed-off-by: Rakesh Pillai > --- > - This change is dependent on the below patch series > 1) https://lore.kernel.org/patchwork/project/lkml/list/?series=487403 > 2)

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 01:28 CST 2021, Rakesh Pillai wrote: > Add WPSS PIL loading support for SC7280 SoCs. > Acked-by: Bjorn Andersson But can you please follow up with a patch that converts this to yaml? Regards, Bjorn > Signed-off-by: Rakesh Pillai > --- > .../bindings/remotepr

Re: [PATCH 2/2] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 01:28 CST 2021, Rakesh Pillai wrote: > Add support for PIL loading of WPSS processor for SC7280 > WPSS boot will be requested by the wifi driver and hence > disable auto-boot for WPSS. Also add a separate shutdown > sequence handler for WPSS. > > Signed-off-by: Rakesh Pillai > ---

Re: [RFC PATCH v1] Bluetooth: hci_qca: Add device_may_wakeup support

2021-03-10 Thread Bjorn Andersson
On Wed 10 Mar 05:41 CST 2021, Venkata Lakshmi Narayana Gubba wrote: > Added device_may_wakeup() support. This would be an excellent place to describe _why_ this is necessary, instead of just repeating $subject. Something along the lines of the comment in the patch. Regards, Bjorn > >

[PATCH] dt-bindings: arm: qcom: Add SM8350 HDK

2021-03-09 Thread Bjorn Andersson
Document the SM8350 Hardware Development Kit (HDK). Reported-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree

Re: [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations

2021-03-09 Thread Bjorn Andersson
On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote: > Fix SDC1_RCLK configurations which are in a different register so fix the > offset from 0xb3000 to 0xb3004. > > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > Acked-by: Bjorn Andersson R

Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

2021-03-09 Thread Bjorn Andersson
by: Veerabhadrarao Badiganti > Signed-off-by: Rajendra Nayak Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sc728

Re: [PATCH V1] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

2021-03-09 Thread Bjorn Andersson
On Tue 09 Mar 13:18 CST 2021, Shaik Sajida Bhanu wrote: > Add nodes for eMMC and SD card on sc7280. > > Signed-off-by: Shaik Sajida Bhanu > > --- > This change is depends on the below patch series: > https://lore.kernel.org/lkml/1613114930-1661-1-git-send-email-rna...@codeaurora.org/ >

Re: [PATCH 34/41] arm64: dts: qcom: sdm630-nile: Configure WCN3990 Bluetooth

2021-03-08 Thread Bjorn Andersson
On Sat 27 Feb 04:40 CST 2021, Konrad Dybcio wrote: > > > From: AngeloGioacchino Del Regno > > From: Martin Botka > > > That got caught in rebasing madness.. Should any additional mistakes appear, > I'll send a V2. > Patches looks good, but I'm a little bit confused about author and s-o-b

[PATCH v2] arm64: dts: qcom: Introduce SM8350 HDK

2021-03-08 Thread Bjorn Andersson
Add initial DTS for the Snapdragon 888 Mobile Hardware Development Kit, aka SM8350 HDK. This initial version describes debug UART, UFS storage, the three USB connectors and remoteprocs. Reviewed-by: Konrad Dybcio Signed-off-by: Bjorn Andersson --- Changes since v1: - Added 'regulator-allow-set

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm8350 and friends

2021-03-08 Thread Bjorn Andersson
On Mon 08 Mar 10:48 CST 2021, Vinod Koul wrote: > Add support for the PM8350, PM8350B, PM8350C, PMK8350, PMR735A and > PMR735B GPIO support to the Qualcomm PMIC GPIO binding. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Vinod Koul > --- > .../devicetre

Re: [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add support for PM8350 and friends

2021-03-08 Thread Bjorn Andersson
On Mon 08 Mar 10:48 CST 2021, Vinod Koul wrote: > Add support for the PM8350, PM8350B, PM8350C, PMK8350, PMR735A and > PMR735B GPIO support to the Qualcomm PMIC GPIO driver. > Acked-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Vinod Koul > --- > drivers/pinctrl

Re: [PATCH] arm64: dts: qcom: Introduce SM8350 HDK

2021-03-08 Thread Bjorn Andersson
On Sat 06 Mar 04:34 CST 2021, Konrad Dybcio wrote: > Hi! > > > > + vreg_l5b_0p88: ldo5 { > > + regulator-name = "vreg_l5b_0p88"; > > + regulator-min-microvolt = <88>; > > + regulator-max-microvolt = <888000>; > > +

Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-07 Thread Bjorn Andersson
On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote: > Quoting Elliot Berman (2021-03-05 10:18:09) > > On 3/3/2021 10:14 PM, Stephen Boyd wrote: > > > Quoting Elliot Berman (2021-03-03 19:35:08) > > >> > > >> On 2/23/2021 1:45 PM, Stephen Boyd wrote: > > >>> These scm calls are never used outside of

Re: [PATCH] arm64: dts: add support for the Pixel 2 XL

2021-03-05 Thread Bjorn Andersson
On Fri 05 Mar 15:35 CST 2021, Caleb Connolly wrote: Please add "qcom: " to $subject as well. > Add a minimal devicetree capable of booting on the Pixel 2 XL MSM8998 > device. > > It's currently possible to boot the device into postmarketOS with USB > networking, however the display panel

[PATCH] arm64: defconfig: Enable Qualcomm SM8350 TLMM and GCC

2021-03-05 Thread Bjorn Andersson
Enable the Qualcomm SM8350 TLMM pinctrl and GCC clock drivers. They need to be builtin to ensure that the UART is allowed to probe before user space needs a console. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64

[PATCH] arm64: dts: qcom: Introduce SM8350 HDK

2021-03-05 Thread Bjorn Andersson
Add initial DTS for the Snapdragon 888 Mobile Hardware Development Kit, aka SM8350 HDK. This initial version describes debug UART, UFS storage, the three USB connectors and remoteprocs. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom

Re: [PATCH 1/6] firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool

2021-03-05 Thread Bjorn Andersson
uot;firmware: qcom: scm: add OCMEM lock/unlock interface") > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/firmware/qcom_scm.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/firmw

Re: [PATCH net-next 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_ul_csum_header > structure with a single two-byte (big endian) structure member, > and use field masks to encode or get values within it. > > Previously rmnet_map_ipv4_ul_csum_header() would update

Re: [PATCH net-next 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_dl_csum_trailer > structure with a single one-byte field, using constant field masks > to encode or get at embedded values. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Sign

Re: [PATCH net-next 4/6] net: qualcomm: rmnet: use field masks instead of C bit-fields

2021-03-04 Thread Bjorn Andersson
and use the functions defined in , > along with field mask constants to extract or assign values within > that field. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > .../ethernet/qualcomm/rmnet/rmnet_handlers.c | 5 ++-- > .../ethe

Re: [PATCH net-next 3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

2021-03-04 Thread Bjorn Andersson
ocal > variable of the map header pointer type to the socket buffer data > pointer, and derereference that pointer variable. > > In "rmnet_map_data.c", use sizeof(object) rather than sizeof(type) > in one spot. Also,there's no need to byte swap 0; it's all zeros > irrespective

Re: [PATCH net-next 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-04 Thread Bjorn Andersson
art_offset = htons(offset); > > - offset = htons((__force u16)(skb_transport_header(skb) - Just curious, why does this require a __force, or even a cast? Regardless, your proposed way of writing it is easier to read. Reviewed-by: Bjorn Andersson Regards, Bjorn > -

Re: [PATCH net-next 1/6] net: qualcomm: rmnet: mark trailer field endianness

2021-03-04 Thread Bjorn Andersson
always assumed to be zero, and the length is > taken from the other packet headers. So making these fields > explicitly big endian has no effect on the behavior of the code. > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/linux/if_rmne

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Bjorn Andersson
Carpenter Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") > Signed-off-by: Jonathan Marek > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] remoteproc: sysfs: Use scnprintf instead of sprintf

2021-03-03 Thread Bjorn Andersson
On Wed 03 Mar 14:01 CST 2021, Siddharth Gupta wrote: > From: Raghavendra Rao Ananta > > For security reasons scnprintf() is preferred over sprintf(). > Hence, convert the remoteproc's sysfs show functions accordingly. > Thanks for the patch Siddharth. There's no possibility for these calls

[PATCH] usb: dwc3: Flip condition guarding power_supply_put()

2021-03-03 Thread Bjorn Andersson
The condition guarding the power_supply_put() calls in error and removal paths are backwards, resulting in a guaranteed NULL pointer dereference if no power supply was acquired. Fixes: 59fa3def35de ("usb: dwc3: add a power supply for current control") Signed-off-by: Bjorn Andersson --

Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.

2021-03-02 Thread Bjorn Andersson
On Tue 02 Mar 09:47 CST 2021, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter > wrote: > > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: > > uninitialized symbol 'strength'. > > > > Old smatch warnings: > >

Re: [PATCHv2 2/2] iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

2021-02-26 Thread Bjorn Andersson
On Fri 26 Feb 12:23 CST 2021, Rob Clark wrote: > On Fri, Feb 26, 2021 at 9:24 AM Bjorn Andersson > wrote: > > > > On Fri 26 Feb 03:55 CST 2021, Sai Prakash Ranjan wrote: > > > > > Adreno(GPU) SMMU and APSS(Application Processor SubSystem) SMMU > > > bot

Re: [PATCHv2 2/2] iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

2021-02-26 Thread Bjorn Andersson
On Fri 26 Feb 03:55 CST 2021, Sai Prakash Ranjan wrote: > Adreno(GPU) SMMU and APSS(Application Processor SubSystem) SMMU > both implement "arm,mmu-500" in some QTI SoCs and to run through > adreno smmu specific implementation such as enabling split pagetables > support, we need to match the

[GIT PULL] rpmsg updates for v5.12

2021-02-24 Thread Bjorn Andersson
. Alex Elder (2): rpmsg: glink: fix some kerneldoc comments rpmsg: glink: add include of header file Bjorn Andersson (1): rpmsg: glink: Guard qcom_glink_ssr_notify() with correct config drivers/rpmsg/qcom_glink_ssr.c | 17

[GIT PULL] remoteproc updates for v5.12

2021-02-24 Thread Bjorn Andersson
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git tags/rproc-v5.12 for you to fetch changes up to

[GIT PULL] hwspinlock updated for v5.12

2021-02-24 Thread Bjorn Andersson
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git tags/hwlock-v5.12 for you to fetch changes up to

Re: [PATCH] pinctrl: qcom: sc7280: Add GPIO wakeup interrupt map

2021-02-22 Thread Bjorn Andersson
On Thu 11 Feb 22:59 CST 2021, Rajendra Nayak wrote: > From: Maulik Shah > > GPIOs that can be configured as wakeup sources, have their > interrupt lines routed to PDC interrupt controller. > > Provide the interrupt map of the GPIO to its wakeup capable > interrupt parent

Re: [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-18 Thread Bjorn Andersson
On Thu 18 Feb 14:55 CST 2021, Kuogee Hsieh wrote: > Allow supported link rate to be limited to the value specified at > dtsi. If it is not specified, then link rate is derived from dpcd > directly. Below are examples, > link-rate = <162000> for max link rate limited at 1.62G > link-rate =

Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350 CPUfreq compatible

2021-02-18 Thread Bjorn Andersson
On Tue 16 Feb 05:12 CST 2021, Vinod Koul wrote: > Add the CPUfreq compatible for SM8350 SoC along with note for using the > specific compatible for SoCs > > Signed-off-by: Vinod Koul > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt | 4 +++- > 1 file changed, 3

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Bjorn Andersson
On Fri 12 Feb 11:33 CST 2021, Serge Semin wrote: > On Wed, Feb 10, 2021 at 10:33:26PM +0300, Serge Semin wrote: > > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > > > On Wed

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Bjorn Andersson
On Wed 10 Feb 13:33 CST 2021, Serge Semin wrote: > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > > On Wed,

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs

2021-02-11 Thread Bjorn Andersson
On Wed 10 Feb 04:45 CST 2021, Vinod Koul wrote: > Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS > DT binding. > > Signed-off-by: Vinod Koul > --- > .../devicetree/bindings/remoteproc/qcom,adsp.txt | 12 > 1 file changed, 12 insertions(+) > > diff

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Bjorn Andersson
On Wed 10 Feb 12:41 CST 2021, Jakub Kicinski wrote: > On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > > This may be a stupid suggestion,

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Bjorn Andersson
naming so not to fail on the legacy DTS-files passed to the > > > newer kernels. > > > > > > Signed-off-by: Serge Semin > > > Reviewed-by: Bjorn Andersson > > > --- > > > drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > > > 1 file changed, 2 insertions

Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

2021-02-09 Thread Bjorn Andersson
On Tue 09 Feb 17:25 CST 2021, Doug Anderson wrote: > Hi, > > On Tue, Feb 9, 2021 at 8:09 AM Bjorn Andersson > wrote: > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > > b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > > index 216a74f0057c..2f44

Re: [PATCH] dmaengine: qcom: bam_dma: Add LOCK and UNLOCK flag bit support

2021-02-09 Thread Bjorn Andersson
On Mon 01 Feb 09:50 CST 2021, mda...@codeaurora.org wrote: > On 2021-02-01 12:13, Vinod Koul wrote: > > On 01-02-21, 11:52, mda...@codeaurora.org wrote: > > > On 2021-02-01 11:35, Vinod Koul wrote: > > > > On 27-01-21, 23:56, mda...@codeaurora.org wrote: > > > > > > > The actual LOCK/UNLOCK

Re: [GIT PULL 2/3] ARM: dts: samsung: DTS for v5.12

2021-02-09 Thread Bjorn Andersson
On Tue 09 Feb 08:27 CST 2021, Rob Herring wrote: > On Mon, Feb 8, 2021 at 5:10 PM Alexandre Belloni > wrote: > > > > On 08/02/2021 23:14:02+0100, Arnd Bergmann wrote: > > > On Mon, Feb 8, 2021 at 10:35 PM Alexandre Belloni > > > wrote: > > > > On 08/02/2021 20:52:37+0100, Arnd Bergmann wrote: >

[PATCH 2/2] arm64: dts: qcom: sdm850-yoga: Enable IPA

2021-02-09 Thread Bjorn Andersson
), so some shuffling and trial and error was used to come up with acceptable regions. With this in order, enable the IPA device. Signed-off-by: Bjorn Andersson --- .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --

[PATCH 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

2021-02-09 Thread Bjorn Andersson
and then piecemeal patch this up on the various devices, push the configuration of these regions out to the individual device dts files. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi| 89 +-- arch/arm64/boot/dts/qcom/sdm845-db845c.dts| 85

Re: [GIT PULL 2/3] ARM: dts: samsung: DTS for v5.12

2021-02-08 Thread Bjorn Andersson
On Sat 06 Feb 13:47 CST 2021, Geert Uytterhoeven wrote: > Hi Arnd, > > On Sat, Feb 6, 2021 at 3:36 PM Arnd Bergmann wrote: > > That said, I'm still not happy about the patch we discussed in the > > other email thread[1] and I'd like to handle it a little more strictly in > > the future, but I

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2021-02-08 Thread Bjorn Andersson
On Mon 08 Feb 11:21 CST 2021, Kalle Valo wrote: > Amit Pundir writes: > > > Hi Kalle, > > > > On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote: > >> > >> This is firmware version specific, right? There's also enum > >> ath10k_fw_features which is embedded within firmware-N.bin, we could add > >>

<    1   2   3   4   5   6   7   8   9   10   >