Re: [PATCH -next] arch/x86: Return value from notify_die should to be checked.

2020-06-22 Thread Bo YU
On Mon, Jun 22, 2020 at 5:46 PM Peter Zijlstra wrote: > > On Mon, Jun 22, 2020 at 11:17:51AM +0200, Boris Petkov wrote: > > On June 22, 2020 10:52:23 AM GMT+02:00, Alexandre Chartre > > wrote: > > > So the appropriate change to make Coverity happy > > > > Or we can stop "fixing" the kernel in

Re: [PATCH] arch/x86: Check return value from a notify_die() call

2020-06-21 Thread Bo YU
On Sun, Jun 21, 2020 at 10:40 PM Markus Elfring wrote: > > I propose to improve the previous patch subject. > > > > This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN) > > > > FIXES: c94082656dac7(x86: Use enum instead of literals for trap values) > > Is the following tag

[PATCH -next] arch/x86: Return value from notify_die should to be checked.

2020-06-21 Thread Bo YU
This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN) FIXES: c94082656dac7(x86: Use enum instead of literals for trap values) Signed-off-by: Bo YU --- arch/x86/kernel/traps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/traps.c b/arch/x86

[PATCH -next] RDMA/rtrs: fix potential resources leaks

2020-06-19 Thread Bo YU
Dev is returned from allocation function kzalloc but it does not free it in out_err path. Detected by CoverityScan, CID# 1464569: (Resource leak) Fixes: c0894b3ea69d3("RDMA/rtrs: core: lib functions shared between client and server modules") Signed-off-by: Bo YU --- drivers/infi

Re: [PATCH 5.4 020/142] tipc: block BH before using dst_cache

2020-06-01 Thread Bo YU
On Tue, Jun 2, 2020 at 2:08 AM Greg Kroah-Hartman wrote: > > From: Eric Dumazet > > [ Upstream commit 1378817486d6860f6a927f573491afe65287abf1 ] > > dst_cache_get() documents it must be used with BH disabled. > > sysbot reported : syzbot? > > BUG: using smp_processor_id() in preemptible

Re: [PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod

2020-05-15 Thread Bo YU
On Fri, May 15, 2020 at 5:36 PM Johannes Thumshirn wrote: > > On 15/05/2020 11:24, Bo YU wrote: > > Hi, > > On Fri, May 15, 2020 at 5:03 PM Johannes Thumshirn > > wrote: > >> > >> On 15/05/2020 04:17, Bo YU wrote: > >>> It adds spin_lo

Re: [PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod

2020-05-15 Thread Bo YU
Hi, On Fri, May 15, 2020 at 5:03 PM Johannes Thumshirn wrote: > > On 15/05/2020 04:17, Bo YU wrote: > > It adds spin_lock() in add_block_entry() but out path does not unlock > > it. > > Which call path doesn't unlock it? There is an out_unlock label with a > spin_unloc

[PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod

2020-05-14 Thread Bo YU
It adds spin_lock() in add_block_entry() but out path does not unlock it. Detected by CoversityScan, CID# 1463343:(Missing unlock) Fixes: fd708b81d972a (Btrfs: add a extent ref verify tool) Signed-off-by: Bo YU --- fs/btrfs/ref-verify.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCH -next] block/genhd: align title and output

2020-04-29 Thread Bo YU
On Sun, Apr 26, 2020 at 8:22 PM Bo YU wrote: > > Before the patch: > > major minor #blocks name > > 2540 57671680 vda > 2541 57670656 vda1 > > After the patch: > > major minor #blocksname > > 254 0 57671680 vda > 2

[tip:perf/urgent] perf bpf: Return value with unlocking in perf_env__find_btf()

2019-05-02 Thread tip-bot for Bo YU
Commit-ID: 2e712675ffd1331bb527dfc851b0e98cd684c2f1 Gitweb: https://git.kernel.org/tip/2e712675ffd1331bb527dfc851b0e98cd684c2f1 Author: Bo YU AuthorDate: Mon, 22 Apr 2019 04:01:38 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 2 May 2019 16:00:19 -0400 perf bpf: Return

Re: [PATCH] staging: most: protect potential string overflow

2019-04-25 Thread Bo YU
On Wed, Apr 24, 2019 at 10:55 PM Dan Carpenter wrote: > > On Mon, Apr 22, 2019 at 10:20:18PM -0400, Bo YU wrote: > > There maybe cause potential string overflow issue due to use > > strcpy without checking the length > > > > Detected By CoversityScan CID# 144476

[PATCH] staging: most: protect potential string overflow

2019-04-22 Thread Bo YU
There maybe cause potential string overflow issue due to use strcpy without checking the length Detected By CoversityScan CID# 1444760 Fixes: 131ac62253dba:(staging: most: core: use device description as name) Signed-off-by: Bo YU --- drivers/staging/most/core.c | 2 +- 1 file changed, 1

[PATCH] bpf:sample: fix field 'lock' has incomplete type in hbm.h

2019-04-04 Thread Bo YU
When compiling sample/bpf: samples/bpf/hbm.h:12:23: error: field ‘lock’ has incomplete type struct bpf_spin_lock lock; Fixes: 187d0738ff35(bpf: Sample HBM BPF program to limit egress bw) Signed-off-by: Bo YU --- samples/bpf/hbm.h | 2 +- samples/bpf/hbm_out_kern.c | 4 ++-- 2 files

Re: linux-next: manual merge of the char-misc tree with the char-misc.current tree

2019-04-03 Thread Bo YU
-misc tree. > > > > I fixed it up (see below) and can carry the fix as necessary. This > > is now fixed as far as linux-next is concerned, but any non trivial > Greg did request Bo YU to rebase this patch on top of char-misc tree. Yes.The patch was v2 after rebasing char-misc tre

[PATCH V2] misc: fastrpc: add checked value for dma_set_mask

2019-03-28 Thread Bo YU
There be should check return value from dma_set_mask to throw some info if fail to set dma mask. Detected by CoverityScan, CID# 1443983: Error handling issues (CHECKED_RETURN) Fixes:f6f9279f2bf0 (misc: fastrpc: Add Qualcomm fastrpc basic driver model) Signed-off-by: Bo YU --- V2: rebase misc

Re: [PATCH] misc/fastrpc: add checked value for dma_set_mask

2019-03-27 Thread Bo YU
On Thu, Mar 28, 2019 at 2:29 AM Greg KH wrote: > > On Mon, Mar 18, 2019 at 10:05:19PM -0400, Bo YU wrote: > > There be should check return value from dma_set_mask to throw some infos > > if fail to set dma mask. > > > > Detected by CoverityScan, CID# 1

Re: [PATCH] misc/fastrpc: add checked value for dma_set_mask

2019-03-21 Thread Bo YU
On Thu, Mar 21, 2019 at 5:56 PM Kroah-Hartman wrote: > > On Thu, Mar 21, 2019 at 05:31:51PM +0800, Bo YU wrote: > > On Tue, Mar 19, 2019 at 10:05 AM Bo YU wrote: > > > > > > There be should check return value from dma_set_mask to throw some infos

Re: [PATCH] misc/fastrpc: add checked value for dma_set_mask

2019-03-21 Thread Bo YU
On Tue, Mar 19, 2019 at 10:05 AM Bo YU wrote: > > There be should check return value from dma_set_mask to throw some infos > if fail to set dma mask. > > Detected by CoverityScan, CID# 1443983: Error handling issues > (CHECKED_RETURN) > > Fixes:f6f9279f2bf0 (misc: fastr

[PATCH] misc/fastrpc: add checked value for dma_set_mask

2019-03-18 Thread Bo YU
There be should check return value from dma_set_mask to throw some infos if fail to set dma mask. Detected by CoverityScan, CID# 1443983: Error handling issues (CHECKED_RETURN) Fixes:f6f9279f2bf0 (misc: fastrpc: Add Qualcomm fastrpc basic driver model) Signed-off-by: Bo YU --- drivers/misc

Re: [PATCH 2/2] net: bonding: fix incorrect type in assignment

2019-03-08 Thread Bo YU
On Fri, Mar 8, 2019 at 2:51 PM Jay Vosburgh wrote: > > Bo YU wrote: > > >There are some warning when: > > > >sudo make C=1 CF=-D__CHECK_ENDIAN__ drivers/net/bonding/ > > > >drivers/net/bonding/bond_main.c:2438:40: warning: incorrect type in > >ass

[PATCH V3] bpf: fix warning about using plain integer as NULL

2019-03-07 Thread Bo YU
p bpf core to allow multiple cgroup storage types") Acked-by: Yonghong Song Signed-off-by: Bo YU --- V3: put fix tag all in a line V2: Add fix-up tag from Yonghong --- include/linux/bpf-cgroup.h | 2 +- net/bpf/test_run.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH V2] bpf: fix warning about using plain integer as NULL

2019-03-07 Thread Bo YU
p bpf core to allow multiple cgroup storage types") Acked-by: Yonghong Song Signed-off-by: Bo YU --- V2: Add fix-up tag from Yonghong --- include/linux/bpf-cgroup.h | 2 +- net/bpf/test_run.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/bpf-

[PATCH 2/2] net: bonding: fix incorrect type in assignment

2019-03-07 Thread Bo YU
unsigned long long const [usertype] value So fix it Signed-off-by: Bo YU --- drivers/net/bonding/bond_main.c| 2 +- drivers/net/bonding/bond_options.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index

[PATCH 0/2] net: bonding: fix sparse warning

2019-03-07 Thread Bo YU
Bo YU (2): net: bonding: fix restricted __be16 degrades to integer net: bonding: fix incorrect type in assignment drivers/net/bonding/bond_main.c| 8 drivers/net/bonding/bond_options.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.11.0

[PATCH 1/2] net: bonding: fix restricted __be16 degrades to integer

2019-03-07 Thread Bo YU
/bond_main.c:3241:60: warning: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:3241:60: warning: restricted __be16 degrades to integer So fix it. Signed-off-by: Bo YU --- drivers/net/bonding/bond_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] bpf: fix warning about using plain integer as NULL

2019-03-07 Thread Bo YU
Sparse warning below: sudo make C=2 CF=-D__CHECK_ENDIAN__ M=net/bpf/ CHECK net/bpf//test_run.c net/bpf//test_run.c:19:77: warning: Using plain integer as NULL pointer ./include/linux/bpf-cgroup.h:295:77: warning: Using plain integer as NULL pointer Signed-off-by: Bo YU --- include/linux/bpf

[PATCH V2] staging: wilc1000: fix incorrent type in initializer

2019-02-27 Thread Bo YU
struct cfg80211_bss_ies const [noderef] *ies Signed-off-by: Bo YU --- V2: Adding cc wireless-list --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH V2] staging: wilc1000: fix incorrent type assignment

2019-02-25 Thread Bo YU
:25:got unsigned short [usertype] capability Signed-off-by: Bo YU --- V2: use cpu_to_le16 assign valid type according to Ajay's suggestions --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH] staging: wilc1000: fix incorrect type in initializer

2019-02-25 Thread Bo YU
:got struct cfg80211_bss_ies const [noderef] *ies Signed-off-by: Bo YU --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index cdcb52aec779

[PATCH] staging: wilc1000: Fix incorrent type in assignment

2019-02-25 Thread Bo YU
/host_interface.c:451:25:got unsigned short [usertype] capability Signed-off-by: Bo YU --- I have no hardware to test it and just to compile it --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH V3] staging: ks7010: removed unused variables

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH V2] staging: ks7070: removed unused varibales

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH] staging/ks7070: Removed unused varibale

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

2019-02-21 Thread Bo YU
From: Bo Yu Fix sparse warnings: drivers/staging/erofs/utils.c:134:6: warning: symbol 'erofs_try_to_release_workgroup' was not declared. Should it be static? Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled") Cc: Gao Xiang Cc: Chao Yu CC: Greg Kro

[PATCH] perf trace: Fix potential USE_AFTER_FREE problem

2019-02-13 Thread Bo YU
From: Bo Yu There is a freed pointer "evsel", so fix it. Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)") Fixes: 6ab3bc240ade4("perf trace: Support multiple "vfs_getname" probes") Signed-off-by: Bo Yu --- tools/perf/b

[PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

2019-02-13 Thread Bo YU
From: Bo Yu Calling "amdgpu_ring_test_helper" without checking return value Signed-off-by: Bo Yu --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH] perf pmu-events: Removed unused variable

2019-02-13 Thread Bo YU
From: Bo Yu Compiling kernel when W=1, it will throw a warning: pmu-events/jevents.c: In function ‘save_arch_std_events’: pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable] struct stat *sb = data; Removed the unused variable Signed-off-by: Bo Yu --- tools/perf

[tip:x86/cleanups] x86/mtrr: Remove unused variable

2019-02-08 Thread tip-bot for Bo Yu
Commit-ID: c81cd5c08d676483bb09f4809660d2a1abea0062 Gitweb: https://git.kernel.org/tip/c81cd5c08d676483bb09f4809660d2a1abea0062 Author: Bo Yu AuthorDate: Fri, 8 Feb 2019 07:53:43 -0500 Committer: Thomas Gleixner CommitDate: Fri, 8 Feb 2019 14:32:33 +0100 x86/mtrr: Remove unused

[PATCH] x86: drop warning from mtrr: -Wunused-but-set-variable

2019-02-08 Thread Bo YU
From: Bo Yu There is a warning if enable W=1 when compile kernel: arch/x86/kernel/cpu/mtrr/cleanup.c:299:16: warning: variable ‘second_basek’ set but not used [-Wunused-but-set-variable] unsigned long second_basek, second_sizek; Signed-off-by: Bo Yu --- arch/x86/kernel/cpu/mtrr/cleanup.c

[PATCH V5 2/2] kobject: drop newline from msg string

2019-01-09 Thread Bo YU
There is currently a missing terminating newline in non-switch case match when msg == NULL Signed-off-by: Bo YU --- Changes in V4: Recovery originly declaration, requested by Greg. Change in V3: Improve the commit log, requested by Rafael. Changes in V2: Drop newline from msg according

[PATCH V5 0/2] kobject: fix code style and drop newline

2019-01-09 Thread Bo YU
There are some mirror changes in kobject_uevent.c. Btw, this is v5 for the patchset.2/2 was fixed by v1-v4,but 1/2 was marked V2 :(. Bo YU (2): kobject: to repalce printk with pr_* style kobject: drop newline from msg string lib/kobject_uevent.c | 9 - 1 file changed, 4 insertions

[PATCH V5 1/2] kobject: to repalce printk with pr_* style

2019-01-09 Thread Bo YU
Repalce printk with pr_warn in kobject_synth_uevent and replace printk with pr_err in uevent_net_init to make both consistent with other code in kobject_uevent.c Signed-off-by: Bo YU --- Changes in V2: Improve the commit log, doing as the patch did. --- lib/kobject_uevent.c | 5 ++--- 1 file

[PATCH v4 2/2] kobject: drop newline from msg string

2019-01-07 Thread Bo YU
There is currently a missing terminating newline in non-switch case match,when msg == NULL Signed-off-by: Bo YU --- Changes in V4: Recovery originly declaration, requested by Greg. Changes in V3: Improve the commit log, requested by rafael. Changes in V2: According to Joe's suggestion, drop

[PATCH v4 0/2] kobject: trival fix

2019-01-07 Thread Bo YU
This is trival fix for lib/kobject_uevent.c file. Bo YU (2): kobject: use pr_warn to replace printk kobject: drop newline from msg string lib/kobject_uevent.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.11.0

[PATCH v4 1/2] kobject: use pr_warn to replace printk

2019-01-07 Thread Bo YU
This is a fix to replace printk with pr_warn Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 27c6118afd1c..499dfcdafcb0 100644 --- a/lib/kobject_uevent.c +++ b/lib

[PATCH v3 2/2] kobject: drop newline from msg string

2018-12-07 Thread Bo YU
There is currently a missing terminating newline in non-switch case match, when msg == NULL. Signed-off-by: Bo YU --- Changes in v3: Improve the commit log,requested by rafael. Changes in v2: According to Joe's suggestion,drop newline from msg lib/kobject_uevent.c | 11 ++- 1 file

[PATCH v3 2/2] kobject: drop newline from msg string

2018-12-07 Thread Bo YU
There is currently a missing terminating newline in non-switch case match, when msg == NULL. Signed-off-by: Bo YU --- Changes in v3: Improve the commit log,requested by rafael. Changes in v2: According to Joe's suggestion,drop newline from msg lib/kobject_uevent.c | 11 ++- 1 file

[PATCH v3 1/2] kobject: use pr_warn to replace printk

2018-12-07 Thread Bo YU
This is a fix to replace printk with pr_warn Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 63d0816ab23b..b7c088c902a2 100644 --- a/lib/kobject_uevent.c +++ b/lib

[PATCH v3 1/2] kobject: use pr_warn to replace printk

2018-12-07 Thread Bo YU
This is a fix to replace printk with pr_warn Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 63d0816ab23b..b7c088c902a2 100644 --- a/lib/kobject_uevent.c +++ b/lib

[PATCH v3 0/2] kobject: trival fix

2018-12-07 Thread Bo YU
This is trival fix for lib/kobject_uevent.c file. Bo YU (2): kobject: use pr_warn to replace printk kobject: drop newline from msg string lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.11.0

[PATCH v3 0/2] kobject: trival fix

2018-12-07 Thread Bo YU
This is trival fix for lib/kobject_uevent.c file. Bo YU (2): kobject: use pr_warn to replace printk kobject: drop newline from msg string lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.11.0

[PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Bo YU
Fix warning form checkpatch, use pr_warn replace KERN_WARNING Signed-off-by: Bo YU --- changes in v2: According to Joe's suggestion,drop newline from msg, otherwise it can be unterminated with newline. --- lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions

[PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Bo YU
Fix warning form checkpatch, use pr_warn replace KERN_WARNING Signed-off-by: Bo YU --- changes in v2: According to Joe's suggestion,drop newline from msg, otherwise it can be unterminated with newline. --- lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions

[PATCH 2/3] kobject: Fix warnings in lib/kobject_uevent.c

2018-10-30 Thread Bo YU
Add a blank after declaration. Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 402765c3a9cb..27c6118afd1c 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -240,6 +240,7 @@ static

[PATCH 2/3] kobject: Fix warnings in lib/kobject_uevent.c

2018-10-30 Thread Bo YU
Add a blank after declaration. Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 402765c3a9cb..27c6118afd1c 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -240,6 +240,7 @@ static

[PATCH 3/3] kobject: fix warnings use pr_* to replace printk

2018-10-30 Thread Bo YU
Fix warning from checkpatch.pl use pr_* to replace printk Signed-off-by: Bo YU --- lib/kobject_uevent.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 27c6118afd1c..c87a96c4800e 100644 --- a/lib/kobject_uevent.c +++ b

[PATCH 3/3] kobject: fix warnings use pr_* to replace printk

2018-10-30 Thread Bo YU
Fix warning from checkpatch.pl use pr_* to replace printk Signed-off-by: Bo YU --- lib/kobject_uevent.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 27c6118afd1c..c87a96c4800e 100644 --- a/lib/kobject_uevent.c +++ b

[PATCH 1/3] kobject: drop unnecessary cast "%llu" for u64

2018-10-30 Thread Bo YU
There is no searon for u64 var cast to unsigned long long type. Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 63d0816ab23b..402765c3a9cb 100644 --- a/lib/kobject_uevent.c +++ b

[PATCH 1/3] kobject: drop unnecessary cast "%llu" for u64

2018-10-30 Thread Bo YU
There is no searon for u64 var cast to unsigned long long type. Signed-off-by: Bo YU --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 63d0816ab23b..402765c3a9cb 100644 --- a/lib/kobject_uevent.c +++ b

[PATCH 0/3] kobject: fix warnings from ehcekpatch.pl

2018-10-30 Thread Bo YU
Hi,this is a series of patches which fix warning from checkpatch.pl. I do not know which tree should apply these patches,so i git format-patch from linus' s kernel tree. Bo YU (3): kobject: drop unnecessary cast "%llu" for u64 kobject: Fix warnings in lib/kobject_uevent.c ko

[PATCH 0/3] kobject: fix warnings from ehcekpatch.pl

2018-10-30 Thread Bo YU
Hi,this is a series of patches which fix warning from checkpatch.pl. I do not know which tree should apply these patches,so i git format-patch from linus' s kernel tree. Bo YU (3): kobject: drop unnecessary cast "%llu" for u64 kobject: Fix warnings in lib/kobject_uevent.c ko

Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default

2018-02-25 Thread Bo YU
Hi, I think you would better to modify the subject line without [V9fs-developers]. On Mon, Feb 26, 2018 at 09:34:49AM +0800, jiangyiwen wrote: On 2018/2/24 10:47, jiangyiwen wrote: On 2018/2/9 14:13, jiangyiwen wrote: User use some syscall, for example mmap(v9fs_file_mmap), it will not update

Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default

2018-02-25 Thread Bo YU
Hi, I think you would better to modify the subject line without [V9fs-developers]. On Mon, Feb 26, 2018 at 09:34:49AM +0800, jiangyiwen wrote: On 2018/2/24 10:47, jiangyiwen wrote: On 2018/2/9 14:13, jiangyiwen wrote: User use some syscall, for example mmap(v9fs_file_mmap), it will not update

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Bo YU
Hi, On Wed, Feb 21, 2018 at 04:41:05PM +0100, Jason A. Donenfeld wrote: Fixes: 41c87425a1ac ("netlink: do not set cb_running if dump's start() errs") I think you Would better to resend it. Bo,

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Bo YU
Hi, On Wed, Feb 21, 2018 at 04:41:05PM +0100, Jason A. Donenfeld wrote: Fixes: 41c87425a1ac ("netlink: do not set cb_running if dump's start() errs") I think you Would better to resend it. Bo,

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-21 Thread Bo Yu
Hi, On Wed, Jun 21, 2017 at 02:33:03PM +0800, Jia-Ju Bai wrote: On 06/21/2017 02:11 PM, Kalle Valo wrote: David Miller writes: From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 The driver may sleep under a spin lock, and the function call

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-21 Thread Bo Yu
Hi, On Wed, Jun 21, 2017 at 02:33:03PM +0800, Jia-Ju Bai wrote: On 06/21/2017 02:11 PM, Kalle Valo wrote: David Miller writes: From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 The driver may sleep under a spin lock, and the function call path is: netxen_nic_pci_mem_access_direct

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: + struct notifier_block notifier_block; + /* Vxlan/Geneve information */ + struct hns3_udp_tunnel udp_tnl[HNS3_UDP_TNL_MAX]; +}; + +/* the distance between [begin, end) in a ring buffer + * note: there is a unuse

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: + struct notifier_block notifier_block; + /* Vxlan/Geneve information */ + struct hns3_udp_tunnel udp_tnl[HNS3_UDP_TNL_MAX]; +}; + +/* the distance between [begin, end) in a ring buffer + * note: there is a unuse

Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:25PM +0100, Salil Mehta wrote: + * Unregister client from ae_dev + * start() + * Enable the hardware + * stop() + * Disable the hardware + * get_status() + * Get the carrier state of the back channel of the handle, 1 for ok, 0 for + * non-ok + *

Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:25PM +0100, Salil Mehta wrote: + * Unregister client from ae_dev + * start() + * Enable the hardware + * stop() + * Disable the hardware + * get_status() + * Get the carrier state of the back channel of the handle, 1 for ok, 0 for + * non-ok + *

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: +static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, + int size, dma_addr_t dma, int frag_end, + enum hns_desc_type type) +{ + struct hns3_desc_cb *desc_cb =

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: +static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, + int size, dma_addr_t dma, int frag_end, + enum hns_desc_type type) +{ + struct hns3_desc_cb *desc_cb =

[PATCH] Staging: iio: return expression instead of return ret

2017-03-09 Thread Bo Yu
The following Coccinelle script was used to detect this: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/iio/meter/ade7754.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] Staging: iio: return expression instead of return ret

2017-03-09 Thread Bo Yu
The following Coccinelle script was used to detect this: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Bo YU --- drivers/staging/iio/meter/ade7754.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH v2] Staging: wlan-ng: fixed block comments should align the * on each line

2017-02-17 Thread Bo YU
Right-shift a space key to align the * on each line. Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruc

[PATCH v2] Staging: wlan-ng: fixed block comments should align the * on each line

2017-02-17 Thread Bo YU
Right-shift a space key to align the * on each line. Signed-off-by: Bo YU --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng

[PATCH] Staging: bcm2835-audio: fixed a code style issue:

2017-02-16 Thread Bo YU
Missing a blank line after declarations Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-pcm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c index 014bf7

[PATCH] Staging: bcm2835-audio: fixed a code style issue:

2017-02-16 Thread Bo YU
Missing a blank line after declarations Signed-off-by: Bo YU --- drivers/staging/bcm2835-audio/bcm2835-pcm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c index 014bf7ab69f4..16127e062661 100644

[PATCH] Staging: wlan-ng: Fixed the code style issue:

2017-02-14 Thread Bo YU
WARNING: Block comments should align the * on each line Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruc

[PATCH] Staging: wlan-ng: Fixed the code style issue:

2017-02-14 Thread Bo YU
WARNING: Block comments should align the * on each line Signed-off-by: Bo YU --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng

[PATCH] Staging: wlan-ng: Fixed code style issue:

2017-02-13 Thread Bo YU
Statements should start on a tabstop Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index

[PATCH] Staging: wlan-ng: Fixed code style issue:

2017-02-13 Thread Bo YU
Statements should start on a tabstop Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index c558ad656c49..b641a59052ac 100644 ---

Re: [PATCH] staging: xgifb: Fix comment style

2016-03-22 Thread Bo Yu
On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote: hi, On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote: Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c|3 ++-

Re: [PATCH] staging: xgifb: Fix comment style

2016-03-22 Thread Bo Yu
On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote: hi, On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote: Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c|3 ++- drivers/staging/xgifb/vb_setmode.c |3 ++- 2

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hi, On Sun, Feb 21, 2016 at 11:33:48AM -0800, Kroah-Hartman wrote: >On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote: >> Hello, >> >> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >> >Patch doesn't apply :( >> I don't know that whether

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hi, On Sun, Feb 21, 2016 at 11:33:48AM -0800, Kroah-Hartman wrote: >On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote: >> Hello, >> >> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >> >Patch doesn't apply :( >> I don't know that whether

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hello, On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote: >> Fix comments to use trailing */ on separate lines. >> >> Signed-off-by: YU BO <tsu.y...@gmail.com> >> --- >> drivers/staging/x

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hello, On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote: >> Fix comments to use trailing */ on separate lines. >> >> Signed-off-by: YU BO >> --- >> drivers/staging/xgifb/vb_init.c | 10

[PATCH] staging: xgifb: Fix comment style

2016-02-16 Thread Bo YU
Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index

[PATCH] staging: xgifb: Fix comment style

2016-02-16 Thread Bo YU
Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539b..c7f02c7 100644 ---

Re: [PATCH] Staging: xgifb: vgatypes.h: Coding style warning fix for block comments

2016-02-15 Thread Bo YU
Hi, Sorry for the delay to reply.I have send the patch to Arnaud,but he didn't reply me...Maybe i was wrong with something. Thanks again. On Mon, Feb 8, 2016 at 12:14 PM, Kroah-Hartman wrote: > On Fri, Jan 15, 2016 at 05:30:02PM +0800, YU Bo wrote: >> This patch is

Re: [PATCH] Staging: xgifb: vgatypes.h: Coding style warning fix for block comments

2016-02-15 Thread Bo YU
Hi, Sorry for the delay to reply.I have send the patch to Arnaud,but he didn't reply me...Maybe i was wrong with something. Thanks again. On Mon, Feb 8, 2016 at 12:14 PM, Kroah-Hartman wrote: > On Fri, Jan 15, 2016 at 05:30:02PM +0800, YU Bo wrote: >> This patch is to vgatypes.h file that