Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 12:45 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hello Bryan On Thu, Feb 12, 2015 at 8:48 PM, Bryan Wu coolo...@gmail.com wrote: Could you please give me some real error message or example about this device tree overlays? Looks like it's not only

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:30 PM, Bjorn Andersson bj...@kryo.se wrote: On Tue, Feb 17, 2015 at 2:14 PM, Bryan Wu coolo...@gmail.com wrote: On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd sb...@codeaurora.org wrote: On 01/23/15 16:54, Bjorn Andersson wrote: Thanks for the review, Stephen. Bjorn

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-12 Thread Bryan Wu
On Wed, Feb 11, 2015 at 4:26 AM, Ricardo Ribalda Delgado wrote: > The current code expected that every LED had an unique name. This is a > legit expectation when the device tree can no be modified or extended. > But with device tree overlays this requirement can be easily broken. > Could you

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Bryan Wu
On Thu, Jan 29, 2015 at 11:07 AM, Bjorn Andersson wrote: > On Thu 29 Jan 04:48 PST 2015, Ivan T. Ivanov wrote: > >> >> Hi Bjorn, >> >> Just few nitpick comments. >> > > Thanks. > >> On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote: >> > From: Courtney Cavin ca...@sonymobile.com> >> > >> >

Re: [PATCH v2 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2015-02-12 Thread Bryan Wu
On Fri, Jan 23, 2015 at 4:54 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds device tree binding documentation for the WLED ('White' LED) > block on Qualcomm's PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson I will merge this into my branch for

[GIT PULL] LED subsystem for 3.20 merge window

2015-02-12 Thread Bryan Wu
Hi Linus, The big change of LED subsystem is introducing a new LED class for Flash type LEDs which will be used for V4L2 subsystem. Also we got some cleanup and fixes. So please conside the following changes since commit 188c901941efd43cbf21e8f4f9e9a276536b989c: Merge branch

Re: [PATCH v2 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2015-02-12 Thread Bryan Wu
On Fri, Jan 23, 2015 at 4:54 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds device tree binding documentation for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Signed-off-by: Courtney Cavin

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Bryan Wu
On Thu, Jan 29, 2015 at 11:07 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: On Thu 29 Jan 04:48 PST 2015, Ivan T. Ivanov wrote: Hi Bjorn, Just few nitpick comments. Thanks. On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote: From: Courtney Cavin ca...@sonymobile.com

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-12 Thread Bryan Wu
On Wed, Feb 11, 2015 at 4:26 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: The current code expected that every LED had an unique name. This is a legit expectation when the device tree can no be modified or extended. But with device tree overlays this requirement can be easily

[GIT PULL] LED subsystem for 3.20 merge window

2015-02-12 Thread Bryan Wu
Hi Linus, The big change of LED subsystem is introducing a new LED class for Flash type LEDs which will be used for V4L2 subsystem. Also we got some cleanup and fixes. So please conside the following changes since commit 188c901941efd43cbf21e8f4f9e9a276536b989c: Merge branch

Re: [PATCH] leds: leds-gpio: Pass on error codes unmodified

2015-02-02 Thread Bryan Wu
On Sun, Feb 1, 2015 at 8:59 AM, Sören Brinkmann wrote: > + Andreas who actually reported this issue and also tested the patch. > > On Sat, 2015-01-31 at 07:15PM -0800, Soren Brinkmann wrote: >> Instead of overriding error codes, pass them on unmodified. This >> way a EPROBE_DEFER is correctly

Re: [PATCH] leds: leds-gpio: Pass on error codes unmodified

2015-02-02 Thread Bryan Wu
On Sun, Feb 1, 2015 at 8:59 AM, Sören Brinkmann soren.brinkm...@xilinx.com wrote: + Andreas who actually reported this issue and also tested the patch. On Sat, 2015-01-31 at 07:15PM -0800, Soren Brinkmann wrote: Instead of overriding error codes, pass them on unmodified. This way a

Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

2015-01-30 Thread Bryan Wu
this match your vision of how it should work, i.e. ACK? > > Bryan/Dmitry: can you ACK the oneliners in your subsystems? Sure, please take my Ack Acked-by: Bryan Wu > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

2015-01-30 Thread Bryan Wu
? Bryan/Dmitry: can you ACK the oneliners in your subsystems? Sure, please take my Ack Acked-by: Bryan Wu coolo...@gmail.com Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension

2015-01-26 Thread Bryan Wu
ss and the related sysfs attributes. >>> >>> Signed-off-by: Jacek Anaszewski >>> Acked-by: Kyungmin Park >>> Cc: Bryan Wu >>> Cc: Richard Purdie >> >> >>> +In order to enable support for flash LEDs CONFIG_LEDS_CLA

Re: [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem

2015-01-26 Thread Bryan Wu
the kernel internal interface. When V4L2 Flash sub-device >> file is opened, the LED class device sysfs interface is made >> unavailable. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Cc: Bryan Wu >> Cc: Richard Purdie > > Acke

Re: [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem

2015-01-26 Thread Bryan Wu
sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Acked-by: Pavel Machek pa...@ucw.cz Applied to my tree. Thanks for pushing

Re: [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension

2015-01-26 Thread Bryan Wu
-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net +In order to enable support for flash LEDs CONFIG_LEDS_CLASS_FLASH symbol +must be defined in the kernel config. A flash

Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack

2015-01-14 Thread Bryan Wu
On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven wrote: > of_find_node_by_name() calls of_node_put() on its "from" parameter. > To counter this, mc13xxx_led_probe_dt() calls of_node_get() first. > > Use of_get_child_by_name() instead to get rid of the refcount hack. > > Signed-off-by: Geert

Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack

2015-01-14 Thread Bryan Wu
On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven geert+rene...@glider.be wrote: of_find_node_by_name() calls of_node_put() on its from parameter. To counter this, mc13xxx_led_probe_dt() calls of_node_get() first. Use of_get_child_by_name() instead to get rid of the refcount hack.

[GIT PULL] LED fix for 3.19

2015-01-13 Thread Bryan Wu
Hi Linus, Please consider the following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git leds-fixes-for-3.19 for you to

[GIT PULL] LED fix for 3.19

2015-01-13 Thread Bryan Wu
Hi Linus, Please consider the following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git leds-fixes-for-3.19 for you to

Re: LED: inform userspace about brightness change

2015-01-06 Thread Bryan Wu
On Wed, Dec 24, 2014 at 12:06 PM, Pali Rohár wrote: > Hello! > > What is preferred way from kernel driver to inform userspace > about LED device brightness change? In /sys/class/leds// > is file brightness which can be used to read current brightness > or set write new value. But sometimes also

Re: LED: inform userspace about brightness change

2015-01-06 Thread Bryan Wu
On Wed, Dec 24, 2014 at 12:06 PM, Pali Rohár pali.ro...@gmail.com wrote: Hello! What is preferred way from kernel driver to inform userspace about LED device brightness change? In /sys/class/leds/device/ is file brightness which can be used to read current brightness or set write new value.

Re: [PATCH 14/27] leds: Use setup_timer

2015-01-05 Thread Bryan Wu
On Fri, Dec 26, 2014 at 6:35 AM, Julia Lawall wrote: > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > A simplified version of the semantic match that fixes this problem is as > follows:

Re: [PATCH 14/27] leds: Use setup_timer

2015-01-05 Thread Bryan Wu
On Fri, Dec 26, 2014 at 6:35 AM, Julia Lawall julia.law...@lip6.fr wrote: Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows:

Re: [PATCH] leds: Don't allow brightness values greater than max_brightness

2014-12-23 Thread Bryan Wu
On Tue, Dec 23, 2014 at 10:59 AM, Gabriele Mazzotta wrote: > Since commit 4d71a4a12b13 ("leds: Add support for setting brightness in > a synchronous way") the value passed to brightness_set() is no longer > limited to max_brightness and can be different from the internally saved > brightness

Re: [PATCH] leds: Don't allow brightness values greater than max_brightness

2014-12-23 Thread Bryan Wu
On Tue, Dec 23, 2014 at 10:59 AM, Gabriele Mazzotta gabriele@gmail.com wrote: Since commit 4d71a4a12b13 (leds: Add support for setting brightness in a synchronous way) the value passed to brightness_set() is no longer limited to max_brightness and can be different from the internally saved

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-16 Thread Bryan Wu
On Tue, Dec 9, 2014 at 5:19 PM, Bryan Wu wrote: > On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson > wrote: >> From: Courtney Cavin >> >> This adds device tree binding documentation for the WLED ('White' LED) >> block on Qualcomm's PM8941 PMICs. >> >

Re: [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver

2014-12-16 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > drivers/leds/Kconfig| 8 + >

Re: [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver

2014-12-16 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds support for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Signed-off-by: Courtney Cavin courtney.ca...@sonymobile.com Signed-off-by:

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-16 Thread Bryan Wu
On Tue, Dec 9, 2014 at 5:19 PM, Bryan Wu coolo...@gmail.com wrote: On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds device tree binding documentation for the WLED ('White' LED) block

[GIT PULL] LED subsystem for 3.19 merge window

2014-12-15 Thread Bryan Wu
Hi Linus, We got some cleanup and driver for LP8860 as well as some patches for LED Flash Class. So please consider the following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at:

[GIT PULL] LED subsystem for 3.19 merge window

2014-12-15 Thread Bryan Wu
Hi Linus, We got some cleanup and driver for LP8860 as well as some patches for LED Flash Class. So please consider the following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at:

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-09 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds device tree binding documentation for the WLED ('White' LED) > block on Qualcomm's PM8941 PMICs. > Looks good to me, I need device tree reviewer's Ack to merge it. Thanks, -Bryan > Signed-off-by:

Re: [PATCH] leds: leds-gpio: Fix the "default-state" property check

2014-12-09 Thread Bryan Wu
k to restore the original behaviour. > > Fixes: a43f2cbbb009 (leds: leds-gpio: Make use of device property API) Thanks, please take my Ack Acked-by: Bryan Wu I think Rafael will take this fix with other patches through his tree. > Reported-by: Jean-Michel Hautbois > Signed-off-by: Fabio

Re: [PATCH] leds: leds-gpio: Fix the default-state property check

2014-12-09 Thread Bryan Wu
behaviour. Fixes: a43f2cbbb009 (leds: leds-gpio: Make use of device property API) Thanks, please take my Ack Acked-by: Bryan Wu coolo...@gmail.com I think Rafael will take this fix with other patches through his tree. Reported-by: Jean-Michel Hautbois jean-michel.hautb...@vodalys.com Signed

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-09 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds device tree binding documentation for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Looks good to me, I need device tree reviewer's

Re: [PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-05 Thread Bryan Wu
On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie &g

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-05 Thread Bryan Wu
On Mon, Dec 1, 2014 at 5:58 AM, Jacek Anaszewski wrote: > Hi Pavel, > > On 12/01/2014 02:04 PM, Pavel Machek wrote: >> >> Hi! >> How are faults cleared? Should it be list of strings, instead of bitmask? We may want to add new fault modes in future... >>> >>> >>> Faults are cleared by

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-05 Thread Bryan Wu
On Mon, Dec 1, 2014 at 5:58 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Pavel, On 12/01/2014 02:04 PM, Pavel Machek wrote: Hi! How are faults cleared? Should it be list of strings, instead of bitmask? We may want to add new fault modes in future... Faults are cleared by

Re: [PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-05 Thread Bryan Wu
...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- This patch looks good to me. I will take it with other patches! Thanks, -Bryan Documentation/leds/leds-class-flash.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/leds/leds

[PATCH] MAINTAINERS: remove my name from Backlight subsystem

2014-12-03 Thread Bryan Wu
Signed-off-by: Bryan Wu --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea4d005..1cb460f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1862,7 +1862,6 @@ F:drivers/net/wireless/b43legacy/ BACKLIGHT CLASS/SUBSYSTEM M: Jingoo Han

[PATCH] MAINTAINERS: remove my name from Backlight subsystem

2014-12-03 Thread Bryan Wu
Signed-off-by: Bryan Wu coolo...@gmail.com --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea4d005..1cb460f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1862,7 +1862,6 @@ F:drivers/net/wireless/b43legacy/ BACKLIGHT CLASS/SUBSYSTEM M

Re: [PATCH v9 4/8] devicetree: backlight: Add new SKY81452 backlight binding

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo Acked-by: Bryan Wu Thanks, -Bryan > --- > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable propert

Re: [PATCH v9 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo This patch looks good to me and I think Jingoo reviewed it already. So please take my Ack here: Acked-by: Bryan Wu Lee, can you apply this patch? Thanks, -Bryan > --- > Change

Re: [PATCH v9 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com This patch looks good to me and I think Jingoo reviewed it already. So please take my Ack here: Acked-by: Bryan Wu coolo...@gmail.com Lee

Re: [PATCH v9 4/8] devicetree: backlight: Add new SKY81452 backlight binding

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com Acked-by: Bryan Wu coolo...@gmail.com Thanks, -Bryan --- Changes v9: Nothing Changes v8: Renamed property names for backlight

Re: [PATCH v3] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-19 Thread Bryan Wu
On Wed, Nov 19, 2014 at 4:48 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display cluster mode > as this seems to be the most used configuration at the > time of the driver configuration. > > For more product

Re: [PATCH v3] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-19 Thread Bryan Wu
On Wed, Nov 19, 2014 at 4:48 AM, Dan Murphy dmur...@ti.com wrote: Introduce the Texas Instruments lp8860 4 channel LED driver. This driver configures the device in display cluster mode as this seems to be the most used configuration at the time of the driver configuration. For more product

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 3:50 PM, Dan Murphy wrote: > Bryan > > On 11/18/2014 04:56 PM, Bryan Wu wrote: >> On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy wrote: >>> Introduce the Texas Instruments lp8860 >>> 4 channel LED driver. >>> >>> This d

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display cluster mode > as this seems to be the most used configuration at the > time of the driver configuration. > > For more product

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy dmur...@ti.com wrote: Introduce the Texas Instruments lp8860 4 channel LED driver. This driver configures the device in display cluster mode as this seems to be the most used configuration at the time of the driver configuration. For more product

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 3:50 PM, Dan Murphy dmur...@ti.com wrote: Bryan On 11/18/2014 04:56 PM, Bryan Wu wrote: On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy dmur...@ti.com wrote: Introduce the Texas Instruments lp8860 4 channel LED driver. This driver configures the device in display

Re: [PATCH] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-13 Thread Bryan Wu
On Thu, Nov 13, 2014 at 4:35 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display custer mode custer or cluster? > as this seems to be the most used configuration at the > time of the driver configuration. > >

Re: [PATCH] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-13 Thread Bryan Wu
On Thu, Nov 13, 2014 at 4:35 AM, Dan Murphy dmur...@ti.com wrote: Introduce the Texas Instruments lp8860 4 channel LED driver. This driver configures the device in display custer mode custer or cluster? as this seems to be the most used configuration at the time of the driver

[GIT PULL] LED subsystem for 3.18 merge window

2014-10-20 Thread Bryan Wu
driver hwmon: (menf21bmc) Introduce MEN14F021P00 BMC HWMON driver Bryan Wu (1): Merge tag 'mfd-hwmon-leds-watchdog-v3.18' into devel Jacek Anaszewski (5): leds: Reorder include directives leds: make brightness type consistent across whole subsystem leds: avoid using

[GIT PULL] LED subsystem for 3.18 merge window

2014-10-20 Thread Bryan Wu
driver hwmon: (menf21bmc) Introduce MEN14F021P00 BMC HWMON driver Bryan Wu (1): Merge tag 'mfd-hwmon-leds-watchdog-v3.18' into devel Jacek Anaszewski (5): leds: Reorder include directives leds: make brightness type consistent across whole subsystem leds: avoid using

Re: [PATCH 12/13] leds: leds-gpio: Make use of device property API

2014-10-08 Thread Bryan Wu
ious versions if I remember correctly, > but it's changed quite a bit since then, so can you please check this new > version too? > Sure, the new one is even better than before. Please go ahead with my Ack Acked-by: Bryan Wu Thanks, -Bryan >> --- >> drivers/leds/led

Re: [PATCH 12/13] leds: leds-gpio: Make use of device property API

2014-10-08 Thread Bryan Wu
of the previous versions if I remember correctly, but it's changed quite a bit since then, so can you please check this new version too? Sure, the new one is even better than before. Please go ahead with my Ack Acked-by: Bryan Wu coolo...@gmail.com Thanks, -Bryan --- drivers/leds/leds-gpio.c

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-10-03 Thread Bryan Wu
On Thu, Oct 2, 2014 at 12:12 AM, Linus Walleij wrote: > On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu wrote: >> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav >> wrote: >>> Get rid of using return value from gpiochip_remove() as it returns >>> void. >

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-10-03 Thread Bryan Wu
On Thu, Oct 2, 2014 at 12:12 AM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu coolo...@gmail.com wrote: On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav pramod.gu...@smartplayin.com wrote: Get rid of using return value from gpiochip_remove

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-09-30 Thread Bryan Wu
; Cc: Alexandre Courbot > Cc: Bryan Wu > Cc: Richard Purdie > Cc: linux-l...@vger.kernel.org > > Cc: linux-g...@vger.kernel.org > > Signed-off-by: Pramod Gurav > --- > drivers/leds/leds-pca9532.c | 10 ++ > drivers/leds/leds-tca6507.c |7 ++- >

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-09-30 Thread Bryan Wu
Walleij linus.wall...@linaro.org Cc: Alexandre Courbot gnu...@gmail.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: linux-l...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com --- drivers/leds/leds-pca9532.c

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:57 AM, Guenter Roeck wrote: > On Wed, Sep 24, 2014 at 09:33:32AM -0700, Bryan Wu wrote: >> On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones wrote: >> > On Wed, 24 Sep 2014, Guenter Roeck wrote: >> > >> >> On Wed, Sep 24, 20

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones wrote: > On Wed, 24 Sep 2014, Guenter Roeck wrote: > >> On Wed, Sep 24, 2014 at 03:48:29PM +0100, Lee Jones wrote: >> > Guenter, Bryan, Wim, >> > >> > The following changes since commit >> > 52addcf9d6669fa439387610bc65c92fa0980cef: >> > >> > Linux

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 24 Sep 2014, Guenter Roeck wrote: On Wed, Sep 24, 2014 at 03:48:29PM +0100, Lee Jones wrote: Guenter, Bryan, Wim, The following changes since commit 52addcf9d6669fa439387610bc65c92fa0980cef: Linux

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:57 AM, Guenter Roeck li...@roeck-us.net wrote: On Wed, Sep 24, 2014 at 09:33:32AM -0700, Bryan Wu wrote: On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 24 Sep 2014, Guenter Roeck wrote: On Wed, Sep 24, 2014 at 03:48:29PM +0100, Lee

Re: [PATCH v3] leds: Add DT support for leds-pca9532

2014-09-22 Thread Bryan Wu
On Wed, Sep 10, 2014 at 8:29 AM, Roland Stigge wrote: > This patch adds DT support for leds-pca9532. > > Signed-off-by: Roland Stigge > > --- > Applies to v3.17-rc4 > > v3: Removed superfluous whitespace > v2: Removed #ifdef statements > >

Re: [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support

2014-09-22 Thread Bryan Wu
leds: leds-gpio: Add support for GPIO descriptors > input: gpio_keys_polled - Add ACPI probing support > misc: at25: Make use of device property API > misc: at25: Add ACPI probing support > > Rafael J. Wysocki (1): > Driver core: Unified device properties interface f

Re: [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support

2014-09-22 Thread Bryan Wu
with the LEDs change, please go ahead with my Ack Acked-by: Bryan Wu coolo...@gmail.com Thanks, -Bryan Documentation/acpi/enumeration.txt| 27 ++ Documentation/acpi/properties.txt | 410 + drivers/acpi/Makefile | 1 + drivers/acpi/internal.h

Re: [PATCH v3] leds: Add DT support for leds-pca9532

2014-09-22 Thread Bryan Wu
On Wed, Sep 10, 2014 at 8:29 AM, Roland Stigge sti...@antcom.de wrote: This patch adds DT support for leds-pca9532. Signed-off-by: Roland Stigge sti...@antcom.de --- Applies to v3.17-rc4 v3: Removed superfluous whitespace v2: Removed #ifdef statements

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-12 Thread Bryan Wu
On Fri, Sep 5, 2014 at 2:03 PM, Bryan Wu wrote: > On Wed, Aug 20, 2014 at 6:41 AM, Jacek Anaszewski > wrote: >> led_update_brightness helper function used to be exploited only locally >> in the led-class.c module, where its result was being passed to the >> bright

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-12 Thread Bryan Wu
On Fri, Sep 12, 2014 at 12:09 AM, Lothar Waßmann wrote: > Hi, > > Bryan Wu wrote: >> On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann >> wrote: >> > When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO >> > driver, request_irq() fail

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-12 Thread Bryan Wu
On Fri, Sep 12, 2014 at 12:09 AM, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Bryan Wu wrote: On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann l...@karo-electronics.de wrote: When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO driver, request_irq() fails

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-12 Thread Bryan Wu
On Fri, Sep 5, 2014 at 2:03 PM, Bryan Wu coolo...@gmail.com wrote: On Wed, Aug 20, 2014 at 6:41 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: led_update_brightness helper function used to be exploited only locally in the led-class.c module, where its result was being passed

Re: [PATCH/RFC v5 2/4] leds: implement sysfs interface locking mechanism

2014-09-11 Thread Bryan Wu
Flash > sub-device control. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c| 23 --- > drivers/leds/led-core.c | 18 ++ > drivers/leds/led

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann wrote: > When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO > driver, request_irq() fails with -EINVAL, because the GPIO driver > requires a nested interrupt handler. > > Use request_any_context_irq() to be able to use any GPIO

Re: [PATCH 1/2] leds: trigger: gpio: fix warning in gpio trigger for gpios whose accessor function may sleep

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann wrote: > When using a GPIO driver whose accessor functions may sleep (e.g. an > I2C GPIO extender like PCA9554) the following warning is issued: > WARNING: CPU: 0 PID: 665 at drivers/gpio/gpiolib.c:2274 > gpiod_get_raw_value+0x3c/0x48() > Modules

Re: [PATCH 1/2] leds: trigger: gpio: fix warning in gpio trigger for gpios whose accessor function may sleep

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann l...@karo-electronics.de wrote: When using a GPIO driver whose accessor functions may sleep (e.g. an I2C GPIO extender like PCA9554) the following warning is issued: WARNING: CPU: 0 PID: 665 at drivers/gpio/gpiolib.c:2274

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann l...@karo-electronics.de wrote: When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO driver, request_irq() fails with -EINVAL, because the GPIO driver requires a nested interrupt handler. Use request_any_context_irq() to be able

Re: [PATCH/RFC v5 2/4] leds: implement sysfs interface locking mechanism

2014-09-11 Thread Bryan Wu
-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- drivers/leds/led-class.c| 23 --- drivers/leds/led-core.c | 18 ++ drivers

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-05 Thread Bryan Wu
ks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c |6 -- > drivers/leds/led-core.c | 16 > include/linux/leds.h | 10 ++ > 3 files chang

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-05 Thread Bryan Wu
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- drivers/leds/led-class.c |6 -- drivers/leds/led-core.c | 16 include/linux/leds.h

[GIT PULL] LED fix for 3.17

2014-09-02 Thread Bryan Wu
Hi Linus, Hugh, Jiri and many other people found a kernel oops due to a LED change merged recently. Now the right fix might just revert it and unblock the kernel oops. Please check the bug report in the patch commit message and consider merge the following changes since commit

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211] > [] __cancel_work_timer+0x7b/0x100 > [] cancel_delayed_work_sync+0xe/0x10 > [] led_blink_set+0x1b/0x40 > [] tpt_trig_timer+0x110/0x170 [mac80211] > [] call_timer_fn+0x75/0x180 > [] ? process_timeout+0x10/0x10 > [] ? __ieee80211_

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer wrote: > On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer jwbo...@fedoraproject.org wrote: On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Bryan Wu
+0x170/0x170 [81af3ff2] start_kernel+0x44f/0x45a [81af399c] ? set_init_arg+0x53/0x53 [81af35ad] x86_64_start_reservations+0x2a/0x2c [81af36a0] x86_64_start_kernel+0xf1/0xf4 Cc: Vincent Donnefort vdonnef...@gmail.com Cc: Bryan Wu coolo...@gmail.com Cc

[GIT PULL] LED fix for 3.17

2014-09-02 Thread Bryan Wu
Hi Linus, Hugh, Jiri and many other people found a kernel oops due to a LED change merged recently. Now the right fix might just revert it and unblock the kernel oops. Please check the bug report in the patch commit message and consider merge the following changes since commit

Re: [PATCH v6 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-28 Thread Bryan Wu
On Wed, Aug 27, 2014 at 10:52 AM, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC LEDs. > The BMC is a Board Management Controller including four LEDs which > can be switched on and off. > Please go ahead with my Ack Acked-by: Bryan Wu Lee, will you merge this

Re: [PATCH v6 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-28 Thread Bryan Wu
On Wed, Aug 27, 2014 at 10:52 AM, Andreas Werner andreas.wer...@men.de wrote: Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Please go ahead with my Ack Acked-by: Bryan Wu coolo...@gmail.com Lee

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-25 Thread Bryan Wu
On Sat, Aug 23, 2014 at 2:52 AM, Michal Sojka wrote: > Hi Bryan, > > thanks for the review. See some comments below. > > On Sat, Aug 23 2014, Bryan Wu wrote: >> On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: >>> With this patch, USB host activity can

Re: [PATCH v4 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-25 Thread Bryan Wu
On Wed, Aug 13, 2014 at 1:40 AM, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC LEDs. > The BMC is a Board Management Controller including four LEDs which > can be switched on and off. > > Signed-off-by: Andreas Werner > --- > drivers/leds/Kconfig | 6 ++ >

Re: [PATCH v4 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-25 Thread Bryan Wu
On Wed, Aug 13, 2014 at 1:40 AM, Andreas Werner andreas.wer...@men.de wrote: Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Signed-off-by: Andreas Werner andreas.wer...@men.de ---

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-25 Thread Bryan Wu
On Sat, Aug 23, 2014 at 2:52 AM, Michal Sojka so...@merica.cz wrote: Hi Bryan, thanks for the review. See some comments below. On Sat, Aug 23 2014, Bryan Wu wrote: On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka so...@merica.cz wrote: With this patch, USB host activity can be signaled

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: > With this patch, USB host activity can be signaled by blinking a LED. > > This should work with all host controllers. Tested only with musb. > > Signed-off-by: Michal Sojka > --- > drivers/usb/core/Kconfig | 9 + >

Re: [PATCH v2 0/3] LED triggers for USB host and device

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: > This adds LED triggers for USB host and device. > > Changes from v1: > - Moved from drivers/leds/ to drivers/usb/ > - Improved Kconfig help > - Linked with other modules rather than being standalone modules > > Michal Sojka (3): > usb: Add

Re: [PATCH] leds: make led_blink_set IRQ safe

2014-08-22 Thread Bryan Wu
On Tue, Aug 19, 2014 at 6:51 PM, Hugh Dickins wrote: > On Tue, 19 Aug 2014, Vincent Donnefort wrote: > >> This patch introduces a work which take care of reseting the blink workqueue >> and >> avoid calling the cancel_delayed_work_sync function which may sleep, from an >> IRQ >> context. >>

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 2:42 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote: >> On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka wrote: >> > With this patch, USB gadget activity can be signaled by blinking a LED. >> > >>

<    1   2   3   4   5   6   7   8   9   10   >