Re: [PATCH 10/36] leds: convert class code to use dev_groups

2013-07-26 Thread Bryan Wu
On Wed, Jul 24, 2013 at 3:05 PM, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the led class code to use the > correct field. > > Cc: Bryan Wu > Cc: Richard Purdie > Signed-off-b

Re: [PATCH 10/36] leds: convert class code to use dev_groups

2013-07-26 Thread Bryan Wu
On Wed, Jul 24, 2013 at 3:05 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: The dev_attrs field of struct class is going away soon, dev_groups should be used instead. This converts the led class code to use the correct field. Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur

Re: [PATCH re-send] leds: support new LP8501 device - another LP55xx common

2013-07-12 Thread Bryan Wu
On Tue, Jul 9, 2013 at 2:11 AM, Kim, Milo wrote: > LP8501 can drive up to 9 channels like LP5523. > LEDs can be controlled directly via the I2C and programmable engines are > supported. > > LP55xx common driver > LP8501 is one of LP55xx family device, so LP55xx common code are used. > Chip

Re: [PATCH re-send] leds: support new LP8501 device - another LP55xx common

2013-07-12 Thread Bryan Wu
On Tue, Jul 9, 2013 at 2:11 AM, Kim, Milo milo@ti.com wrote: LP8501 can drive up to 9 channels like LP5523. LEDs can be controlled directly via the I2C and programmable engines are supported. LP55xx common driver LP8501 is one of LP55xx family device, so LP55xx common code are used.

[GIT PULL] leds: updates for 3.11

2013-07-02 Thread Bryan Wu
Hi Linus, LED subsystem updates for 3.11: - lp55xx device tree updates - mc13xxx driver updates - some clean up So please consider the following changes since commit 7d132055814ef17a6c7b69f342244c410a5e000f: Linux 3.10-rc6 (2013-06-15 11:51:07 -1000) are available in the git repository

[GIT PULL] leds: updates for 3.11

2013-07-02 Thread Bryan Wu
Hi Linus, LED subsystem updates for 3.11: - lp55xx device tree updates - mc13xxx driver updates - some clean up So please consider the following changes since commit 7d132055814ef17a6c7b69f342244c410a5e000f: Linux 3.10-rc6 (2013-06-15 11:51:07 -1000) are available in the git repository

Re: [PATCH] leds: Convert led class driver from legacy pm ops to dev_pm_ops

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 12:08 PM, Shuah Khan wrote: > Convert drivers/leds/led-class to use dev_pm_ops for power management and > remove Legacy PM ops hooks. With this change, led class registers > suspend/resume callbacks via class->pm (dev_pm_ops) instead of Legacy > class->suspend/resume. When

Re: [RFC PATCH] led: add Cycle LED trigger.

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 2:44 AM, Gaël PORTAY wrote: > On 19/06/2013 00:05, Joe Perches wrote: >> >> On Tue, 2013-06-18 at 18:24 +0200, Gaël PORTAY wrote: >>> >>> Currently, none of available triggers supports playing with the LED >>> brightness >>> level. The cycle trigger provides a way to

Re: [RFC PATCH] led: add Cycle LED trigger.

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 2:44 AM, Gaël PORTAY g.por...@overkiz.com wrote: On 19/06/2013 00:05, Joe Perches wrote: On Tue, 2013-06-18 at 18:24 +0200, Gaël PORTAY wrote: Currently, none of available triggers supports playing with the LED brightness level. The cycle trigger provides a way to

Re: [PATCH] leds: Convert led class driver from legacy pm ops to dev_pm_ops

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 12:08 PM, Shuah Khan shuah...@samsung.com wrote: Convert drivers/leds/led-class to use dev_pm_ops for power management and remove Legacy PM ops hooks. With this change, led class registers suspend/resume callbacks via class-pm (dev_pm_ops) instead of Legacy

Re: [PATCH 3.9-stable] leds: leds-gpio: reserve gpio before using it.

2013-05-22 Thread Bryan Wu
nd trace 5308fb20d2514822 ]--- > > Signed-off-by: Timo Teras > Cc: Sachin Kamat > Cc: Raphael Assenat > Cc: Trent Piepho > Cc: Javier Martinez Canillas > Cc: Arnaud Patard > Cc: Ezequiel Garcia > Acked-by: Jingoo Han > Signed-off-by: Bryan Wu > Signed-of

Re: [PATCH 3.9-stable] leds: leds-gpio: reserve gpio before using it.

2013-05-22 Thread Bryan Wu
-by: Jingoo Han jg1@samsung.com Signed-off-by: Bryan Wu coolo...@gmail.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- drivers/leds/leds-gpio.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c

[GIT PULL] leds fixes for 3.10-rc2

2013-05-21 Thread Bryan Wu
Hi Linus, We found a bug in leds-gpio driver, please consider to pull the following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at:

[GIT PULL] leds fixes for 3.10-rc2

2013-05-21 Thread Bryan Wu
Hi Linus, We found a bug in leds-gpio driver, please consider to pull the following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at:

Re: [PATCH] leds: leds-gpio: reserve gpio before using it

2013-05-20 Thread Bryan Wu
On Sun, May 19, 2013 at 5:39 PM, Jingoo Han wrote: > Friday, May 17, 2013 4:49 PM, Timo Teras wrote: >> >> This reverts commit a99d76f (leds: leds-gpio: use gpio_request_one) >> and commit 2d7c22f (leds: leds-gpio: set devm_gpio_request_one() >> flags param correctly) which was a fix of the first

Re: [PATCH] leds: leds-gpio: reserve gpio before using it

2013-05-20 Thread Bryan Wu
On Sun, May 19, 2013 at 5:39 PM, Jingoo Han jg1@samsung.com wrote: Friday, May 17, 2013 4:49 PM, Timo Teras wrote: This reverts commit a99d76f (leds: leds-gpio: use gpio_request_one) and commit 2d7c22f (leds: leds-gpio: set devm_gpio_request_one() flags param correctly) which was a fix of

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-05-14 Thread Bryan Wu
On Tue, May 14, 2013 at 10:16 AM, Andrew Morton wrote: > On Tue, 14 May 2013 10:12:04 -0700 Bryan Wu wrote: > >> On Tue, May 14, 2013 at 12:06 AM, Christian Gmeiner >> wrote: >> > 2013/5/12 Christian Gmeiner : >> >> 2013/3/8 Christian Gmeiner : >>

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-05-14 Thread Bryan Wu
On Tue, May 14, 2013 at 12:06 AM, Christian Gmeiner wrote: > 2013/5/12 Christian Gmeiner : >> 2013/3/8 Christian Gmeiner : >>> 2013/3/5 Bryan Wu : >>>> On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner >>>> wrote: >>>>> ping >>

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-05-14 Thread Bryan Wu
On Tue, May 14, 2013 at 12:06 AM, Christian Gmeiner christian.gmei...@gmail.com wrote: 2013/5/12 Christian Gmeiner christian.gmei...@gmail.com: 2013/3/8 Christian Gmeiner christian.gmei...@gmail.com: 2013/3/5 Bryan Wu coolo...@gmail.com: On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-05-14 Thread Bryan Wu
On Tue, May 14, 2013 at 10:16 AM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 14 May 2013 10:12:04 -0700 Bryan Wu coolo...@gmail.com wrote: On Tue, May 14, 2013 at 12:06 AM, Christian Gmeiner christian.gmei...@gmail.com wrote: 2013/5/12 Christian Gmeiner christian.gmei

Re: [PATCH 2/2] leds: lp5562: support the device tree feature

2013-05-08 Thread Bryan Wu
On Tue, May 7, 2013 at 1:00 PM, Linus Walleij wrote: > On Tue, May 7, 2013 at 9:14 AM, Kim, Milo wrote: > >> The LP55xx DT structure is applicable to the LP5562 device. >> The driver and documentation are updated. >> >> Compatible property of the DT >> : LP5521 and LP5223 were manufactured by

Re: [PATCH 1/2] leds: lp55xx: support dynamic channel settings in the device tree structure

2013-05-08 Thread Bryan Wu
On Tue, May 7, 2013 at 12:14 AM, Kim, Milo wrote: > Currently, the LP55xx DT structure supports max 3 channels. > However, LP5523 has max 9 channels and LP5562 has 4 channels. > To enhance this constraint, the DT structure has been changed. > > (a) Use the child node for various channel settings

Re: [PATCH 1/2] leds: lp55xx: support dynamic channel settings in the device tree structure

2013-05-08 Thread Bryan Wu
On Tue, May 7, 2013 at 12:14 AM, Kim, Milo milo@ti.com wrote: Currently, the LP55xx DT structure supports max 3 channels. However, LP5523 has max 9 channels and LP5562 has 4 channels. To enhance this constraint, the DT structure has been changed. (a) Use the child node for various

Re: [PATCH 2/2] leds: lp5562: support the device tree feature

2013-05-08 Thread Bryan Wu
On Tue, May 7, 2013 at 1:00 PM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, May 7, 2013 at 9:14 AM, Kim, Milo milo@ti.com wrote: The LP55xx DT structure is applicable to the LP5562 device. The driver and documentation are updated. Compatible property of the DT : LP5521 and

[GIT PULL] leds: updates for 3.10

2013-05-06 Thread Bryan Wu
Hi Linus, LED subsystem updates for 3.10: - move LED trigger drivers into a new directory - lp55xx common driver updates - other led drivers updates and bug fixing So please consider the following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31

[GIT PULL] leds: updates for 3.10

2013-05-06 Thread Bryan Wu
Hi Linus, LED subsystem updates for 3.10: - move LED trigger drivers into a new directory - lp55xx common driver updates - other led drivers updates and bug fixing So please consider the following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31

Re: leds-ss4200 oops in 3.7/3.8

2013-04-24 Thread Bryan Wu
On Tue, Apr 16, 2013 at 6:59 AM, Josh Boyer wrote: > Hi All, > > We've had a report[1] of the leds-ss4200 driver oopsing during device > initialization on both the 3.7 and 3.8 kernels. The backtrace is below. > In the same report a gentoo user posted a similar backtrace on 3.7.10, > and has

Re: [PATCH v2 11/11] leds: Remove leds-renesas-tpu driver

2013-04-24 Thread Bryan Wu
On Wed, Apr 24, 2013 at 1:50 PM, Laurent Pinchart wrote: > The driver is superseded by the generic rmob-tpu-pwm driver used with > leds-pwm. > > Signed-off-by: Laurent Pinchart It's nice to move to generic driver. Acked-by: Bryan Wu > --- > dr

Re: [PATCH v2 11/11] leds: Remove leds-renesas-tpu driver

2013-04-24 Thread Bryan Wu
. Acked-by: Bryan Wu coolo...@gmail.com --- drivers/leds/Kconfig | 12 - drivers/leds/Makefile | 1 - drivers/leds/leds-renesas-tpu.c| 336 - include/linux/platform_data/leds-renesas-tpu.h | 14

Re: leds-ss4200 oops in 3.7/3.8

2013-04-24 Thread Bryan Wu
On Tue, Apr 16, 2013 at 6:59 AM, Josh Boyer jwbo...@redhat.com wrote: Hi All, We've had a report[1] of the leds-ss4200 driver oopsing during device initialization on both the 3.7 and 3.8 kernels. The backtrace is below. In the same report a gentoo user posted a similar backtrace on 3.7.10,

Re: [PATCH 1/2] leds: lp55xx: use common clock framework when external clock is used

2013-03-25 Thread Bryan Wu
On Wed, Mar 20, 2013 at 5:37 PM, Kim, Milo wrote: > Program execution is timed with 32768Hz clock in the LP55xx family devices. > To run LED functionalities, LP55xx devices provide two options. > One is using internal clock. The other is using external clock. > This patch enables external clock

Re: [PATCH 1/2] leds: lp55xx: use common clock framework when external clock is used

2013-03-25 Thread Bryan Wu
On Wed, Mar 20, 2013 at 5:37 PM, Kim, Milo milo@ti.com wrote: Program execution is timed with 32768Hz clock in the LP55xx family devices. To run LED functionalities, LP55xx devices provide two options. One is using internal clock. The other is using external clock. This patch enables

Re: [PATCH 1/3] leds: move LED trigger drivers into new subdirectory

2013-03-15 Thread Bryan Wu
On Wed, Feb 20, 2013 at 1:29 AM, Kim, Milo wrote: >> For this kind of patches you should really use the "-M" flag of "git >> format-patch" to activate rename detection. The patch becomes much >> more >> readable. For example, the diffstat for this one using -M is: > > Thanks for useful tip! >

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Fri, Mar 15, 2013 at 1:09 PM, Florian Vaussard wrote: > Hi, > > > On 03/15/2013 07:59 PM, Thierry Reding wrote: >>> >>> >>> Hi Florian and Thierry, >>> >>> Sorry, guys. My bad! I'm using GMAIL filtering my emails. This email >>> goes into my arm-linux mail list archive and I totally missed it.

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Tue, Mar 12, 2013 at 3:06 AM, Florian Vaussard wrote: > Hi Bryan, > > > > Bryan, I assume that you'll be taking this? It doesn't apply cleanly to > my tree, probably because of Peter's recent changes that you took > through your tree and Florian based his patches on top of

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Tue, Mar 12, 2013 at 3:06 AM, Florian Vaussard florian.vauss...@epfl.ch wrote: Hi Bryan, Bryan, I assume that you'll be taking this? It doesn't apply cleanly to my tree, probably because of Peter's recent changes that you took through your tree and Florian based his patches on top of

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Fri, Mar 15, 2013 at 1:09 PM, Florian Vaussard florian.vauss...@epfl.ch wrote: Hi, On 03/15/2013 07:59 PM, Thierry Reding wrote: Hi Florian and Thierry, Sorry, guys. My bad! I'm using GMAIL filtering my emails. This email goes into my arm-linux mail list archive and I totally missed

Re: [PATCH 1/3] leds: move LED trigger drivers into new subdirectory

2013-03-15 Thread Bryan Wu
On Wed, Feb 20, 2013 at 1:29 AM, Kim, Milo milo@ti.com wrote: For this kind of patches you should really use the -M flag of git format-patch to activate rename detection. The patch becomes much more readable. For example, the diffstat for this one using -M is: Thanks for useful tip!

Re: [PATCH] leds: lp55xx: fix the sysfs read operation

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 5:19 PM, Kim, Milo wrote: > According to a sysfs documentation(Documentation/filesystem/sysfs.txt), > scnprintf() should be used in a read operation method. > It guarantees safe buffer size(PAGE_SIZE) which is allocated by the sysfs. > Oh, I missed that. Great, I merged

Re: [PATCH v2 0/3] leds: replace macros with inline functions and support camera LED triggers

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 4:29 AM, Kim, Milo wrote: > Patch v2 > (1) LED trigger macros are replaced with inline function in case of > !CONFIG_LED_TRIGGERS and !CONFIG_LEDS_TRIGGER_IDE_DISK. > (2) Use an inline function when CONFIG_LEDS_TRIGGER_CAMERA is not configured. > > Patch v1 >

Re: [PATCH v2 0/3] leds: replace macros with inline functions and support camera LED triggers

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 4:29 AM, Kim, Milo milo@ti.com wrote: Patch v2 (1) LED trigger macros are replaced with inline function in case of !CONFIG_LED_TRIGGERS and !CONFIG_LEDS_TRIGGER_IDE_DISK. (2) Use an inline function when CONFIG_LEDS_TRIGGER_CAMERA is not configured. Patch v1

Re: [PATCH] leds: lp55xx: fix the sysfs read operation

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 5:19 PM, Kim, Milo milo@ti.com wrote: According to a sysfs documentation(Documentation/filesystem/sysfs.txt), scnprintf() should be used in a read operation method. It guarantees safe buffer size(PAGE_SIZE) which is allocated by the sysfs. Oh, I missed that. Great,

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-13 Thread Bryan Wu
On Wed, Mar 13, 2013 at 4:16 PM, Kim, Milo wrote: >> > +#if defined(CONFIG_LEDS_TRIGGER_CAMERA) || >> defined(CONFIG_LEDS_TRIGGER_CAMERA_MODULE) >> > +extern void ledtrig_flash_ctrl(bool on); >> > +extern void ledtrig_torch_ctrl(bool on); >> > +#else >> > +#define ledtrig_flash_ctrl(x) do {}

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-13 Thread Bryan Wu
On Wed, Mar 13, 2013 at 4:16 PM, Kim, Milo milo@ti.com wrote: +#if defined(CONFIG_LEDS_TRIGGER_CAMERA) || defined(CONFIG_LEDS_TRIGGER_CAMERA_MODULE) +extern void ledtrig_flash_ctrl(bool on); +extern void ledtrig_torch_ctrl(bool on); +#else +#define ledtrig_flash_ctrl(x) do {}

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Tue, Mar 12, 2013 at 12:10 PM, Mark Brown wrote: > On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: >> On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > >> > + spinlock_t value_lock; > >> I think you don't need this spinlock to protect the

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > The Palmas familly of chips has LED support. This is not always muxed > to output pins so depending on the setting of the mux this driver > will create the appropriate LED class devices. > > Signed-off-by: Graeme Gregory > Signed-off-by: Ian

Re: [PATCH 3/3] leds: lm355x, lm3642: support Camera LED triggers for flash/torch

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo wrote: > LM355x and LM3642 support flash and torch functionality. > > (Camera driver) (LED trigger for camera) (LED driver) > Turn on the flash ...> ledtrig_flash_ctrl(true) ...> LM355x or LM3642 >

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo wrote: > Some LED devices support flash/torch functionality through the LED subsystem. > This patch enables direct LED trigger controls by the driver. > Flash on/off and torch on/off can be done simply by other driver space. > Two trigger APIs are

Re: [PATCH 1/2] leds: add new LP5562 LED driver

2013-03-12 Thread Bryan Wu
On Mon, Feb 18, 2013 at 9:10 PM, Kim, Milo wrote: > LP5562 can drive up to 4 channels, RGB and White. > LEDs can be controlled directly via the led class control interface. > > LP55xx common driver > LP5562 is one of LP55xx family device, so LP55xx common code are used. > On the other hand,

Re: [PATCH 1/2] leds: add new LP5562 LED driver

2013-03-12 Thread Bryan Wu
On Mon, Feb 18, 2013 at 9:10 PM, Kim, Milo milo@ti.com wrote: LP5562 can drive up to 4 channels, RGB and White. LEDs can be controlled directly via the led class control interface. LP55xx common driver LP5562 is one of LP55xx family device, so LP55xx common code are used. On the

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo milo@ti.com wrote: Some LED devices support flash/torch functionality through the LED subsystem. This patch enables direct LED trigger controls by the driver. Flash on/off and torch on/off can be done simply by other driver space. Two trigger

Re: [PATCH 3/3] leds: lm355x, lm3642: support Camera LED triggers for flash/torch

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo milo@ti.com wrote: LM355x and LM3642 support flash and torch functionality. (Camera driver) (LED trigger for camera) (LED driver) Turn on the flash ... ledtrig_flash_ctrl(true) ... LM355x or LM3642

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey i...@slimlogic.co.uk wrote: The Palmas familly of chips has LED support. This is not always muxed to output pins so depending on the setting of the mux this driver will create the appropriate LED class devices. Signed-off-by: Graeme Gregory

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Tue, Mar 12, 2013 at 12:10 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey i...@slimlogic.co.uk wrote: + spinlock_t value_lock; I think you don't need this spinlock

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-06 Thread Bryan Wu
On Tue, Mar 5, 2013 at 9:01 PM, Mark Brown wrote: > Provide some trace, though the hardware is most likely non-functional if > this happens. > Thanks for the update, I will merge it. -Bryan > Signed-off-by: Mark Brown > --- > drivers/leds/leds-wm8350.c |5 - > 1 file changed, 4

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-06 Thread Bryan Wu
On Tue, Mar 5, 2013 at 9:01 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Provide some trace, though the hardware is most likely non-functional if this happens. Thanks for the update, I will merge it. -Bryan Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com ---

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-05 Thread Bryan Wu
On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown wrote: > Provide some trace, though the hardware is most likely non-functional if > this happens. > > Signed-off-by: Mark Brown > --- > drivers/leds/leds-wm8350.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-03-05 Thread Bryan Wu
On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner wrote: > ping > -- > Christian Gmeiner, MSc > > > 2013/2/23 Christian Gmeiner : >> 2013/2/15 Bryan Wu : >>> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner >>> wrote: >>>> Duri

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-03-05 Thread Bryan Wu
On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner christian.gmei...@gmail.com wrote: ping -- Christian Gmeiner, MSc 2013/2/23 Christian Gmeiner christian.gmei...@gmail.com: 2013/2/15 Bryan Wu coolo...@gmail.com: On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner christian.gmei

Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

2013-03-05 Thread Bryan Wu
On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Provide some trace, though the hardware is most likely non-functional if this happens. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/leds/leds-wm8350.c |6 +- 1 file

Re: [GIT PULL] LED subsystem update for v3.9

2013-02-26 Thread Bryan Wu
On Tue, Feb 26, 2013 at 9:30 AM, Linus Torvalds wrote: > On Fri, Feb 22, 2013 at 6:21 PM, Bryan Wu wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git >> for-next > > Pulled, but I'd *really* like to see some human-readable explana

Re: [GIT PULL] LED subsystem update for v3.9

2013-02-26 Thread Bryan Wu
On Tue, Feb 26, 2013 at 9:30 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Feb 22, 2013 at 6:21 PM, Bryan Wu coolo...@gmail.com wrote: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next Pulled, but I'd *really* like to see some human-readable

[GIT PULL] LED subsystem update for v3.9

2013-02-22 Thread Bryan Wu
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch changes up to

[GIT PULL] LED subsystem update for v3.9

2013-02-22 Thread Bryan Wu
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch changes up to

Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

2013-02-15 Thread Bryan Wu
On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner wrote: > During the development of this driver an in-house register > documentation was used. The last weeks some integration tests > were done and this problem was found. It turned out that > the released register documentation is wrong. > > The

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

2013-02-04 Thread Bryan Wu
resumably missed this in the lkml flood. > > You are right... > > ~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c > Bryan Wu (maintainer:LED SUBSYSTEM) > Richard Purdie (maintainer:LED SUBSYSTEM) > linux-l...@vger.kernel.org (open list:LED SUBSYSTEM

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

2013-02-04 Thread Bryan Wu
a cc he presumably missed this in the lkml flood. You are right... ~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c Bryan Wu coolo...@gmail.com (maintainer:LED SUBSYSTEM) Richard Purdie rpur...@rpsys.net (maintainer:LED SUBSYSTEM) linux-l...@vger.kernel.org (open

Re: [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t'

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 3:43 PM, Kim, Milo wrote: > The printk format of type 'size_t' is not '%d' but '%zu' or '%zx'. > This patch fixes build warnings below. > > drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded: > drivers/leds/leds-lp5521.c:257:4: warning: format %d expects

Re: [PATCH 1/2] leds-lp5521: fix a build warning

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 7:08 AM, Nathan Lynch wrote: > On Wed, 2013-01-23 at 08:07 +, Kim, Milo wrote: >> This patch removes a build warning below.(ARCH=x86_64) >> >> drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded: >> drivers/leds/leds-lp5521.c:257:4: warning: format %d

Re: [PATCH] leds: leds-pwm: make it depend on PWM and not HAVE_PWM

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 12:35 AM, Peter Ujfalusi wrote: > The correct dependency for the leds-pwm is PWM and not HAVE_PWM > since PWM drivers now have their own subsystem. > Thanks, merged. -Bryan > Signed-off-by: Peter Ujfalusi > --- > drivers/leds/Kconfig | 2 +- > 1 file changed, 1

Re: [PATCH v2] leds: fix build error for LP55xx Common driver

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 1:38 AM, Kim, Milo wrote: > To solve undefined symbols for LED class and I2C, lp55xx-common driver should > support a module build as well. > > In case of CONFIG_I2C=m, CONFIG_LEDS_LP5521/5523=m, it still has undefined > symbol problems because CONFIG_LEDS_LP55XX_COMMON

Re: [PATCH v2] leds: fix build error for LP55xx Common driver

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 1:38 AM, Kim, Milo milo@ti.com wrote: To solve undefined symbols for LED class and I2C, lp55xx-common driver should support a module build as well. In case of CONFIG_I2C=m, CONFIG_LEDS_LP5521/5523=m, it still has undefined symbol problems because

Re: [PATCH] leds: leds-pwm: make it depend on PWM and not HAVE_PWM

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 12:35 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: The correct dependency for the leds-pwm is PWM and not HAVE_PWM since PWM drivers now have their own subsystem. Thanks, merged. -Bryan Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

Re: [PATCH 1/2] leds-lp5521: fix a build warning

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 7:08 AM, Nathan Lynch n...@pobox.com wrote: On Wed, 2013-01-23 at 08:07 +, Kim, Milo wrote: This patch removes a build warning below.(ARCH=x86_64) drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded: drivers/leds/leds-lp5521.c:257:4: warning: format %d

Re: [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t'

2013-01-23 Thread Bryan Wu
On Wed, Jan 23, 2013 at 3:43 PM, Kim, Milo milo@ti.com wrote: The printk format of type 'size_t' is not '%d' but '%zu' or '%zx'. This patch fixes build warnings below. drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded: drivers/leds/leds-lp5521.c:257:4: warning: format %d

Re: [PATCH] leds-lm355x: support LED trigger functionality

2013-01-09 Thread Bryan Wu
On Wed, Jan 9, 2013 at 5:42 PM, Kim, Milo wrote: >> -Original Message- >> From: Bryan Wu [mailto:coolo...@gmail.com] >> Sent: Thursday, January 10, 2013 10:16 AM >> To: Kim, Milo >> Cc: Jeong, Daniel; gshark.je...@gmail.com; linux-l...@vger.kernel.org; &

Re: [PATCH] leds-lm355x: support LED trigger functionality

2013-01-09 Thread Bryan Wu
On Mon, Jan 7, 2013 at 10:35 PM, Kim, Milo wrote: > LM355x family devices provide flash, torch and indicator functions. > This patch support LED trigger feature. > Using LED trigger APIs(), other driver simply turn on/off the flash, torch > and indicator. > > Platform data > the name of

Re: [PATCH] leds-lm355x: support LED trigger functionality

2013-01-09 Thread Bryan Wu
On Mon, Jan 7, 2013 at 10:35 PM, Kim, Milo milo@ti.com wrote: LM355x family devices provide flash, torch and indicator functions. This patch support LED trigger feature. Using LED trigger APIs(), other driver simply turn on/off the flash, torch and indicator. Platform data the

Re: [PATCH] leds-lm355x: support LED trigger functionality

2013-01-09 Thread Bryan Wu
On Wed, Jan 9, 2013 at 5:42 PM, Kim, Milo milo@ti.com wrote: -Original Message- From: Bryan Wu [mailto:coolo...@gmail.com] Sent: Thursday, January 10, 2013 10:16 AM To: Kim, Milo Cc: Jeong, Daniel; gshark.je...@gmail.com; linux-l...@vger.kernel.org; linux-kernel@vger.kernel.org

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2013-01-04 Thread Bryan Wu
On Thu, Dec 20, 2012 at 4:17 PM, Kim, Milo wrote: >> Hi Kim >> >> This patchset looks good, but I need some time to review it more >> carefully especially during this merge window + holiday time. > > OK, thanks for the reply. > Please let me know if any problem in the git tree. > Happy holidays!

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2013-01-04 Thread Bryan Wu
On Thu, Dec 20, 2012 at 4:17 PM, Kim, Milo milo@ti.com wrote: Hi Kim This patchset looks good, but I need some time to review it more carefully especially during this merge window + holiday time. OK, thanks for the reply. Please let me know if any problem in the git tree. Happy

Re: [PATCH] leds-lp8788: fix a parent device in _probe()

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 10:28 PM, Kim, Milo wrote: > The lp8788-keyled is a platform driver of lp8788-mfd. > The platform device is allocated when mfd_add_devices() is called > in lp8788-mfd. > On the other hand, 'lp->dev' is the i2c client device. > > Therefore, this 'platform_device' is a

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 11:22 PM, Thierry Reding wrote: > On Wed, Jan 02, 2013 at 06:10:13PM -0800, Bryan Wu wrote: >> Hi Peter, >> >> I merged this patchset into my for-next branch already. >> >> Thanks for pushing this. > > Hi Bryan, > > Did you

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 11:22 PM, Thierry Reding thierry.red...@avionic-design.de wrote: On Wed, Jan 02, 2013 at 06:10:13PM -0800, Bryan Wu wrote: Hi Peter, I merged this patchset into my for-next branch already. Thanks for pushing this. Hi Bryan, Did you also take the PWM patches (3-5

Re: [PATCH] leds-lp8788: fix a parent device in _probe()

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 10:28 PM, Kim, Milo milo@ti.com wrote: The lp8788-keyled is a platform driver of lp8788-mfd. The platform device is allocated when mfd_add_devices() is called in lp8788-mfd. On the other hand, 'lp-dev' is the i2c client device. Therefore, this

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-02 Thread Bryan Wu
documentation changed to reflect the changes > > Changes since v1: > - As suggested by Bryan Wu: the legacy pwm_request() has been removed from > patch 1 > - Device tree bindings added for leds-pwm driver. > > When we boot with Device tree we handle one LED per device to be mor

[GIT PULL] a LED fix for 3.8 (try2)

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for you to fetch changes up to

Re: [GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Sorry, I signed off with wrong email address. Please ignore this pull request email. I will resent one. -Bryan On Wed, Jan 2, 2013 at 5:50 PM, Bryan Wu wrote: > Hi Linus: > > Please consider the following changes since commit > a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: > > L

[GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git fixes-for-3.8 for you to fetch

[GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git fixes-for-3.8 for you to fetch

Re: [GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Sorry, I signed off with wrong email address. Please ignore this pull request email. I will resent one. -Bryan On Wed, Jan 2, 2013 at 5:50 PM, Bryan Wu coolo...@gmail.com wrote: Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux

[GIT PULL] a LED fix for 3.8 (try2)

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for you to fetch changes up to

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-02 Thread Bryan Wu
: - As suggested by Bryan Wu: the legacy pwm_request() has been removed from patch 1 - Device tree bindings added for leds-pwm driver. When we boot with Device tree we handle one LED per device to be more aligned with PWM core's DT implementation. An example of the DT usage is provided

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2012-12-18 Thread Bryan Wu
Hi Kim This patchset looks good, but I need some time to review it more carefully especially during this merge window + holiday time. Thanks, -Bryan On Wed, Dec 12, 2012 at 5:59 AM, Kim, Milo wrote: > LP5521, LP5523 and L55231 have common features as below. > > Register access via the I2C. >

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2012-12-18 Thread Bryan Wu
Hi Kim This patchset looks good, but I need some time to review it more carefully especially during this merge window + holiday time. Thanks, -Bryan On Wed, Dec 12, 2012 at 5:59 AM, Kim, Milo milo@ti.com wrote: LP5521, LP5523 and L55231 have common features as below. Register access via

[GIT PULL] LED subsystem update for v3.8

2012-12-13 Thread Bryan Wu
Hi Linus, Please consider to pull the following changes since commit 9489e9dcae718d5fde988e4a684a0f55b5f94d17: Linux 3.7-rc7 (2012-11-25 17:59:19 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch

[GIT PULL] LED subsystem update for v3.8

2012-12-13 Thread Bryan Wu
Hi Linus, Please consider to pull the following changes since commit 9489e9dcae718d5fde988e4a684a0f55b5f94d17: Linux 3.7-rc7 (2012-11-25 17:59:19 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch

Re: [PATCH 4/4] MAINTAINERS: add LP8788 MFD driver entry

2012-12-10 Thread Bryan Wu
On Sun, Dec 9, 2012 at 9:27 PM, Kim, Milo wrote: > Cc: Anton Vorontsov > Cc: Bryan Wu > Cc: Jonathan Cameron > Cc: Mark Brown > Cc: Samuel Ortiz > Signed-off-by: Milo(Woogyom) Kim Acked-by: Bryan Wu Thanks, -Bryan > --- > MAINTAINERS | 10 ++ > 1

Re: [PATCH 4/4] MAINTAINERS: add LP8788 MFD driver entry

2012-12-10 Thread Bryan Wu
On Sun, Dec 9, 2012 at 9:27 PM, Kim, Milo milo@ti.com wrote: Cc: Anton Vorontsov c...@mail.ru Cc: Bryan Wu coolo...@gmail.com Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Milo(Woogyom) Kim

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-04 Thread Bryan Wu
On Tue, Dec 4, 2012 at 12:11 AM, Peter Ujfalusi wrote: > Hi Bryan, > > On 12/03/2012 07:32 PM, Bryan Wu wrote: >> On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi wrote: >> Actually, I'm waiting for some feedback from DT maintainers about this >> new binding. But it

<    1   2   3   4   5   6   7   8   9   10   >