> From: Sven Van Asbroeck
>
> Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git #
> 9ec5eea5b6ac
>
> v2 -> v3:
> - Bryan Whitehead:
> + add Bryan's reviewed-by tag to patch 1/5.
> + Only use FRAME_LENGTH if the LS bit is checked.
> If set use the smaller of
> From: Sven Van Asbroeck
>
> On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very
> expensive operation, because its resulting sync needs to invalidate cpu
> caches.
>
> Increase efficiency/performance by syncing only those sections of the
> lan743x's rx ring buffers that
> Will do. Are you planning to hold off your tests until v3? It shouldn't take
> too
> long.
Sure, we will wait for v3
Hi Sven, see below.
> + if (buffer_info->dma_ptr) {
> + /* unmap from dma */
> + packet_length = RX_DESC_DATA0_FRAME_LENGTH_GET_
> + (le32_to_cpu(descriptor->data0));
> + if (packet_length == 0 ||
> +
Hi Sven,
> Subject: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs
> w/o dma cache snooping
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> From: Sven Van Asbroeck
>
> The buffers in the lan743x driver's receive ring are
Hi Sven, see below
> - Bryan Whitehead:
> + multi-buffer patch concept "looks good".
> As a result, I will squash the intermediate "dma buffer only" patch
> which
> demonstrated the speed boost using an inflexible solution
> (w/o multi-buffers).
> + Rename
> On Wed, Feb 3, 2021 at 3:14 PM wrote:
> >
> > We can test on x86 PC. We will just need about a week after you release
> your next version.
> >
>
> That's great. If you have any suggestions on how I can improve testing on my
> end, feel free to reach out.
If you are able, in addition to basic
Hi Sven,
We can test on x86 PC. We will just need about a week after you release your
next version.
Thanks,
Bryan
> -Original Message-
> From: Sven Van Asbroeck
> Sent: Wednesday, February 3, 2021 1:53 PM
> To: Bryan Whitehead - C21958
> Cc: UNGLinuxDriver ; David Miller
> ; Jakub
Hi Sven, see below
> >
> > If lan743x_rx_init_ring_element fails to allocate an skb, Then
> > lan743x_rx_reuse_ring_element will be called.
> > But that function expects the skb is already allocated and dma mapped.
> > But the dma was unmapped above.
>
> Good catch. I think you're right, the skb
Hi Sven,
Looks good.
see comments below.
> static int lan743x_rx_process_packet(struct lan743x_rx *rx) {
It looks like this function no longer processes a packet, but rather only
processes a single buffer.
So perhaps it should be renamed to lan743x_rx_process_buffer, so it is not
Sven, see below comments
> @@ -2148,11 +2149,18 @@ static int lan743x_rx_process_packet(struct
> lan743x_rx *rx)
> descriptor = >ring_cpu_ptr[first_index];
>
> /* unmap from dma */
> + packet_length =
> -Original Message-
> From: Roelof Berg
> Sent: Sunday, May 17, 2020 4:45 PM
> To: Andrew Lunn
> Cc: Bryan Whitehead - C21958 ;
> UNGLinuxDriver ; David S. Miller
> ; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] lan743x: Added fixed link support
>
>
12 matches
Mail list logo
