On Wed, Aug 26, 2020 at 04:49:33PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
f-by: Sebastian Krzyszkowiak
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Hallo
Ich bin Charles W. Jackson aus North Carolina, Vereinigte Staaten von Amerika,
und ich bin der Gewinner des Mega-Millionen-Jackpots von 344 Millionen
US-Dollar. Ich spende die Summe von 2.000.000 Millionen Euro als Teil der
Hilfsgelder für das Corona-Virus.
Dies ist Ihr Spendencode
--
Herzlichen Glückwunsch, die Summe von 55.000,00 Euro wurde Ihnen von
Charles W. Jackson Jr. gespendet. Ich habe beim Powerball-Jackpot
344,6 Millionen Dollar gewonnen.
Dieser Sieg ist ein Segen. Deshalb habe ich beschlossen, der
Öffentlichkeit etwas zurückzugeben. Dies bedeutet, dass ich
the new MFD mfd_remove_devices_late functionality to split
the DCVDD regulator off from the other drivers.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd
/20200616075834.GF2608702@dell/
Suggested-by: Lee Jones
Signed-off-by: Charles Keepax
---
drivers/mfd/mfd-core.c | 16 +++-
include/linux/mfd/core.h | 5 +
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index
> ---
Worth noting I haven't actually tested the gapless, but keeps all
the compressed capture stuff happy.
Tested-by: Charles Keepax
Reviewed-by: Charles Keepax
Thanks,
Charles
--
Hallo
Ich bin Charles W. Jackson aus North Carolina, Vereinigte Staaten von Amerika,
und ich bin der Gewinner des Mega-Millionen-Jackpots von 344 Millionen
US-Dollar. Ich spende die Summe von 2.000.000 Millionen Euro als Teil der
Hilfsgelder fr das Corona-Virus.
Dies ist Ihr
On Thu, Jun 25, 2020 at 09:16:49PM +0530, Vinod Koul wrote:
> So we had some discussions of the stream states, so I thought it is a
> good idea to document the state transitions, so add it documentation
>
> Signed-off-by: Vinod Koul
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
rning: Function parameter or
> member 'pdata' not described in 'wm8350_register_led'
>
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
->trigger(stream, SNDRV_PCM_TRIGGER_STOP);
> if (!retval) {
> + /* clear flags and stop any drain wait */
> + stream->partial_drain = false;
> + stream->metadata_set = false;
> snd_compr_drain_notify(stream);
that can be called from snd_compr_stop here which is already
holding the lock resulting in deadlock.
Thanks,
Charles
bed in 'wm8400_register_regulator'
> drivers/regulator/wm8400-regulator.c:243: warning: Function parameter or
> member 'initdata' not described in 'wm8400_register_regulator'
>
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ck'
> drivers/mfd/wm831x-core.c:145: warning: Function parameter or member
> 'wm831x' not described in 'wm831x_reg_unlock'
>
> Cc:
> Cc: Mark Brown
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
et_codec_reg_cache'
>
> Cc:
> Cc: Mark Brown
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
e can go from running to free directly? is
> this really a legit transition? There's already the option of doing
> a stop and a a drain.
>
This is allowed in the current code, the kernel sends the stop
internally in this case, so it kinda does go through the setup
state just not from the users view point. I am not sure I have a
good handle on if that makes sense or not.
> c) no way to stop a paused stream?
Currently the code does allow this and it certainly makes sense
so should probably be added.
Thanks,
Charles
When a register patch is registered the reg_sequence is copied but the
memory allocated is never freed. Add a kfree in regmap_exit to clean it
up.
Fixes: 22f0d90a3482 ("regmap: Support register patch sets")
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap.c | 1 +
1 file
/20200616075834.GF2608702@dell/
Suggested-by: Lee Jones
Signed-off-by: Charles Keepax
---
Changes since v2:
- Removed old tag system and now just have 2 levels, one removed
by new mfd_remove_devices_late
Thanks,
Charles
drivers/mfd/mfd-core.c | 16 +++-
include/linux/mfd
the new MFD mfd_remove_devices_late functionality to split
the DCVDD regulator off from the other drivers.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Moved to new mfd_remove_devices_late
Thanks,
Charles
drivers/mfd/madera-core.c | 23 +++
1 file changed, 15
On Tue, Jun 16, 2020 at 02:22:59PM +0100, Lee Jones wrote:
> On Tue, 16 Jun 2020, Charles Keepax wrote:
> > On Tue, Jun 16, 2020 at 10:15:45AM +0100, Lee Jones wrote:
> > > On Tue, 16 Jun 2020, Charles Keepax wrote:
> > > > On Tue, Jun 16, 2020 at 08:
On Tue, Jun 16, 2020 at 10:15:45AM +0100, Lee Jones wrote:
> On Tue, 16 Jun 2020, Charles Keepax wrote:
> > On Tue, Jun 16, 2020 at 08:58:34AM +0100, Lee Jones wrote:
> > > On Mon, 15 Jun 2020, Charles Keepax wrote:
> > Does this match how you would expect this to be u
On Tue, Jun 16, 2020 at 08:58:34AM +0100, Lee Jones wrote:
> On Mon, 15 Jun 2020, Charles Keepax wrote:
> > Happy to discuss other approaches as well, but this one
modified by the core
and can even by automatically generated. Using the name alone would
work for my usecase but it is not hard to imagine a situation where it
wouldn't.
Signed-off-by: Charles Keepax
---
Following on from our discussions here
n.
Signed-off-by: Charles Keepax
---
No changes since v1.
Thanks,
Charles
drivers/mfd/madera-core.c | 73 +--
1 file changed, 58 insertions(+), 15 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 4724c1a01a39f..30a
This forward declaration is redundant since the header including the
full data structure is included.
Signed-off-by: Charles Keepax
---
New since v1 of the series.
Thanks,
Charles
include/linux/mfd/madera/pdata.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mfd/madera
generate a warning on unbind.
Add clean up on both the probe error path and unbind for the 32k
clock.
Fixes: cdd8da8cc66b ("mfd: arizona: Add gating of external MCLKn clocks")
Signed-off-by: Charles Keepax
---
No changes since v1.
Thanks,
Charles
drivers/mfd/arizona-c
The mfd_cell structures inconsistently use commas on single entries in
the table, make this consistent by always using a comma. Also remove an
extra blank line.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Added some additional commit description.
- Move the removing and unused
BUG_ON macros are generally frowned upon when the issue isn't super
critical, the kernel can certainly carry on with the 32k clock on the
CODEC in a bad state so change the BUG_ON to a WARN_ON.
Signed-off-by: Charles Keepax
---
No changes since v1.
Thanks,
Charles
drivers/mfd/arizona-core.c
On Thu, Jun 11, 2020 at 03:14:23PM +0530, Vinod Koul wrote:
> On 11-06-20, 11:09, Jaroslav Kysela wrote:
> > Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a):
> > > On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote:
> > > > On 10-06-20, 12:40, Jaroslav Kyse
t;
> >
> > The snd_compr_drain_notify() is called only from snd_compr_stop(). Something
> > is missing in this sequence?
>
> It is supposed to be invoked by driver when partial drain is complete..
> both intel and sprd driver are calling this. snd_compr_stop is stop
> while draining case so legit
>
Not sure I follow this statement, could you elaborate a bit?
snd_compr_stop putting the state to RUNNING seems fundamentally
broken to me, the whole point of snd_compr_stop is to take the
state out of RUNNING.
Thanks,
Charles
> Signed-off-by: Navid Emamdoost
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Thu, Jun 04, 2020 at 09:52:07PM -0500, Navid Emamdoost wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost
> ---
Acked-
On Thu, Jun 04, 2020 at 09:47:13PM -0500, Navid Emamdoost wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put_sync if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost
> ---
On Wed, May 27, 2020 at 01:43:29PM -0600, Rob Herring wrote:
> On Wed, May 13, 2020 at 10:57:17AM +0100, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax
> > ---
> > +LDOVDD-supply:
> > + description:
> > +Digital power supply,
On Mon, Jun 01, 2020 at 06:24:33AM +0100, Lee Jones wrote:
> On Fri, 29 May 2020, Charles Keepax wrote:
>
> Still needs a commit log.
>
> > Signed-off-by: Charles Keepax
> > ---
> > drivers/mfd/madera-core.c| 12 ++--
> > drivers/mfd/made
BUG_ON macros are generally frowned upon when the issue isn't super
critical, the kernel can certainly carry on with the 32k clock on the
CODEC in a bad state so change the BUG_ON to a WARN_ON.
Signed-off-by: Charles Keepax
---
drivers/mfd/arizona-core.c | 2 +-
1 file changed, 1 insertion
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c| 12 ++--
drivers/mfd/madera-i2c.c | 1 -
include/linux/mfd/madera/pdata.h | 1 -
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index
generate a warning on unbind.
Add clean up on both the probe error path and unbind for the 32k
clock.
Fixes: cdd8da8cc66b ("mfd: arizona: Add gating of external MCLKn clocks")
Signed-off-by: Charles Keepax
---
drivers/mfd/arizona-core.c | 18 ++
1 file changed, 18
Add new trace points for the start and end of enabling bypass on a
regulator, to allow monitoring of when regulators are moved into bypass
and how long that takes.
Signed-off-by: Charles Keepax
---
drivers/regulator/core.c | 9 +
include/trace/events/regulator.h | 32
by: Dinghao Liu
> ---
Acked-by: Charles Keepax
Thanks,
Charles
--
YOUR EMAIL ACCOUNT WAS SELECTED FOR A DONATION OF $3,500,000.00 FOR
CHARITY. PLEASE CONTACT CHARLES JACKSON WITH THIS EMAIL
ej331...@gmail.com
TO CLAIM YOUR DONATION:
that case I don't think there is any reason why
we need to put before calling input_device_register so it might
just be simplest to move that put until after registering the
input device.
Thanks,
Charles
> gpiod_put(info->micd_pol_gpio);
> err_register:
> pm_runtime_disable(>dev);
> --
> 2.17.1
>
On Mon, May 11, 2020 at 04:53:32PM +0100, Charles Keepax wrote:
> Currently, the only way to remove MFD children is with a call to
> mfd_remove_devices, which will remove all the children. Under
> some circumstances it is useful to remove only a subset of the
> child devices. For exa
Signed-off-by: Charles Keepax
---
Changes since v2:
- Remove some more redundant descriptions
- Force pinctrl node to be called "pin-settings"
- Force suffix on individual config nodes to -pins
Thanks,
Charles
.../bindings/pinctrl/cirrus,madera-pinctrl.txt
Signed-off-by: Charles Keepax
---
Changes since v2:
- Removed a couple more redundant descriptions
Thanks,
Charles
Documentation/devicetree/bindings/mfd/arizona.txt | 101 ---
.../devicetree/bindings/mfd/wlf,arizona.yaml | 289 +
MAINTAINERS
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/sound/wlf,arizona.txt | 53 --
.../devicetree/bindings/sound/wlf,arizona.yaml | 114 +
2 files changed, 114 insertions(+), 53 deletions(-)
delete mode 100644
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../bindings/regulator/arizona-regulator.txt | 18 ---
.../devicetree/bindings/regulator/wlf,arizona.yaml | 37 ++
2 files changed, 37 insertions(+), 18 deletions(-)
delete mode 100644
Acked-by: Chanwoo Choi
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/extcon/extcon-arizona.txt | 76 -
.../devicetree/bindings/extcon/wlf,arizona.yaml| 125 +
2 files changed, 125 insertions(+), 76
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/sound/cirrus,madera.yaml | 113 +
Documentation/devicetree/bindings/sound/madera.txt | 67
2 files changed, 113 insertions(+), 67 deletions(-)
create mode 100644
Signed-off-by: Charles Keepax
---
Changes since v2:
- Removed some more redundant descriptions
- Updated pinctrl node naming in the example
Thanks,
Charles
.../devicetree/bindings/mfd/cirrus,madera.yaml | 311 +
Documentation/devicetree/bindings/mfd/madera.txt
t;
> /* SYSCLK defaults to on; make sure it is off so we can safely
> * write to registers if the device is declocked.
>
> Fixes: c38b608504aa ("ASoC: wm8962: set CLOCKING2 as non-volatile register")
> Signed-off-by: Shengjiu Wang
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Wed, May 06, 2020 at 04:57:52PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax
> ---
Will update this series to match comments on my Lochnagar series
as well.
Thanks,
Charles
Signed-off-by: Charles Keepax
---
Changes since v2:
- Removed description for gpio-controller
- Force pin node to be called pin-settings
- Simplify -pins pattern
- Add additional blank line
Thanks,
Charles
.../bindings/pinctrl/cirrus,lochnagar.txt | 141
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/clock/cirrus,lochnagar.txt | 94 --
.../bindings/clock/cirrus,lochnagar.yaml | 78 ++
2 files changed, 78 insertions(+), 94 deletions(-)
delete mode
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/mfd/cirrus,lochnagar.txt | 85 -
.../devicetree/bindings/mfd/cirrus,lochnagar.yaml | 352 +
.../bindings/regulator/cirrus,lochnagar.txt| 82 -
MAINTAINERS
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/sound/cirrus,lochnagar.txt | 39
.../bindings/sound/cirrus,lochnagar.yaml | 52 ++
2 files changed, 52 insertions(+), 39 deletions(-)
delete mode
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
.../devicetree/bindings/hwmon/cirrus,lochnagar.txt | 26
.../bindings/hwmon/cirrus,lochnagar.yaml | 35 ++
2 files changed, 35 insertions(+), 26 deletions(-)
delete mode
On Tue, May 12, 2020 at 08:49:49AM -0500, Rob Herring wrote:
> On Mon, May 04, 2020 at 04:47:57PM +0100, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax
> > ---
> >
> > Changes since v1:
> > - Removed contains on the compatible
> > - Moved all
n.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Added MFD by tag thing and removed the regulator parts
Thanks,
Charles
drivers/mfd/madera-core.c | 73 +--
1 file changed, 58 insertions(+), 15 deletions(-)
diff --git a/drivers/mfd/mader
modified by the core
and can even by automatically generated. Using the name alone would
work for my usecase but it is not hard to imagine a situation where it
wouldn't.
Signed-off-by: Charles Keepax
---
Following on from our discussions here:
https://lore.kernel.org/lkml/20200122110842.10702-2
g, if
so it would be good if you could elaborate on them? My understanding
is that since this driver uses devm_input_allocate_device
input_unregister_device will be handled automatically, see the
comments on input_register_device/devm_input_allocate_device.
Thanks,
Charles
> free_irq(wm83
Signed-off-by: Charles Keepax
---
Changes since v1:
- Removed some description that duplicates constraints
Thanks,
Charles
.../devicetree/bindings/extcon/extcon-arizona.txt | 76 -
.../devicetree/bindings/extcon/wlf,arizona.yaml| 125 +
2 files changed
Signed-off-by: Charles Keepax
---
Changes since v1:
- Removed some description that duplicates constraints
Thanks,
Charles
.../devicetree/bindings/sound/wlf,arizona.txt | 53 --
.../devicetree/bindings/sound/wlf,arizona.yaml | 114 +
2 files changed, 114
Signed-off-by: Charles Keepax
---
No changes since v1.
Thanks,
Charles
.../bindings/regulator/arizona-regulator.txt | 18 ---
.../devicetree/bindings/regulator/wlf,arizona.yaml | 37 ++
2 files changed, 37 insertions(+), 18 deletions(-)
delete mode 100644
Signed-off-by: Charles Keepax
---
New since v1, putting in the same series as Arizona since they share the
same regulator binding.
Thanks,
Charles
.../devicetree/bindings/mfd/cirrus,madera.yaml | 317 +
Documentation/devicetree/bindings/mfd/madera.txt | 114
Signed-off-by: Charles Keepax
---
New since v1, putting in the same series as Arizona since they share the
same regulator binding.
Thanks,
Charles
.../devicetree/bindings/sound/cirrus,madera.yaml | 113 +
Documentation/devicetree/bindings/sound/madera.txt | 67
Signed-off-by: Charles Keepax
---
New since v1, putting in the same series as Arizona since they share the
same regulator binding.
Thanks,
Charles
.../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 --
.../devicetree/bindings/pinctrl/cirrus,madera.yaml | 147
Signed-off-by: Charles Keepax
---
Changes since v1:
- Removed some description that duplicates constraints
- Added some blank lines for readability
Thanks,
Charles
Documentation/devicetree/bindings/mfd/arizona.txt | 101 ---
.../devicetree/bindings/mfd/wlf,arizona.yaml | 298
Signed-off-by: Charles Keepax
---
Changes since v1:
- Moved sub-nodes into MFD file leaving just the properties in here
- Removed contains on the compatible
- Made clock descriptions comments rather than being in the description
Thanks,
Charles
.../devicetree/bindings/clock/cirrus
Signed-off-by: Charles Keepax
---
Changes since v1:
- Moved sub-node into MFD file leaving just the properties in here
- Removed contains on the compatible
- Added a required -pins suffix for pinmux/ctrl nodes
- Added some extra blank lines for readability
Thanks,
Charles
.../bindings
Signed-off-by: Charles Keepax
---
Changes since v1:
- Moved sub-node into MFD file leaving just the properties in here
- Removed contains on the compatible
- Removed some pointless descriptions
Thanks,
Charles
.../devicetree/bindings/sound/cirrus,lochnagar.txt | 39
Signed-off-by: Charles Keepax
---
Changes since v1:
- Moved sub-node into MFD file leaving just the properties in here
- Removed contains on the compatible
Thanks,
Charles
.../devicetree/bindings/hwmon/cirrus,lochnagar.txt | 26
.../bindings/hwmon/cirrus,lochnagar.yaml
Signed-off-by: Charles Keepax
---
Changes since v1:
- Removed contains on the compatible
- Moved all sub-nodes into here directly only using $ref for properties
- As the regulator binding only contained subnodes that file is now deleted
- Removed some pointless descriptions
A little nervous
On Fri, May 01, 2020 at 03:47:21PM -0500, Rob Herring wrote:
> On Mon, Apr 27, 2020 at 10:36:14AM +0000, Charles Keepax wrote:
> > On Mon, Apr 27, 2020 at 11:28:12AM +0100, Charles Keepax wrote:
> > > Signed-off-by: Charles Keepax
> > > ---
> >
s just DBVDD-supply instead of DBVDDn-supply (n: <1,3>).
>
> Reported-by: Jonathan Bakker
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
&& !UML && SND [=y] && SND_SOC
> [=y] && SND_PXA2XX_SOC [=m] && (MACH_EM_X270 [=n] || MACH_EXEDA [=n] ||
> MACH_CM_X300 [=y]) && AC97_BUS [=n]=n
>
> Change the dependency to allow either version of the AC97 library
> code.
>
> Fixes: 5a309875787d ("ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout")
> Signed-off-by: Arnd Bergmann
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Save a few bytes by removing some registers from the driver that are not
currently used and not intended to be used at any point in the future.
Signed-off-by: Charles Keepax
---
drivers/mfd/wm8998-tables.c | 12
include/linux/mfd/arizona/registers.h | 7 ---
2 files
Add the 3 input clock sources for the chip into the device tree binding
document.
Reviewed-by: Rob Herring
Signed-off-by: Charles Keepax
---
Documentation/devicetree/bindings/mfd/madera.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd
Add the ability to get the clock for each clock input pin of the chip
and enable MCLK2 since that is expected to be a permanently enabled
32kHz clock.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 27 ++-
include/linux/mfd/madera/core.h | 11
On Thu, Oct 10, 2019 at 10:29:56PM +0200, Arnd Bergmann wrote:
> This header is empty and conflicts with the s3c24xx version
> of the same file when we merge the two, so stop including it.
>
> Signed-off-by: Arnd Bergmann
> ---
Acked-by: Charles Keepax
Thanks,
Charles
speaker
> >>>>amplifiers.
> >>>>
> >>>>Currently this driver is blocked on this patch, If you think
> >>>>there are other ways to do this, am happy to try them out.
> >>>
> >>>So to be clear, you are *not* using snd_soc_dai_set_sdw_stream?
> >>Yes, am not using snd_soc_dai_set_sdw_stream().
> >
> >It's been a while since this thread started, and I still don't
> >quite get the concepts or logic.
> >
> >First, I don't understand what the problem with "aux" devices is.
> >All the SoundWire stuff is based on the concept of DAI, so I guess
> >I am
>
> That is the actual problem! Some aux devices does not have dais.
>
Usually aux devices are used for things like analog amplifiers that
clearly don't have a digital interface, thus it really makes no sense
to have a DAI link connecting them. So I guess my question here
would be what is the thinking on making the "smart amplifier" dailess?
It feels like having a CODEC to CODEC DAI between the CODEC and
the AMP would be a more obvious way to connect the two devices
and would presumably avoid the issues being discussed around the
patch.
Thanks,
Charles
Add the ability to get the clock for each clock input pin of the chip
and enable MCLK2 since that is expected to be a permanently enabled
32kHz clock.
Signed-off-by: Charles Keepax
---
Changes since v4:
- Change (ret != 0) to (!ret)
drivers/mfd/madera-core.c | 27
Save a few bytes by removing some registers from the driver that are not
currently used and not intended to be used at any point in the future.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Add more commit message
drivers/mfd/wm8998-tables.c | 12
include/linux
Add the 3 input clock sources for the chip into the device tree binding
document.
Reviewed-by: Rob Herring
Signed-off-by: Charles Keepax
---
No changes since v3.
Documentation/devicetree/bindings/mfd/madera.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation
On Fri, Oct 04, 2019 at 03:34:10PM +0100, Lee Jones wrote:
> On Tue, 01 Oct 2019, Charles Keepax wrote:
>
> > Add the ability to get the clock for each clock input pin of the chip
> > and enable MCLK2 since that is expected to be a permanently enabled
> > 32kHz cl
t; Note that we will lose "arizona /RESET" custom GPIO label, but since we
> do not set such custom label when using the modern binding, I opted to
> not having it here either.
>
> Signed-off-by: Dmitry Torokhov
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Signed-off-by: Charles Keepax
---
Patch is new to the series.
Thanks,
Charles
drivers/mfd/wm8998-tables.c | 12
include/linux/mfd/arizona/registers.h | 7 ---
2 files changed, 19 deletions(-)
diff --git a/drivers/mfd/wm8998-tables.c b/drivers/mfd/wm8998-tables.c
Add the ability to get the clock for each clock input pin of the chip
and enable MCLK2 since that is expected to be a permanently enabled
32kHz clock.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Use new devm_clk_bulk_get_optional API
Thanks,
Charles
drivers/mfd/madera-core.c
Add the 3 input clock sources for the chip into the device tree binding
document.
Reviewed-by: Rob Herring
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
Documentation/devicetree/bindings/mfd/madera.txt | 8
1 file changed, 8 insertions(+)
diff --git
The VDDCORE regulator takes a good length of time to discharge down, so
add an on_off_delay to ensure DCVDD is removed before it is powered on
again.
Signed-off-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator
less at this point, so I hope you can give me some hints on what's
> going bad here.
>
Not sure I can add much in terms of a solution, but I can at
least confirm I am seeing exactly the same issue, on my Zynq
based ARM system.
Thanks,
Charles
I had issues with that plic driver. The current implementation wasn't
usable with driver using level sensitive interrupt together with the
IRQF_ONESHOT flag.
Those null were producing crashes in the chained_irq_enter function.
Filling them with dummy function fixed the issue.
On Sat, Sep 14,
Hej modtager
Mit navn er Charles W. Jackson Jr, vinder af Power Ball Jackpot i juni
2019 på $ 344 millioner.
Jeg donerer $ 4.600.000 til dig til velgørenhed for at hjælpe dig og
de fattige i dit samfund. Det gjorde jeg til minde om min afdøde
kone, der døde af kræft for nogle år tilbage
under the 80 char line limit.
.clk_ref_map = {
},
> @@ -2165,6 +1951,19 @@ static int wm8904_i2c_probe(struct i2c_client *i2c,
> /* Can leave the device powered off until we need it */
> + wm8904_disable_sysclk(wm8904);
How come this is now enabled during probe?
I trimmed down the CC list, for the next version I would suggest
using a similar list, this one was a little over sized.
Thanks,
Charles
ntrol_new rin_mode =
> + SOC_DAPM_ENUM("right Capture Mode", rin_mode_enum);
Minor nit missing a captial on the right here.
Otherwise looks good:
Acked-by: Charles Keepax
Thanks,
Charles
On Tue, Aug 20, 2019 at 12:33:29PM +0200, Michał Mirosław wrote:
> Trivial fix for typo in "Capture Inverting Mux"es' name.
>
> Signed-off-by: Michał Mirosław
> ---
Acked-by: Charles Keepax
Thanks,
Charles
t;ASoC: Add initial WM8737 driver")
> Signed-off-by: YueHaibing
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Add the ability to get the clock for each clock input pin of the chip
and enable MCLK2 since that is expected to be a permanently enabled
32kHz clock.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Fail probe if we encounter a clock error
- Print a warning if MCLK2 is not specified
Add the 3 input clock sources for the chip into the device tree binding
document.
Signed-off-by: Charles Keepax
---
No changes since v1.
Thanks,
Charles
Documentation/devicetree/bindings/mfd/madera.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree
On Tue, Aug 13, 2019 at 08:18:14AM +0100, Lee Jones wrote:
> On Mon, 12 Aug 2019, Charles Keepax wrote:
> > On Mon, Aug 12, 2019 at 11:38:53AM +0100, Lee Jones wrote:
> > > On Tue, 06 Aug 2019, Charles Keepax wrote:
> > >
> > > > Add the ability to
ect everybody to compile with a baseline set of ISA extentions, to
make binary exchanges easier.
But for smaller systems, i do not see advantages having RVC forced.
On Mon, Aug 12, 2019 at 5:03 PM Christoph Hellwig wrote:
>
> On Thu, Aug 08, 2019 at 02:18:53PM +0200, Charles Papon wrote:
&
101 - 200 of 3625 matches
Mail list logo
