On Mon, Aug 12, 2019 at 11:38:53AM +0100, Lee Jones wrote:
> On Tue, 06 Aug 2019, Charles Keepax wrote:
>
> > Add the ability to get the clock for each clock input pin of the chip
> > and enable MCLK2 since that is expected to be a permanently enabled
> > 32kHz cl
Some error paths in regmap_irq_thread put the pm_runtime others do not,
there is no reason to leave the pm_runtime enabled in some cases so
update those paths to also put the pm_runtime.
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap-irq.c | 7 +--
1 file changed, 1 insertion
Please do not drop it.
Compressed instruction extension has some specific overhead in small
RISC-V FPGA softcore, especialy in the ones which can't implement the
register file read in a asynchronous manner because of the FPGA
technology.
What are reasons to enforce RVC ?
On Wed, Aug 7, 2019 at
Add the 3 input clock sources for the chip into the device tree binding
document.
Signed-off-by: Charles Keepax
---
Documentation/devicetree/bindings/mfd/madera.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/madera.txt
b/Documentation
Add the ability to get the clock for each clock input pin of the chip
and enable MCLK2 since that is expected to be a permanently enabled
32kHz clock.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 24 +++-
include/linux/mfd/madera/core.h | 11
ons.
>
> Cc: Charles Keepax
> Cc: Richard Fitzgerald
> Signed-off-by: Stephen Boyd
> ---
>
Acked-by: Charles Keepax
Thanks,
Charles
ving the mutex so
> that no one re-reads "diagnostic" within the 5s poll timeout.
>
> Alternatively, this diagnostic feature could be handled with an
> external-handler
> kcontrol SOC_SINGLE_EXT? I'm not sure if this is an atomic interface either.
>
> What would be acceptable?
You could take the DAPM mutex in your debugfs handler that would
prevent any changes to the cards power state whilst your debug
stuff is running.
Thanks,
Charles
On Tue, Jul 30, 2019 at 03:04:19PM +0100, Thomas Preston wrote:
> On 30/07/2019 13:41, Charles Keepax wrote:
> >> +static int tda7802_bulk_update(struct regmap *map, struct reg_update
> >> *update,
> >> + size_t update_count)
> >> +{
> >
err = debugfs_create_file("diagnostic", 0444, tda7802->debugfs, tda7802,
> + _diagnostic_fops);
> + if (err < 0) {
> + dev_err(dev,
> + "debugfs: Failed to create diagnostic node, err %d\n",
> + err);
> + goto cleanup_diagnostic;
> + }
You shouldn't be failing the driver probe if debugfs fails, it
should be purely optional.
Thanks,
Charles
syncing that implies the hardware registers
have lost state, so there is little point in writing to them
if they are unavailable/about to loose their state.
> + }
> + break;
> + case SND_SOC_BIAS_OFF:
> + regcache_mark_dirty(component->regmap);
> + err = regulator_disable(tda7802->enable_reg);
> + if (err < 0)
> + dev_err(component->dev, "Could not disable.\n");
> + break;
> + }
> +
> + return err;
> +}
Thanks,
Charles
uot;Booster"
> +
> +Example:
> +
> +amp: tda7802@6c {
> + compatible = "st,tda7802";
> + reg = <0x6c>;
> + enable-supply = <_enable_reg>;
> +};
> --
> 2.21.0
>
Thanks,
Charles
is not necessary snd_soc_dapm_alloc_kcontrol calls
snd_soc_dapm_free_kcontrol on its internal error path.
Thanks,
Charles
On Fri, Jul 26, 2019 at 02:47:05PM +0100, Marc Zyngier wrote:
> On Tue, 25 Jun 2019 16:47:17 +0100,
> Charles Keepax wrote:
> > diff --git a/include/linux/irqchip/irq-madera.h
> > b/include/linux/irqchip/irq-madera.h
> > index 1160fa3769ae6..3a46cadd38654 100644
> &g
es may occur.
>
> To fix these bugs, wm->mach_ops is checked at the beginning of
> wm97xx_init_pen_irq().
>
> These bugs found by a static analysis tool STCheck written by us.
>
> Signed-off-by: Jia-Ju Bai
> ---
> v2:
> * Add a new check of wm->mach_ops in
es may occur.
>
> To fix these bugs, wm->mach_ops is checked at the beginning of
> wm97xx_init_pen_irq().
>
> These bugs found by a static analysis tool STCheck written by us.
>
> Signed-off-by: Jia-Ju Bai
> ---
> v2:
> * Add a new check of wm->mach_ops in wm97xx_init_pen_
_pen_irq(wm);
> else
> dev_err(wm->dev, "No IRQ specified\n");
This doesn't quite feel like the right fix as it would print an
error message saying "No IRQ specified", in the case the IRQ is
specified but the mach_ops have not been set.
I would suggest either extending the existing BUG_ON or adding a
new check in wm97xx_init_pen_irq.
Thanks,
Charles
> --
> 2.17.0
>
Signed-off-by: Charles Keepax
---
Documentation/devicetree/bindings/extcon/extcon-arizona.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
index
On Wed, Jul 24, 2019 at 07:26:32AM +0200, Christophe JAILLET wrote:
> This should be 'wm8955_pll_factors()' instead.
> Fix it and use it.
>
> Signed-off-by: Christophe JAILLET
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Tue, Jul 23, 2019 at 08:40:21PM +0300, Andy Shevchenko wrote:
> Use use device_property_count_u32() directly, that makes code neater.
>
> Signed-off-by: Andy Shevchenko
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ove issue, free the buffer before returning from
> snd_soc_dapm_new_control_unlocked() through the 'request_failed' label.
>
> Signed-off-by: Wenwen Wang
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
SoC: dpcm: play nice with CODEC<->CODEC links")
Fixes: 09464974eaa8 ("ASoC: dapm: Fix to return correct path list in
is_connected_ep.")
Signed-off-by: Charles Keepax
---
sound/soc/soc-dapm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/s
ttle worried there might be a bit more required to fix this
one. I seem to remember edge triggered IRQs and ONESHOT don't play
very nicely together, but on the flip side this is just a virtual
domain used within the chip so in practice it is probably safe.
A tentative ack from me, but I would certain
On Sat, Jun 29, 2019 at 02:43:33AM +, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No change since v7.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No change since v7.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2 files changed, 3 insertions(+), 3
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function. Whilst we are at it update the handling
to return the actual error code returned from acpi_dev_get_resources
as well.
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
Changes since
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-base.c | 5 +++--
1 file changed, 3 inserti
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
Changes since v7:
- Leave call to acpi_dev_free_resource_list
Thanks,
Charles
basically the same as
the current handling although perhaps caching more stuff.
Thanks,
Charles
See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html
Charles Keepax (6):
i2c: core: Allow whole core to use
Signed-off-by: Charles Keepax
---
No change since v7.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 16 ++--
drivers/i2c/i2c-core-base.c | 5 -
drivers/i2c/i2c-core.h | 7 +++
3 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/i2c-core-acpi.c
On Wed, Jun 26, 2019 at 10:09:06PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 26, 2019 at 04:02:58PM +0100, Charles Keepax wrote:
> > Use the available IRQ helper functions, most of the functions have
> > additional helpful side affects like configuring the trigger type
Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.
Signed-off-by: Charles Keepax
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function. Whilst we are at it update the handling
to return the actual error code returned from acpi_dev_get_resources
as well.
Signed-off-by: Charles Keepax
---
No change since v6.
Thanks,
Charles
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No change since v6.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No change since v6.
Thanks,
Charles
drivers/i2c/i2c-core-base.c
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Signed-off-by: Charles Keepax
---
No change since v6.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
basically the same as
the current handling although perhaps caching more stuff.
Thanks,
Charles
See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html
Charles Keepax (6):
i2c: core: Allow whole core to use
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Signed-off-by: Charles Keepax
---
No change since v6.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 25 ++---
1 file changed
GPL-2.0-only is the preferred way of expressing v2 of the GPL, so switch
to that. Remove some redundant copyright notices and correct some
instances where the wrong comment type has been used in header files.
Signed-off-by: Charles Keepax
---
drivers/mfd/cs47l15-tables.c | 2 +-
drivers
Signed-off-by: Charles Keepax
---
drivers/mfd/cs47l15-tables.c | 2 -
drivers/mfd/cs47l35-tables.c | 54 +---
drivers/mfd/cs47l85-tables.c | 122 ++-
drivers/mfd/cs47l90-tables.c | 76 --
drivers
On Tue, Jun 25, 2019 at 04:25:15PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 25, 2019 at 01:42:45PM +0100, Charles Keepax wrote:
> > On Tue, Jun 25, 2019 at 02:50:11PM +0300, Mika Westerberg wrote:
>
> > I would be happy to squash the two patches, and go back to the
>
GPL-2.0-only is the preferred way of expressing v2 of the GPL, update
the code to use this.
Signed-off-by: Charles Keepax
---
drivers/irqchip/irq-madera.c | 2 +-
include/linux/irqchip/irq-madera.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq
On Tue, Jun 25, 2019 at 02:50:11PM +0300, Mika Westerberg wrote:
> On Fri, Jun 21, 2019 at 11:08:12AM +0100, Charles Keepax wrote:
> > In preparation for more refactoring make i2c_acpi_get_irq available
> > outside i2c-core-acpi.c.
> >
> > Signed-off-by: Charles Keepa
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function. Whilst we are at it update the handling
to return the actual error code returned from acpi_dev_get_resources
as well.
Signed-off-by: Charles Keepax
---
Changes since v5:
- Return error code from
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v5.
Thanks,
Charles
drivers/i2c/i2c-core-base.c
Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.
Signed-off-by: Charles Keepax
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Signed-off-by: Charles Keepax
---
Changes since v5:
- Pass info->irq to i2c_acpi_add_resource directly
- Remove call to acpi_dev_free_resource_l
In preparation for more refactoring make i2c_acpi_get_irq available
outside i2c-core-acpi.c.
Signed-off-by: Charles Keepax
---
Changes since v5:
- Pass a struct device rather than acpi_device to i2c_acpi_get_irq,
note this is more awkward than I would have liked as I am very
unconvinced
basically the same as
the current handling although perhaps caching more stuff.
Thanks,
Charles
See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html
Charles Keepax (7):
i2c: core: Allow whole core to use
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v5.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4
On Thu, Jun 20, 2019 at 05:59:50PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 20, 2019 at 02:34:17PM +0100, Charles Keepax wrote:
> > In preparation for more refactoring make i2c_acpi_get_irq available
> > outside i2c-core-acpi.c.
>
> > Reviewed-by: Andy Shevchenk
On Thu, Jun 20, 2019 at 05:52:21PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 20, 2019 at 02:34:15PM +0100, Charles Keepax wrote:
> > Use the available IRQ helper functions, most of the functions have
> > additional helpful side affects like configuring the trigger type
In preparation for more refactoring make i2c_acpi_get_irq available
outside i2c-core-acpi.c.
Reviewed-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
Changes since v4:
- Leave i2c_acpi_get_irq accepting an acpi_device, this should
avoid the NULL pointer
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v4.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v4.
Thanks,
Charles
drivers/i2c/i2c
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
Changes since v4:
- Pass acpi_device to i2c_acpi_get_irq
- Pass the client acpi_device rather than the adaptor, I think (maybe
hope is more accurate) this should fix the issue seen by Benjamin.
Thanks,
Charles
drivers/i2c/i2c
basically the same as
the current handling although perhaps caching more stuff.
Thanks,
Charles
See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html
Charles Keepax (7):
i2c: core: Allow whole core to use
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v4.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 33
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v4.
Thanks,
Charles
drivers/i2c/i2c-core-base.c
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Reviewed-by: Mika Westerberg
Reviewed-by: Andy Shevchenko
Signed-off-by: Charles Keepax
---
No changes since v4.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4
On Tue, Jun 18, 2019 at 4:38 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Jun 13, 2019 at 03:08:24PM -0300, Charles wrote:
> > Avoid following compiler warning on uninitialized variable
> >
> > In file included from ./include/linux/rwsem.h:16:0,
> > from
unsigned long flags;
^
Signed-off-by: Charles Oliveira <18oliveira.char...@gmail.com>
---
drivers/tty/serial/sh-sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index abc705716aa0..a6af73
Avoid following compiler warning on uninitialized variable
net/ipv4/fib_semantics.c: In function ‘fib_check_nh_v4_gw’:
net/ipv4/fib_semantics.c:1023:12: warning: ‘err’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
if (!tbl || err) {
Signed-off-by: Charles Oliveira
On Wed, Jun 12, 2019 at 06:27:18PM +0300, Mika Westerberg wrote:
> On Tue, Jun 11, 2019 at 01:30:58PM +0100, Charles Keepax wrote:
> > In preparation for more refactoring make i2c_acpi_get_irq available
> > outside i2c-core-acpi.c.
> >
> > Signed-off-by: Charles Keepa
On Thu, Jun 13, 2019 at 11:32:47AM +0200, Benjamin Tissoires wrote:
> On Thu, Jun 13, 2019 at 10:49 AM Charles Keepax
> wrote:
> >
> > On Wed, Jun 12, 2019 at 06:27:18PM +0300, Mika Westerberg wrote:
> > > On Tue, Jun 11, 2019 at 01:30:58PM +0100, Charles Keepax wr
cro (now Cirrus) Cragganmore 6410 so we
> patch this board to pass a descriptor table and fix up the driver
> accordingly.
>
> Cc: Charles Keepax
> Cc: Richard Fitzgerald
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Linus Walleij
> ---
> ChangeLog v1->v2:
>
o be fixed by the system design, normally the gain
would be controlled through an ALSA control.
Thanks,
Charles
On Tue, Jun 11, 2019 at 05:16:58PM +0200, Benjamin Tissoires wrote:
> On Tue, Jun 11, 2019 at 2:31 PM Charles Keepax
> wrote:
> >
> > This series attempts to align as much IRQ handling into the
> > probe path as possible. Note that I don't have a great setup
> >
Signed-off-by: Charles Keepax
---
New since v3, but this patch and the previous one leave the code in
the same state as this patch did on v3.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 7 ---
drivers/i2c/i2c-core-base.c | 5 -
2 files changed, 4 insertions(+), 8 deletions(-)
diff
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function.
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
No changes since v3.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 33 +
1 file changed, 21
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
No change since v3.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 5 +++--
1 file changed
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
No changes since v3.
Apologies Andy but I really can't see a sensible way to split
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
No change since v3.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2 files changed, 3 insertions(+), 3
In preparation for more refactoring make i2c_acpi_get_irq available
outside i2c-core-acpi.c.
Signed-off-by: Charles Keepax
---
Changes since v3:
- Move the change to use the helper function from i2c-core-base into its own
patch.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 15
basically the same as
the current handling although perhaps caching more stuff.
Thanks,
Charles
See previous discussions:
- https://lkml.org/lkml/2019/2/15/989
- https://www.spinics.net/lists/linux-i2c/msg39541.html
Charles Keepax (7):
i2c: core: Allow whole core to use
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Reviewed-by: Mika Westerberg
Signed-off-by: Charles Keepax
---
No changes since v3.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4 ++--
drivers/i2c/i2c-core.h | 2
cro (now Cirrus) Cragganmore 6410 so we
> patch this board to pass a descriptor table and fix up the driver
> accordingly.
>
> Cc: Charles Keepax
> Cc: Richard Fitzgerald
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Linus Walleij
> ---
> +/*
> + * VDDARM is eventuall
Signed-off-by: Charles Keepax
---
New since v1 of the series.
Thanks,
Charles
drivers/mfd/cs47l35-tables.c | 54 +--
drivers/mfd/cs47l85-tables.c | 122 ++-
drivers/mfd/cs47l90-tables.c | 76 ---
3 files changed
CS47L15_* if it is unique to CS47L15
and conflicts with definitions on other codecs.
Signed-off-by: Stuart Henderson
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
Changes since v1:
- Corrected a couple of register defaults and removed a couple of registers
Thanks,
Charles
* if it is unique to CS47L15
and conflicts with definitions on other codecs.
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
Changes since v1:
- Corrected a couple of register defaults and removed a couple of registers
Thanks,
Charles
drivers/mfd/Kconfig |7
From: Richard Fitzgerald
This adds the cs47l15, cs42l92, cs47l92 and cs47l93 to the list of
compatible strings and updates some properties that need to note
the new CODECs.
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
No change since v1.
Thanks,
Charles
On Tue, Jun 04, 2019 at 08:00:52PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote:
> > Use the available IRQ helper functions, most of the functions have
> > additional helpful side affects like configuring the trigger type
On Tue, Jun 04, 2019 at 08:04:04PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:58PM +0100, Charles Keepax wrote:
> > Bring the ACPI path in sync with the device tree path and handle all the
> > IRQ fetching at probe time. This leaves the only IRQ han
On Sat, Jun 01, 2019 at 01:02:52AM +0200, Linus Walleij wrote:
> This driver uses no symbols from so just drop
> this include.
>
> Signed-off-by: Linus Walleij
> ---
Acked-by: Charles Keepax
Thanks,
Charles
From: Richard Fitzgerald
This adds the cs47l15, cs42l92, cs47l92 and cs47l93 to the list of
compatible strings and updates some properties that need to note
the new CODECs.
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
Documentation/devicetree/bindings/mfd/madera.txt
CS47L15_* if it is unique to CS47L15
and conflicts with definitions on other codecs.
Signed-off-by: Stuart Henderson
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
drivers/mfd/Kconfig |7 +
drivers/mfd/Makefile |3 +
drivers/mfd
* if it is unique to CS47L15
and conflicts with definitions on other codecs.
Signed-off-by: Richard Fitzgerald
Signed-off-by: Charles Keepax
---
drivers/mfd/Kconfig |7 +
drivers/mfd/Makefile |3 +
drivers/mfd/cs47l15-tables.c | 1301
Ensure the case when regmap_update_bits_check fails and the change
variable is not updated is handled correctly.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Print error message in driver remove
Thanks,
Charles
drivers/extcon/extcon-arizona.c | 33
On Wed, May 29, 2019 at 02:37:06PM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 5. 29. 오전 1:50, Charles Keepax wrote:
> > Ensure the case when regmap_update_bits_check fails and the change
> > variable is not updated is handled correctly.
> >
> &
Ensure the case when regmap_update_bits_check fails and the change
variable is not updated is handled correctly.
Signed-off-by: Charles Keepax
---
drivers/extcon/extcon-arizona.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/extcon/extcon
Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 4 ++--
drivers/i2c/i2c-core.h | 2 ++
2 files changed, 4 insertions
It makes sense to contain all the ACPI IRQ handling in a single helper
function.
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 3 +++
drivers/i2c/i2c-core-base.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Don't consider zero to be a valid IRQ number
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c | 33 +
1 file
Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.
Signed-off-by: Charles Keepax
Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Don't consider zero to be a valid IRQ number
Thanks,
Charles
drivers/i2c/i2c-core-acpi.c
Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.
Suggested-by: Benjamin Tissoires
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
drivers/i2c/i2c-core-base.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
d
On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote:
> On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote:
> > static int i2c_acpi_get_info(struct acpi_device *adev,
> > struct i2c_board_info *info,
> >
On Mon, May 27, 2019 at 04:19:29PM +0100, Charles Keepax wrote:
> In preparation for future refactoring factor out the fetch of the IRQ
> into its own helper function.
>
> Signed-off-by: Charles Keepax
> ---
>
> +static int i2c_acpi_get_irq(struct acpi_device *adev
Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.
Signed-off-by: Charles Keepax
201 - 300 of 3625 matches
Mail list logo
