the board
controller chip on the Lochnagar board.
The Lochnagar can take several input clocks from the host system,
provides several of its own clock sources, and provides extensive
routing options for those clocks to be supplied to the attached
CODEC/Amp device.
Signed-off-by: Charles Keepax
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
.../bindings/pinctrl/cirrus,lochnagar.txt | 141 +
1 file changed, 141 insertions(+)
create mode 100644
Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.txt
diff --git
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
.../bindings/pinctrl/cirrus,lochnagar.txt | 141 +
1 file changed, 141 insertions(+)
create mode 100644
Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.txt
diff --git
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
Changes since v4:
- Move sub-bindings into separate documents
Again incase Rob missed v4 I have dropped his ack due to the large
changes introduced in v4, see:
https://patchwork.kernel.org/patch/10673891
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
Changes since v4:
- Move sub-bindings into separate documents
Again incase Rob missed v4 I have dropped his ack due to the large
changes introduced in v4, see:
https://patchwork.kernel.org/patch/10673891
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Reviewed-by: Linus Walleij
Signed-off-by: Charles Keepax
---
Changes since v4:
- Removed pinctrl-lochnagar.h
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
No change since v4.
Thanks
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Reviewed-by: Linus Walleij
Signed-off-by: Charles Keepax
---
Changes since v4:
- Removed pinctrl-lochnagar.h
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
No change since v4.
Thanks
On Thu, Nov 15, 2018 at 11:54:48AM +0100, Linus Walleij wrote:
> On Thu, Nov 8, 2018 at 11:14 AM Charles Keepax
> wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most C
On Thu, Nov 15, 2018 at 11:54:48AM +0100, Linus Walleij wrote:
> On Thu, Nov 8, 2018 at 11:14 AM Charles Keepax
> wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most C
On Tue, Nov 13, 2018 at 08:28:25AM +, Lee Jones wrote:
> On Thu, 08 Nov 2018, Charles Keepax wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most Cirrus Logic device
On Tue, Nov 13, 2018 at 08:28:25AM +, Lee Jones wrote:
> On Thu, 08 Nov 2018, Charles Keepax wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most Cirrus Logic device
On Thu, Nov 08, 2018 at 12:16:29PM +, Mark Brown wrote:
> On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:
>
> > +static const struct of_device_id lochnagar_of_match[] = {
> > + { .compatible = "cirrus,lochnagar-regulator" },
> > + {},
&
On Thu, Nov 08, 2018 at 12:16:29PM +, Mark Brown wrote:
> On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:
>
> > +static const struct of_device_id lochnagar_of_match[] = {
> > + { .compatible = "cirrus,lochnagar-regulator" },
> > + {},
&
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
I have dropped Rob and Stephen's Acks from this patch on
account of the scale of the changes since v3.
Changes since v3:
- Split the binding up into separate parts for the individual subsystems
- Added
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
I have dropped Rob and Stephen's Acks from this patch on
account of the scale of the changes since v3.
Changes since v3:
- Split the binding up into separate parts for the individual subsystems
- Added
Review of the MFD component has stated we should not include the
register headers through lochnagar.h and thus removed them from that
header. Explicitly include them in the end drivers manually.
Signed-off-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 2 ++
1 file changed, 2
Based on review comments on the MFD driver, move the child drivers for
the Lochnagar MFD over to binding through device tree.
Signed-off-by: Charles Keepax
---
Mark, I would maybe hold on merging this one until discussions
on this version of the patch chain are done, just incase we
decide to go
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Signed-off-by: Charles Keepax
---
Changes since v3:
- Driver is bound through device tree rather than using
. But could switch over
to it if people prefer.
Thanks,
Charles
Charles Keepax (6):
regulator: lochnagar: Explicitly include register headers
regulator: lochnagar: Move driver to binding from DT
mfd: lochnagar: Add initial binding documentation
mfd: lochnagar: Add support for the Cirrus Logic
the board
controller chip on the Lochnagar board.
The Lochnagar can take several input clocks from the host system,
provides several of its own clock sources, and provides extensive
routing options for those clocks to be supplied to the attached
CODEC/Amp device.
Signed-off-by: Charles Keepax
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
Changes since v3:
- Bind
Review of the MFD component has stated we should not include the
register headers through lochnagar.h and thus removed them from that
header. Explicitly include them in the end drivers manually.
Signed-off-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 2 ++
1 file changed, 2
Based on review comments on the MFD driver, move the child drivers for
the Lochnagar MFD over to binding through device tree.
Signed-off-by: Charles Keepax
---
Mark, I would maybe hold on merging this one until discussions
on this version of the patch chain are done, just incase we
decide to go
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Signed-off-by: Charles Keepax
---
Changes since v3:
- Driver is bound through device tree rather than using
. But could switch over
to it if people prefer.
Thanks,
Charles
Charles Keepax (6):
regulator: lochnagar: Explicitly include register headers
regulator: lochnagar: Move driver to binding from DT
mfd: lochnagar: Add initial binding documentation
mfd: lochnagar: Add support for the Cirrus Logic
the board
controller chip on the Lochnagar board.
The Lochnagar can take several input clocks from the host system,
provides several of its own clock sources, and provides extensive
routing options for those clocks to be supplied to the attached
CODEC/Amp device.
Signed-off-by: Charles Keepax
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
Changes since v3:
- Bind
: add ac97 new bus support")
> Signed-off-by: Arnd Bergmann
> ---
Acked-by: Charles Keepax
Thanks,
Charles
: add ac97 new bus support")
> Signed-off-by: Arnd Bergmann
> ---
Acked-by: Charles Keepax
Thanks,
Charles
t;mfd_pdata) {
> + if (IS_ENABLED(CONFIG_SND_SOC_AC97_BUS)) {
Should this one not also have an && !wm9713->mfd_pdata?
Thanks,
Charles
> snd_soc_component_exit_regmap(component);
> snd_soc_free_ac97_component(wm9713->ac97);
> }
> -#endif
> }
>
> static const struct snd_soc_component_driver soc_component_dev_wm9713 = {
> --
> 2.18.0
t;mfd_pdata) {
> + if (IS_ENABLED(CONFIG_SND_SOC_AC97_BUS)) {
Should this one not also have an && !wm9713->mfd_pdata?
Thanks,
Charles
> snd_soc_component_exit_regmap(component);
> snd_soc_free_ac97_component(wm9713->ac97);
> }
> -#endif
> }
>
> static const struct snd_soc_component_driver soc_component_dev_wm9713 = {
> --
> 2.18.0
at least
>
> Change-Id: Icc970b438166daef13518b7d1a62b13eb8752f5f
> Signed-off-by: liush
> ---
Acked-by: Charles Keepax
Thanks,
Charles
at least
>
> Change-Id: Icc970b438166daef13518b7d1a62b13eb8752f5f
> Signed-off-by: liush
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Signed-off-by: Charles Keepax
---
drivers/mfd/wm5110-tables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
index 1ee68bd440fbc..16c6e2accfaa5 100644
--- a/drivers/mfd/wm5110-tables.c
+++ b/drivers/mfd/wm5110-tables.c
@@ -1618,6
Signed-off-by: Charles Keepax
---
drivers/mfd/wm5110-tables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
index 1ee68bd440fbc..16c6e2accfaa5 100644
--- a/drivers/mfd/wm5110-tables.c
+++ b/drivers/mfd/wm5110-tables.c
@@ -1618,6
> > I think from the perspective of Richard and Charles who are just trying
> > to get their driver merged this is something of an abstract distinction.
> > If the driver were merged and this discussion were happening separately
> > their perspective would most likely be di
> > I think from the perspective of Richard and Charles who are just trying
> > to get their driver merged this is something of an abstract distinction.
> > If the driver were merged and this discussion were happening separately
> > their perspective would most likely be di
uld have also
not worked before that commit but it would have not worked
for different reasons.
Thanks,
Charles
uld have also
not worked before that commit but it would have not worked
for different reasons.
Thanks,
Charles
On Tue, Oct 30, 2018 at 02:04:20PM +0100, Linus Walleij wrote:
> On Fri, Oct 19, 2018 at 11:50 AM Charles Keepax
> wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most C
On Tue, Oct 30, 2018 at 02:04:20PM +0100, Linus Walleij wrote:
> On Fri, Oct 19, 2018 at 11:50 AM Charles Keepax
> wrote:
>
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most C
On Mon, Oct 29, 2018 at 11:15:47AM +0100, Benjamin Tissoires wrote:
> On Sun, Oct 28, 2018 at 11:31 PM Wolfram Sang wrote:
> >
> > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote:
> > > The IRQ will be mapped in i2c_device_probe onl
On Mon, Oct 29, 2018 at 11:15:47AM +0100, Benjamin Tissoires wrote:
> On Sun, Oct 28, 2018 at 11:31 PM Wolfram Sang wrote:
> >
> > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote:
> > > The IRQ will be mapped in i2c_device_probe onl
On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote:
> On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote:
> > On Thu, 25 Oct 2018, Richard Fitzgerald wrote:
> > > On 25/10/18 09:26, Charles Keepax wrote:
> > > > On Thu, Oct 25, 2018 at 08:
On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote:
> On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote:
> > On Thu, 25 Oct 2018, Richard Fitzgerald wrote:
> > > On 25/10/18 09:26, Charles Keepax wrote:
> > > > On Thu, Oct 25, 2018 at 08:
On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote:
> On Thu, 25 Oct 2018, Richard Fitzgerald wrote:
> > On 25/10/18 09:26, Charles Keepax wrote:
> > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> > > > On Mon, 08 Oct 2018, Charles Keepax
On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote:
> On Thu, 25 Oct 2018, Richard Fitzgerald wrote:
> > On 25/10/18 09:26, Charles Keepax wrote:
> > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> > > > On Mon, 08 Oct 2018, Charles Keepax
On Thu, Oct 25, 2018 at 11:12:48AM +0100, Mark Brown wrote:
> On Thu, Oct 25, 2018 at 10:28:16AM +0100, Richard Fitzgerald wrote:
> > On 25/10/18 09:26, Charles Keepax wrote:
> > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> > > I really fee
On Thu, Oct 25, 2018 at 11:12:48AM +0100, Mark Brown wrote:
> On Thu, Oct 25, 2018 at 10:28:16AM +0100, Richard Fitzgerald wrote:
> > On 25/10/18 09:26, Charles Keepax wrote:
> > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> > > I really fee
On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> On Mon, 08 Oct 2018, Charles Keepax wrote:
> > From: Charles Keepax
> > +static const struct reg_default lochnagar1_reg_defaults[] = {
> > + { LOCHNAGAR1_CDC_AIF1_SEL,0x00 },
> > + { LOCHN
On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote:
> On Mon, 08 Oct 2018, Charles Keepax wrote:
> > From: Charles Keepax
> > +static const struct reg_default lochnagar1_reg_defaults[] = {
> > + { LOCHNAGAR1_CDC_AIF1_SEL,0x00 },
> > + { LOCHN
Update the rest of the comment at the start of the file to also use C++
style comments to match the required style of the SPDX header.
Signed-off-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
Update the rest of the comment at the start of the file to also use C++
style comments to match the required style of the SPDX header.
Signed-off-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
On Fri, Oct 19, 2018 at 01:21:18PM +0100, Mark Brown wrote:
> On Fri, Oct 19, 2018 at 01:19:20PM +0100, Charles Keepax wrote:
> > On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote:
>
> > > Please do not submit new versions of already applied patches, please
>
On Fri, Oct 19, 2018 at 01:21:18PM +0100, Mark Brown wrote:
> On Fri, Oct 19, 2018 at 01:19:20PM +0100, Charles Keepax wrote:
> > On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote:
>
> > > Please do not submit new versions of already applied patches, please
>
On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote:
> On Fri, Oct 19, 2018 at 10:50:02AM +0100, Charles Keepax wrote:
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits c
On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote:
> On Fri, Oct 19, 2018 at 10:50:02AM +0100, Charles Keepax wrote:
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits c
but these supplies are sufficient for most
systems/use-cases.
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
drivers/regulator/Kconfig | 7 +
drivers/regulator/Makefile | 1 +
drivers/regulator/lochnagar-regulator.c | 255
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
Acked-by: Rob Herring
---
Changes since v2:
- Used vendor prefix on aif-master and aif-slave
- Used -gpios instead of -gpio in example DT
- Used - rather than _ on node names in example DT
- Removed some clocks
but these supplies are sufficient for most
systems/use-cases.
Signed-off-by: Charles Keepax
---
No changes since v2.
Thanks,
Charles
drivers/regulator/Kconfig | 7 +
drivers/regulator/Makefile | 1 +
drivers/regulator/lochnagar-regulator.c | 255
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
Acked-by: Rob Herring
---
Changes since v2:
- Used vendor prefix on aif-master and aif-slave
- Used -gpios instead of -gpio in example DT
- Used - rather than _ on node names in example DT
- Removed some clocks
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Updated aif-master/aif-slave to use a vendor prefix
the board
controller chip on the Lochnagar board.
The Lochnagar can take several input clocks from the host system,
provides several of its own clock sources, and provides extensive
routing options for those clocks to be supplied to the attached
CODEC/Amp device.
Signed-off-by: Charles Keepax
the board
controller chip on the Lochnagar board.
The Lochnagar can take several input clocks from the host system,
provides several of its own clock sources, and provides extensive
routing options for those clocks to be supplied to the attached
CODEC/Amp device.
Signed-off-by: Charles Keepax
the board
controller chip on the Lochnagar board.
Lochnagar provides many pins which can generally be used for an
audio function such as an AIF or a PDM interface, but also as
GPIOs.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Updated aif-master/aif-slave to use a vendor prefix
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Minor
the drivers for the various features to be bound
in. Initially clocking, regulator and pinctrl will be added as
these are necessary to configure the system. But in time at least
audio and voltage/current monitoring will also be added.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Minor
Fix this issue by clearing client->irq in i2c_device_remove,
forcing i2c_device_probe to lookup the mapping again.
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-base.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
Fix this issue by clearing client->irq in i2c_device_remove,
forcing i2c_device_probe to lookup the mapping again.
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-base.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
irq_create_mapping calls irq_find_mapping internally and will use the
found mapping if one exists, so there is no need to manually call this
from i2c_smbus_host_notify_to_irq.
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-base.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
irq_create_mapping calls irq_find_mapping internally and will use the
found mapping if one exists, so there is no need to manually call this
from i2c_smbus_host_notify_to_irq.
Signed-off-by: Charles Keepax
---
drivers/i2c/i2c-core-base.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
On Sat, Oct 13, 2018 at 04:45:13PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in sound control text
>
> Signed-off-by: Colin Ian King
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Sat, Oct 13, 2018 at 04:45:13PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in sound control text
>
> Signed-off-by: Colin Ian King
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Fri, Oct 12, 2018 at 08:59:56AM -0700, Stephen Boyd wrote:
> Quoting Charles Keepax (2018-10-11 06:26:02)
> > On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote:
> > > Quoting Charles Keepax (2018-10-08 06:25:40)
> > > > +struct lochnagar_clk_priv {
>
On Fri, Oct 12, 2018 at 08:59:56AM -0700, Stephen Boyd wrote:
> Quoting Charles Keepax (2018-10-11 06:26:02)
> > On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote:
> > > Quoting Charles Keepax (2018-10-08 06:25:40)
> > > > +struct lochnagar_clk_priv {
>
On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote:
> Quoting Charles Keepax (2018-10-08 06:25:40)
> > +#include
>
> Is this used?
>
> > +#include
> > +#include
>
> Is this used?
>
> > +#include
> > +#include
> > +#includ
On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote:
> Quoting Charles Keepax (2018-10-08 06:25:40)
> > +#include
>
> Is this used?
>
> > +#include
> > +#include
>
> Is this used?
>
> > +#include
> > +#include
> > +#includ
ot;)
> Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera
> codecs")
> Signed-off-by: Gustavo A. R. Silva
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ot;)
> Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera
> codecs")
> Signed-off-by: Gustavo A. R. Silva
> ---
Acked-by: Charles Keepax
Thanks,
Charles
if statement
and you will use the reg variable which should also be
uninitialised on that code path.
Feels like initialising to 0 would probably be better anyway
since the code path looks like the case were you have n_pins == 0
and nothing really failed in that case just nothing needed to be
don
if statement
and you will use the reg variable which should also be
uninitialised on that code path.
Feels like initialising to 0 would probably be better anyway
since the code path looks like the case were you have n_pins == 0
and nothing really failed in that case just nothing needed to be
don
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Move the binding includes into this patch.
- Move patch to the start of the patch chain.
- Update commit message a little
Thanks,
Charles
.../devicetree/bindings/mfd/cirrus,lochnagar.txt
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
the board
controller chip on the Lochnagar board.
Signed-off-by: Charles Keepax
---
Changes since v1:
- Move the binding includes into this patch.
- Move patch to the start of the patch chain.
- Update commit message a little
Thanks,
Charles
.../devicetree/bindings/mfd/cirrus,lochnagar.txt
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
From: Charles Keepax
Lochnagar is an evaluation and development board for Cirrus
Logic Smart CODEC and Amp devices. It allows the connection of
most Cirrus Logic devices on mini-cards, as well as allowing
connection of various application processor systems to provide a
full evaluation platform
Signed-off-by: Charles Keepax
---
drivers/mfd/wm5110-tables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
index 1ee68bd440fbc..16c6e2accfaa5 100644
--- a/drivers/mfd/wm5110-tables.c
+++ b/drivers/mfd/wm5110-tables.c
@@ -1618,6
Signed-off-by: Charles Keepax
---
drivers/mfd/wm5110-tables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
index 1ee68bd440fbc..16c6e2accfaa5 100644
--- a/drivers/mfd/wm5110-tables.c
+++ b/drivers/mfd/wm5110-tables.c
@@ -1618,6
into a separate function call.
>
> Signed-off-by: Richard Fitzgerald
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
nce and
> set the bit. Note that the boot sequence is not the same as a
> reset so we still have to soft reset to get the codec into a
> known state.
>
> Signed-off-by: Stuart Henderson
> Signed-off-by: Richard Fitzgerald
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
into a separate function call.
>
> Signed-off-by: Richard Fitzgerald
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
nce and
> set the bit. Note that the boot sequence is not the same as a
> reset so we still have to soft reset to get the codec into a
> known state.
>
> Signed-off-by: Stuart Henderson
> Signed-off-by: Richard Fitzgerald
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
goto err_reset;
> - }
> -
> - ret = madera_wait_for_boot(madera);
> - if (ret) {
> - dev_err(madera->dev, "Device failed initial boot: %d\n", ret);
> - goto err_reset;
> - }
And this guy would then only need done in the case of a soft
reset.
Thanks,
Charles
> -
> ret = regmap_read(madera->regmap, MADERA_HARDWARE_REVISION,
> >rev);
> if (ret) {
> --
> 2.11.0
501 - 600 of 3625 matches
Mail list logo
