Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node

2019-05-20 Thread Chen-Yu Tsai
0, Clément Péron wrote: > > > > Allwinner H6 has a watchog node which seems broken > > > > on some boards. > > > > > > > > Test has been performed on several boards. > > > > > > > > Chen-Yu Tsai boards: > > > > Pine H6

[PATCH 08/25] clk: sunxi-ng: switch to of_clk_hw_register() for registering clks

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Commit 89a5ddcc799d ("clk: Add of_clk_hw_register() API for early clk drivers") introduces a new API for registering clks, which allows the user to directly specify a device node, even if there is no struct device attached to it. The device node is used for loca

[PATCH 03/25] clk: Add CLK_HW_INIT_FW_NAME macro using .fw_name in .parent_data

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, clk_init_data was expanded to include .parent_data, for clk drivers that have parents referenced using a combination of device tree clock-names, clock indices, and/or clk_hw pointers. Add a CLK_HW_INIT macro for specifying a single parent from

[PATCH 21/25] clk: sunxi-ng: h6: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 14/25] clk: sunxi-ng: a33: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 15/25] clk: sunxi-ng: h3: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 16/25] clk: sunxi-ng: r40: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 25/25] clk: sunxi-ng: sun8i-r: Use local parent references for SUNXI_CCU_GATE

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and SUNXI_CCU_GATE macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing SUNXI_CCU_GATE definitions to SUNXI_CCU_GATE_HWS as the parent clock is internal to this clock unit. To avoid

[PATCH 04/25] clk: Add CLK_HW_INIT_PARENT_DATA macro using .parent_data

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, struct clk_init_data was expanded to include .parent_data, for clk drivers that have parents referenced using a combination of device tree clock-names, clock indices, and/or struct clk_hw pointers. Add a new macro that can take a list

[PATCH 12/25] clk: sunxi-ng: a31: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 11/25] clk: sunxi-ng: sun5i: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 19/25] clk: sunxi-ng: f1c100s: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 18/25] clk: sunxi-ng: sun8i-r: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 10/25] clk: sunxi-ng: a10: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 05/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_HW which takes clk_hw pointer as parent

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, clk_init_data was expanded to include .parent_hws, for clk drivers to directly reference parents by clk_hw. Add a new macro, CLK_FIXED_FACTOR_HW, that can take a struct clk_hw pointer, instead of a string, as its parent. Signed-off-by: Chen

[PATCH 24/25] clk: sunxi-ng: a80-usb: Use local parent references for SUNXI_CCU_GATE

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and SUNXI_CCU_GATE macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing SUNXI_CCU_GATE definitions to SUNXI_CCU_GATE_DATA to specify the parent clock. Signed-off-by: Chen-Yu Tsai

[PATCH 13/25] clk: sunxi-ng: a23: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 17/25] clk: sunxi-ng: v3s: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is series is the first part of a large series (I haven't done the rest) of patches to rewrite the clk parent relationship handling within the sunxi-ng clk driver. This is based on Stephen's recent work allowing clk drivers to specify clk parents using struct

[PATCH 23/25] clk: sunxi-ng: gate: Add macros for referencing local clock parents

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, clk_init_data was expanded to include .parent_hws, for clk drivers to directly reference parents by clk_hw, and .parent_data, for clk drivers to specify parents using a combination of device tree clock-names, pointers to struct clk_hw, device

[PATCH 20/25] clk: sunxi-ng: a64: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 07/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_FW_NAME for DT clock-names parent

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, clk_init_data was expanded to include .parent_data, for clk drivers to specify parents using a combination of device tree clock-names, pointers to struct clk_hw, device tree clocks, and/or fallback global clock names. Add a new macro

[PATCH 22/25] clk: sunxi-ng: h6-r: Use local parent references for CLK_FIXED_FACTOR

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_FIXED_FACTOR_{HW,FW_NAME} macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_FIXED_FACTOR definitions to either the _HW or _FW_NAME variant based on whether the parent clock

[PATCH 09/25] clk: sunxi-ng: sun8i-r: Use local parent references for CLK_HW_INIT_*

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code and CLK_HW_INIT_* macros, we can reference parents locally via pointers to struct clk_hw or DT clock-names. Convert existing CLK_HW_INIT_* definitions to describe parents using either struct clk_hw pointers or clock-names from the device tree

[PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, struct clk_init_data was expanded to include .parent_hws, for clk drivers to directly list parents by pointing to their respective struct clk_hw's. Add macros that can take either one single struct clk_hw *, or an array of them, for drivers

[PATCH 01/25] clk: Fix debugfs clk_possible_parents for clks without parent string names

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Following the commit fc0c209c147f ("clk: Allow parents to be specified without string names"), the parent name string is not always populated. Instead, fetch the parents clk_core struct using the appropriate helper, and read its name directly. Fixes: fc0c209c

[PATCH 06/25] clk: fixed-factor: Add CLK_FIXED_FACTOR_HWS which takes list of struct clk_hw *

2019-05-20 Thread Chen-Yu Tsai
From: Chen-Yu Tsai With the new clk parenting code, clk_init_data was expanded to include .parent_hws, for clk drivers to directly reference parents by clk_hw. Add a new macro, CLK_FIXED_FACTOR_HWS, that can take an array of pointers to struct clk_hw, instead of a string, as its parent. Taking

Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind

2019-04-23 Thread Chen-Yu Tsai
On Tue, Apr 23, 2019 at 10:06 AM Paul Kocialkowski wrote: > > Hi, > > Le vendredi 19 avril 2019 à 19:10 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > On Fri, 2019-04-19 at 09:02 -0700, Chen-Yu Tsai wrote: > > > On Fri, Apr 19, 2019 at 1:03 AM Paul

[PATCH 0/3] arm64: allwinner: Enable AXP803's USB power supply

2019-04-18 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This series follows up on the A83T USB OTG series. The USB power supply portion of the AXP803, the PMIC used with the A64, is identical to the part in the AXP813/AXP818, used with the A83T. This series enables the USB power supply in the AXP803 using the AXP813

[PATCH 1/3] mfd: axp20x: add USB power supply mfd cell to AXP803

2019-04-18 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The AXP803 has a VBUS power input. Its functionality is the same as the one found in the AXP813. Now that the axp20x_usb_power driver supports this variant, we can add an mfd cell for it to use it. Signed-off-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 + 1 file

[PATCH 2/3] arm64: dts: allwinner: axp803: add USB power supply node

2019-04-18 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The AXP803 has a VBUS power input. Add a device node for it, now that we support it. Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/allwinner/axp803.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi b/arch/arm64

[PATCH 3/3] arm64: dts: allwinner: a64: bananapi-m64: Enable PMIC USB power supply

2019-04-18 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The Bananapi M64 has a micro-USB connector with USB OTG support (that is already enabled). VBUS from this connector is wired to the PMIC's VBUS input. Enable the PMIC's USB power supply on this board, and also hook it up to the USB PHY. Signed-off-by: Chen-Yu Tsai --- arch

[PATCH v4 0/7] ARM: sun8i: a83t: Enable USB OTG

2019-04-16 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is v4 of my A83T USB power supply / OTG series. Hopefully this is the last revision even though it's kind of late in the -rc cycle for the patches to make the next release. Fingers crossed. Changes since v3: - Dropped patch for disabling current limit

[PATCH v4 1/7] dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible

2019-04-16 Thread Chen-Yu Tsai
From: Chen-Yu Tsai This adds the "x-powers,axp813-usb-power-supply" to the list of compatibles for AXP20X VBUS power supply driver. Reviewed-by: Rob Herring Signed-off-by: Chen-Yu Tsai --- Changes since v2: - Collected Rob's Reviewed-by --- .../devicetree/bindings/po

[PATCH v4 2/7] power: supply: axp20x_usb_power: Fix typo in VBUS current limit macros

2019-04-16 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The VBUS current limit value macros have VBUS typed as VBUC, while the bitmask macro is named correctly. Fix it. Fixes: 69fb4dcada77 ("power: Add an axp20x-usb-power driver") Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 16 -

Re: [PATCH 4/6] ARM: dts: sun8i: a83t: Add device node for CSI (Camera Sensor Interface)

2019-04-09 Thread Chen-Yu Tsai
On Tue, Apr 9, 2019 at 4:28 PM Maxime Ripard wrote: > > On Tue, Apr 09, 2019 at 04:07:34PM +0800, Chen-Yu Tsai wrote: > > On Tue, Apr 9, 2019 at 3:58 PM Maxime Ripard > > wrote: > > > On Tue, Apr 09, 2019 at 12:57:42AM +0800, Chen-Yu Tsai wrote:

[PATCH 4/6] ARM: dts: sun8i: a83t: Add device node for CSI (Camera Sensor Interface)

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The A83T SoC has a camera sensor interface (known as CSI in Allwinner lingo), which is similar to the one found on the A64 and H3. The only difference seems to be that support of MIPI CSI through a connected MIPI CSI-2 bridge. Add a device node for it, and pinctrl nodes

[PATCH 2/6] dt-bindings: media: sun6i-csi: Add compatible string for A83T variant

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The A83T SoC has a camera sensor interface (known as CSI in Allwinner lingo), which is similar to the one found on the A64 and H3. The only difference seems to be that support of MIPI CSI through a connected MIPI CSI-2 bridge. Add a compatible string for this variant. Signed

[PATCH 0/6] ARM: sun8i: a83t: Support Camera Sensor Interface controller

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This series adds support for the camera sensor interface controller found on the Allwinner A83T SoC. The controller is similar to the one found on the H3, with the addition of a MIPI CSI-2 interface. However, this series only supports parallel and BT.656

Re: [PATCH v2] ARM: sun8i: h3: bluetooth for Banana Pi M2 Zero board

2019-04-08 Thread Chen-Yu Tsai
On Sat, Mar 2, 2019 at 2:53 AM Andreas Kemnade wrote: > > The Banana Pi M2 Zero board has an AP6212 BT+Wifi combo chip > with broadcom internals attached to UART1 and some gpios. ^ Broadcom > This addition is in line with similar boards This sentence is unfinished. > > Signed-off-by:

Re: [PATCH 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node

2019-04-08 Thread Chen-Yu Tsai
On Mon, Apr 8, 2019 at 1:54 PM Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > Amarula A64-Relic board. > > The CTP connected to board with, > - SDA, SCK from i2c1 > - GPIO-LD0 as AVDD28 supply > - PH4 gpio as interrupt pin > - PH8 gpio as reset pin > - X axis is

Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node

2019-04-05 Thread Chen-Yu Tsai
On Fri, Apr 5, 2019 at 10:50 PM Maxime Ripard wrote: > > On Fri, Apr 05, 2019 at 10:35:08PM +0800, Chen-Yu Tsai wrote: > > On Fri, Apr 5, 2019 at 5:02 PM Maxime Ripard > > wrote: > > > > > > On Thu, Apr 04, 2019 at 03:57:36PM +0200, Clément Péron wrote

Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node

2019-04-05 Thread Chen-Yu Tsai
On Fri, Apr 5, 2019 at 5:02 PM Maxime Ripard wrote: > > On Thu, Apr 04, 2019 at 03:57:36PM +0200, Clément Péron wrote: > > Allwinner H6 has a watchog compatible with A31. > > > > Declare it in the device tree. > > > > Signed-off-by: Clément Péron > > Applied both, thanks! > Maxime IIRC there

Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func

2019-04-04 Thread Chen-Yu Tsai
On Thu, Apr 4, 2019 at 7:05 PM Maxime Ripard wrote: > > On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > > > > On 02/04/2019 16:45, Yangtao Li wrote: > > > Because there was an endianness issue. It seems that reg_read > > > function which the nvmem the driver currently

Re: [PATCH 3/3] clk: sunxi-ng: h6: Allow video & vpu clocks to change parent rate

2019-04-03 Thread Chen-Yu Tsai
On Wed, Apr 3, 2019 at 3:54 PM Maxime Ripard wrote: > > On Tue, Apr 02, 2019 at 11:06:23PM +0200, Jernej Skrabec wrote: > > Video related clocks need to set rate as close as possible to the > > requested one, so they should be able to change parent clock rate. > > > > VPU clock sometimes has to

[PATCH] Bluetooth: hci_bcm: Fix empty regulator supplies for Intel Macs

2019-03-31 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The code path for Macs goes through bcm_apple_get_resources(), which skips over the code that sets up the regulator supplies. As a result, the call to regulator_bulk_enable() / regulator_bulk_disable() results in a NULL pointer dereference. This was reported on the kernel.org

Re: [linux-sunxi] [PATCH 4/7] ARM: dts: sun8i: a83t: Add UART2 PB pins

2019-03-28 Thread Chen-Yu Tsai
On Wed, Mar 27, 2019 at 8:18 AM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > Add pin definitions for UART2 PB pins. These are used on TBS-A711 > tablet. > > Signed-off-by: Ondrej Jirman > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller

2019-03-22 Thread Chen-Yu Tsai
t; Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai

Re: [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c

2019-03-22 Thread Chen-Yu Tsai
ble > to use it, but since it's proprietary, when we want to use the PMIC in a > multi-master setup, the i2c might make sense as well. > > Let's add that possibility. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai

Re: [PATCH] regulator: axp20x: Mark expected switch fall-throughs

2019-03-22 Thread Chen-Yu Tsai
s used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Chen-Yu Tsai

[PATCH v3 4/9] power: supply: axp20x_usb_power: use polling to detect vbus status change

2019-03-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai On AXP221 and later AXP PMICs that have the N_VBUSEN pin, when this pin is high, either due to the PMIC driving it high or as an input, the VBUS detection related interrupt mechanisms are disabled. Previously this was worked around in the phy-sun4i-usb driver, which needed

[PATCH v3 0/9] ARM: sun8i: a83t: Enable USB OTG

2019-03-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This is v3 of my A83T USB power supply / OTG series. Changes since v2: - Added Rob's ack for dt bindings patch - Rebased onto v5.1-rc1 Changes since v1: - Added Lee's ack for mfd patch - Make axp803_usb_power_supply_resources[] const This series has

[PATCH v3 9/9] ARM: dts: sun8i: a83t: Enable USB OTG controller on some boards

2019-03-21 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The Bananapi M3 and Cubietruck Plus both have USB OTG ports wired to the SoC and PMIC in the same way, with the N_VBUSEN pin on the PMIC controlling VBUS output, the PMIC's VBUS input for sensing VBUS, and PH11 on the SoC for sensing the ID pin. Enable OTG on both boards

[PATCH v3 6/9] power: supply: axp20x_usb_power: add support for AXP813

2019-03-21 Thread Chen-Yu Tsai
From: Quentin Schulz This adds support for AXP813 PMIC. It is almost the same as AXP22X but has a different current limit. Signed-off-by: Quentin Schulz Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 66 - 1 file changed, 65 insertions(+), 1

[PATCH v3 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

2019-03-21 Thread Chen-Yu Tsai
From: Quentin Schulz The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver supports this variant, we can add an mfd cell for it to use it. Signed-off-by: Quentin Schulz [w...@csie.org: add commit message] Acked-for-MFD-by: Lee Jones Signed-off-by: Chen-Yu Tsai --- Changes

Re: [PATCH 1/2] regulator: axp20x: Remove unneeded NULL test against rdev

2019-03-18 Thread Chen-Yu Tsai
On Tue, Mar 19, 2019 at 11:36 AM Axel Lin wrote: > > rdev won't be NULL in .enable callback. > > Signed-off-by: Axel Lin Acked-by: Chen-Yu Tsai

Re: [PATCH 2/2] regulator: axp20x: Use rdev_get_id at appropriate places

2019-03-18 Thread Chen-Yu Tsai
On Tue, Mar 19, 2019 at 11:36 AM Axel Lin wrote: > > Use rdev_get_id() to simplify the code a bit. > > Signed-off-by: Axel Lin Acked-by: Chen-Yu Tsai

Re: [PATCH 4/6] nvmem: sunxi_sid: Read out data in native format

2019-03-18 Thread Chen-Yu Tsai
On Mon, Mar 18, 2019 at 4:42 PM Maxime Ripard wrote: > > Hi, > > On Mon, Mar 18, 2019 at 03:33:52PM +0800, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Originally the SID e-fuses were thought to be in big-endian format. > > Later sources show that they

Re: [PATCH] dt-bindings: Add YAML description for Allwinner boards

2019-03-15 Thread Chen-Yu Tsai
ree.org/meta-schemas/core.yaml# > + > +title: Allwinner platforms device tree bindings > + > +maintainers: > + - Chen-Yu Tsai > + - Maxime Ripard > + > +properties: > + $nodename: > +const: '/' > + compatible: > +oneOf: > + [...]

Re: device tree binding for poly-phased regulators

2019-03-05 Thread Chen-Yu Tsai
On Fri, Feb 22, 2019 at 7:21 PM Torsten Duwe wrote: > > Hi! > > Documentation/devicetree/bindings/mfd/axp20x.txt nicely describes the > capabilities of the X-powers PMICs; however, it seems polyphasing is > left to comments only. > > May I suggest to add a property "poly-phased", just to get the

[PATCH v2 2/9] power: supply: axp20x_usb_power: Fix typo in VBUS current limit macros

2019-02-24 Thread Chen-Yu Tsai
The VBUS current limit value macros have VBUS typed as VBUC, while the bitmask macro is named correctly. Fix it. Fixes: 69fb4dcada77 ("power: Add an axp20x-usb-power driver") Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 16 1 file

[PATCH v2 4/9] power: supply: axp20x_usb_power: use polling to detect vbus status change

2019-02-24 Thread Chen-Yu Tsai
supply driver would not know when. Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c index e2f353906bb1

[PATCH v2 6/9] power: supply: axp20x_usb_power: add support for AXP813

2019-02-24 Thread Chen-Yu Tsai
From: Quentin Schulz This adds support for AXP813 PMIC. It is almost the same as AXP22X but has a different current limit. Signed-off-by: Quentin Schulz Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 66 - 1 file changed, 65 insertions(+), 1

[PATCH v2 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

2019-02-24 Thread Chen-Yu Tsai
From: Quentin Schulz The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver supports this variant, we can add an mfd cell for it to use it. Signed-off-by: Quentin Schulz [w...@csie.org: add commit message] Acked-for-MFD-by: Lee Jones Signed-off-by: Chen-Yu Tsai --- Changes

[PATCH v2 1/9] dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible

2019-02-24 Thread Chen-Yu Tsai
This adds the "x-powers,axp813-usb-power-supply" to the list of compatibles for AXP20X VBUS power supply driver. Signed-off-by: Chen-Yu Tsai --- .../devicetree/bindings/power/supply/axp20x_usb_power.txt| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/

[PATCH v2 8/9] ARM: dtsi: axp81x: add USB power supply node

2019-02-24 Thread Chen-Yu Tsai
From: Quentin Schulz The AXP813/818 has a VBUS power input. Add a device node for it, now that we support it. Signed-off-by: Quentin Schulz [w...@csie.org: Add commit message] Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp81x.dtsi | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2 0/9] ARM: sun8i: a83t: Enable USB OTG

2019-02-24 Thread Chen-Yu Tsai
an AXP221 or newer PMIC. I haven't removed the polling workaround from the USB PHY driver yet. That would be the next step after this series is merged, and preferrably a release has passed. Regards ChenYu Chen-Yu Tsai (5): dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible power

[PATCH v2 5/9] power: supply: axp20x_usb_power: add function to get max current

2019-02-24 Thread Chen-Yu Tsai
From: Quentin Schulz To prepare for a new PMIC, factor out the code responsible of returning the maximum current to axp20x_get_current_max. Signed-off-by: Quentin Schulz Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 52 ++--- 1 file changed, 30

[PATCH v2 9/9] ARM: dts: sun8i: a83t: Enable USB OTG controller on some boards

2019-02-24 Thread Chen-Yu Tsai
The Bananapi M3 and Cubietruck Plus both have USB OTG ports wired to the SoC and PMIC in the same way, with the N_VBUSEN pin on the PMIC controlling VBUS output, the PMIC's VBUS input for sensing VBUS, and PH11 on the SoC for sensing the ID pin. Enable OTG on both boards. Signed-off-by: Chen-Yu

[PATCH v2 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting

2019-02-24 Thread Chen-Yu Tsai
The AXP PMICs allow the user to disable current limiting on the VBUS input. While read-out of this setting was already supported by the driver, it did not allow the user to configure the PMIC to disable current limiting. Add support for this. Signed-off-by: Chen-Yu Tsai --- drivers/power

Re: [PATCH] ARM: dts: sun7i: add pinctrl for missing uart mux options

2019-02-20 Thread Chen-Yu Tsai
On Wed, Feb 20, 2019 at 7:00 PM Måns Rullgård wrote: > > Maxime Ripard writes: > > > On Wed, Feb 20, 2019 at 04:58:49PM +0800, Chen-Yu Tsai wrote: > >> On Sun, Feb 17, 2019 at 2:21 AM Mans Rullgard wrote: > >> > > >> > This adds p

Re: [PATCH] ARM: dts: sun7i: add pinctrl for missing uart mux options

2019-02-20 Thread Chen-Yu Tsai
On Sun, Feb 17, 2019 at 2:21 AM Mans Rullgard wrote: > > This adds pinctrl settings for various missing uart options. > > Signed-off-by: Mans Rullgard > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 45 > 1 file changed, 45 insertions(+) > > diff --git

Re: [PATCH 2/5] nvmem: sunxi-sid: add support for H5's SID controller

2019-02-19 Thread Chen-Yu Tsai
On Tue, Feb 19, 2019 at 11:03 PM Maxime Ripard wrote: > > Hi, > > On Mon, Feb 18, 2019 at 05:19:40PM +0800, Chen-Yu Tsai wrote: > > On Mon, Feb 18, 2019 at 4:49 PM Maxime Ripard > > wrote: > > > > > > On Sun, Feb 17, 2019 at 11:23:13AM -0500, Yangtao

Allwinner SID THS calibration data cell representation?

2019-02-18 Thread Chen-Yu Tsai
Sorry for resurrecting an old discussion, but since someone posted patches for H5 and H6, I thought we should resolve this. I'm working on patches to fix / replace the big-endian issue. On Thu, Sep 6, 2018 at 7:51 PM Maxime Ripard wrote: > > On Thu, Sep 06, 2018 at 01:47:47PM +0200, Philipp

Re: [PATCH 2/5] nvmem: sunxi-sid: add support for H5's SID controller

2019-02-18 Thread Chen-Yu Tsai
On Mon, Feb 18, 2019 at 4:49 PM Maxime Ripard wrote: > > On Sun, Feb 17, 2019 at 11:23:13AM -0500, Yangtao Li wrote: > > Add support for H5's SID controller. > > > > Signed-off-by: Yangtao Li > > --- > > drivers/nvmem/sunxi_sid.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff

Re: [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev

2019-02-18 Thread Chen-Yu Tsai
and can be removed. > > Detected by CoverityScan, CID#1476031 ("Dereference before null check") > > Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for > AXP209 LDO3") > Signed-off-by: Colin Ian King Acked-by: Chen-Yu Tsai

Re: [PATCH] regulator: axp20x: fix DCDCB and BLDO2 definitions for AXP806

2019-02-17 Thread Chen-Yu Tsai
t;regulator: axp20x: use defines for masks") > Signed-off-by: Ondrej Jirman The first hunk is also covered by a patch from Rask Ingemann Lambertsen. Acked-by: Chen-Yu Tsai

Re: [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug

2019-02-17 Thread Chen-Yu Tsai
t;--> 1550 mV at 1050 mV > > This patch fixes it: > > vcc-dram: 1450 <--> 1550 mV at 1500 mV > > Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks") > Signed-off-by: Rask Ingemann Lambertsen Acked-by: Chen-Yu Tsai

Re: [PATCH 1/9] pinctrl: sunxi: Support I/O bias voltage setting on A80

2019-02-13 Thread Chen-Yu Tsai
On Mon, Feb 11, 2019 at 4:21 PM Linus Walleij wrote: > > On Wed, Feb 6, 2019 at 4:32 AM Chen-Yu Tsai wrote: > > > The A80 SoC has configuration registers for I/O bias voltage. Incorrect > > settings would make the affected peripherals inoperable in some cases, > > suc

[PATCH 2/2] arm64: dts: allwinner: a64: Rename hpvcc-supply to cpvdd-supply

2019-02-12 Thread Chen-Yu Tsai
supply so it matches the datasheet and bindings. Fixes: c56689e6f2fb ("arm64: dts: allwinner: a64: bananapi-m64: Enable audio codec") Fixes: 6de8e717848f ("arm64: dts: allwinner: a64: enable sound on Pinebook") Fixes: 498c21f233ed ("arm64: dts: allwinner: a64: enable sound on Pin

[PATCH 0/2] arm64: allwinner: a64: Rename hpvcc-supply to cpvdd-supply

2019-02-12 Thread Chen-Yu Tsai
and the device tree binding, but used "HPVCC" (which is the name used by the A33) in the device tree files and the device driver. (facepalm) This feature was just introduced in v5.0-rc1, so if we could merge this as fixes for v5.0 that would be great. Thanks, and sorry for the blunder on my pa

[PATCH 1/2] ASoC: sunxi: sun50i-codec-analog: Rename hpvcc regulator supply to cpvdd

2019-02-12 Thread Chen-Yu Tsai
supply so it matches the datasheet, bindings, and the subject from the original commit. Fixes: ca0412a05756 ("ASoC: sunxi: sun50i-codec-analog: Add support for cpvdd regulator supply") Signed-off-by: Chen-Yu Tsai --- sound/soc/sunxi/sun50i-codec-analog.c | 4 ++-- 1 file changed, 2 insertions(

Re: [RFT PATCH 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

2019-02-07 Thread Chen-Yu Tsai
On Thu, Feb 7, 2019 at 7:02 PM Lee Jones wrote: > > On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > > > From: Quentin Schulz > > > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > > supports this variant, we can add an mfd cell for

Re: linux-next: Fixes tag needs some work in the sunxi tree

2019-02-07 Thread Chen-Yu Tsai
On Thu, Feb 7, 2019 at 9:50 PM Stephen Rothwell wrote: > > Hi all, > > In commit > > df0aeb208b24 ("ARM: dts: sun9i: a80-optimus: Add node for AXP809's unused > dc1sw regulator") > > Fixes tag > > Fixes: aa4a27bc819e ("ARM: dts: sun9i: a80-optimus: Add AXP809 PMIC > > has these problem(s): >

[RFT PATCH 0/9] ARM: sun8i: a83t: Enable USB OTG

2019-02-06 Thread Chen-Yu Tsai
boards that have an AXP221 or newer PMIC. I haven't removed the polling workaround from the USB PHY driver yet. That would be the next step after this series is merged, and preferrably a release has passed. Regards ChenYu Chen-Yu Tsai (5): dt-bindings: power: supply: axp20x_usb_power: add axp813

[RFT PATCH 8/9] ARM: dtsi: axp81x: add USB power supply node

2019-02-06 Thread Chen-Yu Tsai
From: Quentin Schulz The AXP813/818 has a VBUS power input. Add a device node for it, now that we support it. Signed-off-by: Quentin Schulz [w...@csie.org: Add commit message] Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp81x.dtsi | 4 1 file changed, 4 insertions(+) diff --git

[RFT PATCH 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

2019-02-06 Thread Chen-Yu Tsai
From: Quentin Schulz The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver supports this variant, we can add an mfd cell for it to use it. Signed-off-by: Quentin Schulz [w...@csie.org: add commit message] Signed-off-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 11

[RFT PATCH 4/9] power: supply: axp20x_usb_power: use polling to detect vbus status change

2019-02-06 Thread Chen-Yu Tsai
supply driver would not know when. Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c index e2f353906bb1

[RFT PATCH 1/9] dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible

2019-02-06 Thread Chen-Yu Tsai
This adds the "x-powers,axp813-usb-power-supply" to the list of compatibles for AXP20X VBUS power supply driver. Signed-off-by: Chen-Yu Tsai --- .../devicetree/bindings/power/supply/axp20x_usb_power.txt| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/

[RFT PATCH 2/9] power: supply: axp20x_usb_power: Fix typo in VBUS current limit macros

2019-02-06 Thread Chen-Yu Tsai
The VBUS current limit value macros have VBUS typed as VBUC, while the bitmask macro is named correctly. Fix it. Fixes: 69fb4dcada77 ("power: Add an axp20x-usb-power driver") Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 16 1 file

[RFT PATCH 5/9] power: supply: axp20x_usb_power: add function to get max current

2019-02-06 Thread Chen-Yu Tsai
From: Quentin Schulz To prepare for a new PMIC, factor out the code responsible of returning the maximum current to axp20x_get_current_max. Signed-off-by: Quentin Schulz Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 52 ++--- 1 file changed, 30

[RFT PATCH 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting

2019-02-06 Thread Chen-Yu Tsai
The AXP PMICs allow the user to disable current limiting on the VBUS input. While read-out of this setting was already supported by the driver, it did not allow the user to configure the PMIC to disable current limiting. Add support for this. Signed-off-by: Chen-Yu Tsai --- drivers/power

[RFT PATCH 6/9] power: supply: axp20x_usb_power: add support for AXP813

2019-02-06 Thread Chen-Yu Tsai
From: Quentin Schulz This adds support for AXP813 PMIC. It is almost the same as AXP22X but has a different current limit. Signed-off-by: Quentin Schulz Signed-off-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_usb_power.c | 66 - 1 file changed, 65 insertions(+), 1

[RFT PATCH 9/9] ARM: dts: sun8i: a83t: Enable USB OTG controller on some boards

2019-02-06 Thread Chen-Yu Tsai
The Bananapi M3 and Cubietruck Plus both have USB OTG ports wired to the SoC and PMIC in the same way, with the N_VBUSEN pin on the PMIC controlling VBUS output, the PMIC's VBUS input for sensing VBUS, and PH11 on the SoC for sensing the ID pin. Enable OTG on both boards. Signed-off-by: Chen-Yu

Re: [PATCH] regulator: axp20x: Fix incorrect vsel_mask settings

2019-02-06 Thread Chen-Yu Tsai
On Wed, Feb 6, 2019 at 10:47 PM Axel Lin wrote: > > Chen-Yu Tsai 於 2019年2月6日 週三 下午6:44寫道: > > > > On Mon, Jan 28, 2019 at 10:02 PM Axel Lin wrote: > > > > > > Fix copy-paste mistake while converting to use defines for masks. > > > > > >

Re: [PATCH 5/5] arm: dts: axpxx: add charge led node

2019-02-06 Thread Chen-Yu Tsai
On Wed, Feb 6, 2019 at 2:06 PM Stefan Mavrodiev wrote: > > > On 2/5/19 6:16 PM, Chen-Yu Tsai wrote: > > On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev wrote: > >> Add dt node for axp20x-led driver controlling CHGLED. > >> Default status is disabled, since it

Re: [PATCH] regulator: axp20x: Fix incorrect vsel_mask settings

2019-02-06 Thread Chen-Yu Tsai
On Mon, Jan 28, 2019 at 10:02 PM Axel Lin wrote: > > Fix copy-paste mistake while converting to use defines for masks. > > Fixes: db4a555f7c4cf ("regulator: axp20x: use defines for masks") > Signed-off-by: Axel Lin Reviewed-by: Chen-Yu Tsai Though I believe the latte

Re: [PATCH v15 0/8] ASoC: sun4i-codec: Add Line-In, FM-In, Mic 2

2019-02-06 Thread Chen-Yu Tsai
trols. > > v1 changes: > - added linein, fmin output volumes and switches. > > Danny Milosavljevic (8): > ASoC: sun4i-codec: Add MIC2 Pre-Amplifier, Mic2 > ASoC: sun4i-codec: Add Mic Playback Volume > ASoC: sun4i-codec: Add sun7i_codec_controls, sun7i_codec_codec. > ASoC: sun4i-codec: Add Mic1 Boost Volume, Mic2 Boost Volume > ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and > sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls > ASoC: sun4i-codec: Add Mic1 Playback Switch, Mic2 Playback Switch > ASoC: sun4i-codec: Add FM Playback Volume, FM Left, FM Right, FM > Playback Switch > ASoC: sun4i-codec: Add Line Playback Volume, Line Boost Volume, Line > Right, Line Left, Line Playback Switch The whole series is Reviewed-by: Chen-Yu Tsai

Re: [linux-sunxi] Re: [PATCH 1/9] pinctrl: sunxi: Support I/O bias voltage setting on A80

2019-02-06 Thread Chen-Yu Tsai
On Wed, Feb 6, 2019 at 4:14 PM Linus Walleij wrote: > > On Wed, Feb 6, 2019 at 4:32 AM Chen-Yu Tsai wrote: > > > The A80 SoC has configuration registers for I/O bias voltage. Incorrect > > settings would make the affected peripherals inoperable in some cases, > > suc

[PATCH 0/9] ARM: sun9i: a80: Enable GMAC

2019-02-05 Thread Chen-Yu Tsai
tack on support for setting up these registers. This in turn allows us to enable the GMAC, which runs at a reduced 2.5V for RGMII, instead of the standard 3.0V or 3.3V. Please have a look. Regards ChenYu Chen-Yu Tsai (9): pinctrl: sunxi: Support I/O bias voltage setting on A80 ARM: dts

<    1   2   3   4   5   6   7   8   9   10   >