[PATCH V3] tty: fix memleak in alloc_pid

race and fix the memleak. Signed-off-by: Zhang Jun Signed-off-by: Chen Tingjie --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 31c4a57..72547a3 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

> > Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a > > > > Why is this line here? > Tingjie, Greg is asking you the sentence of "Change-Id", which is not needed, > please remove it with one new patch. Sorry for mistaken, I will make a new patch for it. -- To unsubscribe from this list:

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

erations should be atomic, which protected by spinlock: current->sighand->siglock. So the sentence: spin_unlock_irq(>sighand->siglock); need to move down after tty has process completed. Thanks, -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] S

[PATCH V2] tty: fix memleak in alloc_pid

current_tty() can avoid the race and fix the memleak. Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Signed-off-by: Zhang Jun Signed-off-by: Chen Tingjie --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 31c4a57..7254

[PATCH] [PATCH V2] tty: memleak in alloc_pid

current_tty() can avoid the race and fix the memleak. Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Signed-off-by: Zhang Jun Signed-off-by: Chen Tingjie --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 31c4a57..7254

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

down after tty has process completed. Thanks, -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, April 14, 2014 7:47 PM To: Chen, Tingjie Cc: Jiri Slaby; linux-kernel@vger.kernel.org; Zhang, Jun Subject: Re: [PATCH] [PATCH V2] tty: memleak

RE: [PATCH] [PATCH V2] tty: memleak in alloc_pid

Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Why is this line here? Tingjie, Greg is asking you the sentence of Change-Id, which is not needed, please remove it with one new patch. Sorry for mistaken, I will make a new patch for it. -- To unsubscribe from this list: send the

[PATCH V3] tty: fix memleak in alloc_pid

the race and fix the memleak. Signed-off-by: Zhang Jun jun.zh...@intel.com Signed-off-by: Chen Tingjie tingjie.c...@intel.com --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 31c4a57..72547a3 100644

[PATCH] [PATCH V2] tty: memleak in alloc_pid

the race and fix the memleak. Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Signed-off-by: Zhang Jun jun.zh...@intel.com Signed-off-by: Chen Tingjie tingjie.c...@intel.com --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b

[PATCH V2] tty: fix memleak in alloc_pid

the race and fix the memleak. Change-Id: Ic960dda039c8f99aad3e0f4d176489a966c62f6a Signed-off-by: Zhang Jun jun.zh...@intel.com Signed-off-by: Chen Tingjie tingjie.c...@intel.com --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b

[PATCH] tty: fix memleak in alloc_pid

an fix this leak. Signed-off-by: Zhang Jun Signed-off-by: Chen Tingjie --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index d3448a9..3411071 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c

[PATCH] tty: fix memleak in alloc_pid

operations can fix this leak. Signed-off-by: Zhang Jun jun.zh...@intel.com Signed-off-by: Chen Tingjie tingjie.c...@intel.com --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index d3448a9..3411071 100644