Re: [PATCH 4/6] time: fix typo in comments

2007-11-29 Thread Chris Malley
On Thu, 29 Nov 2007 15:35:32 +0800, Li Zefan wrote: > > Fix typo in comments. > > BTW: I have to fix coding style in arch/ia64/kernel/time.c also, > otherwise checkpatch.pl will be complaining. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > > --- > arch/ia64/kernel/time.c | 14

Re: [PATCH 4/6] time: fix typo in comments

2007-11-29 Thread Chris Malley
On Thu, 29 Nov 2007 15:35:32 +0800, Li Zefan wrote: Fix typo in comments. BTW: I have to fix coding style in arch/ia64/kernel/time.c also, otherwise checkpatch.pl will be complaining. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- arch/ia64/kernel/time.c | 14 +++---

[PATCH] sysfs: trivial: fix sysfs_create_file kerneldoc spelling mistake

2007-10-16 Thread Chris Malley
Spelling error in sysfs_create_file kerneldoc. Signed-off-by: Chris Malley <[EMAIL PROTECTED]> --- fs/sysfs/file.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 3e1cc06..ac75554 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/

[PATCH] sysfs: trivial: fix sysfs_create_file kerneldoc spelling mistake

2007-10-16 Thread Chris Malley
Spelling error in sysfs_create_file kerneldoc. Signed-off-by: Chris Malley [EMAIL PROTECTED] --- fs/sysfs/file.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 3e1cc06..ac75554 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c

Re: [PATCH 5/5] lguest: loading bzImage directly

2007-10-03 Thread Chris Malley
Hi guys Would it not be clearer to #include and use the relevant named members of struct setup_header / struct boot_params rather than the hard-coded values 0x202, 0x1F1, 0x214 ? -- Chris On Wed, 2007-10-03 at 09:40 +1000, Rusty Russell wrote: [snip] > + u8 hdr[1024]; > + int r; > +

Re: [PATCH 5/5] lguest: loading bzImage directly

2007-10-03 Thread Chris Malley
Hi guys Would it not be clearer to #include asm/bootparam.h and use the relevant named members of struct setup_header / struct boot_params rather than the hard-coded values 0x202, 0x1F1, 0x214 ? -- Chris On Wed, 2007-10-03 at 09:40 +1000, Rusty Russell wrote: [snip] + u8 hdr[1024]; +