Re: [PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Chris Ye
That line was using tab + 4 spaces on the left and was reformatted to use 2 tabs. If you don't like it I've uploaded patch v5 not touching that line. On Tue, Apr 13, 2021 at 5:34 AM Bastien Nocera wrote: > > On Tue, 2021-04-13 at 01:02 +, Chris Ye wrote: > > Add "Sel

[PATCH] [v5] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Chris Ye
Add "Select" button input capability and input event mapping for Microsoft Xbox One controller. From product site this is also referred as "Share" button. Fixed Microsoft Xbox One controller select button not working under USB connection. Signed-off-by: Chris Ye --- dr

[PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-12 Thread Chris Ye
Add "Select" button input capability and input event mapping for Microsoft Xbox One controller. From product site this is also referred as "Share" button. Fixed Microsoft Xbox One controller select button not working under USB connection. Signed-off-by: Chris Ye --- dr

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-04-10 Thread Chris Ye
tton. Quickly pair with, play on, and switch between devices " Should we override the product button name and name it "Select" in driver? I am ok with either way but can we have a name everyone can agree on and move forward? Thanks! Chris On Tue, Mar 23, 2021 at 2:52 PM Chris Ye

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Chris Ye
at 3:57 PM Chris Ye wrote: > > Hi Bastien, > The "Share button" is a name Microsoft calls it, it actually has > HID descriptor defined in the bluetooth interface, which the HID usage > is: > consumer 0xB2: > 0x05, 0x0C,// Usage Page (Consumer) > 0x0A,

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-03 Thread Chris Ye
e key code to be generated consistently for USB and bluetooth. Thanks! Chris On Tue, Mar 2, 2021 at 1:50 AM Bastien Nocera wrote: > > On Thu, 2021-02-25 at 05:32 +, Chris Ye wrote: > > Add "Share" button input capability and input event mapping for > > Microsoft Xbox One co

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-01 Thread Chris Ye
in, thanks! Chris On Sat, Feb 27, 2021 at 6:01 PM Cameron Gutman wrote: > > On 2/24/21 11:32 PM, Chris Ye wrote: > > Add "Share" button input capability and input event mapping for > > Microsoft Xbox One controller. > > Fixed Microsoft Xbox One controller share

[PATCH] [v3] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-01 Thread Chris Ye
Add "Share" button input capability and input event mapping for Microsoft Xbox One controller. Fixed Microsoft Xbox One controller share button not working under USB connection. Signed-off-by: Chris Ye --- drivers/input/joystick/xpad.c | 8 +++- 1 file changed, 7 insertions(+),

[PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-24 Thread Chris Ye
Add "Share" button input capability and input event mapping for Microsoft Xbox One controller. Fixed Microsoft Xbox One controller share button not working under USB connection. Signed-off-by: Chris Ye --- drivers/input/joystick/xpad.c | 9 - 1 file changed, 8 insertions(+),

Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-24 Thread Chris Ye
(Record) Thanks! Chris On Wed, Feb 24, 2021 at 8:33 PM Dmitry Torokhov wrote: > > Hi Chris, > > On Thu, Feb 25, 2021 at 04:00:32AM +0000, Chris Ye wrote: > > Add "Share" button input capability and input event mapping for > > Microsoft Xbox One controller. >

[PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-24 Thread Chris Ye
Add "Share" button input capability and input event mapping for Microsoft Xbox One controller. Fixed Microsoft Xbox One controller share button not working under USB connection. Signed-off-by: Chris Ye --- drivers/input/joystick/xpad.c | 16 ++-- 1 file changed, 14 insert

[PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-24 Thread Chris Ye
Add "Share" button input capability and input event mapping for Microsoft Xbox One controller. Fixed Microsoft Xbox One controller share button not working under USB connection. Signed-off-by: Chris Ye --- drivers/input/joystick/xpad.c | 16 ++-- 1 file changed, 14 insert

Re: [PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-13 Thread Chris Ye
is f59ee399de4a8ca4d7d19cdcabb4b63e94867f09. Hope this helps, Michael On Fri, Nov 13, 2020 at 5:27 PM Chris Ye wrote: Hi Jiri, can I have a commit ID for 5.10? I'll need this to submit the patch internally. Thanks! Chris On 11/9/20 3:55 AM, Jiri Kosina wrote: On Sun, 1 Nov 2020, Chris Ye wrote

Re: [PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-13 Thread Chris Ye
Hi Jiri,  can I have a commit ID for 5.10? I'll need this to submit the patch internally. Thanks! Chris On 11/9/20 3:55 AM, Jiri Kosina wrote: On Sun, 1 Nov 2020, Chris Ye wrote: diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 74be76e848bf..cf55dca494f3 100644

Re: [PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-09 Thread Chris Ye
Thanks a lot Jiri! On 11/9/20 3:55 AM, Jiri Kosina wrote: On Sun, 1 Nov 2020, Chris Ye wrote: diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 74be76e848bf..cf55dca494f3 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -449,6 +449,10 @@ #define

Re: [PATCH v2] Input: Fix the HID usage of DPAD input event generation.

2020-11-05 Thread Chris Ye
+sta...@vger.kernel.org On 11/3/20 9:36 AM, Benjamin Tissoires wrote: Hi Chris, On Mon, Nov 2, 2020 at 6:24 PM Chris Ye wrote: Hi Benjamin, I've tried the hid-tool for testing on my linux machine and it works. However the issue comes from a game controller I don't posses in hand

Re: [PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-05 Thread Chris Ye
+sta...@vger.kernel.org On 11/1/20 11:34 AM, Chris Ye wrote: Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye --- drivers/hid/hid-ids.h| 4 drivers/hid/hid-quirks.c | 4 2 files changed, 8

Re: [PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-05 Thread Chris Ye
test with. Thanks! Chris On 11/1/20 11:34 AM, Chris Ye wrote: Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye --- drivers/hid/hid-ids.h| 4 drivers/hid/hid-quirks.c | 4 2 files changed

Re: [PATCH v2] Input: Fix the HID usage of DPAD input event generation.

2020-11-04 Thread Chris Ye
Hi Benjamin,    We are using hid driver to inject hid report for D-Pad and Hat switch events, like:   [0x00, 0x00, 0x00, 0x00, 0x01, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00], Check the HID format dump from kernel, this will send a 0x1 on HID usage GenericDesktop.HatSwitch. Do you

Re: [PATCH v2] Input: Fix the HID usage of DPAD input event generation.

2020-11-02 Thread Chris Ye
te any axis events because the HatDir internally is still 0 regardless the report value of the 4 DPAD usages. Thanks! Chris On 11/2/20 12:16 AM, Benjamin Tissoires wrote: Hi Chris, On Sun, Nov 1, 2020 at 8:35 PM Chris Ye wrote: Generic Desktop DPAD usage is mapped by hid-input, that

Re: [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-01 Thread Chris Ye
Thanks Dmitry,  I just sent out the v2 version of patches, to maintainers of HID core layer, Benjamin and Jiri. On 10/29/20 1:39 PM, Dmitry Torokhov wrote: Jiri Kosina

Re: [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-01 Thread Chris Ye
text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 29, 2020 at 01:04:06PM -0700, Chris Ye wrote: Hi Greg, Yes, I can see them

[PATCH v2] Input: Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-11-01 Thread Chris Ye
Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye --- drivers/hid/hid-ids.h| 4 drivers/hid/hid-quirks.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid

[PATCH v2] Input: Fix the HID usage of DPAD input event generation.

2020-11-01 Thread Chris Ye
will be assigned to hat direction only. The hid input event should check the HID report value and generate HID event for its hat direction. Test: Connect HID device with Generic Desktop DPAD usage and press the DPAD to generate input events. Signed-off-by: Chris Ye --- drivers/hid/hid-input.c

Re: [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-10-29 Thread Chris Ye
-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 29, 2020 at 08:23:57AM -0700, Chris Ye wrote: Haha, thanks! I have fixed my git config and sent a new mail

[PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-10-29 Thread Chris Ye
Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye --- drivers/hid/hid-ids.h| 4 drivers/hid/hid-quirks.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid

[PATCH] ANDROID: Fix the HID usage of DPAD input event generation.

2020-10-29 Thread Chris Ye
will be assigned to hat direction only. The hid input event should check the HID report value and generate HID event for its hat direction. Test: Connect HID device with Generic Desktop DPAD usage and press the DPAD to generate input events. Signed-off-by: Chris Ye --- drivers/hid/hid-input.c

[PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-10-28 Thread Chris Ye
Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye diff -uprN -X linux-vanilla/Documentation/dontdiff linux-vanilla/drivers/hid/hid-ids.h linux/drivers/hid/hid-ids.h --- linux-vanilla/drivers/hid/hid-ids.h

[PATCH] ANDROID: Fix the HID usage of DPAD input event generation.

2020-10-28 Thread Chris Ye
will be assigned to hat direction only. The hid input event should check the HID report value and generate HID event for its hat direction. Test: Connect HID device with Generic Desktop DPAD usage and press the DPAD to generate input events. Signed-off-by: Chris Ye --- drivers/hid/hid-input.c