nand_chip
*chip, u8 *dat,
switch (b % 4) {
case 2:
byte_addr += shifting;
+ break;
case 1:
break;
default:
Reviewed-by: Christophe Kerello
Regards,
Christophe Kerello.
p function.
Signed-off-by: Christophe Kerello
Fixes: d7157ff49a5b ("mtd: rawnand: Use the ECC framework user input parsing
bits")
---
Changes in v2:
- move default ECC settings in stm32_fmc2_nfc_attach_chip function.
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 15 --
Hi Miquel,
On 10/30/20 9:19 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Thu, 29 Oct
2020 17:38:12 +0100:
Since commit d7157ff49a5b ("mtd: rawnand: Use the ECC framework user
input parsing bits"), ECC are broken in FMC2 driver in case of
nand-ecc-step-siz
t function is called. To avoid to lose the default user
configuration, it is needed to move it in the new user_conf structure.
Signed-off-by: Christophe Kerello
Fixes: d7157ff49a5b ("mtd: rawnand: Use the ECC framework user input parsing
bits")
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c
This patch adds FMC2 EBI controller support used by STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig
b/arch/arm/configs/multi_v7_defconfig
index e9e76e3..4929cc8
This patch adds FMC2 External Bus Interface support on stm32mp157c.
Signed-off-by: Christophe Kerello
---
arch/arm/boot/dts/stm32mp151.dtsi | 43 +++
arch/arm/boot/dts/stm32mp157c-ev1.dts | 16 +++--
2 files changed, 38 insertions(+), 21 deletions
This patchset enables FMC2 EBI support on STM32MP1 SOCs.
Christophe Kerello (2):
ARM: multi_v7_defconfig: add FMC2 EBI controller support
ARM: dts: stm32: add FMC2 EBI support for stm32mp157c
arch/arm/boot/dts/stm32mp151.dtsi | 43 +++
arch/arm/boot/dts
ata lines are configured, but the bus width
is set to 4. What is the reason of not setting this property to 8?
Regards,
Christophe Kerello.
This patch solves following static checker warning:
drivers/mtd/nand/raw/stm32_fmc2_nand.c:350 stm32_fmc2_nfc_select_chip()
error: buffer overflow 'nfc->data_phys_addr' 2 <= 2
The CS value can only be 0 or 1.
Signed-off-by: Christophe Kerello
Fixes: 2cd457f328c1 ("mtd: rawnand: stm3
Hi Richard,
On 6/30/20 11:13 AM, Richard Weinberger wrote:
On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
wrote:
The driver adds the support for the STMicroelectronics FMC2 EBI controller
found on STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
+ if (!IS_ERR(rstc
This patch uses regmap APIs to access all FMC2 registers.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/Kconfig | 2 +
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 268
to avoid a MFD driver
- bindings:
- pattern name has been modified
- vendor properties have been modified
- s/_/-/
- add unit suffix (-ns) on timing properties
Christophe Kerello (6):
mtd: rawnand: stm32_fmc2: do not display errors if the driver is
deferred
dt-bindings: mtd
Signed-off-by: Christophe Kerello
---
Changes in v5:
- look at the parent compatible string to match what we expect.
drivers/mtd/nand/raw/Kconfig | 3 +-
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 71 --
2 files changed, 51 insertions(+), 23 deletions(-)
Controller 2 (FMC2)
Bindings
maintainers:
- Christophe Kerello
-allOf:
- - $ref: "nand-controller.yaml#"
-
properties:
compatible:
-const: st,stm32mp15-fmc2
+enum:
+ - st,stm32mp15-fmc2
+ - st,stm32mp1-fmc2-nfc
reg:
-items:
- - description:
This patch removes the display of this log in the console in case of
this error is -EPROBE_DEFER.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
b/drivers/mtd
This patch adds the documentation of the device tree bindings for the STM32
FMC2 EBI controller.
Signed-off-by: Christophe Kerello
Reviewed-by: Rob Herring
---
Changes in v5:
- fix indent descriptions
- add Rob reviewed-by tag
Changes in v4:
- fix filename: st,stm32-fmc2-ebi.yaml
Changes
The driver adds the support for the STMicroelectronics FMC2 EBI controller
found on STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- Move in memory folder
- Merge MFD and BUS drivers to avoid a MFD driver
drivers/memory/Kconfig | 10 +
drivers/memory/Makefile
Hi Rob,
On 5/14/20 7:55 PM, Rob Herring wrote:
On Thu, May 14, 2020 at 11:35 AM Christophe Kerello
wrote:
Hi Rob,
On 5/14/20 5:00 PM, Rob Herring wrote:
On Wed, May 06, 2020 at 11:11:15AM +0200, Christophe Kerello wrote:
These bindings can be used on SOCs where the FMC2 NAND controller
Hi Rob,
On 5/14/20 5:07 PM, Rob Herring wrote:
On Wed, May 06, 2020 at 11:11:16AM +0200, Christophe Kerello wrote:
This patch adds the documentation of the device tree bindings for the STM32
FMC2 EBI controller.
Signed-off-by: Christophe Kerello
---
Changes in v4:
- fix filename: st,stm32
Hi Rob,
On 5/14/20 5:00 PM, Rob Herring wrote:
On Wed, May 06, 2020 at 11:11:15AM +0200, Christophe Kerello wrote:
These bindings can be used on SOCs where the FMC2 NAND controller is
in standalone. In case that the FMC2 embeds 2 controllers (an external
bus controller and a raw NAND
This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v5:
- rebase on top of nand/next
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 177
This patch renames functions and local variables.
This cleanup is done to get all functions starting by stm32_fmc2_nfc
in the FMC2 raw NAND driver when all functions will start by
stm32_fmc2_ebi in the FMC2 EBI driver.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes
This set of patches is a rebase of the patches that were not applied
on nand/next.
Changes in v5:
- rebase on top of nand/next
Changes in v3:
- add Miquel reviewed-by tag
Christophe Kerello (2):
mtd: rawnand: stm32_fmc2: cosmetic change to use nfc instead of
fmc2 where relevant
Hi Miquel,
On 5/11/20 10:39 PM, Miquel Raynal wrote:
Christophe Kerello wrote on Wed, 6 May 2020
11:11:13 +0200:
This patch renames functions and local variables.
This cleanup is done to get all functions starting by stm32_fmc2_nfc
in the FMC2 raw NAND driver when all functions will start
Hi Miquel,
On 5/11/20 4:45 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Mon, 11 May
2020 16:19:47 +0200:
Hi Miquel,
On 5/11/20 2:58 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Mon, 11 May
2020 14:47:09 +0200:
Hi Miquel,
On 5/11/20 1
Hi Miquel,
On 5/11/20 2:58 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Mon, 11 May
2020 14:47:09 +0200:
Hi Miquel,
On 5/11/20 1:59 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Mon, 11 May
2020 12:21:03 +0200:
Hi Miquel,
On 5/11/20 11
Hi Miquel,
On 5/11/20 1:59 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Mon, 11 May
2020 12:21:03 +0200:
Hi Miquel,
On 5/11/20 11:18 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 6 May 2020
11:11:19 +0200:
FMC2 EBI support has been
Hi Miquel,
On 5/11/20 11:22 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 6 May 2020
11:11:09 +0200:
The FMC2 functional block makes the interface with: synchronous and
asynchronous static devices (such as PSNOR, PSRAM or other memory-mapped
peripherals) and NAND
Hi Miquel,
On 5/11/20 11:18 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 6 May 2020
11:11:19 +0200:
FMC2 EBI support has been added. Common resources (registers base
and clock) are now shared between the 2 drivers. It means that the
common resources should now
Hi,
Please do not spend time to review v3.
V4 has been pushed to fix an issue in YAML bindings.
Regards,
Christophe Kerello.
On 5/5/20 7:10 PM, Christophe Kerello wrote:
The FMC2 functional block makes the interface with: synchronous and
asynchronous static devices (such as PSNOR, PSRAM
This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 177 -
1 file changed, 85
This patch renames functions and local variables.
This cleanup is done to get all functions starting by stm32_fmc2_nfc
in the FMC2 raw NAND driver when all functions will start by
stm32_fmc2_ebi in the FMC2 EBI driver.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes
This patch uses regmap APIs to access all FMC2 registers.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/Kconfig | 2 +
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 268
FMC2 EBI support has been added. Common resources (registers base
and clock) are now shared between the 2 drivers. It means that the
common resources should now be found in the parent device when EBI
node is available.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/Kconfig
This patch defers its probe when the expected reset control is not
yet ready. This patch also handles properly all errors cases at probe
time.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- rename labels used on errors
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 17 +++--
1
Remove inline comments that are useless since function label are
self explanatory.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 40 --
1 file changed, 40
met this
value. To be safe, FMC2_TIMEOUT_MS is set to 5 seconds.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- add in the commit log the reason to increase FMC2_TIMEOUT_MS
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
and the clock are now optional.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
b/Documentation
to avoid a MFD driver
- bindings:
- pattern name has been modified
- vendor properties have been modified
- s/_/-/
- add unit suffix (-ns) on timing properties
Christophe Kerello (10):
mtd: rawnand: stm32_fmc2: manage all errors cases at probe time
mtd: rawnand: stm32_fmc2: remove
This patch adds the documentation of the device tree bindings for the STM32
FMC2 EBI controller.
Signed-off-by: Christophe Kerello
---
Changes in v4:
- fix filename: st,stm32-fmc2-ebi.yaml
Changes in v3:
- pattern name has been modified
- vendor properties have been modified
- s
The driver adds the support for the STMicroelectronics FMC2 EBI controller
found on STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- Move in memory folder
- Merge MFD and BUS drivers to avoid a MFD driver
drivers/memory/Kconfig | 10 +
drivers/memory/Makefile
On 5/5/20 7:11 PM, Christophe Kerello wrote:
This patch adds the documentation of the device tree bindings for the STM32
FMC2 EBI controller.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- pattern name has been modified
- vendor properties have been modified
- s
This patch defers its probe when the expected reset control is not
yet ready. This patch also handles properly all errors cases at probe
time.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- rename labels used on errors
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 17 +++--
1
This patch adds the documentation of the device tree bindings for the STM32
FMC2 EBI controller.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- pattern name has been modified
- vendor properties have been modified
- s/_/-/
- add unit suffix (-ns) on timing properties
.../memory
The driver adds the support for the STMicroelectronics FMC2 EBI controller
found on STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- Move in memory folder
- Merge MFD and BUS drivers to avoid a MFD driver
drivers/memory/Kconfig | 10 +
drivers/memory/Makefile
and the clock are now optional.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
b/Documentation
- vendor properties have been modified
- s/_/-/
- add unit suffix (-ns) on timing properties
Christophe Kerello (10):
mtd: rawnand: stm32_fmc2: manage all errors cases at probe time
mtd: rawnand: stm32_fmc2: remove useless inline comments
mtd: rawnand: stm32_fmc2: use
This patch renames functions and local variables.
This cleanup is done to get all functions starting by stm32_fmc2_nfc
in the FMC2 raw NAND driver when all functions will start by
stm32_fmc2_ebi in the FMC2 EBI driver.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes
This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 177 -
1 file changed, 85
FMC2 EBI support has been added. Common resources (registers base
and clock) are now shared between the 2 drivers. It means that the
common resources should now be found in the parent device when EBI
node is available.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/Kconfig
This patch uses regmap APIs to access all FMC2 registers.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/Kconfig | 2 +
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 268
met this
value. To be safe, FMC2_TIMEOUT_MS is set to 5 seconds.
Signed-off-by: Christophe Kerello
---
Changes in v3:
- add in the commit log the reason to increase FMC2_TIMEOUT_MS
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
Remove inline comments that are useless since function label are
self explanatory.
Signed-off-by: Christophe Kerello
Reviewed-by: Miquel Raynal
---
Changes in v3:
- add Miquel reviewed-by tag
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 40 --
1 file changed, 40
On 4/29/20 12:06 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 29 Apr
2020 11:41:44 +0200:
On 4/29/20 11:35 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 29 Apr
2020 11:27:43 +0200:
Hi Miquèl,
On 4/27/20 8:22 PM, Miquel Raynal
On 4/29/20 11:35 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 29 Apr
2020 11:27:43 +0200:
Hi Miquèl,
On 4/27/20 8:22 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 15 Apr
2020 17:57:30 +0200:
This patch removes the constant
Hi rob,
On 4/28/20 5:28 PM, Rob Herring wrote:
On Wed, Apr 15, 2020 at 05:57:25PM +0200, Christophe Kerello wrote:
This patch adds the documentation of the device tree bindings for the STM32
FMC2 controller.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mfd/st,stm32-fmc2
Hi Miquèl,
On 4/27/20 8:33 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 15 Apr
2020 17:57:31 +0200:
This patch renames functions and local variables to be ready to use
stm32_fmc2 structure.
Signed-off-by: Christophe Kerello
---
-static int
Hi Miquèl,
On 4/27/20 8:22 PM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Wed, 15 Apr
2020 17:57:30 +0200:
This patch removes the constant FMC2_TIMEOUT_US.
FMC2_TIMEOUT_MS is set to 5 seconds and this constant is used
each time that we need to wait (except when
,
Christophe Kerello.
ename the label in v3:
- err_device_register => err_nand_cleanup
- err_dma_setup => err_release_dma
- err_clk_disable => will keep this one
Regards,
Christophe Kerello.
Any way I suppose catching ":\n" is already a good approximation to
find labels?
Not very practical with git grep (
-limits]
else if (tims->twait > FMC2_PMEM_PATT_TIMING_MASK)
Signed-off-by: Christophe Kerello
Cc: sta...@vger.kernel.org
Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash
controller driver")
---
Changes in v2:
- Fixes/stable tag added
driv
On 7/1/19 9:11 AM, Miquel Raynal wrote:
Hi Christophe,
Christophe Kerello wrote on Fri, 21 Jun
2019 16:43:09 +0200:
This patch solves warnings detected by setting W=1 when building.
Warnings type detected:
drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function ‘stm32_fmc2_calc_timings
From: Amelie Delaunay
When the system is overloaded, DMA data transfer completion occurs after
100ms. Increase the timeouts to let it the time to complete.
Signed-off-by: Amelie Delaunay
Signed-off-by: Christophe Kerello
---
Changes in v2:
- Replace the author of the patch.
- Define
This patch adds FMC2 NAND controller support used by STM32MP SOCs.
Signed-off-by: Christophe Kerello
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig
b/arch/arm/configs/multi_v7_defconfig
index e386f35..092255c
This patch enables FMC2 NAND controller used on stm32mp157c-ev1.
Signed-off-by: Christophe Kerello
---
arch/arm/boot/dts/stm32mp157c-ev1.dts | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts
b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index
This patch adds FMC2 NAND controller pins muxing used on stm32mp157c-ev1.
Signed-off-by: Christophe Kerello
---
arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 44 +++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
b/arch/arm
This patch adds FMC2 NAND controller support used by stm32mp157c SOC.
Signed-off-by: Christophe Kerello
---
arch/arm/boot/dts/stm32mp157c.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi
b/arch/arm/boot/dts/stm32mp157c.dtsi
index
This patchset adds and enables FMC2 NAND controller used on
stm32mp157c-ev1.
Christophe Kerello (4):
ARM: dts: stm32: add FMC2 NAND controller support on stm32mp157c
ARM: dts: stm32: add FMC2 NAND controller pins muxing on
stm32mp157c-ev1
ARM: dts: stm32: enable FMC2 NAND controller
When the system is overloaded, DMA data transfer completion occurs after
100ms. Increase the timeouts to let it the time to complete.
Signed-off-by: Amelie Delaunay
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2
-limits]
else if (tims->twait > FMC2_PMEM_PATT_TIMING_MASK)
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 90 +++---
1 file changed, 29 insertions(+), 61 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
b/drive
On 4/24/19 4:49 PM, Fabien Dessenne wrote:
During probe, check the "get_irq" error value.
Signed-off-by: Fabien Dessenne
Acked-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/mt
This patch adds the polling mode, a basic mode that do not need
any DMA channels. This mode is also useful for debug purpose.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 329 +
1 file changed, 297 insertions(+), 32 deletions
= <512> (BCH8)
- nand-ecc-strength = <4>, nand-ecc-step-size = <512> (BCH4)
- nand-ecc-strength = <1>, nand-ecc-step-size = <512> (Extended ECC
based on Hamming)
This patch has been tested on Micron MT29F8G08ABACAH4 and
MT29F8G16ABACAH4
Signed-off-by: Christoph
structure and the NAND chip structure
- remove timings description from the device tree
- fix typo issues
- fix kbuildrobot issues
Christophe Kerello (3):
dt-bindings: mtd: stm32_fmc2: add STM32 FMC2 NAND controller
documentation
mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash contro
This patch adds the documentation of the device tree bindings for the STM32
FMC2 NAND controller.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mtd/stm32-fmc2-nand.txt| 61 ++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree
On 12/7/18 10:06 AM, Linus Walleij wrote:
Hi Christophe,
On Thu, Nov 29, 2018 at 5:42 PM Christophe Kerello
wrote:
+/* FMC2 Controller Registers */
+#define FMC2_BCR1 0x0
+#define FMC2_PCR 0x80
(...)
+/* Register: FMC2_BCR1 */
+#define
On 12/7/18 10:06 AM, Linus Walleij wrote:
Hi Christophe,
On Thu, Nov 29, 2018 at 5:42 PM Christophe Kerello
wrote:
+/* FMC2 Controller Registers */
+#define FMC2_BCR1 0x0
+#define FMC2_PCR 0x80
(...)
+/* Register: FMC2_BCR1 */
+#define
Hi Linus,
It is correct.
I will replace "manual mode" by "polling mode" in next patchset.
Regards,
Christophe Kerello.
On 12/7/18 10:16 AM, Linus Walleij wrote:
On Thu, Nov 29, 2018 at 5:42 PM Christophe Kerello
wrote:
This patch adds the manual mode, a basic mode that
Hi Linus,
It is correct.
I will replace "manual mode" by "polling mode" in next patchset.
Regards,
Christophe Kerello.
On 12/7/18 10:16 AM, Linus Walleij wrote:
On Thu, Nov 29, 2018 at 5:42 PM Christophe Kerello
wrote:
This patch adds the manual mode, a basic mode that
nand_controller_ops stm32_fmc2_nand_controller_ops = {
.attach_chip = stm32_fmc2_attach_chip,
.exec_op = stm32_fmc2_exec_op,
.setup_data_interface = stm32_fmc2_setup_interface,
};
Regards,
Christophe Kerello.
On 12/7/18 11:18 AM, Miquel Raynal wrote:
Hi Christophe
nand_controller_ops stm32_fmc2_nand_controller_ops = {
.attach_chip = stm32_fmc2_attach_chip,
.exec_op = stm32_fmc2_exec_op,
.setup_data_interface = stm32_fmc2_setup_interface,
};
Regards,
Christophe Kerello.
On 12/7/18 11:18 AM, Miquel Raynal wrote:
Hi Christophe
This patch adds the manual mode, a basic mode that do not need
any DMA channels. This mode is also useful for debug purpose.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 329 +
1 file changed, 297 insertions(+), 32 deletions
ypo issues
- fix kbuildrobot issues
Christophe Kerello (3):
dt-bindings: mtd: stm32_fmc2: add STM32 FMC2 NAND controller
documentation
mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver
mtd: rawnand: stm32_fmc2: add manual mode
.../devicetree/bindings/mtd/stm32-fmc2-nand.t
This patch adds the manual mode, a basic mode that do not need
any DMA channels. This mode is also useful for debug purpose.
Signed-off-by: Christophe Kerello
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 329 +
1 file changed, 297 insertions(+), 32 deletions
ypo issues
- fix kbuildrobot issues
Christophe Kerello (3):
dt-bindings: mtd: stm32_fmc2: add STM32 FMC2 NAND controller
documentation
mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver
mtd: rawnand: stm32_fmc2: add manual mode
.../devicetree/bindings/mtd/stm32-fmc2-nand.t
= <512> (BCH8)
- nand-ecc-strength = <4>, nand-ecc-step-size = <512> (BCH4)
- nand-ecc-strength = <1>, nand-ecc-step-size = <512> (Extended ECC
based on Hamming)
This patch has been tested on Micron MT29F8G08ABACAH4 and
MT29F8G16ABACAH4
Signed-off-by: Christoph
= <512> (BCH8)
- nand-ecc-strength = <4>, nand-ecc-step-size = <512> (BCH4)
- nand-ecc-strength = <1>, nand-ecc-step-size = <512> (Extended ECC
based on Hamming)
This patch has been tested on Micron MT29F8G08ABACAH4 and
MT29F8G16ABACAH4
Signed-off-by: Christoph
This patch adds the documentation of the device tree bindings for the STM32
FMC2 NAND controller.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mtd/stm32-fmc2-nand.txt| 61 ++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree
This patch adds the documentation of the device tree bindings for the STM32
FMC2 NAND controller.
Signed-off-by: Christophe Kerello
---
.../devicetree/bindings/mtd/stm32-fmc2-nand.txt| 61 ++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree
FMC2_PCR);
pcr |= FMC2_PCR_PWID(FMC2_PCR_PWID_BUSWIDTH_16);
writel_relaxed(pcr, fmc2->io_base + FMC2_PCR);
}
Regards,
Christophe Kerello.
+}
Regards,
Boris
FMC2_PCR);
pcr |= FMC2_PCR_PWID(FMC2_PCR_PWID_BUSWIDTH_16);
writel_relaxed(pcr, fmc2->io_base + FMC2_PCR);
}
Regards,
Christophe Kerello.
+}
Regards,
Boris
and handle the nand controller structure.
Regards,
Christophe Kerello.
+ struct stm32_fmc2_nand nand;
+ struct device *dev;
+ void __iomem *io_base;
+ void __iomem *data_base[FMC2_MAX_CE];
+ void __iomem *cmd_base[FMC2_MAX_CE];
+ void __iomem *addr_base
and handle the nand controller structure.
Regards,
Christophe Kerello.
+ struct stm32_fmc2_nand nand;
+ struct device *dev;
+ void __iomem *io_base;
+ void __iomem *data_base[FMC2_MAX_CE];
+ void __iomem *cmd_base[FMC2_MAX_CE];
+ void __iomem *addr_base
On 10/12/2018 10:32 PM, Rob Herring wrote:
On Fri, Oct 05, 2018 at 11:41:58AM +0200, christophe.kere...@st.com wrote:
From: Christophe Kerello
This patch adds the documentation of the device tree bindings for the STM32
FMC2 NAND controller.
Signed-off-by: Christophe Kerello
On 10/12/2018 10:32 PM, Rob Herring wrote:
On Fri, Oct 05, 2018 at 11:41:58AM +0200, christophe.kere...@st.com wrote:
From: Christophe Kerello
This patch adds the documentation of the device tree bindings for the STM32
FMC2 NAND controller.
Signed-off-by: Christophe Kerello
.
Yes, I can create 2 structures: one for the controller (stm32_fmc2) and
one for the NAND chip (stm32_fmc2_nand_chip).
Regards,
Christophe Kerello.
Regards,
Boris
.
Yes, I can create 2 structures: one for the controller (stm32_fmc2) and
one for the NAND chip (stm32_fmc2_nand_chip).
Regards,
Christophe Kerello.
Regards,
Boris
Hi Boris,
On 09/24/2018 07:17 PM, Boris Brezillon wrote:
Hi Christophe,
On Mon, 24 Sep 2018 18:36:27 +0200
Christophe Kerello wrote:
+- st,fmc2_timings: array of 8 bytes for NAND timings. The meanings of
+ these bytes are:
+ byte 0 TCLR : CLE to RE delay in number of AHB clock cycles
Hi Boris,
On 09/24/2018 07:17 PM, Boris Brezillon wrote:
Hi Christophe,
On Mon, 24 Sep 2018 18:36:27 +0200
Christophe Kerello wrote:
+- st,fmc2_timings: array of 8 bytes for NAND timings. The meanings of
+ these bytes are:
+ byte 0 TCLR : CLE to RE delay in number of AHB clock cycles
:39 +0200:
From: Christophe Kerello
The driver adds the support for the STMicroelectronics FMC2 NAND
Controller found on STM32MP SOCs.
This patch is based on FMC2 command sequencer.
The purpose of the command sequencer is to facilitate the programming
and the reading of NAND flash pages
1 - 100 of 105 matches
Mail list logo
