Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年4月20日 週二 下午5:05寫道： > > On Fri, Apr 9, 2021 at 12:53 PM Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel_orientation() is first called

Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"

Hi, Yongqiang: Yongqiang Niu 於 2021年4月12日 週一 下午7:19寫道： > > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f. > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

viewed-by: Chun-Kuang Hu > > Reported-by: Hulk Robot > Signed-off-by: Wang Li > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/me

Re: [PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

Hi, Neil: Neil Armstrong 於 2021年4月9日 週五 下午4:43寫道： > > On MT8167, only CEA modes and anything using a clock below 148500 is > supported for HDMI. This change adds some checks to make sure the > video format is OK for MT8167. I think this patch should be separated to 3 patches. check CEA mode,

Re: [PATCH] drm/mediatek: force hsa hsa hfp packets multiple of line num to avoid screen shift

Hi, Jitao: Jitao Shi 於 2021年4月7日 週三 下午10:37寫道： > > The bridge chip ANX7625 require the line packets ending at the sametime > or ANX7625 will shift the screen. > > Change-Id: Ia324ad28fbff54140feedb9a1d6bfb2b246d0447 > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 12

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

Andrew Lunn 於 2021年4月7日 週三 上午12:02寫道： > > On Tue, Apr 06, 2021 at 11:47:08PM +0800, Chun-Kuang Hu wrote: > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道： > > > > > > Add support for MediaTek PHYs found in MT7530 and MT7531 switches.

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

DENG Qingfang 於 2021年4月6日 週二 下午11:57寫道： > > On Tue, Apr 6, 2021 at 11:47 PM Chun-Kuang Hu wrote: > > > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道： > > > --- a/drivers/net/phy/Kconfig > > > +++ b/drivers/net/phy/Kconfig >

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

Hi, Qingfang: DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道： > > Add support for MediaTek PHYs found in MT7530 and MT7531 switches. > The initialization procedure is from the vendor driver, but due to lack > of documentation, the function of some register values remains unknown. > > Signed-off-by: DENG

Re: [PATCH 0/3] Refine mtk-cmdq-mailbox callback mechanism

Hi, Jassi: Chun-Kuang Hu 於 2021年3月15日 週一 上午7:33寫道： > > mtk-cmdq-mailbox use proprietary callback mechanism and proprietary > error number, but these could be replaced by standard callback > mechanism and standard error number. In addition, use cmdq_pkt as > callback data to pr

Re: [PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation

Hi, Dafna: Dafna Hirschfeld 於 2021年3月30日 週二 下午7:09寫道： > > commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") > broke the display support for elm device since mtk_dpi calls > drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR > while mtk_hdmi does not yet

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

Hi, Enric: Enric Balletbo i Serra 於 2021年3月30日 週二 下午5:43寫道： > > Hi, > > On 3/2/21 12:07, Enric Balletbo i Serra wrote: > > From: Boris Brezillon > > > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > > Mediatek drivers which generates correct modalias for automatic

Re: [PATCH] drm/mediatek: crtc: Make config-updating atomic

Applied to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. Chun-Kuang Hu 於 2021年3月13日 週六 下午5:43寫道： > > While updating config, the irq would occur and get the partial > config, so use

Re: [PATCH 1/2] dt-bindings: devapc: Update bindings

Hi, Nina: Nina Wu 於 2021年3月26日 週五 下午3:34寫道： > > From: Nina Wu > > To support newer hardware architecture of devapc, > update device tree bindings. > > Signed-off-by: Nina Wu > --- > .../devicetree/bindings/soc/mediatek/devapc.yaml | 41 > ++ > 1 file changed, 41

Re: [PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

> Signed-off-by: Dafna Hirschfeld > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9e876927c60d..8260bc5afe66 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5963,6 +5963,7 @@ DRM DRIVERS FOR

Re: [PATCH v4, 08/10] soc: mediatek: mmsys: add component RDMA4

Hi, Matthias: Yongqiang Niu 於 2021年1月5日 週二 上午11:07寫道： > > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depends on this patch. [1] https://patchwork.kernel.org/project/linux

Re: [PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

Hi, Matthias: Chun-Kuang Hu 於 2020年12月29日 週二 下午11:23寫道： > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:37寫道： > > > > This patch add component OVL_2L2 > > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depe

Re: [v5, 1/2] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid

Hi, Enric: Enric Balletbo Serra 於 2021年3月18日 週四 下午10:25寫道： > > Hi Rex-BC Chen, > > Thank you for your patch. > > Missatge de Rex-BC Chen del dia dj., 18 de > març 2021 a les 6:42: > > > > Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid. > > > > Signed-off-by: Pi-Hsun Shih >

Re: [v5,0/2] Add check for max clock rate in mode_valid

Hi, Rex: For this series, applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. Rex-BC Chen 於 2021年3月18日 週四 下午1:41寫道： > > Changes in v5: > fix build error > > Changes in v4: >

Re: [PATCH 1/2] dt-bindings: mediatek: mmsys: add mt1867 binding

Hi, Matthias: Ping again. Regards, Chun-Kuang. Fabien Parent 於 2021年2月24日 週三 上午6:21寫道： > > Hi Matthias, > > Pinging you in case you didn't see @Chun-Kuang Hu's question for you. > > Thanks, > Best regards, > Fabien > > On Sun, Jan 10, 2021 at 12:18 AM Chun-

Re: [PATCH] drm/mediatek: fine tune the data lane trail by project dts

Hi, Jitao: Jitao Shi 於 2021年2月1日 週一 上午11:48寫道： > > Some panels or bridges require customized hs_da_trail time. > So add a property in devicetree for this panels and bridges. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +- > 1 file changed, 9

Re: [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static

o this > commit marks it static. Reviewed-by: Chun-Kuang Hu > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/soc/mediatek/mtk-mutex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > b/dr

Re: [RESEND,v4,1/2] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid

Hi, Rex: Rex-BC Chen 於 2021年3月16日 週二 上午11:26寫道： > > Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Rex-BC Chen > Signed-off-by: Jitao Shi > --- > drivers/gpu/

[PATCH 1/3] mailbox: mtk-cmdq: Remove cmdq_cb_status

: linux-media...@lists.infradead.org Signed-off-by: Chun-Kuang Hu --- drivers/mailbox/mtk-cmdq-mailbox.c | 10 +- include/linux/mailbox/mtk-cmdq-mailbox.h | 7 +-- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk

[PATCH 3/3] mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data

...@lists.infradead.org Cc: linux-media...@lists.infradead.org Signed-off-by: Chun-Kuang Hu --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 ++ include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk

[PATCH 2/3] mailbox: mtk-cmdq: Use mailbox rx_callback

of cmdq_task_cb. Cc: Jassi Brar Cc: Matthias Brugger Cc: Houlong Wei Cc: Bibby Hsieh Cc: Dennis YC Hsieh Cc: linux-kernel@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-media...@lists.infradead.org Signed-off-by: Chun-Kuang Hu --- drivers/mailbox/mtk-cmdq-mailbox.c | 14

[PATCH 0/3] Refine mtk-cmdq-mailbox callback mechanism

, so keep proprietary mechanism until client driver use the standard one. Chun-Kuang Hu (3): mailbox: mtk-cmdq: Remove cmdq_cb_status mailbox: mtk-cmdq: Use mailbox rx_callback mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data drivers/mailbox/mtk-cmdq-mailbox.c | 24

Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value

Hi, Wang: Wang Qing 於 2021年3月13日 週六 下午3:48寫道： > > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. Applied to mediatek-drm-next [1], thanks. [1]

[PATCH] drm/mediatek: crtc: Make config-updating atomic

While updating config, the irq would occur and get the partial config, so use variable config_updating to make updating atomic. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [RESEND PATCH v1 2/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

Hi, Yongqiang: Yongqiang Niu 於 2021年3月10日 週三 下午6:58寫道： > > This reverts commit c9ea564f3d9dd20d88bd34f40a6ff6d31a0d7e8c. > > Signed-off-by: Yongqiang Niu > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 80 > +- > 1 file changed, 71 insertions(+), 9

Re: [PATCH v8 3/4] arm64: dts: mediatek: add mt6765 support

Hi, Macpaul: Macpaul Lin 於 2020年2月21日 週五 下午6:22寫道： > > From: Mars Cheng > > Add basic chip support for Mediatek 6765, include > uart node with correct uart clocks, pwrap device > > Add clock controller nodes, include topckgen, infracfg, > apmixedsys and subsystem. > > Signed-off-by: Mars Cheng

Re: [PATCH] arm64: dts: mt8173: fix property typo of 'phys' in dsi node

Hi, Chunfeng: Chunfeng Yun 於 2021年3月8日 週一 下午3:05寫道： > > Use 'phys' instead of 'phy'. Reviewed-by: Chun-Kuang Hu > > Fixes: 81ad4dbaf7af ("arm64: dts: mt8173: Add display subsystem related > nodes") > Cc: stable > Signed-off-by: Chunfeng Yun > --- > arc

Re: [PATCH v3 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi

Hi, Jitao: Rob Herring 於 2021年2月11日 週四 上午4:19寫道： > > On Mon, 08 Feb 2021 09:42:21 +0800, Jitao Shi wrote: > > Add compatible "mediatek,mt8192-dpi" for the mt8192 dpi. > > > > Signed-off-by: Jitao Shi > > --- > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > > 1 file

Re: [PATCH v2 2/2] drm/mediatek: dsi: fine tune the line time cause by EOTp

Hi, Jitao: Jitao Shi 於 2021年2月1日 週一 上午11:36寫道： > > Enabling EoTp will make the line time larger, so the hfp and > hbp should be reduced to keep line time. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v2 1/2] drm/mediatek: dsi: Fix EoTp flag

Hi, Jitao: Jitao Shi 於 2021年2月1日 週一 上午11:36寫道： > > SoC will transmit the EoTp (End of Transmission packet) when > MIPI_DSI_MODE_EOT_PACKET flag is set. I've modified the title and message as: drm/mediatek: dsi: Use symbolized register definition For HSTX_CKLP_EN and DIS_EOT, use symbolized

Re: [PATCH] dt-bindings: display: mediatek,dpi: Convert to use graph schema

nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: CK Hu > Cc: Jitao shi > Cc: dri-de...@lists.freedesktop.org > Cc: linux-media...@lists.infradead.org > Signed-off-by: Rob He

Re: [PATCH v1] drm/mediatek: move page flip handle into cmdq cb

Hi, Yongqiang: Yongqiang Niu 於 2021年2月19日 週五 下午5:54寫道： > > move page flip handle into cmdq cb > irq callback will before cmdq flush ddp register > into hardware, that will cause the display frame page > flip event before it realy display out time > > Signed-off-by: Yongqiang Niu > --- >

Re: [PATCH -next] soc / drm: mediatek: Mark mtk_mutex_driver with static keyword

Hi, Zou: Zou Wei 於 2021年2月18日 週四 下午3:12寫道： > > Fix the following sparse warning: > > drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' > was not declared. Should it be static? > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Zou Wei > --- >

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

E_NO_EOT_PACKET. For Mediatek part, Acked-by: Chun-Kuang Hu > > Signed-off-by: Nicolas Boichat > --- > I considered adding _DISABLE_ instead, but that'd make the > flag names a big too long. > > Generated with: > flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':

Re: [PATCH next v3 04/16] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

compatible items to make dependence clear. Acked-by: Chun-Kuang Hu > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v3: modify commit message > v2: no changes > --- > .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml| 11 +++--

Re: [PATCH next v3 03/16] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

Hi, Chunfeng: Chunfeng Yun 於 2021年2月1日 週一 下午3:00寫道： > > mt7623-mipi-tx is compatible to mt2701-mipi-tx, and use > "mediatek,mt2701-mipi-tx" instead on MT7623, so modify > the compatible items to make dependence clear. Acked-by: Chun-Kuang Hu > > Cc: Chun-K

Re: [PATCH v3 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192

Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道： Where is the description? Say something here. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c >

Re: [PATCH v3 1/3] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid

Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道： > > Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 17 + > 1 file changed, 17 inserti

Re: [PATCH v3 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi

Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道： > > Add compatible "mediatek,mt8192-dpi" for the mt8192 dpi. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > 1 file changed

Re: [PATCH v3 1/3] dt-binding: gce: add gce header file for mt8192

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月5日 週五 下午3:19寫道： > > From: Yongqiang Niu > > Add documentation for the mt8192 gce. > > Add gce header file defined the gce hardware event, > subsys number and constant for mt8192. > > Signed-off-by: Yongqiang Niu > Reviewed-by: Rob Herring > Signed-off-by:

Re: [PATCH v6 5/8] drm/mediatek: Fix ccorr size config

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道： > > From: Yongqiang Niu > > Fix setting to follow hardware datasheet. The original error setting > affects mt8192 display. > Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v6 4/8] drm/mediatek: separate ccorr module

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道： > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang.

Re: [PATCH v6 6/8] drm/mediatek: add matrix_bits private data for ccorr

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:14寫道： > > From: Yongqiang Niu > > Add matrix_bits and coeffs_precision to ccorr private data: > - matrix bits of mt8183 is 10 > - matrix bits of mt8192 is 11 Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH] drm/mediatek: enable dither function

Hi, Hsin-Yi: Chun-Kuang Hu 於 2021年2月1日 週一 上午12:20寫道： > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2021年1月31日 週日 下午1:11寫道： > > > > From: Yongqiang Niu > > > > Enable dither function to improve the display quality. > > Reviewed-by: Chun-Kuang Hu > Applied

Re: [PATCH v4 5/8] drm/mediatek: separate ccorr module

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午3:35寫道： > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/Makefile | 3 +- >

Re: [PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

Hi, Hsin-Yi: CK Hu 於 2021年1月29日 週五 下午4:21寫道： > > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, > > ovl will hang up when more than 1 layer enabled. > > Reviewed-by:

Re: [PATCH v13 6/8] drm/mediatek: enable dither function

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > Enable dither function to improve the display quality for dither > supported bpc 4, 6, 8. For not supported bpc, use relay mode. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

Re: [PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v13 4/8] drm/mediatek: separate gamma module

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data After I clean up all checkpatch error, applied to mediatek-drm-next [1]. Remember to clean up all checkpatch error before send

Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, >

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

Hi, Matthias: Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道： > > Hi, Matthias: > > Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道： > > > > rx_callback is a standard mailbox callback mechanism and could > > cover the function of proprietary cmdq_task_cb, so it is better >

Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

Hi, Chunfeng: Chun-Kuang Hu 於 2021年1月24日 週日 下午12:47寫道： > > Hi, Chunfeng: > > Chunfeng Yun 於 2021年1月22日 週五 下午8:04寫道： > > > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > > and in fact uses "mediatek,mt2701-mipi-tx" inst

Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

Hi, Chunfeng: Chunfeng Yun 於 2021年1月22日 週五 下午8:04寫道： > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. Reviewed-

Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

tree. If a property does not exist in binding document, we should not write it in device tree. So let's drop this patch and remove clock-names in mt8183.dtsi. Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v2: new patch

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

Matthias Brugger 於 2021年1月21日 週四 下午4:19寫道： > > On Thu, Jan 21, 2021 at 07:46:44AM +0800, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道： > > > > > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote

Re: [PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:33寫道： > > On Thu, Jan 07, 2021 at 07:17:29AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, > > so move it to soc folder. > >

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道： > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by both drm and mdp driver, so change disp/ddp term to > > mutex to show that it's a

Re: [PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

Chun-Kuang Hu 於 2021年1月7日 週四 上午7:17寫道： > > mtk mutex is a driver used by DRM and MDP [1], so this series move > mtk mutex driver from DRM folder to soc folder, so it could be used > by DRM and MDP. Applied [1/5] ~ [4/5] to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/

Re: [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

Hi, Chunfeng: Chunfeng Yun 於 2021年1月16日 週六 下午5:07寫道： > > The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. > >

Re: [PATCH next 03/15] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

add an optional "clock-names" property, it's not used to get the clock, > but some DTS files provide it. Separate the clock part to another patch. Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > .../binding

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

Hi, Yongqiang: Chun-Kuang Hu 於 2021年1月7日 週四 下午6:05寫道： > > Hi, Yongqiang: > > Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > > > Get the fifo size from device tree > > because each rdma in the same SoC may have different fifo size > > Reviewed-by: Chun-Kuang

Re: [PATCH v3, 11/15] drm/mediatek: fix aal size config

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道： > > the orginal setting is not correct, fix it follow hardware data sheet. > if keep this error setting, mt8173/mt8183 display ok > but mt8192 display abnormal. > Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

Rob Herring 於 2021年1月15日 週五 上午3:11寫道： > > On Mon, 11 Jan 2021 15:43:37 +0800, Yongqiang Niu wrote: > > add description for postmask > > postmask is used control round corner for display frame > > > > Signed-off-by: Yongqiang Niu > > --- > >

Re: [PATCH] drm/mediatek: mtk_dpi: Create connector for bridges

Hi, Hsin-Yi: Chun-Kuang Hu 於 2020年12月11日 週五 下午10:04寫道： > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2020年12月3日 週四 下午4:24寫道： > > > > Similar to a9d9fea74be2 ("drm/mediatek: mtk_dsi: Create connector for > > bridges"): > > > > Use the drm_bridge_

Re: [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display

Rob Herring 於 2021年1月12日 週二 下午10:49寫道： > > On Thu, 07 Jan 2021 11:11:11 +0800, Yongqiang Niu wrote: > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v3, 12/15] drm/mediatek: separate ccorr module

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:54寫道： > > ccorr ctm matrix bits will be different in mt8192 This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1]

Re: [PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道： > > gamma power domain need controled in the device. In this series, why only gamma and color add pm runtime support? I think all ddp component need pm runtime support. And pm runtime support is not related to mt8192, so move these patches

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道： > > add description for postmask > postmask is used control round corner for display frame After changing to 'used to control', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bind

Re: [PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/

Re: [PATCH v3, 03/15] arm64: dts: mt8192: add display node

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道： > > add display node > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 > +++ > 1 file changed, 134 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道： > > This patch add component OVL_2L2 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3, 05/15] drm/mediatek: add component POSTMASK

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道： > > This patch add component POSTMASK, This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1]

Re: [PATCH v3, 06/15] drm/mediatek: add component RDMA4

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道： > > This patch add component RDMA4 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道： > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Could you describe more information? Without this patch, what would happen? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 > 1

Re: [PATCH v3, 08/15] drm/mediatek: check if fb is null

Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道： > > It's possible that state->base.fb is null. Add a check before access its > format. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH 1/2] dt-bindings: mediatek: mmsys: add mt1867 binding

Hi, Matthias: Rob Herring 於 2020年10月31日 週六 上午3:17寫道： > > On Tue, 27 Oct 2020 17:06:29 +0100, Fabien Parent wrote: > > Add binding documentation for MT8167 SoC. Even though the title need to change to 'mt8167', this patch looks good to me. How do you think about this patch? One drm patch [1]

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

Hi, Matthias: Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道： > > rx_callback is a standard mailbox callback mechanism and could > cover the function of proprietary cmdq_task_cb, so it is better > to use the standard one instead of the proprietary one. But > register rx_callbac

Re: [PATCH] drm/mediatek: dsi: Fix EoTp flag

Hi, Jitao: Jitao Shi 於 2021年1月7日 週四 下午10:34寫道： > > SoC will transmit the EoTp (End of Transmission packet) when > MIPI_DSI_MODE_EOT_PACKET flag is set. > > Enabling EoTp will make the line time larger, so the hfp and > hbp should be reduced to keep line time. > > Signed-off-by: Jitao Shi > ---

Re: [PATCH v9, 10/11] drm/mediatek: add DDP support for MT8183

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > Add DDP support for MT8167 SoC. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 48 > ++ > 1 file changed, 48 insertions(+) > > diff --git

Re: [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > not all SoC has dither function in gamma module > dd private data to control this function setting 'add' ? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- > 1 file changed, 9

Re: [PATCH v9, 07/11] drm/mediatek: separate gamma module

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > mt8183 gamma module will different with mt8173 > separate gamma for add private data I've applied series "Decouple Mediatek DRM sub driver" [1] into mediatek-drm-next [2] and this patch would conflict with mediatek-drm-next, so please

Re: [PATCH v9, 02/11] dt-bindings: mediatek: add description for mt8183 display

ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > Get the fifo size from device tree > because each rdma in the same SoC may have different fifo size Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek

Re: [PATCH v9, 03/11] arm64: dts: mt8183: rename rdma fifo size

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道： > > property name must include only lowercase and '-' Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display

Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:11寫道： > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediat

[PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

From: CK Hu mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, so move it to soc folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 3 +-- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2

[PATCH v2 4/5] drm/mediatek: Automatically search unclaimed mtk mutex in mtk_mutex_get()

From: CK Hu Moving mutex resource management from client driver to mutex driver could prevent client drivers negotiating for resource management. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_mutex.c

[PATCH v2 2/5] drm/mediatek: Rename file mtk_drm_ddp to mtk_mutex

From: CK Hu After mmsys routing function is moved out of mtk_drm_ddp.c, mtk_drm_ddp.c has only mtk mutex function, so rename it to match the function in it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm

[PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

From: CK Hu mtk mutex is used by both drm and mdp driver, so change disp/ddp term to mutex to show that it's a common driver for drm and mdp. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 30 +-- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2

[PATCH v2 1/5] drm/mediatek: Remove redundant file including

From: CK Hu Those file includings are useless, so remove them. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 2 -- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

mtk mutex is a driver used by DRM and MDP [1], so this series move mtk mutex driver from DRM folder to soc folder, so it could be used by DRM and MDP. Changes in v2: 1. Rebase onto mediatek-drm-next [2]. 2. Export symbol for mtk-mutex API. [1] https://patchwork.kernel.org/patch/11140751/ [2]

Re: [PATCH v4, 10/10] soc: mediatek: mmsys: add mt8192 mmsys support

Hi, Yongqiang: Yongqiang Niu 於 2021年1月5日 週二 上午11:17寫道： > > add mt8192 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 149 > ++ >

Re: [PATCH v8, 5/6] drm/mediatek: add RDMA fifo size error handle

Hi, Yongqiang: Yongqiang Niu 於 2021年1月5日 週二 下午2:36寫道： > > On Mon, 2020-12-14 at 22:54 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月11日 週五 上午8:45寫道： > > > > > > On Thu, 2020-12-10 at 23:50 +0800,

Re: [PATCH v3, 6/8] soc: mediatek: mmsys: add component RDMA4

Hi, Yongqiang: Yongqiang Niu 於 2020年12月28日 週一 下午4:37寫道： > > This patch add component RDMA4 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/inc

Re: [PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

Hi, Yongqiang: Yongqiang Niu 於 2020年12月28日 週一 下午4:37寫道： > > This patch add component OVL_2L2 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/inc

  1   2   3   4   5   >