Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
ards Frank > > > > Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx&quo

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:08寫道: > > On Tue, 2020-08-04 at 00:04 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kua

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:19寫道: > > > On Tue, 2020-08-04 at 00:13 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri, 2020-07-31 at 23:03 +0800, Chu

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank Wunderl

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
d in this case, so call > mtk_drm_find_possible_crtc_by_comp() to find out the correct possible > crtc. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dsi.c

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
e, so search > pipeline information to find out the correct possible crtc. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Stu Hsieh > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 + > drivers/gpu/drm/mediatek/mtk_

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道: > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional propertie

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 23:03 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月31日 週五 上午10:44寫道: > > > > > > Hi Chun-Kuang, > > > > > > > &

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > Hi Chun-Kuang, > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > This patch is for "mediatek,mt6779-devapc", so I think commit title > > should show the SoC ID. >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月3日 週一 下午12:05寫道: > > Hi Chun-Kuang, > > On Sun, 2020-08-02 at 07:50 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security support and da

Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午4:06寫道: > > > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > > , "Davi

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午12:44寫道: > > Hi, > > Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu > : > >Hi, Frank: > >> - disable tmds on phy on mt2701 > >> - support other resolutions like 1280x1024 > > > >If this

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Jitao Shi > > [Detail] > dpi/dsi get the possible_crtc by > mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp) > I would like more information of why do this patch. For example: For current mediatek dsi encoder, its possible

Re: [PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > Describe why need this patch. I think the reason is: For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this ca

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:19寫道: > > From: chunhui dai > > - disable tmds on phy on mt2701 > - support other resolutions like 1280x1024 If this patch does two things, it should be broken into two patches. > > without this Patch i see flickering on my TFT (1280x1024), > so

Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Bibby Hsieh > > We can select output component by decive node port. > Main path default output component is DSI. > External path default output component is DPI. > > without this Patch i get this warning: > > WARNING: CPU: 3 PID: 70

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-01 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: This patch is for "mediatek,mt6779-devapc", so I think commit title should show the SoC ID. Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月31日 週五 上午10:52寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 00:14 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security sup

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月31日 週五 上午10:44寫道: > > Hi Chun-Kuang, > > > On Thu, 2020-07-30 at 00:38 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-30 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-29 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-29 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-28 Thread Chun-Kuang Hu
Neal Liu 於 2020年7月29日 週三 上午10:10寫道: > > Hi Chun-Kuang, > > On Tue, 2020-07-28 at 23:35 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月28日 週二 上午11:52寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Mon

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-28 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月28日 週二 上午11:52寫道: > > Hi Chun-Kuang, > > On Mon, 2020-07-27 at 22:47 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月27日 週一 上午11:06寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-27 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月27日 週一 下午3:54寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-27 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月27日 週一 上午11:06寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-24 at 23:55 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月24日 週五 下午2:55寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri

Re: [v7, PATCH 6/7] drm/mediatek: add fifo_size into rdma private data

2020-07-24 Thread Chun-Kuang Hu
The primary thing of this patch is to get fifo size from device tree. So you may modify title to show the primary thing. Yongqiang Niu 於 2020年7月23日 週四 上午10:12寫道: > > the fifo size of rdma in mt8183 is different. > rdma0 fifo size is 5k > rdma1 fifo size is 2k I would like the description to be "

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月25日 週六 上午11:32寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > >

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:05寫道: > > add mmsys private data > > Feature: drm/mediatek > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mmsys/Makefile | 2 + > drivers/soc/mediatek/mmsys/mt2701-mmsys.c

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl I think this is done in [1], [2], [3], this patch just add the support of mt8183-ovl and mt8183-ovl-2l. [1] https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-24 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月24日 週五 下午2:55寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-24 at 00:32 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月23日 週四 下午2:11寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Wed

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-23 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月23日 週四 下午2:11寫道: > > Hi Chun-Kuang, > > On Wed, 2020-07-22 at 22:25 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月22日 週三 上午11:49寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Wed

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年7月23日 週四 下午6:06寫道: > > On Thu, 2020-07-23 at 11:34 +0200, Enric Balletbo Serra wrote: > > Hi Yongqian Niu, > > > > Thank you for your patch > > > > Missatge de Yongqiang Niu del dia dj., 23 > > de jul. 2020 a les 4:05: > > > > > > move ddp component defint into mtk_mmsys.h >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-22 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月22日 週三 上午11:49寫道: > > Hi Chun-Kuang, > > On Wed, 2020-07-22 at 07:21 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月21日 週二 下午12:00寫道: > > > > > > > > + > > > +/* > > >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-21 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月21日 週二 下午12:00寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH v2 1/2] [media] mtk-mdp: add driver to probe mdp components

2020-07-20 Thread Chun-Kuang Hu
Hi, Eizan: Eizan Miyamoto 於 2020年5月6日 週三 下午4:41寫道: > > Broadly, this patch (1) adds a driver for various MTK MDP components to > go alongside the main MTK MDP driver, and (2) hooks them all together > using the component framework. > > (1) Up until now, the MTK MDP driver controls 8 devices in th

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-15 Thread Chun-Kuang Hu
HI, Neal: Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-13 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月13日 週一 下午4:27寫道: > > Hi Chun-Kuang, > > Thanks for your review. > > On Fri, 2020-07-10 at 22:21 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月10日 週五 上午11:23寫道: > > > > > > Hi Chun-Kuang,

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-10 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月10日 週五 上午11:23寫道: > > Hi Chun-Kuang, > > Thanks for your review. > > On Thu, 2020-07-09 at 21:01 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > > > > > MediaTek b

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-09 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. For DRM part, Acked-by: Chun-Kuang Hu > > Change since v2: > - Keep behavior in drm crtc driver and > separate bug

Re: [PATCH v3 9/9] drm/mediatek: reduce clear event

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > No need to clear event again since event always clear before wait. > This fix depend on patch: > "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" Acked-by: Chun-Kuang Hu > > Fixes: 2f965be7f900

Re: [PATCH v2 8/8] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-07-06 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月6日 週一 下午3:20寫道: > > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. > > Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow") I think this patch include two things, one is bug fix, another is changing in

Re: [RESEND PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年6月16日 週二 上午4:31寫道: > > Use the drm_bridge_connector helper to create a connector for pipelines > that use drm_bridge. This allows splitting connector operations across > multiple bridges when necessary, instead of having the last bridge in > the chain crea

Re: [RESEND PATCH v4 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-07-04 Thread Chun-Kuang Hu
gt; Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > Reviewed-by: Chun-

Re: [RESEND PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-07-04 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > Reviewed-by: Chun-Kuang Hu > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None

Re: [RESEND PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-07-04 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Sam Ravnborg > Reviewed-by: Chun-Kuang Hu > --- > > Changes in v4: > - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) > - Cleanup the encoder

Re: [RESEND PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-07-04 Thread Chun-Kuang Hu
l be > named next_bridge. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月19日 週二 下午11:13寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月19日 週二 > 下午5:41寫道: > > > > Equivalent information can be nowadays obtained using function tracer > > > > Reviewed-by: Chun-Kuang Hu Applied to medi

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月19日 週二 下午11:12寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月19日 週二 > 下午5:40寫道: > > > > There are some `static const u8` variables that are not used, this > > triggers a warning building with `make W=1`, it is safe to r

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-07-04 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:23寫道: > > From: Matthias Brugger > > The driver will be loaded by via a platform device. So we > will need to get the device_node from the parent device. > Depending on this we will set the driver data. > As all this is done later already, just delete the call t

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-30 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年7月1日 週三 上午5:02寫道: > > Hi Chun-Kuang, > > On 30/6/20 18:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年6月30日 週二 > > 下午10:34寫道: > >> > >> Hi Sam, Chun-Kuan, > >

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-30 Thread Chun-Kuang Hu
ain of drm_bridge API > >> unconditionally. > >> > >> The patches has been tested on a Acer Chromebook R13 (Elm) running a > >> Chrome OS userspace and checking that the valid EDID mode reported by > >> the bridge is selected. > >> > &g

Re: [PATCH v2] drm/mediatek: remove unnecessary conversion to bool

2020-06-28 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年6月16日 週二 下午2:51寫道: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > to bool return, this change is to make the code a bit readable. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/

Re: [PATCH v4] drm/mediatek: check plane visibility in atomic_update

2020-06-26 Thread Chun-Kuang Hu
/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Chun-Kuang Hu > Reviewed-by: Tomasz Figa > --- > v4: fix c

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-24 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH] drm/mediatek: check plane visibility in atomic_update

2020-06-22 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2020年6月22日 週一 下午1:32寫道: > > Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() > would proceed with invalid plane and we may see vblank timeout. Except the Fixes tag, Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Hsin-Yi Wa

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-20 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月20日 週六 上午11:18寫道: > > Hi Chun-Kuang, > > Thanks for your quick feedback. > > On Sat, 2020-06-20 at 00:25 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > > > > > MT6873 bu

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-19 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
O should us to find help? I think we just need vio address. Using mt8173 for example, if the vio address is 0x1400d03c, we could find the device in mt8173.dtsi [1], ovl1: ovl@1400d000 { compatible = "mediatek,mt8173-disp-ovl"; reg = <0 0x1400d000 0 0x1000>; }; we co

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年6月15日 週一 下午10:14寫道: > > Hi, Neal: > > Neal Liu 於 2020年6月15日 週一 上午10:43寫道: > > > > Hi Chun-Kuang, > > > > > > On Sun, 2020-06-14 at 11:26 +0800, Chun-Kuang Hu wrote: > > > Hi, Neal: > > > > > > Neal Liu

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月15日 週一 上午10:43寫道: > > Hi Chun-Kuang, > > > On Sun, 2020-06-14 at 11:26 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > > > > > MT6873 bus frabric provides TrustZone security

Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool

2020-06-15 Thread Chun-Kuang Hu
Joe Perches 於 2020年6月15日 週一 上午4:41寫道: > > On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > > to bool return, this change is to make the code a bit readable. > [] > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/d

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-13 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-12 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-12 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月12日 週五 上午11:04寫道: > > Hi Chun-Kuang, > > [snip] > > > > > +/* > > > > > + * devapc_violation_irq - the devapc Interrupt Service Routine (ISR) > > > > > will dump > > > > > + * violation information including which > > > > > master violates > > >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-11 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月11日 週四 下午5:26寫道: > > On Wed, 2020-06-10 at 00:01 +0800, Chun-Kuang Hu wrote: > Hi Chun-Kuang, > > [snip] > > > > + > > > +/* > > > + * mtk_devapc_pd_get - get devapc pd_types of register address. >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-09 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH RESEND v9 18/18] media: platform: Add jpeg enc feature

2020-06-07 Thread Chun-Kuang Hu
Hi, Xia: Xia Jiang 於 2020年6月4日 週四 下午5:21寫道: > > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg > decode and encode have great similarities with function operation. > > Signed-off-by: Xia Jiang > --- > v9: add member variable(struct v4l2_rect) in out_q structure for stori

Re: [PATCH v4 11/17] drm/mediatek: Get rid of mtk_smi_larb_get/put

2020-05-30 Thread Chun-Kuang Hu
Hi, Yong: Yong Wu 於 2020年5月30日 週六 下午4:27寫道: > > MediaTek IOMMU has already added the device_link between the consumer > and smi-larb device. If the drm device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > Acked-by: Chun-Ku

Re: [PATCH v4 10/17] drm/mediatek: Add pm runtime support for ovl and rdma

2020-05-30 Thread Chun-Kuang Hu
ime_get for smi via > ovl or rdma device. > > This is a preparing patch that smi cleaning up "mediatek,larb". > Acked-by: Chun-Kuang Hu > CC: CK Hu > Signed-off-by: Yongqiang Niu > Signed-off-by: Yong Wu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c |

Re: [PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-27 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年5月22日 週五 下午6:12寫道: > > If panel has too small hfp or hbp, horizontal_frontporch_byte or > horizontal_backporch_byte may become very small value or negative > value. This patch adjusts their values so that they are greater > than minimum value and keep total of them unc

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月25日 週一 下午4:38寫道: > > > > On 25/05/2020 02:23, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > >> > >> > >> > >> On 08/03/2020 11:52, Dennis YC

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-24 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > > > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Export finalize function to client which helps append eoc and jump > > command to pkt. Let client decide call finalize or not. > > > > Signed-off-by: Dennis YC Hsieh > > Reviewed-by:

Re: [PATCH 3/4] clk/soc: mediatek: mt6779: Bind clock driver from platform device

2020-05-19 Thread Chun-Kuang Hu
Matthias Brugger 於 2020年5月20日 週三 上午5:26寫道: > > > > On 19/05/2020 17:10, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > 於 2020年5月18日 週一 下午7:33寫道: > >> > >> From: Matthias Brugger > >> > >> The mmsys driver is now the top level ent

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:41寫道: > > Equivalent information can be nowadays obtained using function tracer > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +-

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:40寫道: > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu

Re: [PATCH 3/4] clk/soc: mediatek: mt6779: Bind clock driver from platform device

2020-05-19 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:33寫道: > > From: Matthias Brugger > > The mmsys driver is now the top level entry point for the multimedia > system (mmsys), we bind the clock driver by creating a platform device. > We also bind the MediaTek DRM driver which is not yet implement and > therefor w

Re: [PATCH 4/4] arm64: dts: mt6797: Fix mmsys node name

2020-05-19 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:33寫道: > > From: Matthias Brugger > > Node names are supposed to match the class of the device. The > mmsys node is a syscon as it provides more then just a clock controller. > Update the name. Reviewed-by: Chun-Kuang Hu > > Signed-

Re: [PATCH 2/4] clk/soc: mediatek: mt6797: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
ent and > therefor will errror out for now. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- > > drivers/clk/mediatek/clk-mt6797-mm.c | 9 ++--- > drivers/soc/mediatek/mtk-mmsys.c | 8 > 2 files changed, 10 insertions(+), 7 deletion

Re: [PATCH 1/4] clk/soc: mediatek: mt8183: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月18日 週一 下午11:57寫道: > > > > On 18/05/2020 17:30, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > 於 2020年5月18日 週一 下午7:32寫道: > >> > >> From: Matthias Brugger > >> > >> The mmsys driver is n

Re: [PATCH 1/4] clk/soc: mediatek: mt8183: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:32寫道: > > From: Matthias Brugger > > The mmsys driver is now the top level entry point for the multimedia > system (mmsys), we bind the clock driver by creating a platform device. > We also bind the MediaTek DRM driver which is not yet implement and > therefor w

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-18 Thread Chun-Kuang Hu
just delete the call to > of_device_get_match_data. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月15日 週五 上午1:35寫道: > > Hi again, > > On 14/5/20 19:12, Enric Balletbo i Serra wrote: > > Hi Chun-Kuang, > > > > On 14/5/20 18:44, Chun-Kuang Hu wrote: > >> Hi, Enric: > >> > >> Enric Balletbo i Se

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月10日 週日 上午9:24寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月4日 週一 > 下午10:14寫道: > > > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > > deprecated. We started to move all the Mediatek d

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月14日 週四 下午11:42寫道: > > Hi Chun-Kuang, > > On 14/5/20 16:28, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > >> > >> Hi Chun-Kuang, > >> > >&g

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > > Hi Chun-Kuang, > > Missatge de Enric Balletbo i Serra del > dia dv., 1 de maig 2020 a les 17:25: > > > > Use the drm_bridge_connector helper to create a connector for pipelines > > that use drm_bridge. This allows splitting connector

Re: [PATCH] drm/mediatek: eliminate the magic number in array size

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:43寫道: > > Eiminate the magic number in array size, there macro defines in > hdmi.h. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang >

Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:34寫道: > > This code change is to make code bit more readable. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang > Signed-off-by: Bern

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-09 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > deprecated. We started to move all the Mediatek drivers to the drm_bridge API, > like we did for the mtk-dsi driver [1], this is another small step to be able

Re: [PATCH] drm/mediatek: eliminate the magic number in array size

2020-05-06 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:43寫道: > > Eiminate the magic number in array size, there macro defines in > hdmi.h. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- > 1 file changed, 3 in

Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit

2020-05-06 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:34寫道: > > This code change is to make code bit more readable. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 > 1 file changed, 4 insertions(+), 8

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-05-05 Thread Chun-Kuang Hu
Hi, YueHaibing: Chun-Kuang Hu 於 2020年4月29日 週三 下午10:15寫道: > > Hi, YueHaibing: > > YueHaibing 於 2020年4月29日 週三 下午3:14寫道: > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) &

Re: [PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk_dpi driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > Convert mtk_dpi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-05 Thread Chun-Kuang Hu
l be > named next_bridge. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/d

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月1日 週五 下午10:59寫道: > > Hi Chun-Kuang, > > Thank you for your review. > > On 1/5/20 16:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年4月17日 週五 > > 下午11:06寫道: > >> &

<    1   2   3   4   5   >