RE: warning: objtool: fn1 uses BP as a scratch register

2019-07-22 Thread Topper, Craig
The framepointer thing may have been fixed by this https://reviews.llvm.org/D64294 -Original Message- From: Arnd Bergmann Sent: Friday, July 19, 2019 12:44 PM To: Nick Desaulniers Cc: Josh Poimboeuf ; clang-built-linux ; Linux Kernel Mailing List ; Peter Zijlstra ; Topper, Craig

Re: [PATCH bpf v2] bpf, lpm: fix lookup bug in map_delete_elem

2019-02-22 Thread Craig Gallek
udo ./tools/testing/selftests/bpf/test_lpm_map > test_lpm_map: test_lpm_map.c:485: test_lpm_delete: Assertion > `bpf_map_delete_elem(map_fd, key) == -1 && errno == ENOENT' failed. > Aborted > > With the patch: test_lpm_map runs without errors. > > Fixes: e454

[PATCH] pinctrl: sdm660: Set tile property for pingroups

2018-11-12 Thread Craig Tatlor
This was missed when tiles support was added in a revison and causes the driver to fail to load. Fixes: 9cf0c526bc58 ("pinctrl: qcom: Add sdm660 pinctrl driver") Signed-off-by: Craig Tatlor --- drivers/pinctrl/qcom/pinctrl-sdm660.c | 28 ++- 1 file changed, 15

Re: [PATCH V2] arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

2018-11-12 Thread Craig Tatlor
On Mon, Nov 12, 2018 at 04:34:50PM +0100, Heiko Stuebner wrote: > Hi Craig, > > Am Sonntag, 12. August 2018, 16:23:12 CET schrieb Craig Tatlor: > > Initial device tree support for Qualcomm SDM630 SoC and > > Sony Pioneer (Xperia XA2). > > > > SDM630 is based off

Re: Insanely high baud rates

2018-10-11 Thread Craig Milo Rogers
dth limitation layer? You say, I need to justify it? It's for, uh... protecting the system from unrestricted pty usage DOS attacks! Yeah. That's what it's for. Craig Milo Rogers

[PATCH] staging: vboxvideo: make a couple of funcs static

2018-10-10 Thread Craig Kewley
atic? Signed-off-by: Craig Kewley --- drivers/staging/vboxvideo/vbox_mode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c index 042e4f384df9..deed28c7a1db 100644 --- a/drivers/staging/vboxvid

Re: [PATCH V3 0/4] Changes for SDCC5 version

2018-10-08 Thread Craig
On 9 October 2018 07:01:57 BST, Veerabhadrarao Badiganti wrote: >Hi > > >On 10/8/2018 12:26 PM, Bjorn Andersson wrote: >> On Sun 07 Oct 01:07 PDT 2018, Craig wrote: >> >>> Any updates on this? >>> >> FWIW I used qcom,sdhci-msm-v5 on QCS404 s

Re: [PATCH v3] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-10-07 Thread Craig
(Resend due to broken email client) any reviews for this? On 25 September 2018 18:35:58 BST, Craig Tatlor wrote: >From: Taniya Das > >Add support for the global clock controller found on SDM660 >based devices. This should allow most non-multimedia device >drivers to probe an

Re: [PATCH V3 0/4] Changes for SDCC5 version

2018-10-07 Thread Craig
Any updates on this? On 25 September 2018 16:39:33 BST, Craig wrote: > > >On 25 September 2018 12:17:26 BST, Veerabhadrarao Badiganti > wrote: >> >>On 9/25/2018 1:18 AM, Craig Tatlor wrote: >>> What socs have you tested this on? >>> On sdm660 it seem

Re: [PATCH v3 1/2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-09-26 Thread Craig
Hey, You seem to have missed the bindings, it might be an idea to drop and reapply with the new ones I just sent off when they get a review. On 26 September 2018 07:57:41 BST, Linus Walleij wrote: >On Tue, Sep 25, 2018 at 7:38 PM Craig Tatlor >wrote: > >> From: Neeraj Upad

[PATCH v4 1/2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-09-26 Thread Craig Tatlor
From: Neeraj Upadhyay Add initial pinctrl driver to support pin configuration with pinctrl framework for sdm660. Based off CAF implementation. Signed-off-by: Neeraj Upadhyay Co-Developed-by: Venkatesh Yadav Abbarapu Signed-off-by: Venkatesh Yadav Abbarapu [craig: minor updates for

[PATCH v4 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding

2018-09-26 Thread Craig Tatlor
Add the binding for the TLMM pinctrl block found in the SDM660 platform. Signed-off-by: Craig Tatlor --- Changes from v3: Updated for tile structure change irq field .../bindings/pinctrl/qcom,sdm660-pinctrl.txt | 181 ++ 1 file changed, 181 insertions(+) create mode

[PATCH v3 1/2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-09-25 Thread Craig Tatlor
From: Neeraj Upadhyay Add initial pinctrl driver to support pin configuration with pinctrl framework for sdm660. Based off CAF implementation. Signed-off-by: Neeraj Upadhyay Co-Developed-by: Venkatesh Yadav Abbarapu Signed-off-by: Venkatesh Yadav Abbarapu [craig: minor updates for

[PATCH v3 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding

2018-09-25 Thread Craig Tatlor
Add the binding for the TLMM pinctrl block found in the SDM660 platform. Signed-off-by: Craig Tatlor --- .../bindings/pinctrl/qcom,sdm660-pinctrl.txt | 181 ++ 1 file changed, 181 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm660

[PATCH v3] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-09-25 Thread Craig Tatlor
From: Taniya Das Add support for the global clock controller found on SDM660 based devices. This should allow most non-multimedia device drivers to probe and control their clocks. Based on CAF implementation. Signed-off-by: Taniya Das [craig: rename parents to fit upstream, and other cleanups

[PATCH v2] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-09-25 Thread Craig Tatlor
From: Taniya Das Add support for the global clock controller found on SDM660 based devices. This should allow most non-multimedia device drivers to probe and control their clocks. Based on CAF implementation. Signed-off-by: Taniya Das [craig: rename parents to fit upstream, and other cleanups

Re: [PATCH V3 0/4] Changes for SDCC5 version

2018-09-25 Thread Craig
On 25 September 2018 12:17:26 BST, Veerabhadrarao Badiganti wrote: > >On 9/25/2018 1:18 AM, Craig Tatlor wrote: >> What socs have you tested this on? >> On sdm660 it seems to crash device >> when writing pwr ctl. > >Hi >We have tested this on SDM845. >SDM6

Re: [PATCH] arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

2018-09-24 Thread Craig
On 24 September 2018 20:19:29 BST, Bjorn Andersson wrote: >On Sat 11 Aug 09:25 PDT 2018, Craig Tatlor wrote: > >> Initial device tree support for Qualcomm SDM630 SoC and >> Sony Pioneer (Xperia XA2). >> >> SDM630 is based off of the SDM660 soc and al

Re: [PATCH v2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-09-24 Thread Craig
On 24 September 2018 19:53:06 BST, Bjorn Andersson wrote: >On Sun 12 Aug 07:24 PDT 2018, Craig Tatlor wrote: > >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for sdm660. >> Based off CAF implementation. >>

Re: [PATCH V3 0/4] Changes for SDCC5 version

2018-09-24 Thread Craig Tatlor
What socs have you tested this on? On sdm660 it seems to crash device when writing pwr ctl. On Tue, Jun 19, 2018 at 11:09:17AM +0530, Vijay Viswanath wrote: > With SDCC5, the MCI register space got removed and the offset/order of > several registers have changed. Based on SDCC version used and th

Re: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-09-24 Thread Craig
On 24 September 2018 13:44:33 BST, Heiko Stuebner wrote: >Hi Craig, > >Am Montag, 13. August 2018, 09:45:09 CEST schrieb Craig Tatlor: >> On 13 August 2018 07:55:34 BST, Taniya Das >wrote: >> >Hello Craig, >> > >> >Could you please correct t

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
On 20 September 2018 17:58:47 BST, Sebastian Reichel wrote: >[Dropped a couple of people from CC, added Baolin] > >Hi Craig, Baolin and Rob, > >On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: >> On 16 September 2018 13:10:45 BST, Sebastian Reichel > wrote: >

Re: [PATCH v7 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-09-20 Thread Craig
Replies inline On 16 September 2018 14:48:36 BST, Sebastian Reichel wrote: >Hi, > >First of all thanks for the patch and big sorry for the long delay >in reviewing this. I did not find enough time to do it properly >until now :( > >On Thu, Jun 14, 2018 at 04:14:15PM +010

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
txt Thanks for the review, what bindings for ocv would you prefer? The spreadtrum ones or mine? >and referenced via monitored-battery. > >-- Sebastian > >On Thu, Jun 14, 2018 at 04:14:16PM +0100, Craig Tatlor wrote: >> Add bindings for the Qualcomm Battery Monitoring system

Re: [PATCH V12 00/14] Krait clocks + Krait CPUfreq

2018-09-20 Thread Craig
On 20 September 2018 14:01:57 BST, Sricharan R wrote: > > >On 9/20/2018 1:54 AM, Craig wrote: >> Yup, this patch seems to have fixed the higher frequencies from the >quick test I did. >> > Thanks !!. Can i take that as Craig Tatlor ? Sure, no problem > >Rega

Re: [PATCH V12 00/14] Krait clocks + Krait CPUfreq

2018-09-19 Thread Craig
Yup, this patch seems to have fixed the higher frequencies from the quick test I did. On 7 September 2018 15:28:53 BST, Craig Tatlor wrote: > > >On 7 September 2018 10:57:34 BST, Sricharan R > wrote: >>Hi Craig, >> >> >>>> [v12] >>>>

Re: [PATCH V12 00/14] Krait clocks + Krait CPUfreq

2018-09-07 Thread Craig Tatlor
On 7 September 2018 10:57:34 BST, Sricharan R wrote: >Hi Craig, > > >>> [v12] >>> * Added my signed-off that was missing in some patches. >>> * Added Bjorn's acked that i missed earlier. >>> >> >> Can you give this a try o

Re: [RFC PATCH v2] irqchip/gic-v3: Add quirk for msm8996 secured registers

2018-09-04 Thread Craig Tatlor
On 4 September 2018 15:05:38 BST, Srinivas Kandagatla wrote: >Access to GICR_WAKER is restricted on msm8996 SoC in Hypervisor. >Its been more than 2 years of wait for this to be fixed, which has >no hopes to be fixed. This change was introduced for the "lead device" >on msm8996 platform. It lo

Re: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-08-13 Thread Craig Tatlor
On 13 August 2018 07:55:34 BST, Taniya Das wrote: >Hello Craig, > >Could you please correct the authorship and also provide the reference >to code where this is picked from? > Also, don't you have a program that just spits out the clock setup? And I did leave copyright in

Re: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-08-13 Thread Craig Tatlor
On 13 August 2018 07:55:34 BST, Taniya Das wrote: >Hello Craig, > >Could you please correct the authorship and also provide the reference >to code where this is picked from? Okay, Got code from here https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/drivers/clk/qcom/

Re: [PATCH v2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-13 Thread Craig Tatlor
On 13 August 2018 08:24:43 BST, "Michal Vokáč" wrote: >Hi Craig, >On 12.8.2018 16:24, Craig Tatlor wrote: >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for sdm660. >> Based off CAF implementation. >> >&

Re: [PATCH v2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-13 Thread Craig Tatlor
On 13 August 2018 08:24:43 BST, "Michal Vokáč" wrote: >Hi Craig, >On 12.8.2018 16:24, Craig Tatlor wrote: >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for sdm660. >> Based off CAF implementation. >> >&

[PATCH v2] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-12 Thread Craig Tatlor
Add initial pinctrl driver to support pin configuration with pinctrl framework for sdm660. Based off CAF implementation. Signed-off-by: Craig Tatlor --- Changes from v1: Adds gpio-ranges property to bindings .../bindings/pinctrl/qcom,sdm660-pinctrl.txt | 202 +++ drivers/pinctrl/qcom

[PATCH V2] arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

2018-08-12 Thread Craig Tatlor
kernel tree. The device can be booted into the initrd with a shell over UART. Signed-off-by: Craig Tatlor --- Changes from v1: Adds gpio-ranges node to allow gpio-hogs to function arch/arm64/boot/dts/qcom/Makefile| 1 + arch/arm64/boot/dts/qcom/sdm630-pins.dtsi| 17 + arch

Re: [PATCH] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-12 Thread Craig Tatlor
On 12 August 2018 13:42:27 BST, Christian Lamparter wrote: >On Sunday, August 12, 2018 9:18:19 AM CEST you wrote: >> On 11 August 2018 18:27:43 BST, Christian Lamparter > wrote: >> >On Saturday, August 11, 2018 6:25:19 PM CEST Craig Tatlor wrote: >> >> Add init

Re: [PATCH] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-12 Thread Craig Tatlor
On 11 August 2018 18:27:43 BST, Christian Lamparter wrote: >On Saturday, August 11, 2018 6:25:19 PM CEST Craig Tatlor wrote: >> Add initial pinctrl driver to support pin configuration with >> pinctrl framework for sdm660. >> Based off CAF implementation. >> >

[PATCH] arm64: dts: sdm630 SoC and Sony Pioneer (Xperia XA2) support

2018-08-11 Thread Craig Tatlor
kernel tree. The device can be booted into the initrd with a shell over UART. Signed-off-by: Craig Tatlor --- arch/arm64/boot/dts/qcom/Makefile| 1 + arch/arm64/boot/dts/qcom/sdm630-pins.dtsi| 17 + arch/arm64/boot/dts/qcom/sdm630-pioneer.dts | 16 + arch/arm64/boot/dts/qcom

[PATCH] pinctrl: qcom: Add sdm660 pinctrl driver

2018-08-11 Thread Craig Tatlor
Add initial pinctrl driver to support pin configuration with pinctrl framework for sdm660. Based off CAF implementation. Signed-off-by: Craig Tatlor --- .../bindings/pinctrl/qcom,sdm660-pinctrl.txt | 195 +++ drivers/pinctrl/qcom/Kconfig | 10 + drivers/pinctrl/qcom

[PATCH] firmware: qcom: scm: Add sdm660 soc compatible

2018-08-11 Thread Craig Tatlor
Add the compatible for SDM660. This does not need clocks to do scm calls Signed-off-by: Craig Tatlor --- Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + drivers/firmware/qcom_scm.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation

[PATCH] soc: qcom: smd-rpm: Add sdm660 compatible

2018-08-11 Thread Craig Tatlor
Add the compatible for the RPM in SDM660, so that rpm resources can be made available. Signed-off-by: Craig Tatlor --- Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 + drivers/soc/qcom/smd-rpm.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660

2018-08-10 Thread Craig Tatlor
Add support for the global clock controller found on SDM660 based devices. This should allow most non-multimedia device drivers to probe and control their clocks. Based on CAF implementation. Signed-off-by: Craig Tatlor --- .../devicetree/bindings/clock/qcom,gcc.txt|1 + drivers/clk

Re: [PATCH v10 13/14] cpufreq: Add module to register cpufreq on Krait CPUs

2018-06-19 Thread Craig Tatlor
The pvs refuse check is incorrect... With downstream it says it isn't blown and that it is 11, which also happens on upstream if I import it's efuse reading code from an older revision, or comment out the check. Also, I'm still getting my issue about clocks above 2,147,483,647hz however I think th

[PATCH v7 4/4] MAINTAINERS: Add entry for the Qualcomm BMS

2018-06-14 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c125f705f78..be485caf9313 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11646,6 +11646,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-14 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor Reviewed-by: Rob Herring --- * Changes from v6: s/celcius/celsius change uah to uAh. * Changes from v5

[PATCH v7 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-06-14 Thread Craig Tatlor
-by: Craig Tatlor Reviewed-by: Linus Walleij --- * Changes from v5: Uses select for REGMAP_SPMI

[PATCH v7 1/4] fixp-arith: add a linear interpolation function

2018-06-14 Thread Craig Tatlor
Adds a function to interpolate against two points, this is carried arount as a helper function by tons of drivers. Signed-off-by: Craig Tatlor Reviewed-by: Linus Walleij --- include/linux/fixp-arith.h | 20 1 file changed, 20 insertions(+) diff --git a/include/linux/fixp

[PATCH v6 4/4] MAINTAINERS: Add entry for the Qualcomm BMS

2018-06-13 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c125f705f78..be485caf9313 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11646,6 +11646,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH v6 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-13 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor --- * Changes from v5: Mentions which values are 8 bit. * Changes from v4: Uses proper units and expands some definitions, along with changing vadc@ to adc@. .../bindings/power/supply/qcom_bms.txt

[PATCH v6 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-06-13 Thread Craig Tatlor
-by: Craig Tatlor --- * Changes from v5: Uses select for REGMAP_SPMI. * Changes from v4: Cleaned up percentage interpolation function, uses new fixp interpolation helper, added some more error cases, uses devm_power_supply_register(), uses a DIV_ROUND_CLOSEST for division and uses

[PATCH v6 1/4] fixp-arith: add a linear interpolation function

2018-06-13 Thread Craig Tatlor
Adds a function to interpolate against two points, this is carried arount as a helper function by tons of drivers. Signed-off-by: Craig Tatlor --- include/linux/fixp-arith.h | 20 1 file changed, 20 insertions(+) diff --git a/include/linux/fixp-arith.h b/include/linux/fixp

Re: [PATCH v5 1/4] fixp-arith: add a linear interpolation function

2018-06-13 Thread Craig Tatlor
On Wed, Jun 13, 2018 at 01:12:45PM +0200, Linus Walleij wrote: > On Wed, Jun 13, 2018 at 1:06 PM, Linus Walleij > wrote: > > On Thu, Jun 7, 2018 at 8:12 PM, Craig Tatlor wrote: > > > >> Adds a function to interpolate against two points, > >> this is carried

Re: [PATCH v5 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-13 Thread Craig Tatlor
On Mon, Jun 11, 2018 at 12:15:15PM -0600, Rob Herring wrote: > On Thu, Jun 07, 2018 at 07:12:51PM +0100, Craig Tatlor wrote: > > Add bindings for the Qualcomm Battery Monitoring system. > > > > Signed-off-by: Craig Tatlor > > --- > > * Changes from v4: > &g

Re: [PATCH v5 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-06-13 Thread Craig Tatlor
On Thu, Jun 07, 2018 at 12:08:20PM -0700, Randy Dunlap wrote: > On 06/07/2018 11:12 AM, Craig Tatlor wrote: > > This patch adds a driver for the BMS (Battery Monitoring System) > > block of the PM8941 PMIC, it uses a lookup table defined in the > > device tree to generate a

[PATCH v5 4/4] MAINTAINERS: Add entry for the Qualcomm BMS

2018-06-07 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c125f705f78..be485caf9313 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11646,6 +11646,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH v5 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-07 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor --- * Changes from v4: Uses proper units and expands some definitions, along with changing vadc@ to adc@. .../bindings/power/supply/qcom_bms.txt| 91 +++ 1 file changed, 91

[PATCH v5 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-06-07 Thread Craig Tatlor
-by: Craig Tatlor --- * Changes from v4: Cleaned up percentage interpolation function, uses new fixp interpolation helper, added some more error cases, uses devm_power_supply_register(), uses a DIV_ROUND_CLOSEST for division and uses micro(volts / amp hours) instead of milli (volts

[PATCH v5 1/4] fixp-arith: add a linear interpolation function

2018-06-07 Thread Craig Tatlor
Adds a function to interpolate against two points, this is carried arount as a helper function by tons of drivers. Signed-off-by: Craig Tatlor --- include/linux/fixp-arith.h | 20 1 file changed, 20 insertions(+) diff --git a/include/linux/fixp-arith.h b/include/linux/fixp

Re: [PATCH v2 0/2] slimbus: Add QCOM SLIMBus NGD driver

2018-05-31 Thread Craig Tatlor
Tested on msm8974 with wcd9320 codec. Tested-by: Craig Tatlor On Fri, May 25, 2018 at 12:15:45PM +0100, Srinivas Kandagatla wrote: > This patchset adds support to basic version of Qualcomm NGD SLIMBus > controller driver found SoCs from B family. > > This controller is light-we

Re: [PATCH v4 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-30 Thread Craig Tatlor
Thanks for review, replies inline. On Thu, Apr 26, 2018 at 01:34:00PM +0200, Linus Walleij wrote: > On Sat, Apr 7, 2018 at 7:57 PM, Craig Tatlor wrote: > > Hi Craig! Thanks for your patch! > > > This patch adds a driver for the BMS (Battery Monitoring System) > > bloc

Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-15 Thread Craig Tatlor
On Fri, Apr 13, 2018 at 11:35:27AM -0500, Rob Herring wrote: > On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: > > Add bindings for the Qualcomm Battery Monitoring system. > > > > Signed-off-by: Craig Tatlor > > --- > > .../bindings/powe

Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-13 Thread Craig Tatlor
On 13 April 2018 18:08:54 BST, Craig Tatlor wrote: > > >On 13 April 2018 17:35:27 BST, Rob Herring wrote: >>On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: >>> Add bindings for the Qualcomm Battery Monitoring system. >>> >>> Signed-off-b

Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-13 Thread Craig Tatlor
On 13 April 2018 17:35:27 BST, Rob Herring wrote: >On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: >> Add bindings for the Qualcomm Battery Monitoring system. >> >> Signed-off-by: Craig Tatlor >> --- >> .../bindings/powe

[PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-07 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor --- .../bindings/power/supply/qcom_bms.txt| 93 +++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt diff --git a

[PATCH v4 3/3] MAINTAINERS: Add entry for the Qualcomm BMS

2018-04-07 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0c3ad62c638c..aaf54b665f86 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11605,6 +11605,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH v4 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-07 Thread Craig Tatlor
-by: Craig Tatlor --- drivers/power/supply/Kconfig| 9 + drivers/power/supply/Makefile | 1 + drivers/power/supply/qcom_bms.c | 500 3 files changed, 510 insertions(+) create mode 100644 drivers/power/supply/qcom_bms.c diff --git a/drivers/power/supply

Re: [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-07 Thread Craig Tatlor
On Sat, Apr 07, 2018 at 09:37:21AM -0700, Randy Dunlap wrote: > On 04/07/2018 06:59 AM, Craig Tatlor wrote: > > This patch adds a driver for the BMS (Battery Monitoring System) > > block of the PM8941 PMIC, it uses a lookup table defined in the > > device tree to generate a

[PATCH v3 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-07 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor --- .../bindings/power/supply/qcom_bms.txt| 93 +++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt diff --git a

[PATCH v3 3/3] MAINTAINERS: Add entry for the Qualcomm BMS

2018-04-07 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0c3ad62c638c..aaf54b665f86 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11605,6 +11605,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-07 Thread Craig Tatlor
-by: Craig Tatlor --- drivers/power/supply/Kconfig| 9 + drivers/power/supply/Makefile | 1 + drivers/power/supply/qcom_bms.c | 500 3 files changed, 510 insertions(+) create mode 100644 drivers/power/supply/qcom_bms.c diff --git a/drivers/power/supply

[PATCH v2 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-07 Thread Craig Tatlor
-by: Craig Tatlor --- drivers/power/supply/Kconfig| 9 + drivers/power/supply/Makefile | 1 + drivers/power/supply/qcom_bms.c | 500 3 files changed, 510 insertions(+) create mode 100644 drivers/power/supply/qcom_bms.c diff --git a/drivers/power/supply

[PATCH 3/3] MAINTAINERS: Add entry for the Qualcomm BMS

2018-04-07 Thread Craig Tatlor
Signed-off-by: Craig Tatlor --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0c3ad62c638c..b7ffa9268384 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11605,6 +11605,12 @@ W: http://wireless.kernel.org/en/users/Drivers/ath9k S

[PATCH 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-04-07 Thread Craig Tatlor
-by: Craig Tatlor --- drivers/power/supply/Kconfig| 9 + drivers/power/supply/Makefile | 1 + drivers/power/supply/qcom_bms.c | 500 3 files changed, 510 insertions(+) create mode 100644 drivers/power/supply/qcom_bms.c diff --git a/drivers/power/supply

[PATCH 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-07 Thread Craig Tatlor
Add bindings for the Qualcomm battery measurement system. Signed-off-by: Craig Tatlor --- .../bindings/power/supply/qcom_bms.txt| 93 +++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt diff --git a

[PATCH] ARM: dts: qcom: pm8941: Add vadc nodes needed to estimate an ocv

2018-03-30 Thread Craig Tatlor
vbat_sns is needed to estimate a fairly accurate on chip voltage and bat_therm is needed to produce an accurate percentage from the estimated ocv. Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-pm8941.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/qcom

Re: [v9,04/15] clk: qcom: Add HFPLL driver

2018-03-25 Thread Craig Tatlor
This doesn't seem to work correctly with the higher clocks on 8974pro, specifically 215040 hz or above, maybe its something to do with being bigger than an unsigned long. When i try to set any higher frequency it jumps down to 300mhz.

[PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

2018-03-13 Thread Craig Tatlor
The compatible string was mistakenly pulled from the downstream tree and the startup delay property is needed to prevent io errors on initial page select. Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string

2018-03-12 Thread Craig Tatlor
This was mistakenly pulled from the downstream tree. Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974

[PATCH] arm/dts: Correct typo in touchscreen compatible string

2018-03-12 Thread Craig Tatlor
This was mistakenly pulled from the downstream driver Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974

[PATCH] drm/msm: Call msm_init_vram before binding the gpu

2018-02-03 Thread Craig Tatlor
vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor --- drivers/gpu/drm/msm/msm_drv.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c

Re: [PATCH 1/3] mmc: sdhci-pci-o2micro: Add hardware tuning for eMMC

2018-01-10 Thread Craig Bergstrom
Gotcha. Thank you for the detailed explanation. I will give that a try and see if it fixes the problem. Cheers, Craig On Wed, Jan 10, 2018 at 3:05 PM, Shirley Her (SC) wrote: > Hi, Craig: > > The upstream user is using SD card not eMMC for this device in the current > market. B

Re: [PATCH 1/3] mmc: sdhci-pci-o2micro: Add hardware tuning for eMMC

2018-01-10 Thread Craig Bergstrom
Hey Shirley, If all upstream users of this device need to set bit 4 of 0x308 to 1, should the upstream driver do that? Craig On Wed, Jan 10, 2018 at 12:05 PM, Shirley Her (SC) wrote: > Hi, Craig: > > As the message said during sign off as below. BIOS needs to set x0308 bit 4 >

Re: [PATCH 1/3] mmc: sdhci-pci-o2micro: Add hardware tuning for eMMC

2017-12-21 Thread Craig Bergstrom
Thanks for sending these patches out, I would be very excited to see these devices supported by Linux. I'm trying them out with a SEABIRD device (pci device 1217:8620). When I boot up and load the driver, it don't see any indication of the existence of block device and I see these messages repeate

Re: [PATCH 3.18 08/20] tun/tap: sanitize TUNSETSNDBUF input

2017-11-16 Thread Craig Gallek
On Thu, Nov 16, 2017 at 12:28 PM, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Craig Gallek > > > [ Upstream commit 93161922c658c714715686cd0cf69b090cb9bf1d ] > > Syzkaller

[tip:x86/urgent] x86/mm: Limit mmap() of /dev/mem to valid physical addresses

2017-11-16 Thread tip-bot for Craig Bergstrom
Commit-ID: be62a32044061cb4a3b70a10598e093f1319102e Gitweb: https://git.kernel.org/tip/be62a32044061cb4a3b70a10598e093f1319102e Author: Craig Bergstrom AuthorDate: Wed, 15 Nov 2017 15:29:51 -0700 Committer: Ingo Molnar CommitDate: Thu, 16 Nov 2017 12:49:48 +0100 x86/mm: Limit mmap

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-11-03 Thread Craig Bergstrom
f reboot the whole kernel. This is based on Linus' comment "I think we might also look at just also handling the whole RSVD page fault case more gracefully". Standby while I test these changes. Cheers, Craig On Fri, Oct 27, 2017 at 1:28 PM, Craig Bergstrom wrote: > Sounds good.

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-27 Thread Craig Bergstrom
Sounds good. Thanks for the context. I'll keep this on my plate and I'll turn something around once I've had a chance to test a bit, probably next week. On Fri, Oct 27, 2017 at 1:24 PM, Ingo Molnar wrote: > > * Craig Bergstrom wrote: > >> Reverting seems like th

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Craig Bergstrom
Reverting seems like the right approach at the moment. My apologies for the breakage so late the in the cycle. Post-revert, there remains a bug here wherein you can make the system OOPS if you mmap memory above the 48 bit bus width. Linus/Ingo, is there something in particular that you'd like to

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Craig Bergstrom
t's high memory address is at 2048M and your device is at 0xfe1fe000 (~4G), the new mmap() limits are preventing you from mapping addresses that are explicitly disallowed by the parameter. On Thu, Oct 26, 2017 at 10:39 AM, Ingo Molnar wrote: > > * Craig Bergstrom wrote: > >&g

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Craig Bergstrom
nge(addr, count); + if ((addr + count) & + ~(1ul << (unsigned long)boot_cpu_data.x86_phys_bits)) + return 0; + + return 1; } On Thu, Oct 26, 2017 at 2:58 AM, Sander Eikelenboom wrote: > On 26/10/17 10:12, Sander Eikelenboom wrote: >> On 26/10/17 10:05, Sander Eikelenboom wrote: >&

[tip:x86/mm] x86/mm: Limit mmap() of /dev/mem to valid physical addresses

2017-10-20 Thread tip-bot for Craig Bergstrom
Commit-ID: ce56a86e2ade45d052b3228cdfebe913a1ae7381 Gitweb: https://git.kernel.org/tip/ce56a86e2ade45d052b3228cdfebe913a1ae7381 Author: Craig Bergstrom AuthorDate: Thu, 19 Oct 2017 13:28:56 -0600 Committer: Ingo Molnar CommitDate: Fri, 20 Oct 2017 09:48:00 +0200 x86/mm: Limit mmap

[PATCH] X86/mm limit mmap of /dev/mem to valid addrs.

2017-10-19 Thread Craig Bergstrom
fault handler will be called with error_code set to RSVD. The kernel then crashes with a page table corruption error. This change prevents this page table corruption on x86 by refusing to mmap offsets higher than the highest valid address in the system. Signed-off-by: Craig Bergstrom --- arch

[PATCH] arm64: dts: qcom: msm8916: Shrink mdp address length for msm8916

2017-10-06 Thread Craig Tatlor
This shrinks the address size down to 89000 from its previous 9 which was mistakenly pulled from downstream. Signed-off-by: Craig Tatlor --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b

Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

2017-07-17 Thread Craig Inches
On Mon, Jul 17, 2017 at 05:44:59PM +, Dilger, Andreas wrote: > On Jul 12, 2017, at 03:03, Craig Inches wrote: > > > > This fixes a block statement which didnt end with */ > > > > Signed-off-by: Craig Inches > > --- > > drivers/staging/lustre/include/

[PATCH v2 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

2017-07-12 Thread Craig Inches
This fixes multiple block statements found not to match style as per checkpatch Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 + 1 file changed, 81 insertions(+), 48 deletions(-) diff --git a/drivers/staging/lustre/include/linux

[PATCH v2 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h

2017-07-12 Thread Craig Inches
This patch fixes some multiline comment blocks which didnt conform to the style guide, found by checkpatch. Signed-off-by: Craig Inches --- .../staging/lustre/include/linux/lnet/lib-types.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v2 4/4] Staging: Lustre Fix block statement style issue

2017-07-12 Thread Craig Inches
This fixes a block statement which didnt end with */ Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include

[PATCH v2 1/4] Staging: Lustre Clean up line over 80Char in lib-lnet.h

2017-07-12 Thread Craig Inches
This patch fixes a warning generated by checkpatch for a line over 80 characters. Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b

[PATCH v2 0/4] Staging: Lustre Style Fixes

2017-07-12 Thread Craig Inches
This series fixes a few style issues in lustre. All where picked up by checkpatch. v2 Changes: - Fixed typo in patch subject s/luster/lustre/ Craig

[PATCH 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h

2017-07-06 Thread Craig Inches
This patch fixes some multiline comment blocks which didnt conform to the style guide, found by checkpatch. Signed-off-by: Craig Inches --- .../staging/lustre/include/linux/lnet/lib-types.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH 1/4] Staging: Luster: Clean up line over 80Char in lib-lnet.h

2017-07-06 Thread Craig Inches
This patch fixes a warning generated by checkpatch for a line over 80 characters. Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b

  1   2   3   >