[PATCH V2] workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

de by removing the conditional. This doesn't make any functional difference. Signed-off-by: Daeseok Youn --- V2: update patch description and comment of code kernel/workqueue.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workque

Re: [PATCH] fbdev: fix possible NULL pointer derefernce

Hello, 2014-04-16 21:38 GMT+09:00 Jean-Christophe PLAGNIOL-VILLARD : > > On Apr 16, 2014, at 5:40 PM, Daeseok Youn wrote: > >> >> The spec->modedb can be NULL by fb_create_modedb(). >> >> And also smatch says: >> drivers/video/fbdev/core/fbmon.c:975 fb_e

Re: [PATCH 2/2] workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

Hi, Ok. I will update the comment in the code and patch description. Thanks for review. Regards, Daeseok Youn. 2014-04-17 2:38 GMT+09:00 Tejun Heo : > Hello, > > On Wed, Apr 16, 2014 at 02:33:27PM +0900, Daeseok Youn wrote: >> >> Replace blocks of code which checks whethe

[PATCH] uwb: adds missing error handling

There is checking NULL before dereferncing but it need to add "return". Signed-off-by: Daeseok Youn --- drivers/uwb/drp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/uwb/drp.c b/drivers/uwb/drp.c index 16ada83..1a2fd97 100644 --- a/drivers

[PATCH] fbdev: fix possible NULL pointer derefernce

The spec->modedb can be NULL by fb_create_modedb(). And also smatch says: drivers/video/fbdev/core/fbmon.c:975 fb_edid_to_monspecs() error: potential null dereference 'specs->modedb'. (fb_create_modedb returns null) Signed-off-by: Daeseok Youn --- drivers/video/fbdev/core/fbmon

[PATCH 2/2] workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

Replace blocks of code which checks whether pwq is defalut with jump to use_dfl_pwq. It is same as before. Signed-off-by: Daeseok Youn --- kernel/workqueue.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 3150b21

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

do so after alloc_unbound_pwq() failure. Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on alloc_unbound_pwq() failure. Signed-off-by: Daeseok Youn --- kernel/workqueue.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

do so after alloc_unbound_pwq() failure. Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on alloc_unbound_pwq() failure. Signed-off-by: Daeseok Youn --- kernel/workqueue.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

do so after alloc_unbound_pwq() failure. Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on alloc_unbound_pwq() failure. Signed-off-by: Daeseok Youn --- kernel/workqueue.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c

Re: [PATCH V3] workqueue: fix double unlock bug

Hi, Tejun. 2014-04-15 23:43 GMT+09:00 Tejun Heo : > On Tue, Apr 15, 2014 at 08:17:43AM +0900, Daeseok Youn wrote: >> >> Use default pwq when alloc_unbound_pwq() is failed. >> >> And remove "if" condition for whether "pwq" is same as "wq->df

Re: [PATCH] [media] s2255drv: fix memory leak s2255_probe()

Hi, Sakari 2014-04-15 18:33 GMT+09:00 Sakari Ailus : > Hi Daeseok, > > On Tue, Apr 15, 2014 at 01:49:34PM +0900, Daeseok Youn wrote: >> >> smatch says: >> drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn: >> possible memory leak of '

Re: [PATCH] drm/nouveau/clk: fix possible NULL pointer dereference

2014-04-15 16:00 GMT+09:00 Ben Skeggs : > - Original Message - >> From: "Daeseok Youn" >> To: airl...@linux.ie >> Cc: bske...@redhat.com, dri-de...@lists.freedesktop.org, >> linux-kernel@vger.kernel.org >> Sent: Tuesday, 15 April, 2014 11:56:49

[PATCH] [media] s2255drv: fix memory leak s2255_probe()

smatch says: drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn: possible memory leak of 'dev' Signed-off-by: Daeseok Youn --- drivers/media/usb/s2255/s2255drv.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c

[PATCH] drm/nouveau/clk: fix possible NULL pointer dereference

It need to be checking NULL before dereferencing. Signed-off-by: Daeseok Youn --- drivers/gpu/drm/nouveau/core/subdev/clock/base.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/clock/base.c b/drivers/gpu/drm/nouveau/core/subdev

[PATCH V3] workqueue: fix double unlock bug

Use default pwq when alloc_unbound_pwq() is failed. And remove "if" condition for whether "pwq" is same as "wq->dfl_pwq" when wq_calc_node_cpumask() returns false and just use "goto use_dfl_pwq" Signed-off-by: Daeseok Youn --- V2: replace "if

[PATCH V2] workqueue: fix double unlock bug

mutex_unlock() and put_pwq_unlocked() do not need to be called when alloc_unbound_pwq() is failed. And remove "if" condition for whether "pwq" is same as "wq->dfl_pwq" when wq_calc_node_cpumask() returns false and just use "goto use_dfl_pwq" Signe

Re: [PATCH] workqueue: fix double unlock bug

2014-04-14 15:50 GMT+09:00 Lai Jiangshan : > On 04/14/2014 08:58 AM, Daeseok Youn wrote: >> >> mutex_unlock() and put_pwq_unlocked() do not need to be called >> when alloc_unbound_pwq() is failed. >> >> Signed-off-by: Daeseok Youn >> --- >> kernel

[PATCH] btrfs: remove redundant null check in btrfs_dentry_release()

It doesn't need to check NULL for kfree() Signed-off-by: Daeseok Youn --- fs/btrfs/inode.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 06e9a41..d9f54b0 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5

[PATCH] befs: replace goto with while

The goto in befs_readdir() can be replaced with while. And also fix smatch warnings: fs/befs/linuxvfs.c:283 befs_readdir() info: ignoring unreachable code. fs/befs/linuxvfs.c:283 befs_readdir() info: ignoring unreachable code. Signed-off-by: Daeseok Youn --- fs/befs/linuxvfs.c | 86

Re: [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls

Hi, Can you review this patch? Thanks. Daeseok Youn 2014-04-02 16:56 GMT+09:00 Daeseok Youn : > > If local is NULL, nfs_put_device() is called twice. > So nfs_put_device() in "if (!local)" is removed. > > Signed-off-by: Daeseok Youn > --- > net/nfc/netlink.c

Re: [PATCH 1/2] nfc: fix NULL pointer dereference

Hi, Can you review this patch? Thanks. Daeseok Youn 2014-04-02 16:55 GMT+09:00 Daeseok Youn : > > dev is NULL when nfc_get_device() is failed but > dev is used for handling error. > > coccicheck says: > net/nfc/netlink.c:1092:21-24: ERROR: > dev is NULL but dereferenc

[PATCH] workqueue: fix double unlock bug

mutex_unlock() and put_pwq_unlocked() do not need to be called when alloc_unbound_pwq() is failed. Signed-off-by: Daeseok Youn --- kernel/workqueue.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 0ee63af..e6e9f6a 100644

Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()

2014-04-09 20:39 GMT+09:00, Dan Carpenter : > On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote: >> >> A string of goto_buf has a number followed by x or y. >> e.g. "3x" means move 3 lines down. >> The kstrtol() returns an error(-EINVAL) with th

[PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()

/speakup/main.c:1901 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero. drivers/staging/speakup/main.c:1911 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero. Signed-off-by: Daes

Re: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

Hi, This patch didn't apply. Please check for me. Thanks. Daeseok Youn 2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal : > > > -Original Message- > From: Daeseok Youn [mailto:daeseok.y...@gmail.com] > Sent: Thursday, February 20, 2014 5:13 PM > To: jbottom...@parall

[PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c

The bp_proc_create() can be called if BP_PROC_SUPPORT is defined. Signed-off-by: Daeseok Youn --- drivers/staging/silicom/bpctl_mod.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index

[PATCH] [SCSI] FlashPoint: Fix non-ANSI function declaration

sparse says: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll' Signed-off-by: Daeseok Youn --- drivers/scsi/FlashPoint.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c index 5c74e4

[PATCH] staging: lustre: use NULL instead of 0 for pointer

Signed-off-by: Daeseok Youn --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/staging/lustre/lustre/obdclass/obd_mount.c index 6f8ba54

Re: [PATCH] staging: lirc: fix NULL pointer dereference

Please drop this patch. I made a patch as Dan's comment and sent it. Thanks. Daeseok Youn. 2014-04-02 18:41 GMT+09:00 DaeSeok Youn : > You are right. remove whole thing and send it again. > > Thanks. > Daeseok Youn > > 2014-04-02 18:13 GMT+09:00 Dan Carpenter : >>

[PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc()

"ir" is already checked before calling unregister_from_lirc(). Signed-off-by: Daeseok Youn --- drivers/staging/media/lirc/lirc_igorplugusb.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/

Re: [PATCH] staging: lirc: fix NULL pointer dereference

You are right. remove whole thing and send it again. Thanks. Daeseok Youn 2014-04-02 18:13 GMT+09:00 Dan Carpenter : > On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote: >> >> coccicheck says: >> drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: >

[PATCH] staging: lirc: fix NULL pointer dereference

coccicheck says: drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: ERROR: ir is NULL but dereferenced. Signed-off-by: Daeseok Youn --- drivers/staging/media/lirc/lirc_igorplugusb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/lirc

[PATCH 2/2] nfc: remove unneeded nfc_put_device() calls

If local is NULL, nfs_put_device() is called twice. So nfs_put_device() in "if (!local)" is removed. Signed-off-by: Daeseok Youn --- net/nfc/netlink.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index b2ad570..3e0a

[PATCH 1/2] nfc: fix NULL pointer dereference

dev is NULL when nfc_get_device() is failed but dev is used for handling error. coccicheck says: net/nfc/netlink.c:1092:21-24: ERROR: dev is NULL but dereferenced. Signed-off-by: Daeseok Youn --- net/nfc/netlink.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a

[PATCH] regmap: adds missing braces in regmap_init()

It need to add curly braces because the inner for "if" has two statements. coccicheck says: drivers/base/regmap/regmap.c:765:2-44: code aligned with following code on line 766 Signed-off-by: Daeseok Youn --- drivers/base/regmap/regmap.c |3 ++- 1 files changed, 2 insert

[PATCH v2] xen: fix memory leak in __xen_pcibk_add_pci_dev()

It need to free dev_entry when it failed to assign to a new slot on the virtual PCI bus. smatch says: drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn: possible memory leak of 'dev_entry' Signed-off-by: Daeseok Youn --- v2: The kfree() invocation is moved outside

Re: [Xen-devel] [PATCH] xen: fix memory leak in __xen_pcibk_add_pci_dev()

dd_pci_dev() warn: >> possible memory leak of 'dev_entry' >> >> Signed-off-by: Daeseok Youn > > Reviewed-by: Jan Beulich > > albeit the solution is not ideal: > >> --- a/drivers/xen/xen-pciback/vpci.c >> +++ b/drivers/xen/xen-pciback/vpci.c >

[PATCH] xen: fix memory leak in __xen_pcibk_add_pci_dev()

It need to free dev_entry when it failed to assign to a new slot on the virtual PCI bus. smatch says: drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn: possible memory leak of 'dev_entry' Signed-off-by: Daeseok Youn --- drivers/xen/xen-pciback/vpci.c |1

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-27 23:30 GMT+09:00 Aaron Sierra : > > - Original Message - >> From: "DaeSeok Youn" >> Sent: Wednesday, March 26, 2014 8:47:51 PM >> >> 2014-03-27 3:51 GMT+09:00 Aaron Sierra : >> > - Original Message - >> >> Fr

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-27 3:51 GMT+09:00 Aaron Sierra : > - Original Message - >> From: "Daeseok Youn" >> Sent: Tuesday, March 25, 2014 10:01:48 PM >> Subject: [PATCH] staging: vme: fix memory leak in vme_user_probe() >> >> >> If vme_master_request(

[PATCH] staging: vme: fix memory leak in vme_user_probe()

If vme_master_request() returns NULL when it failed, it need to free buffers for master. And also removes unreachable code in vme_user_probe(). Signed-off-by: Daeseok Youn --- drivers/staging/vme/devices/vme_user.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH v3] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

Replace OS_kmalloc/OS_kfree with kmalloc/kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn --- v3: replace kzalloc with kmalloc. v2: fix subject and comment correctly. I'm not

Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

2014-03-21 13:27 GMT+09:00 Greg KH : > On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote: >> >> Replace OS_kmalloc/OS_kfree with kmalloc/kfree. > > You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed > out the allocated data: I think some c

[PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

Replace OS_kmalloc/OS_kfree with kmalloc/kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn --- v2: fix subject and comment correctly. I'm not sure what GFP_DMA use correctly

Re: [PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

Yes. It was already noticed by Joe Perches. I will send it again. Thanks. Daeseok Youn. 2014-03-21 11:35 GMT+09:00, Greg KH : > On Fri, Mar 21, 2014 at 10:41:39AM +0900, Daeseok Youn wrote: >> >> Replace kmalloc/kfree with OS_kmalloc/OS_kfree. > > I think you mean this

[PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

Replace kmalloc/kfree with OS_kmalloc/OS_kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn --- I'm not sure what GFP_DMA use correctly for km{,z}alloc(). Please review this.

[PATCH v2] staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE

It doesn't need to trace status of buffer when buffers are allocated/deallocated. So stuff of tracing memory status are removed. And also UISMALLOC/UISFREE macro are removed completetly. just use kzalloc/kfree. Signed-off-by: Daeseok Youn --- v2: removed __GFP_NORETRY flag for kz

Re: [PATCH] staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE

OK. I will remove __GFP_NORETRY for kmalloc/kzalloc and sent this again. Thanks. Daeseok Youn 2014-03-20 0:28 GMT+09:00 Greg KH : > On Wed, Mar 19, 2014 at 04:58:52PM +0900, Daeseok Youn wrote: >> >> It doesn't need to trace status of buffer when buffers are >> allocate

[PATCH] staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE

It doesn't need to trace status of buffer when buffers are allocated/deallocated. So stuff of tracing memory status are removed. And also UISMALLOC/UISFREE macro are removed completetly. just use kzalloc/kfree. Signed-off-by: Daeseok Youn --- drivers/staging/unisys/include/uisutils.h |

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Thanks for reply. I will do that. Regards, Daeseok Youn. 2014-03-19 11:31 GMT+09:00 Greg KH : > On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: >> oh... >> You didn't get my reply about vmalloc usage. >> >> My replay attach again, below. >>

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

oh... You didn't get my reply about vmalloc usage. My replay attach again, below. > 2014-03-18 9:37 GMT+09:00 Greg KH : >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >&

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

ake a patch. Regards, Daeseok Youn. 2014-03-18 22:00 GMT+09:00 Ken Cox : > > On 03/17/2014 07:26 PM, DaeSeok Youn wrote: >> >> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >> vmalloc/kmalloc directly. >> (UISMALLOC() macro is also removed.) &

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Hi, greg. Review my comment below. Thanks. Daeseok Youn. 2014-03-18 17:11 GMT+09:00 DaeSeok Youn : > 2014-03-18 9:37 GMT+09:00 Greg KH : >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and ju

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 9:37 GMT+09:00 Greg KH : > On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >> vmalloc/kmalloc directly. > > Yes. Actually, just use kmalloc, I don't knwo why vmalloc is

[PATCH v2] staging: cxt1e1: remove unneeded mkret() calls

The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn --- v2: fix a typo in subject this patch is rebas

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

e ...) for info_proc_read_helper(). If this change is accepted, it also need to change uislib_free(). Is it fine to change like this? Thanks. Daeseok Youn. 2014-03-18 6:41 GMT+09:00 Greg KH : > On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote: >> >> Signed-off-by: Daeseok Youn &

Re: [PATCH 1/2] staging: cxtie1: remove unneeded mkret() calls

Ok. I will rebase this patch in staging-next branch and send it again. Thanks. Daeseok Youn. 2014-03-18 6:23 GMT+09:00 Greg KH : > On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote: >> >> The mkret() change a value of error from positive to >> negative. This

[PATCH] staging: cxt1e1: remove redundant memset() call

The banner array doens't need to set to 0. sprintf() adds a terminating '\0'. And the sn array can be declared and initialized to zero. So remove redundant memset() with zero. Remove unnecessary cast for memcpy(). Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/h

[PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Signed-off-by: Daeseok Youn --- drivers/staging/unisys/uislib/uislib.c |5 + drivers/staging/unisys/uislib/uisutils.c |2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c index

[PATCH] staging: unisys: remove incorrect error handling after queue_delayed_work

The queue_delayed_work() return false if the work is already on the queue, true otherwise. So return value cannot be less than zero. Signed-off-by: Daeseok Youn --- .../unisys/visorchipset/visorchipset_main.c| 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff

[PATCH] staging: dgnc: replace unnecessary while() with if()

speed() info: ignoring unreachable code. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c | 41 ++ 1 files changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index a6c6aba..1

[PATCH 2/2] staging: cxt1e1: remove redundant memset() call

The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'. And also it doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |8 +++- 1 files changed, 3 insert

[PATCH 1/2] staging: cxtie1: remove unneeded mkret() calls

The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |

Re: [PATCH 3/4] staging: cxtie1: remove unneeded mkret() calls

Ok. I will check and send it again. Thanks. Daeseok Youn. 2014-03-09 15:38 GMT+09:00, Greg KH : > On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote: >> >> The mkret() change a value of error from positive to >> negative. This patch is modified to return nega

[PATCH v2] staging: frontier: fix memory leak in usb_alphatrack_probe()

oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called. Signed-off-by: Daeseok Youn --- v2: remove the unneeded comment. drivers/staging/frontier/alphatrack.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/staging/frontier

Re: [PATCH] staging: frontier: fix memory leak in usb_alphatrack_probe()

OK. I will remove that comment and send again. Thanks. Daeseok Youn. 2014-03-07 17:14 GMT+09:00 Dan Carpenter : > On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote: >> >> oldi_buffer and write_buffer need to free when usb_alphatrack_delete() >> is called. >>

[PATCH] staging: frontier: fix memory leak in usb_alphatrack_probe()

oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called. Signed-off-by: Daeseok Youn --- drivers/staging/frontier/alphatrack.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier

[PATCH 4/4] staging: cxt1e1: remove redundant memset() call

The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'. And also it doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |8 +++- 1 files changed, 3 insert

[PATCH 3/4] staging: cxtie1: remove unneeded mkret() calls

The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |

[PATCH 2/4] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error in linux.c: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 67 --- 1 files changed, 21 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH 1/4] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging

Re: [PATCH v2 7/7] staging: cxt1e1: remove unneeded a value

Ok. I will fix it and send again. Thanks. Daeseok Youn 2014-03-07 4:58 GMT+09:00 Greg KH : > On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote: >> >> It doesn't need to assign name array address to np pointer. >> >> Signed-off-by: Daeseok Youn >

Re: [PATCH 4/7 v3] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

rebase current staging-next branch. Thanks. Daeseok Youn. 2014-03-07 4:57 GMT+09:00 Greg KH : > On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote: >> >> checkpatch.pl error in linux.c: >> ERROR: do not use assignment in if condition >> >

[PATCH v2 7/7] staging: cxt1e1: remove unneeded a value

It doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn --- v2: replace sprintf() with snprintf() and remove memset() call because snprintf() adds a terminating '\0' drivers/staging/cxt1e1/linux.c |8 +++- 1 files changed, 3 insertions(

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

Ok. I will use sizeof(name) for snprintf() call. Thanks. Daeseok Youn. 2014-03-06 16:33 GMT+09:00 Tobias Klauser : > On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote: >> 2014-03-05 19:13 GMT+09:00 Tobias Klauser : >> > On 2014-03-05 at 02:24:22 +0100, Daeseok

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 19:13 GMT+09:00 Tobias Klauser : > On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote: >> >> It doesn't need to assign name array address to np pointer. >> >> Signed-off-by: Daeseok Youn >> --- >> drivers/staging/cxt1e1/linux.c |5 +

Re: [PATCH] staging: cxt1e1: use kzalloc instead of kmalloc/memset 0

Thanks for review. OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc. And I also check GFP_DMA flag in kmalloc/kzalloc. Regards, Daeseok Youn 2014-03-05 19:04 GMT+09:00 Tobias Klauser : > On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote: >> >> Signed-off-b

[PATCH] staging: dgap: remove useless cast on kzalloc()

coccinelle warning: drivers/staging/dgap/dgap.c:782:3-7: WARNING: casting value returned by k[cmz]alloc to (char *) is useless. drivers/staging/dgap/dgap.c:776:2-16: WARNING: casting value returned by k[cmz]alloc to (struct board_t *) is useless. Signed-off-by: Daeseok Youn --- drivers

[PATCH] staging: cxt1e1: use kzalloc instead of kmalloc/memset 0

Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h b/drivers/staging/cxt1e1/sbecom_inline_linux.h index ba3ff3e..6dd1b55 100644 --- a/drivers

[PATCH 7/7] staging: cxt1e1: remove unneeded a value

It doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c index 5bb42ae..cae8c66 1

[PATCH 6/7] staging: cxtie1: remove unneeded mkret() calls

The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |

[PATCH 5/7 v3] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error in linux.c: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 67 --- 1 files changed, 21 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH 4/7 v3] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging

Re: [PATCH 5/7] staging: cxt1e1: fix checkpatch errors with open brace '{'

OK. I send patches again. Thanks. Daeseok Youn. 2014-03-05 10:06 GMT+09:00 Greg KH : > On Wed, Mar 05, 2014 at 09:55:14AM +0900, DaeSeok Youn wrote: >> Hi, greg >> >> I already resend patch 4 and 5. :-) >> >> It had a bug which is noticed by Dan. >> >&

Re: [PATCH 5/7] staging: cxt1e1: fix checkpatch errors with open brace '{'

-next branch from mailing list. Please check. Thanks. Daeseok Youn. 2014-03-05 9:35 GMT+09:00 Greg KH : > On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote: >> >> clean up checkpatch.pl error in linux.c: >> ERROR: that open brace { should be on the previous lin

[PATCH 5/7 v2] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error in linux.c: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 67 --- 1 files changed, 21 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH 4/7 v2] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

Yes, it need to add brace in inner loop. I will send again. Thanks for review. Daeseok Youn 2014-03-04 18:04 GMT+09:00, Dan Carpenter : > On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: >> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) >> ci = (ci_t *)

Re: [PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c

Thanks for review. Ok. I Will fix later. Daeseok Youn 2014-03-04 17:45 GMT+09:00, Dan Carpenter : > On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote: >> >> clean up checkpatch.pl warnings: >> WARNING: Line length over 80 characters >> >

[PATCH 3/5 v4] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers

Re: [PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c

. just my opinion. Regards. Daeseok Youn. 2014-03-04 12:24 GMT+09:00 Joe Perches : > On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote: >> clean up checkpatch.pl warnings: >> WARNING: Line length over 80 characters > > Please run your patches through checkpatch. >

[PATCH 7/7] staging: cxt1e1: remove unneeded a value

It doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c index 599a5ef..390b1f5 1

[PATCH 6/7] staging: cxtie1: remove unneeded mkret() calls

The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c |

[PATCH 5/7] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error in linux.c: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 67 --- 1 files changed, 21 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging

[PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 48 +-- 1 files changed, 31 insertions(+), 17 deletions(-) diff --git a/drivers/staging/cxt1e1/linux.c b/drivers

[PATCH 2/7] staging: cxt1e1: Fix no spaces at the start of a line in linux.c

clean up checkpatch.pl warnings: WARNING: please no spaces at the start of a line in Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 1478 1 files changed, 743 insertions(+), 735 deletions(-) diff --git a/drivers/staging/cxt1e1

[PATCH 1/7] staging: cxt1e1: remove space between function name and parenthesis

clean up checkpatch.pl warnings in linux.c: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/linux.c | 524 1 files changed, 262 insertions(+), 262 deletion

Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

Hi, Joe and Krzysztof I think that code which can be improved to hex_dump() may be used for debugging. So that improvement will be sent with another patch. I think it would be fine. right? Thanks. Daeseok Youn. 2014-03-03 16:33 GMT+09:00 DaeSeok Youn : > I think line break is a solut

Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

s. Daeseok Youn. 2014-03-03 16:10 GMT+09:00 Joe Perches : > On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote: >> 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa : >> > why not use some existing *hex_dump*() instead? >> OK. but this patch is only for fix line length over 80

<    1   2   3   4   5   6   >