Hi, greg.
Review my comment below.
Thanks.
Daeseok Youn.
2014-03-18 17:11 GMT+09:00 DaeSeok Youn :
> 2014-03-18 9:37 GMT+09:00 Greg KH :
>> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
>>> I think vmalloc/kmalloc in uislib_malloc() can be removed and ju
2014-03-18 9:37 GMT+09:00 Greg KH :
> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
>> vmalloc/kmalloc directly.
>
> Yes. Actually, just use kmalloc, I don't knwo why vmalloc is
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc directly.
Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being
Hi, greg.
Review my comment below.
Thanks.
Daeseok Youn.
2014-03-18 17:11 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can
a patch.
Regards,
Daeseok Youn.
2014-03-18 22:00 GMT+09:00 Ken Cox j...@redhat.com:
On 03/17/2014 07:26 PM, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc directly.
(UISMALLOC() macro is also removed.)
And uislib_malloc() is renamed
oh...
You didn't get my reply about vmalloc usage.
My replay attach again, below.
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc
Thanks for reply.
I will do that.
Regards,
Daeseok Youn.
2014-03-19 11:31 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote:
oh...
You didn't get my reply about vmalloc usage.
My replay attach again, below.
2014-03-18 9:37 GMT+09
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
v2: fix a typo in subject
this patch is rebased
BytesInUse
...) for info_proc_read_helper().
If this change is accepted, it also need to change uislib_free().
Is it fine to change like this?
Thanks.
Daeseok Youn.
2014-03-18 6:41 GMT+09:00 Greg KH :
> On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote:
>>
>> Signed-off-by: Daeseok Youn
&
Ok. I will rebase this patch in staging-next branch and send it again.
Thanks.
Daeseok Youn.
2014-03-18 6:23 GMT+09:00 Greg KH :
> On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote:
>>
>> The mkret() change a value of error from positive to
>> negative. T
Ok. I will rebase this patch in staging-next branch and send it again.
Thanks.
Daeseok Youn.
2014-03-18 6:23 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote:
The mkret() change a value of error from positive to
negative. This patch
...) for info_proc_read_helper().
If this change is accepted, it also need to change uislib_free().
Is it fine to change like this?
Thanks.
Daeseok Youn.
2014-03-18 6:41 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: fix a typo in subject
The banner array doens't need to set to 0.
sprintf() adds a terminating '\0'.
And the sn array can be declared and initialized to zero.
So remove redundant memset() with zero.
Remove unnecessary cast for memcpy().
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 12
The banner array doens't need to set to 0.
sprintf() adds a terminating '\0'.
And the sn array can be declared and initialized to zero.
So remove redundant memset() with zero.
Remove unnecessary cast for memcpy().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1
Signed-off-by: Daeseok Youn
---
drivers/staging/unisys/uislib/uislib.c |5 +
drivers/staging/unisys/uislib/uisutils.c |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/unisys/uislib/uislib.c |5 +
drivers/staging/unisys/uislib/uisutils.c |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib
The queue_delayed_work() return false if the work is
already on the queue, true otherwise.
So return value cannot be less than zero.
Signed-off-by: Daeseok Youn
---
.../unisys/visorchipset/visorchipset_main.c| 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff
The queue_delayed_work() return false if the work is
already on the queue, true otherwise.
So return value cannot be less than zero.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
.../unisys/visorchipset/visorchipset_main.c| 14 --
1 files changed, 4 insertions
ignoring unreachable code.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 41 ++
1 files changed, 19 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index a6c6aba..199b9d7 100644
-
.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c | 41 ++
1 files changed, 19 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index a6c6aba..199b9d7 100644
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72
Ok. I will check and send it again.
Thanks.
Daeseok Youn.
2014-03-09 15:38 GMT+09:00, Greg KH :
> On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote:
>>
>> The mkret() change a value of error from positive to
>> negative. This patch is modified to return n
Ok. I will check and send it again.
Thanks.
Daeseok Youn.
2014-03-09 15:38 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote:
The mkret() change a value of error from positive to
negative. This patch is modified to return negative
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn
---
v2: remove the unneeded comment.
drivers/staging/frontier/alphatrack.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/frontier
OK. I will remove that comment and send again.
Thanks.
Daeseok Youn.
2014-03-07 17:14 GMT+09:00 Dan Carpenter :
> On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote:
>>
>> oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
>> is called.
>>
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn
---
drivers/staging/frontier/alphatrack.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/frontier/alphatrack.c
b/drivers/staging/frontier
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/frontier/alphatrack.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/frontier/alphatrack.c
b
OK. I will remove that comment and send again.
Thanks.
Daeseok Youn.
2014-03-07 17:14 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote:
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: remove the unneeded comment.
drivers/staging/frontier/alphatrack.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH :
> On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
&g
to rebase current staging-next branch.
Thanks.
Daeseok Youn.
2014-03-07 4:57 GMT+09:00 Greg KH :
> On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
>>
>> checkpatch.pl error in linux.c:
>> ERROR: do not use assignment in if condition
>>
>
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3
to rebase current staging-next branch.
Thanks.
Daeseok Youn.
2014-03-07 4:57 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions
Ok.
I will use sizeof(name) for snprintf() call.
Thanks.
Daeseok Youn.
2014-03-06 16:33 GMT+09:00 Tobias Klauser :
> On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote:
>> 2014-03-05 19:13 GMT+09:00 Tobias Klauser :
>> > On 2014-03-05 at 02:24:22 +0100, Daeseok
2014-03-05 19:13 GMT+09:00 Tobias Klauser :
> On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> drivers/staging/cxt1e1/linux.c |5 ++---
Thanks for review.
OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc.
And I also check GFP_DMA flag in kmalloc/kzalloc.
Regards,
Daeseok Youn
2014-03-05 19:04 GMT+09:00 Tobias Klauser :
> On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote:
>>
>> Signed-off-b
coccinelle warning:
drivers/staging/dgap/dgap.c:782:3-7: WARNING:
casting value returned by k[cmz]alloc to (char *) is useless.
drivers/staging/dgap/dgap.c:776:2-16: WARNING:
casting value returned by k[cmz]alloc to (struct board_t *) is useless.
Signed-off-by: Daeseok Youn
---
drivers
coccinelle warning:
drivers/staging/dgap/dgap.c:782:3-7: WARNING:
casting value returned by k[cmz]alloc to (char *) is useless.
drivers/staging/dgap/dgap.c:776:2-16: WARNING:
casting value returned by k[cmz]alloc to (struct board_t *) is useless.
Signed-off-by: Daeseok Youn daeseok.y
Thanks for review.
OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc.
And I also check GFP_DMA flag in kmalloc/kzalloc.
Regards,
Daeseok Youn
2014-03-05 19:04 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 03:37:15 +0100, Daeseok Youn daeseok.y...@gmail.com wrote
2014-03-05 19:13 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn daeseok.y...@gmail.com wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
Ok.
I will use sizeof(name) for snprintf() call.
Thanks.
Daeseok Youn.
2014-03-06 16:33 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn daeseok.y...@gmail.com wrote:
2014-03-05 19:13 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 02
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h
b/drivers/staging/cxt1e1/sbecom_inline_linux.h
index ba3ff3e..6dd1b55 100644
--- a/drivers
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 5bb42ae..cae8c66 100644
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
OK.
I send patches again.
Thanks.
Daeseok Youn.
2014-03-05 10:06 GMT+09:00 Greg KH :
> On Wed, Mar 05, 2014 at 09:55:14AM +0900, DaeSeok Youn wrote:
>> Hi, greg
>>
>> I already resend patch 4 and 5. :-)
>>
>> It had a bug which is noticed by Dan.
>>
>&
-next branch from mailing list.
Please check.
Thanks.
Daeseok Youn.
2014-03-05 9:35 GMT+09:00 Greg KH :
> On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl error in linux.c:
>> ERROR: that open brace { should be on the previous
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
Yes, it need to add brace in inner loop.
I will send again.
Thanks for review.
Daeseok Youn
2014-03-04 18:04 GMT+09:00, Dan Carpenter :
> On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
>> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>> ci = (ci_t *)
Thanks for review.
Ok. I Will fix later.
Daeseok Youn
2014-03-04 17:45 GMT+09:00, Dan Carpenter :
> On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>>
>
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
Thanks for review.
Ok. I Will fix later.
Daeseok Youn
2014-03-04 17:45 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
Yes, it need to add brace in inner loop.
I will send again.
Thanks for review.
Daeseok Youn
2014-03-04 18:04 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
@@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
ci
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
-next branch from mailing list.
Please check.
Thanks.
Daeseok Youn.
2014-03-05 9:35 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
OK.
I send patches again.
Thanks.
Daeseok Youn.
2014-03-05 10:06 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 05, 2014 at 09:55:14AM +0900, DaeSeok Youn wrote:
Hi, greg
I already resend patch 4 and 5. :-)
It had a bug which is noticed by Dan.
I tried to fix assignment
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h
b/drivers/staging/cxt1e1/sbecom_inline_linux.h
index ba3ff3e..6dd1b55
.
just my opinion.
Regards.
Daeseok Youn.
2014-03-04 12:24 GMT+09:00 Joe Perches :
> On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>
> Please run your patches through checkpatch.
>
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 599a5ef..390b1f5 100644
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 48 +--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 1478
1 files changed, 743 insertions(+), 735 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings in linux.c:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 524
1 files changed, 262 insertions(+), 262 deletions(-)
diff
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn :
> I think line break is a solut
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
I think line
clean up checkpatch.pl warnings in linux.c:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 524
1 files changed, 262 insertions(+), 262
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 1478
1 files changed, 743 insertions(+), 735 deletions(-)
diff --git a/drivers
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 48 +--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index
.
just my opinion.
Regards.
Daeseok Youn.
2014-03-04 12:24 GMT+09:00 Joe Perches j...@perches.com:
On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Please run your patches through checkpatch.
diff --git
Youn.
2014-03-03 16:10 GMT+09:00 Joe Perches :
> On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
>> 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa :
>> > why not use some existing *hex_dump*() instead?
>> OK. but this patch is only for fix line length over 80 charact
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa :
> Daeseok Youn writes:
>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>
> This warning should be long gone IMHO. It does more harm than good.
>
>> unsigned char *ucp =
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/cxt1e1
901 - 1000 of 1119 matches
Mail list logo
