the "brd" was already checked for NULL before calling dgnc_do_remap().
the dgnc_do_remap() function was called only
from the dgnc_found_board() and the DGNC_BOARD_MAGIC value
was assigned to "brd->magic" in dgcn_found_board(). So it doesn't
need to check about magic value.
2016-05-26 21:29 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>:
> On 26/05/16 05:56, DaeSeok Youn wrote:
>> 2016-05-26 6:48 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>:
>>> On 20/05/16 10:51, Daeseok Youn wrote:
>>>> the "brd&qu
2016-05-26 21:29 GMT+09:00 Luis de Bethencourt :
> On 26/05/16 05:56, DaeSeok Youn wrote:
>> 2016-05-26 6:48 GMT+09:00 Luis de Bethencourt :
>>> On 20/05/16 10:51, Daeseok Youn wrote:
>>>> the "brd" value cannot be NULL in dgnc_finalize_board_i
2016-05-26 7:00 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>:
> On 20/05/16 10:51, Daeseok Youn wrote:
>> the "brd" was already checked for NULL before calling dgnc_do_remap().
>>
>> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
>&g
2016-05-26 7:00 GMT+09:00 Luis de Bethencourt :
> On 20/05/16 10:51, Daeseok Youn wrote:
>> the "brd" was already checked for NULL before calling dgnc_do_remap().
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> drivers/staging/dgnc/dgnc_driver.c | 3 ---
&g
2016-05-26 6:48 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>:
> On 20/05/16 10:51, Daeseok Youn wrote:
>> the "brd" value cannot be NULL in dgnc_finalize_board_init().
>> Because "brd" as a parameter of this function was already
>> chec
2016-05-26 6:48 GMT+09:00 Luis de Bethencourt :
> On 20/05/16 10:51, Daeseok Youn wrote:
>> the "brd" value cannot be NULL in dgnc_finalize_board_init().
>> Because "brd" as a parameter of this function was already
>> checked for NULL.
>>
>> Si
the "brd" value cannot be NULL in dgnc_finalize_board_init().
Because "brd" as a parameter of this function was already
checked for NULL.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file changed, 3 deletion
the "brd" value cannot be NULL in dgnc_finalize_board_init().
Because "brd" as a parameter of this function was already
checked for NULL.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/stagin
the "brd" was already checked for NULL before calling dgnc_do_remap().
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgn
the "brd" was already checked for NULL before calling dgnc_do_remap().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index 22257d2..1882
Re-arrange the functions for removing forward declarations in dgnc_cls.c file.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
After applying this patch, the object file size was NOT changed.
drivers/staging/dgnc/dgnc_cls.c | 949 +++-
1 file c
Re-arrange the functions for removing forward declarations in dgnc_cls.c file.
Signed-off-by: Daeseok Youn
---
After applying this patch, the object file size was NOT changed.
drivers/staging/dgnc/dgnc_cls.c | 949 +++-
1 file changed, 460 insertions(+), 489
The dgnc_set_modem_info() used only channel_t variable.
Any other variables were used only for checking NULL.
So fist parameter changed from "tty_struct" to "channel_t" and
useless NULL checks and variables are removed.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.co
The dgnc_set_modem_info() used only channel_t variable.
Any other variables were used only for checking NULL.
So fist parameter changed from "tty_struct" to "channel_t" and
useless NULL checks and variables are removed.
Signed-off-by: Daeseok Youn
---
drivers/staging/
The local variable "bd" was not used in dgnc_carrier() function.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty
The local variable "bd" was not used in dgnc_carrier() function.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index a505775..52a1
The unit struct(un_t) was not used in dgnc_tty_hangup().
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 52a1613..5
The unit struct(un_t) was not used in dgnc_tty_hangup().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 52a1613..5119bcb 100644
--- a/drivers/staging
The "result" variable in dgnc_get_mstat() was initialized with
"-EIO". But if the "ch" is not null, "result" will be set to zero
and if the "ch" is null, dgnc_get_mstat() will return "-ENXIO" as
an error. So "-EIO" err
The "result" variable in dgnc_get_mstat() was initialized with
"-EIO". But if the "ch" is not null, "result" will be set to zero
and if the "ch" is null, dgnc_get_mstat() will return "-ENXIO" as
an error. So "-EIO" err
The dgnc_block_til_ready() is only used in dgnc_tty_open().
The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
And also tty and un were tested about NULL so these variables doesn't
need to check for NULL in dgnc_block_til_ready().
Signed-off-by: Daeseok Y
The dgnc_block_til_ready() is only used in dgnc_tty_open().
The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
And also tty and un were tested about NULL so these variables doesn't
need to check for NULL in dgnc_block_til_ready().
Signed-off-by: Daeseok Y
2016-05-09 21:08 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
>> tty and ch are already checked for NULL
>> before calling dgnc_block_til_ready().
>>
>> Signed-off-by: Daeseok Youn <daeseok.y
2016-05-09 21:09 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Wed, May 04, 2016 at 02:13:26PM +0900, Daeseok Youn wrote:
>> the result in dgnc_get_mstat() was initialized with -EIO but
>> there are no use of EIO as a result in this function.
>>
>> Signe
2016-05-09 21:08 GMT+09:00 Greg KH :
> On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote:
>> tty and ch are already checked for NULL
>> before calling dgnc_block_til_ready().
>>
>> Signed-off-by: Daeseok Youn
>
> Your subject line doesn't make sense, p
2016-05-09 21:09 GMT+09:00 Greg KH :
> On Wed, May 04, 2016 at 02:13:26PM +0900, Daeseok Youn wrote:
>> the result in dgnc_get_mstat() was initialized with -EIO but
>> there are no use of EIO as a result in this function.
>>
>> Signed-off-by: Daeseok Youn
>
the "ch" from brd structure could be NULL, it need to
check for NULL.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging
the "ch" from brd structure could be NULL, it need to
check for NULL.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 9eae1a
fix checkpatch.pl warning about 'line over 80 characters'.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_sysfs.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/s
fix checkpatch.pl warning about 'line over 80 characters'.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_sysfs.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index
dgnc_board(brd) was already checked for NULL before calling
neo_parse_isr(). And also port doesn't need to check.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_n
dgnc_board(brd) was already checked for NULL before calling
neo_parse_isr(). And also port doesn't need to check.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc
Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2
Carpenter
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2cecdb0..392d532 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drive
the "ch" in dgnc_get_modem_info() was already checked before calling
this function and also if "ch" is not NULL, dgnc_get_mstat() returns
valid value so it doesn't need to check an error.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/st
the "ch" in dgnc_get_modem_info() was already checked before calling
this function and also if "ch" is not NULL, dgnc_get_mstat() returns
valid value so it doesn't need to check an error.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 12 +--
the result in dgnc_get_mstat() was initialized with -EIO but
there are no use of EIO as a result in this function.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/stagin
the result in dgnc_get_mstat() was initialized with -EIO but
there are no use of EIO as a result in this function.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers
tty and ch are already checked for NULL
before calling dgnc_block_til_ready().
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/s
tty and ch are already checked for NULL
before calling dgnc_block_til_ready().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index
The tty_alloc_driver() can allocate memory for ttys and termios.
And also allocated memory will be released easily with
put_tty_driver() call.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 4 +-
drivers/staging/dgnc/dgnc_tty.c
The tty_alloc_driver() can allocate memory for ttys and termios.
And also allocated memory will be released easily with
put_tty_driver() call.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 4 +-
drivers/staging/dgnc/dgnc_tty.c| 144
There were already checking NULL about channel_t / un_t
before calling dgnc_maxcps_room().
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc
There were already checking NULL about channel_t / un_t
before calling dgnc_maxcps_room().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
The kzalloc can be failed when memory is not enough
to allocate. When kzalloc failed, it need to return
error code with ENOMEM
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/stagin
The kzalloc can be failed when memory is not enough
to allocate. When kzalloc failed, it need to return
error code with ENOMEM
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers
remove parenthesis around the CONST | CONST.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 5e46ac8..4
fix checkpatch.pl warning:
Blank lines aren't necessary after an open brace '{'
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
fix checkpatch.pl warning:
Blank lines aren't necessary after an open brace '{'
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 2da6a72..3b8ce38 100644
remove parenthesis around the CONST | CONST.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 5e46ac8..46c050c 100644
--- a/drivers/staging
fix checkpatch.pl warning about 'Avoid CamelCase'
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
drivers/staging/dgnc/digi.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/d
fix checkpatch.pl warning about 'Avoid CamelCase'
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
drivers/staging/dgnc/digi.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
The "ch->ch_bd" is already assined to "bd" but this is only
for checking null or MAGIC number.
in the dgnc_tty_ioctl function, bd can be used for referencing
to board_ops structure.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers
The "ch->ch_bd" is already assined to "bd" but this is only
for checking null or MAGIC number.
in the dgnc_tty_ioctl function, bd can be used for referencing
to board_ops structure.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 37 +
This is for fixing checkpatch.pl warning about
"Alignment should match open parenthesis" but if that is
fixed, code line is over 80 characters.
I think "ch->ch_rqueue + tail + i" could be declared once in
the begining of loop.
Signed-off-by: Daeseok Youn <daeseok.y.
This is for fixing checkpatch.pl warning about
"Alignment should match open parenthesis" but if that is
fixed, code line is over 80 characters.
I think "ch->ch_rqueue + tail + i" could be declared once in
the begining of loop.
Signed-off-by: Daeseok Youn
---
drivers/stagi
It doesn't need to save major number with variable.
And there are no use of these variables(dgnc_serial_major and
dgnc_transparent_print_major)
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 3 ---
drivers/staging/dgnc/dgnc_tty.c| 4 -
It doesn't need to save major number with variable.
And there are no use of these variables(dgnc_serial_major and
dgnc_transparent_print_major)
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 3 ---
drivers/staging/dgnc/dgnc_tty.c| 4
2 files changed, 7 deletions
fix checkpatch.pl warning about
'Logical continuations should be on the previous line'
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/d
fix checkpatch.pl warning about 'line over 80 characters'.
I just moved all line comment to above if statement.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/d
fix checkpatch.pl warning about
'Logical continuations should be on the previous line'
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
fix checkpatch.pl warning about 'line over 80 characters'.
I just moved all line comment to above if statement.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b
remove parenthesis around the CONST | CONST.
It will be also fixed checkpatch.pl warning about
"Alignment should match open parenthesis" becasue
parenthesis were removed by this patch.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc
remove parenthesis around the CONST | CONST.
It will be also fixed checkpatch.pl warning about
"Alignment should match open parenthesis" becasue
parenthesis were removed by this patch.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 26 +---
the dgnc_offset_table has a same value with (1 << port).
So I tried to replace dgnc_offset_table array with 1 << port.
And also there are redundant assignments(tmp and current_port)
inside while loop for checking uart port, and remove them.
Signed-off-by: Daeseok Youn <daeseok
the dgnc_offset_table has a same value with (1 << port).
So I tried to replace dgnc_offset_table array with 1 << port.
And also there are redundant assignments(tmp and current_port)
inside while loop for checking uart port, and remove them.
Signed-off-by: Daeseok Youn
---
V2: clea
2016-03-25 22:15 GMT+09:00 walter harms <wha...@bfs.de>:
>
>
> Am 25.03.2016 12:33, schrieb Daeseok Youn:
>> the dgnc_offset_table has a same value with (1 << port).
>> So I tried to replace dgnc_offset_table array with 1 << port.
>> And also there a
2016-03-25 22:15 GMT+09:00 walter harms :
>
>
> Am 25.03.2016 12:33, schrieb Daeseok Youn:
>> the dgnc_offset_table has a same value with (1 << port).
>> So I tried to replace dgnc_offset_table array with 1 << port.
>> And also there are redundant assignment
the dgnc_offset_table has a same value with (1 << port).
So I tried to replace dgnc_offset_table array with 1 << port.
And also there are redundant assignments(tmp and current_port)
inside while loop for checking uart port, and remove them.
Signed-off-by: Daeseok Youn <daeseok
the dgnc_offset_table has a same value with (1 << port).
So I tried to replace dgnc_offset_table array with 1 << port.
And also there are redundant assignments(tmp and current_port)
inside while loop for checking uart port, and remove them.
Signed-off-by: Daeseok Youn
---
Greg
2016-03-25 12:19 GMT+09:00 Joe Perches <j...@perches.com>:
> On Fri, 2016-03-25 at 11:44 +0900, Daeseok Youn wrote:
>> fix checkpatch.pl warning about 'line over 80 characters'
>> in dgnc_neo.c
> []
>> diff --git a/drivers/staging/dgnc/dgnc_neo.c
>&g
2016-03-25 12:19 GMT+09:00 Joe Perches :
> On Fri, 2016-03-25 at 11:44 +0900, Daeseok Youn wrote:
>> fix checkpatch.pl warning about 'line over 80 characters'
>> in dgnc_neo.c
> []
>> diff --git a/drivers/staging/dgnc/dgnc_neo.c
>> b/drivers/staging/dgnc/dgn
fix checkpatch.pl warning about 'Logical continuations
should be on the previous line' in dgnc_neo.c file.
I think the 'force' need to check first, because if the 'force' is true,
it doesn't need to call another function call.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
d
fix checkpatch.pl warning about 'Logical continuations
should be on the previous line' in dgnc_neo.c file.
I think the 'force' need to check first, because if the 'force' is true,
it doesn't need to call another function call.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 4
fix checkpatch.pl warning about 'line over 80 characters'
in dgnc_neo.c
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 66 +++--
1 file changed, 44 insertions(+), 22 deletions(-)
diff --git a/drivers/stagin
fix checkpatch.pl warning about 'line over 80 characters'
in dgnc_neo.c
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_neo.c | 66 +++--
1 file changed, 44 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers
fix checkpatch.pl warning about CamelCase
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 12 ++--
drivers/staging/dgnc/dgnc_tty.c| 32
2 files changed, 22 insertions(+), 22 deletions(-)
diff
fix checkpatch.pl warning about CamelCase
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 12 ++--
drivers/staging/dgnc/dgnc_tty.c| 32
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgnc
TtyRefCnt was not used anywhere in dgnc.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 3d8e15f..44216ae
TtyRefCnt was not used anywhere in dgnc.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 3d8e15f..44216ae 100644
--- a/drivers/staging/dgnc
fix checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
V2: fix build errors reported by kbuild test robot.
And also save the attached .config file to my linux build tree.
build successfully without any errors.
drivers/stagin
fix checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn
---
V2: fix build errors reported by kbuild test robot.
And also save the attached .config file to my linux build tree.
build successfully without any errors.
drivers/staging/dgnc/dgnc_driver.c | 52
fix checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 52 +++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/d
fix checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 52 +++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
2016-03-22 22:02 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Tue, Mar 22, 2016 at 04:40:24PM +0900, DaeSeok Youn wrote:
>> 2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
>> > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
&g
2016-03-22 22:02 GMT+09:00 Greg KH :
> On Tue, Mar 22, 2016 at 04:40:24PM +0900, DaeSeok Youn wrote:
>> 2016-03-22 6:05 GMT+09:00 Greg KH :
>> > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
>> >> the tty_alloc_driver() can allocate memory for tt
is module.
(I had been fixing issues dgap module that was removed in linux-next
branch. dgnc has same issues what dgap has.
I can also fix issues in dgnc module.)
Thanks for comment.
regards,
Daeseok.
>
> just my two cents
>
> re,
> wh
>
> Am 22.03.2016 10:20, schrieb Daese
been fixing issues dgap module that was removed in linux-next
branch. dgnc has same issues what dgap has.
I can also fix issues in dgnc module.)
Thanks for comment.
regards,
Daeseok.
>
> just my two cents
>
> re,
> wh
>
> Am 22.03.2016 10:20, schrieb Daeseok Youn:
>> fix th
fix the checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 4 +-
drivers/staging/dgnc/dgnc_tty.c| 118 ++---
2 files changed, 61 insertions(+), 61 deletions(-)
diff
fix the checkpatch.pl warning about CamelCase.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 4 +-
drivers/staging/dgnc/dgnc_tty.c| 118 ++---
2 files changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/dgnc
2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
>> the tty_alloc_driver() can allocate memory for ttys and termios.
>> And also it can release allocated memory easly with using
>> put_tty
2016-03-22 6:05 GMT+09:00 Greg KH :
> On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
>> the tty_alloc_driver() can allocate memory for ttys and termios.
>> And also it can release allocated memory easly with using
>> put_tty_driver().
>>
>> Signed-
2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
>> For using tty_alloc_driver, SerialDriver has to be pointer type.
>
> Yes, but you aren't calling tty_alloc_driver, so this patch totally
>
2016-03-22 6:05 GMT+09:00 Greg KH :
> On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
>> For using tty_alloc_driver, SerialDriver has to be pointer type.
>
> Yes, but you aren't calling tty_alloc_driver, so this patch totally
> breaks the working code :(
2016-03-22 6:02 GMT+09:00 Greg KH <gre...@linuxfoundation.org>:
> On Mon, Mar 14, 2016 at 01:28:01PM +0900, Daeseok Youn wrote:
>> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
>
> Your subject: does not make sense, and I can't take a patch without any
> cha
2016-03-22 6:02 GMT+09:00 Greg KH :
> On Mon, Mar 14, 2016 at 01:28:01PM +0900, Daeseok Youn wrote:
>> Signed-off-by: Daeseok Youn
>
> Your subject: does not make sense, and I can't take a patch without any
> changelog entry :(
ok. I will add comment to changelog entry and re
the tty_alloc_driver() can allocate memory for ttys and termios.
And also it can release allocated memory easly with using
put_tty_driver().
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 86 +++--
1 file chang
Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 4 +-
drivers/staging/dgnc/dgnc_tty.c| 118 ++---
2 files changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/d
the tty_alloc_driver() can allocate memory for ttys and termios.
And also it can release allocated memory easly with using
put_tty_driver().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 86 +++--
1 file changed, 31 insertions(+), 55
201 - 300 of 1119 matches
Mail list logo
