Re: [GIT PULL] libnvdimm for 5.4

2019-09-21 Thread Dan Williams
On Fri, Sep 20, 2019 at 4:57 PM Dan Williams wrote: > > Hi Linus, please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm > tags/libnvdimm-for-5.4 > > ...to receive some reworks to better support nvdimms on powerpc and an > nvdimm security inter

[GIT PULL] libnvdimm for 5.4

2019-09-20 Thread Dan Williams
lign check libnvdimm: Use PAGE_SIZE instead of SZ_4K for align check Dan Williams (5): tools/testing/nvdimm: Fix fallthrough warning libnvdimm/security: Introduce a 'frozen' attribute libnvdimm/security: Tighten scope of nvdimm->busy vs security operations libnv

Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc

2019-09-20 Thread Dan Williams
On Fri, Sep 20, 2019 at 11:18 AM Qian Cai wrote: > > On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote: > > Qian Cai writes: > > > > > The linux-next commit "libnvdimm/dax: Pick the right alignment default > > > when > > > creating dax devices" causes powerpc failed to build with this

Re: linux-next: manual merge of the nvdimm tree with the libnvdimm-fixes tree

2019-09-19 Thread Dan Williams
On Thu, Sep 19, 2019 at 8:02 AM Mark Brown wrote: > > Hi all, > > Today's linux-next merge of the nvdimm tree got a conflict in: > > drivers/nvdimm/pfn_devs.c > > between commit: > > 274b924088e935 ("libnvdimm/pfn: Fix namespace creation on misaligned > addresses") > > from the

Re: [PATCH] libnvdimm/nfit_test: Fix acpi_handle redefinition

2019-09-18 Thread Dan Williams
On Tue, Sep 17, 2019 at 9:23 PM Nathan Chancellor wrote: > > After commit 62974fc389b3 ("libnvdimm: Enable unit test infrastructure > compile checks"), clang warns: > > In file included from > ../drivers/nvdimm/../../tools/testing/nvdimm/test/iomap.c:15: >

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-17 Thread Dan Williams
On Tue, Sep 17, 2019 at 9:16 AM Jason Gunthorpe wrote: > > On Fri, Sep 13, 2019 at 02:48:50PM +0300, Dan Carpenter wrote: > > > It used to be that infiniband used "sizeof foo" instead of sizeof(foo) > > but now there is a new maintainer. > > These days I run everything through checkpatch and

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-13 Thread Dan Williams
On Fri, Sep 13, 2019 at 4:49 AM Dan Carpenter wrote: > > On Fri, Sep 13, 2019 at 01:09:37AM -0600, Jonathan Corbet wrote: > > On Wed, 11 Sep 2019 16:11:29 -0600 > > Jens Axboe wrote: > > > > > On 9/11/19 12:43 PM, Dan Carpenter wrote: > > > > > > > > I kind of hate all this extra documentation

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Dan Williams
On Thu, Sep 12, 2019 at 7:06 AM Johannes Thumshirn wrote: > > On 12/09/2019 16:00, Jeff Moyer wrote: > > I'd rather avoid the churn and the risk of > > introducing regressions. This will also make backports to stable more > > of a pain, so it isn't without cost. Dan, is this really something

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-12 Thread Dan Williams
On Thu, Sep 12, 2019 at 4:02 AM Joe Perches wrote: > > (cut down the cc-list) > > On Thu, 2019-09-12 at 03:18 -0700, Joe Perches wrote: > > On Thu, 2019-09-12 at 10:24 +0200, Miguel Ojeda wrote: > > > On Thu, Sep 12, 2019 at 9:43 AM Dan Williams > > &g

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Dan Williams
Hi Joe, On Wed, Sep 11, 2019 at 7:55 PM Joe Perches wrote: > > Rather than have a local coding style, use the typical kernel style. I'd rather automate this. I'm going to do once-over with clang-format and see what falls out.

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-12 Thread Dan Williams
On Wed, Sep 11, 2019 at 3:11 PM Jens Axboe wrote: > > On 9/11/19 12:43 PM, Dan Carpenter wrote: > > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: > >> +Coding Style Addendum > >> +- > >> +libnvdimm expects multi-lin

[PATCH v2 1/3] MAINTAINERS: Reclaim the P: tag for Maintainer Entry Profile

2019-09-11 Thread Dan Williams
Fixup some P: entries to be M: and delete the others that do not include an email address. The P: tag will be used to indicate the location of a Profile for a given MAINTAINERS entry. Cc: Joe Perches Signed-off-by: Dan Williams --- MAINTAINERS | 12 +++- 1 file changed, 3 insertions

[PATCH v2 2/3] Maintainer Handbook: Maintainer Entry Profile

2019-09-11 Thread Dan Williams
. Petersen Cc: Daniel Vetter Cc: Joe Perches Cc: Dmitry Vyukov Cc: Alexandre Belloni Signed-off-by: Dan Williams --- Documentation/maintainer/index.rst |1 .../maintainer/maintainer-entry-profile.rst| 99 MAINTAINERS

[PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-11 Thread Dan Williams
Document the basic policies of the libnvdimm subsystem and provide a first example of a Maintainer Entry Profile for others to duplicate and edit. Cc: Vishal Verma Cc: Dave Jiang Signed-off-by: Dan Williams --- Documentation/nvdimm/maintainer-entry-profile.rst | 64

[PATCH v2 0/3] Maintainer Entry Profiles

2019-09-11 Thread Dan Williams
n outlet to document the unwritten rules and policies in effect for each subsystem, and that each subsystem might decide differently for whatever reason. --- Dan Williams (3): MAINTAINERS: Reclaim the P: tag for Maintainer Entry Profile Maintainer Handbook: Maintainer Entry Profile li

Re: [RFC PATCH v2] mm: initialize struct pages reserved by ZONE_DEVICE driver.

2019-09-10 Thread Dan Williams
On Tue, Sep 10, 2019 at 7:01 AM Michal Hocko wrote: > > On Fri 06-09-19 08:09:52, Toshiki Fukasawa wrote: > [...] > > @@ -5856,8 +5855,6 @@ void __meminit memmap_init_zone(unsigned long size, > > int nid, unsigned long zone, > > if (!altmap) > > return; > > >

Re: [RFC PATCH v2] mm: initialize struct pages reserved by ZONE_DEVICE driver.

2019-09-10 Thread Dan Williams
On Mon, Sep 9, 2019 at 5:06 AM David Hildenbrand wrote: > > On 09.09.19 13:53, Dan Williams wrote: > > On Mon, Sep 9, 2019 at 1:11 AM David Hildenbrand wrote: > > [..] > >>>> It seems that SECTION_IS_ONLINE and SECTION_MARKED_PRESENT can be used to > >>

Re: [RFC PATCH v2] mm: initialize struct pages reserved by ZONE_DEVICE driver.

2019-09-09 Thread Dan Williams
On Mon, Sep 9, 2019 at 1:11 AM David Hildenbrand wrote: [..] > >> It seems that SECTION_IS_ONLINE and SECTION_MARKED_PRESENT can be used to > >> distinguish uninitialized struct pages if we can apply them to ZONE_DEVICE, > >> but that is no longer necessary with this approach. > > > > Let's take

[GIT PULL] libnvdimm fix for v5.3-rc8

2019-09-06 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-fix-5.3-rc8 ...to receive a fix for a regression introduced in v5.3-rc1. The latest version has shipped in -next with no reported issues. --- The following changes since commit

Re: [PATCH v8 2/7] mm: Adjust shuffle code to allow for future coalescing

2019-09-06 Thread Dan Williams
educe the overhead > and can consolidate all of the list addition bits in one spot. Looks good, thanks for doing the split: Reviewed-by: Dan Williams

Re: [PATCH v8 1/7] mm: Add per-cpu logic to page shuffling

2019-09-06 Thread Dan Williams
ch this can result in cache line > bouncing and will ultimately hurt performance when enabled. > > To resolve this I have moved to a per-cpu logic for maintaining a unsigned > long containing some amount of bits, and an offset value for which bit we > can use for entropy with each call. > Reviewed-by: Dan Williams

Re: [PATCH v5 00/10] EFI Specific Purpose Memory Support

2019-09-04 Thread Dan Williams
On Mon, Sep 2, 2019 at 4:09 AM Rafael J. Wysocki wrote: > > On Friday, August 30, 2019 3:52:18 AM CEST Dan Williams wrote: > > Changes since v4 [1]: > > - Rename the facility from "Application Reserved" to "Soft Reserved" to > > better reflect how

[PATCH v4] libnvdimm: Enable unit test infrastructure compile checks

2019-09-04 Thread Dan Williams
to catch unit test build regressions. Note that there are a few x86isms in the implementation, so this does not bother compile testing this architectures other than 64-bit x86. Cc: Jérôme Glisse Cc: Jason Gunthorpe Reported-by: Christoph Hellwig Signed-off-by: Dan Williams Link: https

Re: [PATCH v7 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h

2019-09-04 Thread Dan Williams
the mm/internal.h header so > that they can be used outside of the page_alloc.c file. > > Signed-off-by: Alexander Duyck Reviewed-by: Dan Williams

Re: [PATCH v7 1/6] mm: Adjust shuffle code to allow for future coalescing

2019-09-04 Thread Dan Williams
On Wed, Sep 4, 2019 at 8:10 AM Alexander Duyck wrote: > > From: Alexander Duyck > > Move the head/tail adding logic out of the shuffle code and into the > __free_one_page function since ultimately that is where it is really > needed anyway. By doing this we should be able to reduce the overhead

Re: linux-next: build failure after merge of the hmm tree

2019-09-03 Thread Dan Williams
On Mon, Sep 2, 2019 at 10:42 PM Stephen Rothwell wrote: > > Hi Dan, > > On Mon, 2 Sep 2019 22:31:00 -0700 Dan Williams > wrote: > > > > On Mon, Sep 2, 2019 at 4:45 PM Stephen Rothwell > > wrote: > > > > > > Hi Jason, > > > > >

Re: linux-next: build failure after merge of the hmm tree

2019-09-02 Thread Dan Williams
On Mon, Sep 2, 2019 at 4:45 PM Stephen Rothwell wrote: > > Hi Jason, > > On Mon, 2 Sep 2019 10:51:41 + Jason Gunthorpe wrote: > > > > On Mon, Sep 02, 2019 at 08:50:17PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > ERROR: "nd_region_provider_data" [drivers/acpi/nfit/nfit.ko]

[PATCH v3] libnvdimm: Enable unit test infrastructure compile checks

2019-08-31 Thread Dan Williams
to catch unit test build regressions. Note that there are a few x86isms in the implementation, so this does not bother compile testing this architectures other than 64-bit x86. Cc: Jérôme Glisse Cc: Jason Gunthorpe Reported-by: Christoph Hellwig Signed-off-by: Dan Williams Link: https

Re: [PATCH] IOAT: iop-adma.c: fix printk format warning

2019-08-30 Thread Dan Williams
> type ‘unsigned int’, but argument 6 has type ‘dma_addr_t {aka long long > unsigned int}’ [-Wformat=] > > Fixes: c211092313b9 ("dmaengine: driver for the iop32x, iop33x, and iop13xx > raid engines") > Signed-off-by: Randy Dunlap > Cc: Dan Williams Acked-by: Dan Williams &

Re: [PATCH v3] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-30 Thread Dan Williams
On Fri, Aug 30, 2019 at 8:47 AM Stephen Douthit wrote: > > On 8/29/19 7:30 PM, Dan Williams wrote: > > The Linux ahci driver has historically implemented a configuration fixup > > for platforms / platform-firmware that fails to enable the ports prior > > to OS han

[PATCH v5 07/10] dax: Fix alloc_dax_region() compile warning

2019-08-29 Thread Dan Williams
eported-by: kbuild test robot Signed-off-by: Dan Williams --- drivers/dax/bus.c |2 +- drivers/dax/bus.h |2 +- drivers/dax/dax-private.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 8fafbeab510a..e

[PATCH v5 04/10] x86, efi: Reserve UEFI 2.8 Specific Purpose Memory for dax

2019-08-29 Thread Dan Williams
islav Petkov Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Darren Hart Cc: Andy Shevchenko Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ard Biesheuvel Reported-by: kbuild test robot Reviewed-by: Dave Hansen Signed-off-by: Dan Williams --- Documentation/admin-gu

[PATCH v3] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-29 Thread Dan Williams
e quirk if the board was matched by class-code. Reported-by: Stephen Douthit Cc: Christoph Hellwig Signed-off-by: Dan Williams --- Changes since v2: - Use board_ahci_pcs7 to opt Denverton out of the PCS quirk. drivers/ata/ahci.c | 116 +++- drivers/at

Re: [PATCH v2] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-29 Thread Dan Williams
On Thu, Aug 29, 2019 at 4:33 PM Dan Williams wrote: > > The Linux ahci driver has historically implemented a configuration fixup > for platforms / platform-firmware that fails to enable the ports prior > to OS hand-off at boot. The fixup was originally implemented way back > be

[PATCH v2] libata/ahci: Drop PCS quirk for Denverton and beyond

2019-08-29 Thread Dan Williams
e quirk if the board was matched by class-code. Reported-by: Stephen Douthit Cc: Christoph Hellwig Signed-off-by: Dan Williams --- Changes since v1 [1]: - Find a way to not duplicate a large portion of the ahci_pci_tbl[] array (Stephen). - Add a definition for the PCS register offset rather than hard

Re: linux-next: Fixes tag needs some work in the nvdimm-fixes tree

2019-08-29 Thread Dan Williams
On Thu, Aug 29, 2019 at 3:09 PM Stephen Rothwell wrote: > > Hi all, > > In commit > > dcbce3cd20be ("libnvdimm/pfn: Fix namespace creation on misaligned > addresses") > > Fixes tag > > Fixes: commit a3619190d62e ("libnvdimm/pfn: stop padding pmem namespaces > ...") > > has these problem(s):

Re: [PATCH] libnvdimm, region: Use struct_size() in kzalloc()

2019-08-29 Thread Dan Williams
On Wed, Aug 28, 2019 at 1:24 PM Verma, Vishal L wrote: > > On Wed, 2019-08-28 at 14:36 -0500, Gustavo A. R. Silva wrote: > > > struct_size() does not apply to those scenarios. See below... > > > > > [1]: > > >

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Dan Williams
On Wed, Aug 28, 2019 at 3:53 PM Dave Chinner wrote: > > On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > > > For bdev_dax_pgoff > > > > > I'd

Re: [PATCH] usb: storage: Add ums-cros-aoa driver

2019-08-28 Thread Dan Williams
On Wed, 2019-08-28 at 12:17 -0400, Alan Stern wrote: > On Tue, 27 Aug 2019, Julius Werner wrote: > > > This patch adds a new "unusual" USB mass storage device driver. This > > driver will be used for a virtual USB storage device presented by an > > Android phone running the 'Chrome OS Recovery'*

[PATCH v2 3/3] libnvdimm/security: Consolidate 'security' operations

2019-08-26 Thread Dan Williams
with the helpers. Acked-by: Jeff Moyer Reviewed-by: Dave Jiang Signed-off-by: Dan Williams --- drivers/nvdimm/dimm_devs.c | 84 - drivers/nvdimm/nd-core.h | 30 +-- drivers/nvdimm/security.c | 90

[PATCH v2 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups

2019-08-26 Thread Dan Williams
vdimm/2019-August/022856.html --- Dan Williams (3): libnvdimm/security: Introduce a 'frozen' attribute libnvdimm/security: Tighten scope of nvdimm->busy vs security operations libnvdimm/security: Consolidate 'security' operations drivers/acpi/nfit/intel.c| 59 ++-

[PATCH v2 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations

2019-08-26 Thread Dan Williams
rdless of busy state. Reviewed-by: Dave Jiang Signed-off-by: Dan Williams --- drivers/nvdimm/dimm_devs.c | 33 - drivers/nvdimm/security.c | 10 -- 2 files changed, 16 insertions(+), 27 deletions(-) diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/

[PATCH v2 1/3] libnvdimm/security: Introduce a 'frozen' attribute

2019-08-26 Thread Dan Williams
is that communicating 'frozen' is mostly a helper for debug and status monitoring. Reviewed-by: Dave Jiang Reported-by: Jeff Moyer Signed-off-by: Dan Williams --- drivers/acpi/nfit/intel.c| 59 --- drivers/nvdimm/bus.c |2 - drivers/nvdimm/dimm_devs.c

Re: [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range()

2019-08-26 Thread Dan Williams
[ add Jan ] On Mon, Aug 26, 2019 at 1:58 PM Vivek Goyal wrote: > > On Mon, Aug 26, 2019 at 04:33:26PM -0400, Vivek Goyal wrote: > > On Mon, Aug 26, 2019 at 04:53:16AM -0700, Christoph Hellwig wrote: > > > On Wed, Aug 21, 2019 at 01:57:03PM -0400, Vivek Goyal wrote: > > > > Right now

Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap

2019-08-21 Thread Dan Williams
On Wed, Aug 21, 2019 at 4:51 PM Jason Gunthorpe wrote: > > On Wed, Aug 21, 2019 at 01:24:20PM -0300, Jason Gunthorpe wrote: > > On Tue, Aug 20, 2019 at 07:58:22PM -0700, Dan Williams wrote: > > > On Tue, Aug 20, 2019 at 6:27 AM Jason Gunthorpe wrote: > > > > >

Re: kernel panic in 5.3-rc5, nfsd_reply_cache_stats_show+0x11

2019-08-20 Thread Dan Williams
On Tue, Aug 20, 2019 at 6:39 PM wrote: > > Hi, > > Apology if there is a better channel reporting the issue, if so, please > let me know. > > I just saw below regression in 5.3-rc5 kernel, but not in 5.2-rc7 or > earlier kernels. Is the error stable enough to bisect?

Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap

2019-08-20 Thread Dan Williams
On Tue, Aug 20, 2019 at 6:27 AM Jason Gunthorpe wrote: > > On Mon, Aug 19, 2019 at 06:44:02PM -0700, Dan Williams wrote: > > On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig wrote: > > > > > > The dev field in struct dev_pagemap is only used to print dev_n

Re: [PATCH 1/4] resource: add a not device managed request_free_mem_region variant

2019-08-19 Thread Dan Williams
On Mon, Aug 19, 2019 at 7:26 PM Christoph Hellwig wrote: > > On Mon, Aug 19, 2019 at 06:28:30PM -0700, Dan Williams wrote: > > > > Previously we would loudly crash if someone passed NULL to > > devm_request_free_mem_region(), but now it will silently work and the >

Re: [PATCH 4/4] memremap: provide a not device managed memremap_pages

2019-08-19 Thread Dan Williams
ellwig > Reviewed-by: Ira Weiny Looks good, Reviewed-by: Dan Williams

Re: [PATCH 3/4] memremap: don't use a separate devm action for devmap_managed_enable_get

2019-08-19 Thread Dan Williams
eviewed-by: Ira Weiny Looks good, Reviewed-by: Dan Williams

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-19 Thread Dan Williams
On Mon, Aug 19, 2019 at 9:30 AM Stephen Douthit wrote: > > On 8/14/19 1:17 PM, Dan Williams wrote: > >> Can you get someone from the controller design team to give us a clear > >> answer on a revision where this PCS change happened? > >> > >&g

Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap

2019-08-19 Thread Dan Williams
ellwig > Reviewed-by: Ira Weiny Needs the below as well. /me goes to check if he ever merged the fix to make the unit test stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't submit it for 5.3-rc1, sorry for the thrash. You can otherwise add: Reviewed-by: Dan Williams [1]: ht

Re: [PATCH 1/4] resource: add a not device managed request_free_mem_region variant

2019-08-19 Thread Dan Williams
VICE > + * memory, which in turn allocates struct pages. > + */ > +struct resource *devm_request_free_mem_region(struct device *dev, > + struct resource *base, unsigned long size) > +{ Previously we would loudly crash if someone passed NULL to devm_request_free_mem_region(), but now it will silently work and the result will leak. Perhaps this wants a: if (!dev) return NULL; ...to head off those mistakes? No major heartburn if you keep it as is, you can add: Reviewed-by: Dan Williams

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-17 Thread Dan Williams
On Sat, Aug 17, 2019 at 4:13 AM Qian Cai wrote: > > > > > On Aug 16, 2019, at 11:57 PM, Dan Williams wrote: > > > > On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: > >> > >> > >> > >>> On Aug 16, 2019, at 5:48 PM, Dan Williams

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Dan Williams
On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: > > > > > On Aug 16, 2019, at 5:48 PM, Dan Williams wrote: > > > > On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: > >> > >> Every so often recently, booting Intel CPU server on linux-next triggers

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Dan Williams
On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: > > Every so often recently, booting Intel CPU server on linux-next triggers this > warning. Trying to figure out if the commit 7cc7867fb061 > ("mm/devm_memremap_pages: enable sub-section remap") is the culprit here. > > # ./scripts/faddr2line

Re: [PATCH 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations

2019-08-16 Thread Dan Williams
On Fri, Aug 16, 2019 at 1:49 PM Jeff Moyer wrote: > > Dan Williams writes: > > > The blanket blocking of all security operations while the DIMM is in > > active use in a region is too restrictive. The only security operations > > that need to be aware of the ->bu

Re: [PATCH] libnvdimm: change disk name of virtio pmem disk

2019-08-15 Thread Dan Williams
On Wed, Jul 31, 2019 at 4:12 AM Pankaj Gupta wrote: > > This patch adds prefix 'v' in disk name for virtio pmem. > This differentiates virtio-pmem disks from the pmem disks. I don't think the small matter that this device does not support MAP_SYNC warrants a separate naming scheme. That said I

[PATCH 3/3] libnvdimm/security: Consolidate 'security' operations

2019-08-14 Thread Dan Williams
with the helpers. Cc: Dave Jiang Signed-off-by: Dan Williams --- drivers/nvdimm/dimm_devs.c | 84 - drivers/nvdimm/nd-core.h | 30 +-- drivers/nvdimm/security.c | 90 ++-- 3 files changed, 90

[PATCH 1/3] libnvdimm/security: Introduce a 'frozen' attribute

2019-08-14 Thread Dan Williams
is that communicating 'frozen' is mostly a helper for debug and status monitoring. Cc: Dave Jiang Reported-by: Jeff Moyer Signed-off-by: Dan Williams --- drivers/acpi/nfit/intel.c| 65 ++--- drivers/nvdimm/bus.c |2 - drivers/nvdimm/dimm_devs.c | 59

[PATCH 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations

2019-08-14 Thread Dan Williams
pplied at the entry common entry point in __security_store() rather than each of the helper routines. Cc: Dave Jiang Signed-off-by: Dan Williams --- drivers/nvdimm/dimm_devs.c | 33 - drivers/nvdimm/security.c | 10 -- 2 files changed, 16 insertions(

[PATCH 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups

2019-08-14 Thread Dan Williams
/pipermail/linux-nvdimm/2019-August/022856.html --- Dan Williams (3): libnvdimm/security: Introduce a 'frozen' attribute libnvdimm/security: Tighten scope of nvdimm->busy vs security operations libnvdimm/security: Consolidate 'security' operations drivers/acpi/nfit/intel.c

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Dan Williams
On Wed, Aug 14, 2019 at 9:54 AM Stephen Douthit wrote: > > On 8/14/19 12:09 PM, Dan Williams wrote: > > On Wed, Aug 14, 2019 at 7:34 AM Stephen Douthit > > wrote: > >> > >> On 8/13/19 6:07 PM, Dan Williams wrote: > >>> On Tue, Aug 13,

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Dan Williams
On Wed, Aug 14, 2019 at 7:34 AM Stephen Douthit wrote: > > On 8/13/19 6:07 PM, Dan Williams wrote: > > On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig > > wrote: > >> > >> On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > >>> I

Re: [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk

2019-08-14 Thread Dan Williams
On Wed, Aug 14, 2019 at 6:28 AM Jason Gunthorpe wrote: > > On Wed, Aug 14, 2019 at 09:38:54AM +0200, Christoph Hellwig wrote: > > On Tue, Aug 13, 2019 at 06:36:33PM -0700, Dan Williams wrote: > > > Section alignment constraints somewhat save us here. The only example >

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-13 Thread Dan Williams
On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig wrote: > > On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > > It seems platforms / controllers that fail to run the option-rom > > should be quirked by device-id, but the PCS register twiddling be > > r

Re: [PATCH v5 3/6] mm: Use zone and order instead of free area in free_list manipulators

2019-08-12 Thread Dan Williams
ve the zone defined before we define the > list manipulation functions. Independent of the code movement for the zone declaration this looks like a nice cleanup of the calling convention. Reviewed-by: Dan Williams

Re: [PATCH v5 1/6] mm: Adjust shuffle code to allow for future coalescing

2019-08-12 Thread Dan Williams
On Mon, Aug 12, 2019 at 2:33 PM Alexander Duyck wrote: > > From: Alexander Duyck > > This patch is meant to move the head/tail adding logic out of the shuffle s/This patch is meant to move/Move/ > code and into the __free_one_page function since ultimately that is where > it is really needed

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Dan Williams
On Mon, Aug 12, 2019 at 11:08 AM Christoph Hellwig wrote: > > On Mon, Aug 12, 2019 at 05:49:29PM +, Stephen Douthit wrote: > > Does anyone know the background of the original PCS workaround? > > Based on a few git-blame iterations on history.git the original PCS > handling (just when

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Dan Williams
On Mon, Aug 12, 2019 at 6:03 AM Stephen Douthit wrote: > > On 8/10/19 3:43 AM, Christoph Hellwig wrote: > > On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: > >> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > >> reason, so now we get to check the device ID

[GIT PULL] dax fixes v5.3-rc4

2019-08-11 Thread Dan Williams
) dax fixes v5.3-rc4 - Fix dax_layout_busy_page() to not discard private cow pages of fs/dax private mappings. - Update the memremap_pages core to properly cleanup on behalf of internal reference-count users like device-dax. Dan

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-10 Thread Dan Williams
On Sat, Aug 10, 2019 at 12:43 AM Christoph Hellwig wrote: > > On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: > > Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > > reason, so now we get to check the device ID before poking it on reset. > > And now you just

Re: [PATCH 1/7] [RFC] ARM: remove Intel iop33x and iop13xx support

2019-08-09 Thread Dan Williams
On Fri, Aug 9, 2019 at 11:37 AM Russell King - ARM Linux admin wrote: > > On Fri, Aug 09, 2019 at 11:34:12AM -0700, Dan Williams wrote: > > [ add Martin (if cyrius.com address is still valid) ] > > > > On Fri, Aug 9, 2019 at 9:35 AM Arnd Bergmann wrote: > > &g

Re: [PATCH 1/7] [RFC] ARM: remove Intel iop33x and iop13xx support

2019-08-09 Thread Dan Williams
ave not followed this space in years hence copying Martin. In any event: Acked-by: Dan Williams

Re: Resend [PATCH] kernel/resource.c: invalidate parent when freed resource has childs

2019-08-09 Thread Dan Williams
On Fri, Aug 9, 2019 at 6:50 AM Schmid, Carsten wrote: > > When a resource is freed and has children, the childrens are > left without any hint that their parent is no more valid. > This caused at least one use-after-free in the xhci-hcd using > ext-caps driver when platform code released platform

Re: [PATCH v4 2/2] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if mmaped more than once

2019-08-06 Thread Dan Williams
corrupted page > => to deliver SIGKILL > Memory failure: 0xedbe201: Killing read_poison:22434 due to hardware memory > corruption > => to deliver SIGBUS > > Signed-off-by: Jane Chu > Suggested-by: Naoya Horiguchi Looks good, ignore the checkpatch warning about too long subject line, looks appropriate to me: Reviewed-by: Dan Williams

Re: [PATCH v4 1/2] mm/memory-failure.c clean up around tk pre-allocation

2019-08-06 Thread Dan Williams
return; > } checkpatch points out that this error message can be deleted. According to the commit that added this check (ebfdc40969f2 "checkpatch: attempt to find unnecessary 'out of memory' messages") the kernel already prints a message and a backtrace on these eve

Re: [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-08-06 Thread Dan Williams
On Mon, Aug 5, 2019 at 11:47 PM Michal Hocko wrote: > > On Mon 05-08-19 20:27:03, Dan Williams wrote: > > On Sun, Aug 4, 2019 at 10:31 PM Toshiki Fukasawa > > wrote: > > > > > > On 2019/07/26 16:06, Michal Hocko wrote: > > > >

Re: [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-08-05 Thread Dan Williams
On Wed, Jul 24, 2019 at 7:46 PM Toshiki Fukasawa wrote: > > A kernel panic was observed during reading /proc/kpageflags for > first few pfns allocated by pmem namespace: > > BUG: unable to handle page fault for address: fffe > [ 114.495280] #PF: supervisor read access in kernel mode

Re: [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-08-05 Thread Dan Williams
On Sun, Aug 4, 2019 at 10:31 PM Toshiki Fukasawa wrote: > > On 2019/07/26 16:06, Michal Hocko wrote: > > On Fri 26-07-19 06:25:49, Toshiki Fukasawa wrote: > >> > >> > >> On 2019/07/25 18:03, Michal Hocko wrote: > >>> On Thu 25-07-19 02:31:18, Toshiki Fukasawa wrote: > A kernel panic was

Re: [PATCH 4.19 112/113] libnvdimm/bus: Stop holding nvdimm_bus_list_mutex over __nd_ioctl()

2019-07-31 Thread Dan Williams
On Wed, Jul 31, 2019 at 11:15 AM Pavel Machek wrote: > > On Mon 2019-07-29 21:23:19, Greg Kroah-Hartman wrote: > > From: Dan Williams > > > > commit b70d31d054ee3a6fc1034b9d7fc0ae1e481aa018 upstream. > > > > In preparation for fixing a dead

[GIT PULL] dax fix for v5.3-rc3

2019-07-30 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm dax-fix-5.3-rc3 ...to receive a manual fixup I happened to drop. I re-fetched the patch from the mailing list after integrating the git message-id support to generate a "Link:" tag [1], but then did not

Re: [PATCH v5 13/29] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-07-30 Thread Dan Williams
dimm_ioctl, > - .compat_ioctl = dimm_ioctl, > + .compat_ioctl = compat_ptr_ioctl, > .llseek = noop_llseek, > }; Acked-by: Dan Williams

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-29 Thread Dan Williams
On Mon, Jul 29, 2019 at 5:02 AM Jan Kara wrote: > > On Tue 16-07-19 20:39:46, Dan Williams wrote: > > On Fri, Jul 12, 2019 at 2:14 AM Jan Kara wrote: > > > > > > On Thu 11-07-19 08:25:50, Matthew Wilcox wrote: > > > > On Thu, Jul 11, 2019

[GIT PULL] libnvdimm fixes for 5.3-rc2

2019-07-26 Thread Dan Williams
device-core infrastructure to coordinate async operations via the device ->dead state. - Add device-core infrastructure to validate device_lock() usage with lockdep. ---- Dan Williams (7): drivers/base: Introduce kill_dev

Re: [PATCH v2 0/1] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue

2019-07-24 Thread Dan Williams
On Wed, Jul 24, 2019 at 3:35 PM Jane Chu wrote: > > Changes in v2: > - move 'tk' allocations internal to add_to_kill(), suggested by Dan; Oh, sorry if it wasn't clear, this should move to its own patch that only does the cleanup, and then the follow on fix patch becomes smaller and more

Re: [PATCH v2 4/5] mm,memory_hotplug: allocate memmap from the added memory range for sparse-vmemmap

2019-07-24 Thread Dan Williams
On Tue, Jun 25, 2019 at 12:53 AM Oscar Salvador wrote: > > Physical memory hotadd has to allocate a memmap (struct page array) for > the newly added memory section. Currently, alloc_pages_node() is used > for those allocations. > > This has some disadvantages: > a) an existing memory is consumed

Re: [PATCH v2 2/5] mm,memory_hotplug: Introduce MHP_VMEMMAP_FLAGS

2019-07-24 Thread Dan Williams
llows us to have flexibility when removing > the > memory. Concept and patch looks good to me, but I don't quite like the proliferation of the _DEVICE naming, in theory it need not necessarily be ZONE_DEVICE that is the only user of that flag. I also think it might be useful to assign a flag for the d

Re: [PATCH] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if mmaped more than once

2019-07-23 Thread Dan Williams
On Tue, Jul 23, 2019 at 4:49 PM Jane Chu wrote: > > Mmap /dev/dax more than once, then read the poison location using address > from one of the mappings. The other mappings due to not having the page > mapped in will cause SIGKILLs delivered to the process. SIGKILL succeeds > over SIGBUS, so user

Re: [PATCH] memremap: move from kernel/ to mm/

2019-07-22 Thread Dan Williams
On Mon, Jul 22, 2019 at 2:42 AM Christoph Hellwig wrote: > > memremap.c implements MM functionality for ZONE_DEVICE, so it really > should be in the mm/ directory, not the kernel/ one. > > Signed-off-by: Christoph Hellwig Acked-by: Dan Williams

Re: [patch 23/38] mm/sparsemem: introduce struct mem_section_usage

2019-07-19 Thread Dan Williams
On Fri, Jul 19, 2019 at 9:42 AM Linus Torvalds wrote: > > On Thu, Jul 18, 2019 at 11:13 PM Michal Hocko wrote: > > > > Has this been properly reviewed after the last rebase and is this > > actually ready for merging? I have seen some follow up fixes > >

[GIT PULL] dax for 5.3

2019-07-18 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/dax-for-5.3 ...to receive the fruits of a bug hunt in the fsdax implementation with Willy and a small feature update for device-dax. These have appeared in a -next release with no reported issues. ---

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-18 Thread Dan Williams
On Thu, Jul 18, 2019 at 6:15 AM Vivek Goyal wrote: > > On Wed, Jul 17, 2019 at 07:27:25PM +0200, Halil Pasic wrote: > > On Wed, 15 May 2019 15:27:03 -0400 > > Vivek Goyal wrote: > > > > > From: Stefan Hajnoczi > > > > > > Setup a dax device. > > > > > > Use the shm capability to find the cache

Re: HMM_MIRROR has less than useful help text

2019-07-18 Thread Dan Williams
On Thu, Jul 18, 2019 at 4:04 AM Balbir Singh wrote: > > On Wed, Jul 17, 2019 at 5:41 PM Pavel Machek wrote: > > > > Hi! > > > > Commit c0b124054f9e42eb6da545a10fe9122a7d7c3f72 has very nice commit > > message, explaining what HMM_MIRROR is and when it is > > needed. Unfortunately, it did not

[GIT PULL] libnvdimm for 5.3

2019-07-18 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-for-5.3 ...to receive primarily just the virtio_pmem driver for v5.3-rc1. The lateness is attributed to me being out last week, and a last minute regression hunt in a pending fix / rework of

Re: [PATCH v2 6/7] libnvdimm/bus: Fix wait_nvdimm_bus_probe_idle() ABBA deadlock

2019-07-18 Thread Dan Williams
On Wed, Jul 17, 2019 at 7:05 PM Sasha Levin wrote: > > On Wed, Jul 17, 2019 at 06:08:21PM -0700, Dan Williams wrote: > >A multithreaded namespace creation/destruction stress test currently > >deadlocks with the following lockup signature: > > > >INFO: task ndctl:

Re: RFC: move kernel/memremap.c to mm/

2019-07-18 Thread Dan Williams
On Wed, Jul 17, 2019 at 10:49 PM Christoph Hellwig wrote: > > Hi Dan, > > was there any really good reason to have memremap.c in kernel/ back > when you started it? It seems to be pretty much tried into the mm > infrastructure, and I keep mistyping the path. Would you mind a simple > git-mv

[PATCH v2 7/7] driver-core, libnvdimm: Let device subsystems add local lockdep coverage

2019-07-17 Thread Dan Williams
J. Wysocki" Cc: Greg Kroah-Hartman Signed-off-by: Dan Williams --- drivers/acpi/nfit/core.c| 28 drivers/acpi/nfit/nfit.h| 24 ++ drivers/base/core.c |3 ++ drivers/nvdimm/btt_devs.c | 16 + drivers/nvdimm/bus

[PATCH v2 6/7] libnvdimm/bus: Fix wait_nvdimm_bus_probe_idle() ABBA deadlock

2019-07-17 Thread Dan Williams
tion") Cc: Vishal Verma Tested-by: Jane Chu Signed-off-by: Dan Williams --- drivers/nvdimm/bus.c | 14 +- drivers/nvdimm/region_devs.c |4 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index a38572bf486

[PATCH v2 1/7] drivers/base: Introduce kill_device()

2019-07-17 Thread Dan Williams
does not change any behavior, but it is a pre-requisite for follow-on fixes and therefore marked for -stable. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Fixes: 4d88a97aa9e8 ("libnvdimm, nvdimm: dimm driver and base libnvdimm device-driver...") Cc: Tested-by: Jane Chu

<    6   7   8   9   10   11   12   13   14   15   >