[PATCH] ACPI: NFIT: Fix flexible_array.cocci warnings

2021-01-05 Thread Dan Williams
member in a struct with no named members drivers/acpi/nfit/core.c:2287:4: error: flexible array member in a struct with no named members Instead, just use plain arrays not embedded a flexible arrays. Cc: Denis Efremov Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Dan

[tip: x86/urgent] x86/mm: Fix leak of pmd ptlock

2021-01-05 Thread tip-bot2 for Dan Williams
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: d1c5246e08eb64991001d97a3bd119c93edbc79a Gitweb: https://git.kernel.org/tip/d1c5246e08eb64991001d97a3bd119c93edbc79a Author:Dan Williams AuthorDate:Wed, 02 Dec 2020 22:28:12 -08:00

[tip: x86/urgent] x86/mm: Fix leak of pmd ptlock

2021-01-05 Thread tip-bot2 for Dan Williams
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 1bd3d9c593211e09771562b464028d3ab7e05b3a Gitweb: https://git.kernel.org/tip/1bd3d9c593211e09771562b464028d3ab7e05b3a Author:Dan Williams AuthorDate:Wed, 02 Dec 2020 22:28:12 -08:00

Re: uninitialized pmem struct pages

2021-01-05 Thread Dan Williams
On Tue, Jan 5, 2021 at 1:37 AM David Hildenbrand wrote: > > >> Yeah, obviously the first one. Being able to add+use PMEM is more > >> important than using each and every last MB of main memory. > >> > >> I wonder if we can just stop adding any system RAM like > >> > >> [ Memory Section] >

Re: uninitialized pmem struct pages

2021-01-05 Thread Dan Williams
On Tue, Jan 5, 2021 at 1:25 AM David Hildenbrand wrote: > > On 05.01.21 06:17, Dan Williams wrote: > > On Mon, Jan 4, 2021 at 2:45 AM David Hildenbrand wrote: > >> > >> On 04.01.21 11:03, Michal Hocko wrote: > >>> Hi, > >>> back in March [1]

Re: uninitialized pmem struct pages

2021-01-05 Thread Dan Williams
On Tue, Jan 5, 2021 at 12:42 AM Michal Hocko wrote: > > On Tue 05-01-21 00:27:34, Dan Williams wrote: > > On Tue, Jan 5, 2021 at 12:17 AM Michal Hocko wrote: > > > > > > On Tue 05-01-21 09:01:00, Michal Hocko wrote: > > > > On Mon 04-01-21 16:44:52, Davi

Re: uninitialized pmem struct pages

2021-01-05 Thread Dan Williams
On Tue, Jan 5, 2021 at 12:17 AM Michal Hocko wrote: > > On Tue 05-01-21 09:01:00, Michal Hocko wrote: > > On Mon 04-01-21 16:44:52, David Hildenbrand wrote: > > > On 04.01.21 16:43, David Hildenbrand wrote: > > > > On 04.01.21 16:33, Michal Hocko wrote: > > > >> On Mon 04-01-21 16:15:23, David

Re: [PATCH] arm64: add pmem module for kernel update

2021-01-04 Thread Dan Williams
Hi Zhuling, On Wed, Dec 30, 2020 at 10:18 PM Zhuling wrote: > > Category: feature > Bugzilla: NA > CVE: NA These tags can be dropped. > > Use reserved memory to create a pmem device to store the > processes information that dumped before kernel update. > When you want to use this feature you

Re: uninitialized pmem struct pages

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 7:59 AM Michal Hocko wrote: > > On Mon 04-01-21 16:43:49, David Hildenbrand wrote: > > On 04.01.21 16:33, Michal Hocko wrote: > > > On Mon 04-01-21 16:15:23, David Hildenbrand wrote: > > >> On 04.01.21 16:10, Michal Hocko wrote: > > > [...] > > >> Do the physical addresses

Re: uninitialized pmem struct pages

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 2:45 AM David Hildenbrand wrote: > > On 04.01.21 11:03, Michal Hocko wrote: > > Hi, > > back in March [1] you have recommended 53cdc1cb29e8 > > ("drivers/base/memory.c: indicate all memory blocks as removable") to be > > backported to stable trees and that has led to a more

Re: [PATCH] x86/mm: Fix leak of pmd ptlock

2021-01-04 Thread Dan Williams
Ping, this bug is still present on v5.11-rc2, need a resend? On Wed, Dec 2, 2020 at 10:28 PM Dan Williams wrote: > > Commit 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces") > introduced a new location where a pmd was released, but neglected to run > t

Re: [PATCH v2] fs/dax: include to fix build error on ARC

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 7:47 PM Randy Dunlap wrote: > > On 1/4/21 12:13 PM, Dan Williams wrote: > > On Thu, Dec 31, 2020 at 8:29 PM Randy Dunlap wrote: > >> > >> fs/dax.c uses copy_user_page() but ARC does not provide that interface, > >> result

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 5:53 PM Jason Gunthorpe wrote: > > On Mon, Jan 04, 2021 at 04:51:51PM -0800, Dan Williams wrote: > > On Mon, Jan 4, 2021 at 4:14 PM Jason Gunthorpe wrote: > > > > > > On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: &g

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 4:14 PM Jason Gunthorpe wrote: > > On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: > > > > > Regardless of the shortcut to make everything a struct > > > platform_device, I think it was a mistake to put OF devices on > > > platform_bus. Those should have

Re: [RFC v2 PATCH 4/4] mm: pre zero out free pages to speed up page allocation for __GFP_ZERO

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 12:11 PM David Hildenbrand wrote: > > > > Am 04.01.2021 um 20:52 schrieb Dave Hansen : > > > > On 1/4/21 11:27 AM, Matthew Wilcox wrote: > >>> On Mon, Jan 04, 2021 at 11:19:13AM -0800, Dave Hansen wrote: > >>> On 12/21/20 8:30 AM, Liang Li wrote: > ---

Re: [PATCH v2] fs/dax: include to fix build error on ARC

2021-01-04 Thread Dan Williams
ted-by: kernel test robot > Signed-off-by: Randy Dunlap > Cc: Vineet Gupta > Cc: linux-snps-...@lists.infradead.org > Cc: Dan Williams > Acked-by: Vineet Gupta > Cc: Andrew Morton > Cc: Matthew Wilcox > Cc: Jan Kara > Cc: linux-fsde...@vger.kernel.org > Cc: linux

Re: [RFC v2 PATCH 4/4] mm: pre zero out free pages to speed up page allocation for __GFP_ZERO

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 11:28 AM Matthew Wilcox wrote: > > On Mon, Jan 04, 2021 at 11:19:13AM -0800, Dave Hansen wrote: > > On 12/21/20 8:30 AM, Liang Li wrote: > > > --- a/include/linux/page-flags.h > > > +++ b/include/linux/page-flags.h > > > @@ -137,6 +137,9 @@ enum pageflags { > > > #endif >

[GIT PULL] libnvdimm for v5.11

2020-12-24 Thread Dan Williams
in the ioctl path - Miscellaneous cleanups Dan Williams (4): libnvdimm/namespace: Fix reaping of invalidated block-window-namespace labels ACPI: NFIT: Fix input validation of bus-family device-dax: Fix range release

Re: [PATCH] ACPI: NFIT: fix flexible_array.cocci warnings

2020-12-24 Thread Dan Williams
On Tue, Dec 22, 2020 at 1:10 PM Julia Lawall wrote: > > From: kernel test robot > > Zero-length and one-element arrays are deprecated, see > Documentation/process/deprecated.rst > Flexible-array members should be used instead. > > Generated by: scripts/coccinelle/misc/flexible_array.cocci > >

Re: [PATCH] device-dax: Fix range release

2020-12-19 Thread Dan Williams
On Fri, Dec 18, 2020 at 11:46 PM Leizhen (ThunderTown) wrote: > > > > On 2020/12/19 10:41, Dan Williams wrote: > > There are multiple locations that open-code the release of the last > > range in a device-dax instance. Consolidate this into a new > > dev_dax_trim_ran

[PATCH] device-dax: Fix range release

2020-12-18 Thread Dan Williams
[<53e5659b>] bind_store+0xb7/0xc3 [<d3bdaadc>] drv_attr_store+0x27/0x31 [<949069c5>] sysfs_kf_write+0x4a/0x57 [<4a8b5adf>] kernfs_fop_write+0x150/0x1e5 [<bded60f0>] __vfs_write+0x1b/0x34 [<00

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-18 Thread Dan Williams
On Fri, Dec 18, 2020 at 1:17 PM Alexandre Belloni wrote: > > On 18/12/2020 16:58:56-0400, Jason Gunthorpe wrote: > > On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote: > > > > > > So, I strongly suspect, MFD should create mfd devices on a MFD bus > > > > type. > > > > > > Historically

Re: [PATCH V3 04/10] x86/pks: Preserve the PKRS MSR on context switch

2020-12-18 Thread Dan Williams
On Fri, Dec 18, 2020 at 1:06 PM Thomas Gleixner wrote: > > On Fri, Dec 18 2020 at 11:20, Dan Williams wrote: > > On Fri, Dec 18, 2020 at 5:58 AM Thomas Gleixner wrote: > > [..] > >> 5) The DAX case which you made "work" with dev_access_enable() and > >

Re: [PATCH V3 04/10] x86/pks: Preserve the PKRS MSR on context switch

2020-12-18 Thread Dan Williams
On Fri, Dec 18, 2020 at 5:58 AM Thomas Gleixner wrote: [..] > 5) The DAX case which you made "work" with dev_access_enable() and > dev_access_disable(), i.e. with yet another lazy approach of > avoiding to change a handful of usage sites. > > The use cases are strictly context

Re: [PATCH V3 10/10] x86/pks: Add PKS test code

2020-12-18 Thread Dan Williams
On Thu, Dec 17, 2020 at 8:05 PM Ira Weiny wrote: > > On Thu, Dec 17, 2020 at 12:55:39PM -0800, Dave Hansen wrote: > > On 11/6/20 3:29 PM, ira.we...@intel.com wrote: > > > + /* Arm for context switch test */ > > > + write(fd, "1", 1); > > > + > > > + /* Context switch

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-17 Thread Dan Williams
[ add Neil, original gooodguy who wrote badblocks ] On Thu, Dec 3, 2020 at 9:16 AM Coly Li wrote: > > Recently I received a bug report that current badblocks code does not > properly handle multiple ranges. For example, > badblocks_set(bb, 32, 1, true); > badblocks_set(bb, 34,

Re: [PATCH 1/1] device-dax: avoid an unnecessary check in alloc_dev_dax_range()

2020-12-17 Thread Dan Williams
On Fri, Nov 20, 2020 at 1:23 AM Zhen Lei wrote: > > Swap the calling sequence of krealloc() and __request_region(), call the > latter first. In this way, the value of dev_dax->nr_range does not need to > be considered when __request_region() failed. This looks ok, but I think I want to see

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-17 Thread Dan Williams
On Thu, Dec 17, 2020 at 1:20 PM Alexandre Belloni wrote: > > Hello, > > On 05/12/2020 16:51:36+0100, Greg KH wrote: > > > To me, the documentation was written, and reviewed, more from the > > > perspective of "why not open code a custom bus instead". So I can see > > > after the fact how that is

Re: [PATCH 1/1] device-dax: delete a redundancy check in dev_dax_validate_align()

2020-12-17 Thread Dan Williams
On Fri, Nov 20, 2020 at 1:27 AM Leizhen (ThunderTown) wrote: > > > > On 2020/11/20 17:20, Zhen Lei wrote: > > After we have done the alignment check for the length of each range, the > > alignment check for dev_dax_size(dev_dax) is no longer needed, because it > > get the sum of the length of

Re: [RFC PATCH 0/8] x86: Support Intel Key Locker

2020-12-17 Thread Dan Williams
On Thu, Dec 17, 2020 at 11:11 AM Eric Biggers wrote: > > On Wed, Dec 16, 2020 at 09:41:38AM -0800, Chang S. Bae wrote: > > [1] Intel Architecture Instruction Set Extensions Programming Reference: > > > >

Re: [PATCH] dax: fix memory leak when rmmod dax.ko

2020-12-15 Thread Dan Williams
On Tue, Dec 1, 2020 at 5:54 AM Wang Hai wrote: > > When I repeatedly modprobe and rmmod dax.ko, kmemleak report a > memory leak as follows: > > unreferenced object 0x9a5588c05088 (size 8): > comm "modprobe", pid 261, jiffies 4294693644 (age 42.063s) > ... > backtrace: >

Re: [PATCH -next] dax: pmem: convert comma to semicolon

2020-12-15 Thread Dan Williams
On Mon, Dec 14, 2020 at 5:45 AM Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Thanks, applied.

Re: [PATCH] drivers: nvdimm: cleanup include of badblocks.h

2020-12-15 Thread Dan Williams
On Tue, Dec 15, 2020 at 8:36 AM Enrico Weigelt, metux IT consult wrote: > > * drivers/nvdimm/core.c doesn't use anything from badblocks.h on its own, > thus including it isn't needed. There's indeed indirect use, via funcs > in nd.h, but this one already includes badblocks.h. > > *

Re: [PATCH] x86/mm: Fix leak of pmd ptlock

2020-12-15 Thread Dan Williams
Might I tempt an x86/mm maintainer to ack this, or a x86-tip maintainer to apply it outright? On Wed, Dec 2, 2020 at 10:28 PM Dan Williams wrote: > > Commit 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces") > introduced a new location where a pmd was released, b

Re: [RFC PATCH 10/14] cxl/mem: Add send command

2020-12-15 Thread Dan Williams
On Tue, Dec 15, 2020 at 1:44 PM Ben Widawsky wrote: [..] > > > +static int handle_mailbox_cmd_from_user(struct cxl_memdev *cxlmd, > > > + const struct cxl_mem_command *cmd, > > > + struct cxl_send_command __user *u) > > >

Re: [PATCH v17 3/3] bus: mhi: Add userspace client interface driver

2020-12-11 Thread Dan Williams
On Fri, 2020-12-11 at 08:44 +0100, Greg KH wrote: > On Thu, Dec 10, 2020 at 11:04:11PM -0800, Hemant Kumar wrote: > > This MHI client driver allows userspace clients to transfer > > raw data between MHI device and host using standard file > > operations. > > Driver instantiates UCI device object

Re: [RFC PATCH 04/15] lib/scatterlist: Add flag for indicating P2PDMA segments in an SGL

2020-12-09 Thread Dan Williams
On Wed, Dec 9, 2020 at 6:07 PM Logan Gunthorpe wrote: > > > > On 2020-12-09 6:22 p.m., Dan Williams wrote: > > On Mon, Nov 9, 2020 at 8:47 AM Logan Gunthorpe wrote: > >> > >> > >> > >> On 2020-11-09 2:12 a.m., Christoph Hellwig wrote:

Re: [RFC PATCH 04/15] lib/scatterlist: Add flag for indicating P2PDMA segments in an SGL

2020-12-09 Thread Dan Williams
On Mon, Nov 9, 2020 at 8:47 AM Logan Gunthorpe wrote: > > > > On 2020-11-09 2:12 a.m., Christoph Hellwig wrote: > > On Fri, Nov 06, 2020 at 10:00:25AM -0700, Logan Gunthorpe wrote: > >> We make use of the top bit of the dma_length to indicate a P2PDMA > >> segment. > > > > I don't think "we" can.

Re: [RFC PATCH 14/14] WIP/cxl/mem: Add get firmware for testing

2020-12-09 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:25 PM Ben Widawsky wrote: > > This also serves as an example how to add a new command > > Signed-off-by: Ben Widawsky > --- > drivers/cxl/mem.c| 22 ++ > include/uapi/linux/cxl_mem.h | 3 ++- > 2 files changed, 24 insertions(+), 1

Re: [RFC PATCH 11/14] cxl/mem: Add a "RAW" send command

2020-12-09 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > The CXL memory device send interface will have a number of supported > commands. The raw command is not such a command. Raw commands allow > userspace to send a specified opcode to the underlying hardware and > bypass all driver checks on the

Re: [RFC PATCH 10/14] cxl/mem: Add send command

2020-12-09 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > The send command allows userspace to issue mailbox commands directly to > the hardware. The driver will verify basic properties of the command but > otherwise pass any input payload untouched to the hardware, and return > the output payload

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-09 Thread Dan Williams
On Wed, Dec 9, 2020 at 12:14 PM Matthew Wilcox wrote: [..] > If we put in into a separate patch, someone will suggest backing out the > patch which tells us that there's a problem. You know, like this guy ... >

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-09 Thread Dan Williams
On Tue, Dec 8, 2020 at 8:03 PM Matthew Wilcox wrote: > > On Tue, Dec 08, 2020 at 06:22:50PM -0800, Ira Weiny wrote: > > Right now we have a mixed bag. zero_user() [and it's variants, circa 2008] > > does a BUG_ON.[0] While the other ones do nothing; clear_highpage(), > > clear_user_highpage(),

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-09 Thread Dan Williams
On Wed, Dec 9, 2020 at 2:31 AM Dan Carpenter wrote: > > On Wed, Dec 09, 2020 at 12:54:30AM -0800, Joe Perches wrote: > > On Wed, 2020-12-09 at 10:58 +0300, Dan Carpenter wrote: > > > On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote: > > > > On Tue, 2020-12-08 at 16:34 -0800, Kees Cook

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 6:13 PM Ben Widawsky wrote: > > On 20-12-08 17:37:50, Dan Williams wrote: > > On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > > > > > Add a straightforward IOCTL that provides a mechanism for userspace to > > > que

Re: [RFC PATCH 12/14] cxl: Add basic debugging

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 6:04 PM Ben Widawsky wrote: > > On 20-12-08 17:17:36, Dan Williams wrote: > > On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > > > > > Provide a standard debug function for use throughout the driver. > > > > > > Signe

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > Add a straightforward IOCTL that provides a mechanism for userspace to > query the supported memory device commands. > > Memory device commands are specified in 8.2.9 of the CXL 2.0 > specification. They are submitted through a mailbox

Re: [RFC PATCH 12/14] cxl: Add basic debugging

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > Provide a standard debug function for use throughout the driver. > > Signed-off-by: Ben Widawsky > --- > drivers/cxl/cxl.h | 3 +++ > drivers/cxl/mem.c | 26 +- > 2 files changed, 28 insertions(+), 1 deletion(-) > >

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 2:49 PM Darrick J. Wong wrote: [..] > > So what's your preferred poison? > > > > 1. Corrupt random data in whatever's been mapped into the next page (which > >is what the helpers currently do) > > Please no. My assertion is that the kernel can't know it's corruption,

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 1:51 PM Matthew Wilcox wrote: > > On Tue, Dec 08, 2020 at 01:32:55PM -0800, Ira Weiny wrote: > > On Mon, Dec 07, 2020 at 03:49:55PM -0800, Dan Williams wrote: > > > On Mon, Dec 7, 2020 at 3:40 PM Matthew Wilcox wrote: > > > > > >

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 1:33 PM Ira Weiny wrote: > > On Mon, Dec 07, 2020 at 03:49:55PM -0800, Dan Williams wrote: > > On Mon, Dec 7, 2020 at 3:40 PM Matthew Wilcox wrote: > > > > > > On Mon, Dec 07, 2020 at 03:34:44PM -0800, Dan Williams wrote: > > > &

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-07 Thread Dan Williams
On Mon, Dec 7, 2020 at 3:40 PM Matthew Wilcox wrote: > > On Mon, Dec 07, 2020 at 03:34:44PM -0800, Dan Williams wrote: > > On Mon, Dec 7, 2020 at 3:27 PM Matthew Wilcox wrote: > > > > > > On Mon, Dec 07, 2020 at 02:57:03PM -0800, ira.we...@intel.com wrote: > >

Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core

2020-12-07 Thread Dan Williams
On Mon, Dec 7, 2020 at 3:27 PM Matthew Wilcox wrote: > > On Mon, Dec 07, 2020 at 02:57:03PM -0800, ira.we...@intel.com wrote: > > +static inline void memcpy_page(struct page *dst_page, size_t dst_off, > > +struct page *src_page, size_t src_off, > > +

Re: [RFC V2 00/37] Enhance memory utilization with DMEMFS

2020-12-07 Thread Dan Williams
On Mon, Dec 7, 2020 at 4:03 AM David Hildenbrand wrote: > > On 07.12.20 12:30, yulei.ker...@gmail.com wrote: > > From: Yulei Zhang > > > > In current system each physical memory page is assocaited with > > a page structure which is used to track the usage of this page. > > But due to the memory

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-05 Thread Dan Williams
On Sat, Dec 5, 2020 at 4:24 PM David Ahern wrote: > > On 12/2/20 5:54 PM, Dan Williams wrote: > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > > index 8d7001712062..040be48ce046 100644 > > --- a/drivers/base/Kconfig > > +++ b/drivers/base/Kconfig &

Re: [RFC PATCH 0/9] CXL 2.0 Support

2020-12-04 Thread Dan Williams
On Fri, Dec 4, 2020 at 11:26 AM Verma, Vishal L wrote: > > On Fri, 2020-12-04 at 10:12 -0800, Ben Widawsky wrote: > > Hi Chris. > > > > On 20-12-04 12:40:03, Chris Browy wrote: > [..] > > > > >acpidump indicates the CXL0 and CXLM devices but no SRAT or HMAT > > > tables are > > >in the

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Dan Williams
On Fri, Dec 4, 2020 at 3:41 AM Greg KH wrote: > > On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote: > > From: Dave Ertman > > > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > > It enables drivers to creat

Re: [RFC PATCH 5/9] cxl/mem: Find device capabilities

2020-12-03 Thread Dan Williams
On Tue, Nov 10, 2020 at 9:44 PM Ben Widawsky wrote: > > CXL devices contain an array of capabilities that describe the > interactions software can interact with the device, or firmware running > on the device. A CXL compliant device must implement the device status > and the mailbox capability. A

Re: [RFC PATCH 5/9] cxl/mem: Find device capabilities

2020-12-03 Thread Dan Williams
On Wed, Nov 25, 2020 at 10:06 PM Jon Masters wrote: > > On 11/11/20 12:43 AM, Ben Widawsky wrote: > > > + case CXL_CAPABILITIES_CAP_ID_SECONDARY_MAILBOX: > > + dev_dbg(>pdev->dev, > > +"found UNSUPPORTED Secondary Mailbox > >

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-12-03 Thread Dan Williams
On Thu, Dec 3, 2020 at 11:22 PM Dan Williams wrote: > > On Tue, Nov 17, 2020 at 6:50 AM Jonathan Cameron > wrote: > > > > On Tue, 10 Nov 2020 21:43:50 -0800 > > Ben Widawsky wrote: > > > > > From: Dan Williams > > > > > > The CXL.

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-12-03 Thread Dan Williams
On Tue, Nov 17, 2020 at 6:50 AM Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:43:50 -0800 > Ben Widawsky wrote: > > > From: Dan Williams > > > > The CXL.mem protocol allows a device to act as a provider of "System > > RAM" and/or "Persist

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-03 Thread Dan Williams
On Thu, Dec 3, 2020 at 6:34 PM Jason Gunthorpe wrote: > > On Thu, Dec 03, 2020 at 04:06:24PM +0100, Greg KH wrote: > > > > ...for all the independent drivers to have a common commit baseline. It > > > is not there yet pending Greg's Ack. > > > > I have been trying to carve out some time to review

[PATCH] x86/mm: Fix leak of pmd ptlock

2020-12-02 Thread Dan Williams
a Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: "H. Peter Anvin" Co-debugged-by: Matthew Wilcox Tested-by: Yi Zhang Signed-off-by: Dan Williams --- arch/x86/mm/pgtable.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/pgtable.c b/a

Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch

2020-12-02 Thread Dan Williams
On Wed, Dec 2, 2020 at 3:44 PM Vlastimil Babka wrote: > > Hi, > > there was a bit of debate on Twitter about this, so I thought I would bring it > here. Imagine a scenario where patch sits as a commit in -next and there's a > bug > report or fix, possibly by a bot or with some static analysis.

[resend/standalone PATCH v4] Add auxiliary bus support

2020-12-02 Thread Dan Williams
-by: Leon Romanovsky Signed-off-by: Dave Ertman Reviewed-by: Pierre-Louis Bossart Reviewed-by: Shiraz Saleem Reviewed-by: Parav Pandit Reviewed-by: Dan Williams Reviewed-by: Martin Habets Link: https://lore.kernel.org/r/20201113161859.1775473-2-david.m.ert...@intel.com Signed-off-by: Dan

Re: mapcount corruption regression

2020-12-02 Thread Dan Williams
On Tue, Dec 1, 2020 at 9:07 PM Dan Williams wrote: > > On Tue, Dec 1, 2020 at 7:43 PM Matthew Wilcox wrote: > > > > On Tue, Dec 01, 2020 at 06:28:45PM -0800, Dan Williams wrote: > > > On Tue, Dec 1, 2020 at 12:49 PM Matthew Wilcox > > > wrote: > > >

Re: mapcount corruption regression

2020-12-01 Thread Dan Williams
On Tue, Dec 1, 2020 at 7:43 PM Matthew Wilcox wrote: > > On Tue, Dec 01, 2020 at 06:28:45PM -0800, Dan Williams wrote: > > On Tue, Dec 1, 2020 at 12:49 PM Matthew Wilcox wrote: > > > > > > On Tue, Dec 01, 2020 at 12:42:39PM -0800, Dan Williams wrote: > >

Re: mapcount corruption regression

2020-12-01 Thread Dan Williams
On Tue, Dec 1, 2020 at 12:49 PM Matthew Wilcox wrote: > > On Tue, Dec 01, 2020 at 12:42:39PM -0800, Dan Williams wrote: > > On Mon, Nov 30, 2020 at 6:24 PM Matthew Wilcox wrote: > > > > > > On Mon, Nov 30, 2020 at 05:20:25PM -0800, Dan Williams wrote: > > >

Re: mapcount corruption regression

2020-12-01 Thread Dan Williams
On Mon, Nov 30, 2020 at 6:24 PM Matthew Wilcox wrote: > > On Mon, Nov 30, 2020 at 05:20:25PM -0800, Dan Williams wrote: > > Kirill, Willy, compound page experts, > > > > I am seeking some debug ideas about the following splat: > > > > BUG: Bad page state in pro

Re: mapcount corruption regression

2020-11-30 Thread Dan Williams
On Mon, Nov 30, 2020 at 5:20 PM Dan Williams wrote: > > Kirill, Willy, compound page experts, > > I am seeking some debug ideas about the following splat: > > BUG: Bad page state in process lt-pmem-ns pfn:121a12 Looks to be a similar signature that Yi Zhang is seeing: http:/

mapcount corruption regression

2020-11-30 Thread Dan Williams
Kirill, Willy, compound page experts, I am seeking some debug ideas about the following splat: BUG: Bad page state in process lt-pmem-ns pfn:121a12 page:51ef73f7 refcount:0 mapcount:-1024 mapping: index:0x0 pfn:0x121a12 flags: 0x28() raw: 0028

[PATCH] ACPI: NFIT: Fix input validation of bus-family

2020-11-23 Thread Dan Williams
-by: Dan Carpenter Fixes: 6450ddbd5d8e ("ACPI: NFIT: Define runtime firmware activation commands") Cc: Signed-off-by: Dan Williams --- drivers/acpi/nfit/core.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/co

Re: arch/powerpc/mm/book3s64/pgtable.c:174:15: error: no previous prototype for 'create_section_mapping'

2020-11-23 Thread Dan Williams
On Mon, Nov 23, 2020 at 6:13 PM kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc > commit: a927bd6ba952d13c52b8b385030943032f659a3e mm: fix > phys_to_target_node() and

Re: [RFC PATCH 4/9] cxl/mem: Map memory device registers

2020-11-23 Thread Dan Williams
On Mon, Nov 23, 2020 at 11:20 AM Ben Widawsky wrote: [..] > > -ENXIO is fine with me. I just don't see it as often so I don't > > really know what it is. > > > > Bjorn > > Dan, Bjorn, I did a fairly randomized look at various probe functions and > ENODEV > seems to be more common. My sort of

[PATCH] libnvdimm/namespace: Fix reaping of invalidated block-window-namespace labels

2020-11-20 Thread Dan Williams
error") Cc: Cc: Vishal Verma Cc: Dave Jiang Cc: Ira Weiny Signed-off-by: Dan Williams --- drivers/nvdimm/label.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c index 47a4828b8b31..6f2be7a34598 100644 --- a/drivers/nvdimm/label.c

Re: [RFC PATCH 8/9] cxl/mem: Register CXL memX devices

2020-11-19 Thread Dan Williams
On Tue, Nov 17, 2020 at 7:57 AM Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:43:55 -0800 > Ben Widawsky wrote: > > > From: Dan Williams > > > > Create the /sys/bus/cxl hierarchy to enumerate memory devices > > (per-endpoint control devices), me

Re: [PATCH 1/1] ACPI/nfit: correct the badrange to be reported in nfit_handle_mce()

2020-11-18 Thread Dan Williams
On Wed, Nov 18, 2020 at 5:53 PM Leizhen (ThunderTown) wrote: > > > > On 2020/11/19 3:16, Dan Williams wrote: > > On Wed, Nov 18, 2020 at 12:55 AM Leizhen (ThunderTown) > > wrote: > >> > >> > >> > >> On 2020/11/18 16:41, Zhen Lei wrot

Re: [PATCH 1/1] ACPI/nfit: correct the badrange to be reported in nfit_handle_mce()

2020-11-18 Thread Dan Williams
On Wed, Nov 18, 2020 at 12:55 AM Leizhen (ThunderTown) wrote: > > > > On 2020/11/18 16:41, Zhen Lei wrote: > > The badrange to be reported should always cover mce->addr. > Maybe I should change this description to: > Make sure the badrange to be reported can always cover mce->addr. Yes, I like

Re: [mm/gup] 47e29d32af: phoronix-test-suite.npb.FT.A.total_mop_s -45.0% regression

2020-11-18 Thread Dan Williams
On Wed, Nov 18, 2020 at 5:51 AM Jan Kara wrote: > > On Mon 16-11-20 19:35:31, John Hubbard wrote: > > > > On 11/16/20 6:48 PM, kernel test robot wrote: > > > > > > Greeting, > > > > > > FYI, we noticed a -45.0% regression of > > > phoronix-test-suite.npb.FT.A.total_mop_s due to commit: > > > > >

Re: [RFC PATCH 2/9] cxl/acpi: add OSC support

2020-11-18 Thread Dan Williams
On Wed, Nov 18, 2020 at 4:26 AM Rafael J. Wysocki wrote: > > On Tue, Nov 17, 2020 at 12:26 AM Dan Williams > wrote: > > > > On Mon, Nov 16, 2020 at 10:00 AM Jonathan Cameron > > wrote: > > > > > > On Tue, 10 Nov 2020 21:43:49 -0800 > > >

Re: [PATCH 1/1] ACPI/nfit: avoid accessing uninitialized memory in acpi_nfit_ctl()

2020-11-18 Thread Dan Williams
y: Zhen Lei Looks good to me. Reviewed-by: Dan Williams I'll pick this up.

Re: [RFC PATCH 1/9] cxl/acpi: Add an acpi_cxl module for the CXL interconnect

2020-11-17 Thread Dan Williams
On Tue, Nov 17, 2020 at 6:33 AM Rafael J. Wysocki wrote: [..] > > +static struct acpi_driver acpi_cxl_driver = { > > First of all, no new acpi_driver instances, pretty please! > > acpi_default_enumeration() should create a platform device with the > ACPI0017 ID for you. Can't you provide a

Re: [PATCH v4 01/10] Add auxiliary bus support

2020-11-17 Thread Dan Williams
> > Signed-off-by: Fred Oh > > > Co-developed-by: Leon Romanovsky > > > Signed-off-by: Leon Romanovsky > > > Reviewed-by: Pierre-Louis Bossart > > > Reviewed-by: Shiraz Saleem > > > Reviewed-by: Parav Pandit > > > Reviewed-by: Dan Wi

Re: [RFC PATCH 7/9] cxl/mem: Implement polled mode mailbox

2020-11-17 Thread Dan Williams
On Tue, Nov 17, 2020 at 10:07 AM Jonathan Cameron wrote: > > On Tue, 17 Nov 2020 08:34:38 -0800 > Ben Widawsky wrote: > > > On 20-11-17 15:31:22, Jonathan Cameron wrote: > > > On Tue, 10 Nov 2020 21:43:54 -0800 > > > Ben Widawsky wrote: > > > > > > > Create a function to handle sending a

Re: [RFC PATCH 2/9] cxl/acpi: add OSC support

2020-11-16 Thread Dan Williams
On Mon, Nov 16, 2020 at 10:00 AM Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:43:49 -0800 > Ben Widawsky wrote: > > > From: Vishal Verma > > > > Add support to advertise OS capabilities, and request OS control for CXL > > features using the ACPI _OSC mechanism. Advertise support for all >

Re: [RFC PATCH 4/9] cxl/mem: Map memory device registers

2020-11-16 Thread Dan Williams
On Fri, Nov 13, 2020 at 5:12 PM Ben Widawsky wrote: > > On 20-11-13 12:17:32, Bjorn Helgaas wrote: > > On Tue, Nov 10, 2020 at 09:43:51PM -0800, Ben Widawsky wrote: > > > All the necessary bits are initialized in order to find and map the > > > register space for CXL Memory Devices. This is

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-11-14 Thread Dan Williams
On Fri, Nov 13, 2020 at 5:09 PM Ben Widawsky wrote: [..] > > Unused, maybe move it to the patch that adds the use? > > > > This is a remnant from when Dan gave me the basis to do the mmio work. I agree > it can be removed now. Yes. > > > +static int cxl_mem_dvsec(struct pci_dev *pdev, int

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-11-11 Thread Dan Williams
On Wed, Nov 11, 2020 at 1:42 PM Randy Dunlap wrote: > > On 11/11/20 9:17 AM, Dan Williams wrote: > > On Tue, Nov 10, 2020 at 11:12 PM Christoph Hellwig > > wrote: > >> > >> On Tue, Nov 10, 2020 at 09:43:50PM -0800, Ben Widawsky wrote: > >>>

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-11-11 Thread Dan Williams
On Wed, Nov 11, 2020 at 9:17 AM Dan Williams wrote: [..] > > > + > > > + pci_read_config_word(pdev, pos + PCI_DVSEC_VENDOR_OFFSET, > > > ); > > > + pci_read_config_word(pdev, pos + PCI_DVSEC_ID_OFFSET, ); > > > +

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-11-11 Thread Dan Williams
On Tue, Nov 10, 2020 at 11:12 PM Christoph Hellwig wrote: > > On Tue, Nov 10, 2020 at 09:43:50PM -0800, Ben Widawsky wrote: > > +config CXL_MEM > > +tristate "CXL.mem Device Support" > > +depends on PCI && CXL_BUS_PROVIDER != n > > depend on PCI && CXL_BUS_PROVIDER > > > +

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Dan Williams
On Fri, Nov 6, 2020 at 4:12 PM Jason Gunthorpe wrote: > > On Fri, Nov 06, 2020 at 03:47:00PM -0800, Dan Williams wrote: [..] > The only sane way to implement this generically is for the VMM to > provide a hypercall to obtain a real *working* addr/data pair(s) and > then have th

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-06 Thread Dan Williams
On Fri, Nov 6, 2020 at 9:51 AM Jason Gunthorpe wrote: [..] > > This is true for IMS as well. But probably not implemented in the kernel as > > such. From a HW point of view (take idxd for instance) the facility is > > available to native OS as well. The early RFC supported this for native. > > I

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:28 AM Ertman, David M wrote: [..] > > > Each auxiliary_device represents a part of its parent > > > +functionality. The generic behavior can be extended and specialized as > > needed > > > +by encapsulating an auxiliary_device within other domain-specific > > structures

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:30 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > > > > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > >

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:40 AM Parav Pandit wrote: > > > > > From: Ertman, David M > > Sent: Friday, November 6, 2020 12:58 AM > > Subject: RE: [PATCH v3 01/10] Add auxiliary bus support > > > > > -Original Message- > > > From: Dan Wi

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 12:21 PM Greg KH wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > > > > > > > Per above SPDX is v2 only, so... > > > > > > Isn't it default for the Linux kernel? > > > > SPDX eli

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman > > wrote: > &g

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
; Co-developed-by: Ranjani Sridharan > Signed-off-by: Ranjani Sridharan > Co-developed-by: Fred Oh > Signed-off-by: Fred Oh > Co-developed-by: Leon Romanovsky > Signed-off-by: Leon Romanovsky > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Shiraz Saleem > Reviewed-by: Para

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-04 Thread Dan Williams
On Wed, Nov 4, 2020 at 11:32 PM gregkh wrote: > > On Wed, Nov 04, 2020 at 03:21:23PM -0800, Dan Williams wrote: > > On Tue, Nov 3, 2020 at 7:45 AM Jason Gunthorpe wrote: > > [..] > > > > +MODULE_DEVICE_TABLE(auxiliary, mlx5v_id_table); > > > >

Re: linux-next: build failure after merge of the akpm-current tree

2020-11-04 Thread Dan Williams
On Wed, Nov 4, 2020 at 9:05 PM Stephen Rothwell wrote: > > Hi all, > > After merging the akpm-current tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from include/linux/numa.h:25, > from include/linux/nodemask.h:96, >

<    1   2   3   4   5   6   7   8   9   10   >