Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-27 Thread Danesh Petigara
On 2/27/2015 3:54 PM, Andrew Morton wrote: > On Fri, 27 Feb 2015 15:52:56 -0800 Danesh Petigara > wrote: > >> On 2/27/2015 1:24 PM, Andrew Morton wrote: >>> On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara >>> wrote: >>> >>>> The CMA ali

Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-27 Thread Danesh Petigara
On 2/27/2015 1:24 PM, Andrew Morton wrote: > On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara > wrote: > >> The CMA aligned offset calculation is incorrect for >> non-zero order_per_bit values. >> >> For example, if cma->order_per_bit=1, cma->bas

Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-27 Thread Danesh Petigara
On 2/27/2015 1:24 PM, Andrew Morton wrote: On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara dpetig...@broadcom.com wrote: The CMA aligned offset calculation is incorrect for non-zero order_per_bit values. For example, if cma-order_per_bit=1, cma-base_pfn= 0x2f80 and align_order=12

Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-27 Thread Danesh Petigara
On 2/27/2015 3:54 PM, Andrew Morton wrote: On Fri, 27 Feb 2015 15:52:56 -0800 Danesh Petigara dpetig...@broadcom.com wrote: On 2/27/2015 1:24 PM, Andrew Morton wrote: On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara dpetig...@broadcom.com wrote: The CMA aligned offset calculation

[PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
c: sta...@vger.kernel.org Signed-off-by: Danesh Petigara Reviewed-by: Gregory Fong Acked-by: Michal Nazarewicz --- Changes since v1: - moved comment out of function - removed unused 'alignment' variable v1: https://lkml.org/lkml/2015/2/24/598 mm/cma.c | 12 +++- 1 file chan

Re: [PATCH] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
On 2/24/2015 1:10 PM, Michal Nazarewicz wrote: > On Tue, Feb 24 2015, Danesh Petigara wrote: >> The CMA aligned offset calculation is incorrect for >> non-zero order_per_bit values. >> >> For example, if cma->order_per_bit=1, cma->base_pfn= >> 0x2f80 a

[PATCH] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
c: sta...@vger.kernel.org Signed-off-by: Danesh Petigara Reviewed-by: Gregory Fong --- mm/cma.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/cma.c b/mm/cma.c index 75016fd..58f37bd 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -70,9 +70,13 @@ static unsigne

[PATCH] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
...@vger.kernel.org Signed-off-by: Danesh Petigara dpetig...@broadcom.com Reviewed-by: Gregory Fong gregory.0...@gmail.com --- mm/cma.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/cma.c b/mm/cma.c index 75016fd..58f37bd 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -70,9 +70,13

Re: [PATCH] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
On 2/24/2015 1:10 PM, Michal Nazarewicz wrote: On Tue, Feb 24 2015, Danesh Petigara dpetig...@broadcom.com wrote: The CMA aligned offset calculation is incorrect for non-zero order_per_bit values. For example, if cma-order_per_bit=1, cma-base_pfn= 0x2f80 and align_order=12

[PATCH v2] mm: cma: fix CMA aligned offset calculation

2015-02-24 Thread Danesh Petigara
...@vger.kernel.org Signed-off-by: Danesh Petigara dpetig...@broadcom.com Reviewed-by: Gregory Fong gregory.0...@gmail.com Acked-by: Michal Nazarewicz min...@mina86.com --- Changes since v1: - moved comment out of function - removed unused 'alignment' variable v1: https://lkml.org/lkml/2015/2