Re: [PATCH] bpf: clean up unused-variable warning

On 02/20/2018 11:07 PM, Arnd Bergmann wrote: > The only user of this variable is inside of an #ifdef, causing > a warning without CONFIG_INET: > > net/core/filter.c: In function 'bpf_sock_ops_cb_flags_set': > net/core/filter.c:3382:6: error: unused variable 'val' > [-Werror=unused-variable]

Re: [PATCH] bpf: hide a possibly unused variable

On 02/20/2018 11:08 PM, Arnd Bergmann wrote: > On Tue, Feb 20, 2018 at 10:44 PM, Daniel Borkmann <dan...@iogearbox.net> > wrote: >> Hi Arnd, >> >> On 02/20/2018 10:16 PM, Arnd Bergmann wrote: >>> The only user of this variable is inside of an #ifdef, ca

Re: [PATCH] bpf: hide a possibly unused variable

On 02/20/2018 11:08 PM, Arnd Bergmann wrote: > On Tue, Feb 20, 2018 at 10:44 PM, Daniel Borkmann > wrote: >> Hi Arnd, >> >> On 02/20/2018 10:16 PM, Arnd Bergmann wrote: >>> The only user of this variable is inside of an #ifdef, causing >>> a warning with

Re: [PATCH] bpf: hide a possibly unused variable

Hi Arnd, On 02/20/2018 10:16 PM, Arnd Bergmann wrote: > The only user of this variable is inside of an #ifdef, causing > a warning without CONFIG_INET: > > net/core/filter.c: In function 'bpf_sock_ops_cb_flags_set': > net/core/filter.c:3382:6: error: unused variable 'val' >

Re: [PATCH] bpf: hide a possibly unused variable

Hi Arnd, On 02/20/2018 10:16 PM, Arnd Bergmann wrote: > The only user of this variable is inside of an #ifdef, causing > a warning without CONFIG_INET: > > net/core/filter.c: In function 'bpf_sock_ops_cb_flags_set': > net/core/filter.c:3382:6: error: unused variable 'val' >

Re: [PATCH] tools/libbpf: Avoid possibly using uninitialized variable

On 02/20/2018 02:00 AM, Jeremy Cline wrote: > Fixes a GCC maybe-uninitialized warning introduced by 48cca7e44f9f. > "text" is only initialized inside the if statement so only print debug > info there. > > Signed-off-by: Jeremy Cline Looks good, applied to bpf tree, thanks

Re: [PATCH] tools/libbpf: Avoid possibly using uninitialized variable

On 02/20/2018 02:00 AM, Jeremy Cline wrote: > Fixes a GCC maybe-uninitialized warning introduced by 48cca7e44f9f. > "text" is only initialized inside the if statement so only print debug > info there. > > Signed-off-by: Jeremy Cline Looks good, applied to bpf tree, thanks Jeremy!

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

MIC >> with GFP_KERNEL. >> >> Reported-by: syzbot+1a240cdb1f4cc8881...@syzkaller.appspotmail.com >> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") >> Cc: Michal Hocko <mho...@kernel.org> >> Cc: Daniel Borkmann <dan...@iogearbox.

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

MIC >> with GFP_KERNEL. >> >> Reported-by: syzbot+1a240cdb1f4cc8881...@syzkaller.appspotmail.com >> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") >> Cc: Michal Hocko >> Cc: Daniel Borkmann >> Cc: Matthew Wilcox >> Cc: Jesper Danga

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

On 02/14/2018 01:36 PM, Daniel Borkmann wrote: > On 02/14/2018 12:59 AM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on bpf-next commit >> 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) >> Linux 4.16-rc1 >> >>

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

On 02/14/2018 01:36 PM, Daniel Borkmann wrote: > On 02/14/2018 12:59 AM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on bpf-next commit >> 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) >> Linux 4.16-rc1 >> >>

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

es: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") > Cc: Michal Hocko <mho...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Matthew Wilcox <wi...@infradead.org> > Cc: Jesper Dangaard Brouer <bro...@redhat.com> > Cc:

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

es: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") > Cc: Michal Hocko > Cc: Daniel Borkmann > Cc: Matthew Wilcox > Cc: Jesper Dangaard Brouer > Cc: a...@linux-foundation.org > Cc: dhowe...@redhat.com > Cc: han...@cmpxchg.org > Signed-off-by: Jason Wang Applied to bpf tree, thanks Jason!

Re: WARNING in kvmalloc_node

On 02/14/2018 01:47 PM, Jason Wang wrote: > On 2018年02月14日 20:29, Jesper Dangaard Brouer wrote: >> On Wed, 14 Feb 2018 13:17:18 +0100 >> Daniel Borkmann <dan...@iogearbox.net> wrote: >>> On 02/14/2018 01:02 PM, Jason Wang wrote: >>>> On 2018年02月14日 19:51,

Re: WARNING in kvmalloc_node

On 02/14/2018 01:47 PM, Jason Wang wrote: > On 2018年02月14日 20:29, Jesper Dangaard Brouer wrote: >> On Wed, 14 Feb 2018 13:17:18 +0100 >> Daniel Borkmann wrote: >>> On 02/14/2018 01:02 PM, Jason Wang wrote: >>>> On 2018年02月14日 19:51, Michal Hocko wrote: >&g

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

On 02/14/2018 12:59 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) > Linux 4.16-rc1 > > So far this crash happened 362 times on bpf-next. > C reproducer is attached. > syzkaller

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

On 02/14/2018 12:59 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) > Linux 4.16-rc1 > > So far this crash happened 362 times on bpf-next. > C reproducer is attached. > syzkaller

Re: WARNING in kvmalloc_node

On 02/14/2018 01:02 PM, Jason Wang wrote: > On 2018年02月14日 19:51, Michal Hocko wrote: >> On Wed 14-02-18 19:47:30, Jason Wang wrote: >>> On 2018年02月14日 17:28, Daniel Borkmann wrote: >>>> [ +Jason, +Jesper ] >>>> >>>> On 02/14/2018 09:43

Re: WARNING in kvmalloc_node

On 02/14/2018 01:02 PM, Jason Wang wrote: > On 2018年02月14日 19:51, Michal Hocko wrote: >> On Wed 14-02-18 19:47:30, Jason Wang wrote: >>> On 2018年02月14日 17:28, Daniel Borkmann wrote: >>>> [ +Jason, +Jesper ] >>>> >>>> On 02/14/2018 09:43

Re: WARNING in kvmalloc_node

[ +Jason, +Jesper ] On 02/14/2018 09:43 AM, Michal Hocko wrote: > On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: >> On Tue, Feb 13, 2018 at 03:59:01PM -0800, syzbot wrote: > [...] >>> kvmalloc include/linux/mm.h:541 [inline] >>> kvmalloc_array include/linux/mm.h:557 [inline] >>>

Re: WARNING in kvmalloc_node

[ +Jason, +Jesper ] On 02/14/2018 09:43 AM, Michal Hocko wrote: > On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: >> On Tue, Feb 13, 2018 at 03:59:01PM -0800, syzbot wrote: > [...] >>> kvmalloc include/linux/mm.h:541 [inline] >>> kvmalloc_array include/linux/mm.h:557 [inline] >>>

Re: lost connection to test machine (4)

On 02/12/2018 05:03 PM, Dmitry Vyukov wrote: > On Mon, Feb 12, 2018 at 5:00 PM, syzbot > wrote: >> Hello, >> >> syzbot hit the following crash on bpf-next commit >> 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) >>

Re: lost connection to test machine (4)

On 02/12/2018 05:03 PM, Dmitry Vyukov wrote: > On Mon, Feb 12, 2018 at 5:00 PM, syzbot > wrote: >> Hello, >> >> syzbot hit the following crash on bpf-next commit >> 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) >> Merge tag 'usercopy-v4.16-rc1' of >>

Re: [kmemleak] unreferenced object 0xcd9c1a80 (size 192):

On 02/12/2018 06:47 AM, Yonghong Song wrote: > On 2/11/18 11:18 AM, Mathieu Malaterre wrote: >> On Sun, Feb 11, 2018 at 5:54 PM, Alexei Starovoitov >> wrote: >>> On Sun, Feb 11, 2018 at 7:24 AM, Mathieu Malaterre wrote: Alexei, Could

Re: [kmemleak] unreferenced object 0xcd9c1a80 (size 192):

On 02/12/2018 06:47 AM, Yonghong Song wrote: > On 2/11/18 11:18 AM, Mathieu Malaterre wrote: >> On Sun, Feb 11, 2018 at 5:54 PM, Alexei Starovoitov >> wrote: >>> On Sun, Feb 11, 2018 at 7:24 AM, Mathieu Malaterre wrote: Alexei, Could you please comment on why I am seeing those

Re: [Resend] Question: kselftests: bpf/test_maps failed

On 02/09/2018 06:14 AM, Li Zhijian wrote: > Hi > > INTEL 0-Day noticed that bpf/test_maps has different results at different > platforms. > when it fails, the details are like Sorry for the late reply and thanks for reporting! More below: > -- >   880 Failed to create hashmap

Re: [Resend] Question: kselftests: bpf/test_maps failed

On 02/09/2018 06:14 AM, Li Zhijian wrote: > Hi > > INTEL 0-Day noticed that bpf/test_maps has different results at different > platforms. > when it fails, the details are like Sorry for the late reply and thanks for reporting! More below: > -- >   880 Failed to create hashmap

Re: [PATCH bpf-next v8 0/5] libbpf: add XDP binding support

On 01/30/2018 09:50 PM, Eric Leblond wrote: > Hello Daniel, > > No problem with the delay in the answer. I'm doing far worse. > > Here is an updated version: > - add if_link.h in uapi and remove the definition > - fix a commit message > - remove uapi from a include Fyi, this still needs to wait

Re: [PATCH bpf-next v8 0/5] libbpf: add XDP binding support

On 01/30/2018 09:50 PM, Eric Leblond wrote: > Hello Daniel, > > No problem with the delay in the answer. I'm doing far worse. > > Here is an updated version: > - add if_link.h in uapi and remove the definition > - fix a commit message > - remove uapi from a include Fyi, this still needs to wait

Re: general protection fault in ___bpf_prog_run

On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

Re: general protection fault in ___bpf_prog_run

On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

Re: general protection fault in ___bpf_prog_run

On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

Re: general protection fault in ___bpf_prog_run

On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

Re: net: hang in unregister_netdevice: waiting for lo to become free

On 01/30/2018 07:32 PM, Cong Wang wrote: > On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: >> Hello, >> >> The following program creates a hang in unregister_netdevice. >> cleanup_net work hangs there forever periodically printing >> "unregister_netdevice: waiting for lo

Re: net: hang in unregister_netdevice: waiting for lo to become free

On 01/30/2018 07:32 PM, Cong Wang wrote: > On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: >> Hello, >> >> The following program creates a hang in unregister_netdevice. >> cleanup_net work hangs there forever periodically printing >> "unregister_netdevice: waiting for lo to become free.

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

Hi Eric, On 01/27/2018 11:32 AM, Eric Leblond wrote: > On Sat, 2018-01-27 at 02:28 +0100, Daniel Borkmann wrote: >> On 01/25/2018 01:05 AM, Eric Leblond wrote: >>> Parse netlink ext attribute to get the error message returned by >>> the card. Code is partially take

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

Hi Eric, On 01/27/2018 11:32 AM, Eric Leblond wrote: > On Sat, 2018-01-27 at 02:28 +0100, Daniel Borkmann wrote: >> On 01/25/2018 01:05 AM, Eric Leblond wrote: >>> Parse netlink ext attribute to get the error message returned by >>> the card. Code is partially take

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 06:36 PM, Greg KH wrote: > On Mon, Jan 29, 2018 at 04:36:35PM +0100, Daniel Borkmann wrote: >> On 01/29/2018 12:40 AM, Daniel Borkmann wrote: >>> On 01/28/2018 03:45 PM, Greg KH wrote: >>>> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 06:36 PM, Greg KH wrote: > On Mon, Jan 29, 2018 at 04:36:35PM +0100, Daniel Borkmann wrote: >> On 01/29/2018 12:40 AM, Daniel Borkmann wrote: >>> On 01/28/2018 03:45 PM, Greg KH wrote: >>>> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 12:40 AM, Daniel Borkmann wrote: > On 01/28/2018 03:45 PM, Greg KH wrote: >> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >>> On 01/24/2018 11:07 AM, David Woodhouse wrote: >>>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 12:40 AM, Daniel Borkmann wrote: > On 01/28/2018 03:45 PM, Greg KH wrote: >> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >>> On 01/24/2018 11:07 AM, David Woodhouse wrote: >>>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/28/2018 03:45 PM, Greg KH wrote: > On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >> On 01/24/2018 11:07 AM, David Woodhouse wrote: >>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >>>> On 01/09/2018 07:04 PM, Alexei Starovoi

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/28/2018 03:45 PM, Greg KH wrote: > On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >> On 01/24/2018 11:07 AM, David Woodhouse wrote: >>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >>>> On 01/09/2018 07:04 PM, Alexei Starovoi

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

On 01/25/2018 01:05 AM, Eric Leblond wrote: > Parse netlink ext attribute to get the error message returned by > the card. Code is partially take from libnl. > > We add netlink.h to the uapi include of tools. And we need to > avoid include of userspace netlink header to have a successful > build

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

On 01/25/2018 01:05 AM, Eric Leblond wrote: > Parse netlink ext attribute to get the error message returned by > the card. Code is partially take from libnl. > > We add netlink.h to the uapi include of tools. And we need to > avoid include of userspace netlink header to have a successful > build

Re: [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP

On 01/25/2018 01:05 AM, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond > Acked-by: Alexei Starovoitov > --- > tools/lib/bpf/bpf.c| 127 >

Re: [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP

On 01/25/2018 01:05 AM, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond > Acked-by: Alexei Starovoitov > --- > tools/lib/bpf/bpf.c| 127 >

Re: [PATCH net-next v1] samples/bpf: Partially fixes the bpf.o build

On 01/26/2018 09:30 AM, Mickaël Salaün wrote: > On 26/01/2018 03:16, Alexei Starovoitov wrote: >> On Fri, Jan 26, 2018 at 01:39:30AM +0100, Mickaël Salaün wrote: >>> Do not build lib/bpf/bpf.o with this Makefile but use the one from the >>> library directory. This avoid making a buggy bpf.o file

Re: [PATCH net-next v1] samples/bpf: Partially fixes the bpf.o build

On 01/26/2018 09:30 AM, Mickaël Salaün wrote: > On 26/01/2018 03:16, Alexei Starovoitov wrote: >> On Fri, Jan 26, 2018 at 01:39:30AM +0100, Mickaël Salaün wrote: >>> Do not build lib/bpf/bpf.o with this Makefile but use the one from the >>> library directory. This avoid making a buggy bpf.o file

Re: [PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

On 01/24/2018 08:48 AM, Wang YanQing wrote: > If we then OR this with 0x40, then the value of 6th bit (0th is first bit) > become known, so the right mask is 0xbf instead of 0xcf. > > Signed-off-by: Wang YanQing Applied to bpf-next, thanks Wang!

Re: [PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

On 01/24/2018 08:48 AM, Wang YanQing wrote: > If we then OR this with 0x40, then the value of 6th bit (0th is first bit) > become known, so the right mask is 0xbf instead of 0xcf. > > Signed-off-by: Wang YanQing Applied to bpf-next, thanks Wang!

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/24/2018 11:07 AM, David Woodhouse wrote: > On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >> On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: >>> >>> The BPF interpreter has been used as part of the spectre 2 attack >>> CVE-2017-5715. >

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/24/2018 11:07 AM, David Woodhouse wrote: > On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >> On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: >>> >>> The BPF interpreter has been used as part of the spectre 2 attack >>> CVE-2017-5715. >

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/20/2018 09:28 AM, Éric Leblond wrote: > Hi, > > Le 20 janv. 2018 9:21 AM, Daniel Borkmann <dan...@iogearbox.net> a écrit : > > On 01/20/2018 03:27 AM, Alexei Starovoitov wrote: > > On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: >

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/20/2018 09:28 AM, Éric Leblond wrote: > Hi, > > Le 20 janv. 2018 9:21 AM, Daniel Borkmann a écrit : > > On 01/20/2018 03:27 AM, Alexei Starovoitov wrote: > > On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: > >> On 01/19/201

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/20/2018 03:27 AM, Alexei Starovoitov wrote: > On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: >> On 01/19/2018 12:43 AM, Eric Leblond wrote: >>> Hello, >>> >>> This patchset rebases the libbpf code on latest bpf-next code and addresse

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/20/2018 03:27 AM, Alexei Starovoitov wrote: > On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: >> On 01/19/2018 12:43 AM, Eric Leblond wrote: >>> Hello, >>> >>> This patchset rebases the libbpf code on latest bpf-next code and addresse

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/19/2018 12:43 AM, Eric Leblond wrote: > Hello, > > This patchset rebases the libbpf code on latest bpf-next code and addresses > remarks by Daniel. Ok, I think it's a good start. We should later on clean up the netlink handling code a bit, but that's all internal and can be done in a

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/19/2018 12:43 AM, Eric Leblond wrote: > Hello, > > This patchset rebases the libbpf code on latest bpf-next code and addresses > remarks by Daniel. Ok, I think it's a good start. We should later on clean up the netlink handling code a bit, but that's all internal and can be done in a

Re: [PATCH] selftests: bpf: update .gitignore with missing generated files

On 01/19/2018 01:36 AM, Shuah Khan wrote: > Update .gitignore with missing generated files. > > Signed-off-by: Shuah Khan Applied to bpf-next, thanks Shuah!

Re: [PATCH] selftests: bpf: update .gitignore with missing generated files

On 01/19/2018 01:36 AM, Shuah Khan wrote: > Update .gitignore with missing generated files. > > Signed-off-by: Shuah Khan Applied to bpf-next, thanks Shuah!

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

and define >> corresponding text representation. >> >> Signed-off-by: Roman Gushchin <g...@fb.com> >> Cc: Quentin Monnet <quentin.mon...@netronome.com> >> Cc: Jakub Kicinski <jakub.kicin...@netronome.com> >> Cc: Daniel Borkmann <dan...@iog

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

001 >> From: Roman Gushchin >> Date: Fri, 19 Jan 2018 14:07:38 + >> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps >> >> Add BPF_MAP_TYPE_CPUMAP map type to the list >> of map type recognized by bpftool and define >> correspo

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On 01/18/2018 02:10 PM, Dmitry Vyukov wrote: > On Wed, Jan 17, 2018 at 12:09 PM, Dmitry Vyukov <dvyu...@google.com> wrote: >> On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann <dan...@iogearbox.net> >> wrote: >>> Don't know if there's such a possibili

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On 01/18/2018 02:10 PM, Dmitry Vyukov wrote: > On Wed, Jan 17, 2018 at 12:09 PM, Dmitry Vyukov wrote: >> On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann >> wrote: >>> Don't know if there's such a possibility, but it would be nice if we could >>> targe

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On 01/17/2018 10:32 AM, Pavel Machek wrote: > On Fri 2018-01-12 17:58:01, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on >> 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > > What an useful way to describe kernel version. > > Could we get reasonable subject line? 4.15-rc7: prefix

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On 01/17/2018 10:32 AM, Pavel Machek wrote: > On Fri 2018-01-12 17:58:01, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on >> 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > > What an useful way to describe kernel version. > > Could we get reasonable subject line? 4.15-rc7: prefix

Re: [bpf-next PATCH 0/3] libbpf: cleanups to Makefile

On 01/17/2018 12:20 AM, Jesper Dangaard Brouer wrote: > This patchset contains some small improvements and cleanup for > the Makefile in tools/lib/bpf/. > > It worries me that the libbpf.so shared library is not versioned, but > it not addressed in this patchset. Looks good; applied it to

Re: [bpf-next PATCH 0/3] libbpf: cleanups to Makefile

On 01/17/2018 12:20 AM, Jesper Dangaard Brouer wrote: > This patchset contains some small improvements and cleanup for > the Makefile in tools/lib/bpf/. > > It worries me that the libbpf.so shared library is not versioned, but > it not addressed in this patchset. Looks good; applied it to

Re: [PATCH] samples/bpf: Fix trailing semicolon

On 01/16/2018 03:15 PM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Applied to bpf-next, thanks Luis!

Re: [PATCH] samples/bpf: Fix trailing semicolon

On 01/16/2018 03:15 PM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Applied to bpf-next, thanks Luis!

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

ponding textual representation: >>> >>> $ bpftool prog show >>> 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74 >>> loaded_at Jan 15/07:58 uid 0 >>> xlated 96B jited 105B memlock 4096B >>> >>> Signed-off-by: Roman

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

tual representation: >>> >>> $ bpftool prog show >>> 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74 >>> loaded_at Jan 15/07:58 uid 0 >>> xlated 96B jited 105B memlock 4096B >>> >>> Signed-off-by: Roman Gushchin >>> C

Re: KASAN: use-after-free Write in array_map_update_elem

On 01/15/2018 04:07 PM, Dmitry Vyukov wrote: > On Mon, Jan 15, 2018 at 3:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 8418f88764046d0e8ca6a3c04a69a0e57189aa1e >>

Re: KASAN: use-after-free Write in array_map_update_elem

On 01/15/2018 04:07 PM, Dmitry Vyukov wrote: > On Mon, Jan 15, 2018 at 3:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 8418f88764046d0e8ca6a3c04a69a0e57189aa1e >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> compiler: gcc (GCC) 7.1.1

Re: KASAN: slab-out-of-bounds Write in array_map_update_elem

On 01/15/2018 04:07 PM, Dmitry Vyukov wrote: > On Mon, Jan 15, 2018 at 3:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 4147d50978df60f34d444c647dde9e5b34a4315e >> git://git.cmpxchg.org/linux-mmots.git/master

Re: KASAN: slab-out-of-bounds Write in array_map_update_elem

On 01/15/2018 04:07 PM, Dmitry Vyukov wrote: > On Mon, Jan 15, 2018 at 3:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 4147d50978df60f34d444c647dde9e5b34a4315e >> git://git.cmpxchg.org/linux-mmots.git/master >> compiler: gcc (GCC) 7.1.1 20170620 >> .config is

Re: BUG: unable to handle kernel paging request in check_memory_region

On 01/13/2018 08:29 AM, Dmitry Vyukov wrote: > On Fri, Jan 12, 2018 at 11:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> c92a9a461dff6140c539c61e457aa97df29517d6 >>

Re: BUG: unable to handle kernel paging request in check_memory_region

On 01/13/2018 08:29 AM, Dmitry Vyukov wrote: > On Fri, Jan 12, 2018 at 11:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> c92a9a461dff6140c539c61e457aa97df29517d6 >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >> compiler: gcc (GCC) 7.1.1

Re: general protection fault in __bpf_map_put

On 01/13/2018 08:16 AM, Dmitry Vyukov wrote: > On Wed, Jan 10, 2018 at 1:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> b4464bcab38d3f7fe995a7cb960eeac6889bec08 >>

Re: general protection fault in __bpf_map_put

On 01/13/2018 08:16 AM, Dmitry Vyukov wrote: > On Wed, Jan 10, 2018 at 1:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> b4464bcab38d3f7fe995a7cb960eeac6889bec08 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> compiler: gcc (GCC) 7.1.1

Re: divide error in ___bpf_prog_run

On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: divide error in ___bpf_prog_run

On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: KASAN: slab-out-of-bounds Read in map_lookup_elem

On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: KASAN: slab-out-of-bounds Read in map_lookup_elem

On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: linux-next: build failure after merge of the net-next tree

On 01/12/2018 04:56 PM, Alexei Starovoitov wrote: > On Fri, Jan 12, 2018 at 11:45:42AM +0100, Daniel Borkmann wrote: >> On 01/12/2018 05:21 AM, Alexei Starovoitov wrote: >>> On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote: >>>> From: Alexei Starovoitov

Re: linux-next: build failure after merge of the net-next tree

On 01/12/2018 04:56 PM, Alexei Starovoitov wrote: > On Fri, Jan 12, 2018 at 11:45:42AM +0100, Daniel Borkmann wrote: >> On 01/12/2018 05:21 AM, Alexei Starovoitov wrote: >>> On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote: >>>> From: Alexei Starovoitov

Re: linux-next: build failure after merge of the net-next tree

On 01/12/2018 05:21 AM, Alexei Starovoitov wrote: > On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote: >> From: Alexei Starovoitov >> Date: Wed, 10 Jan 2018 17:58:54 -0800 >> >>> On Thu, Jan 11, 2018 at 11:53:55AM +1100, Stephen Rothwell wrote: Hi

Re: linux-next: build failure after merge of the net-next tree

On 01/12/2018 05:21 AM, Alexei Starovoitov wrote: > On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote: >> From: Alexei Starovoitov >> Date: Wed, 10 Jan 2018 17:58:54 -0800 >> >>> On Thu, Jan 11, 2018 at 11:53:55AM +1100, Stephen Rothwell wrote: Hi all, After merging the

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On 01/11/2018 04:58 PM, Dan Williams wrote: > On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: >> On Tue, 9 Jan 2018, Josh Poimboeuf wrote: >>> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On 01/11/2018 04:58 PM, Dan Williams wrote: > On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: >> On Tue, 9 Jan 2018, Josh Poimboeuf wrote: >>> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > On Fri, 5 Jan 2018, Dan

Re: KASAN: use-after-free Read in __bpf_prog_put

Hi Dmitry, On 01/11/2018 11:22 AM, Dmitry Vyukov wrote: > On Thu, Jan 11, 2018 at 11:17 AM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 4147d50978df60f34d444c647dde9e5b34a4315e >>

Re: KASAN: use-after-free Read in __bpf_prog_put

Hi Dmitry, On 01/11/2018 11:22 AM, Dmitry Vyukov wrote: > On Thu, Jan 11, 2018 at 11:17 AM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 4147d50978df60f34d444c647dde9e5b34a4315e >> git://git.cmpxchg.org/linux-mmots.git/master >> compiler: gcc (GCC) 7.1.1 20170620 >>

Re: WARNING in ___bpf_prog_run

On 01/10/2018 06:31 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached.

Re: WARNING in ___bpf_prog_run

On 01/10/2018 06:31 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached.

Re: general protection fault in cgroup_fd_array_put_ptr

On 01/10/2018 04:30 PM, Daniel Borkmann wrote: > On 01/10/2018 01:58 PM, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> c

Re: general protection fault in cgroup_fd_array_put_ptr

On 01/10/2018 04:30 PM, Daniel Borkmann wrote: > On 01/10/2018 01:58 PM, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> c

Re: general protection fault in cgroup_fd_array_put_ptr

On 01/10/2018 01:58 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached.

Re: general protection fault in cgroup_fd_array_put_ptr

On 01/10/2018 01:58 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on b4464bcab38d3f7fe995a7cb960eeac6889bec08 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached.

Re: [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"

On 01/10/2018 10:20 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text. > > Signed-off-by: Colin Ian King > --- > kernel/bpf/verifier.c | 2 +- > 1 file changed, 1 insertion(+), 1

<    1   2   3   4   5   6   7   8   9   10   >