[PATCH v2 9/9] phy/drivers/stm32: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano --- drivers/phy/st/phy-stm32-usbphyc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy

[PATCH v2 8/9] mtd/drivers/nand: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b

[PATCH v2 7/9] i2c/drivers/ov02q10: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano --- drivers/media/i2c/ov02a10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c index

[PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano Reviewed-by: Christian Eggers --- drivers/hwmon/mr75203.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon

[PATCH v2 6/9] iio/drivers/hid-sensor: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano --- drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/common/hid-sensors/hid

[PATCH v2 4/9] iio/drivers/as73211: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano Reviewed-by: Christian Eggers --- drivers/iio/light/as73211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/as73211.c b

[PATCH v2 2/9] thermal/drivers/devfreq_cooling: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano Reviewed-by: Christian Eggers --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal

[PATCH v2 3/9] devfreq: Use HZ macros

2021-02-24 Thread Daniel Lezcano
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano Reviewed-by: Christian Eggers Acked-by: Chanwoo Choi --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 1/9] units: Add the HZ macros

2021-02-24 Thread Daniel Lezcano
The macros for the unit conversion for frequency are duplicated in different places. Provide these macros in the 'units' header, so they can be reused. Signed-off-by: Daniel Lezcano Reviewed-by: Christian Eggers Reviewed-by: Andy Shevchenko --- include/linux/units.h | 4 1 file changed

[PATCH 2/2] units: Use the HZ_PER_KHZ macro

2021-02-23 Thread Daniel Lezcano
The HZ_PER_KHZ macro definition is duplicated in different subsystems. The macro now exists in include/linux/units.h, make use of it and remove all the duplicated ones. Signed-off-by: Daniel Lezcano --- drivers/devfreq/devfreq.c | 2 +- drivers/iio/light/as73211.c | 3

[PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-02-23 Thread Daniel Lezcano
The macro for the unit conversion for frequency is duplicated in different places. Provide this macro in the 'units' header, so it can be reused. Signed-off-by: Daniel Lezcano --- include/linux/units.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/units.h b/include

Re: [GIT PULL] thermal for v5.12-rc1

2021-02-22 Thread Daniel Lezcano
Hi Linus, On 22/02/2021 18:44, Linus Torvalds wrote: > On Fri, Feb 19, 2021 at 3:54 AM Daniel Lezcano > wrote: >> >> Note a set of changes for the qcom adc driver rely on an immutable >> branch from the iio tree: > > That part is fine, but what _isn't_ gre

Re: [RFC][PATCH 0/3] New thermal interface allowing IPA to get max power

2021-02-22 Thread Daniel Lezcano
Hi Lukasz, sorry for the delay, it took more time to finish my current work before commenting these patches. On 26/01/2021 11:39, Lukasz Luba wrote: > Hi all, > > This patch set tries to add the missing feature in the Intelligent Power > Allocation (IPA) governor which is: frequency limit set

Re: [GIT PULL] timer drivers fixes for v5.11-rc5

2021-02-22 Thread Daniel Lezcano
Hi Thomas, those fixes were not picked up -- Daniel On 27/01/2021 09:47, Daniel Lezcano wrote: > > Hi Thomas, > > just a gentle ping > > On 20/01/2021 09:31, Daniel Lezcano wrote: >> >> Hi Thomas, >> >> please consider the following three

[GIT PULL] thermal for v5.12-rc1

2021-02-19 Thread Daniel Lezcano
to a51afb13311cd85b2f638c691b2734622277d8f5: thermal: cpufreq_cooling: freq_qos_update_request() returns < 0 on error (2021-02-17 18:53:19 +0100) - Use the newly introduced 'hot' and 'critical' ops for the acpi thermal driver (Daniel Lezcano) - Remove the not

Re: [PATCH v9 1/8] drivers: thermal: tsens: Add VER_0 tsens version

2021-02-15 Thread Daniel Lezcano
On 22/01/2021 15:55, Ansuel Smith wrote: > VER_0 is used to describe device based on tsens version before v0.1. > These device are devices based on msm8960 for example apq8064 or > ipq806x. > > Signed-off-by: Ansuel Smith At the first glance, this series sounds ok but there is no ack from the

[GIT PULL] timer drivers for v5.12

2021-02-09 Thread Daniel Lezcano
Hi Thomas, please consider pulling the following changes for v5.12. Thanks -- Daniel The following changes since commit e85c1d21b16b278f50d191155bc674633270e9c6: clocksource/drivers/timer-microchip-pit64b: Add clocksource suspend/resume (2021-02-03 09:36:50 +0100) are available in the

Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

2021-02-09 Thread Daniel Lezcano
On 09/02/2021 17:02, Guo Ren wrote: > Hi Daniel, > > On Sun, Feb 7, 2021 at 5:29 PM Daniel Lezcano > wrote: >> >> On 07/02/2021 04:31, Guo Ren wrote: >>> Hi Daniel, >>> >>> On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano >>> w

Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

2021-02-07 Thread Daniel Lezcano
On 07/02/2021 04:31, Guo Ren wrote: > Hi Daniel, > > On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano > wrote: >> >> On 04/02/2021 08:46, guo...@kernel.org wrote: >>> From: Guo Ren >>> >>> The timer-mp-csky.c only could support CPU

Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes

2021-02-04 Thread Daniel Lezcano
On 04/02/2021 13:37, Bartosz Golaszewski wrote: > On Mon, Jan 11, 2021 at 3:08 PM Bartosz Golaszewski wrote: >> >> From: Bartosz Golaszewski >> >> We no longer need to undef pr_fmt if we define our own before including >> any headers. >> >> Signed-off-by: Bartosz Golaszewski >> --- Applied.

Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

2021-02-04 Thread Daniel Lezcano
The COMPILE_TEST is there for compilation test coverage when the changes are touching a lot of drivers. > Signed-off-by: Guo Ren > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Marc Zyngier > --- > drivers/clocksource/Kconfig | 2 +- > 1 file changed, 1 insertio

Re: [RESEND PATCH] clocksource/drivers/timer-microchip-pit64b: add clocksource suspend/resume

2021-02-03 Thread Daniel Lezcano
On 19/01/2021 13:59, Claudiu Beznea wrote: > Add suspend/resume support for clocksource timer. > > Signed-off-by: Claudiu Beznea Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook |

Re: [PATCH 0/4] clocksource: remove obsolete drivers

2021-02-03 Thread Daniel Lezcano
Applied, thanks On 20/01/2021 14:15, Arnd Bergmann wrote: > From: Arnd Bergmann > > A few Arm platforms are getting removed in v5.12, this removes > the corresponding clocksource drivers. > > Link: > https://lore.kernel.org/linux-arm-kernel/20210120124812.2800027-1-a...@kernel.org/T/ > >

Re: [RFC][PATCH 0/3] New thermal interface allowing IPA to get max power

2021-02-01 Thread Daniel Lezcano
Hi Lukasz, On 01/02/2021 12:23, Lukasz Luba wrote: > Daniel, Chanwoo > > Gentle ping. Have you have a chance to check these patches? I will review the patches in a couple of days -- Daniel > On 1/26/21 10:39 AM, Lukasz Luba wrote: >> Hi all, >> >> This patch set tries to add the missing

Re: [GIT PULL] timer drivers fixes for v5.11-rc5

2021-01-27 Thread Daniel Lezcano
Hi Thomas, just a gentle ping On 20/01/2021 09:31, Daniel Lezcano wrote: > > Hi Thomas, > > please consider the following three fixes for the timer drivers. > > Thanks > > -- Daniel > > The following changes since commit e3fab2f3de081e98c50b7b4ace1b040

Re: [PATCH] drm/panfrost: Add governor data with pre-defined thresholds

2021-01-21 Thread Daniel Lezcano
On 21/01/2021 18:04, Lukasz Luba wrote: > The simple_ondemand devfreq governor uses two thresholds to decide about > the frequency change: upthreshold, downdifferential. These two tunable > change the behavior of the governor decision, e.g. how fast to increase > the frequency or how rapidly limit

[GIT PULL] timer drivers fixes for v5.11-rc5

2021-01-20 Thread Daniel Lezcano
Hi Thomas, please consider the following three fixes for the timer drivers. Thanks -- Daniel The following changes since commit e3fab2f3de081e98c50b7b4ace1b040161d95310: ntp: Fix RTC synchronization on 32-bit platforms (2021-01-12 21:13:01 +0100) are available in the Git repository at:

Re: [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

2021-01-18 Thread Daniel Lezcano
On 18/01/2021 22:19, t...@redhat.com wrote: > From: Tom Rix > > When DEBUG is defined this error occurs > > drivers/clocksource/mxs_timer.c:138:1: error: > expected ‘;’ before ‘}’ token > > The preceding statement needs a semicolon. > Replace pr_info() with pr_debug() and remove the unneeded

Re: [PATCH v2 3/7] clocksource: Drop unused efm32 timer code

2021-01-18 Thread Daniel Lezcano
On 15/01/2021 16:51, Uwe Kleine-König wrote: > Support for this machine was just removed, so drop the now unused timer > code, too. > > Signed-off-by: Uwe Kleine-König > --- I've applied this patch in the clocksource tree. Thanks -- Daniel -- Linaro.org │ Open

[PATCH v2] thermal/core: Make cooling device state change private

2021-01-18 Thread Daniel Lezcano
The change of the cooling device state should be used by the governor or at least by the core code, not by the drivers themselves. Remove the API usage and move the function declaration to the internal headers. Signed-off-by: Daniel Lezcano Acked-by: Guenter Roeck --- drivers/hwmon/pwm-fan.c

Re: [PATCH v2 3/7] clocksource: Drop unused efm32 timer code

2021-01-18 Thread Daniel Lezcano
On 15/01/2021 16:51, Uwe Kleine-König wrote: > Support for this machine was just removed, so drop the now unused timer > code, too. > > Signed-off-by: Uwe Kleine-König Shall I take it through my tree ? > --- > drivers/clocksource/Kconfig | 9 - > drivers/clocksource/Makefile |

Re: [PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support

2021-01-18 Thread Daniel Lezcano
On 30/12/2020 07:25, vijayakannan.ayyathu...@intel.com wrote: > From: Vijayakannan Ayyathurai [ ... ] > +static struct timer_of keembay_ce_to = { > + .flags = TIMER_OF_IRQ | TIMER_OF_BASE | TIMER_OF_CLOCK, > + .clkevt = { > + .name = "keembay_sys_clkevt",

Re: [PATCH] thermal: power allocator: Add control for non-power actor devices

2021-01-18 Thread Daniel Lezcano
On 05/01/2021 20:01, Lukasz Luba wrote: > The cooling devices which are used in IPA should provide power mapping > functions. The callback functions are used for power estimation and state > setting. When these functions are missing IPA ignores such cooling devices > and does not limit their

Re: [PATCH v2 0/2] Add drivers for Intel Keem Bay SoC timer block

2021-01-18 Thread Daniel Lezcano
On 13/01/2021 11:54, Ayyathurai, Vijayakannan wrote: > Hi, > >> From: Vijayakannan Ayyathurai >> >> Changes since v1: >> - Add support for KEEMBAY_TIMER to get selected through Kconfig.platforms. >> - Add CLOCK_EVT_FEAT_DYNIRQ as part of clockevent feature. >> - Avoid overlapping reg regions

Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

2021-01-18 Thread Daniel Lezcano
On 18/01/2021 14:49, t...@redhat.com wrote: > From: Tom Rix > > When DEBUG is defined this error occurs > > drivers/clocksource/mxs_timer.c:138:1: error: > expected ‘;’ before ‘}’ token > > The preceding statement needs a semicolon. > > Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate

Re: [PATCH v2 1/2] thermal: int340x: Fix unexpected shutdown at critical temperature

2021-01-11 Thread Daniel Lezcano
On 11/01/2021 17:18, Kai-Heng Feng wrote: > On Tue, Dec 22, 2020 at 1:23 AM Kai-Heng Feng > wrote: >> >> We are seeing thermal shutdown on Intel based mobile workstations, the >> shutdown happens during the first trip handle in >> thermal_zone_device_register(): >> kernel: thermal thermal_zone15:

[PATCH] thermal/core: Make cooling device state change private

2021-01-11 Thread Daniel Lezcano
The change of the cooling device state should be used by the governor or at least by the core code, not by the drivers themselves. Remove the API usage and move the function declaration to the internal headers. Signed-off-by: Daniel Lezcano --- drivers/hwmon/pwm-fan.c| 1 - drivers

Re: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding

2021-01-07 Thread Daniel Lezcano
On 07/01/2021 06:10, Zhang, Rui wrote: > ACPI thermal driver binds the devices listed in _TZD method with > THERMAL_TRIPS_NONE. > Now given that > 1. THERMAL_TRIPS_NONE is removed from thermal framework > 2. _TZP is rarely supported. I searched ~500 acpidumps from different > platforms reported

Re: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding

2021-01-05 Thread Daniel Lezcano
Hi Rui, On 15/12/2020 00:38, Daniel Lezcano wrote: > The loop is here to create default cooling device binding on the > THERMAL_TRIPS_NONE number which is used to be the 'forced_passive' > feature. However, we removed all code dealing with that in the thermal > core, thus this

Re: [PATCH][next] powercap/drivers/dtpm: Fix size of object being allocated

2021-01-04 Thread Daniel Lezcano
sizeof argument") > Fixes: 0e8f68d7f048 ("powercap/drivers/dtpm: Add CPU energy model based > support") > Signed-off-by: Colin Ian King Good catch, thanks for fixing this Acked-by: Daniel Lezcano > --- > drivers/powercap/dtpm_cpu.c | 2 +- > 1 file chang

Re: [PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

2021-01-04 Thread Daniel Lezcano
Hi Geert, On 04/01/2021 09:18, Geert Uytterhoeven wrote: > Hi Daniel, > > On Wed, Dec 30, 2020 at 4:39 PM Daniel Lezcano > wrote: >> 32 bits architectures do not support u64 division, so the macro >> DIV_ROUND_CLOSEST is not adequate as the compiler will replace the

[PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

2020-12-30 Thread Daniel Lezcano
and DIV_ROUND_CLOSEST_ULL. Reported-by: kernel test robot Signed-off-by: Daniel Lezcano --- drivers/powercap/dtpm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c index 5b6857e9b064..0abcc439d728 100644 --- a/drivers/powercap/dtpm.c

Re: [PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-25 Thread Daniel Lezcano
On 24/12/2020 19:46, Pavel Machek wrote: > Hi! > >> The density of components greatly increased the last decade bringing a >> numerous number of heating sources which are monitored by more than 20 >> sensors on recent SoC. The skin temperature, which is the case >> temperature of the device, must

Re: [PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-23 Thread Daniel Lezcano
On 22/12/2020 19:52, Rafael J. Wysocki wrote: > On Fri, Dec 11, 2020 at 8:15 PM Rafael J. Wysocki wrote: >> >> On Fri, Dec 11, 2020 at 11:41 AM Daniel Lezcano >> wrote: >>> >>> >>> Hi Rafael, >>> >>> I believe I took into

[PATCH] thermal/core: Remove pointless thermal_zone_device_reset() function

2020-12-22 Thread Daniel Lezcano
(). Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index b2615449b18f..996c038f83a4 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers

Re: [PATCH 1/6] thermal/core: Remove the 'forced_passive' option

2020-12-22 Thread Daniel Lezcano
On 15/12/2020 00:38, Daniel Lezcano wrote: > The code was reorganized in 2012 with the commit 0c01ebbfd3caf1. > > The main change is a loop on the trip points array and a unconditional > call to the throttle() ops of the governors for each of them even if > the trip temperature is

Re: [PATCH 1/2] thermal: int340x: Add critical callback to override default shutdown behavior

2020-12-21 Thread Daniel Lezcano
On 21/12/2020 16:00, Kai-Heng Feng wrote: > On Mon, Dec 21, 2020 at 9:59 PM Daniel Lezcano > wrote: >> >> On 21/12/2020 14:52, Kai-Heng Feng wrote: >>> We are seeing thermal shutdown on Intel based mobile workstations, the >>> shutdown

Re: [PATCH 1/2] thermal: int340x: Add critical callback to override default shutdown behavior

2020-12-21 Thread Daniel Lezcano
On 21/12/2020 14:52, Kai-Heng Feng wrote: > We are seeing thermal shutdown on Intel based mobile workstations, the > shutdown happens during the first trip handle in > thermal_zone_device_register(): > kernel: thermal thermal_zone15: critical temperature reached (101 C), > shutting down > >

Re: [PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-18 Thread Daniel Lezcano
On 18/12/2020 11:16, Adam Thomson wrote: > On 16 December 2020 22:04, Daniel Lezcano wrote: > >> The code does no longer use the ms unit based fields to set the >> delays as they are replaced by the jiffies. >> >> Remove them and replace their user to use the jif

[GIT PULL] thermal for v5.11 #2

2020-12-18 Thread Daniel Lezcano
Hi Linus, please consider this trivial change which fall into the cracks. It adds a couple of ids in a array. The following changes since commit 4401117bf7fc11dc738c0963fa0c94814abc8dcd: thermal/drivers/devfreq_cooling: Fix the build when !ENERGY_MODEL (2020-12-15 17:03:56 +0100) are

Re: [PATCH v2 47/48] ARM: tegra: ventana: Support CPU voltage scaling and thermal throttling

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 21:28, Dmitry Osipenko wrote: > 17.12.2020 22:36, Daniel Lezcano пишет: >>>>> + type = "critical"; >>>>> + }; >>>>> + }; >>>>> + &g

Re: [PATCH v2 47/48] ARM: tegra: ventana: Support CPU voltage scaling and thermal throttling

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 20:01, Dmitry Osipenko wrote: > 17.12.2020 21:28, Daniel Lezcano пишет: >> On 17/12/2020 19:06, Dmitry Osipenko wrote: >>> Enable CPU voltage scaling and thermal throttling on Tegra20 Ventana board. >>> >>> Signed-off-by: Dmitry Osipenko &g

Re: [PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 19:32, Hans de Goede wrote: > Hi Daniel, > > On 12/16/20 11:03 PM, Daniel Lezcano wrote: >> The code does no longer use the ms unit based fields to set the >> delays as they are replaced by the jiffies. >> >> Remove them and replace their user t

Re: [PATCH v2 48/48] ARM: tegra: cardhu: Support CPU voltage scaling and thermal throttling

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 19:06, Dmitry Osipenko wrote: > Enable CPU voltage scaling and thermal throttling on Tegra30 Cardhu board. > > Signed-off-by: Dmitry Osipenko > --- Same comments as 47/48 > arch/arm/boot/dts/tegra30-cardhu.dtsi | 61 ++- > 1 file changed, 60

Re: [PATCH v2 47/48] ARM: tegra: ventana: Support CPU voltage scaling and thermal throttling

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 19:06, Dmitry Osipenko wrote: > Enable CPU voltage scaling and thermal throttling on Tegra20 Ventana board. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20-ventana.dts | 40 ++- > 1 file changed, 39 insertions(+), 1 deletion(-) > >

Re: [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops

2020-12-17 Thread Daniel Lezcano
On 17/12/2020 12:38, Srinivas Pandruvada wrote: > On Thu, 2020-12-17 at 07:28 +0100, Daniel Lezcano wrote: >> On 10/12/2020 13:15, Daniel Lezcano wrote: >>> The acpi driver wants to do a netlink notification in case of a hot >>> or >>> critical trip po

Re: [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops

2020-12-16 Thread Daniel Lezcano
On 10/12/2020 13:15, Daniel Lezcano wrote: > The acpi driver wants to do a netlink notification in case of a hot or > critical trip point. Implement the corresponding ops to be used for > the thermal zone and use them instead of the notify ops. > > Signed-off-by: Daniel Lezcano

Re: [PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-16 Thread Daniel Lezcano
On 16/12/2020 23:35, Peter Kästle wrote: > 16. Dezember 2020 23:04, "Daniel Lezcano" schrieb: > >> The code does no longer use the ms unit based fields to set the >> delays as they are replaced by the jiffies. >> >> Remove them and replace their user to u

[PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-16 Thread Daniel Lezcano
The code does no longer use the ms unit based fields to set the delays as they are replaced by the jiffies. Remove them and replace their user to use the jiffies version instead. Cc: Thara Gopinath Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/platform/x86/acerhdf.c

[PATCH v2 2/3] thermal/core: Use precomputed jiffies for the polling

2020-12-16 Thread Daniel Lezcano
The delays are also stored in jiffies based unit. Use them instead of the ms. Cc: Thara Gopinath Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/thermal

[PATCH v2 1/3] thermal/core: Precompute the delays from msecs to jiffies

2020-12-16 Thread Daniel Lezcano
-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c| 3 +++ drivers/thermal/thermal_core.h| 1 + drivers/thermal/thermal_helpers.c | 7 +++ include/linux/thermal.h | 7 +++ 4 files changed, 18 insertions(+) diff --git a/drivers/thermal

Re: [PATCH] thermal: int340x: Support Alder Lake

2020-12-15 Thread Daniel Lezcano
On 16/12/2020 02:59, srinivas pandruvada wrote: > On Tue, 2020-11-17 at 11:48 -0800, Srinivas Pandruvada wrote: >> Add ACPI IDs for thermal drivers for Alder Lake support. >> > This patch was not in PULL request. > It is simple patch, adding ids. Can we send as part of second PULL? Ah, sorry. I

Re: [PATCH 2/4] thermal/core: Precompute the jiffies

2020-12-15 Thread Daniel Lezcano
On Tue, Dec 15, 2020 at 09:38:06AM -0500, Thara Gopinath wrote: > Hi Daniel, > > On 12/2/20 7:06 AM, Daniel Lezcano wrote: > > The delays are stored in ms units and when the polling function is > > called this delay is converted into jiffies at each call. > > > >

[GIT PULL] thermal for v5.11

2020-12-15 Thread Daniel Lezcano
by a new one (Niklas Söderlund) - Improve the error code handling at init time on imx8mm (Fabio Estevam) - Compute interval validity once instead at each temperature reading iteration on acerhdf (Daniel Lezcano) - Add r8a779a0 support (Niklas Söderlund) - Add PCI ids for AlderLake PCH

Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model

2020-12-15 Thread Daniel Lezcano
A separate patch should add the select ENERGY_MODEL in the multi_v7_defconfig so the devfreq cooling device continues to build by default as before. Arnd? On 15/12/2020 09:35, Daniel Lezcano wrote: > The devfreq cooling device has been converted to use the energy model. > > Add the d

[PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model

2020-12-15 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano --- drivers/thermal/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 7edc8dc6bbab..ee62d51ef351 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL

[PATCH 3/6] thermal/core: Remove pointless test with the THERMAL_TRIPS_NONE macro

2020-12-14 Thread Daniel Lezcano
The THERMAL_TRIPS_NONE is equal to -1, it is pointless to do a conversion in this function. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_sysfs.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c

[PATCH 5/6] thermal/core: Remove THERMAL_TRIPS_NONE test

2020-12-14 Thread Daniel Lezcano
The last site calling the thermal_zone_bind_cooling_device() function with the THERMAL_TRIPS_NONE parameter was removed. We can get rid of this test as no user of this function is calling this function with this parameter. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 2

[PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding

2020-12-14 Thread Daniel Lezcano
The loop is here to create default cooling device binding on the THERMAL_TRIPS_NONE number which is used to be the 'forced_passive' feature. However, we removed all code dealing with that in the thermal core, thus this binding does no longer make sense. Remove it. Signed-off-by: Daniel Lezcano

[PATCH 6/6] thermal/core: Remove unused macro THERMAL_TRIPS_NONE

2020-12-14 Thread Daniel Lezcano
The macro THERMAL_TRIPS_NONE is no longer used, remove it. Signed-off-by: Daniel Lezcano --- include/linux/thermal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/thermal.h b/include/linux/thermal.h index a57232a9a6f9..060a2160add4 100644 --- a/include/linux/thermal.h +++ b

[PATCH 2/6] thermal/core: Remove unused functions rebind/unbind exception

2020-12-14 Thread Daniel Lezcano
The functions thermal_zone_device_rebind_exception and thermal_zone_device_unbind_exception are not used from anywhere. Remove that code. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 37 -- drivers/thermal/thermal_core.h | 4 2 files

[PATCH 1/6] thermal/core: Remove the 'forced_passive' option

2020-12-14 Thread Daniel Lezcano
effect. Given the regression exists since more than 8 years, nobody complained and at the best of my knowledge there is no bug open in https://bugzilla.kernel.org, it is reasonable to say it is unused. Remove the 'forced_passive' related code. Signed-off-by: Daniel Lezcano --- .../driver-api

[thermal: thermal/next] thermal/core: Emit a warning if the thermal zone is updated without ops

2020-12-14 Thread thermal-bot for Daniel Lezcano
The following commit has been merged into the thermal/next branch of thermal: Commit-ID: 433178e75834dc35f1ae79b56ec2cf396f2c6f3c Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//433178e75834dc35f1ae79b56ec2cf396f2c6f3c Author:Daniel Lezcano

Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate

2020-12-13 Thread Daniel Lezcano
On 13/12/2020 02:11, Matthew Garrett wrote: > On Sun, Dec 13, 2020 at 12:39:26AM +0100, Daniel Lezcano wrote: >> On 12/12/2020 21:08, Matthew Garrett wrote: >>> Anything that provides a trip point that has no active notifications and >>> doesn't provide any inform

Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate

2020-12-12 Thread Daniel Lezcano
On 12/12/2020 21:08, Matthew Garrett wrote: > On Sat, Dec 12, 2020 at 10:11:31AM +0100, Daniel Lezcano wrote: >> On 12/12/2020 04:50, Matthew Garrett wrote: >>> Yes - what's the reason to do so? >> >> I'm cleaning up the thermal core code, so questioning every

Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate

2020-12-12 Thread Daniel Lezcano
On 12/12/2020 04:50, Matthew Garrett wrote: > On Fri, Dec 11, 2020 at 02:17:55PM +0100, Daniel Lezcano wrote: >> On 08/12/2020 16:30, Daniel Lezcano wrote: >>> The passive file in sysfs forces the usage of a passive trip point set >>> by the userspace when a b

Re: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model

2020-12-11 Thread Daniel Lezcano
On 11/12/2020 16:11, Lukasz Luba wrote: > Hi Daniel, > > Do you think it has chance to go to as material for v5.11? Yes, it is in the thermal/linux-next material ATM. > On 12/10/20 2:30 PM, Lukasz Luba wrote: >> Hi all, >> >> This patch set is a continuation of my previous work, which aimed >>

Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate

2020-12-11 Thread Daniel Lezcano
On 08/12/2020 16:30, Daniel Lezcano wrote: > The passive file in sysfs forces the usage of a passive trip point set > by the userspace when a broken BIOS does not provide the mitigation > temperature for such thermal zone. The hardware evolved a lot since > 2008 as a good therma

Re: [PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-11 Thread Daniel Lezcano
Hi Rafael, I believe I took into account all the comments, do you think it is possible to merge this series ? On 08/12/2020 17:41, Daniel Lezcano wrote: > The density of components greatly increased the last decade bringing a > numerous number of heating sources which are monitored b

Re: [PATCH v2 1/4] thermal/core: Rename passive_delay and polling_delay with units

2020-12-10 Thread Daniel Lezcano
Cc'ing missing persons. Sorry for the inconvenience, just a head up with those trivial changes (1/4 and 4/4). On 07/12/2020 20:08, Daniel Lezcano wrote: > The input unit used by the thermal framework is the msec but it uses > the jiffies to set the timers. > > As it is stored in

Re: [PATCH 2/5] thermal/core: Add critical and hot ops

2020-12-10 Thread Daniel Lezcano
On 10/12/2020 13:44, Lukasz Luba wrote: > > > On 12/10/20 12:15 PM, Daniel Lezcano wrote: >> Currently there is no way to the sensors to directly call an ops in >> interrupt mode without calling thermal_zone_device_update assuming all >> the trip points are defined. &g

Re: [PATCH v3 0/5] Thermal devfreq cooling improvements with Energy Model

2020-12-10 Thread Daniel Lezcano
On 10/12/2020 14:22, Lukasz Luba wrote: > Hi Daniel, [ ... ] >> Lukasz Luba (5): >>    thermal: devfreq_cooling: change tracing function and arguments >>    thermal: devfreq_cooling: use a copy of device status >>    thermal: devfreq_cooling: add new registration functions with Energy >>

[PATCH 4/5] thermal/drivers/rcar: Remove notification usage

2020-12-10 Thread Daniel Lezcano
The ops is only showing a trace telling a critical trip point is crossed. The same information is given by the thermal framework. This is redundant, remove the code. Signed-off-by: Daniel Lezcano --- drivers/thermal/rcar_thermal.c | 19 --- 1 file changed, 19 deletions(-) diff

[PATCH 2/5] thermal/core: Add critical and hot ops

2020-12-10 Thread Daniel Lezcano
to the thermal zone device, so a sensor can directly invoke them or let the thermal framework to call the sensor specific ones. Tested-by: Kai-Heng Feng Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 43 +- include/linux/thermal.h| 3 +++ 2

[PATCH 5/5] thermal/core: Remove notify ops

2020-12-10 Thread Daniel Lezcano
With the remove of the notify user in a previous patch, the ops is no longer needed, remove it. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 3 --- include/linux/thermal.h| 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers

[PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops

2020-12-10 Thread Daniel Lezcano
The acpi driver wants to do a netlink notification in case of a hot or critical trip point. Implement the corresponding ops to be used for the thermal zone and use them instead of the notify ops. Signed-off-by: Daniel Lezcano --- drivers/acpi/thermal.c | 30 ++ 1

[PATCH 1/5] thermal/core: Emit a warning if the thermal zone is updated without ops

2020-12-10 Thread Daniel Lezcano
. Any warning emitted will have to be fixed at the source of the problem: the caller must not call thermal_zone_device_update if there is not get_temp callback set. Cc: Thara Gopinath Cc: Amit Kucheria Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Daniel Lezcano

[GIT PULL] timers changes for v5.11 #2

2020-12-10 Thread Daniel Lezcano
Hi Thomas, please consider pulling those 3 last changes which fixes some issues on the drivers. The following changes since commit fef92cd2bc04c64bb3743d40c0b4be47aedf9e23: Merge tag 'timers-v5.11' of https://git.linaro.org/people/daniel.lezcano/linux into timers/core (2020-12-04 00:39:45

Re: [PATCH 3/4] thermal: int340x: processor_thermal: Add RFIM driver

2020-12-09 Thread Daniel Lezcano
On 26/11/2020 18:18, Srinivas Pandruvada wrote: > Add support for RFIM (Radio Frequency Interference Mitigation) support > via processor thermal PCI device. This drivers allows adjustment of > FIVR (Fully Integrated Voltage Regulator) and DDR (Double Data Rate) > frequencies to avoid RF

[PATCH RFC 1/4] thermal/core: Emit a warning if the thermal zone is updated without ops

2020-12-09 Thread Daniel Lezcano
. Any warning emitted will have to be fixed at the source of the problem: the caller must not call thermal_zone_device_update if there is not get_temp callback set. Cc: Thara Gopinath Cc: Amit Kucheria Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Daniel Lezcano

[PATCH RFC 2/4] thermal/core: Add critical and hot ops

2020-12-09 Thread Daniel Lezcano
to the thermal zone device, so a sensor can directly invoke them or let the thermal framework to call the sensor specific ones. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 42 +- include/linux/thermal.h| 3 +++ 2 files changed, 29 insertions

[PATCH RFC 4/4] thermal/core: Remove notify ops

2020-12-09 Thread Daniel Lezcano
With the remove of the notify user in a previous patch, the ops is no longer needed, remove it. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 3 --- include/linux/thermal.h| 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers

[PATCH RFC 3/4] thermal/drivers/acpi: Use hot and critical ops

2020-12-09 Thread Daniel Lezcano
The acpi driver wants to do a netlink notification in case of a hot or critical trip point. Implement the corresponding ops to be used for the thermal zone and use them instead of the notify ops. Signed-off-by: Daniel Lezcano --- drivers/acpi/thermal.c | 30 ++ 1

Re: [PATCH] thermal/core: Emit a warning if the thermal zone is updated without ops

2020-12-09 Thread Daniel Lezcano
On 09/12/2020 11:41, Lukasz Luba wrote: > > > On 12/8/20 3:19 PM, Daniel Lezcano wrote: >> On 08/12/2020 15:37, Lukasz Luba wrote: >>> >>> >>> On 12/8/20 1:51 PM, Daniel Lezcano wrote: >>>> >>>> Hi Lukasz,

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-12-09 Thread Daniel Lezcano
On 07/12/2020 06:36, Kai-Heng Feng wrote: > > >> On Dec 1, 2020, at 02:39, Srinivas Pandruvada >> wrote: >> >> On Tue, 2020-12-01 at 02:22 +0800, Kai-Heng Feng wrote: On Dec 1, 2020, at 02:13, Srinivas Pandruvada < srinivas.pandruv...@linux.intel.com> wrote: >>> >>> [snipped] >>>

[PATCH v5 3/4] powercap/drivers/dtpm: Add API for dynamic thermal power management

2020-12-08 Thread Daniel Lezcano
: Ram Chandrasekar Cc: Zhang Rui Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba Tested-by: Lukasz Luba --- drivers/powercap/Kconfig | 6 + drivers/powercap/Makefile | 1 + drivers/powercap/dtpm.c | 473 ++ include/asm-generic

[PATCH v5 4/4] powercap/drivers/dtpm: Add CPU energy model based support

2020-12-08 Thread Daniel Lezcano
return dtpm_register_cpu(pkg); } static struct dtpm_descr descr = { .name = "pkg", .init = dtpm_register_pkg, }; DTPM_DECLARE(descr); Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba Tested-by:

[PATCH v5 1/4] units: Add Watt units

2020-12-08 Thread Daniel Lezcano
As there are the temperature units, let's add the Watt macros definition. Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- include/linux/units.h | 4 1 file changed, 4 insertions(+) diff --git a/include

[PATCH v5 2/4] Documentation/powercap/dtpm: Add documentation for dtpm

2020-12-08 Thread Daniel Lezcano
framework provides an unified API to userspace to act on the power. Document this framework. Cc: Thara Gopinath Cc: Lina Iyer Cc: Ram Chandrasekar Cc: Zhang Rui Cc: Jonathan Corbet Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- Documentation/power/index.rst | 1

[PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-08 Thread Daniel Lezcano
duplicate initialization in the dtpm cpu Daniel Lezcano (4): units: Add Watt units Documentation/powercap/dtpm: Add documentation for dtpm powercap/drivers/dtpm: Add API for dynamic thermal power management powercap/drivers/dtpm: Add CPU energy model based support Documentation/power/index.rst

<    1   2   3   4   5   6   7   8   9   10   >