Re: [PATCH] clocksource: arc_timer: use BIT() instead of _BITUL()

2019-05-31 Thread Daniel Lezcano
On 24/05/2019 07:40, Masahiro Yamada wrote: > This is in-kernel C code, so there is no reason to use _BITUL(). > Replace it with equivalent BIT(). > > I added #include explicitly although it has been included > by other headers eventually. > > Signed-off-by: Masahiro Yamada > --- Applied,

Re: [PATCH 2/5] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support

2019-05-31 Thread Daniel Lezcano
Hi Claudiu, On 30/05/2019 09:46, claudiu.bez...@microchip.com wrote: > Hi Daniel, > > Taking into account the discussion on this tread and the fact that we have > no answer from Rob on this topic (I'm talking about [1]), what do you think > it would be best for this driver to be accepted the

[PATCH V3 3/8] genirq/timings: Optimize the period detection speed

2019-05-27 Thread Daniel Lezcano
; <-> <-> In our case, the minimum period is 2 and the maximum period is 5. That means all repeating pattern of 2 will be detected as repeating pattern of 4, it is pointless to go up to 2 when searching for the period as it will always fail. Remove one loop iteration by increasing t

[PATCH V3 2/8] genirq/timings: Fix timings buffer inspection

2019-05-27 Thread Daniel Lezcano
uffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 4f5daf3db13b..19d2fad379ee 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/

[PATCH V3 7/8] genirq/timings: Add selftest for irqs circular buffer

2019-05-27 Thread Daniel Lezcano
After testing the per cpu interrupt circular event, we want to make sure the per interrupt circular buffer usage is correct. Add tests to validate the interrupt circular buffer. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 139 +++ 1 file

[PATCH V3 6/8] genirq/timings: Add selftest for circular array

2019-05-27 Thread Daniel Lezcano
/ decoding of the values - the macro to browse the irq timings circular buffer - the function to push data in the circular buffer Signed-off-by: Daniel Lezcano --- kernel/irq/Makefile | 3 ++ kernel/irq/timings.c | 119 +++ lib/Kconfig.debug| 8 +++ 3

[PATCH V3 4/8] genirq/timings: Encapsulate timings push

2019-05-27 Thread Daniel Lezcano
-by: Daniel Lezcano --- kernel/irq/internals.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index 70c3053bc1f6..21f9927ff5ad 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -354,6

[PATCH V3 1/8] genirq/timings: Fix next event index function

2019-05-27 Thread Daniel Lezcano
. Fixes: bbba0e7c5cda "genirq/timings: Add array suffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 51 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timin

[PATCH V3 8/8] genirq/timings: Add selftest for next event computation

2019-05-27 Thread Daniel Lezcano
the last one. The next event computation must return the same value as the last element we did not inserted. Add tests for the next event index computation. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 66 1 file changed, 66 insertions(+) diff

[PATCH V3 5/8] genirq/timings: Encapsulate storing function

2019-05-27 Thread Daniel Lezcano
For the next patches providing the selftest, we want to insert interval values directly in the buffer in order to check the correctness of the code. Encapsulate the code doing that in a always inline function in order to reuse it in the test code. No functional changes. Signed-off-by: Daniel

[PATCH V3 0/8] genirq/timings: Fixes and selftests

2019-05-27 Thread Daniel Lezcano
*** Daniel Lezcano (8): genirq/timings: Fix next event index function genirq/timings: Fix timings buffer inspection genirq/timings: Optimize the period detection speed genirq/timings: Encapsulate timings push genirq/timings: Encapsulate storing function genirq/timings: Add selftest

Re: [RFC v2 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-25 Thread Daniel Lezcano
On 24/05/2019 13:53, Bartosz Golaszewski wrote: > pt., 24 maj 2019 o 10:59 Daniel Lezcano > napisał(a): >> >> On 24/05/2019 09:28, Bartosz Golaszewski wrote: >>> czw., 23 maj 2019 o 18:38 Daniel Lezcano >>> napisał(a): >>>> >>>>

Re: [PATCH V2 4/9] genirq/timings: Use the min kernel macro

2019-05-24 Thread Daniel Lezcano
On 24/05/2019 15:57, Andy Shevchenko wrote: > On Fri, May 24, 2019 at 01:16:10PM +0200, Daniel Lezcano wrote: >> The' min' is available as a kernel macro. Use it instead of writing >> the same code. > > While it's technically correct... > >> /* &

Re: [PATCH V2 7/9] genirq/timings: Add selftest for circular array

2019-05-24 Thread Daniel Lezcano
On 24/05/2019 16:00, Andy Shevchenko wrote: > On Fri, May 24, 2019 at 01:16:13PM +0200, Daniel Lezcano wrote: >> Due to the complexity of the code and the difficulty to debug it, >> let's add some selftests to the framework in order to spot issues or >> regression at boot

[PATCH V2 4/9] genirq/timings: Use the min kernel macro

2019-05-24 Thread Daniel Lezcano
The' min' is available as a kernel macro. Use it instead of writing the same code. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 06bde5253a7d..8928601b4b42 100644

[PATCH V2 2/9] genirq/timings: Fix timings buffer inspection

2019-05-24 Thread Daniel Lezcano
uffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 60362aca4ca4..250bb00ccd85 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/

[PATCH V2 7/9] genirq/timings: Add selftest for circular array

2019-05-24 Thread Daniel Lezcano
/ decoding of the values - the macro to browse the irq timings circular buffer - the function to push data in the circular buffer Signed-off-by: Daniel Lezcano --- kernel/irq/Makefile | 3 ++ kernel/irq/timings.c | 119 +++ lib/Kconfig.debug| 8 +++ 3

[PATCH V2 5/9] genirq/timings: Encapsulate timings push

2019-05-24 Thread Daniel Lezcano
-by: Daniel Lezcano --- kernel/irq/internals.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index 70c3053bc1f6..21f9927ff5ad 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -354,6

[PATCH V2 8/9] genirq/timings: Add selftest for irqs circular buffer

2019-05-24 Thread Daniel Lezcano
After testing the per cpu interrupt circular event, we want to make sure the per interrupt circular buffer usage is correct. Add tests to validate the interrupt circular buffer. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 139 +++ 1 file

[PATCH V2 6/9] genirq/timings: Encapsulate storing function

2019-05-24 Thread Daniel Lezcano
For the next patches providing the selftest, we want to insert interval values directly in the buffer in order to check the correctness of the code. Encapsulate the code doing that in a always inline function in order to reuse it in the test code. No functional changes. Signed-off-by: Daniel

[PATCH V2 3/9] genirq/timings: Optimize the period detection speed

2019-05-24 Thread Daniel Lezcano
; <-> <-> In our case, the minimum period is 2 and the maximum period is 5. That means all repeating pattern of 2 will be detected as repeating pattern of 4, it is pointless to go up to 2 when searching for the period as it will always fail. Remove one loop iteration by increasing t

[PATCH V2 9/9] genirq/timings: Add selftest for next event computation

2019-05-24 Thread Daniel Lezcano
the last one. The next event computation must return the same value as the last element we did not inserted. Add tests for the next event index computation. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 66 1 file changed, 66 insertions(+) diff

[PATCH V2 1/9] genirq/timings: Fix next event index function

2019-05-24 Thread Daniel Lezcano
. Fixes: bbba0e7c5cda "genirq/timings: Add array suffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 53 1 file changed, 44 insertions(+), 9 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timin

[PATCH V2 0/9] genirq/timings: Fixes and selftests

2019-05-24 Thread Daniel Lezcano
samples to insert values in the arrays and use them to predict the next event. These tests cover the most difficult part of the code. Changelog: V2: - remove defaulting to 'n' as it is already the case Daniel Lezcano (9): genirq/timings: Fix next event index function genirq/timings: Fix

Re: [PATCH] clocksource/arm_arch_timer: Don't trace count reader functions

2019-05-24 Thread Daniel Lezcano
t;>arch_timer_read_counter to access stable counters") >> Signed-off-by: Julien Thierry >> Cc: Marc Zyngier >> Cc: Mark Rutland >> Cc: Daniel Lezcano >> Cc: Thomas Gleixner >> Cc: Steven Rostedt >> --- [ ... ] > Well spotted,

Re: [RFC v2 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-24 Thread Daniel Lezcano
On 24/05/2019 09:28, Bartosz Golaszewski wrote: > czw., 23 maj 2019 o 18:38 Daniel Lezcano > napisał(a): >> >> On 23/05/2019 14:58, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Currently the clocksource and clockevent support fo

Re: [PATCH] clocksource/drivers/ixp4xx: Implement delay timer

2019-05-23 Thread Daniel Lezcano
On 23/05/2019 21:34, Linus Walleij wrote: > On Thu, May 23, 2019 at 9:21 PM Daniel Lezcano > wrote: >> On 23/05/2019 20:16, Linus Walleij wrote: > >>> This adds delay timer functionality to the IXP4xx >>> timer driver. >>> >>> Signed-off-by: L

Re: [PATCH] clocksource/drivers/ixp4xx: Implement delay timer

2019-05-23 Thread Daniel Lezcano
Hi Linus, On 23/05/2019 20:16, Linus Walleij wrote: > This adds delay timer functionality to the IXP4xx > timer driver. > > Signed-off-by: Linus Walleij The patch does not apply on tip/timers/core -- Linaro.org │ Open source software for ARM SoCs Follow

Re: [RFC v2 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-23 Thread Daniel Lezcano
On 23/05/2019 14:58, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently the clocksource and clockevent support for davinci platforms > lives in mach-davinci. It hard-codes many things, uses global variables, > implements functionalities unused by any platform and has code

Re: [RFC 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-23 Thread Daniel Lezcano
Hi Bartosz, On 23/05/2019 14:58, Bartosz Golaszewski wrote: [ ... ] >>> +++ b/drivers/clocksource/timer-davinci.c >>> @@ -0,0 +1,272 @@ >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +// >>> +// TI DaVinci clocksource driver >>> +// >>> +// Copyright (C) 2019 Texas Instruments >>> +//

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Daniel Lezcano
On 22/05/2019 14:27, Heiko Stuebner wrote: [ ... ] >> As this change is now in mainline and is causing veyron to hang I'd >> suggest reverting this change for now. Even fixing the root cause >> (maybe the one I pointed above) after this patch we will have the >> thermal driver to fail because

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Daniel Lezcano
Elaine, are you taking care of the issue related to this patch. If not fixed, it will be reverted. On 30/04/2019 12:09, Elaine Zhang wrote: > Explicitly use the pinctrl to set/unset the right mode > instead of relying on the pinctrl init mode. > And it requires setting the tshut polarity

Re: [PATCH] ARM: dts: at91sam9261ek: remove unused chosen nodes

2019-05-22 Thread Daniel Lezcano
Hi Rob, a gentle ping ... ;) On 08/04/2019 18:30, Daniel Lezcano wrote: > > Hi Rob, > > the following patch has been pushed in 2016 by commit 51f0aeb2d21f1. > > Being able to specify which timer should act as a clocksource or a > clockevent is often requested. Doing

Re: [PATCH] clocksource/drivers/timer-ti-dm: Change to new style declaration

2019-05-21 Thread Daniel Lezcano
On 21/05/2019 14:26, Philippe Mazenauer wrote: > Variable 'dmtimer_ops' was declared const static instead of static const. > > ../drivers/clocksource/timer-ti-dm.c:899:1: warning: ‘static’ is not at > beginning of declaration [-Wold-style-declaration] > const static struct omap_dm_timer_ops

Re: [PATCH v4 2/2] driver: clocksource: Add nxp system counter timer driver support

2019-05-21 Thread Daniel Lezcano
On 21/05/2019 14:01, Jacky Bai wrote: > >> -Original Message- >> From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] >> Sent: Tuesday, May 21, 2019 6:08 PM >> To: Jacky Bai ; t...@linutronix.de; robh...@kernel.org; >> shawn...@kernel.org; mark.rutl..

Re: [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus

2019-05-21 Thread Daniel Lezcano
e topology code to determine > the actual capacity by taking into account the highest frequency for > each CPU. > > Signed-off-by: Amit Kucheria > Suggested-by: Daniel Lezcano Acked-by: Daniel Lezcano > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 > 1 file changed,

Re: [PATCH v2 6/9] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states

2019-05-21 Thread Daniel Lezcano
ble by the CPUs. > > Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi > b/arch/arm64/boot/dts/qcom/msm8996.

Re: [PATCH v4 2/2] driver: clocksource: Add nxp system counter timer driver support

2019-05-21 Thread Daniel Lezcano
On 21/05/2019 09:18, Jacky Bai wrote: > From: Bai Ping > > The system counter (sys_ctr) is a programmable system counter > which provides a shared time base to the Cortex A15, A7, A53 etc cores. > It is intended for use in applications where the counter is always > powered on and supports

Re: [PATCH] clocksource: timer-meson6: update with SPDX Licence identifier

2019-05-21 Thread Daniel Lezcano
On 20/05/2019 16:00, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong > --- Applied, thanks. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook |

Re: [PATCHv1 8/8] arm64: dts: qcom: sdm845: Add PSCI cpuidle low power states

2019-05-17 Thread Daniel Lezcano
t; Reviewed-by: Evan Green > Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog

Re: [PATCHv1 7/8] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-05-17 Thread Daniel Lezcano
On 10/05/2019 13:29, Amit Kucheria wrote: > Add device bindings for cpuidle states for cpu devices. > > Cc: Marc Gonzalez > Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 32 +++ > 1 file c

Re: [PATCHv1 6/8] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states

2019-05-17 Thread Daniel Lezcano
On 10/05/2019 13:29, Amit Kucheria wrote: > Add device bindings for cpuidle states for cpu devices. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 28 +++ > 1 file changed, 28 insertions(+) > > diff --git

Re: [PATCHv1 5/8] arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states

2019-05-17 Thread Daniel Lezcano
f-by: Amit Kucheria Acked-by: Daniel Lezcano > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi > b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index e8fd26633d57..369c

Re: [PATCHv1 4/8] arm64: dts: qcom: msm8916: Use more generic idle state names

2019-05-17 Thread Daniel Lezcano
On 10/05/2019 13:29, Amit Kucheria wrote: > Instead of using Qualcomm-specific terminology, use generic node names > for the idle states that are easier to understand. Move the description > into the "idle-state-name" property. > > Signed-off-by: Amit Kucheria

Re: [PATCHv1 3/8] arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node

2019-05-17 Thread Daniel Lezcano
On 10/05/2019 13:29, Amit Kucheria wrote: > The idle-states binding documentation[1] mentions that the > 'entry-method' property is required on 64-bit platforms and must be set > to "psci". > > Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano > --- > a

Re: [PATCH V12 2/5] thermal: of-thermal: add API for getting sensor ID from DT

2019-05-16 Thread Daniel Lezcano
On 16/04/2019 05:22, Anson Huang wrote: > On some platforms like i.MX8QXP, the thermal driver needs a > real HW sensor ID from DT thermal zone, the HW sensor ID is > used to get temperature from SCU firmware, and the virtual > sensor ID starting from 0 to N is NOT used at all, this patch > adds

Re: [PATCH V12 3/5] thermal: imx_sc: add i.MX system controller thermal support

2019-05-16 Thread Daniel Lezcano
On 16/04/2019 05:22, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal driver support, > Linux kernel has to

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 13:01, Quentin Perret wrote: > On Wednesday 15 May 2019 at 12:51:57 (+0200), Daniel Lezcano wrote: >> On 15/05/2019 12:46, Quentin Perret wrote: >>> On Wednesday 15 May 2019 at 11:40:44 (+0100), Quentin Perret wrote: >> >> [ ... ] >> >>>

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 12:40, Quentin Perret wrote: > On Wednesday 15 May 2019 at 15:52:00 (+0530), Viresh Kumar wrote: >> On 15-05-19, 12:16, Daniel Lezcano wrote: >>> Viresh what do you think ? >> >> I agree with your last suggestions. They do make sense. > > Good :-)

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 12:46, Quentin Perret wrote: > On Wednesday 15 May 2019 at 11:40:44 (+0100), Quentin Perret wrote: [ ... ] >> +#ifdef CONFIG_THERMAL_GOV_POWER_ALLOCATOR >> if (capacitance) { >> ret = update_freq_table(cpufreq_cdev, capacitance); >> if (ret)

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 12:07, Quentin Perret wrote: > On Wednesday 15 May 2019 at 11:56:30 (+0200), Daniel Lezcano wrote: >> On 15/05/2019 11:17, Quentin Perret wrote: >>> Hi Daniel, >>> >>> On Wednesday 15 May 2019 at 11:06:18 (+0200), Daniel Lezcano wrote: >>&g

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 11:17, Quentin Perret wrote: > Hi Daniel, > > On Wednesday 15 May 2019 at 11:06:18 (+0200), Daniel Lezcano wrote: >> On 15/05/2019 10:23, Quentin Perret wrote: >>> In the current state, the perf_domain struct is fully defined only when >>> CON

Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct

2019-05-15 Thread Daniel Lezcano
On 15/05/2019 10:23, Quentin Perret wrote: > In the current state, the perf_domain struct is fully defined only when > CONFIG_ENERGY_MODEL=y. Since we need to write code that compiles both > with or without that option in the thermal framework, make sure to > actually define the struct regardless

Re: [PATCH v4 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL

2019-05-15 Thread Daniel Lezcano
h Kumar > Signed-off-by: Quentin Perret Acked-by: Daniel Lezcano > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 2d9c39033c1a..4881a752ab3f 100644 > --- a/arch

Re: [RFC 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-14 Thread Daniel Lezcano
On 17/04/2019 16:47, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently the clocksource and clockevent support for davinci platforms > lives in mach-davinci. It hard-codes many things, uses global variables, > implements functionalities unused by any platform and has code

Re: [PATCH 7/9] genirq/timings: Add selftest for circular array

2019-05-13 Thread Daniel Lezcano
On 13/05/2019 12:50, Andy Shevchenko wrote: > On Mon, May 13, 2019 at 12:29:51PM +0200, Daniel Lezcano wrote: >> Due to the complexity of the code and the difficulty to debug it, >> let's add some selftests to the framework in order to spot issues or >> regression at boot

[PATCH 1/9] genirq/timings: Fix next event index function

2019-05-13 Thread Daniel Lezcano
. Fixes: bbba0e7c5cda "genirq/timings: Add array suffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 53 1 file changed, 44 insertions(+), 9 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timin

[PATCH 0/9] genirq/timings: Fixes and selftests

2019-05-13 Thread Daniel Lezcano
samples to insert values in the arrays and use them to predict the next event. These tests cover the most difficult part of the code. Daniel Lezcano (9): genirq/timings: Fix next event index function genirq/timings: Fix timings buffer inspection genirq/timings: Optimize the period detection

[PATCH 2/9] genirq/timings: Fix timings buffer inspection

2019-05-13 Thread Daniel Lezcano
uffix computation code" Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 60362aca4ca4..250bb00ccd85 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/

[PATCH 4/9] genirq/timings: Use the min kernel macro

2019-05-13 Thread Daniel Lezcano
The' min' is available as a kernel macro. Use it instead of writing the same code. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 06bde5253a7d..8928601b4b42 100644

[PATCH 3/9] genirq/timings: Optimize the period detection speed

2019-05-13 Thread Daniel Lezcano
; <-> <-> In our case, the minimum period is 2 and the maximum period is 5. That means all repeating pattern of 2 will be detected as repeating pattern of 4, it is pointless to go up to 2 when searching for the period as it will always fail. Remove one loop iteration by increasing t

[PATCH 5/9] genirq/timings: Encapsulate timings push

2019-05-13 Thread Daniel Lezcano
-by: Daniel Lezcano --- kernel/irq/internals.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index 70c3053bc1f6..21f9927ff5ad 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -354,6

[PATCH 6/9] genirq/timings: Encapsulate storing function

2019-05-13 Thread Daniel Lezcano
For the next patches providing the selftest, we want to insert interval values directly in the buffer in order to check the correctness of the code. Encapsulate the code doing that in a always inline function in order to reuse it in the test code. No functional changes. Signed-off-by: Daniel

[PATCH 7/9] genirq/timings: Add selftest for circular array

2019-05-13 Thread Daniel Lezcano
/ decoding of the values - the macro to browse the irq timings circular buffer - the function to push data in the circular buffer Signed-off-by: Daniel Lezcano --- kernel/irq/Makefile | 3 ++ kernel/irq/timings.c | 119 +++ lib/Kconfig.debug| 9 3

[PATCH 8/9] genirq/timings: Add selftest for irqs circular buffer

2019-05-13 Thread Daniel Lezcano
After testing the per cpu interrupt circular event, we want to make sure the per interrupt circular buffer usage is correct. Add tests to validate the interrupt circular buffer. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 139 +++ 1 file

[PATCH 9/9] genirq/timings: Add selftest for next event computation

2019-05-13 Thread Daniel Lezcano
the last one. The next event computation must return the same value as the last element we did not inserted. Add tests for the next event index computation. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 66 1 file changed, 66 insertions(+) diff

Re: [RFC 0/2] clocksource: davinci-timer: new driver

2019-05-13 Thread Daniel Lezcano
On 13/05/2019 09:54, Bartosz Golaszewski wrote: > śr., 17 kwi 2019 o 16:47 Bartosz Golaszewski napisał(a): >> >> From: Bartosz Golaszewski >> >> Hi Daniel, >> >> as discussed - this is the davinci timer driver split into the clockevent >> and clocksource parts. >> >> Since it won't work without

Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node

2019-05-10 Thread Daniel Lezcano
On 08/05/2019 14:23, Michael Kao wrote: > On Mon, 2019-05-06 at 12:43 +0200, Daniel Lezcano wrote: >> On 03/05/2019 18:46, Matthias Kaehlcke wrote: >>> Hi, >>> >>> On Fri, May 03, 2019 at 04:03:58PM +0800, Hsin-Yi Wang wrote: >>>> On Thu,

Re: [EXT] Re: [PATCH v6] arm64: dts: ls1088a: add one more thermal zone node

2019-05-10 Thread Daniel Lezcano
On 10/05/2019 05:40, Andy Tang wrote: >> -Original Message- >> From: Shawn Guo >> Sent: 2019年5月10日 11:14 >> To: Andy Tang >> Cc: Leo Li ; robh...@kernel.org; >> mark.rutl...@arm.com; linux-arm-ker...@lists.infradead.org; >> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; >>

[PATCH 14/15] clocksource/drivers/timer-atmel-tcb: Convert tc_clksrc_suspend|resume() to static

2019-05-09 Thread Daniel Lezcano
From: kbuild test robot Statisticize tc_clksrc_suspend and tc_clksrc_resume. Signed-off-by: kbuild test robot Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-atmel-tcb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/15] clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer

2019-05-09 Thread Daniel Lezcano
Milbeaut SoCs") Signed-off-by: Sugaya Taichi Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-milbeaut.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers/clocksource/timer-milbeaut.c index f2019a88e3ee..9fd5d081fac4 100644 --- a

[PATCH 13/15] clocksource/drivers/tcb_clksrc: Rename the file for consistency

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni For the sake of consistency, let's rename the file to a name similar to other file names in this directory. Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource/Makefile| 2 +- drivers/clocksource

[PATCH 08/15] clocksource/drivers/tcb_clksrc: Stop depending on atmel_tclib

2019-05-09 Thread Daniel Lezcano
everything on our own using the correct device tree binding. This also allows getting rid of ATMEL_TCB_CLKSRC_BLOCK and makes the driver a bit more flexible as the TCB is not hardcoded in the kernel anymore. Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource

[PATCH 01/15] clocksource/drivers/sun4i: Add a compatible for suniv

2019-05-09 Thread Daniel Lezcano
, thus it has no architecture timer. Register sun4i_timer as sched_clock on it. Signed-off-by: Mesih Kilinc Acked-by: Maxime Ripard Acked-by: Daniel Lezcano Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-sun4i.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 03/15] clocksource/drivers/tegra: Rework for compensation of suspend time

2019-05-09 Thread Daniel Lezcano
From: Joseph Lo Since the clocksource framework has the support for suspend time compensation. Re-work the driver to use that, so we can reduce the duplicate code. Suggested-by: Daniel Lezcano Signed-off-by: Joseph Lo Acked-by: Thierry Reding Signed-off-by: Daniel Lezcano --- drivers

[PATCH 10/15] ARM: at91: Implement clocksource selection

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni Allow selecting and unselecting the PIT clocksource driver so it doesn't have to be compiled when unused. Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- arch/arm/mach-at91/Kconfig | 23 +++ 1 file changed, 23 insertions(+) diff

[PATCH 05/15] clocksource/drivers/timer-milbeaut: Add shutdown function

2019-05-09 Thread Daniel Lezcano
From: Sugaya Taichi Add a shutdown operation to support shutdown timer. Signed-off-by: Sugaya Taichi Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-milbeaut.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers

[PATCH 06/15] clocksource/drivers/timer-milbeaut: Cleanup common register accesses

2019-05-09 Thread Daniel Lezcano
From: Sugaya Taichi Aggregate common register accesses into shared functions for maintainability. Signed-off-by: Sugaya Taichi Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-milbeaut.c | 62 +--- 1 file changed, 39 insertions(+), 23 deletions(-) diff

[PATCH 07/15] ARM: at91: move SoC specific definitions to SoC folder

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni Move linux/atmel_tc.h to the SoC specific folder include/soc/at91. Signed-off-by: Alexandre Belloni Acked-by: Thierry Reding Acked-by: Arnd Bergmann Signed-off-by: Daniel Lezcano --- drivers/clocksource/tcb_clksrc.c | 2 +- drivers/misc

[PATCH 02/15] clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804

2019-05-09 Thread Daniel Lezcano
From: David Abdurachmanov This is only used on arm and arm64 platforms. Add COMPILE_TEST option. Tested with 5.1-rc3+ on Fedora/RISCV. CONFIG_ARM_TIMER_SP804 no more shows up in riscv config. Signed-off-by: David Abdurachmanov Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig

[PATCH 12/15] clocksource/drivers/timer-atmel-pit: Rework Kconfig option

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni Allow building the PIT driver when COMPILE_TEST is enabled. Also remove its default value so it can be disabled. Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH 11/15] clocksource/drivers/tcb_clksrc: Move Kconfig option

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni Move the ATMEL_TCB_CLKSRC option to drivers/clocksource and make it silent if COMPILE_TEST is not selected. Cc: Arnd Bergmann Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 7 +++ drivers/misc/Kconfig| 14

[PATCH 15/15] misc: atmel_tclib: Do not probe already used TCBs

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni The TCBs that have children are using the proper DT bindings and don't need to be handled by tclib. Acked-by: Greg Kroah-Hartman Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/misc/atmel_tclib.c | 3 +++ 1 file changed, 3 insertions

[PATCH 09/15] clocksource/drivers/tcb_clksrc: Use tcb as sched_clock

2019-05-09 Thread Daniel Lezcano
From: Alexandre Belloni Now that the driver is registered early enough, use the TCB as the sched_clock which is much more accurate than the jiffies implementation. Signed-off-by: Alexandre Belloni Signed-off-by: Daniel Lezcano --- drivers/clocksource/tcb_clksrc.c | 16 1

[GIT PULL] timer drivers for 5.2

2019-05-09 Thread Daniel Lezcano
Hi Thomas, here a (late) pull request for the changes on 5.2. - Add compatible string for suniv for sun4i (Mesih Kilinc) - Add COMPILE_TEST option for sp804 (David Abdurachmanov) - Replace the compensation time when suspend happens on tegra with the one provided by the generic framework

Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro

2019-05-06 Thread Daniel Lezcano
> The complete fix is to remove all MODULE_* and #include > like many "make ... explicitly non-modular" commits did. > > For now, I am touching the offending lines. > > Reported-by: Stephen Rothwell > Signed-off-by: Masahiro Yamada > --- Acked-by: Daniel Lezcano

Missing patches for thermal for 5.2

2019-05-06 Thread Daniel Lezcano
Hi Eduardo, Zhang, AFAICS, the following patches are missing for 5.2: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error [PATCH v3 2/3] dt-bindings: rockchip-thermal: Support the PX30 SoC compatible [PATCH

Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node

2019-05-06 Thread Daniel Lezcano
On 03/05/2019 18:46, Matthias Kaehlcke wrote: > Hi, > > On Fri, May 03, 2019 at 04:03:58PM +0800, Hsin-Yi Wang wrote: >> On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: >>> >>> Add thermal zone node to Mediatek MT8183 dts file. >>> >>> Signed-off-by: Michael Kao >>> --- >>>

Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node

2019-05-06 Thread Daniel Lezcano
On 02/05/2019 12:43, michael.kao wrote: > Add thermal zone node to Mediatek MT8183 dts file. > > Signed-off-by: Michael Kao > --- Hi Michael, the device tree binding for thermal specifies the thermal zone must define a cooling-maps (it is a required field). All the thermal zones below tzts1,

Re: [PATCH] thermal: cpu_cooling: Actually trace CPU load in thermal_power_cpu_get_power

2019-05-03 Thread Daniel Lezcano
the check. > > Fixes: 6828a4711f99 ("thermal: add trace events to the power allocator > governor") > Signed-off-by: Matthias Kaehlcke > --- Yes, load_cpu is needed in any case for both traces. The change makes sense. Reviewed-by: Daniel Lezcano -- <http://www.linaro.org

Re: [PATCH 7/7] clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters

2019-05-03 Thread Daniel Lezcano
Hi Valentin, On 30/04/2019 17:39, Valentin Schneider wrote: > Hi, > > On 30/04/2019 16:27, Marc Zyngier wrote: > [...] @@ -372,6 +392,7 @@ static u32 notrace sun50i_a64_read_cntv_tval_el0(void) DEFINE_PER_CPU(const struct arch_timer_erratum_workaround *,

Re: [PATCH 7/7] clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters

2019-05-03 Thread Daniel Lezcano
Hi Marc, On 30/04/2019 17:27, Marc Zyngier wrote: > On 15/04/2019 13:16, Daniel Lezcano wrote: >> On 08/04/2019 17:49, Marc Zyngier wrote: >>> Instead of always going via arch_counter_get_cntvct_stable to >>> access the counter workaround, let's have arch_time

Re: [PATCH 3/7] thermal/drivers/core: Add init section table for self-encapsulation

2019-05-03 Thread Daniel Lezcano
with this patch? if yes, I suppose I can take it through > my tree, right? Hi Zhang, given the Acked-by from Arnd, will you add the missing patches in the tree for 5.2? > On 一, 2019-04-22 at 14:11 +0200, Daniel Lezcano wrote: >> Hi Zhang, >> >> >> On 22/04/2019 1

Re: [PATCH 1/6] thermal: Introduce devm_thermal_of_cooling_device_register

2019-05-03 Thread Daniel Lezcano
On 01/05/2019 18:48, Guenter Roeck wrote: > On Thu, Apr 18, 2019 at 12:58:15PM -0700, Guenter Roeck wrote: >> thermal_of_cooling_device_register() and thermal_cooling_device_register() >> are typically called from driver probe functions, and >> thermal_cooling_device_unregister() is called from

Re: linux-next: Tree for May 2

2019-05-02 Thread Daniel Lezcano
On 03/05/2019 00:03, Stephen Rothwell wrote: > Hi Daniel, > > On Thu, 2 May 2019 22:09:49 +0200 Daniel Lezcano > wrote: >> >> Yes, I picked the patch and it was merged it via the tip tree [1] as >> requested by Marc Zyngier [2] and notified [3]. >> >&

Re: linux-next: Tree for May 2

2019-05-02 Thread Daniel Lezcano
On 02/05/2019 21:08, Nathan Chancellor wrote: > On Thu, May 02, 2019 at 09:00:58PM +0200, Anders Roxell wrote: >> On Thu, 2 May 2019 at 12:10, Stephen Rothwell wrote: >>> >>> Hi all, >>> >>> Changes since 20190501: >>> >>> The kbuild tree gained a conflict against Linus' tree. >>> >>> The f2fs

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Daniel Lezcano
to the RESET circuit on the hardware. > If the IO is in the wrong state, it will trigger RESET. > (similar to the effect of pressing the RESET button) > which will cause the soc to restart all the time. > > Signed-off-by: Elaine Zhang Reviewed-by: Daniel Lezcano > --- > drivers/th

Re: [PATCH v2 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Daniel Lezcano
On 29/04/2019 11:51, elaine.zhang wrote: [ ... ] > pinctrl select to gpio mode when tsadc suspend and shutdown. > > When suspend, tsadc is disabled, the otp_pin should revert to the > default gpio state. > >> >>>     return 0; >>>   } >>> @@ -1383,7 +1413,8 @@ static int __maybe_unused >>>

Re: [PATCH] thermal/drivers/of: Add a get_temp_id callback function

2019-04-29 Thread Daniel Lezcano
On 24/04/2019 01:08, Daniel Lezcano wrote: > On 23/04/2019 17:44, Eduardo Valentin wrote: >> Hello, >> >> On Tue, Apr 16, 2019 at 07:22:03PM +0200, Daniel Lezcano wrote: >>> Currently when we register a sensor, we specify the sensor id and a data >>> pointer

[PATCH - resend] thermal/drivers/cpu_cooling: Fixup the header and copyright

2019-04-29 Thread Daniel Lezcano
The copyright format does not conform to the format requested by Linaro: https://wiki.linaro.org/Copyright Fix it. Signed-off-by: Daniel Lezcano Acked-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/thermal

<    5   6   7   8   9   10   11   12   13   14   >