[PATCH 3/3] ARM: dts: mstar: Add a dts for M5Stack UnitV2

2021-04-16 Thread Daniel Palmer
M5Stack are releasing a new widget based on the SigmaStar SSD202D. We have some support for the SSD202D so lets add a dts for it. Link: https://m5stack-store.myshopify.com/products/unitv2-ai-camera-gc2145 Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/Makefile| 1

[PATCH 2/3] dt-bindings: arm: mstar: Add compatible for M5Stack UnitV2

2021-04-16 Thread Daniel Palmer
Add a compatible for the M5Stack UnitV2 that is based on the SigmaStar SSD202D (inifinity2m). Signed-off-by: Daniel Palmer --- Documentation/devicetree/bindings/arm/mstar/mstar.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml b

[PATCH 0/3] ARM: mstar: Add initial support for M5Stack UnitV2

2021-04-16 Thread Daniel Palmer
else to help with cleaning up and pushing the commits for these SoCs. Link: https://m5stack-store.myshopify.com/products/unitv2-ai-camera-gc2145 Daniel Palmer (3): dt-bindings: vendor-prefixes: Add vendor prefix for M5Stack dt-bindings: arm: mstar: Add compatible for M5Stack UnitV2 ARM: dts

[PATCH 1/3] dt-bindings: vendor-prefixes: Add vendor prefix for M5Stack

2021-04-16 Thread Daniel Palmer
M5Stack make various modules for STEM, Makers, IoT. Their UnitV2 is based on a SigmaStar SSD202D SoC which we already have some minimal support for so add a prefix in preparation for UnitV2 board support. Link: https://m5stack.com/ Signed-off-by: Daniel Palmer --- Documentation/devicetree

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-04-07 Thread Daniel Palmer
Hi Miquel, On Wed, 7 Apr 2021 at 17:02, Miquel Raynal wrote: > You may look at micron_8_ecc_get_status() helper to guide you. But > IMHO, if there are 0-3 bf, you should probably assume there were 3 bf > and return 3, if there were 4, return 4, if it's uncorrectable return > -EBADMSG otherwise

Re: [PATCH 1/8] dt-bindings: clk: mstar msc313 cpupll binding description

2021-04-01 Thread Daniel Palmer
Hi Arnd, On Thu, 1 Apr 2021 at 20:04, Arnd Bergmann wrote: > I found this is still in patchwork as not merged, and I have not > seen a replacement. Marking all eight patches as 'changes requested' now, > please resend. Understood. I will resend. Thanks, Daniel

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-26 Thread Daniel Palmer
Hi Miquel, Sorry for the constant pestering on this.. On Tue, 23 Mar 2021 at 23:06, Miquel Raynal wrote: > > # nandbiterrs -i /dev/mtd1 > > incremental biterrors test > > Successfully corrected 0 bit errors per subpage > > Inserted biterror @ 0/5 > > Read reported 4 corrected bit errors > > ECC

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 23:06, Miquel Raynal wrote: > > > > # nandbiterrs -i /dev/mtd1 > > incremental biterrors test > > Successfully corrected 0 bit errors per subpage > > Inserted biterror @ 0/5 > > Read reported 4 corrected bit errors > > ECC failure, invalid data despite read

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 19:32, Miquel Raynal wrote: > You can run nandbiterrs -i /dev/mtdX > > You'll see if there is ECC correction or not (and its level). These are results I get for both of the nandbiterrs tests. # nandbiterrs -i /dev/mtd1 incremental biterrors test Successfully

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 03:32, Miquel Raynal wrote: > > I think this shows that the datasheet is right in that the complete 64 > > bytes of "spare area" is usable. > > I have no idea where it puts the ECC though. :) > > Argh, I don't like when hardware tries to be smart. I'm sort of

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-22 Thread Daniel Palmer
Hi Miquel, Sorry for the resend. Gmail randomly switched to HTML email so the original version seems to have bounced. On Mon, 15 Feb 2021 at 20:16, Miquel Raynal wrote: > > "2. Spare area 800H to 83FH is all available for user. > > ECC parity codes are programmed in > > additional space and

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

2021-03-12 Thread Daniel Palmer
On Fri, 12 Mar 2021 at 01:11, Mark-PK Tsai wrote: > Why irq could accept either? As the irq intc has no way to clear it's triggered state (no eoi) it must just pass the signal through instead of latching it? Otherwise it would latch once and never again right? That's what I really didn't

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

2021-03-11 Thread Daniel Palmer
Hi Mark-PK. On Thu, 11 Mar 2021 at 12:12, Mark-PK Tsai wrote: > For a fiq controller, the input edge signal will be convert to level and > keep the interrupt status until we do EOI operation. > That means if a rising edge input if trigger the ouput line will keep high > until we clear the

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

2021-03-10 Thread Daniel Palmer
Hi Mark-PK, On Mon, 8 Mar 2021 at 23:30, Mark-PK Tsai wrote: > From: Daniel Palmer > >On Mon, 8 Mar 2021 at 15:05, Mark-PK Tsai wrote: > >> +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > > > +{ > >> + if

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

2021-03-08 Thread Daniel Palmer
Hi Mark-PK, On Mon, 8 Mar 2021 at 15:05, Mark-PK Tsai wrote: > +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > +{ > + if (type != IRQ_TYPE_LEVEL_LOW && type != IRQ_TYPE_LEVEL_HIGH) > + return -EINVAL; > + Does this mean we can't do rising or

Re: [PATCH] irqchip/irq-mst: Support polarity configuration

2021-03-08 Thread Daniel Palmer
gt; And all the irqs of Mstar intc are masked by default when the IP powered on. > > > Best regards, > Mark-PK Tsai > > > -Original Message----- > From: Marc Zyngier [mailto:m...@kernel.org] > Sent: Sunday, March 7, 2021 2:28 AM > To: Daniel Palmer > Cc: Mark-PK Tsa

Re: [PATCH] irqchip/irq-mst: Support polarity configuration

2021-03-06 Thread Daniel Palmer
Hi Mark-PK, I'm trying to understand the logic behind the changes. It seems like the polarity of interrupts is always the same between the MStar intc and the GIC? Low level interrupts are handled in the mstar intc and become high level interrupts to the GIC? I think for the Mstar MSC313(e) and

[PATCH 1/3] ARM: mstar: Select MSTAR_MSC313_MPLL

2021-03-01 Thread Daniel Palmer
All of the ARCH_MSTARV7 chips have an MPLL as the source for peripheral clocks so select MSTAR_MSC313_MPLL. Signed-off-by: Daniel Palmer --- arch/arm/mach-mstar/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mstar/Kconfig b/arch/arm/mach-mstar/Kconfig index

[PATCH 3/3] ARM: mstar: Add mpll to base dtsi

2021-03-01 Thread Daniel Palmer
All of the currently known MStar/SigmaStar ARMv7 SoCs have at least one MPLL and it seems to always be at the same place so add it to the base dtsi. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 0/3] ARM: mstar: MPLL mop up

2021-03-01 Thread Daniel Palmer
This series is just 3 small patches that got left behind when the MPLL driver was merged. Link: https://lore.kernel.org/linux-arm-kernel/20210211052206.2955988-1-dan...@0x0f.com/ Daniel Palmer (3): ARM: mstar: Select MSTAR_MSC313_MPLL ARM: mstar: Add the external clocks to the base dsti

[PATCH 2/3] ARM: mstar: Add the external clocks to the base dsti

2021-03-01 Thread Daniel Palmer
RTC node is disabled by default and should be enabled at the board level if the RTC input is wired up. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dts

Re: [PATCH 1/8] dt-bindings: clk: mstar msc313 cpupll binding description

2021-02-26 Thread Daniel Palmer
Hi Rob's bot On Wed, 24 Feb 2021 at 04:34, Rob Herring wrote: > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.example.dts:19:18: > fatal error: dt-bindings/clock/mstar-msc313-mpll.h: No such file or directory >19 | #include > |

[PATCH 7/8] ARM: mstar: Add OPP table for infinity3

2021-02-22 Thread Daniel Palmer
The infinity3 has a slightly higher max frequency compared to the infinity so extend the OPP table. Co-authored-by: Willy Tarreau Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity3.dtsi | 58 ++ 1 file changed, 58 insertions(+) diff --git a/arch/arm

[PATCH 6/8] ARM: mstar: Add OPP table for infinity

2021-02-22 Thread Daniel Palmer
Add an OPP table for the inifinity chips so that cpu frequency scaling can happen. Co-authored-by: Willy Tarreau Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity.dtsi | 34 +++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/mstar

[PATCH 8/8] ARM: mstar: Add OPP table for mercury5

2021-02-22 Thread Daniel Palmer
Add an OPP table for mercury5 so that cpu frequency scaling can happen. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-mercury5.dtsi | 36 +++ 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/mstar-mercury5.dtsi b/arch/arm/boot/dts/mstar

[PATCH 5/8] ARM: mstar: Link cpupll to second core

2021-02-22 Thread Daniel Palmer
The second core also sources it's clock from the CPU PLL. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/mstar-infinity2m.dtsi b/arch/arm/boot/dts/mstar-infinity2m.dtsi index 6d4d1d224e96

[PATCH 4/8] ARM: mstar: Link cpupll to cpu

2021-02-22 Thread Daniel Palmer
The CPU clock is sourced from the CPU PLL. Link cpupll to the cpu so that frequency scaling can happen. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi index

[PATCH 3/8] ARM: mstar: Add cpupll to base dtsi

2021-02-22 Thread Daniel Palmer
All MStar/SigmaStar ARMv7 SoCs have the CPU PLL at the same place so add it to the base dtsi. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi index

[PATCH 2/8] clk: mstar: msc313 cpupll clk driver

2021-02-22 Thread Daniel Palmer
-by: Daniel Palmer --- drivers/clk/mstar/Kconfig | 7 + drivers/clk/mstar/Makefile| 1 + drivers/clk/mstar/clk-msc313-cpupll.c | 228 ++ 3 files changed, 236 insertions(+) create mode 100644 drivers/clk/mstar/clk-msc313-cpupll.c diff --git

[PATCH 1/8] dt-bindings: clk: mstar msc313 cpupll binding description

2021-02-22 Thread Daniel Palmer
Add a binding description for the MStar/SigmaStar CPU PLL block. Signed-off-by: Daniel Palmer --- .../bindings/clock/mstar,msc313-cpupll.yaml | 45 +++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml diff

[PATCH 0/8] ARM: mstar: cpupll

2021-02-22 Thread Daniel Palmer
This series adds a scrappy driver for the PLL that generates the cpu clock on MStar/SigmaStar ARMv7 SoCs. Unfortunately there isn't much documentation for this thing so there are few magic values and guesses. This needs to come after the MPLL DT changes. Daniel Palmer (8): dt-bindings: clk

Re: [PATCH v2 0/7] ARM: mstar: Basic MPLL support

2021-02-22 Thread Daniel Palmer
Hi Arnd and Olof, On Thu, 11 Feb 2021 at 14:22, Daniel Palmer wrote: > Daniel Palmer (7): > dt-bindings: clk: mstar msc313 mpll binding header > dt-bindings: clk: mstar msc313 mpll binding description > clk: fixed: add devm helper for clk_hw_register_fixed_factor() > cl

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Daniel Palmer
Hi Miquel, On Mon, 15 Feb 2021 at 20:16, Miquel Raynal wrote: > But a changelog should always be added when you change something > between two versions. And the changelog can be located below the three > dashes ("---") without being part of the final commit message, it does > not need to be in a

Re: [PATCH v2 4/7] clk: mstar: MStar/SigmaStar MPLL driver

2021-02-15 Thread Daniel Palmer
Hi Stephen, On Mon, 15 Feb 2021 at 05:48, Stephen Boyd wrote: > BTW, it would be nice to expose this driver to compile testing instead > of putting it behind ARCH_MSTARTV7. Can we have this patch? I like that idea. I'll send a patch. Thanks, Daniel

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Daniel Palmer
Hi Miquel, On Mon, 15 Feb 2021 at 19:24, Miquel Raynal wrote: > > Can you please add a changelog here when you send a new version of a > patch? Sorry, I was going to add a cover letter but elsewhere got told that one isn't needed for a single patch.. Basically I changed FS35ND01G to

[PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-13 Thread Daniel Palmer
Add support for the Foresee FS35ND01G-S1Y2 manufactured by Longsys. Signed-off-by: Daniel Palmer Link: https://datasheet.lcsc.com/szlcsc/2008121142_FORESEE-FS35ND01G-S1Y2QWFI000_C719495.pdf --- drivers/mtd/nand/spi/Makefile | 2 +- drivers/mtd/nand/spi/core.c| 1 + drivers/mtd/nand/spi

[PATCH v2 7/7] ARM: mstar: Add mpll to base dtsi

2021-02-10 Thread Daniel Palmer
All of the currently known MStar/SigmaStar ARMv7 SoCs have at least one MPLL and it seems to always be at the same place so add it to the base dtsi. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 6/7] ARM: mstar: Add the external clocks to the base dsti

2021-02-10 Thread Daniel Palmer
RTC node is disabled by default and should be enabled at the board level if the RTC input is wired up. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-v7.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dts

[PATCH v2 4/7] clk: mstar: MStar/SigmaStar MPLL driver

2021-02-10 Thread Daniel Palmer
the MPLL block found in the MSC313/MSC313E but there is no documentation this chip so the register descriptions for the another MStar chip the MST786 were used as they seem to match. Signed-off-by: Daniel Palmer --- MAINTAINERS | 1 + drivers/clk/Kconfig

[PATCH v2 5/7] ARM: mstar: Select MSTAR_MSC313_MPLL

2021-02-10 Thread Daniel Palmer
All of the ARCH_MSTARV7 chips have an MPLL as the source for peripheral clocks so select MSTAR_MSC313_MPLL. Signed-off-by: Daniel Palmer --- arch/arm/mach-mstar/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mstar/Kconfig b/arch/arm/mach-mstar/Kconfig index

[PATCH v2 2/7] dt-bindings: clk: mstar msc313 mpll binding description

2021-02-10 Thread Daniel Palmer
Add a binding description for the MStar/SigmaStar MPLL clock block. Signed-off-by: Daniel Palmer --- .../bindings/clock/mstar,msc313-mpll.yaml | 46 +++ MAINTAINERS | 1 + 2 files changed, 47 insertions(+) create mode 100644 Documentation

[PATCH v2 3/7] clk: fixed: add devm helper for clk_hw_register_fixed_factor()

2021-02-10 Thread Daniel Palmer
Add a devm helper for clk_hw_register_fixed_factor() so that drivers that internally register fixed factor clocks for things like dividers don't need to manually unregister them on remove or if probe fails. Signed-off-by: Daniel Palmer --- drivers/clk/clk-fixed-factor.c | 39

[PATCH v2 1/7] dt-bindings: clk: mstar msc313 mpll binding header

2021-02-10 Thread Daniel Palmer
Simple header to document the relationship between the MPLL outputs and which divider they come from. Output 0 is missing because it should not be consumed. Signed-off-by: Daniel Palmer Acked-by: Rob Herring --- MAINTAINERS | 1 + include/dt-bindings/clock

[PATCH v2 0/7] ARM: mstar: Basic MPLL support

2021-02-10 Thread Daniel Palmer
on Stephen's feedback. Daniel Palmer (7): dt-bindings: clk: mstar msc313 mpll binding header dt-bindings: clk: mstar msc313 mpll binding description clk: fixed: add devm helper for clk_hw_register_fixed_factor() clk: mstar: MStar/SigmaStar MPLL driver ARM: mstar: Select

Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description

2021-02-10 Thread Daniel Palmer
Hi Stephen, On Wed, 10 Feb 2021 at 11:29, Stephen Boyd wrote: > The child clks should be using clk_parent_data to point to the parent > clks through DT. That way the name of the clk doesn't matter except for > debug purposes. I think I get it now. I was using of_clk_parent_fill() to get the

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Daniel Palmer
Hi Hector, On Wed, 10 Feb 2021 at 20:49, Hector Martin wrote: > > Yeah, just don't use an imaginary dummy index for the reg. Use a real > > register offset from a clock controller instance base, and a register > > bit offset too if needed. > > I mean for fixed input clocks without any

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-03 Thread Daniel Palmer
-gpio"; >#gpio-cells = <2>; >reg = <0x207800 0x200>; >gpio-controller; This is correct. The compatible string dropped the e at some point and I must have missed the example. Thanks for the fix. Reviewed-by: Daniel Palmer

Re: Old platforms: bring out your dead

2021-01-11 Thread Daniel Palmer
Hi Adrian, On Mon, 11 Jan 2021 at 18:17, John Paul Adrian Glaubitz wrote: > > Hi Daniel! > > On Sat, 9 Jan 2021 at 07:56, Arnd Bergmann wrote: > >> * 68000/68328 (Dragonball): these are less capable than the > >> 68020+ or the Coldfire MCF5xxx line and similar to the 68360 > >> that was

Re: Old platforms: bring out your dead

2021-01-10 Thread Daniel Palmer
Hi Arnd, On Sat, 9 Jan 2021 at 07:56, Arnd Bergmann wrote: > * 68000/68328 (Dragonball): these are less capable than the > 68020+ or the Coldfire MCF5xxx line and similar to the 68360 > that was removed in 2016. I have some patches for the DragonBall series to enable SPI etc there, some

Re: [PATCH 1/1] mtd: spinand: add support for Foresee FS35ND01G

2021-01-05 Thread Daniel Palmer
Hi Miquel, On Mon, 4 Jan 2021 at 23:17, Miquel Raynal wrote: > Perhaps giving the link of the datasheet here makes sense. Noted. I'll put that into v2. > > +#define SPINAND_MFR_LONGSYS 0xcd > > Nitpick: I personally prefer uppercase hex numbers. > Noted. > > +

Re: [PATCH] USB: serial: option: add LongSung M5710 module support

2021-01-04 Thread Daniel Palmer
Hi Johan, On Mon, 4 Jan 2021 at 19:32, Johan Hovold wrote: > Also, would you mind posting the "lsusb -v" output for this device for > reference? The lsusb from busybox on this system doesn't support the -v option it seems. Here is the output from /sys/kernel/debug/usb/devices: T: Bus=01

[PATCH 1/1] mtd: spinand: add support for Foresee FS35ND01G

2020-12-28 Thread Daniel Palmer
Add support for the Foresee FS35ND01G manufactured by Longsys. Signed-off-by: Daniel Palmer --- drivers/mtd/nand/spi/Makefile | 2 +- drivers/mtd/nand/spi/core.c| 1 + drivers/mtd/nand/spi/longsys.c | 45 ++ include/linux/mtd/spinand.h| 1 + 4 files

[PATCH 0/1] Add basic support for Foresee SPI NAND

2020-12-28 Thread Daniel Palmer
. The datasheet for this chip is linked. If someone that actually knows what they're doing could take a look and point out my mistakes that would be great. Link: https://datasheet.lcsc.com/szlcsc/2008121142_FORESEE-FS35ND01G-S1Y2QWFI000_C719495.pdf Daniel Palmer (1): mtd: spinand: add support

[PATCH] USB: serial: option: add LongSung M5710 module support

2020-12-26 Thread Daniel Palmer
Add a vendor id for LongSung and a product id for the M5710 module. Signed-off-by: Daniel Palmer --- drivers/usb/serial/option.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 2c21e34235bb..2666e061c38d 100644

[PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi

2020-12-23 Thread Daniel Palmer
dts. Signed-off-by: Daniel Palmer --- .../dts/mstar-infinity-breadbee-common.dtsi | 49 +++ .../mstar-infinity-msc313-breadbee_crust.dts | 1 + .../dts/mstar-infinity3-msc313e-breadbee.dts | 1 + 3 files changed, 51 insertions(+) create mode 100644 arch/arm/boot/dts/mstar

Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description

2020-12-21 Thread Daniel Palmer
Hi Stephen, On Mon, 21 Dec 2020 at 03:44, Stephen Boyd wrote: > > Quoting Daniel Palmer (2020-12-19 22:35:41) > > Hi Stephen, > > > > On Sun, 20 Dec 2020 at 12:39, Stephen Boyd wrote: > > > > + clock-output-names: > > > > +minItems: 8 &

Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-21 Thread Daniel Palmer
Hi Stephen, On Mon, 21 Dec 2020 at 03:43, Stephen Boyd wrote: > Can be part of the same series. Ok. I have added a small patch that adds devm_clk_hw_register_fixed_factor(). I'll send that in the v2 once the clock names issue is resolved. Thanks, Daniel

Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-19 Thread Daniel Palmer
Hi Stephen, On Sun, 20 Dec 2020 at 13:36, Stephen Boyd wrote: > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > > index da8fcf147eb1..b758aae17ab8 100644 > > --- a/drivers/clk/Makefile > > +++ b/drivers/clk/Makefile > > @@ -124,3 +124,4 @@ endif > > obj-$(CONFIG_ARCH_ZX)

Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description

2020-12-19 Thread Daniel Palmer
Hi Stephen, On Sun, 20 Dec 2020 at 12:39, Stephen Boyd wrote: > > + clock-output-names: > > +minItems: 8 > > +maxItems: 8 > > +description: | > > + This should provide a name for the internal PLL clock and then > > + a name for each of the divided outputs. > > Is this

Re: [PATCH 1/7] ARM: mstar: Unify common parts of BreadBee boards into a dtsi

2020-12-11 Thread Daniel Palmer
Hi all, >[PATCH 1/7] Sorry, this isn't actually a 1/7 it's 1/1. I forgot to fix the subject before sending. Thanks, Daniel

[PATCH 1/7] ARM: mstar: Unify common parts of BreadBee boards into a dtsi

2020-12-11 Thread Daniel Palmer
dts. Signed-off-by: Daniel Palmer --- .../dts/mstar-infinity-breadbee-common.dtsi | 47 +++ .../mstar-infinity-msc313-breadbee_crust.dts | 1 + .../dts/mstar-infinity3-msc313e-breadbee.dts | 1 + 3 files changed, 49 insertions(+) create mode 100644 arch/arm/boot/dts/mstar

[PATCH] dt-bindings: vendor-prefixes: Fix misordering introduced by honestar prefix

2020-12-11 Thread Daniel Palmer
The prefix for honestar should come before honeywell. Fixes: 43181b5d8072 ("dt-bindings: vendor-prefixes: Add honestar vendor prefix") Link: https://lore.kernel.org/linux-arm-kernel/cafr9pxmwoeuhha-kdel1ys8bwvovrt43mxxyy1j+hgbxwpu...@mail.gmail.com/ Signed-off-by: Dan

Re: [PATCH v4 3/5] gpio: msc313: MStar MSC313 GPIO driver

2020-12-10 Thread Daniel Palmer
Hi Arnd, On Thu, 10 Dec 2020 at 23:28, Arnd Bergmann wrote: > > I did think about this and I did this with the clk mux driver I > > haven't pushed yet. In that case there is a random lump of registers > > with some muxes mixed into it so I decided to make the lump a syscon > > and then have a

Re: [PATCH v4 3/5] gpio: msc313: MStar MSC313 GPIO driver

2020-12-10 Thread Daniel Palmer
Hi Andy, On Thu, 10 Dec 2020 at 23:22, Andy Shevchenko wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Perhaps ordered? Ok. I did try to find some rules on includes, mainly what should be included even though it's included in

Re: [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl

2020-12-10 Thread Daniel Palmer
Hi Arnd, On Thu, 10 Dec 2020 at 02:45, Arnd Bergmann wrote: > Daniel, please send patches on top of this series to address Rob's > comments. Will do. On the enabled method one I had a question for Rob so I'll wait for a reply to that and then send the fixes. Sorry about the trouble caused.

Re: [PATCH v2 02/10] dt-bindings: vendor-prefixes: Add honestar vendor prefix

2020-12-10 Thread Daniel Palmer
Hi Rob, On Thu, 10 Dec 2020 at 01:34, Rob Herring wrote: > > + "^honestar,.*": > > +description: Honestar Technologies Co., Ltd. > > Alphabetical order please. Sorry about that. I intended to do that but apparently don't know the alphabet anymore.. Thanks, Daniel

Re: [PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl

2020-12-10 Thread Daniel Palmer
Hi Rob, On Thu, 10 Dec 2020 at 01:35, Rob Herring wrote: > On Tue, Dec 01, 2020 at 10:43:21PM +0900, Daniel Palmer wrote: > > This adds a YAML description of the smpctrl node needed by the > > platform code for the MStar/SigmaStar Armv7 SoCs to boot secondary cpus. > > You n

Re: [PATCH v4 3/5] gpio: msc313: MStar MSC313 GPIO driver

2020-12-10 Thread Daniel Palmer
Hi Arnd, On Thu, 10 Dec 2020 at 06:58, Arnd Bergmann wrote: > These seem to just be contiguous ranges, so I probably would have > suggested describing them as separate gpio controllers to avoid > all the complexity with the names. As Linus already merged the > driver into the gpio tree, I won't

Re: [PATCH 2/2] pinctrl: ingenic: Only support SoCs enabled in config

2020-12-09 Thread Daniel Palmer
Hi Paul and others, Sorry to hijack this but I actually want to do something similar to this in some other drivers. The targets I'm working with have only 64MB of ram so I want to remove code wherever possible. Is there any reason to do it like this instead of wrapping the whole unneeded

Re: [PATCH v4 0/5] Add GPIO support for MStar/SigmaStar ARMv7

2020-12-07 Thread Daniel Palmer
Hi Linus, On Sun, 6 Dec 2020 at 06:43, Linus Walleij wrote: > OK finished! > Patches 1, 2 & 3 applied to the GPIO tree for v5.11. Awesome! Thank you Linus. :) Arnd and Olof: Sorry for being a noob.. Is there anything I need to do for patches 4 and 5 (device tree bits)? They are in the Linux

Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-02 Thread Daniel Palmer
Hi Russell, On Wed, 2 Dec 2020 at 00:04, Russell King - ARM Linux admin wrote: > > On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > > + smpctrl = of_iomap(np, 0);

[PATCH v2 04/10] ARM: mstar: Add infinity2m support

2020-12-01 Thread Daniel Palmer
, instead of a camera interface they have display hardware and so on. Aside from the above points the big difference about these chips is that they include a second Cortex A7 core. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m.dtsi | 15 +++ arch/arm/boot/dts

[PATCH v2 10/10] ARM: mstar: SMP support

2020-12-01 Thread Daniel Palmer
to handle multiple cores is fine if there is only one core the will get booted. This might need to be reconsidered if chips with more cores turn up. Signed-off-by: Daniel Palmer --- arch/arm/mach-mstar/mstarv7.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/arc

[PATCH v2 08/10] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

2020-12-01 Thread Daniel Palmer
Add the smpctrl registers to the infinity2m dtsi so that the second CPU can be enabled on chips in this family. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/mstar-infinity2m.dtsi b/arch/arm

[PATCH v2 09/10] ARM: mstar: Wire up smpctrl for SSD201/SSD202D

2020-12-01 Thread Daniel Palmer
Add the specific compat string for the smpctrl registers to the SSD201/SSD202D common dtsi. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m-ssd20xd.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd20xd.dtsi b/arch/arm/boot

[PATCH v2 07/10] ARM: mstar: Add dts for Honestar ssd201htv2

2020-12-01 Thread Daniel Palmer
Add a dts for the Honestar ssd201htv2 devkit. This is for the board populated with a SSD202D. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/Makefile| 1 + .../mstar-infinity2m-ssd202d-ssd201htv2.dts | 25 +++ 2 files changed, 26 insertions(+) create

[PATCH v2 03/10] dt-bindings: mstar: Add Honestar SSD201_HT_V2 to mstar boards

2020-12-01 Thread Daniel Palmer
The Honestar SSD201_HT_V2 is a full size devkit for the SigmaStar SSD201 or SSD202D (they are pin compatible). Currently only the SSD202D version is supported as that's the one I have. Link: https://linux-chenxing.org/infinity2/ssd201_ht_v2/ Signed-off-by: Daniel Palmer --- Documentation

[PATCH v2 06/10] ARM: mstar: Add chip level dtsi for SSD202D

2020-12-01 Thread Daniel Palmer
Add a chip level dtsi for the SigmaStar SSD202D Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m-ssd202d.dtsi | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d.dtsi diff --git a/arch/arm/boot/dts/mstar

[PATCH v2 05/10] ARM: mstar: Add common dtsi for SSD201/SSD202D

2020-12-01 Thread Daniel Palmer
The SSD201 and SSD202D are basically the same chip with a different DDR die packaged (64MB DDR2 or 128MB DDR3). This patch adds a shared dtsi for the common parts of these chips like gpio, pinctrl etc. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m-ssd20xd.dtsi | 7

[PATCH v2 00/10] ARM: mstar: Add basic support for i2m and SMP

2020-12-01 Thread Daniel Palmer
pdmxnwjgw_ozinku93lp+eyq8qacmh4eesh...@mail.gmail.com/ Daniel Palmer (10): dt-bindings: mstar: Add binding details for mstar,smpctrl dt-bindings: vendor-prefixes: Add honestar vendor prefix dt-bindings: mstar: Add Honestar SSD201_HT_V2 to mstar boards ARM: mstar: Add infinity2m support AR

[PATCH v2 02/10] dt-bindings: vendor-prefixes: Add honestar vendor prefix

2020-12-01 Thread Daniel Palmer
Add prefix for Honestar Technologies Co., Ltd. Signed-off-by: Daniel Palmer --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor

[PATCH v2 01/10] dt-bindings: mstar: Add binding details for mstar,smpctrl

2020-12-01 Thread Daniel Palmer
This adds a YAML description of the smpctrl node needed by the platform code for the MStar/SigmaStar Armv7 SoCs to boot secondary cpus. Signed-off-by: Daniel Palmer --- .../bindings/arm/mstar/mstar,smpctrl.yaml | 40 +++ 1 file changed, 40 insertions(+) create mode 100644

Re: [PATCH 9/9] ARM: mstar: SMP support

2020-11-30 Thread Daniel Palmer
Hi Arnd, On Mon, 30 Nov 2020 at 22:42, Arnd Bergmann wrote: > > +struct smp_operations __initdata mstarv7_smp_ops = { > > + .smp_boot_secondary = mstarv7_boot_secondary, > > +}; > > +#endif > > So no hotplug operations? Not yet. There are controls to power down different bits of the

Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

2020-11-30 Thread Daniel Palmer
Hi Arnd, On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann wrote: > > On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer wrote: > > > > + { > > + smpctrl@204000 { > > + compatible = "mstar,smpctrl"; > > + reg = <0x

[PATCH 4/9] ARM: mstar: Add infinity2m support

2020-11-30 Thread Daniel Palmer
, instead of a camera interface they have display hardware and so on. Aside from the above points the big difference about these chips is that they include a second Cortex A7 core. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m.dtsi | 15 +++ arch/arm/boot/dts

[PATCH 5/9] ARM: mstar: Add common dtsi for SSD201/SSD202D

2020-11-30 Thread Daniel Palmer
The SSD201 and SSD202D are basically the same chip with a different DDR die packaged (64MB DDR2 or 128MB DDR3). This patch adds a shared dtsi for the common parts of these chips like gpio, pinctrl etc. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m-ssd20xd.dtsi | 7

[PATCH 9/9] ARM: mstar: SMP support

2020-11-30 Thread Daniel Palmer
to handle multiple cores is fine if there is only one core the will get booted. This might need to be reconsidered if chips with more cores turn up. Signed-off-by: Daniel Palmer --- arch/arm/mach-mstar/mstarv7.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arc

[PATCH 6/9] ARM: mstar: Add chip level dtsi for SSD202D

2020-11-30 Thread Daniel Palmer
Add a chip level dtsi for the SigmaStar SSD202D Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m-ssd202d.dtsi | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d.dtsi diff --git a/arch/arm/boot/dts/mstar

[PATCH 3/9] dt-bindings: mstar: Add Honestar SSD201_HT_V2 to mstar boards

2020-11-30 Thread Daniel Palmer
The Honestar SSD201_HT_V2 is a full size devkit for the SigmaStar SSD201 or SSD202D (they are pin compatible). Currently only the SSD202D version is supported as that's the one I have. Link: https://linux-chenxing.org/infinity2/ssd201_ht_v2/ Signed-off-by: Daniel Palmer --- Documentation

[PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

2020-11-30 Thread Daniel Palmer
Add the smpctrl registers to the infinity2m dtsi so that the second CPU can be enabled on chips in this family. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/mstar-infinity2m.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/mstar-infinity2m.dtsi b/arch

[PATCH 0/9] ARM: mstar: Add basic support for i2m and SMP

2020-11-30 Thread Daniel Palmer
This series adds basic support for the infinity2m series of chips. For now the SigmaStar SSD202D which is a dual Cortex A7 in a QFN128 package. These chips share most of the same hardware with the currently supported infinity, infinity3 and mercury5 chips. Daniel Palmer (9): dt-bindings: mstar

[PATCH 1/9] dt-bindings: mstar: Add binding details for mstar,smpctrl

2020-11-30 Thread Daniel Palmer
This adds a YAML description of the smpctrl node needed by the platform code for the MStar/SigmaStar Armv7 SoCs to boot secondary cpus. Signed-off-by: Daniel Palmer --- .../bindings/arm/mstar/mstar,smpctrl.yaml | 38 +++ 1 file changed, 38 insertions(+) create mode 100644

[PATCH 7/9] ARM: mstar: Add dts for Honestar ssd201htv2

2020-11-30 Thread Daniel Palmer
Add a dts for the Honestar ssd201htv2 devkit. This is for the board populated with a SSD202D. Signed-off-by: Daniel Palmer --- arch/arm/boot/dts/Makefile| 1 + .../mstar-infinity2m-ssd202d-ssd201htv2.dts | 25 +++ 2 files changed, 26 insertions(+) create

[PATCH 2/9] dt-bindings: vendor-prefixes: Add honestar vendor prefix

2020-11-30 Thread Daniel Palmer
Add prefix for Honestar Technologies Co., Ltd. Signed-off-by: Daniel Palmer --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor

[PATCH v4 5/5] ARM: mstar: Fill in GPIO controller properties for infinity

2020-11-29 Thread Daniel Palmer
Fill in the properties needed to use the GPIO controller in the infinity and infinity3 chips. Signed-off-by: Daniel Palmer Acked-by: Linus Walleij --- arch/arm/boot/dts/mstar-infinity.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/mstar-infinity.dtsi b/arch

[PATCH v4 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver

2020-11-29 Thread Daniel Palmer
somewhere to go. Because of the above the driver itself uses the index of a pin's offset in an array of the possible offsets for a chip as the gpio number. Signed-off-by: Daniel Palmer Reviewed-by: Rob Herring --- MAINTAINERS| 1 + include/dt-bindings/gpio/msc313-gpio.h

[PATCH v4 4/5] ARM: mstar: Add gpio controller to MStar base dtsi

2020-11-29 Thread Daniel Palmer
The GPIO controller is at the same address in all of the currently known chips so create a node for it in the base dtsi. Some extra properties are needed to actually use it so disable it by default. Signed-off-by: Daniel Palmer Acked-by: Linus Walleij --- arch/arm/boot/dts/mstar-v7.dtsi | 10

[PATCH v4 2/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller

2020-11-29 Thread Daniel Palmer
Add a binding description for the MStar/SigmaStar GPIO controller found in the MSC313 and later ARMv7 SoCs. Signed-off-by: Daniel Palmer --- .../bindings/gpio/mstar,msc313-gpio.yaml | 59 +++ MAINTAINERS | 1 + 2 files changed, 60

[PATCH v4 3/5] gpio: msc313: MStar MSC313 GPIO driver

2020-11-29 Thread Daniel Palmer
of the lines have been mapped out. Signed-off-by: Daniel Palmer --- MAINTAINERS| 1 + drivers/gpio/Kconfig | 11 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-msc313.c | 460 + 4 files changed, 473 insertions(+) create mode 100644

[PATCH v4 0/5] Add GPIO support for MStar/SigmaStar ARMv7

2020-11-29 Thread Daniel Palmer
he binding description has been updated to add the interrupt-controller bits and remove the description of the interrupt-names that described how the interrupts used to be passed in. Daniel Palmer (5): dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver dt-bindings: gpi

  1   2   3   >