From: Daniel Scheller <d.schel...@gmx.net>
drivers/media/pci/ddbridge exposes a few IOCTLs which are used by userspace
utilities to ie. update PCIe card's FPGA firmware.
The IOCTLs chosen are in the range 0xDD/0xE0 up to 0xDD/0xFF, with 0xDD as
sort of gimmick for "Digi
From: Daniel Scheller
drivers/media/pci/ddbridge exposes a few IOCTLs which are used by userspace
utilities to ie. update PCIe card's FPGA firmware.
The IOCTLs chosen are in the range 0xDD/0xE0 up to 0xDD/0xFF, with 0xDD as
sort of gimmick for "Digital Devices". To not conflict wit
Hi Colin,
Am Tue, 8 May 2018 11:39:56 +0100
schrieb Colin Ian King <colin.k...@canonical.com>:
> On 08/05/18 11:38, Daniel Scheller wrote:
> > Hi Colin,
> >
> > Am Tue, 8 May 2018 00:08:42 +0100
> > schrieb Colin King <colin.k...@canonical.com>:
&g
Hi Colin,
Am Tue, 8 May 2018 11:39:56 +0100
schrieb Colin Ian King :
> On 08/05/18 11:38, Daniel Scheller wrote:
> > Hi Colin,
> >
> > Am Tue, 8 May 2018 00:08:42 +0100
> > schrieb Colin King :
> >
> >> From: Colin Ian King
> >>
> >&
k);
> state->started = 0;
Thanks for the patch, or - better - pointing this out. While it's
unlikely this will ever be an issue, I'm fine with changing the code
like that, but I'd prefer to change it a bit differently (ie.
DEMOD_STOPPED should be DEMOD_UNUSED, and I'd add defines for max.
tuners and use/compare against them).
I'll send out a different patch that will cover the potential
coverityscan problem throughout the end of the week.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
ile it's
unlikely this will ever be an issue, I'm fine with changing the code
like that, but I'd prefer to change it a bit differently (ie.
DEMOD_STOPPED should be DEMOD_UNUSED, and I'd add defines for max.
tuners and use/compare against them).
I'll send out a different patch that will cover the potential
coverityscan problem throughout the end of the week.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
get_algo(struct dvb_frontend *fe)
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller <d.schel...@gmx.net>
Best regards,
Daniel Scheller
--
https://github.com/herrnst
et_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller
Best regards,
Daniel Scheller
--
https://github.com/herrnst
gt; -static int get_algo(struct dvb_frontend *fe)
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller <d.schel...@gmx.net>
Best regards,
Daniel Scheller
--
https://github.com/herrnst
m dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller
Best regards,
Daniel Scheller
--
https://github.com/herrnst
e-core.c: In function 'ngene_start':
> drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev'
> [-Werror=unused-variable]
>
> Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk()
> to dev_*() macros")
> Signed-off-by: Arnd Be
on 'ngene_start':
> drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev'
> [-Werror=unused-variable]
>
> Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk()
> to dev_*() macros")
> Signed-off-by: Arnd Bergmann
Acked-by:
gt;frontend_priv = NULL;
FWIW, this patch breaks unloading for all DVB cards in my dev system,
in that attached drivers like demod and tuner drivers won't usecount
to zero anymore ("rmmod ddbridge" keeps the usecount of stv0367 and
cxd2841er up, and "rmmod budget_av" doesn't usecount the tda10023 back
to zero).
Best regards,
Daniel Scheller
--
https://github.com/herrnst
for all DVB cards in my dev system,
in that attached drivers like demod and tuner drivers won't usecount
to zero anymore ("rmmod ddbridge" keeps the usecount of stv0367 and
cxd2841er up, and "rmmod budget_av" doesn't usecount the tda10023 back
to zero).
Best regards,
Daniel Scheller
--
https://github.com/herrnst
static?
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Thanks,
Acked-by: Daniel Scheller <d.schel...@gmx.net>
> ---
> drivers/media/dvb-frontends/stv0910.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/me
; symbol 'padc_lookup' was not declared. Should it be static?
> symbol 's1_sn_lookup' was not declared. Should it be static?
> symbol 's2_sn_lookup' was not declared. Should it be static?
> symbol 'stvlist' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King
Thanks,
Acked-by
tches back for
now, since we're in the process of bumping the whole driver to a newer
version which involves lots of code shuffling. With this, quite some
GIT rebasing work needs to be done, and adding this one liner at a
later time (thus rebasing it) is way easier.
To be sure this will not be forgot
er to a newer
version which involves lots of code shuffling. With this, quite some
GIT rebasing work needs to be done, and adding this one liner at a
later time (thus rebasing it) is way easier.
To be sure this will not be forgotten afterwards, I've already posted a
patch applying the exact change at [1].
Thank you very much!
[1] https://patchwork.linuxtv.org/patch/42393/
Best regards,
Daniel Scheller
--
https://github.com/herrnst
18 matches
Mail list logo
