On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
> Acked-by: Jiri Slaby <[EMAIL PROTECTED]>
> ---
> scripts/checkpatch.pl |1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/scripts/checkpatch.pl
>
On Fri, 2008-01-11 at 10:41 +0100, Jiri Slaby wrote:
> On 01/11/2008 10:36 AM, Daniel Walker wrote:
> > On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote:
> >> If somebody is hacking kernel, I think he should know the - trick used in
> >> many
> >> programs
On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote:
> On 01/11/2008 10:30 AM, Daniel Walker wrote:
> > On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote:
> >> On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote:
> >>> git show 9914cad54c79d0b89b1f066c089
On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote:
> On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote:
> > On 01/11/2008 10:17 AM, Daniel Walker wrote:
> > > On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote:
> > >> On 01/11/2008 05:10 AM, Daniel
On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote:
> On 01/11/2008 05:10 AM, Daniel Walker wrote:
> > A little feature addition to allow checkpatch.pl to check patches piped
> > into it, in addition to specific file arguments.
>
> You can still add - as an argument to chec
On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote:
On 01/11/2008 05:10 AM, Daniel Walker wrote:
A little feature addition to allow checkpatch.pl to check patches piped
into it, in addition to specific file arguments.
You can still add - as an argument to check stdin. In which way
On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote:
On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote:
On 01/11/2008 10:17 AM, Daniel Walker wrote:
On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote:
On 01/11/2008 05:10 AM, Daniel Walker wrote:
A little feature addition
On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote:
On 01/11/2008 10:30 AM, Daniel Walker wrote:
On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote:
On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote:
git show 9914cad54c79d0b89b1f066c0894f00e1344131c
| ./scripts/checkpatch.pl
On Fri, 2008-01-11 at 10:41 +0100, Jiri Slaby wrote:
On 01/11/2008 10:36 AM, Daniel Walker wrote:
On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote:
If somebody is hacking kernel, I think he should know the - trick used in
many
programs, but do not consider this as a nack.
I'm
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
Acked-by: Jiri Slaby [EMAIL PROTECTED]
---
scripts/checkpatch.pl |1 +
1 file changed, 1 insertion(+)
Index: linux/scripts/checkpatch.pl
On Fri, 2008-01-11 at 18:29 +0100, Stefan Richter wrote:
Daniel Walker wrote:
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
+ print When patchfile is -, read standard input.\n;
Naww .. Why add documentation when you can just
A little feature addition to allow checkpatch.pl to check patches piped
into it, in addition to specific file arguments.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
scripts/checkpatch.pl | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux-2.6.23/s
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
> On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> > modified since it was pull in on Oct. 11 ..
>
> Daniel
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
> On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> > modified since it was pull in on Oct. 11 ..
>
> Daniel
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> >
> >
> > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > inside the arch/x86/ sub-directo
On Thu, 2008-01-10 at 23:47 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 11:41 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]&
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> >
> >
> > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > inside the arch/x86/ sub-directo
I was playing with checkpatch.pl ;) .. I made a list of style offenders
inside the arch/x86/ sub-directory. I thought it might be helpful to
prioritize any style clean ups that people might want to do for x86 ..
OTOH some of these might show imperfections in checkpatch.pl .. Either
way I thought
I was playing with checkpatch.pl ;) .. I made a list of style offenders
inside the arch/x86/ sub-directory. I thought it might be helpful to
prioritize any style clean ups that people might want to do for x86 ..
OTOH some of these might show imperfections in checkpatch.pl .. Either
way I thought
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote:
I was playing with checkpatch.pl ;) .. I made a list of style offenders
inside the arch/x86/ sub-directory. I thought it might be helpful to
prioritize any style
On Thu, 2008-01-10 at 23:47 +0100, Paolo Ciarrocchi wrote:
On Jan 10, 2008 11:41 PM, Daniel Walker [EMAIL PROTECTED] wrote:
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote:
I was playing
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote:
I was playing with checkpatch.pl ;) .. I made a list of style offenders
inside the arch/x86/ sub-directory. I thought it might be helpful to
prioritize any style
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
On Jan 11, 2008 12:08 AM, Daniel Walker [EMAIL PROTECTED] wrote:
The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
modified since it was pull in on Oct. 11 ..
Daniel,
are we looking at the same tree
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
On Jan 11, 2008 12:08 AM, Daniel Walker [EMAIL PROTECTED] wrote:
The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
modified since it was pull in on Oct. 11 ..
Daniel,
are we looking at the same tree
A little feature addition to allow checkpatch.pl to check patches piped
into it, in addition to specific file arguments.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
scripts/checkpatch.pl | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux-2.6.23/scripts
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
> + /* Don't trace irqs off for idle */
> + stop_critical_timings();
> idle();
> + start_critical_timings();
Is there another way to hook into the
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
> +enum trace_flag_type {
> + TRACE_FLAG_IRQS_OFF = 0x01,
> + TRACE_FLAG_NEED_RESCHED = 0x02,
> + TRACE_FLAG_NEED_RESCHED_DELAYED = 0x04,
> + TRACE_FLAG_HARDIRQ = 0x08,
> +
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
> +cycle_t notrace get_monotonic_cycles(void)
> +{
> + cycle_t cycle_now, cycle_delta, cycle_raw, cycle_last;
> +
> + do {
> + /*
> +* cycle_raw and cycle_last can change on
> +*
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
+cycle_t notrace get_monotonic_cycles(void)
+{
+ cycle_t cycle_now, cycle_delta, cycle_raw, cycle_last;
+
+ do {
+ /*
+* cycle_raw and cycle_last can change on
+* another CPU
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
+enum trace_flag_type {
+ TRACE_FLAG_IRQS_OFF = 0x01,
+ TRACE_FLAG_NEED_RESCHED = 0x02,
+ TRACE_FLAG_NEED_RESCHED_DELAYED = 0x04,
+ TRACE_FLAG_HARDIRQ = 0x08,
+
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
+ /* Don't trace irqs off for idle */
+ stop_critical_timings();
idle();
+ start_critical_timings();
Is there another way to hook into the idle
On Tue, 2008-01-08 at 16:14 -0500, Theodore Tso wrote:
> On Tue, Jan 08, 2008 at 12:19:44PM -0800, Daniel Walker wrote:
> > > But is discourage the creation of pure clean-up patches because it
> > > may have a disturbing effect on several other peoples work.
> >
&g
On Tue, 2008-01-08 at 20:21 +0100, Sam Ravnborg wrote:
> But is discourage the creation of pure clean-up patches because it
> may have a disturbing effect on several other peoples work.
pure clean ups are _good_ patches , are they not?
Daniel
--
To unsubscribe from this list: send the line
On Tue, 2008-01-08 at 13:20 -0500, Theodore Tso wrote:
> On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote:
> > > It is a simple pain/benefit issue.
> > > Fixing the 25 errors and 13 warnings in kernel/profile.c may look
> > > like an easy task but
On Tue, 2008-01-08 at 18:53 +0100, Sam Ravnborg wrote:
> On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote:
> >
> > On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> >
> >
> > > +if ($file) {
> > > + print < > > +WARNING:
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> +if ($file) {
> + print < +WARNING: Using --file mode. Please do not send patches to linux-kernel
> +that change whole existing files if you did not significantly change most
> +of the the file for other reasons anyways or just wrote
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
+if ($file) {
+ print EOL
+WARNING: Using --file mode. Please do not send patches to linux-kernel
+that change whole existing files if you did not significantly change most
+of the the file for other reasons anyways or just wrote the
On Tue, 2008-01-08 at 18:53 +0100, Sam Ravnborg wrote:
On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote:
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
+if ($file) {
+ print EOL
+WARNING: Using --file mode. Please do not send patches to linux-kernel
On Tue, 2008-01-08 at 13:20 -0500, Theodore Tso wrote:
On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote:
It is a simple pain/benefit issue.
Fixing the 25 errors and 13 warnings in kernel/profile.c may look
like an easy task but then we put additional burden on the 10 people
On Tue, 2008-01-08 at 20:21 +0100, Sam Ravnborg wrote:
But is discourage the creation of pure clean-up patches because it
may have a disturbing effect on several other peoples work.
pure clean ups are _good_ patches , are they not?
Daniel
--
To unsubscribe from this list: send the line
On Tue, 2008-01-08 at 16:14 -0500, Theodore Tso wrote:
On Tue, Jan 08, 2008 at 12:19:44PM -0800, Daniel Walker wrote:
But is discourage the creation of pure clean-up patches because it
may have a disturbing effect on several other peoples work.
pure clean ups are _good_ patches
On Thu, 2008-01-03 at 02:16 -0500, Steven Rostedt wrote:
> Index: linux-compile.git/Makefile
> ===
> --- linux-compile.git.orig/Makefile 2008-01-03 01:02:28.0 -0500
> +++ linux-compile.git/Makefile 2008-01-03
On Thu, 2008-01-03 at 02:16 -0500, Steven Rostedt wrote:
Index: linux-compile.git/Makefile
===
--- linux-compile.git.orig/Makefile 2008-01-03 01:02:28.0 -0500
+++ linux-compile.git/Makefile 2008-01-03
On Sun, 2007-12-23 at 16:16 +0100, Ingo Molnar wrote:
> * Tetsuo Handa <[EMAIL PROTECTED]> wrote:
>
> > Hello.
> >
> > I encountered a BUG().
> > I didn't encounter this bug for 2.6.24-rc5-mm1 .
> > I guess this bug was introduced between 2.6.24-rc5-mm1 and 2.6.24-rc6-mm1 .
>
> does the patch
On Sun, 2007-12-23 at 16:16 +0100, Ingo Molnar wrote:
* Tetsuo Handa [EMAIL PROTECTED] wrote:
Hello.
I encountered a BUG().
I didn't encounter this bug for 2.6.24-rc5-mm1 .
I guess this bug was introduced between 2.6.24-rc5-mm1 and 2.6.24-rc6-mm1 .
does the patch below help?
I
On Mon, 2007-12-24 at 06:12 -0800, Pete Zaitcev wrote:
> On Sun, 23 Dec 2007 08:46:37 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> > I noticed you also have a spinlock held in usu_probe_thread(), the
> > usu_lock.. That spinlock would preclude anything inside r
On Mon, 2007-12-24 at 06:12 -0800, Pete Zaitcev wrote:
On Sun, 23 Dec 2007 08:46:37 -0800, Daniel Walker [EMAIL PROTECTED] wrote:
I noticed you also have a spinlock held in usu_probe_thread(), the
usu_lock.. That spinlock would preclude anything inside request_module()
from sleeping
On Sat, 2007-12-22 at 23:37 -0800, Pete Zaitcev wrote:
> On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> > Then in usu_probe_thread() your basically stopping it at the start of
> > the function with a down(), and the up() is just ancil
On Sat, 2007-12-22 at 23:37 -0800, Pete Zaitcev wrote:
On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker [EMAIL PROTECTED] wrote:
Then in usu_probe_thread() your basically stopping it at the start of
the function with a down(), and the up() is just ancillary .. So you
could easily move
On Fri, 2007-12-21 at 22:24 -0800, Pete Zaitcev wrote:
> When I tried it, usb-storage would not load with unresolved symbols.
> It happens if child (usu_probe_thread) runs ahead of its parent
> (usb_usual_init -> usb_register -> usu_probe). It's entirely possible,
> depending on your scheduler.
>
On Fri, 2007-12-21 at 22:24 -0800, Pete Zaitcev wrote:
When I tried it, usb-storage would not load with unresolved symbols.
It happens if child (usu_probe_thread) runs ahead of its parent
(usb_usual_init - usb_register - usu_probe). It's entirely possible,
depending on your scheduler.
I
I converted the usu_init_notify semaphore to normal mutex usage, and it
should still prevent the request_module before the init routine is
complete. Before it acted more like a complete, now the mutex protects
two distinct section from running at the same time..
Signed-off-by: Daniel Walker
No current references, so removing it.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/usb/image/microtek.c |1 -
drivers/usb/image/microtek.h |1 -
2 files changed, 2 deletions(-)
Index: linux-2.6.23/drivers/usb/image/micr
Just converting this documentation semaphore reference, since we don't
want to promote semaphore usage.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
Documentation/kref.txt | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Index: linux-2.6.23/Documen
-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/net/wireless/prism54/isl_ioctl.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
Index: linux-2.6.23/drivers/net/wireless/prism54/isl_ioctl.c
===
--- linux-2.6.2
No current references, so removing it.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/usb/image/microtek.c |1 -
drivers/usb/image/microtek.h |1 -
2 files changed, 2 deletions(-)
Index: linux-2.6.23/drivers/usb/image/microtek.c
Just converting this documentation semaphore reference, since we don't
want to promote semaphore usage.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
Documentation/kref.txt | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Index: linux-2.6.23/Documentation
-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/net/wireless/prism54/isl_ioctl.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
Index: linux-2.6.23/drivers/net/wireless/prism54/isl_ioctl.c
===
--- linux-2.6.23.orig
I converted the usu_init_notify semaphore to normal mutex usage, and it
should still prevent the request_module before the init routine is
complete. Before it acted more like a complete, now the mutex protects
two distinct section from running at the same time..
Signed-off-by: Daniel Walker
On Thu, 2007-12-20 at 12:06 -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2007 11:32:25 -0800 Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> > On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:
> >
> > > Unfortunately there wasn't enough context in the patch
On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:
> Unfortunately there wasn't enough context in the patch to see
> that there is a down() earlier in the routine, and that the patch
> does indeed remove an incorrectly placed down(). Here is the
> entire routine, marked with what the patch
On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:
Unfortunately there wasn't enough context in the patch to see
that there is a down() earlier in the routine, and that the patch
does indeed remove an incorrectly placed down(). Here is the
entire routine, marked with what the patch
On Thu, 2007-12-20 at 12:06 -0800, Andrew Morton wrote:
On Thu, 20 Dec 2007 11:32:25 -0800 Daniel Walker [EMAIL PROTECTED] wrote:
On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:
Unfortunately there wasn't enough context in the patch to see
that there is a down() earlier
On Wed, 2007-12-19 at 10:42 -0800, Daniel Walker wrote:
> On Wed, 2007-12-19 at 10:06 -0500, Miles Lane wrote:
> > [ 11.827653] PM: Creating hibernation image:
> > [ 11.827658] WARNING: at arch/x86/kernel/smp_32.c:561
> > native_smp_call_function_mask()
> > [ 11.
On Wed, 2007-12-19 at 10:06 -0500, Miles Lane wrote:
> [ 11.827653] PM: Creating hibernation image:
> [ 11.827658] WARNING: at arch/x86/kernel/smp_32.c:561
> native_smp_call_function_mask()
> [ 11.827661] Pid: 9940, comm: pm-hibernate Not tainted
> 2.6.24-rc5-mm1 #8
> [ 11.827665] []
On Wed, 2007-12-19 at 10:06 -0500, Miles Lane wrote:
[ 11.827653] PM: Creating hibernation image:
[ 11.827658] WARNING: at arch/x86/kernel/smp_32.c:561
native_smp_call_function_mask()
[ 11.827661] Pid: 9940, comm: pm-hibernate Not tainted
2.6.24-rc5-mm1 #8
[ 11.827665] [c0107d55]
On Wed, 2007-12-19 at 10:42 -0800, Daniel Walker wrote:
On Wed, 2007-12-19 at 10:06 -0500, Miles Lane wrote:
[ 11.827653] PM: Creating hibernation image:
[ 11.827658] WARNING: at arch/x86/kernel/smp_32.c:561
native_smp_call_function_mask()
[ 11.827661] Pid: 9940, comm: pm-hibernate
On Tue, 2007-12-18 at 17:10 -0800, Andrew Morton wrote:
> is correct. Although not exactly a thing of beauty.
This isn't the worst I've seen ;( .. Do you think the ending should fall
through instead of having two returns?
Daniel
--
To unsubscribe from this list: send the line "unsubscribe
On Tue, 2007-12-18 at 17:10 -0800, Andrew Morton wrote:
is correct. Although not exactly a thing of beauty.
This isn't the worst I've seen ;( .. Do you think the ending should fall
through instead of having two returns?
Daniel
--
To unsubscribe from this list: send the line unsubscribe
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/base/memory.c |7 ---
include/linux/memory.h |5 ++---
mm/memory_hotplug.c|2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
Index: linux-2.6.23/drivers/base/me
This stray down would cause a permanent sleep which doesn't seem correct.
The other uses of this semaphore appear fairly mutex like it's even initialized
with init_MUTEX() .. So here a patch for removing this one down().
Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
Signed-off-by:
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/base/memory.c |7 ---
include/linux/memory.h |5 ++---
mm/memory_hotplug.c|2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
Index: linux-2.6.23/drivers/base/memory.c
This stray down would cause a permanent sleep which doesn't seem correct.
The other uses of this semaphore appear fairly mutex like it's even initialized
with init_MUTEX() .. So here a patch for removing this one down().
Signed-off-by: Geoff Levand [EMAIL PROTECTED]
Signed-off-by: Daniel Walker
On Thu, 2007-12-13 at 01:48 +0100, Michael Buesch wrote:
> On Wednesday 12 December 2007 09:00:03 Daniel Walker wrote:
> >
> > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]>
> >
> > ---
> > drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30
&g
This stray down would cause a permanent sleep which doesn't seem correct.
The other uses of this semaphore appear fairly mutex like it's even initialized
with init_MUTEX() .. So here a patch for removing this one down().
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/p
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/base/memory.c |7 ---
include/linux/memory.h |5 ++---
2 files changed, 6 insertions(+), 6 deletions(-)
Index: linux-2.6.23/drivers/base/me
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30 -
1 file changed, 15 insertions(+), 15 deletions(-)
Index: linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_deb
do_div() rounds down, so we add have the divisor to round up. This effected my
change to preempt_max_latency. Each time you read preempt_max_latency it gets
rounded lower.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
kernel/time/timekeeping.c |3 ++-
1 file changed, 2 inse
Fix my original mistake of using CONFIG_CRITICAL_TIMING , which only
covers preempt and irqs-off timing.. Convert to CONFIG_LATENCY_TIMING,
so wakeup timing also has these.
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]>
---
kernel/sysctl.c |2 +-
1 file changed, 1 insertion(+), 1 de
Not to long ago preempt_max_latency was microseconds, and someplace
along the way it turned into cycles. That's a bit unintuitive, so I
converted it back to microseconds.
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]>
---
include/linux/clocksource.h | 12 ++--
Not to long ago preempt_max_latency was microseconds, and someplace
along the way it turned into cycles. That's a bit unintuitive, so I
converted it back to microseconds.
Signed-Off-By: Daniel Walker [EMAIL PROTECTED]
---
include/linux/clocksource.h | 12 ++--
kernel/latency_trace.c
Fix my original mistake of using CONFIG_CRITICAL_TIMING , which only
covers preempt and irqs-off timing.. Convert to CONFIG_LATENCY_TIMING,
so wakeup timing also has these.
Signed-Off-By: Daniel Walker [EMAIL PROTECTED]
---
kernel/sysctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
do_div() rounds down, so we add have the divisor to round up. This effected my
change to preempt_max_latency. Each time you read preempt_max_latency it gets
rounded lower.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
kernel/time/timekeeping.c |3 ++-
1 file changed, 2 insertions
This stray down would cause a permanent sleep which doesn't seem correct.
The other uses of this semaphore appear fairly mutex like it's even initialized
with init_MUTEX() .. So here a patch for removing this one down().
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/ps3/ps3
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/base/memory.c |7 ---
include/linux/memory.h |5 ++---
2 files changed, 6 insertions(+), 6 deletions(-)
Index: linux-2.6.23/drivers/base/memory.c
===
--- linux
Signed-Off-By: Daniel Walker [EMAIL PROTECTED]
---
drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30 -
1 file changed, 15 insertions(+), 15 deletions(-)
Index: linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
On Thu, 2007-12-13 at 01:48 +0100, Michael Buesch wrote:
On Wednesday 12 December 2007 09:00:03 Daniel Walker wrote:
Signed-Off-By: Daniel Walker [EMAIL PROTECTED]
---
drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c | 30
-
1 file changed, 15 insertions
There are a few error paths which don't unlock the usbvision->lock.
So I've added mutex_unlock() calls to fix those paths.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/media/video/usbvision/usbvision-video.c |2 ++
1 file changed, 2 insertions(+)
Index: lin
There are a few error paths which don't unlock the usbvision-lock.
So I've added mutex_unlock() calls to fix those paths.
Signed-off-by: Daniel Walker [EMAIL PROTECTED]
---
drivers/media/video/usbvision/usbvision-video.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.23/drivers
On Sat, 2007-12-08 at 15:19 -0400, Kevin Winchester wrote:
>
> Yes, I've used quilt for working with mm patches in the past, but I'm
> not too familiar with the mail features. For example, how do you get
> the recipient list and Signed-off-by in the patch file? Do you just
> edit it by hand?
On Sat, 2007-12-08 at 14:17 -0400, Kevin Winchester wrote:
> Daniel Walker wrote:
> > On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote:
> >> Daniel Walker wrote:
> >>> I've posted all the ones I've done so far ..
> >>>
> >>> ft
On Sat, 2007-12-08 at 18:11 +0100, Peter Zijlstra wrote:
> > It must be the locking in __driver_attach(), taking dev->parent->sem
> > then taking dev->sem .. Assuming those are different structures, why
> > does lockdep trigger?
>
> They aren't different, parent is a struct device again.
It's
On Sat, 2007-12-08 at 13:16 +0100, Peter Zijlstra wrote:
> On Sat, 2007-12-08 at 00:02 +0100, Remy Bohmer wrote:
> > Hello Peter,
> >
> > > > What specifically is wrong with dev->sem ?
> > >
> > > Nothing really, other than that they use semaphores to avoid lockdep :-/
> > >
> > > I think I know
On Sat, 2007-12-08 at 13:16 +0100, Peter Zijlstra wrote:
On Sat, 2007-12-08 at 00:02 +0100, Remy Bohmer wrote:
Hello Peter,
What specifically is wrong with dev-sem ?
Nothing really, other than that they use semaphores to avoid lockdep :-/
I think I know how to annotate this,
On Sat, 2007-12-08 at 18:11 +0100, Peter Zijlstra wrote:
It must be the locking in __driver_attach(), taking dev-parent-sem
then taking dev-sem .. Assuming those are different structures, why
does lockdep trigger?
They aren't different, parent is a struct device again.
It's different
On Sat, 2007-12-08 at 14:17 -0400, Kevin Winchester wrote:
Daniel Walker wrote:
On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote:
Daniel Walker wrote:
I've posted all the ones I've done so far ..
ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/
Feel free to review
On Sat, 2007-12-08 at 15:19 -0400, Kevin Winchester wrote:
Yes, I've used quilt for working with mm patches in the past, but I'm
not too familiar with the mail features. For example, how do you get
the recipient list and Signed-off-by in the patch file? Do you just
edit it by hand? Or is
Converted to a mutex, and changed the name to mce_read_mutex.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/mce_64.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-2.6.23/arch/x86/kernel/cpu/mcheck/mc
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/md/dm.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Index: linux-2.6.23/drivers/md/dm.c
===
--- linux-2.6.23.orig/drivers/md/dm.c
+++
The ctrlUrbLock has all it's users commented out, and so it's unused.
This patch removes it.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
---
drivers/media/video/usbvision/usbvision-core.c |3 ---
drivers/media/video/usbvision/usbvision-video.c |1 -
drivers/media/video/usb
301 - 400 of 1531 matches
Mail list logo
