[PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings

2014-05-13 Thread Darek Marcinkiewicz
Sparse was reporting quite a few warnings for the driver. Those get fixed by this patch. Signed-off-by: Dariusz Marcinkiewicz --- drivers/net/ethernet/ec_bhf.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net

[PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings

2014-05-11 Thread Darek Marcinkiewicz
Sparse was reporting quite a few warnings for the driver. Those get fixed by this patch. --- drivers/net/ethernet/ec_bhf.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index 4884205..056b

[PATCH v9 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-06 Thread Darek Marcinkiewicz
CAT) += ec_bhf.o obj-$(CONFIG_DM9000) += davicom/ obj-$(CONFIG_DNET) += dnet.o obj-$(CONFIG_NET_VENDOR_DEC) += dec/ diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c new file mode 100644 index 000..4884205 --- /dev/null +++ b/drivers/net/ethernet/ec_bhf.c @@ -0,0 +1,70

Re: [PATCH v8 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-06 Thread Darek Marcinkiewicz
On Tue, May 06, 2014 at 04:56:06PM +0200, Tobias Klauser wrote: > > + if (skb) { > > + memcpy(skb_put(skb, pkt_size), data, pkt_size); > > + skb->protocol = eth_type_trans(skb, priv->net_dev); > > + dev_dbg(dev, "Protocol type: %x\n",

[PATCH v8 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-05 Thread Darek Marcinkiewicz
new file mode 100644 index 000..9763cd6 --- /dev/null +++ b/drivers/net/ethernet/ec_bhf.c @@ -0,0 +1,705 @@ + /* + * drivers/net/ethernet/beckhoff/ec_bhf.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of the GNU General Public + * License versio

Re: [PATCH v7 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-05 Thread Darek Marcinkiewicz
On Mon, May 05, 2014 at 04:32:49PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > Hi. > > There needs to be at least > > depends on PCI > > here or the driver will break build on platforms that doesn't have PCI > (i.e. ARM EXYNOS). > Thank you. I'll update the patch. -- DM -- To un

Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
On Sun, May 04, 2014 at 11:19:28PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz : > > On Sun, May 04, 2014 at 08:43:51PM +0200, Francois Romieu wrote: > [...] > > > Regarding tx_dnext updates, you may add a short notice in > > > ec_bhf_start_xmit > >

[PATCH v7 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
@ + /* + * drivers/net/ethernet/beckhoff/ec_bhf.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of the GNU General Public + * License version 2, as published by the Free Software Foundation, and + * may be copied, distributed, and modified under those

Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
On Sun, May 04, 2014 at 08:43:51PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz : > > On Sat, May 03, 2014 at 01:40:29PM +0200, Francois Romieu wrote: > [...] > > Thank you. I am attaching 2 of thse to this repsonse - the other two > > are no longer relevant due to

Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
On Sun, May 04, 2014 at 01:04:13PM +0200, Darek Marcinkiewicz wrote: > > ... > attached to the EtherCAT bus. As for the locking on the tx path, > I have removed that completely on receiving path. I simply didn't know ... Erm. I meant - I have removed it on the tx path. It wa

Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
On Sat, May 03, 2014 at 01:40:29PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz : > [...] > > This driver adds support for EtherCAT master module located on CCAT > > FPGA found on Beckhoff CX series industrial PCs. The driver exposes > > EtherCAT master

[PATCH v6 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-04 Thread Darek Marcinkiewicz
vers/net/ethernet/ec_bhf.c new file mode 100644 index 000..feb40cd --- /dev/null +++ b/drivers/net/ethernet/ec_bhf.c @@ -0,0 +1,701 @@ + /* + * drivers/net/ethernet/beckhoff/ec_bhf.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of the GNU G

Re: [PATCH v4 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-02 Thread Darek Marcinkiewicz
Hello. Thank you for your comments. On Thu, May 01, 2014 at 05:53:31PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz : > [changes] > [...] > > > + > > +struct bh_priv { > > Nit: it would be nice to avoid "_bh_" as it is already used in a set of &g

[PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-02 Thread Darek Marcinkiewicz
j-$(CONFIG_DM9000) += davicom/ obj-$(CONFIG_DNET) += dnet.o obj-$(CONFIG_NET_VENDOR_DEC) += dec/ diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c new file mode 100644 index 000..8e78b8d --- /dev/null +++ b/drivers/net/ethernet/ec_bhf.c @@ -0,0 +1,740 @@ + /* + * drivers/net/ethernet

[PATCH v4 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-30 Thread Darek Marcinkiewicz
--git a/drivers/net/ethernet/ec_bh.c b/drivers/net/ethernet/ec_bh.c new file mode 100644 index 000..2ed2cee --- /dev/null +++ b/drivers/net/ethernet/ec_bh.c @@ -0,0 +1,785 @@ +/* + * drivers/net/ethernet/beckhoff/ec_bh.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is l

Re: [PATCH v2 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-29 Thread Darek Marcinkiewicz
On Tue, Apr 29, 2014 at 03:45:08PM -0400, David Miller wrote: > From: Darek Marcinkiewicz > Date: Mon, 28 Apr 2014 07:36:58 +0200 > > > +void *ec_bh_alloc_dma_mem(struct bh_priv *priv, > > +int channel, > > +

Re: [PATCH v2 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-29 Thread Darek Marcinkiewicz
On Sun, Apr 27, 2014 at 06:21:41PM -0400, David Miller wrote: > > Please do not post new versions of patches as replies to existing > email threads. > > Instead, post the new version as a fresh list posting. > Ok, thank you for the info. I've sent it in a new thread. I've also have just sent upd

[PATCH v3 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-29 Thread Darek Marcinkiewicz
_bh.c b/drivers/net/ethernet/ec_bh.c new file mode 100644 index 000..5c11c73 --- /dev/null +++ b/drivers/net/ethernet/ec_bh.c @@ -0,0 +1,773 @@ +/* + * drivers/net/ethernet/beckhoff/ec_bh.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of

[PATCH v2 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-27 Thread Darek Marcinkiewicz
ll +++ b/drivers/net/ethernet/ec_bh.c @@ -0,0 +1,768 @@ +/* + * drivers/net/ethernet/beckhoff/ec_bh.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of the GNU General Public + * License version 2, as published by the Free Software Foundat

[PATCH v2 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-27 Thread Darek Marcinkiewicz
On Sat, Apr 26, 2014 at 12:24:00PM -0400, David Miller wrote: > From: Darek Marcinkiewicz > Date: Thu, 24 Apr 2014 22:46:15 +0200 > > All of these descriptor structures need to be properly annotated using > endianness types, and their fields accessed using proper endia

[PATCH 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-24 Thread Darek Marcinkiewicz
ethernet/ec_bh.c new file mode 100644 index 000..51892bf --- /dev/null +++ b/drivers/net/ethernet/ec_bh.c @@ -0,0 +1,769 @@ +/* + * drivers/net/ethernet/beckhoff/ec_bh.c + * + * Copyright (C) 2014 Darek Marcinkiewicz + * + * This software is licensed under the terms of the GNU General Public + * Lic