Re: [PATCH] intel-vbtn: match power button on press rather than release

w days, and it was important to get this in sooner rather than later in the RC cycle. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] intel-vbtn: match power button on press rather than release

On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote: > On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote: > > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote: > > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote: > >

Re: [PATCH] intel-vbtn: match power button on press rather than release

On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote: > On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote: > > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote: > > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote: > >

[GIT PULL] platform-drivers-x86 for 4.13-4

-drivers-x86-v4.13-4 for you to fetch changes up to 946da69954485c4da51c785438f98fb13784941a: platform/x86: intel-vbtn: match power button on press rather than release (2017-08-05 14:37:19 -0700) Thanks, Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.13-4

-drivers-x86-v4.13-4 for you to fetch changes up to 946da69954485c4da51c785438f98fb13784941a: platform/x86: intel-vbtn: match power button on press rather than release (2017-08-05 14:37:19 -0700) Thanks, Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

On Thu, Aug 03, 2017 at 08:50:06AM -0700, Darren Hart wrote: > On Wed, Aug 02, 2017 at 06:06:20PM -0700, Linus Torvalds wrote: > > On Wed, Aug 2, 2017 at 5:28 PM, Stephen Rothwell <s...@canb.auug.org.au> > > wrote: > > > > > > I would say that if y

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

On Thu, Aug 03, 2017 at 08:50:06AM -0700, Darren Hart wrote: > On Wed, Aug 02, 2017 at 06:06:20PM -0700, Linus Torvalds wrote: > > On Wed, Aug 2, 2017 at 5:28 PM, Stephen Rothwell > > wrote: > > > > > > I would say that if you rebase someone's commit(s), t

Re: [PATCH] intel-vbtn: match power button on press rather than release

On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote: > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote: > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote: > > > This fixes a problem where the system gets stuck in a loop > > >

Re: [PATCH] intel-vbtn: match power button on press rather than release

On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote: > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote: > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote: > > > This fixes a problem where the system gets stuck in a loop > > >

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

en such a workflow should be OK. There > needs to be a shared understanding that the branch(es) used for such > exchange are unstable and should not be built directly on to be > merged, of course. > Thanks Junio, I don't think I correctly parsed "should not be built directly on to be merged", can you rephrase? -- Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

d understanding that the branch(es) used for such > exchange are unstable and should not be built directly on to be > merged, of course. > Thanks Junio, I don't think I correctly parsed "should not be built directly on to be merged", can you rephrase? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] intel-vbtn: match power button on press rather than release

ello <mario.limoncie...@dell.com> This looks good to me - responding to the release is non-intuitive IMHO anyway. I'd like to see agreement from AceLan, but this should go into the 4.13 rc cycle (at rc3 currently). -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] intel-vbtn: match power button on press rather than release

is looks good to me - responding to the release is non-intuitive IMHO anyway. I'd like to see agreement from AceLan, but this should go into the 4.13 rc cycle (at rc3 currently). -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] selftests: futex: fix run_tests target

On Wed, Aug 02, 2017 at 07:06:39PM -0600, Shuah Khan wrote: > On 08/02/2017 06:52 PM, Darren Hart wrote: > > On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote: > >> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests. > >> Running run_test

Re: [PATCH] selftests: futex: fix run_tests target

On Wed, Aug 02, 2017 at 07:06:39PM -0600, Shuah Khan wrote: > On 08/02/2017 06:52 PM, Darren Hart wrote: > > On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote: > >> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests. > >> Running run_test

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

e each maintainer work from a private set of branches (this just masks the problem by making the rebase invisible) Whatever we decide, I'd like to add this to some documentation for maintainer teams (which I'm happy to prepare and submit). Thanks, -- Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

sidered this until now... this might be the most compatible with maintainer teams while strictly tracking the "patches" delivery path") d) Redefine testing as immutable and revert patches rather than drop them, introducing bugs into mainline. e) Make each maintainer work from a priv

Re: [PATCH] selftests: futex: fix run_tests target

akefile > +++ b/tools/testing/selftests/futex/Makefile > @@ -14,7 +14,7 @@ all: > done > > override define RUN_TESTS > - @if [ `dirname $(OUTPUT)` = $(PWD) ]; then ./run.sh; fi > + $(OUTPUT)/run.sh > endef > > override define INSTALL_RULE > -- > 2.11.0 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] selftests: futex: fix run_tests target

ftests/futex/Makefile > @@ -14,7 +14,7 @@ all: > done > > override define RUN_TESTS > - @if [ `dirname $(OUTPUT)` = $(PWD) ]; then ./run.sh; fi > + $(OUTPUT)/run.sh > endef > > override define INSTALL_RULE > -- > 2.11.0 > > -- Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

a testing branch is made, the maintainer must also ensure a SOB is on each patch? I just want to get a clear picture of what the failure was so we can update our tooling so this doesn't repeat itself. -- Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

a testing branch is made, the maintainer must also ensure a SOB is on each patch? I just want to get a clear picture of what the failure was so we can update our tooling so this doesn't repeat itself. -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.13-3

to 51391caf99e34d2d75ffc428845062d93aa739c6: platform/x86: dell-wmi: Fix driver interface version query (2017-08-01 15:41:43 -0700) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86 for v4.13-3 Fix

[GIT PULL] platform-drivers-x86 for 4.13-3

to 51391caf99e34d2d75ffc428845062d93aa739c6: platform/x86: dell-wmi: Fix driver interface version query (2017-08-01 15:41:43 -0700) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86 for v4.13-3 Fix

Re: [PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init()

khoroshi...@ispras.ru> Eeek. Thank you. Applied to fixes for 4.13.X. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init()

Eeek. Thank you. Applied to fixes for 4.13.X. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

form/x86/intel_telemetry_pltdrv.c > > > b/drivers/platform/x86/intel_telemetry_pltdrv.c > > > index 6393b3b1d5a6..e0424d5a795a 100644 > > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c > > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c > > > @@ -46,7 +46,6 @@ > > > #define TELEM_SAMPLING_DEFAULT_PERIOD0xD > > > > > > #define TELEM_MAX_EVENTS_SRAM28 > > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20 > > > #define TELEM_SSRAM_STARTTIME_OFFSET 8 > > > #define TELEM_SSRAM_EVTLOG_OFFSET16 > > > > > > -- > > > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

el_telemetry_pltdrv.c > > > @@ -46,7 +46,6 @@ > > > #define TELEM_SAMPLING_DEFAULT_PERIOD0xD > > > > > > #define TELEM_MAX_EVENTS_SRAM28 > > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20 > > > #define TELEM_SSRAM_STARTTIME_OFFSET 8 > > > #define TELEM_SSRAM_EVTLOG_OFFSET16 > > > > > > -- > > > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV

s that need this use 'select' > here rather than 'depends on', so I'm doing the same. > > Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Queued to fixes branch for 4.13-rcX. I'll leave patch 2/2 to a

Re: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV

s that need this use 'select' > here rather than 'depends on', so I'm doing the same. > > Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver") > Signed-off-by: Arnd Bergmann Queued to fixes branch for 4.13-rcX. I'll leave patch 2/2 to andy since you worked that

Re: [PATCH 1/3] platform/x86: Add GLK PSS Event Table

has no semantic meaning in the Linux kernel development process, and one line approvals, especially from the same company, have little incremental value. For details, please see: Documentation/process/5.Posting.rst Documentation/submitting-patches.rst Thanks, -- Darren Hart VMware Open Source Technol

Re: [PATCH 1/3] platform/x86: Add GLK PSS Event Table

has no semantic meaning in the Linux kernel development process, and one line approvals, especially from the same company, have little incremental value. For details, please see: Documentation/process/5.Posting.rst Documentation/submitting-patches.rst Thanks, -- Darren Hart VMware Open Source Technol

[GIT PULL] platform-drivers-x86 for 4.13-2

-drivers-x86.git tags/platform-drivers-x86-v4.13-2 for you to fetch changes up to c3a73ed8a82b666ac01466d3badd7824eae89c44: platform/x86: silead_dmi: Add entry for Ployer Momo7w tablet touchscreen (2017-07-12 13:57:42 -0700) Thanks, Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.13-2

-drivers-x86.git tags/platform-drivers-x86-v4.13-2 for you to fetch changes up to c3a73ed8a82b666ac01466d3badd7824eae89c44: platform/x86: silead_dmi: Add entry for Ployer Momo7w tablet touchscreen (2017-07-12 13:57:42 -0700) Thanks, Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: silead_dmi: Add entry for Ployer Momo7w tablet touchscreen

On Wed, Jul 12, 2017 at 01:15:11PM +0200, Hans de Goede wrote: > This Ployer Momo7w revision has the same hardware as the Trekstor > ST70416-6, so we re-use the surftab_wintron70_st70416_6_data. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Thanks Hans, queued to te

Re: [PATCH] platform/x86: silead_dmi: Add entry for Ployer Momo7w tablet touchscreen

On Wed, Jul 12, 2017 at 01:15:11PM +0200, Hans de Goede wrote: > This Ployer Momo7w revision has the same hardware as the Trekstor > ST70416-6, so we re-use the surftab_wintron70_st70416_6_data. > > Signed-off-by: Hans de Goede Thanks Hans, queued to testing. -- Darren Hart VMware

Re: [PATCH 0/7] Constify platform/x86 attribute_group structures.

u-laptop.c | 2 +- > drivers/platform/x86/panasonic-laptop.c | 2 +- > drivers/platform/x86/samsung-laptop.c | 2 +- > drivers/platform/x86/toshiba_acpi.c | 2 +- > 7 files changed, 10 insertions(+), 10 deletions(-) > > -- > 1.9.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 0/7] Constify platform/x86 attribute_group structures.

u-laptop.c | 2 +- > drivers/platform/x86/panasonic-laptop.c | 2 +- > drivers/platform/x86/samsung-laptop.c | 2 +- > drivers/platform/x86/toshiba_acpi.c | 2 +- > 7 files changed, 10 insertions(+), 10 deletions(-) > > -- > 1.9.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1

On Tue, Jul 11, 2017 at 01:41:34PM +0200, Hans de Goede wrote: > If peaq_ignore_events_counter gets set to 1 we should skip polling 1 > time, rather then ignoring it. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Thanks Hans, queued to testing. -- Darren Hart

Re: [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1

On Tue, Jul 11, 2017 at 01:41:34PM +0200, Hans de Goede wrote: > If peaq_ignore_events_counter gets set to 1 we should skip polling 1 > time, rather then ignoring it. > > Signed-off-by: Hans de Goede Thanks Hans, queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: fujitsu-laptop: add NULL check on devm_kzalloc() return value

<garsi...@embeddedor.com> > > These checks should be added in the interest of code correctness. > devm_kzalloc() can fail (even if it's extremely unlikely in practice) so we > should check for this. > > Reviewed-by: Jonathan Woithe <jwoi...@just42.net> Thanks Gustavo and Jonathan, Queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: fujitsu-laptop: add NULL check on devm_kzalloc() return value

gt; > These checks should be added in the interest of code correctness. > devm_kzalloc() can fail (even if it's extremely unlikely in practice) so we > should check for this. > > Reviewed-by: Jonathan Woithe Thanks Gustavo and Jonathan, Queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1

TCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), *groan* you're trolling me now right? ;-) > + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), I presume there are no other identifying strings? Pushed to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1

TCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), *groan* you're trolling me now right? ;-) > + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), I presume there are no other identifying strings? Pushed to testing. -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.13-1

to d791db9a57ab7f390916dce0fa1315130bb6664c: platform/x86: sony-laptop: constify attribute_group and input index array (2017-06-30 20:26:54 -0700) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86

[GIT PULL] platform-drivers-x86 for 4.13-1

to d791db9a57ab7f390916dce0fa1315130bb6664c: platform/x86: sony-laptop: constify attribute_group and input index array (2017-06-30 20:26:54 -0700) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86

Re: linux-next: build warning after merge of the drivers-x86 tree

uot;platform/x86: sony-laptop: constify few static structures") Apologies, and thanks for the catch. Rolled the fix from Arnd together with this and the new one from Arvind. for-next had to be rebased to avoid introducing this error into mainline. -- Darren Hart VMware Open Source Technology Center

Re: linux-next: build warning after merge of the drivers-x86 tree

uot;platform/x86: sony-laptop: constify few static structures") Apologies, and thanks for the catch. Rolled the fix from Arnd together with this and the new one from Arvind. for-next had to be rebased to avoid introducing this error into mainline. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap

On Fri, Jun 30, 2017 at 11:50:52PM +0300, Andy Shevchenko wrote: > On Fri, Jun 30, 2017 at 9:21 PM, Darren Hart <dvh...@infradead.org> wrote: > > On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote: > >> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergma

Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap

On Fri, Jun 30, 2017 at 11:50:52PM +0300, Andy Shevchenko wrote: > On Fri, Jun 30, 2017 at 9:21 PM, Darren Hart wrote: > > On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote: > >> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann wrote: > > > Wil

Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap

kernel. We try not to rebase for-next, but it happens everyday, so it isn't a huge deal for Stephen to deal with. Will you squash it, or shall I? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap

se for-next, but it happens everyday, so it isn't a huge deal for Stephen to deal with. Will you squash it, or shall I? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Wed, Jun 28, 2017 at 06:30:44AM +0200, Michał Kępień wrote: > > On Sat, Jun 24, 2017 at 02:25:46AM +0200, Rafael Wysocki wrote: > > > On Wednesday, June 21, 2017 11:15:43 AM Darren Hart wrote: > > > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Michał Kępień wrote

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Wed, Jun 28, 2017 at 06:30:44AM +0200, Michał Kępień wrote: > > On Sat, Jun 24, 2017 at 02:25:46AM +0200, Rafael Wysocki wrote: > > > On Wednesday, June 21, 2017 11:15:43 AM Darren Hart wrote: > > > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Michał Kępień wrote

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Sat, Jun 24, 2017 at 02:25:46AM +0200, Rafael Wysocki wrote: > On Wednesday, June 21, 2017 11:15:43 AM Darren Hart wrote: > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Michał Kępień wrote: > > > All ACPI device notify callbacks are invoked using acpi_os_execute(),

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Sat, Jun 24, 2017 at 02:25:46AM +0200, Rafael Wysocki wrote: > On Wednesday, June 21, 2017 11:15:43 AM Darren Hart wrote: > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Michał Kępień wrote: > > > All ACPI device notify callbacks are invoked using acpi_os_execute(),

Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0

;louis.da...@dell.com> > Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> Thanks, queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0

Signed-off-by: Mario Limonciello Thanks, queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] alienware-wmi: Adjust instance of all wmi_evaluate_method calls to 0

lo <mario.limoncie...@dell.com> Thanks Mario, Queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] alienware-wmi: Adjust instance of all wmi_evaluate_method calls to 0

llo Thanks Mario, Queued to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Fri, Jun 23, 2017 at 09:44:58AM +0930, Jonathan Woithe wrote: > On Thu, Jun 22, 2017 at 04:58:09PM -0700, Darren Hart wrote: > > On Thu, Jun 22, 2017 at 10:46:19PM +0200, Micha?? K??pie?? wrote: > > > > The events seen by userspace with the original code would be "

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Fri, Jun 23, 2017 at 09:44:58AM +0930, Jonathan Woithe wrote: > On Thu, Jun 22, 2017 at 04:58:09PM -0700, Darren Hart wrote: > > On Thu, Jun 22, 2017 at 10:46:19PM +0200, Micha?? K??pie?? wrote: > > > > The events seen by userspace with the original code would be "

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

On Fri, Jun 23, 2017 at 09:46:59AM +0930, Jonathan Woithe wrote: > Thanks. In case it was missed, I supplied my reviewed-by message and > sign-off in an earlier post. Yup, got it - thanks! -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

On Fri, Jun 23, 2017 at 09:46:59AM +0930, Jonathan Woithe wrote: > Thanks. In case it was missed, I supplied my reviewed-by message and > sign-off in an earlier post. Yup, got it - thanks! -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

efined for > them. I do not think we have a way of ensuring that the above holds > true for every other model out there, but I will point out that > fujitsu-laptop is the only user of acpi_bus_update_power() outside of > drivers/acpi. OK, thanks. Queueing to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

efined for > them. I do not think we have a way of ensuring that the above holds > true for every other model out there, but I will point out that > fujitsu-laptop is the only user of acpi_bus_update_power() outside of > drivers/acpi. OK, thanks. Queueing to testing. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

be happy to > revert to FIFO in v2. This all looks reasonable to me, I don't see anything requiring a respin. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

be happy to > revert to FIFO in v2. This all looks reasonable to me, I don't see anything requiring a respin. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 0/7] fujitsu-laptop: ACPI-related cleanups

gt; some way, which is why I am CCing linux-acpi as per Rafael's previous > advice. > > This patch series was based on platform-driver-x86/for-next and tested > on a Lifebook S7020. I'm satisfied with the responses to all questions on this series. Queued to testing. Thanks Michal and Jo

Re: [PATCH 0/7] fujitsu-laptop: ACPI-related cleanups

gt; some way, which is why I am CCing linux-acpi as per Rafael's previous > advice. > > This patch series was based on platform-driver-x86/for-next and tested > on a Lifebook S7020. I'm satisfied with the responses to all questions on this series. Queued to testing. Thanks Michal and Jo

Re: [PATCH 1/1] futex: remove duplicated code and fix UB

ty (it gets > optimized away anyway). > This required a minor manual merge for ARM on the tip of Linus' tree today. The reduced duplication is a welcome improvement. Reviewed-by: Darren Hart (VMware) <dvh...@infradead.org> -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/1] futex: remove duplicated code and fix UB

ty (it gets > optimized away anyway). > This required a minor manual merge for ARM on the tip of Linus' tree today. The reduced duplication is a welcome improvement. Reviewed-by: Darren Hart (VMware) -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Thu, Jun 22, 2017 at 09:20:21AM +0930, Jonathan Woithe wrote: > On Wed, Jun 21, 2017 at 11:15:43AM -0700, Darren Hart wrote: > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Micha?? K??pie?? wrote: > > > -#define RINGBUFFERSIZE 40 > > > > > > /* Debugging *

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

On Thu, Jun 22, 2017 at 09:20:21AM +0930, Jonathan Woithe wrote: > On Wed, Jun 21, 2017 at 11:15:43AM -0700, Darren Hart wrote: > > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Micha?? K??pie?? wrote: > > > -#define RINGBUFFERSIZE 40 > > > > > > /* Debugging *

Re: [PATCH 0/2] platform/x86: add const to thermal_cooling_device_ops structures

ling_device_ops structure > > drivers/platform/x86/acerhdf.c | 2 +- > drivers/platform/x86/intel_menlow.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > -- > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 0/2] platform/x86: add const to thermal_cooling_device_ops structures

ling_device_ops structure > > drivers/platform/x86/acerhdf.c | 2 +- > drivers/platform/x86/intel_menlow.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > -- > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

te for > both FUJ02B1 and FUJ02E3 to always be ACPI_STATE_D0 ("on"). > How confident are we that all implementations of these two ACPI devices lack _PS0 and _PR0 ? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 5/7] platform/x86: fujitsu-laptop: do not update ACPI device power status

te for > both FUJ02B1 and FUJ02E3 to always be ACPI_STATE_D0 ("on"). > How confident are we that all implementations of these two ACPI devices lack _PS0 and _PR0 ? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

40]; Do we know why 40 was used here? A single use magic number is fine, but it would be good to document why it is what it is if we know. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes

40]; Do we know why 40 was used here? A single use magic number is fine, but it would be good to document why it is what it is if we know. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

ne > > - do _not_ prepend it by any characters including white spaces > > (except new line :-) ) > > I have not known that those lines are parsed automatically. > Will do it in future! :-) Thanks! For reference, Patchwork tally's such things in the patch list view: https://patchwork.kernel.org/project/platform-driver-x86/list/ And, selfishly, the more normalized these are, the less likely Andy and I are to make mistakes manipulating them into the patches. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

found that there have some wmi query/evaluation > > >> code that they used 'one' as the first WMI instance number. > > >> But the number is indexed from zero that it's must less than > > >> the instance_count in _WDG. > > >> > > >> This patch

Re: WMI and Kernel:User interface

On Mon, Jun 19, 2017 at 03:10:09PM -0700, Andy Lutomirski wrote: > On Tue, Jun 13, 2017 at 9:38 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Tue, Jun 13, 2017 at 10:07:19AM -0700, Darren Hart wrote: > >> On Tue, Jun 13, 2017 at 06:52:47PM +020

Re: WMI and Kernel:User interface

On Mon, Jun 19, 2017 at 03:10:09PM -0700, Andy Lutomirski wrote: > On Tue, Jun 13, 2017 at 9:38 PM, Greg Kroah-Hartman > wrote: > > On Tue, Jun 13, 2017 at 10:07:19AM -0700, Darren Hart wrote: > >> On Tue, Jun 13, 2017 at 06:52:47PM +0200, Greg Kroah-Hartman wrote: > >

Re: [GIT PULL] Immutable branch between MFD and X86 due for the v4.13 merge window

rvive until v4.13-rc1? I suggest merging it to a local branch for safe keeping and if we see conflicts in subsequent patches, we can apply it. I doubt it will be a problem. -- Darren Hart VMware Open Source Technology Center

Re: [GIT PULL] Immutable branch between MFD and X86 due for the v4.13 merge window

ggest merging it to a local branch for safe keeping and if we see conflicts in subsequent patches, we can apply it. I doubt it will be a problem. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: silead_dmi: Add touchscreen info for PoV mobii wintab p800w

On Fri, Jun 16, 2017 at 03:22:45PM +0200, Hans de Goede wrote: > Hi, > > On 16-06-17 14:44, Andy Shevchenko wrote: > > On Thu, Jun 15, 2017 at 7:53 PM, Darren Hart <dvh...@infradead.org> wrote: > > > On Thu, Jun 15, 2017 at 08:48:3

Re: [PATCH 1/2] platform/x86: silead_dmi: Add touchscreen info for PoV mobii wintab p800w

On Fri, Jun 16, 2017 at 03:22:45PM +0200, Hans de Goede wrote: > Hi, > > On 16-06-17 14:44, Andy Shevchenko wrote: > > On Thu, Jun 15, 2017 at 7:53 PM, Darren Hart wrote: > > > On Thu, Jun 15, 2017 at 08:48:31AM +0200, Hans de Goede wrote: > > > > > > +

[GIT PULL] platform-drivers-x86 for 4.12-2

-platform-drivers-x86.git tags/platform-drivers-x86-v4.12-2 for you to fetch changes up to bf5d008164dd84d671ca2dd569a1676051f9faff: platform/x86: intel_telemetry_debugfs: fix oops when load/unload module (2017-06-13 10:57:54 -0700) Thanks, Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.12-2

-platform-drivers-x86.git tags/platform-drivers-x86-v4.12-2 for you to fetch changes up to bf5d008164dd84d671ca2dd569a1676051f9faff: platform/x86: intel_telemetry_debugfs: fix oops when load/unload module (2017-06-13 10:57:54 -0700) Thanks, Darren Hart VMware Open Source Technology Center

Re: [PATCH 2/2] platform/x86: silead_dmi: Add touchscreen info for Pipo W2S tablet

On Thu, Jun 15, 2017 at 08:48:32AM +0200, Hans de Goede wrote: > Add touchscreen info for Pipo W2S tablet. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Queued to testing, thanks Hans! -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 2/2] platform/x86: silead_dmi: Add touchscreen info for Pipo W2S tablet

On Thu, Jun 15, 2017 at 08:48:32AM +0200, Hans de Goede wrote: > Add touchscreen info for Pipo W2S tablet. > > Signed-off-by: Hans de Goede Queued to testing, thanks Hans! -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: silead_dmi: Add touchscreen info for PoV mobii wintab p800w

ate... With words like "Aptio CRB" it's clear the vendor isn't doing their job and just using unmodified reference code. The problem with this of course is that the vendor is not providing a way to identify this hardware. Andy, I'd appreciate your thoughts on this... I'm leaning towards n

Re: [PATCH 1/2] platform/x86: silead_dmi: Add touchscreen info for PoV mobii wintab p800w

"Aptio CRB" it's clear the vendor isn't doing their job and just using unmodified reference code. The problem with this of course is that the vendor is not providing a way to identify this hardware. Andy, I'd appreciate your thoughts on this... I'm leaning towards not accepting bios date (o

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Wed, Jun 14, 2017 at 05:46:54PM +0200, Pali Rohár wrote: > On Tuesday 13 June 2017 11:42:28 Darren Hart wrote: > > On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote: > > > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote: > > > > I'd suggest r

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Wed, Jun 14, 2017 at 05:46:54PM +0200, Pali Rohár wrote: > On Tuesday 13 June 2017 11:42:28 Darren Hart wrote: > > On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote: > > > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote: > > > > I'd suggest r

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote: > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote: > > On Sat, Jun 10, 2017 at 09:15:57PM +0200, Pali Rohár wrote: > > > On Saturday 27 May 2017 13:55:34 Pali Rohár wrote: > > > > instance_count defin

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote: > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote: > > On Sat, Jun 10, 2017 at 09:15:57PM +0200, Pali Rohár wrote: > > > On Saturday 27 May 2017 13:55:34 Pali Rohár wrote: > > > > instance_count defin

Re: WMI and Kernel:User interface

reg's advice and get some code out there for review. I don't think we're going to make more progress in pre-code discussions. Thanks for all the time and effort everyone has put into the discussion. -- Darren Hart VMware Open Source Technology Center

Re: WMI and Kernel:User interface

reg's advice and get some code out there for review. I don't think we're going to make more progress in pre-code discussions. Thanks for all the time and effort everyone has put into the discussion. -- Darren Hart VMware Open Source Technology Center

Re: WMI and Kernel:User interface

On Tue, Jun 13, 2017 at 07:16:11PM +0200, Pali Rohár wrote: > On Tuesday 13 June 2017 17:38:57 Darren Hart wrote: > > I'll mention this again I suspect in this thread, but rather than a > > "WMI filter" we can implement a "WMI proxy". If a kernel driver > &g

<    3   4   5   6   7   8   9   10   11   12   >