Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

On Tue, Jun 14, 2016 at 08:37:14PM +0300, Andy Shevchenko wrote: > On Tue, 2016-06-14 at 10:26 -0700, David Cohen wrote: > > > > Yes. Will rename in this way, re-test and re-send. > > > > I'm curious about that. What pmu prefix would stand for? > > It's

Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

On Tue, Jun 14, 2016 at 08:37:14PM +0300, Andy Shevchenko wrote: > On Tue, 2016-06-14 at 10:26 -0700, David Cohen wrote: > > > > Yes. Will rename in this way, re-test and re-send. > > > > I'm curious about that. What pmu prefix would stand for? > > It's

Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

On Tue, Jun 14, 2016 at 10:26:21AM -0700, David Cohen wrote: > Hi, > > On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote: > > On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote: > > > * Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: >

Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

On Tue, Jun 14, 2016 at 10:26:21AM -0700, David Cohen wrote: > Hi, > > On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote: > > On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote: > > > * Andy Shevchenko wrote: > > > > > > > On Tue,

Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

Hi, On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote: > On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > > > > On Tue, 2016-06-14 at 17:29 +0200, Ingo Molnar wrote: > > > > > > > * Andy Shevchenko

Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

Hi, On Tue, Jun 14, 2016 at 07:07:14PM +0300, Andy Shevchenko wrote: > On Tue, 2016-06-14 at 17:58 +0200, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > > > > On Tue, 2016-06-14 at 17:29 +0200, Ingo Molnar wrote: > > > > > > > * Andy Shevchenko wrote: > > > > > > > > > On Tue,

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Heikki, On Wed, Dec 02, 2015 at 12:27:10PM +0200, Heikki Krogerus wrote: > Hi David, > > > > > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > > +{ > > > > There are still 2 pending comments for this unregister function: > > > > 1) How about a protection against unbalanced

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Heikki, On Wed, Dec 02, 2015 at 12:27:10PM +0200, Heikki Krogerus wrote: > Hi David, > > > > > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > > +{ > > > > There are still 2 pending comments for this unregister function: > > > > 1) How about a protection against unbalanced

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Felipe, On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote: [snip] > > +EXPORT_SYMBOL_GPL(intel_usb_mux_register); > > + > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > +{ > > + extcon_unregister_notifier(>edev, EXTCON_USB_HOST, >nb); > > +

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Heikki, Follow my comments below. On Tue, Dec 01, 2015 at 03:32:37PM +0200, Heikki Krogerus wrote: > Several Intel PCHs and SOCs have an internal mux that is > used to share one USB port between USB Device Controller and > xHCI. The mux is normally handled by System FW/BIOS, but not > always.

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Heikki, Follow my comments below. On Tue, Dec 01, 2015 at 03:32:37PM +0200, Heikki Krogerus wrote: > Several Intel PCHs and SOCs have an internal mux that is > used to share one USB port between USB Device Controller and > xHCI. The mux is normally handled by System FW/BIOS, but not > always.

Re: [PATCH 1/2] extcon: add driver for Intel USB mux

Hi Felipe, On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote: [snip] > > +EXPORT_SYMBOL_GPL(intel_usb_mux_register); > > + > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > +{ > > + extcon_unregister_notifier(>edev, EXTCON_USB_HOST, >nb); > > +

[PATCH] wdt: intel-mid: add Magic Closure flag

Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog is opened, it makes sense to disable watchdog only if it was gracefully released. Signed-off-by: David Cohen --- drivers/watchdog/intel-mid_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] wdt: intel-mid: add Magic Closure flag

Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog is opened, it makes sense to disable watchdog only if it was gracefully released. Signed-off-by: David Cohen <david.a.co...@linux.intel.com> --- drivers/watchdog/intel-mid_wdt.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] usb: gadget: amd5536udc: fix NULL pointer dereference

Hi Sudip, On Fri, Sep 04, 2015 at 05:12:23PM +0530, Sudip Mukherjee wrote: > We were checking if dev->regs is NULL but it was done after > dereferencing it. Lets reset the controller and iounmap dev->regs only > if it is not NULL. > free_irq() does not need dev->regs, so unmaping it before

Re: [PATCH] usb: gadget: amd5536udc: fix NULL pointer dereference

Hi Sudip, On Fri, Sep 04, 2015 at 05:12:23PM +0530, Sudip Mukherjee wrote: > We were checking if dev->regs is NULL but it was done after > dereferencing it. Lets reset the controller and iounmap dev->regs only > if it is not NULL. > free_irq() does not need dev->regs, so unmaping it before

Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote: > On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote: > > Phy drivers and the ulpi interface providers depend on the > > registration of the ulpi bus. Ulpi registers the bus in > > module_init(). This could cause

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

Hi Greg, On Tue, May 26, 2015 at 07:41:18PM -0700, Greg KH wrote: > On Tue, May 26, 2015 at 10:54:01AM -0700, David Cohen wrote: > > Hi, > > > > On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote: > > > Greg KH writes: > > > > > > > I

Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote: On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote: Phy drivers and the ulpi interface providers depend on the registration of the ulpi bus. Ulpi registers the bus in module_init(). This could cause unnecessary

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

Hi Greg, On Tue, May 26, 2015 at 07:41:18PM -0700, Greg KH wrote: On Tue, May 26, 2015 at 10:54:01AM -0700, David Cohen wrote: Hi, On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote: Greg KH gre...@linuxfoundation.org writes: If there are other bus drivers that do

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

Hi, On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote: > Greg KH writes: > > > If there are other bus drivers that do this, I'll go fix them up, > > pointers to those files would be appreciated. > > git grep -E 'if .*\.p\W' found a couple of interesting candidates you > might want to

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

Hi, On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote: Greg KH gre...@linuxfoundation.org writes: If there are other bus drivers that do this, I'll go fix them up, pointers to those files would be appreciated. git grep -E 'if .*\.p\W' found a couple of interesting candidates

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

On Fri, May 22, 2015 at 03:50:47PM +0800, Lu, Baolu wrote: > > > On 05/22/2015 02:46 PM, Lu, Baolu wrote: > > > > > >On 05/22/2015 11:11 AM, David Cohen wrote: > >>On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: > >>>Hi, > >>

Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote: > Phy drivers and the ulpi interface providers depend on the > registeration of the ulpi bus. Ulpi registers the bus in > module_init(). This could result in a load order issue, i.e. It's still not an issue :( I'd say "unnecessary

Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote: Phy drivers and the ulpi interface providers depend on the registeration of the ulpi bus. Ulpi registers the bus in module_init(). This could result in a load order issue, i.e. It's still not an issue :( I'd say unnecessary probe

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

On Fri, May 22, 2015 at 03:50:47PM +0800, Lu, Baolu wrote: On 05/22/2015 02:46 PM, Lu, Baolu wrote: On 05/22/2015 11:11 AM, David Cohen wrote: On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: Many drivers

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: > Hi, > > On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: > > Many drivers and modules depend on ULPI bus registeration to > > register ULPI interfaces and drivers. It's more appropriate >

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: > Many drivers and modules depend on ULPI bus registeration to > register ULPI interfaces and drivers. It's more appropriate > to register ULPI bus in subsys_initcall instead of module_init. > > Kernel panic has been reported with

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: Many drivers and modules depend on ULPI bus registeration to register ULPI interfaces and drivers. It's more appropriate to register ULPI bus in subsys_initcall instead of module_init. Kernel panic has been reported with some

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: Many drivers and modules depend on ULPI bus registeration to register ULPI interfaces and drivers. It's more appropriate to register ULPI bus in subsys_initcall

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

may trigger BUG() on driver_register(). I wonder if it would be nice to have a macro for that checking :) Anyway, Reviewed-by: David Cohen > drv->driver.bus = _bus; > > return driver_register(>driver); > -- > 1.7.10.4 > -- To unsubscribe from this list: send t

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

for that checking :) Anyway, Reviewed-by: David Cohen david.a.co...@linux.intel.com drv-driver.bus = ulpi_bus; return driver_register(drv-driver); -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote: > Hi, Hi Felipe, > > On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote: > > > > > > When going into bus suspend/resume we _must_ > > > > > > call gadget driver's ->su

Re: [PATCH] usb: dwc3: gadget: call gadget driver's -suspend/-resume

On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote: Hi, Hi Felipe, On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote: When going into bus suspend/resume we _must_ call gadget driver's -suspend/-resume callbacks accordingly. This patch implements

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

On Fri, Apr 24, 2015 at 02:48:27PM -0500, Felipe Balbi wrote: > Hi, Hi Felipe, > > On Thu, Apr 23, 2015 at 03:37:48PM -0700, David Cohen wrote: > > On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: > > > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David C

Re: [PATCH] usb: dwc3: gadget: call gadget driver's -suspend/-resume

On Fri, Apr 24, 2015 at 02:48:27PM -0500, Felipe Balbi wrote: Hi, Hi Felipe, On Thu, Apr 23, 2015 at 03:37:48PM -0700, David Cohen wrote: On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: From: Felipe Balbi ba

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

Hi Greg, On Fri, Apr 17, 2015 at 09:42:57PM +0200, Greg KH wrote: > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: > > From: Felipe Balbi > > > > When going into bus suspend/resume we _must_ > > call gadget driver's ->suspend/->resume call

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

Hi Felipe, On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: > > From: Felipe Balbi > > missing the required: > > [ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ] > > > &

Re: [PATCH] usb: dwc3: gadget: call gadget driver's -suspend/-resume

Hi Greg, On Fri, Apr 17, 2015 at 09:42:57PM +0200, Greg KH wrote: On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: From: Felipe Balbi ba...@ti.com When going into bus suspend/resume we _must_ call gadget driver's -suspend/-resume callbacks accordingly. This patch

Re: [PATCH] usb: dwc3: gadget: call gadget driver's -suspend/-resume

Hi Felipe, On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: From: Felipe Balbi ba...@ti.com missing the required: [ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ] When going into bus suspend

[PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

From: Felipe Balbi When going into bus suspend/resume we _must_ call gadget driver's ->suspend/->resume callbacks accordingly. This patch implements that very feature which has been missing forever. Cc: # 3.14 Signed-off-by: Felipe Balbi Signed-off-by: David Cohen --- Hi, This

[PATCH] usb: dwc3: gadget: call gadget driver's -suspend/-resume

-by: David Cohen david.a.co...@linux.intel.com --- Hi, This patch was introduced on v3.15. But the issue it fixes already existed on v3.14 and v3.14 is a long term support version. I propose to backport it over there as well. BR, David --- drivers/usb/dwc3/gadget.c | 35

[RFC] gpio: add set_active_low() function to gpio_chip

Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented, we no longer need to do soft flips on values from non-raw get functions. Signed-off-by: David Cohen

Re: [PATCHv2 00/12] usb: ulpi bus

On Wed, Mar 18, 2015 at 10:12:13AM -0700, David Cohen wrote: > Hi, > > On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote: > > > > Major changes since v1: > > - calling dwc3_phy_setup earlier and registering the ULPI interface there. > > - n

Re: [PATCHv2 00/12] usb: ulpi bus

Hi, On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote: > > Major changes since v1: > - calling dwc3_phy_setup earlier and registering the ULPI interface there. > - new property to dwc3 for selecting the interface in case of UTMI+ and ULPI > as > suggested by Felipe > - dwc3 soft

Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails

Hi Heikki, On Wed, Mar 18, 2015 at 02:40:30PM +0200, Heikki Krogerus wrote: > On some BYT platforms the USB2 PHY needs to be put into > operational mode by the controller driver with GPIOs > controlling the PHYs reset and cs signals. > > Signed-off-by: Heikki Krogerus > --- >

Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering

On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote: > Hello. > > On 3/18/2015 3:40 PM, Heikki Krogerus wrote: > > >ULPI PHYs need to be bound to their controllers with a > >lookup. This adds helpers that the ULPI drivers can use to > >do both, the registration of the PHY and the

Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering

On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote: Hello. On 3/18/2015 3:40 PM, Heikki Krogerus wrote: ULPI PHYs need to be bound to their controllers with a lookup. This adds helpers that the ULPI drivers can use to do both, the registration of the PHY and the lookup, at

Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails

Hi Heikki, On Wed, Mar 18, 2015 at 02:40:30PM +0200, Heikki Krogerus wrote: On some BYT platforms the USB2 PHY needs to be put into operational mode by the controller driver with GPIOs controlling the PHYs reset and cs signals. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com

Re: [PATCHv2 00/12] usb: ulpi bus

Hi, On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote: Major changes since v1: - calling dwc3_phy_setup earlier and registering the ULPI interface there. - new property to dwc3 for selecting the interface in case of UTMI+ and ULPI as suggested by Felipe - dwc3 soft reset

Re: [PATCHv2 00/12] usb: ulpi bus

On Wed, Mar 18, 2015 at 10:12:13AM -0700, David Cohen wrote: Hi, On Wed, Mar 18, 2015 at 02:40:21PM +0200, Heikki Krogerus wrote: Major changes since v1: - calling dwc3_phy_setup earlier and registering the ULPI interface there. - new property to dwc3 for selecting the interface

[RFC] gpio: add set_active_low() function to gpio_chip

Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented, we no longer need to do soft flips on values from non-raw get functions. Signed-off-by: David Cohen

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Mon, Mar 16, 2015 at 09:46:00AM -0700, David Cohen wrote: > Adding Mika to CC list. Grrr :( Adding for real now. > > Br, David > > On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: > > Hi Linus, > > > > On Mon, Mar 09, 2015 at 11:16:08AM -0500,

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Adding Mika to CC list. Br, David On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: > Hi Linus, > > On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > > > On Fri, Feb 20, 2015

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Adding Mika to CC list. Br, David On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: On Fri, Feb 20, 2015 at 8:17 PM, David Cohen

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Mon, Mar 16, 2015 at 09:46:00AM -0700, David Cohen wrote: Adding Mika to CC list. Grrr :( Adding for real now. Br, David On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: On Sat, Mar 07, 2015

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen > > wrote: > > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: On Fri, Feb 20, 2015 at 8:17 PM, David Cohen david.a.co...@linux.intel.com wrote: On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: I

Re: [RFC PATCH] gpio: support for GPIO forwarding

On Wed, Feb 25, 2015 at 10:34:45AM +0900, Alexandre Courbot wrote: > On Wed, Feb 25, 2015 at 5:34 AM, David Cohen > wrote: > > Hi, > > > >> If we decide to go ahead with the solution proposed by this patch for > >> practical reasons (which are good reasons in

Re: [RFC PATCH] gpio: support for GPIO forwarding

On Wed, Feb 25, 2015 at 10:34:45AM +0900, Alexandre Courbot wrote: On Wed, Feb 25, 2015 at 5:34 AM, David Cohen david.a.co...@linux.intel.com wrote: Hi, If we decide to go ahead with the solution proposed by this patch for practical reasons (which are good reasons indeed), I still have

Re: [RFC PATCH] gpio: support for GPIO forwarding

Hi, > If we decide to go ahead with the solution proposed by this patch for > practical reasons (which are good reasons indeed), I still have one > problem with its current form. > > As the discussion highlighted, this is an ACPI problem, so I'd very > much like it to be confined to the ACPI

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, [snip] > Felipe suggested to "divide to conquer" instead of having a single > extcon driver to handle all these functions: > > - The mux functions would be controlled by a possible new pinctrl-gpio > driver (Linus, your input here would be nice :) > - The VBUS would be a fixed regulator > -

Re: [RFC PATCH] gpio: support for GPIO forwarding

Hi, If we decide to go ahead with the solution proposed by this patch for practical reasons (which are good reasons indeed), I still have one problem with its current form. As the discussion highlighted, this is an ACPI problem, so I'd very much like it to be confined to the ACPI GPIO

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, [snip] Felipe suggested to divide to conquer instead of having a single extcon driver to handle all these functions: - The mux functions would be controlled by a possible new pinctrl-gpio driver (Linus, your input here would be nice :) - The VBUS would be a fixed regulator - The USB

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote: > > On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: > > > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > >

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > > Hi Linus and Robert, > > > > CC'ing Heikki as it involves a RFC from him. > > > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Wa

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote: > On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > > A

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 01:09:00PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote: > > Hi, > > > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrot

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus and Robert, CC'ing Heikki as it involves a RFC from him. On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga wrote: > > Hi David, > > > > On 02/19/2015 08:59 PM, David Cohen wrote: > >> Some I

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > As always, comments are welcome. > > Are nits welcome too? > > > +MODULE_LICENSE("GPLv2"); > > You probably meant > MODULE

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote: On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: Hi Linus and Robert, CC'ing

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: As always, comments are welcome. Are nits welcome too? +MODULE_LICENSE(GPLv2); You probably meant MODULE_LICENSE(GPL v2) Didn't that trigger a warning

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote: On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: As always, comments are welcome. Are nits welcome too

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 01:09:00PM -0600, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote: Hi, On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: As always, comments are welcome

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus and Robert, CC'ing Heikki as it involves a RFC from him. On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga r.bald...@samsung.com wrote: Hi David, On 02/19/2015 08:59 PM, David Cohen wrote: Some Intel platforms have

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: Hi Linus and Robert, CC'ing Heikki as it involves a RFC from him. On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: On Fri, Feb 20, 2015 at 7:41

[PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

is high, by standard, the OTG port is configured for device role by not sourcing VBUS and switching D+/- to device controller. Signed-off-by: David Cohen --- Hi, Since splitting this driver into smaller pieces would result in ugly fixes WRT ACPI, I'm resending the same approach. This time I

[PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

is high, by standard, the OTG port is configured for device role by not sourcing VBUS and switching D+/- to device controller. Signed-off-by: David Cohen david.a.co...@linux.intel.com --- Hi, Since splitting this driver into smaller pieces would result in ugly fixes WRT ACPI, I'm resending

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, On Wed, Feb 18, 2015 at 12:17:06PM +0200, Mika Westerberg wrote: > On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote: > > Hi, > > > > Adding Mika. > > > > On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: > > > Hi, > > &

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, On Wed, Feb 18, 2015 at 12:17:06PM +0200, Mika Westerberg wrote: On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote: Hi, Adding Mika. On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: Hi, On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, Adding Mika. On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote: > > > > > > (3) Platform has 2 USB controllers connected to same port: one for > > > > > > de

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus, Thanks for reviewing. On Thu, Jan 08, 2015 at 08:23:03PM +0100, Linus Walleij wrote: > On Mon, Dec 22, 2014 at 11:43 PM, David Cohen > wrote: > > > Some platforms have an USB OTG port fully (or partially) controlled by > > GPIOs: > > > > (1) USB

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Felipe and Linus, On Thu, Dec 25, 2014 at 10:49:29PM -0600, Felipe Balbi wrote: > Hi, > > On Wed, Dec 24, 2014 at 02:43:27PM -0800, David Cohen wrote: > > Hi Felipe, > > > > Thanks replying. > > > > On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Bal

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Linus, Thanks for reviewing. On Thu, Jan 08, 2015 at 08:23:03PM +0100, Linus Walleij wrote: On Mon, Dec 22, 2014 at 11:43 PM, David Cohen david.a.co...@linux.intel.com wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi Felipe and Linus, On Thu, Dec 25, 2014 at 10:49:29PM -0600, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 02:43:27PM -0800, David Cohen wrote: Hi Felipe, Thanks replying. On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Balbi wrote: Hi, On Mon, Dec 22, 2014 at 02:43

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

Hi, Adding Mika. On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: Hi, On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote: (3) Platform has 2 USB controllers connected to same port: one for device and one for host role. D+/- are switched between phys

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

On Fri, Feb 13, 2015 at 04:03:57PM -0600, Felipe Balbi wrote: > On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote: > > Hi Felipe, > > > > [snip] > > > > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > > > index 8d

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: > On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

Hi Felipe, [snip] > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index 8d95056..53902ea 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > > #include

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

Hi Felipe, [snip] diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 8d95056..53902ea 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -21,6 +21,7 @@ #include linux/slab.h #include linux/pci.h #include linux/platform_device.h

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

On Fri, Feb 13, 2015 at 04:03:57PM -0600, Felipe Balbi wrote: On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote: Hi Felipe, [snip] diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 8d95056..53902ea 100644 --- a/drivers/usb/dwc3/dwc3-pci.c

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > index a8c9062..66cbf38 100644 > > > > --- a/driver

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

Hi Heikki, Sorry I am starting a new branch on this thread. I need to go back to another topic on this same patch. On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote: > TUSB1210 ULPI PHY has vendor specific register for eye > diagram tuning. On some platforms the system firmware has

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index a8c9062..66cbf38 100644 > > > --- a/drivers/usb/dwc3/core.c > > > +++ b/drivers/usb/dwc3/core.c > > > @@ -879,6 +879,10 @@ static int dwc3_probe(struct

Re: [RFC] USB phy type C

On Thu, Feb 12, 2015 at 12:45:53PM -0600, Felipe Balbi wrote: > Hi, > > On Thu, Feb 12, 2015 at 10:41:37AM -0800, David Cohen wrote: > > Hi Felipe, et al, > > > > Is there any on going discussion regarding to USB phy for type C connectors? > > > > We'd

[RFC] USB phy type C

Hi Felipe, et al, Is there any on going discussion regarding to USB phy for type C connectors? We'd like to know the community's preferable direction for handling (still unsupported) cases like USB3.1 PD, Accessories and Alternate modes as a new layer or an extension of current USB phy layer.

[RFC] USB phy type C

Hi Felipe, et al, Is there any on going discussion regarding to USB phy for type C connectors? We'd like to know the community's preferable direction for handling (still unsupported) cases like USB3.1 PD, Accessories and Alternate modes as a new layer or an extension of current USB phy layer.

Re: [RFC] USB phy type C

On Thu, Feb 12, 2015 at 12:45:53PM -0600, Felipe Balbi wrote: Hi, On Thu, Feb 12, 2015 at 10:41:37AM -0800, David Cohen wrote: Hi Felipe, et al, Is there any on going discussion regarding to USB phy for type C connectors? We'd like to know the community's preferable direction

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a8c9062..66cbf38 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device

  1   2   3   4   5   6   7   8   9   10   >