Re: [PATCH] regulator: core: avoid regulator_resolve_supply() race condition

2021-01-22 Thread David Collins
Hello Mark, On 1/21/21 12:30 PM, Marek Szyprowski wrote: Hi Mark, On 21.01.2021 16:44, Mark Brown wrote: On Thu, Jan 21, 2021 at 10:41:59AM +0100, Marek Szyprowski wrote: On 18.01.2021 21:49, Mark Brown wrote: Does this help (completely untested): Sadly nope. I get same warning: Try this

[PATCH] regulator: core: avoid regulator_resolve_supply() race condition

2021-01-07 Thread David Collins
'17a0.rsc:rpmh-regulator-gfxlvl-pm8350_s5_level' already present! Avoid this race condition by holding the rdev->mutex lock inside of regulator_resolve_supply() while checking and setting rdev->supply. Signed-off-by: David Collins --- drive

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-13 Thread David Collins
On 10/2/20 2:39 PM, Stephen Boyd wrote: > I see things like this on my console: > > [1.684617] spmi spmi-0: PMIC arbiter version v5 (0x5000) > > and 'spmi' is the bus name I'm thinking about. But I think that's > because there isn't a driver attached. Nothing prints for the 0-00 > device

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-01 Thread David Collins
On 10/1/20 11:51 AM, Stephen Boyd wrote: > Quoting Mark Brown (2020-10-01 10:43:26) >> On Wed, Sep 30, 2020 at 05:07:20PM -0700, Stephen Boyd wrote: >>> Quoting David Collins (2020-09-22 15:04:18) >> >>>> This helps to disambiguate SPMI device regmaps from I2C o

[RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-09-22 Thread David Collins
Change the format of spmi bus device names from: - Example: 0-01 to this: spmi- Example: spmi0-01 This helps to disambiguate SPMI device regmaps from I2C ones at /sys/kernel/debug/regmap since I2C devices use a very similar naming scheme: 0-. Signed-off-by: David Collins

[PATCH] spmi: prefix spmi bus device names with "spmi"

2020-08-28 Thread David Collins
Change the format of spmi bus device names from: - Example: 0-01 to this: spmi- Example: spmi0-01 This helps to disambiguate SPMI device regmaps from I2C ones at /sys/kernel/debug/regmap since I2C devices use a very similar naming scheme: 0-. Signed-off-by: David Collins

Re: [PATCH v3 0/4] Solve postboot supplier cleanup and optimize probe ordering

2019-07-02 Thread David Collins
Hello Saravana, On 7/1/19 5:48 PM, Saravana Kannan wrote: ... > TODO: > - For the case of consumer child sub-nodes being added by a parent > device after late_initcall_sync we might be able to address that by > recursively parsing all child nodes and adding all their suppliers as >

Re: [PATCH v2 2/3] of/platform: Add functional dependency link from DT bindings

2019-06-28 Thread David Collins
Hello Saravana, On 6/27/19 7:22 PM, Saravana Kannan wrote: > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 04ad312fd85b..8d690fa0f47c 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -61,6 +61,72 @@ struct platform_device *of_find_device_by_node(struct

Re: [PATCH v1 0/5] Solve postboot supplier cleanup and optimize probe ordering

2019-05-31 Thread David Collins
Hello Saravana, On 5/23/19 6:01 PM, Saravana Kannan wrote: ... > Having functional dependencies explicitly called out in DT and > automatically added before the devices are probed, provides the > following benefits: ... > - Supplier devices like clock providers, regulators providers, etc > need

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-16 Thread David Collins
Hello Doug, On 08/16/2018 01:07 PM, Doug Anderson wrote: > I'll work on either adding more regulator_set_load() calls to clients > or perhaps disabling the "regulator-allow-set-load" for a bunch of > rails. David: presumably if we have a rail that we never need to be > on-and-in-low-power-mode

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-16 Thread David Collins
Hello Doug, On 08/16/2018 01:07 PM, Doug Anderson wrote: > I'll work on either adding more regulator_set_load() calls to clients > or perhaps disabling the "regulator-allow-set-load" for a bunch of > rails. David: presumably if we have a rail that we never need to be > on-and-in-low-power-mode

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
On 08/14/2018 04:56 PM, Doug Anderson wrote: > On Tue, Aug 14, 2018 at 2:59 PM, David Collins > wrote: >> On 08/14/2018 01:03 PM, Doug Anderson wrote: >>> On Tue, Aug 14, 2018 at 11:30 AM, David Collins >>> wrote:>>> --- a/drivers/regulator/core

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
On 08/14/2018 04:56 PM, Doug Anderson wrote: > On Tue, Aug 14, 2018 at 2:59 PM, David Collins > wrote: >> On 08/14/2018 01:03 PM, Doug Anderson wrote: >>> On Tue, Aug 14, 2018 at 11:30 AM, David Collins >>> wrote:>>> --- a/drivers/regulator/core

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
Hi, On 08/14/2018 01:03 PM, Doug Anderson wrote: > On Tue, Aug 14, 2018 at 11:30 AM, David Collins > wrote:>>> --- a/drivers/regulator/core.c >>> +++ b/drivers/regulator/core.c >>> @@ -732,6 +732,7 @@ static int drms_uA_update(struct regulator_dev *rdev) &g

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
Hi, On 08/14/2018 01:03 PM, Doug Anderson wrote: > On Tue, Aug 14, 2018 at 11:30 AM, David Collins > wrote:>>> --- a/drivers/regulator/core.c >>> +++ b/drivers/regulator/core.c >>> @@ -732,6 +732,7 @@ static int drms_uA_update(struct regulator_dev *rdev) &g

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
Hello Doug, On 08/14/2018 10:06 AM, Douglas Anderson wrote: > Not all regulator consumers call regulator_set_load(). On some > regulators (like on RPMh-regulator) this could be bad since the > regulator framework will treat this as if consumer needs no load. > It's much better to assume that a

Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

2018-08-14 Thread David Collins
Hello Doug, On 08/14/2018 10:06 AM, Douglas Anderson wrote: > Not all regulator consumers call regulator_set_load(). On some > regulators (like on RPMh-regulator) this could be bad since the > regulator framework will treat this as if consumer needs no load. > It's much better to assume that a

Re: [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases

2018-08-10 Thread David Collins
8,7 @@ static unsigned int > rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; Reviewed-by: David Collins -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases

2018-08-10 Thread David Collins
8,7 @@ static unsigned int > rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; Reviewed-by: David Collins -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

[PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-13 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh

[PATCH v9 0/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
lkml.org/lkml/2018/5/11/701 [13]: https://lkml.org/lkml/2018/4/13/687 [14]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPMh regulator bindings regulator: add QCOM RPMh regulator driver .../bindings/regulator/qcom,rpmh-regulator.txt | 160

[PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-13 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh

[PATCH v9 0/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
lkml.org/lkml/2018/5/11/701 [13]: https://lkml.org/lkml/2018/4/13/687 [14]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPMh regulator bindings regulator: add QCOM RPMh regulator driver .../bindings/regulator/qcom,rpmh-regulator.txt | 160

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-12 Thread David Collins
On 07/12/2018 09:54 AM, Mark Brown wrote: > On Mon, Jul 09, 2018 at 04:44:14PM -0700, David Collins wrote: >> On 07/02/2018 03:28 AM, Mark Brown wrote: >>> On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: >>>> +static unsigned int rpmh_regulator_pmic

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-12 Thread David Collins
On 07/12/2018 09:54 AM, Mark Brown wrote: > On Mon, Jul 09, 2018 at 04:44:14PM -0700, David Collins wrote: >> On 07/02/2018 03:28 AM, Mark Brown wrote: >>> On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: >>>> +static unsigned int rpmh_regulator_pmic

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-11 Thread David Collins
Hello Doug, On 07/11/2018 03:43 PM, Doug Anderson wrote: > On Wed, Jul 11, 2018 at 3:36 PM, David Collins > wrote: >>> On Tue, Jul 10, 2018 at 10:45 AM, David Collins >>> wrote: >>>> On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: >>>>> On F

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-11 Thread David Collins
Hello Doug, On 07/11/2018 03:43 PM, Doug Anderson wrote: > On Wed, Jul 11, 2018 at 3:36 PM, David Collins > wrote: >>> On Tue, Jul 10, 2018 at 10:45 AM, David Collins >>> wrote: >>>> On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: >>>>> On F

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-11 Thread David Collins
Hello Doug, > On Tue, Jul 10, 2018 at 10:45 AM, David Collins > wrote: >> On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: >>> On Fri, Jun 29, 2018 at 02:29:55PM -0700, David Collins wrote: >> ... >>>> The PMIC TEMP_ALARM hardware peripheral will perform

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-11 Thread David Collins
Hello Doug, > On Tue, Jul 10, 2018 at 10:45 AM, David Collins > wrote: >> On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: >>> On Fri, Jun 29, 2018 at 02:29:55PM -0700, David Collins wrote: >> ... >>>> The PMIC TEMP_ALARM hardware peripheral will perform

Re: [PATCH 2/3] arm64: dts: qcom: sdm845-mtp: Add RPMh VRM/XOB regulators

2018-07-10 Thread David Collins
Hi, On 07/10/2018 03:55 PM, Doug Anderson wrote: > On Tue, Jul 10, 2018 at 3:32 PM, David Collins > wrote: >> On 07/10/2018 03:02 PM, Douglas Anderson wrote: >> ... >>> + vdd-s1-supply = <_pwr>; >>> + vdd-s2-supply = <_

Re: [PATCH 2/3] arm64: dts: qcom: sdm845-mtp: Add RPMh VRM/XOB regulators

2018-07-10 Thread David Collins
Hi, On 07/10/2018 03:55 PM, Doug Anderson wrote: > On Tue, Jul 10, 2018 at 3:32 PM, David Collins > wrote: >> On 07/10/2018 03:02 PM, Douglas Anderson wrote: >> ... >>> + vdd-s1-supply = <_pwr>; >>> + vdd-s2-supply = <_

Re: [PATCH 2/3] arm64: dts: qcom: sdm845-mtp: Add RPMh VRM/XOB regulators

2018-07-10 Thread David Collins
Hello Doug, On 07/10/2018 03:02 PM, Douglas Anderson wrote: ... > + vdd-s1-supply = <_pwr>; > + vdd-s2-supply = <_pwr>; > + vdd-s3-supply = <_pwr>; > + vdd-s4-supply = <_pwr>; > + vdd-s5-supply = <_pwr>; > + vdd-s6-supply =

Re: [PATCH 2/3] arm64: dts: qcom: sdm845-mtp: Add RPMh VRM/XOB regulators

2018-07-10 Thread David Collins
Hello Doug, On 07/10/2018 03:02 PM, Douglas Anderson wrote: ... > + vdd-s1-supply = <_pwr>; > + vdd-s2-supply = <_pwr>; > + vdd-s3-supply = <_pwr>; > + vdd-s4-supply = <_pwr>; > + vdd-s5-supply = <_pwr>; > + vdd-s6-supply =

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-10 Thread David Collins
Hello Matthias, On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: > On Fri, Jun 29, 2018 at 02:29:55PM -0700, David Collins wrote: ... >> The PMIC TEMP_ALARM hardware peripheral will perform an automatic partial >> PMIC shutdown upon hitting over-temperature stage 2 (125 C). Th

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-07-10 Thread David Collins
Hello Matthias, On 06/29/2018 04:54 PM, Matthias Kaehlcke wrote: > On Fri, Jun 29, 2018 at 02:29:55PM -0700, David Collins wrote: ... >> The PMIC TEMP_ALARM hardware peripheral will perform an automatic partial >> PMIC shutdown upon hitting over-temperature stage 2 (125 C). Th

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-09 Thread David Collins
Hello Mark, On 07/02/2018 03:28 AM, Mark Brown wrote: > On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: > >> --- /dev/null >> +++ b/drivers/regulator/qcom-rpmh-regulator.c >> @@ -0,0 +1,746 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* Copy

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-09 Thread David Collins
Hello Mark, On 07/02/2018 03:28 AM, Mark Brown wrote: > On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: > >> --- /dev/null >> +++ b/drivers/regulator/qcom-rpmh-regulator.c >> @@ -0,0 +1,746 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* Copy

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-06-29 Thread David Collins
(135°C ?). This > would be roughly in line with a system reset I observed in an earlier > test at a temperature > 125°C. If that's correct the trip points need > to be revisited. > > Maybe David Collins who recently extended the driver to add support > for GEN2 PMIC peripherals can pr

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

2018-06-29 Thread David Collins
(135°C ?). This > would be roughly in line with a system reset I observed in an earlier > test at a temperature > 125°C. If that's correct the trip points need > to be revisited. > > Maybe David Collins who recently extended the driver to add support > for GEN2 PMIC peripherals can pr

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-28 Thread David Collins
Hello Mark, On 06/28/2018 03:18 AM, Mark Brown wrote: > On Wed, Jun 27, 2018 at 09:28:03AM -0700, Doug Anderson wrote: > >> OK, great. I guess I'm confused about the "|| COMPILE_TEST" causing >> problems then? I was worried that anyone trying to do "COMPILE_TEST" >> on your tree (or linuxnext

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-28 Thread David Collins
Hello Mark, On 06/28/2018 03:18 AM, Mark Brown wrote: > On Wed, Jun 27, 2018 at 09:28:03AM -0700, Doug Anderson wrote: > >> OK, great. I guess I'm confused about the "|| COMPILE_TEST" causing >> problems then? I was worried that anyone trying to do "COMPILE_TEST" >> on your tree (or linuxnext

[PATCH v8 0/2] regulator: add QCOM RPMh regulator driver

2018-06-22 Thread David Collins
lkml/2018/6/8/573 [8]: https://lkml.org/lkml/2018/6/4/879 [9]: https://lkml.org/lkml/2018/6/1/895 [10]: https://lkml.org/lkml/2018/5/22/1168 [11]: https://lkml.org/lkml/2018/5/11/701 [12]: https://lkml.org/lkml/2018/4/13/687 [13]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: d

[PATCH v8 0/2] regulator: add QCOM RPMh regulator driver

2018-06-22 Thread David Collins
lkml/2018/6/8/573 [8]: https://lkml.org/lkml/2018/6/4/879 [9]: https://lkml.org/lkml/2018/6/1/895 [10]: https://lkml.org/lkml/2018/5/22/1168 [11]: https://lkml.org/lkml/2018/5/11/701 [12]: https://lkml.org/lkml/2018/4/13/687 [13]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: d

[PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-22 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh

[PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-22 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh

[PATCH v8 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-22 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

[PATCH v8 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-22 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-15 Thread David Collins
Hello Ulf, On 06/15/2018 02:25 AM, Ulf Hansson wrote: > On 14 June 2018 at 20:17, David Collins wrote: >> On 06/13/2018 11:54 PM, Rajendra Nayak wrote: >>> On 06/14/2018 06:02 AM, David Collins wrote: >>>> On 06/11/2018 09:40 PM, Rajendra Nayak wrote: >> ..

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-15 Thread David Collins
Hello Ulf, On 06/15/2018 02:25 AM, Ulf Hansson wrote: > On 14 June 2018 at 20:17, David Collins wrote: >> On 06/13/2018 11:54 PM, Rajendra Nayak wrote: >>> On 06/14/2018 06:02 AM, David Collins wrote: >>>> On 06/11/2018 09:40 PM, Rajendra Nayak wrote: >> ..

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-14 Thread David Collins
Hello Rajendra, On 06/13/2018 11:54 PM, Rajendra Nayak wrote: > On 06/14/2018 06:02 AM, David Collins wrote: >> On 06/11/2018 09:40 PM, Rajendra Nayak wrote: ... >>> +static int rpmhpd_power_off(struct generic_pm_domain *domain) >>> +{ >>> + struct

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-14 Thread David Collins
Hello Rajendra, On 06/13/2018 11:54 PM, Rajendra Nayak wrote: > On 06/14/2018 06:02 AM, David Collins wrote: >> On 06/11/2018 09:40 PM, Rajendra Nayak wrote: ... >>> +static int rpmhpd_power_off(struct generic_pm_domain *domain) >>> +{ >>> + struct

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > The RPMh Power domain driver aggregates the corner votes from various > consumers for the ARC resources and communicates it to RPMh. > > We also add data for all power domains on sdm845 SoC as part of the patch. > The driver can be

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > The RPMh Power domain driver aggregates the corner votes from various > consumers for the ARC resources and communicates it to RPMh. > > We also add data for all power domains on sdm845 SoC as part of the patch. > The driver can be

Re: [PATCH v3 7/7] soc: qcom: rpmpd/rpmhpd: Add a max vote on all corners at init

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > As we move from no clients/consumers in kernel voting on corners, > to *some* voting and some not voting, we might end up in a situation > where the clients which remove votes can adversly impact others s/adversly/adversely/ > who

Re: [PATCH v3 7/7] soc: qcom: rpmpd/rpmhpd: Add a max vote on all corners at init

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > As we move from no clients/consumers in kernel voting on corners, > to *some* voting and some not voting, we might end up in a situation > where the clients which remove votes can adversly impact others s/adversly/adversely/ > who

Re: [PATCH v3 5/7] dt-bindings: power: Add qcom rpmh power domain driver bindings

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > Add DT bindings to describe the rpmh powerdomains found on Qualcomm s/powerdomains/power domains/ > Technologies, Inc. SoCs. These power domains communicate a performance > state to RPMh, which then translates it into corresponding

Re: [PATCH v3 5/7] dt-bindings: power: Add qcom rpmh power domain driver bindings

2018-06-13 Thread David Collins
Hello Rajendra, On 06/11/2018 09:40 PM, Rajendra Nayak wrote: > Add DT bindings to describe the rpmh powerdomains found on Qualcomm s/powerdomains/power domains/ > Technologies, Inc. SoCs. These power domains communicate a performance > state to RPMh, which then translates it into corresponding

[PATCH v7 0/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
5/15/1005 [6]: https://lkml.org/lkml/2018/6/4/879 [7]: https://lkml.org/lkml/2018/6/1/895 [8]: https://lkml.org/lkml/2018/5/22/1168 [9]: https://lkml.org/lkml/2018/5/11/701 [10]: https://lkml.org/lkml/2018/4/13/687 [11]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add

[PATCH v7 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-08 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

[PATCH v7 0/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
5/15/1005 [6]: https://lkml.org/lkml/2018/6/4/879 [7]: https://lkml.org/lkml/2018/6/1/895 [8]: https://lkml.org/lkml/2018/5/22/1168 [9]: https://lkml.org/lkml/2018/5/11/701 [10]: https://lkml.org/lkml/2018/4/13/687 [11]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add

[PATCH v7 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-08 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196

[PATCH v7 2/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 753

[PATCH v7 2/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins Reviewed-by: Douglas Anderson --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 753

Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
Hello Matthias, On 06/07/2018 05:26 PM, Matthias Kaehlcke wrote: > On Mon, Jun 04, 2018 at 12:15:12PM -0700, David Collins wrote: >> static int rpmh_regulator_send_request(struct rpmh_vreg *vreg, >> + struct tcs_cmd *cmd, int count, bool wait_for_ack) >>

Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
Hello Matthias, On 06/07/2018 05:26 PM, Matthias Kaehlcke wrote: > On Mon, Jun 04, 2018 at 12:15:12PM -0700, David Collins wrote: >> static int rpmh_regulator_send_request(struct rpmh_vreg *vreg, >> + struct tcs_cmd *cmd, int count, bool wait_for_ack) >>

[PATCH v6 0/2] regulator: add QCOM RPMh regulator driver

2018-06-04 Thread David Collins
lkml.org/lkml/2018/5/11/701 [9]: https://lkml.org/lkml/2018/4/13/687 [10]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPMh regulator bindings regulator: add QCOM RPMh regulator driver .../bindings/regulator/qcom,rpmh-regulator.txt | 160

[PATCH v6 0/2] regulator: add QCOM RPMh regulator driver

2018-06-04 Thread David Collins
lkml.org/lkml/2018/5/11/701 [9]: https://lkml.org/lkml/2018/4/13/687 [10]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPMh regulator bindings regulator: add QCOM RPMh regulator driver .../bindings/regulator/qcom,rpmh-regulator.txt | 160

[PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-04 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 767 3 files

[PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-04 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 767 3 files

[PATCH v6 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-04 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196 insertions(+) create mode 100644

[PATCH v6 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-04 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins Reviewed-by: Rob Herring --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196 insertions(+) create mode 100644

[PATCH v5 2/2] regulator: add QCOM RPMh regulator driver

2018-06-01 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 770 3 files

[PATCH v5 2/2] regulator: add QCOM RPMh regulator driver

2018-06-01 Thread David Collins
of enable state, voltage, and mode. XOB supports manipulation of enable state. Signed-off-by: David Collins --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 770 3 files

[PATCH v5 0/2] regulator: add QCOM RPMh regulator driver

2018-06-01 Thread David Collins
lkml.org/lkml/2018/4/18/556 [4]: https://lkml.org/lkml/2018/5/11/696 [5]: https://lkml.org/lkml/2018/5/15/1005 [6]: https://lkml.org/lkml/2018/5/22/1168 [7]: https://lkml.org/lkml/2018/5/11/701 [8]: https://lkml.org/lkml/2018/4/13/687 [9]: https://lkml.org/lkml/2018/3/16/1431 David Collins

[PATCH v5 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-01 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v5 0/2] regulator: add QCOM RPMh regulator driver

2018-06-01 Thread David Collins
lkml.org/lkml/2018/4/18/556 [4]: https://lkml.org/lkml/2018/5/11/696 [5]: https://lkml.org/lkml/2018/5/15/1005 [6]: https://lkml.org/lkml/2018/5/22/1168 [7]: https://lkml.org/lkml/2018/5/11/701 [8]: https://lkml.org/lkml/2018/4/13/687 [9]: https://lkml.org/lkml/2018/3/16/1431 David Collins

[PATCH v5 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-01 Thread David Collins
the final PMIC regulator hardware state. Signed-off-by: David Collins --- .../bindings/regulator/qcom,rpmh-regulator.txt | 160 + .../dt-bindings/regulator/qcom,rpmh-regulator.h| 36 + 2 files changed, 196 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-01 Thread David Collins
Hello Mark, On 05/31/2018 04:48 AM, Mark Brown wrote: > On Wed, May 30, 2018 at 04:39:10PM -0700, David Collins wrote: >> The DRMS modes to use and max allowed current per mode need to be >> specified at the board level in device tree instead of hard-coded per >> regulat

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-06-01 Thread David Collins
Hello Mark, On 05/31/2018 04:48 AM, Mark Brown wrote: > On Wed, May 30, 2018 at 04:39:10PM -0700, David Collins wrote: >> The DRMS modes to use and max allowed current per mode need to be >> specified at the board level in device tree instead of hard-coded per >> regulat

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-01 Thread David Collins
Hello Rajendra, On 06/01/2018 01:48 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> >>> + [1] = _mx, >>> + [2] = _mx_ao, >>> + [3] = _cx, >>> + [4] = _cx_ao, >>> + [5] = _lmx, >

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-01 Thread David Collins
Hello Rajendra, On 06/01/2018 01:48 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> >>> + [1] = _mx, >>> + [2] = _mx_ao, >>> + [3] = _cx, >>> + [4] = _cx_ao, >>> + [5] = _lmx, >

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-05-30 Thread David Collins
Hi Doug, On 05/30/2018 05:34 PM, Doug Anderson wrote: > On Wed, May 30, 2018 at 4:39 PM, David Collins > wrote: >> Consider the case of a regulator with physical 10 mA LPM max current. Say >> that modem and application processors each have a load on the regulator

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-05-30 Thread David Collins
Hi Doug, On 05/30/2018 05:34 PM, Doug Anderson wrote: > On Wed, May 30, 2018 at 4:39 PM, David Collins > wrote: >> Consider the case of a regulator with physical 10 mA LPM max current. Say >> that modem and application processors each have a load on the regulator

Re: [PATCH v4 0/2] regulator: add QCOM RPMh regulator driver

2018-05-30 Thread David Collins
Hello Mark, On 05/30/2018 09:33 AM, Mark Brown wrote: > On Tue, May 22, 2018 at 07:43:16PM -0700, David Collins wrote: >> This patch series adds a driver and device tree binding documentation for >> PMIC regulator control via Resource Power Manager-hardened (RPMh) on some >>

Re: [PATCH v4 0/2] regulator: add QCOM RPMh regulator driver

2018-05-30 Thread David Collins
Hello Mark, On 05/30/2018 09:33 AM, Mark Brown wrote: > On Tue, May 22, 2018 at 07:43:16PM -0700, David Collins wrote: >> This patch series adds a driver and device tree binding documentation for >> PMIC regulator control via Resource Power Manager-hardened (RPMh) on some >>

Re: [PATCH v4 2/2] regulator: add QCOM RPMh regulator driver

2018-05-30 Thread David Collins
Hello Doug, On 05/29/2018 10:32 PM, Doug Anderson wrote: > On Tue, May 22, 2018 at 7:43 PM, David Collins > wrote: >> + * @ever_enabled: Boolean indicating that the regulator has >> been >> + * explicitly enabled

Re: [PATCH v4 2/2] regulator: add QCOM RPMh regulator driver

2018-05-30 Thread David Collins
Hello Doug, On 05/29/2018 10:32 PM, Doug Anderson wrote: > On Tue, May 22, 2018 at 7:43 PM, David Collins > wrote: >> + * @ever_enabled: Boolean indicating that the regulator has >> been >> + * explicitly enabled

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-05-30 Thread David Collins
Hello Mark and Doug, On 05/30/2018 09:24 AM, Doug Anderson wrote: > On Wed, May 30, 2018 at 9:20 AM, Mark Brown wrote: >> On Wed, May 30, 2018 at 09:12:25AM -0700, Doug Anderson wrote: >>> On Wed, May 30, 2018 at 8:50 AM, Mark Brown wrote: >> No, I'm saying that I don't know why that

Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-05-30 Thread David Collins
Hello Mark and Doug, On 05/30/2018 09:24 AM, Doug Anderson wrote: > On Wed, May 30, 2018 at 9:20 AM, Mark Brown wrote: >> On Wed, May 30, 2018 at 09:12:25AM -0700, Doug Anderson wrote: >>> On Wed, May 30, 2018 at 8:50 AM, Mark Brown wrote: >> No, I'm saying that I don't know why that

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread David Collins
Hello Rajendra, On 05/30/2018 03:14 AM, Rajendra Nayak wrote: > On 05/30/2018 02:47 PM, Ulf Hansson wrote: >> On 25 May 2018 at 12:01, Rajendra Nayak wrote: ... >>> + pm_genpd_init([i]->pd, NULL, true); >> >> Question: Is there no hierarchical topology of the PM domains. No >>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread David Collins
Hello Rajendra, On 05/30/2018 03:14 AM, Rajendra Nayak wrote: > On 05/30/2018 02:47 PM, Ulf Hansson wrote: >> On 25 May 2018 at 12:01, Rajendra Nayak wrote: ... >>> + pm_genpd_init([i]->pd, NULL, true); >> >> Question: Is there no hierarchical topology of the PM domains. No >>

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-29 Thread David Collins
Hello Rajendra, On 05/29/2018 03:19 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> On 05/25/2018 03:01 AM, Rajendra Nayak wrote: >>> The RPMh powerdomain driver aggregates the corner votes from various ... >>> diff --git a/drivers/soc/qcom

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-29 Thread David Collins
Hello Rajendra, On 05/29/2018 03:19 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> On 05/25/2018 03:01 AM, Rajendra Nayak wrote: >>> The RPMh powerdomain driver aggregates the corner votes from various ... >>> diff --git a/drivers/soc/qcom

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-25 Thread David Collins
Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: > The RPMh powerdomain driver aggregates the corner votes from various s/powerdomain/power domain/ This applies to all instances in this patch. "Power domain" seems to be the preferred spelling in the kernel. > consumers for the

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-25 Thread David Collins
Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: > The RPMh powerdomain driver aggregates the corner votes from various s/powerdomain/power domain/ This applies to all instances in this patch. "Power domain" seems to be the preferred spelling in the kernel. > consumers for the

Re: [PATCH v2 2/6] dt-bindings: opp: Introduce qcom-opp bindings

2018-05-25 Thread David Collins
Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: > On Qualcomm platforms, an OPP node needs to describe an s/Qualcomm/Qualcomm Technologies, Inc./ > additional level/corner value that is then communicated to > a remote microprocessor by the CPU, which then takes some > actions

Re: [PATCH v2 2/6] dt-bindings: opp: Introduce qcom-opp bindings

2018-05-25 Thread David Collins
Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: > On Qualcomm platforms, an OPP node needs to describe an s/Qualcomm/Qualcomm Technologies, Inc./ > additional level/corner value that is then communicated to > a remote microprocessor by the CPU, which then takes some > actions

[PATCH v4 0/2] regulator: add QCOM RPMh regulator driver

2018-05-22 Thread David Collins
ttps://lkml.org/lkml/2018/4/18/556 [4]: https://lkml.org/lkml/2018/5/11/696 [5]: https://lkml.org/lkml/2018/5/15/1005 [6]: https://lkml.org/lkml/2018/5/11/701 [7]: https://lkml.org/lkml/2018/4/13/687 [8]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPM

  1   2   >