Re: [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler

2018-09-10 Thread David Frey
On 9/8/2018 7:17 AM, Jonathan Cameron wrote: > On Sat, 8 Sep 2018 17:59:13 +0530 > Himanshu Jha wrote: > >> On Sat, Sep 08, 2018 at 06:57:36PM +0800, zhong jiang wrote: >>> The iterator in for_each_set_bit is never null, therefore, remove >>> the redundant conditional judgment. >>> >>>

Re: [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler

2018-09-10 Thread David Frey
On 9/8/2018 7:17 AM, Jonathan Cameron wrote: > On Sat, 8 Sep 2018 17:59:13 +0530 > Himanshu Jha wrote: > >> On Sat, Sep 08, 2018 at 06:57:36PM +0800, zhong jiang wrote: >>> The iterator in for_each_set_bit is never null, therefore, remove >>> the redundant conditional judgment. >>> >>>

[PATCH v2 2/2] regmap: split up regmap_config.use_single_rw

2018-09-01 Thread David Frey
necessary. Update all struct regmap_config instances where use_single_rw==true to instead set both use_single_read and use_single_write. No attempt was made to evaluate whether it is possible to set only one of use_single_read or use_single_write. Signed-off-by: David Frey --- drivers/base/regmap

[PATCH v2 1/2] regmap: fix comment for regmap.use_single_write

2018-09-01 Thread David Frey
Signed-off-by: David Frey --- drivers/base/regmap/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index a6bf34d6394e..16414ccace96 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap

regmap: split regmap_config.use_single_rw

2018-09-01 Thread David Frey
will be happy. David Frey (2): regmap: fix comment for regmap.use_single_write regmap: split up regmap_config.use_single_rw drivers/base/regmap/internal.h | 2 +- drivers/base/regmap/regmap.c | 4 ++-- drivers/edac/altera_edac.c | 3 ++- drivers/hwmon

[PATCH v2 2/2] regmap: split up regmap_config.use_single_rw

2018-09-01 Thread David Frey
necessary. Update all struct regmap_config instances where use_single_rw==true to instead set both use_single_read and use_single_write. No attempt was made to evaluate whether it is possible to set only one of use_single_read or use_single_write. Signed-off-by: David Frey --- drivers/base/regmap

[PATCH v2 1/2] regmap: fix comment for regmap.use_single_write

2018-09-01 Thread David Frey
Signed-off-by: David Frey --- drivers/base/regmap/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index a6bf34d6394e..16414ccace96 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap

regmap: split regmap_config.use_single_rw

2018-09-01 Thread David Frey
will be happy. David Frey (2): regmap: fix comment for regmap.use_single_write regmap: split up regmap_config.use_single_rw drivers/base/regmap/internal.h | 2 +- drivers/base/regmap/regmap.c | 4 ++-- drivers/edac/altera_edac.c | 3 ++- drivers/hwmon

[PATCH 0/3] regmap: split regmap_config.use_single_rw

2018-08-31 Thread David Frey
if this is the preferred method or if it's better to combine those patches. David Frey (3): regmap: fix comment for regmap.use_single_write regmap: split up regmap_config.use_single_rw regmap: update users of regmap_config.use_single_rw drivers/base/regmap/internal.h | 2 +- drivers/base/regmap

[PATCH 1/3] regmap: fix comment for regmap.use_single_write

2018-08-31 Thread David Frey
Signed-off-by: David Frey --- drivers/base/regmap/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index a6bf34d6394e..16414ccace96 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap

[PATCH 2/3] regmap: split up regmap_config.use_single_rw

2018-08-31 Thread David Frey
necessary. Signed-off-by: David Frey --- drivers/base/regmap/regmap.c | 4 ++-- include/linux/regmap.h | 12 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 0360a90ad6b6..78a778c08f92 100644

[PATCH 3/3] regmap: update users of regmap_config.use_single_rw

2018-08-31 Thread David Frey
Update all struct regmap_config instances where the use_single_rw member was set to instead set both use_single_read and use_single_write. No attempt was made to evaluate whether it is possible to set only one of use_single_read or use_single_write. Signed-off-by: David Frey --- drivers/edac

[PATCH 0/3] regmap: split regmap_config.use_single_rw

2018-08-31 Thread David Frey
if this is the preferred method or if it's better to combine those patches. David Frey (3): regmap: fix comment for regmap.use_single_write regmap: split up regmap_config.use_single_rw regmap: update users of regmap_config.use_single_rw drivers/base/regmap/internal.h | 2 +- drivers/base/regmap

[PATCH 1/3] regmap: fix comment for regmap.use_single_write

2018-08-31 Thread David Frey
Signed-off-by: David Frey --- drivers/base/regmap/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index a6bf34d6394e..16414ccace96 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap

[PATCH 2/3] regmap: split up regmap_config.use_single_rw

2018-08-31 Thread David Frey
necessary. Signed-off-by: David Frey --- drivers/base/regmap/regmap.c | 4 ++-- include/linux/regmap.h | 12 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 0360a90ad6b6..78a778c08f92 100644

[PATCH 3/3] regmap: update users of regmap_config.use_single_rw

2018-08-31 Thread David Frey
Update all struct regmap_config instances where the use_single_rw member was set to instead set both use_single_read and use_single_write. No attempt was made to evaluate whether it is possible to set only one of use_single_read or use_single_write. Signed-off-by: David Frey --- drivers/edac

Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor

2018-07-23 Thread David Frey
ed and nothing else changes, unlike if it had been pressure, temperature, humidity. The IAQ implementation is userspace application suggesting good/bad/ugly air quality. And since we know David Frey is planning to use this sensor in his product mangOH board. So, David, how are you planning to use t

Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor

2018-07-23 Thread David Frey
ed and nothing else changes, unlike if it had been pressure, temperature, humidity. The IAQ implementation is userspace application suggesting good/bad/ugly air quality. And since we know David Frey is planning to use this sensor in his product mangOH board. So, David, how are you planning to use t

Re: [PATCH v3] iio: chemical: Add support for Bosch BME680 sensor

2018-07-13 Thread David Frey
Hi Himanshu Jha, First a bit of background. I'm working on a device which will contain a bme680 sensor. A colleague of mine started work on a Linux kernel driver for the chip a little while ago. The (WIP) driver can be found here:

Re: [PATCH v3] iio: chemical: Add support for Bosch BME680 sensor

2018-07-13 Thread David Frey
Hi Himanshu Jha, First a bit of background. I'm working on a device which will contain a bme680 sensor. A colleague of mine started work on a Linux kernel driver for the chip a little while ago. The (WIP) driver can be found here:

Seeking guidance on spelling fixes

2018-02-18 Thread David Frey
merged at this point. I'm trying to get a feel for whether I should keep working on this. Thanks, David Frey

Seeking guidance on spelling fixes

2018-02-18 Thread David Frey
merged at this point. I'm trying to get a feel for whether I should keep working on this. Thanks, David Frey