Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-08 Thread David Miller
From: Zhang Changzhong Date: Tue, 8 Dec 2020 09:53:42 +0800 > platform_get_resource() may fail and in this case a NULL dereference > will occur. > > Fix it to use devm_platform_ioremap_resource() instead of calling > platform_get_resource() and devm_ioremap(). > > This is detected by

Re: [PATCH] net: sched: fix spelling mistake in Kconfig "trys" -> "tries"

2020-12-08 Thread David Miller
From: Colin King Date: Mon, 7 Dec 2020 16:12:31 + > From: Colin Ian King > > There is a spelling mistake in the Kconfig help text. Fix it. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH] net: tipc: prevent possible null deref of link

2020-12-08 Thread David Miller
From: Cengiz Can Date: Mon, 7 Dec 2020 11:14:24 +0300 > `tipc_node_apply_property` does a null check on a `tipc_link_entry` > pointer but also accesses the same pointer out of the null check block. > > This triggers a warning on Coverity Static Analyzer because we're > implying that `e->link`

Re: [PATCH net] net: hns3: remove a misused pragma packed

2020-12-06 Thread David Miller
From: Huazhong Tan Date: Mon, 7 Dec 2020 15:20:25 +0800 > hclge_dbg_reg_info[] is defined as an array of packed structure > accidentally. However, this array contains pointers, which are > no longer aligned naturally, and cannot be relocated on PPC64. > Hence, when compile-testing this driver on

Re: [PATCH net 0/6] rxrpc: Miscellaneous fixes

2020-10-06 Thread David Miller
From: David Howells Date: Mon, 05 Oct 2020 17:18:44 +0100 > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20201005.txt I think the ".txt" at the end of the branch name is a mistake. It's really hard to send a

Re: [PATCH v4] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-06 Thread David Miller
From: Anant Thazhemadam Date: Mon, 5 Oct 2020 18:59:58 +0530 > When get_registers() fails in set_ethernet_addr(),the uninitialized > value of node_id gets copied over as the address. > So, check the return value of get_registers(). > > If get_registers() executed successfully (i.e., it returns

Re: [PATCH v3] net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()

2020-10-06 Thread David Miller
From: Manivannan Sadhasivam Date: Mon, 5 Oct 2020 12:46:42 +0530 > The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API > since it has the lock_sock() in qrtr_sendmsg() which will sleep. Hence, > fix it by excluding the locking for kernel_sendmsg(). > > While at it, let's also

Re: linux tooling mailing list

2020-10-05 Thread David Miller
From: Nick Desaulniers Date: Mon, 5 Oct 2020 10:50:35 -0700 > Now that the lore archive has been set up > (https://lore.kernel.org/linux-toolchains/), would you mind linking to > it from http://vger.kernel.org/vger-lists.html under archives of > linux-toolchains? Done.

Re: [PATCH] net: phy: marvell: Use phy_read_paged() instead of open coding it

2020-10-05 Thread David Miller
From: Jisheng Zhang Date: Mon, 5 Oct 2020 17:19:50 +0800 > Convert m88e1318_get_wol() to use the well implemented phy_read_paged() > instead of open coding it. > > Signed-off-by: Jisheng Zhang Applied, thanks!

[GIT] Networking

2020-10-04 Thread David Miller
1) Make sure SKB control block is in the proper state during IPSEC ESP-in-TCP encapsulation. From Sabrina Dubroca. 2) Various kinds of attributes were not being cloned properly when we build new xfrm_state objects from existing ones. Fix from Antony Antony. 3) Make sure to keep BTF

Re: [PATCH net-next v2 0/2] net: Constify struct genl_small_ops

2020-10-04 Thread David Miller
From: Rikard Falkeborn Date: Mon, 5 Oct 2020 01:44:15 +0200 > Make a couple of static struct genl_small_ops const to allow the compiler > to put them in read-only memory. Patches are independent. > > v2: Rebase on net-next, genl_ops -> genl_small_ops Applied, thank you.

Re: [PATCH net] drivers/net/wan: lapb: Replace the skb->len checks with pskb_may_pull

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 17:46:19 -0700 > The purpose of these skb->len checks in these drivers is to ensure that > there is a header in the skb available to be read and pulled. > > However, we already have the pskb_may_pull function for this purpose. > > The pskb_may_pull function

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 15:41:05 -0700 > 1. Keep the code for the normal (non-error) flow at the lowest > indentation level. And use "goto drop" for all error handling. > > 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. > > 3. Change "dev_kfree_skb" to

Re: [PATCH] net: mvneta: fix double free of txq->buf

2020-10-04 Thread David Miller
From: t...@redhat.com Date: Sat, 3 Oct 2020 11:51:21 -0700 > From: Tom Rix > > clang static analysis reports this problem: > > drivers/net/ethernet/marvell/mvneta.c:3465:2: warning: > Attempt to free released memory > kfree(txq->buf); > ^~~ > > When

Re: [PATCH net-next 0/2] net: Constify struct genl_ops

2020-10-04 Thread David Miller
From: Rikard Falkeborn Date: Sun, 4 Oct 2020 23:58:08 +0200 > Make a couple of static struct genl_ops const to allow the compiler to put > them in read-only memory. Patches are independent. These do not apply cleanly to net-next, please respin.

Re: [PATCH] net: team: fix memory leak in __team_options_register

2020-10-04 Thread David Miller
From: Anant Thazhemadam Date: Mon, 5 Oct 2020 02:25:36 +0530 > The variable "i" isn't initialized back correctly after the first loop > under the label inst_rollback gets executed. > > The value of "i" is assigned to be option_count - 1, and the ensuing > loop (under alloc_rollback) begins by

Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

2020-10-03 Thread David Miller
From: Matthieu Baerts Date: Sat, 3 Oct 2020 17:36:56 +0200 > The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is > smaller than the one initially sent without echo-flag=1. We then need to > use the correct size everywhere when we need this echo bit. > > Before this patch,

Re: [PATCH][next] bnx2x: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:26:11 -0500 > Replace /* no break */ comments with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > >

Re: [PATCH][next] usbnet: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 17:53:15 -0500 > Replace // FALLTHROUGH comment with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > >

Re: [PATCH][next] net: bna: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:00:01 -0500 > Replace /* !!! fall through !!! */ comments with the new pseudo-keyword > macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > >

Re: [PATCH][next] net: ksz884x: Use fallthrough pseudo-keyword

2020-10-03 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 2 Oct 2020 18:02:59 -0500 > Replace /* Fallthrough... */ comment with the new pseudo-keyword macro > fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > >

Re: [PATCH] net: typhoon: Fix a typo Typoon --> Typhoon

2020-10-03 Thread David Miller
From: Christophe JAILLET Date: Fri, 2 Oct 2020 21:47:43 +0200 > s/Typoon/Typhoon/ > > Signed-off-by: Christophe JAILLET Applied, thank you.

Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-03 Thread David Miller
From: Colin King Date: Fri, 2 Oct 2020 17:54:22 +0100 > From: Colin Ian King > > Currently the comparisons of u16 integers value and sopass_val with > less than zero for error checking is always false because the values > are unsigned. Fix this by making these variables int. This does not >

Re: [PATCH v4 net-next 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-03 Thread David Miller
From: Vladimir Oltean Date: Fri, 2 Oct 2020 16:41:04 +0300 > Seville is a DSA switch that is embedded inside the T1040 SoC, and > supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. > > This series adds this switch to the SoC's dtsi files and to the T1040RDB > board file. >

Re: [PATCH v2] net: hso: do not call unregister if not registered

2020-10-03 Thread David Miller
From: Greg KH Date: Fri, 2 Oct 2020 13:43:23 +0200 > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device > *hso_dev, bool bailout) > > remove_net_device(hso_net->parent); > > - if (hso_net->net) > + if (hso_net->net && > + hso_net->net->reg_state ==

Re: [PATCH v2 net] net: stmmac: Modify configuration method of EEE timers

2020-10-03 Thread David Miller
From: Voon Weifeng Date: Thu, 1 Oct 2020 23:56:09 +0800 > From: "Vineetha G. Jaya Kumaran" > > Ethtool manual stated that the tx-timer is the "the amount of time the > device should stay in idle mode prior to asserting its Tx LPI". The > previous implementation for "ethtool --set-eee

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Miller
From: David Howells Date: Sat, 03 Oct 2020 22:24:55 +0100 > David Miller wrote: > >> > Since the fixes in the set need to go after the patches in net-next, >> > should I >> > resubmit just those for net-next, or sit on them till -rc1? >> >&g

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-03 Thread David Miller
From: David Howells Date: Sat, 03 Oct 2020 21:01:49 +0100 > Since the fixes in the set need to go after the patches in net-next, should I > resubmit just those for net-next, or sit on them till -rc1? My 'net' tree is always open for bug fixes, and that's where bug fixes belong. Not 'net-next'.

Re: [PATCH net-next 7/8] net: ethernet: ti: am65-cpsw: prepare xmit/rx path for multi-port devices in mac-only mode

2020-10-02 Thread David Miller
From: Grygorii Strashko Date: Thu, 1 Oct 2020 13:52:57 +0300 > This patch adds multi-port support to TI AM65x CPSW driver xmit/rx path in > preparation for adding support for multi-port devices, like Main CPSW0 on > K3 J721E SoC or future CPSW3g on K3 AM64x SoC. > Hence DMA channels are

Re: [Linux-kernel-mentees][PATCH 0/2] reorder members of structures in virtio_net for optimization

2020-10-02 Thread David Miller
From: Anant Thazhemadam Date: Wed, 30 Sep 2020 10:47:20 +0530 > The structures virtnet_info and receive_queue have byte holes in > middle, and their members could do with some rearranging > (order-of-declaration wise) in order to overcome this. > > Rearranging the members helps in: > *

Re: [PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

2020-10-02 Thread David Miller
From: David Howells Date: Thu, 01 Oct 2020 15:56:43 +0100 > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-next-20201010 No, they aren't. git pull --no-ff

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread David Miller
From: Jarod Wilson Date: Fri, 2 Oct 2020 16:23:46 -0400 > I'd had a bit of feedback that people would rather see both, and be > able to toggle off the old ones, rather than only having one or the > other, depending on the toggle, so I thought I'd give this a try. I > kind of liked the one or the

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread David Miller
From: Jarod Wilson Date: Fri, 2 Oct 2020 16:12:49 -0400 > The documentation was updated to point to the new names, but the old > ones still exist across the board, there should be no userspace > breakage here. (My lnst bonding tests actually fall flat currently > if the old names are gone). The

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread David Miller
From: Stephen Hemminger Date: Fri, 2 Oct 2020 12:13:17 -0700 > On Fri, 2 Oct 2020 13:40:01 -0400 > Jarod Wilson wrote: > >> By default, enable retaining all user-facing API that includes the use of >> master and slave, but add a Kconfig knob that allows those that wish to >> remove it

Re: [PATCH 1/2] sparc32: Move ioremap/iounmap declaration before asm-generic/io.h include

2020-10-02 Thread David Miller
From: Lorenzo Pieralisi Date: Fri, 2 Oct 2020 15:50:29 +0100 > On Tue, Sep 15, 2020 at 01:11:21PM -0700, David Miller wrote: >> From: Lorenzo Pieralisi >> Date: Tue, 15 Sep 2020 10:32:02 +0100 >> >> > Move the ioremap/iounmap declaration before asm-ge

Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-02 Thread David Miller
From: Anant Thazhemadam Date: Fri, 2 Oct 2020 17:04:13 +0530 > But this patch is about ensuring that an uninitialized variable's > value (whatever that may be) is not set as the ethernet address > blindly (without any form of checking if get_registers() worked > as expected, or not). Right, and

Re: [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-02 Thread David Miller
From: Coly Li Date: Fri, 2 Oct 2020 16:30:12 +0800 > Obviously my fault and no excuse for leaking this uncompleted version to > you. I just re-post a v10 version which I make sure all patches are the > latest version. > > Sorry for the inconvenience and thank you in advance for taking this set.

Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-02 Thread David Miller
From: Coly Li Date: Fri, 2 Oct 2020 16:27:27 +0800 > As Sagi Grimberg suggested, the original fix is refind to a more common > inline routine: > static inline bool sendpage_ok(struct page *page) > { > return (!PageSlab(page) && page_count(page) >= 1); > } > If sendpage_ok()

Re: Why ping latency is smaller with shorter send interval?

2020-10-02 Thread David Miller
Can you please not send the same posting to the mailing list three times, from three different email addresses? Once is enough, thank you.

Re: [PATCH 1/6] net: core: document two new elements of struct net_device

2020-10-02 Thread David Miller
From: Mauro Carvalho Chehab Date: Fri, 2 Oct 2020 07:49:45 +0200 > As warned by "make htmldocs", there are two new struct elements > that aren't documented: > > ../include/linux/netdevice.h:2159: warning: Function parameter or > member 'unlink_list' not described in 'net_device' >

Re: [PATCH net-next 0/4] net: dsa: Improve dsa_untag_bridge_pvid()

2020-10-02 Thread David Miller
From: Florian Fainelli Date: Thu, 1 Oct 2020 19:42:11 -0700 > Hi David, Jakub, > > This patch series is based on the recent discussions with Vladimir: > > https://lore.kernel.org/netdev/20201001030623.343535-1-f.faine...@gmail.com/ > > the simplest way forward was to call

Re: [Linux-kernel-mentees][PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

2020-10-01 Thread David Miller
From: Anant Thazhemadam Date: Thu, 1 Oct 2020 13:02:20 +0530 > When get_registers() fails (which happens when usb_control_msg() fails) > in set_ethernet_addr(), the uninitialized value of node_id gets copied > as the address. > > Checking for the return values appropriately, and handling the

Re: [PATCH net v1] net: phy: realtek: Modify 2.5G PHY name to RTL8226

2020-10-01 Thread David Miller
From: Willy Liu Date: Wed, 30 Sep 2020 14:48:58 +0800 > Realtek single-chip Ethernet PHY solutions can be separated as below: > 10M/100Mbps: RTL8201X > 1Gbps: RTL8211X > 2.5Gbps: RTL8226/RTL8221X > RTL8226 is the first version for realtek that compatible 2.5Gbps single PHY. > Since RTL8226 is

Re: [PATCH] caif_virtio: Remove redundant initialization of variable err

2020-10-01 Thread David Miller
From: Jing Xiangfeng Date: Wed, 30 Sep 2020 09:29:54 +0800 > After commit a8c7687bf216 ("caif_virtio: Check that vringh_config is not > null"), the variable err is being initialized with '-EINVAL' that is > meaningless. So remove it. > > Signed-off-by: Jing Xiangfeng Applied to net-next.

Re: linux-next: build failure after merge of the net-next tree

2020-10-01 Thread David Miller
From: Stephen Rothwell Date: Tue, 29 Sep 2020 13:04:46 +1000 > Caused by commit > > eff7423365a6 ("net: core: introduce struct netdev_nested_priv for nested > interface infrastructure") > > interacting with commit > > e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Correctly handle special skb->protocol values

2020-10-01 Thread David Miller
From: Xie He Date: Mon, 28 Sep 2020 05:56:43 -0700 > The fr_hard_header function is used to prepend the header to skbs before > transmission. It is used in 3 situations: > 1) When a control packet is generated internally in this driver; > 2) When a user sends an skb on an Ethernet-emulating PVC

Re: [PATCH v3 devicetree 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-01 Thread David Miller
From: Vladimir Oltean Date: Thu, 1 Oct 2020 16:20:11 +0300 > Seville is a DSA switch that is embedded inside the T1040 SoC, and > supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. > > This series adds this switch to the SoC's dtsi files and to the T1040RDB > board file.

Re: [PATCH net-next v4 resend 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-10-01 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 1 Oct 2020 12:10:03 +0200 > Some Renesas EtherAVB variants support internal clock delay > configuration, which can add larger delays than the delays that are > typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or > "[rt]xc-skew-ps"

Re: [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-01 Thread David Miller
From: David Miller Date: Thu, 01 Oct 2020 12:43:45 -0700 (PDT) > Series applied and queued up for -stable, thank you. Actually, this doesn't even build: In file included from ./arch/x86/include/asm/bug.h:93, from ./include/linux/bug.h:5, from ./include/li

Re: [PATCH v9 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-10-01 Thread David Miller
From: Coly Li Date: Thu, 1 Oct 2020 15:54:01 +0800 > This series was original by a bug fix in nvme-over-tcp driver which only > checked whether a page was allocated from slab allcoator, but forgot to > check its page_count: The page handled by sendpage should be neither a > Slab page nor 0

Re: linux tooling mailing list

2020-09-30 Thread David Miller
From: Nick Desaulniers Date: Wed, 30 Sep 2020 12:29:38 -0700 > linux-toolcha...@vger.kernel.org Created.

Re: [net PATCH v2 0/4] Fix bugs in Octeontx2 netdev driver

2020-09-30 Thread David Miller
From: Geetha sowjanya Date: Wed, 30 Sep 2020 21:38:10 +0530 > In existing Octeontx2 network drivers code has issues > like stale entries in broadcast replication list, missing > L3TYPE for IPv6 frames, running tx queues on error and > race condition in mbox reset. > This patch set fixes the

Re: [net-next PATCH v1 7/7] net/fsl: Use _ADR ACPI object to register PHYs

2020-09-30 Thread David Miller
From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:30 +0530 > @@ -248,6 +250,10 @@ static int xgmac_mdio_probe(struct platform_device *pdev) > struct resource *res; > struct mdio_fsl_priv *priv; > int ret; > + struct fwnode_handle *fwnode; > + struct fwnode_handle

Re: [net-next PATCH v1 4/7] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2020-09-30 Thread David Miller
From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:27 +0530 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -106,6 +106,46 @@ int mdiobus_unregister_device(struct mdio_device > *mdiodev) > } > EXPORT_SYMBOL(mdiobus_unregister_device); > > +int

Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions

2020-09-30 Thread David Miller
From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:25 +0530 > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > +{ > + struct device *d; > + struct mdio_device *mdiodev; Please use reverse christmas tree ordering for local variables.

Re: [PATCH v4 25/52] docs: net: ieee802154.rst: fix C expressions

2020-09-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Wed, 30 Sep 2020 15:24:48 +0200 > There are some warnings produced with Sphinx 3.x: > > Documentation/networking/ieee802154.rst:29: WARNING: Error in > declarator or parameters > Invalid C declaration: Expecting "(" in parameters. [error at 7] >

Re: [PATCH v4 33/52] docs: net: statistics.rst: remove a duplicated kernel-doc

2020-09-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Wed, 30 Sep 2020 15:24:56 +0200 > include/linux/ethtool.h is included twice with kernel-doc, > both to document ethtool_pause_stats(). The first one is > at statistics.rst, and the second one at ethtool-netlink.rst. > > Replace one of the references to use the

Re: [PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-09-30 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 30 Sep 2020 14:21:30 +0200 > Is there anything still blocking this series? If it's not active in networking patchwork, it needs to be resubmitted or similar.

Re: [PATCH net-next] net: macb: move pdata to private header

2020-09-30 Thread David Miller
From: Alexandre Belloni Date: Wed, 30 Sep 2020 12:50:59 +0200 > struct macb_platform_data is only used by macb_pci to register the platform > device, move its definition to cadence/macb.h and remove platform_data/macb.h > > Signed-off-by: Alexandre Belloni Applied, thank you.

Re: [patch V2 00/36] net: in_interrupt() cleanup and fixes

2020-09-29 Thread David Miller
From: Thomas Gleixner Date: Tue, 29 Sep 2020 22:25:09 +0200 > in the discussion about preempt count consistency accross kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/ > > Linus clearly requested that code in drivers and libraries which changes

Re: [PATCH][next] fddi/skfp: Avoid the use of one-element array

2020-09-29 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 29 Sep 2020 08:27:51 -0500 > One-element arrays are being deprecated[1]. Replace the one-element array > with a simple object of type u_char: 'u_char rm_pad1'[2], once it seems > this is just a placeholder for padding. > > [1] >

Re: [PATCH net-next 0/7] net: hns3: updates for -next

2020-09-29 Thread David Miller
From: Huazhong Tan Date: Tue, 29 Sep 2020 17:31:58 +0800 > There are some misc updates for the HNS3 ethernet driver. > #1 uses the queried BD number as the limit for TSO. > #2 renames trace event hns3_over_8bd since #1. > #3 adds UDP segmentation offload support. > #4 adds RoCE VF reset support.

Re: [PATCH net v4] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-29 Thread David Miller
From: Willy Liu Date: Tue, 29 Sep 2020 10:10:49 +0800 > There are two chip pins named TXDLY and RXDLY which actually adds the 2ns > delays to TXC and RXC for TXD/RXD latching. These two pins can config via > 4.7k-ohm resistor to 3.3V hw setting, but also config via software setting > (extension

Re: [PATCH][next] net/sched: cls_u32: Replace one-element array with flexible-array member

2020-09-28 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 28 Sep 2020 10:30:52 -0500 > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older >

Re: [PATCH][next] qed/qed_ll2: Replace one-element array with flexible-array member

2020-09-28 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 28 Sep 2020 10:16:17 -0500 > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older >

Re: [PATCH v1 net-next] stmmac: intel: Adding ref clock 1us tic for LPI cntr

2020-09-28 Thread David Miller
From: Voon Weifeng Date: Mon, 28 Sep 2020 18:12:12 +0800 > From: Rusaimi Amira Ruslan > > Adding reference clock (1us tic) for all LPI timer on Intel platforms. > The reference clock is derived from ptp clk. This also enables all LPI > counter. > > Signed-off-by: Rusaimi Amira Ruslan >

Re: [PATCH] net/x25: Fix null-ptr-deref in x25_connect

2020-09-28 Thread David Miller
From: Martin Schiller Date: Mon, 28 Sep 2020 11:23:27 +0200 > diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c > index 0bbb283f23c9..0524a5530b91 100644 > --- a/net/x25/af_x25.c > +++ b/net/x25/af_x25.c > @@ -820,7 +820,7 @@ static int x25_connect(struct socket *sock, struct > sockaddr *uaddr,

Re: [PATCH] net: usb: ax88179_178a: add MCT usb 3.0 adapter

2020-09-28 Thread David Miller
From: Wilken Gottwalt Date: Mon, 28 Sep 2020 11:17:40 +0200 > Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB > 3.0 ethernet adapter. > > Signed-off-by: Wilken Gottwalt Applied.

Re: [PATCH v2] net: usb: ax88179_178a: fix missing stop entry in driver_info

2020-09-28 Thread David Miller
From: Wilken Gottwalt Date: Mon, 28 Sep 2020 11:01:04 +0200 > Adds the missing .stop entry in the Belkin driver_info structure. > > Signed-off-by: Wilken Gottwalt > --- > Changes in v2: > - reposted to proper mailing list Applied and queued up for -stable, please provide a proper Fixes:

Re: [PATCH net-next 00/10] net: ipa: miscellaneous cleanups

2020-09-28 Thread David Miller
From: Alex Elder Date: Mon, 28 Sep 2020 18:04:36 -0500 > This series contains some minor cleanups I've been meaning to get > around to for a while. The first few remove the definitions of some > currently-unused symbols. Several fix some warnings that are reported > when the build is done with

Re: [PATCH] net: Use kobj_to_dev() API

2020-09-28 Thread David Miller
From: Wang Qing Date: Sat, 26 Sep 2020 14:49:18 +0800 > Use kobj_to_dev() instead of container_of(). > > Signed-off-by: Wang Qing Applied to net-next, thank you.

Re: [PATCH] fs: remove ->sendpage

2020-09-28 Thread David Miller
From: Christoph Hellwig Date: Sat, 26 Sep 2020 09:00:49 +0200 > ->sendpage is only called from generic_splice_sendpage. The only user of > generic_splice_sendpage is socket_file_ops, which is also the only > instance that actually implements ->sendpage. Remove the ->sendpage file > operation

Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even when netif is down

2020-09-28 Thread David Miller
From: Xie He Date: Sat, 26 Sep 2020 13:56:10 -0700 > @@ -265,7 +269,9 @@ static void x25_asy_write_wakeup(struct tty_struct *tty) >* transmission of another packet */ > sl->dev->stats.tx_packets++; > clear_bit(TTY_DO_WRITE_WAKEUP, >flags); > -

Re: [PATCH] net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks

2020-09-28 Thread David Miller
From: Manivannan Sadhasivam Date: Sat, 26 Sep 2020 22:26:25 +0530 > The rcu read locks are needed to avoid potential race condition while > dereferencing radix tree from multiple threads. The issue was identified > by syzbot. Below is the crash report: ... > Fixes: 0c2204a4ad71 ("net: qrtr:

Re: [PATCH] atm: atmtcp: Constify atmtcp_v_dev_ops

2020-09-28 Thread David Miller
From: Rikard Falkeborn Date: Sun, 27 Sep 2020 23:10:42 +0200 > The only usage of atmtcp_v_dev_ops is to pass its address to > atm_dev_register() which takes a pointer to const, and comparing its > address to another address, which does not modify it. Make it const to > allow the compiler to put

Re: [RESEND PATCH net-next v5 0/2] DP83869 WoL and Speed optimization

2020-09-28 Thread David Miller
From: Dan Murphy Date: Mon, 28 Sep 2020 09:51:33 -0500 > Add the WoL and Speed Optimization (aka downshift) support for the DP83869 > Ethernet PHY. Series applied.

Re: [PATCH net-next v5 1/2] net: phy: dp83869: support Wake on LAN

2020-09-28 Thread David Miller
From: Dan Murphy Date: Mon, 28 Sep 2020 09:47:24 -0500 > Hello > > On 9/28/20 9:46 AM, Dan Murphy wrote: >> This adds WoL support on TI DP83869 for magic, magic secure, unicast >> and >> broadcast. >> >> Signed-off-by: Dan Murphy >> --- >> >> v5 - Fixed 0-day warning for u16 >> >>

Re: [PATCH net] net: ethernet: ave: Replace alloc_etherdev() with devm_alloc_etherdev()

2020-09-28 Thread David Miller
From: Kunihiko Hayashi Date: Mon, 28 Sep 2020 19:04:53 +0900 > Use devm_alloc_etherdev() to simplify the code instead of alloc_etherdev(). > > Signed-off-by: Kunihiko Hayashi Applied to net-next, thanks.

Re: [PATCH v1 net] net: stmmac: Modify configuration method of EEE timers

2020-09-28 Thread David Miller
From: Voon Weifeng Date: Mon, 28 Sep 2020 18:02:41 +0800 > @@ -90,11 +90,12 @@ static const u32 default_msg_level = (NETIF_MSG_DRV | > NETIF_MSG_PROBE | > NETIF_MSG_LINK | NETIF_MSG_IFUP | > NETIF_MSG_IFDOWN |

Re: [PATCH net-next] net: vlan: Fixed signedness in vlan_group_prealloc_vid()

2020-09-28 Thread David Miller
From: Florian Fainelli Date: Sun, 27 Sep 2020 19:31:50 -0700 > After commit d0186842ec5f ("net: vlan: Avoid using BUG() in > vlan_proto_idx()"), vlan_proto_idx() was changed to return a signed > integer, however one of its called: vlan_group_prealloc_vid() was still > using an unsigned integer

Re: [patch 00/35] net: in_interrupt() cleanup and fixes

2020-09-27 Thread David Miller
From: Thomas Gleixner Date: Sun, 27 Sep 2020 21:48:46 +0200 > in the discussion about preempt count consistency accross kernel > configurations: Please respin this against net-next, some of the patches in here are already in net-next (the wireless debug macro one) and even after that the

Re: [RESEND PATCH] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-09-27 Thread David Miller
From: Lad Prabhakar Date: Sun, 27 Sep 2020 13:34:39 +0100 > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > Reviewed-by: Sergei Shtylyov > Reviewed-by: Geert Uytterhoeven > Acked-by:

Re: [PATCH] ptp: add stub function for ptp_get_msgtype()

2020-09-27 Thread David Miller
From: Yangbo Lu Date: Sun, 27 Sep 2020 16:01:50 +0800 > Added the missing stub function for ptp_get_msgtype(). > > Reported-by: Randy Dunlap > Fixes: 036c508ba95e ("ptp: Add generic ptp message type function") > Signed-off-by: Yangbo Lu Applied to net-next, thanks.

Re: [PATCH net-next 00/10] net: hns3: updates for -next

2020-09-27 Thread David Miller
From: Huazhong Tan Date: Sun, 27 Sep 2020 15:12:38 +0800 > To facilitate code maintenance and compatibility, #1 and #2 add > device version to replace pci revision, #3 to #9 adds support for > querying device capabilities and specifications, then the driver > can use these query results to

Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference

2020-09-25 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 25 Sep 2020 12:03:23 -0500 > There is a null-check for _pcs_, but it is being dereferenced > prior to this null-check. So, if _pcs_ can actually be null, > then there is a potential null pointer dereference that should > be fixed by null-checking _pcs_

Re: [PATCH v2] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-25 Thread David Miller
From: Wilken Gottwalt Date: Fri, 25 Sep 2020 15:58:57 +0200 > Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 > ethernet adapter. > > Signed-off-by: Wilken Gottwalt Applied.

Re: [PATCH V2 0/5 net-next] vxlan: clean-up

2020-09-25 Thread David Miller
From: Fabian Frederick Date: Fri, 25 Sep 2020 15:15:41 +0200 > This small patchet does some clean-up on vxlan. > Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by > Michal and David > > I hope to have some feedback/ACK from vxlan developers. Series applied, thanks.

Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop

2020-09-25 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 25 Sep 2020 15:44:39 +0300 > To start also "phy state machine", with UP state as it should be, > the phy_start() has to be used, in another case machine even is not > triggered. After this change negotiation is supposed to be triggered > by SM workqueue. > >

Re: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path

2020-09-25 Thread David Miller
From: Wong Vee Khee Date: Fri, 25 Sep 2020 17:54:06 +0800 > While unloading the dwmac-intel driver, clk_disable_unprepare() is > being called twice in stmmac_dvr_remove() and > intel_eth_pci_remove(). This causes kernel panic on the second call. > > Removing the second call of

Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable

2020-09-25 Thread David Miller
From: Wong Vee Khee Date: Fri, 25 Sep 2020 17:40:41 +0800 > From: "Chuah, Kim Tatt" > > Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail > Queuing. This option allows packets that fail VLAN filter to be routed > to a specific Rx queue when Receive All is also set. > > When

Re: [PATCH net] vmxnet3: fix cksum offload issues for non-udp tunnels

2020-09-25 Thread David Miller
From: Ronak Doshi Date: Thu, 24 Sep 2020 23:11:29 -0700 > Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support") added support for encapsulation offload. However, the inner > offload capability is to be restrictued to UDP tunnels. > > This patch fixes the issue for

Re: [PATCH] net: stmmac: dwmac-meson8b: add calibration registers

2020-09-25 Thread David Miller
From: Martin Blumenstingl Date: Fri, 25 Sep 2020 23:56:29 +0200 > The Amlogic dwmac Ethernet IP glue has two registers: > - PRG_ETH0 with various configuration bits > - PRG_ETH1 with various calibration and information related bits > > Add the register definitions with comments from different

Re: [PATCH net-next v2] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-25 Thread David Miller
From: Florian Fainelli Date: Thu, 24 Sep 2020 17:27:44 -0700 > While we should always make sure that we specify a valid VLAN protocol > to vlan_proto_idx(), killing the machine when an invalid value is > specified is too harsh and not helpful for debugging. All callers are > capable of dealing

Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer conversions; use string size

2020-09-25 Thread David Miller
From: Michael Witten Date: Fri, 25 Sep 2020 20:20:20 - > Are we trying to improve the code or not? Do you want me to apply your patch or not? I want to see the most minimal code change necessary to fix the bug, so we can easily backport it to -stable releases etc. If you want to perform a

Re: [PATCH net-next 0/6] net: hns3: updates for -next

2020-09-24 Thread David Miller
From: Huazhong Tan Date: Fri, 25 Sep 2020 08:26:12 +0800 > There are some updates for the HNS3 ethernet driver. > #1 & #2 are two cleanups. > #3 adds new hardware error for the client. > #4 adds debugfs support the pf's interrupt resource. > #5 adds new pci device id for 200G device. > #6

Re: [PATCH] net/ethernet/broadcom: fix spelling typo

2020-09-24 Thread David Miller
From: Wang Qing Date: Thu, 24 Sep 2020 14:50:24 +0800 > Modify the comment typo: "compliment" -> "complement". > > Signed-off-by: Wang Qing Applied, thank you.

Re: [net] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-09-24 Thread David Miller
From: Xiaoliang Yang Date: Thu, 24 Sep 2020 10:11:13 +0800 > INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3. > This register is used by stream gate control of PSFP, and it has not > been used before, because PSFP is not implemented in ocelot driver. > > Signed-off-by:

Re: [PATCH net] hinic: fix wrong return value of mac-set cmd

2020-09-24 Thread David Miller
From: Luo bin Date: Thu, 24 Sep 2020 09:31:51 +0800 > It should also be regarded as an error when hw return status=4 for PF's > setting mac cmd. Only if PF return status=4 to VF should this cmd be > taken special treatment. > > Fixes: 7dd29ee12865 ("hinic: add sriov feature support") >

Re: [net] net: dsa: felix: convert TAS link speed based on phylink speed

2020-09-24 Thread David Miller
From: Xiaoliang Yang Date: Thu, 24 Sep 2020 09:57:46 +0800 > state->speed holds a value of 10, 100, 1000 or 2500, but > QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the > speed to a proper value. > > Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler

Re: [MPTCP][PATCH net-next 00/16] mptcp: RM_ADDR/ADD_ADDR enhancements

2020-09-24 Thread David Miller
From: Geliang Tang Date: Thu, 24 Sep 2020 08:29:46 +0800 > This series include two enhancements for the MPTCP path management, > namely RM_ADDR support and ADD_ADDR echo support, as specified by RFC > sections 3.4.1 and 3.4.2. > > 1 RM_ADDR support include 9 patches (1-3 and 8-13): > > Patch 1

<    1   2   3   4   5   6   7   8   9   10   >