Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-06 Thread David Miller
From: Florian Fainelli Date: Mon, 4 May 2020 13:18:06 -0700 > When ndo_get_phys_port_name() for the CPU port was added we introduced > an early check for when the DSA master network device in > dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When > we perform the teardown ope

Re: [PATCH net-next v2 1/1] arm64: dts: sdm845: add IPA iommus property

2020-05-06 Thread David Miller
From: Alex Elder Date: Mon, 4 May 2020 13:13:50 -0500 > Add an "iommus" property to the IPA node in "sdm845.dtsi". It is > required because there are two regions of memory the IPA accesses > through an SMMU. The next few patches define and map those regions. > > Signed-off-by: Alex Elder Ap

Re: [net] seg6: fix SRH processing to comply with RFC8754

2020-05-06 Thread David Miller
From: Ahmed Abdelsalam Date: Mon, 4 May 2020 14:42:11 + > The Segment Routing Header (SRH) which defines the SRv6 dataplane is defined > in RFC8754. > > RFC8754 (section 4.1) defines the SR source node behavior which encapsulates > packets into an outer IPv6 header and SRH. The SR source no

Re: [PATCH net-next 0/2] timer: add fsleep for flexible sleeping

2020-05-06 Thread David Miller
From: Heiner Kallweit Date: Fri, 1 May 2020 23:26:21 +0200 > Sleeping for a certain amount of time requires use of different > functions, depending on the time period. > Documentation/timers/timers-howto.rst explains when to use which > function, and also checkpatch checks for some potentially >

Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread David Miller
From: Murali Karicheri Date: Wed, 6 May 2020 11:41:07 -0400 > Fix following sparse checker warning:- > > net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different > base types) > net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [usertype] > protocol > net/hsr/

Re: [PATCH net-next v3 0/3] add phy shared storage

2020-05-06 Thread David Miller
From: Michael Walle Date: Wed, 6 May 2020 16:53:12 +0200 > Introduce the concept of a shared PHY storage which can be used by some > QSGMII PHYs to ease initialization and access to global per-package > registers. > > Changes since v2: > - restore page to standard after reading the base addres

Re: [PATCH net] net: macsec: fix rtnl locking issue

2020-05-06 Thread David Miller
From: Antoine Tenart Date: Wed, 6 May 2020 15:58:30 +0200 > netdev_update_features() must be called with the rtnl lock taken. Not > doing so triggers a warning, as ASSERT_RTNL() is used in > __netdev_update_features(), the first function called by > netdev_update_features(). Fix this. > > Fixes

Re: [PATCH -next] net: enetc: Make some symbols static

2020-05-06 Thread David Miller
From: ChenTao Date: Wed, 6 May 2020 19:22:17 +0800 > Fix the following warning: > > drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning: > symbol 'enetc_act_fwd' was not declared. Should it be static? > drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning: > symbol 'enet

Re: [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

2020-05-06 Thread David Miller
From: Samuel Zou Date: Wed, 6 May 2020 14:27:30 +0800 > Fix the following sparse warning: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning: > symbol 'mtk_m32' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Applied, thanks.

Re: [PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:18:35 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/intel/i40e/i40e_adminq.c:699:13-21: Unneeded > variable: "ret_code". Return "0" on line 710 > > Signed-off-by: Jason Yan Jeff, please pick this up. Thank you.

Re: [PATCH] sparc: mm: return true,false in kern_addr_valid()

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:16:59 +0800 > This function's return type is bool and returns both true/false and 0/1. > This fixes the following coccicheck warning: > > arch/sparc/mm/init_64.c:1652:9-10: WARNING: return of 0/1 in function > 'kern_addr_valid' with return type bool > >

Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:16:30 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded > variable: "err". Return "0" on line 1252 > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()

2020-05-06 Thread David Miller
From: Jason Yan Date: Wed, 6 May 2020 14:16:16 +0800 > Fix the following coccicheck warning: > > net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function > 'br_mrp_enabled' with return type bool > > Signed-off-by: Jason Yan Applied.

Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

2020-05-06 Thread David Miller
From: Manivannan Sadhasivam Date: Wed, 6 May 2020 10:20:14 +0530 > +/* From QRTR to MHI */ > +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev, > + struct mhi_result *mhi_res) > +{ > + struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr

Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

2020-05-06 Thread David Miller
Also when you resubmit, please provide a proper introduction posting that explains what the patch series does, how it does it, and why it is doing it that way. Thanks.

Re: [PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread David Miller
From: Samuel Zou Date: Wed, 6 May 2020 10:54:58 +0800 > Fixes coccicheck warning: > > drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Applied to net-next, thank you.

Re: [PATCH] virtio_net: fix lockdep warning on 32 bit

2020-05-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 5 May 2020 20:01:31 -0400 > - u64_stats_update_end(&rq->stats.syncp); > + u64_stats_update_end_irqrestore(&rq->stats.syncp); Need to pass flags to this function.

Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread David Miller
From: Bhupesh Sharma Date: Wed, 6 May 2020 00:34:40 +0530 > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6) - > 1) : ((u16)BIT(10) - 1)) These parenthesis are very excessive and unnecessary. At the very least

Re: [PATCH net-next] net: ethernet: ti: am65-cpts: fix build

2020-05-05 Thread David Miller
From: Grygorii Strashko Date: Tue, 5 May 2020 19:21:23 +0300 > It's possible to have build configuration which will force PTP_1588_CLOCK=m > and so TI_K3_AM65_CPTS=m while still have TI_K3_AM65_CPSW_NUSS=y. This will > cause build failures: > > aarch64-linux-gnu-ld: ../drivers/net/ethernet/ti/am

Re: [PATCH resend] cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file() call

2020-05-05 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 5 May 2020 15:34:00 +0200 > There is no need to cast a typed pointer to a void pointer when calling > a function that accepts the latter. Remove it, as the cast prevents > further compiler checks. > > Signed-off-by: Geert Uytterhoeven Applied to net-next,

Re: [PATCH net-next] dt-binding: net: ti: am65x-cpts: fix dt_binding_check fail

2020-05-05 Thread David Miller
From: Grygorii Strashko Date: Tue, 5 May 2020 13:19:35 +0300 > Fix dt_binding_check fail: > Fix Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml: $id: > relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/net/ti,k3-am654-cpts.ya

Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:47:36 +0800 > There's no callers in-tree anymore since commit 5952fde10c35 ("net: > sched: choke: remove dead filter classify code") > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] bnx2x: Remove unused inline function bnx2x_vf_vlan_credit

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:50:09 +0800 > commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload") > left behind this, remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: sierra_net: Remove unused inline function

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:51:24 +0800 > There's no callers in-tree > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: microchip: Remove unused inline function is_bits_set

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:44:21 +0800 > There's no callers in-tree. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: stmmac: Remove unused inline function stmmac_rx_threshold_count

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:42:56 +0800 > There's no caller in-tree since > commit 2af6106ae949 ("net: stmmac: Introducing support for Page Pool") > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: mv643xx_eth: Remove unused inline function sum16_as_be

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:40:37 +0800 > commit 84411f73b884 ("net: mv643xx_eth: Avoid setting the initial TCP > checksum") > left behind this, remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: sun: cassini: Remove unused inline functions

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:33:12 +0800 > There's no callers in-tree anymore. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: tehuti: remove unused inline function bdx_tx_db_size

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:31:56 +0800 > There's no callers in-tree anymore. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] myri10ge: Remove unused inline function myri10ge_vlan_ip_csum

2020-05-05 Thread David Miller
From: YueHaibing Date: Tue, 5 May 2020 16:43:39 +0800 > commit 4ca3221fe4b6 ("myri10ge: Convert from LRO to GRO") > left behind this, remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread David Miller
From: David Miller Date: Tue, 05 May 2020 11:48:25 -0700 (PDT) > Series applied and queued up for -stable, thanks. Nevermind, this doesn't even compile. net/smc/af_smc.c: In function ‘smc_switch_to_fallback’: net/smc/af_smc.c:473:19: error: ‘smc->clcsock->wq’ is a pointer; did yo

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread David Miller
From: SeongJae Park Date: Tue, 5 May 2020 10:10:33 +0200 > From: SeongJae Park > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. And the following commit 333f7909a857 ("coalloc

Re: [PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:46:23 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of > 0/1 to bool variable > > Signed-o

Re: [PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:46 +0800 > No need to convert '==' expression to bool. This fixes the following > coccicheck warning: > > drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING: > conversion to bool not needed here > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: agere: use true,false for bool variable

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:56 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of > 0/1 to bool variable > > Signed-o

Re: [PATCH net-next] net: bnxt: Remove Comparison to bool in bnxt_ethtool.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:46:08 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1991:5-46: WARNING: > Comparison to bool > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1993:10-54: WARNING: > Comparison to bool > drivers/net/

Re: [PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:39 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING: > Assignment of 0/1 to bool variable > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:43:49 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25: > WARNING: Assignment of 0/1 to bool variable > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25: > WARNING: Assi

Re: [PATCH net-next] bnx2x: Remove Comparison to bool in bnx2x_dcb.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:44:00 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1548:17-31: WARNING: > Comparison to bool > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1148:16-24: WARNING: > Comparison to bool > drivers/net/eth

Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource

2020-05-05 Thread David Miller
From: Dejin Zheng Date: Tue, 5 May 2020 10:03:29 +0800 > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") will broke this driver. > idm_base and nicpm_base were optional, after this change, they are > mandatory. it will probe fails with -22 when the dt

Re: [PATCH] nfp: abm: fix a memory leak bug

2020-05-04 Thread David Miller
From: wu000...@umn.edu Date: Sat, 2 May 2020 17:42:59 -0500 > From: Qiushi Wu > > In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open. > But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, > which can lead to a memory leak bug. Fix this issue by adding >

Re: [PATCH net-next 0/7] net: ethernet: ti: k3: introduce common platform time sync driver - cpts

2020-05-04 Thread David Miller
From: Grygorii Strashko Date: Fri, 1 May 2020 23:50:04 +0300 > This series introduced support for significantly upgraded TI A65x/J721E Common > platform time sync (CPTS) modules which are part of AM65xx Time > Synchronization > Architecture [1]. ... Series applied, thank you.

Re: [PATCH] net: stmmac: gmac5+: fix potential integer overflow on 32 bit multiply

2020-05-04 Thread David Miller
From: Colin King Date: Fri, 1 May 2020 15:10:16 +0100 > From: Colin Ian King > > The multiplication of cfg->ctr[1] by 10 is performed using a > 32 bit multiplication (since cfg->ctr[1] is a u32) and this can lead > to a potential overflow. Fix this by making the constant a ULL to > ens

Re: [PATCH] cxgb4/chcr: avoid -Wreturn-local-addr warning

2020-05-04 Thread David Miller
From: Arnd Bergmann Date: Thu, 30 Apr 2020 12:39:02 +0200 > gcc-10 warns about functions that return a pointer to a stack > variable. In chcr_write_cpl_set_tcb_ulp(), this does not actually > happen, but it's too hard to see for the compiler: > > drivers/crypto/chelsio/chcr_ktls.c: In function

Re: [PATCH net-next v2 0/4] net: ipa: I/O map SMEM and IMEM

2020-05-04 Thread David Miller
From: Alex Elder Date: Mon, 4 May 2020 12:58:55 -0500 > This series adds the definition of two memory regions that must be > mapped for IPA to access through an SMMU. It requires the SMMU to > be defined in the IPA node in the SoC's Device Tree file. > > There is no change since version 1 to t

Re: [PATCH] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-04 Thread David Miller
From: Kai-Heng Feng Date: Tue, 5 May 2020 01:32:18 +0800 > igb device gets runtime suspended when there's no link partner. We can't > get correct speed under that state: > $ cat /sys/class/net/enp3s0/speed > 1000 > > In addition to that, an error can also be spotted in dmesg: > [ 385.991957] i

Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to be disabled

2020-05-04 Thread David Miller
From: Michael Walle Date: Mon, 4 May 2020 18:52:28 +0200 > If there is no specific configuration of the felix switch in the device > tree, but only the default configuration (ie. given by the SoCs dtsi > file), the probe fails because no CPU port has been set. On the other > hand you cannot set

Re: [PATCH v3 2/3] net: qrtr: Add MHI transport layer

2020-05-04 Thread David Miller
From: Manivannan Sadhasivam Date: Mon, 4 May 2020 20:19:06 +0530 > Hi Dave, > > On Mon, Apr 27, 2020 at 01:28:28PM +0530, Manivannan Sadhasivam wrote: >> MHI is the transport layer used for communicating to the external modems. >> Hence, this commit adds MHI transport layer support to QRTR for >

Re: [PATCH v3 0/7] net: macb: Wake-on-Lan magic packet fixes and GEM handling

2020-05-04 Thread David Miller
From: Date: Mon, 4 May 2020 15:44:15 +0200 > Here is the 3rd series to fix WoL magic-packet on the current macb driver. > I also add, in the second part of this series the feature to GEM types of IPs. > Please tell me if they should be separated; but the two last patches cannot go > without the 5

Re: [PATCH net v1] net: enetc: fix an issue about leak system resources

2020-05-04 Thread David Miller
From: Dejin Zheng Date: Mon, 4 May 2020 20:01:27 +0800 > the related system resources were not released when enetc_hw_alloc() > return error in the enetc_pci_mdio_probe(), add iounmap() for error > handling label "err_hw_alloc" to fix it. > > Fixes: 6517798dd3432a ("enetc: Make MDIO accessors m

Re: [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-04 Thread David Miller
From: Joyce Ooi Date: Mon, 4 May 2020 16:25:49 +0800 > The return from tx_buffer call in tse_start_xmit is > inapropriately ignored. tse_buffer calls should return > 0 for success or NETDEV_TX_BUSY. tse_start_xmit should > return not report a successful transmit when the tse_buffer > call retu

Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-04 Thread David Miller
From: Maxim Petrov Date: Mon, 4 May 2020 09:26:43 +0300 > The paranoidal pointer check in IRQ handler looks very strange - it > really protects us only against bogus drivers which request IRQ line > with null pointer dev_id. However, the code fragment is incorrect > because the dev pointer is use

Re: [PATCH net] net: dsa: Do not make user port errors fatal

2020-05-04 Thread David Miller
From: Florian Fainelli Date: Sun, 3 May 2020 20:50:57 -0700 > Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would > not treat failures to set-up an user port as fatal, but after this > commit we would, which is a regression for some systems where interfaces > may be declared i

Re: [PATCH net v3] net: macb: fix an issue about leak related system resources

2020-05-03 Thread David Miller
From: Dejin Zheng Date: Sun, 3 May 2020 20:32:26 +0800 > A call of the function macb_init() can fail in the function > fu540_c000_init. The related system resources were not released > then. use devm_platform_ioremap_resource() to replace ioremap() > to fix it. > > Fixes: c218ad559020ff9 ("macb

Re: [PATCH] net: usb: qmi_wwan: add support for DW5816e

2020-05-03 Thread David Miller
From: Bjørn Mork Date: Sun, 03 May 2020 09:13:58 +0200 > Matt Jolly writes: > >> Add support for Dell Wireless 5816e to drivers/net/usb/qmi_wwan.c >> >> Signed-off-by: Matt Jolly ... > Looks fine to me. Please add to the stable queue as well, Thanks. > > Acked-by: Bjørn Mork Applied and

Re: [PATCH] net: usb: qmi_wwan: add support for DW5816e

2020-05-02 Thread David Miller
From: Matt Jolly Date: Sun, 3 May 2020 01:52:28 +1000 > Add support for Dell Wireless 5816e to drivers/net/usb/qmi_wwan.c > > Signed-off-by: Matt Jolly Bjørn, please review.

Re: [PATCH] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-02 Thread David Miller
From: Maxim Petrov Date: Sat, 2 May 2020 12:29:08 +0300 > The paranoidal pointer check in IRQ handler looks very strange - it > really protects us only against bogus drivers which request IRQ line > with null pointer dev_id. However, the code fragment is incorrect > because the dev pointer is use

Re: [PATCH v2 net-next 0/3] ptp: Add adjust phase to support phase offset.

2020-05-02 Thread David Miller
From: Date: Fri, 1 May 2020 23:35:35 -0400 > From: Vincent Cheng > > This series adds adjust phase to the PTP Hardware Clock device interface. > > Some PTP hardware clocks have a write phase mode that has > a built-in hardware filtering capability. The write phase mode > utilizes a phase offs

Re: [v5,net-next 0/4] Introduce a flow gate control action and apply IEEE

2020-05-01 Thread David Miller
From: Po Liu Date: Fri, 1 May 2020 08:53:14 +0800 ... > These patches add stream gate action policing in IEEE802.1Qci (Per-Stream > Filtering and Policing) software support and hardware offload support in > tc flower, and implement the stream identify, stream filtering and > stream gate filteri

Re: [PATCH net-next] net: bcmgenet: Move wake-up event out of side band ISR

2020-05-01 Thread David Miller
From: Doug Berger Date: Thu, 30 Apr 2020 16:26:51 -0700 > The side band interrupt service routine is not available on chips > like 7211, or rather, it does not permit the signaling of wake-up > events due to the complex interrupt hierarchy. > > Move the wake-up event accounting into a .resume_no

Re: [PATCH net-next 0/2] net: ipa: don't cache channel state

2020-05-01 Thread David Miller
From: Alex Elder Date: Thu, 30 Apr 2020 17:13:21 -0500 > This series removes a field that holds a copy of a channel's state > at the time it was last fetched. In principle the state can change > at any time, so it's better to just fetch it whenever needed. The > first patch is just preparatory,

Re: [PATCH v2] net: Make PTP-specific drivers depend on PTP_1588_CLOCK

2020-05-01 Thread David Miller
From: Clay McClure Date: Wed, 29 Apr 2020 00:59:00 -0700 > Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed > all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply > PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP > clock subsystem a

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-05-01 Thread David Miller
From: Nathan Chancellor Date: Tue, 28 Apr 2020 10:54:56 -0700 > netvsc_start_xmit is used as a callback function for the ndo_start_xmit > function pointer. ndo_start_xmit's return type is netdev_tx_t but > netvsc_start_xmit's return type is int. > > This causes a failure with Control Flow Integr

Re: [PATCH net v3 0/2] WoL fixes for DP83822 and DP83tc811

2020-05-01 Thread David Miller
From: Dan Murphy Date: Tue, 28 Apr 2020 11:03:52 -0500 > The WoL feature for each device was enabled during boot or when the PHY was > brought up which may be undesired. These patches disable the WoL in the > config_init. The disabling and enabling of the WoL is now done though the > set_wol ca

Re: [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema

2020-05-01 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 28 Apr 2020 15:31:22 +0900 > Convert the UniPhier AVE4 controller binding to DT schema format. > This changes phy-handle property to required. > > Signed-off-by: Kunihiko Hayashi DT folks, is it ok if I take this into net-next or do you folks want to take it i

Re: [PATCH 00/37]net: manually convert files to ReST format - part 3 (final)

2020-05-01 Thread David Miller
From: Mauro Carvalho Chehab Date: Fri, 1 May 2020 16:44:22 +0200 > That's the third part (and the final one) of my work to convert the networking > text files into ReST. it is based on linux-next next-20200430 branch. > > The full series (including those ones) are at: > > https://git.lin

Re: [PATCH -next] hinic: Use kmemdup instead of kzalloc and memcpy

2020-04-30 Thread David Miller
From: Zou Wei Date: Wed, 29 Apr 2020 11:35:28 +0800 > Fixes coccicheck warnings: > > drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING > opportunity for kmemdup > drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING > opportunity for kmemdup > > Reported-b

Re: [PATCH net-next v2 3/4] net: phy: bcm54140: apply the workaround on b0 chips

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:58 +0200 > The lower three bits of the phy_id specifies the chip stepping. The > workaround is specifically for the B0 stepping. Apply it only on these > chips. > > Signed-off-by: Michael Walle > Reviewed-by: Andrew Lunn > Reviewed-by: Florian F

Re: [PATCH net-next v2 4/4] net: phy: bcm54140: add second PHY ID

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:59 +0200 > This PHY has two PHY IDs depending on its mode. Adjust the mask so that > it includes both IDs. > > Signed-off-by: Michael Walle Applied.

Re: [PATCH net-next v2 2/4] net: phy: bcm54140: fix phy_id_mask

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:57 +0200 > Broadcom defines the bits for this PHY as follows: > { oui[24:3], model[6:0], revision[2:0] } > > Thus we have to mask the lower three bits only. > > Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") > Signed-off-by: Mi

Re: [PATCH net-next v2 1/4] net: phy: bcm54140: use genphy_soft_reset()

2020-04-30 Thread David Miller
From: Michael Walle Date: Wed, 29 Apr 2020 01:06:56 +0200 > Set the .soft_reset() op to be sure there will be a reset even if there > is no hardware reset line registered. > > Signed-off-by: Michael Walle > Reviewed-by: Florian Fainelli Applied.

Re: [PATCH net-next] net: phy: at803x: add downshift support

2020-04-30 Thread David Miller
From: Michael Walle Date: Tue, 28 Apr 2020 23:15:02 +0200 > The AR8031 and AR8035 support the link speed downshift. Add driver > support for it. One peculiarity of these PHYs is that it needs a > software reset after changing the setting, thus add the .soft_reset() > op and do a phy_init_hw() if

Re: [PATCH] dpaa_eth: Fix comparing pointer to 0

2020-04-30 Thread David Miller
From: Aishwarya Ramakrishnan Date: Mon, 27 Apr 2020 16:02:30 +0530 > Fixes coccicheck warning: > ./drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2110:30-31: > WARNING comparing pointer to 0 > > Avoid pointer type value compared to 0. > > Signed-off-by: Aishwarya Ramakrishnan Applied, thanks.

Re: [PATCH] net: moxa: Fix a potential double 'free_irq()'

2020-04-30 Thread David Miller
From: Christophe JAILLET Date: Sun, 26 Apr 2020 22:59:21 +0200 > Should an irq requested with 'devm_request_irq' be released explicitly, > it should be done by 'devm_free_irq()', not 'free_irq()'. > > Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") > Signed-off-by: Christophe JAIL

Re: [PATCH net 0/3] net: ipa: three bug fixes

2020-04-30 Thread David Miller
From: Alex Elder Date: Thu, 30 Apr 2020 16:35:09 -0500 > This series fixes three bugs in the Qualcomm IPA code. The third > adds a missing error code initialization step. Series applied, thanks.

Re: [PATCH] dp83640: reverse arguments to list_add_tail

2020-04-30 Thread David Miller
From: Julia Lawall Date: Thu, 30 Apr 2020 21:51:32 +0200 > In this code, it appears that phyter_clocks is a list head, based on > the previous list_for_each, and that clock->list is intended to be a > list element, given that it has just been initialized in > dp83640_clock_init. Accordingly, swi

Re: [PATCH 00/37] net: manually convert files to ReST format - part 2

2020-04-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Thu, 30 Apr 2020 18:03:55 +0200 > That's the second part of my work to convert the networking > text files into ReST. it is based on today's linux-next (next-20200430). > > The full series (including those ones) are at: > > https://git.linuxtv.org/mchehab

Re: [PATCH] net/faraday: Fix unnecessary check in ftmac100_probe()

2020-04-30 Thread David Miller
From: Tang Bin Date: Thu, 30 Apr 2020 20:15:31 +0800 > The function ftmac100_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied.

Re: [PATCH] net: ftgmac100: Fix unused assignment

2020-04-30 Thread David Miller
From: Tang Bin Date: Thu, 30 Apr 2020 20:11:23 +0800 > Delete unused initialized value in ftgmac100.c file. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin This does not apply to the current networking trees.

Re: [PATCH net-next v5 0/3] net: phy: mdio: add IPQ40xx MDIO support

2020-04-30 Thread David Miller
From: Robert Marko Date: Thu, 30 Apr 2020 11:07:04 +0200 > This patch series provides support for the IPQ40xx built-in MDIO interface. > Included are driver, devicetree bindings for it and devicetree node. Series applied, thanks.

Re: [PATCH -next v3] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler

2020-04-30 Thread David Miller
From: Zou Wei Date: Thu, 30 Apr 2020 09:51:31 +0800 > fix coccinelle warning, use ARRAY_SIZE > > drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use > ARRAY_SIZE > > v1-->v2: >remove cmd_number > > v2-->v3: >preserve the reverse christmas tree ordering of local var

Re: [PATCH net-next] hinic: make a bunch of functions static

2020-04-30 Thread David Miller
From: YueHaibing Date: Thu, 30 Apr 2020 09:32:45 +0800 > These fucntions is used only in hinic_sriov.c, > so make them static to fix sparse warnings. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Applied.

Re: [PATCH] net: dsa: mv88e6xxx: remove duplicate assignment of struct members

2020-04-29 Thread David Miller
From: Jason Yan Date: Wed, 29 Apr 2020 22:10:01 +0800 > These struct members named 'phylink_validate' was assigned twice: > > static const struct mv88e6xxx_ops mv88e6190_ops = { > .. > .phylink_validate = mv88e6390_phylink_validate, > .. > .phylink_validate = mv88

Re: [PATCH net-next] ila: remove unused inline function ila_addr_is_ila

2020-04-29 Thread David Miller
From: YueHaibing Date: Wed, 29 Apr 2020 21:25:30 +0800 > There's no callers in-tree anymore since commit 84287bb32856 ("ila: add > checksum neutral map auto"). > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: hsr: remove unused inline functions

2020-04-29 Thread David Miller
From: YueHaibing Date: Wed, 29 Apr 2020 21:24:30 +0800 > There's no callers in-tree anymore. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next v4 0/3] net: phy: mdio: add IPQ40xx MDIO support

2020-04-29 Thread David Miller
From: Robert Marko Date: Wed, 29 Apr 2020 13:07:24 +0200 > This patch series provides support for the IPQ40xx built-in MDIO interface. > Included are driver, devicetree bindings for it and devicetree node. The DT changes don't apply cleanly to net-next, please respin. Thanks.

Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler

2020-04-29 Thread David Miller
From: Zou Wei Date: Wed, 29 Apr 2020 12:17:40 +0800 > fix coccinelle warning, use ARRAY_SIZE > > drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use > ARRAY_SIZE > > -- Please don't put this "---" here. > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sr

Re: [PATCH V2] net: hns3: adds support for reading module eeprom info

2020-04-29 Thread David Miller
From: Huazhong Tan Date: Wed, 29 Apr 2020 11:46:24 +0800 > From: Yonglong Liu > > This patch adds support for reading the optical module eeprom > info via "ethtool -m". > > Signed-off-by: Yonglong Liu > Signed-off-by: Huazhong Tan > --- > V2: replace self-defined macro with the SFF8024_ID_*

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-29 Thread David Miller
From: Wei Liu Date: Wed, 29 Apr 2020 11:10:55 +0100 > Do you want this to go through net tree? I can submit it via hyperv tree > if that's preferred. I'll be taking this, thanks.

Re: [PATCH 00/38] net: manually convert files to ReST format - part 1

2020-04-28 Thread David Miller
From: Mauro Carvalho Chehab Date: Tue, 28 Apr 2020 00:01:15 +0200 > There are very few documents upstream that aren't converted upstream. > > This series convert part of the networking text files into ReST. > It is part of a bigger set of patches, which were split on parts, > in order to make re

Re: [PATCH] dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show

2020-04-28 Thread David Miller
From: Nick Desaulniers Date: Tue, 28 Apr 2020 11:34:11 -0700 > On Tue, Apr 28, 2020 at 10:43 AM Nathan Chancellor > wrote: >> >> When building arm32 allmodconfig: >> >> ERROR: modpost: "__aeabi_uldivmod" >> [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined! >> >> frames and cdan

Re: [PATCH] net/x25: Fix null-ptr-deref in x25_disconnect

2020-04-28 Thread David Miller
From: YueHaibing Date: Tue, 28 Apr 2020 16:12:08 +0800 > We should check null before do x25_neigh_put in x25_disconnect, > otherwise may cause null-ptr-deref like this: ... > Reported-by: syzbot+6db548b615e5aeefd...@syzkaller.appspotmail.com > Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt l

Re: [PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-04-28 Thread David Miller
From: Stephen Kitt Date: Tue, 28 Apr 2020 09:52:31 +0200 > This patch changes INET_ADDR_COOKIE to declare a dummy typedef (so it > makes checkpatch.pl complain, sorry...) This is trading one problem for another, so in the end doesn't really move us forward.

Re: [PATCH v2] net/ena: Fix build warning in ena_xdp_set()

2020-04-28 Thread David Miller
From: Gavin Shan Date: Tue, 28 Apr 2020 14:49:45 +1000 > This fixes the following build warning in ena_xdp_set(), which is > observed on aarch64 with 64KB page size. > >In file included from ./include/net/inet_sock.h:19, > from ./include/net/ip.h:27, > from drivers/net/ethernet/a

Re: [PATCH-next] net: phy: bcm54140: Make a bunch of functions static

2020-04-28 Thread David Miller
From: ChenTao Date: Tue, 28 Apr 2020 09:48:04 +0800 > Fix the following warning: > > drivers/net/phy/bcm54140.c:663:5: warning: > symbol 'bcm54140_did_interrupt' was not declared. Should it be static? > drivers/net/phy/bcm54140.c:672:5: warning: > symbol 'bcm54140_ack_intr' was not declared. Sho

Re: [PATCH net-next v6 0/5] kselftest: add fixture parameters

2020-04-28 Thread David Miller
From: Jakub Kicinski Date: Mon, 27 Apr 2020 18:03:46 -0700 > This set is an attempt to make running tests for different > sets of data easier. The direct motivation is the tls > test which we'd like to run for TLS 1.2 and TLS 1.3, > but currently there is no easy way to invoke the same > tests wi

Re: [PATCH 00/38] net: manually convert files to ReST format - part 1

2020-04-28 Thread David Miller
From: Mauro Carvalho Chehab Date: Tue, 28 Apr 2020 00:01:15 +0200 > There are very few documents upstream that aren't converted upstream. > > This series convert part of the networking text files into ReST. > It is part of a bigger set of patches, which were split on parts, > in order to make re

Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to be disabled

2020-04-28 Thread David Miller
From: Dan Murphy Date: Mon, 27 Apr 2020 16:21:12 -0500 > + return phy_write_mmd(phydev, DP83822_DEVADDR, Please don't submit patches that have not even had a conversation with the compiler. This register define only exist

Re: [PATCH] r8152: add device id for Lenovo ThinkPad USB-C Dock Gen 2

2019-10-21 Thread David Miller
From: Kazutoshi Noguchi Date: Mon, 21 Oct 2019 00:03:07 +0900 > This device is sold as 'ThinkPad USB-C Dock Gen 2 (40AS)'. > Chipset is RTL8153 and works with r8152. > Without this, the generic cdc_ether grabs the device, and the device jam > connected networks up when the machine suspends. > >

Re: [PATCH net-next 00/16] net: dsa: turn arrays of ports into a list

2019-10-21 Thread David Miller
From: Vivien Didelot Date: Sat, 19 Oct 2019 23:19:25 -0400 > The dsa_switch structure represents the physical switch device itself, > and is allocated by the driver. The dsa_switch_tree and dsa_port structures > represent the logical switch fabric (eventually composed of multiple switch > devices

<    9   10   11   12   13   14   15   16   17   18   >