Re: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()

2021-03-29 Thread David Teigland
On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote: > Add the missing unlock before return from accept_from_sock() > in the error handling case. Thanks, applied to the next branch. Dave > Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection") > Reported-by: Hulk Robot >

[GIT PULL] dlm updates for 5.11

2020-12-14 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.11 This set includes more low level communication layer cleanups. The main change is the listening socket is no longer handled as a special case of node connection sockets.

[GIT PULL] dlm updates for 5.10

2020-10-12 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.10 This set continues the ongoing rework of the low level communication layer in the dlm. The focus here is on improvements to connection handling, and reworking the receiving

[GIT PULL] dlm updates for 5.9

2020-08-06 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.9 This set includes a some improvements to the dlm networking layer: improving the ability to trace dlm messages for debugging, and improved handling of bad messages or

[GIT PULL] dlm updates for 5.8

2020-06-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.8 This set includes a couple minor cleanups, and dropping the interruptible from a wait_event that waits for an event from the userspace cluster management. Thanks, Dave Arnd

Re: [PATCH 1/4] sctp: add sctp_sock_set_nodelay

2020-05-29 Thread David Teigland
On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. Ack, they look fine to me, thanks. Dave

Re: is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx

2020-05-14 Thread David Teigland
On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote: > > > And call it directly from dlm instead of going through kernel_setsockopt. > >

[GIT PULL] dlm updates for 5.3 (second try)

2019-07-12 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.3 This set removes some unnecessary debugfs error handling, and checks that lowcomms workqueues are not NULL before destroying. (Dropped the commits related to incorrect

Re: [GIT PULL] dlm updates for 5.3

2019-07-11 Thread David Teigland
On Wed, Jul 10, 2019 at 09:05:21PM -0700, Linus Torvalds wrote: > If wait_event_interruptible() returns -ERESTARTSYS, it means that we > have a signal pending. > > And if we have a signal pending, then you can't go back and call > wait_event_interruptible() in a loop, because the signal will >

[GIT PULL] dlm updates for 5.3

2019-07-09 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.3 Apart from a couple trivial fixes, the more notable fix makes the dlm continuing waiting for a user space result if a signal interrupts the wait event. Thanks, Dave David

[GIT PULL] dlm updates for 4.21

2018-12-19 Thread David Teigland
. Thanks, Dave Bob Peterson (1): dlm: Don't swamp the CPU with callbacks queued during recovery David Teigland (2): dlm: fix missing idr_destroy for recover_idr dlm: fix invalid cluster name warning Denis V. Lunev (1): dlm: fix possible call to kfree() for non-initialized

[GIT PULL] dlm updates for 4.18

2018-06-04 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.18 These three commits fix and clean up the flags dlm was using on its SCTP sockets. The result improves the performance and fixes some bad connection delays. Thanks, Dave

[GIT PULL] dlm updates for 4.18

2018-06-04 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.18 These three commits fix and clean up the flags dlm was using on its SCTP sockets. The result improves the performance and fixes some bad connection delays. Thanks, Dave

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-04-02 Thread David Teigland
On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: > Hello David, > > Do you agree to add this prompt to the user? > Since sometimes customers attempted to setup SCTP protocol with two rings, > but they could not get the expected result, then it maybe bring some concerns > to the

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-04-02 Thread David Teigland
On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: > Hello David, > > Do you agree to add this prompt to the user? > Since sometimes customers attempted to setup SCTP protocol with two rings, > but they could not get the expected result, then it maybe bring some concerns > to the

[GIT PULL] dlm updates for 4.15

2017-11-13 Thread David Teigland
, starting, and stopping. Thanks, Dave Bob Peterson (3): DLM: Eliminate CF_CONNECT_PENDING flag DLM: Eliminate CF_WRITE_PENDING flag DLM: Fix saving of NULL callbacks David Teigland (1): dlm: remove dlm_send_rcom_lookup_dump Guoqing Jiang (1): dlm: recheck

[GIT PULL] dlm updates for 4.15

2017-11-13 Thread David Teigland
, starting, and stopping. Thanks, Dave Bob Peterson (3): DLM: Eliminate CF_CONNECT_PENDING flag DLM: Eliminate CF_WRITE_PENDING flag DLM: Fix saving of NULL callbacks David Teigland (1): dlm: remove dlm_send_rcom_lookup_dump Guoqing Jiang (1): dlm: recheck

Re: [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-09 Thread David Teigland
On Sat, Oct 07, 2017 at 03:26:11AM +0100, Al Viro wrote: > On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > > and the function call path is: > > dlm_master_lookup (acquire the spinlock) > >

Re: [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-09 Thread David Teigland
On Sat, Oct 07, 2017 at 03:26:11AM +0100, Al Viro wrote: > On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > > and the function call path is: > > dlm_master_lookup (acquire the spinlock) > >

Re: linux-next: Signed-off-by missing for commits in the dlm tree

2017-09-18 Thread David Teigland
On Tue, Sep 19, 2017 at 07:49:19AM +1000, Stephen Rothwell wrote: > Hi David, > > Commits > > bcc976a145c9 ("DLM: Eliminate CF_CONNECT_PENDING flag") > c071b28b2bd5 ("DLM: Eliminate CF_WRITE_PENDING flag") > 782551aac851 ("DLM: Fix saving of NULL callbacks") > > are missing a

Re: linux-next: Signed-off-by missing for commits in the dlm tree

2017-09-18 Thread David Teigland
On Tue, Sep 19, 2017 at 07:49:19AM +1000, Stephen Rothwell wrote: > Hi David, > > Commits > > bcc976a145c9 ("DLM: Eliminate CF_CONNECT_PENDING flag") > c071b28b2bd5 ("DLM: Eliminate CF_WRITE_PENDING flag") > 782551aac851 ("DLM: Fix saving of NULL callbacks") > > are missing a

[GIT PULL] dlm updates for 4.14

2017-09-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.14 This set includes a bunch of minor code cleanups that have accumulated, probably from code analyzers people like to run. There is one nice fix that avoids some socket leaks

[GIT PULL] dlm updates for 4.14

2017-09-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.14 This set includes a bunch of minor code cleanups that have accumulated, probably from code analyzers people like to run. There is one nice fix that avoids some socket leaks

[GIT PULL] dlm fixes for 4.10

2016-12-12 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes.

[GIT PULL] dlm fixes for 4.10

2016-12-12 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes.

[GIT PULL] dlm fixes for 4.9

2016-10-10 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.9 This includes a bug fix for a bad memory access during workqueue cleanup, which can happen while shutting down the dlm networking layer. (This was found and fixed in the past

[GIT PULL] dlm fixes for 4.9

2016-10-10 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.9 This includes a bug fix for a bad memory access during workqueue cleanup, which can happen while shutting down the dlm networking layer. (This was found and fixed in the past

[GIT PULL] dlm fixes for 4.8

2016-08-26 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8-fixes This fixes a bug introduced by recent debugfs cleanup. Thanks, Dave Eric Ren (1): dlm: fix malfunction of dlm_tool caused by debugfs changes fs/dlm/debug_fs.c

[GIT PULL] dlm fixes for 4.8

2016-08-26 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8-fixes This fixes a bug introduced by recent debugfs cleanup. Thanks, Dave Eric Ren (1): dlm: fix malfunction of dlm_tool caused by debugfs changes fs/dlm/debug_fs.c

[GIT PULL] dlm updates for 4.8

2016-07-27 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8 This set includes two trivial changes, one to use kmemdup and another to control the log level of recovery messages. Thanks, Dave Amitoj Kaur Chawla (1): dlm: Use

[GIT PULL] dlm updates for 4.8

2016-07-27 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8 This set includes two trivial changes, one to use kmemdup and another to control the log level of recovery messages. Thanks, Dave Amitoj Kaur Chawla (1): dlm: Use

[GIT PULL] dlm fixes for 4.6

2016-03-29 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6-fixes This fixes a bug from the configfs cleanup. Thanks, Dave Andrew Price (1): dlm: config: Fix ENOMEM failures in make_cluster() fs/dlm/config.c | 3 +-- 1 file

[GIT PULL] dlm fixes for 4.6

2016-03-29 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6-fixes This fixes a bug from the configfs cleanup. Thanks, Dave Andrew Price (1): dlm: config: Fix ENOMEM failures in make_cluster() fs/dlm/config.c | 3 +-- 1 file

[GIT PULL] dlm updates for 4.6

2016-03-18 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6 Previous changes introduced the use of socket error reporting for dlm sockets. This set includes two fixes in how the socket error callbacks are used. Thanks, Dave Bob

[GIT PULL] dlm updates for 4.6

2016-03-18 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6 Previous changes introduced the use of socket error reporting for dlm sockets. This set includes two fixes in how the socket error callbacks are used. Thanks, Dave Bob

[GIT PULL] dlm updates for 4.4

2015-11-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.4 This includes one simple fix to make posix locks interruptible by signals in cases where a signal handler is used. Thanks, Dave Eric Ren (1): dlm: make posix locks

[GIT PULL] dlm updates for 4.4

2015-11-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.4 This includes one simple fix to make posix locks interruptible by signals in cases where a signal handler is used. Thanks, Dave Eric Ren (1): dlm: make posix locks

[GIT PULL] dlm updates for 4.3

2015-08-31 Thread David Teigland
are also included. The other notable fix is for a long standing regression in the behavior of lock value blocks for user space locks. Thanks, Dave Bob Peterson (1): dlm: print error from kernel_sendpage David Teigland (1): dlm: fix lvb copy for user locks Marcelo Ricardo Leitner (6

[GIT PULL] dlm updates for 4.3

2015-08-31 Thread David Teigland
are also included. The other notable fix is for a long standing regression in the behavior of lock value blocks for user space locks. Thanks, Dave Bob Peterson (1): dlm: print error from kernel_sendpage David Teigland (1): dlm: fix lvb copy for user locks Marcelo Ricardo Leitner (6

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 12:01:38PM -0700, Guenter Roeck wrote: > I think I can understand why Wim was reluctant to accept your patch; > I must admit I don't understand your use case either. Very breifly, sanlock is a shared storage based lease manager, and the expiration of a lease is tied to the

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 10:41:51AM -0700, Guenter Roeck wrote: > Not really. The heartbeats will be generated such that the watchdog expires > no later that . I > discussed > this already with Uwe; he had the same concern. This isn't in the current > version of the patch set, but it will be in

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote: > - Some watchdogs have a very short maximum timeout, in the range of just a few > seconds. Such low timeouts are difficult if not impossible to support from > user space. Drivers supporting such watchdog hardware need to implement

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote: - Some watchdogs have a very short maximum timeout, in the range of just a few seconds. Such low timeouts are difficult if not impossible to support from user space. Drivers supporting such watchdog hardware need to implement

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 10:41:51AM -0700, Guenter Roeck wrote: Not really. The heartbeats will be generated such that the watchdog expires no later that last heartbeat from userspace + configured timeout. I discussed this already with Uwe; he had the same concern. This isn't in the current

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 12:01:38PM -0700, Guenter Roeck wrote: I think I can understand why Wim was reluctant to accept your patch; I must admit I don't understand your use case either. Very breifly, sanlock is a shared storage based lease manager, and the expiration of a lease is tied to the

Re: clustered MD

2015-06-12 Thread David Teigland
When a node fails, its dirty areas get special treatment from other nodes using the area_resyncing() function. Should the suspend_list be created before any reads or writes from the file system are processed by md? It seems to me that gfs journal recovery could read/write to dirty regions (from

Re: clustered MD

2015-06-12 Thread David Teigland
When a node fails, its dirty areas get special treatment from other nodes using the area_resyncing() function. Should the suspend_list be created before any reads or writes from the file system are processed by md? It seems to me that gfs journal recovery could read/write to dirty regions (from

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread David Teigland
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > Do you consider take the following clean up? If yes, I will send a > formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. > - to_nodeid =

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread David Teigland
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: Do you consider take the following clean up? If yes, I will send a formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. - to_nodeid =

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 04:07:44PM -0500, David Teigland wrote: > > Also a slightly less adversarial tone would make me feel more > > comfortable, though maybe I'm misreading your intent. > > You're probably misreading "concerned". > > The initial responses t

Re: clustered MD

2015-06-10 Thread David Teigland
On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote: > What is your interest in this? I'm always happy for open discussion and > varied input, but it would help to know to what extent you are a stake > holder? Using the dlm correctly is non-trivial and should be reviewed. If the dlm is

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 12:05:33PM -0500, David Teigland wrote: > Separate bitmaps for each node sounds like a much better design than the > cmirror design which used a single shared bitmap (I argued for using a > single bitmap when cmirror was being designed.) Sorry misspoke, I argue

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:23:25AM -0500, Goldwyn Rodrigues wrote: > To start with, the goal of (basic) MD RAID1 is to keep the two > mirrored device consistent _all_ of the time. In case of a device > failure, it should degrade the array pointing to the failed device, > so it can be

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 10:27:27AM -0500, Goldwyn Rodrigues wrote: > I thought I answered that: > To use a software RAID1 across multiple nodes of a cluster. Let me > explain in more words.. > > In a cluster with multiple nodes with a shared storage, such as a > SAN. The shared device becomes a

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: > The remove_from_waiters could only be invoked after failed to > create_message, right? > Since send_message always returns 0, this patch doesn't touch anything > about the failure > path, and it also doesn't change the original

Re: clustered MD

2015-06-10 Thread David Teigland
On Tue, Jun 09, 2015 at 10:33:08PM -0500, Goldwyn Rodrigues wrote: > >>>some real world utility to warrant the potential maintenance effort. > >> > >>We do have a valid real world utility. It is to provide > >>high-availability of RAID1 storage over the cluster. The > >>distributed locking is

Re: clustered MD

2015-06-10 Thread David Teigland
On Tue, Jun 09, 2015 at 10:33:08PM -0500, Goldwyn Rodrigues wrote: some real world utility to warrant the potential maintenance effort. We do have a valid real world utility. It is to provide high-availability of RAID1 storage over the cluster. The distributed locking is required only

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 10:27:27AM -0500, Goldwyn Rodrigues wrote: I thought I answered that: To use a software RAID1 across multiple nodes of a cluster. Let me explain in more words.. In a cluster with multiple nodes with a shared storage, such as a SAN. The shared device becomes a single

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 12:05:33PM -0500, David Teigland wrote: Separate bitmaps for each node sounds like a much better design than the cmirror design which used a single shared bitmap (I argued for using a single bitmap when cmirror was being designed.) Sorry misspoke, I argued for one

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:23:25AM -0500, Goldwyn Rodrigues wrote: To start with, the goal of (basic) MD RAID1 is to keep the two mirrored device consistent _all_ of the time. In case of a device failure, it should degrade the array pointing to the failed device, so it can be

Re: clustered MD

2015-06-10 Thread David Teigland
On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote: What is your interest in this? I'm always happy for open discussion and varied input, but it would help to know to what extent you are a stake holder? Using the dlm correctly is non-trivial and should be reviewed. If the dlm is

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 04:07:44PM -0500, David Teigland wrote: Also a slightly less adversarial tone would make me feel more comfortable, though maybe I'm misreading your intent. You're probably misreading concerned. The initial responses to my inquiry were severely lacking in any

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: The remove_from_waiters could only be invoked after failed to create_message, right? Since send_message always returns 0, this patch doesn't touch anything about the failure path, and it also doesn't change the original semantic.

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 03:08:11PM -0500, Goldwyn Rodrigues wrote: > Hi David, > > On 06/09/2015 02:45 PM, David Teigland wrote: > >On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > >>On 06/09/2015 01:22 PM, David Teigland wrote: > >>

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > On 06/09/2015 01:22 PM, David Teigland wrote: > >I've just noticed the existence of clustered MD for the first time. > >It is a major new user of the dlm, and I have some doubts about it. > >When did this

clustered MD

2015-06-09 Thread David Teigland
I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list for review? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

clustered MD

2015-06-09 Thread David Teigland
I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list for review? Dave -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: On 06/09/2015 01:22 PM, David Teigland wrote: I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 03:08:11PM -0500, Goldwyn Rodrigues wrote: Hi David, On 06/09/2015 02:45 PM, David Teigland wrote: On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: On 06/09/2015 01:22 PM, David Teigland wrote: I've just noticed the existence of clustered MD

[GIT PULL] dlm updates for 3.19

2014-12-10 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.19 This set includes one feature, which allows locks that have been orphaned to be reacquired. Thanks, Dave David Teigland (1): dlm: adopt orphan locks fs/dlm/lock.c

[GIT PULL] dlm updates for 3.19

2014-12-10 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.19 This set includes one feature, which allows locks that have been orphaned to be reacquired. Thanks, Dave David Teigland (1): dlm: adopt orphan locks fs/dlm/lock.c

Re: [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-11-04 Thread David Teigland
On Tue, Nov 04, 2014 at 08:08:52AM -0500, Steven Rostedt wrote: > On Wed, 29 Oct 2014 17:56:07 -0400 > Steven Rostedt wrote: > > > From: Joe Perches > > > > [ REQUEST FOR ACKS ] > > Can any of the DLM maintainers give me an Acked-by for this? Looks ok, Dave -- To unsubscribe from this list:

Re: [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-11-04 Thread David Teigland
On Tue, Nov 04, 2014 at 08:08:52AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:07 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Joe Perches j...@perches.com [ REQUEST FOR ACKS ] Can any of the DLM maintainers give me an Acked-by for this? Looks ok, Dave -- To

[GIT PULL] dlm updates for 3.18

2014-10-17 Thread David Teigland
(v2: add cc lkml) Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.18 This includes a single commit fixing a missing endian conversion. Thanks, Dave Neale Ferguson (1): dlm: fix missing endian conversion of

[GIT PULL] dlm updates for 3.18

2014-10-17 Thread David Teigland
(v2: add cc lkml) Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.18 This includes a single commit fixing a missing endian conversion. Thanks, Dave Neale Ferguson (1): dlm: fix missing endian conversion of

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread David Teigland
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 > Joe Perches wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > > > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). What I

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread David Teigland
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches j...@perches.com wrote: op-info.rv is an s32, but it's only used as a u8. I don't understand this patch. info.rv is s32 (and I assume that rv stands for return value). What I

Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote: > - Original Message - > > On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: > > > On Tue, 01 Jul 2014 06:20:10 -0700 > > > Joe Perches wrote: > > > > > > > While doing a bit of adding argument names to fs.h, > > >

Re: [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: > On Tue, 01 Jul 2014 06:20:10 -0700 > Joe Perches wrote: > > > While doing a bit of adding argument names to fs.h, > > I looked at lm_grant and it seems the 2nd argument > > is always NULL. > > > > How about removing it? > > > >

Re: [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: On Tue, 01 Jul 2014 06:20:10 -0700 Joe Perches j...@perches.com wrote: While doing a bit of adding argument names to fs.h, I looked at lm_grant and it seems the 2nd argument is always NULL. How about removing it? This

Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote: - Original Message - On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: On Tue, 01 Jul 2014 06:20:10 -0700 Joe Perches j...@perches.com wrote: While doing a bit of adding argument names to fs.h, I

[GIT PULL] dlm updates for 3.16

2014-06-13 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.16 This set includes one small fix related to resending SCTP messages. Thanks, Dave Lidong Zhong (1): dlm: keep listening connection alive with sctp mode

[GIT PULL] dlm updates for 3.16

2014-06-13 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.16 This set includes one small fix related to resending SCTP messages. Thanks, Dave Lidong Zhong (1): dlm: keep listening connection alive with sctp mode

[GIT PULL] dlm updates for 3.15

2014-04-02 Thread David Teigland
free warning David Teigland (1): dlm: use INFO for recovery messages Rashika Kheria (1): fs: Include appropriate header file in dlm/ast.c fs/dlm/ast.c | 3 ++- fs/dlm/dir.c | 4 ++-- fs/dlm/dlm_internal.h | 2 ++ fs/dlm/lock.c | 7 --- fs/dlm

[GIT PULL] dlm updates for 3.15

2014-04-02 Thread David Teigland
free warning David Teigland (1): dlm: use INFO for recovery messages Rashika Kheria (1): fs: Include appropriate header file in dlm/ast.c fs/dlm/ast.c | 3 ++- fs/dlm/dir.c | 4 ++-- fs/dlm/dlm_internal.h | 2 ++ fs/dlm/lock.c | 7 --- fs/dlm

[GIT PULL] dlm updates for 3.14

2014-01-21 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.14 This set includes a single change to speed up recovery times when using SCTP connections. Thanks, Dave Dongmao Zhang (1): dlm: set zero linger time on sctp socket

[GIT PULL] dlm updates for 3.14

2014-01-21 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.14 This set includes a single change to speed up recovery times when using SCTP connections. Thanks, Dave Dongmao Zhang (1): dlm: set zero linger time on sctp socket

[GIT PULL] dlm updates for 3.13

2013-11-11 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.13 This set includes a single fix to resolve to a race that could cause lockspace shutdown to incorrectly return -EBUSY. Thanks, Dave Bart Van Assche (1): dlm: Avoid

[GIT PULL] dlm updates for 3.13

2013-11-11 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.13 This set includes a single fix to resolve to a race that could cause lockspace shutdown to incorrectly return -EBUSY. Thanks, Dave Bart Van Assche (1): dlm: Avoid

[GIT PULL] dlm updates for 3.12

2013-09-04 Thread David Teigland
the unnecessary and wrong device_close()->recalc_sigpending() Let me know if you'd like me to send a resolved patch. Thanks, Dave David Teigland (1): dlm: remove signal blocking Tejun Heo (1): dlm: WQ_NON_REENTRANT is meaningless and going away fs/dlm/ast.c | 5 + fs/dlm/use

[GIT PULL] dlm updates for 3.12

2013-09-04 Thread David Teigland
the unnecessary and wrong device_close()-recalc_sigpending() Let me know if you'd like me to send a resolved patch. Thanks, Dave David Teigland (1): dlm: remove signal blocking Tejun Heo (1): dlm: WQ_NON_REENTRANT is meaningless and going away fs/dlm/ast.c | 5 + fs/dlm/user.c

Re: linux-next: manual merge of the dlm tree with Linus' tree

2013-08-16 Thread David Teigland
On Fri, Aug 16, 2013 at 11:40:50AM +1000, Stephen Rothwell wrote: > Hi David, > > Today's linux-next merge of the dlm tree got a conflict in fs/dlm/user.c > between commit 201d3dfa4da1 ("dlm: kill the unnecessary and wrong > device_close()->recalc_sigpending()") from Linus' tree and commit >

Re: linux-next: manual merge of the dlm tree with Linus' tree

2013-08-16 Thread David Teigland
On Fri, Aug 16, 2013 at 11:40:50AM +1000, Stephen Rothwell wrote: Hi David, Today's linux-next merge of the dlm tree got a conflict in fs/dlm/user.c between commit 201d3dfa4da1 (dlm: kill the unnecessary and wrong device_close()-recalc_sigpending()) from Linus' tree and commit c6ca7bc91d51

Re: [PATCH 1/1] dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()

2013-08-12 Thread David Teigland
ing like signals_stop/start for such a use-case. I can't remember why that signal code exists, or if I ever knew; it was there when the code was added seven years ago. I agree that if there's something we cannot interrupt, we should use uninterruptible, but I don't see any cases of that either. I

Re: [PATCH 1/1] dlm: kill the unnecessary and wrong device_close()-recalc_sigpending()

2013-08-12 Thread David Teigland
; it was there when the code was added seven years ago. I agree that if there's something we cannot interrupt, we should use uninterruptible, but I don't see any cases of that either. I think we should just remove it all (untested): From: David Teigland teigl...@redhat.com Date: Mon, 12 Aug 2013 15:22

[GIT PULL] dlm updates for 3.11

2013-07-01 Thread David Teigland
David Teigland (1): dlm: log an error for unmanaged lockspaces Mike Christie (6): dlm: clear correct init bit during sctp setup dlm: set sctp assoc id during setup dlm: clear correct bit during sctp init failure handling dlm: try other IPs when sctp init assoc fails

[GIT PULL] dlm updates for 3.11

2013-07-01 Thread David Teigland
David Teigland (1): dlm: log an error for unmanaged lockspaces Mike Christie (6): dlm: clear correct init bit during sctp setup dlm: set sctp assoc id during setup dlm: clear correct bit during sctp init failure handling dlm: try other IPs when sctp init assoc fails

Re: [PATCH 03/10] idr: Rewrite ida

2013-06-21 Thread David Teigland
On Wed, Jun 19, 2013 at 04:38:36PM -0700, Kent Overstreet wrote: > On Wed, Jun 19, 2013 at 10:40:22AM +0100, Steven Whitehouse wrote: > > Millions of IDs is something that is fairly normal for DLM, since there > > will be two DLM locks per cached inode with GFS2 and people tend to use > > it on

Re: [PATCH 03/10] idr: Rewrite ida

2013-06-21 Thread David Teigland
On Wed, Jun 19, 2013 at 04:38:36PM -0700, Kent Overstreet wrote: On Wed, Jun 19, 2013 at 10:40:22AM +0100, Steven Whitehouse wrote: Millions of IDs is something that is fairly normal for DLM, since there will be two DLM locks per cached inode with GFS2 and people tend to use it on pretty

Re: linux-next: Tree for May 8 (dlm)

2013-05-09 Thread David Teigland
On Thu, May 09, 2013 at 09:47:45AM +1000, Stephen Rothwell wrote: > [Just forwarding to David ...] > > On Wed, 08 May 2013 11:04:45 -0700 Randy Dunlap wrote: > > > > on x86_64: > > > > when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m: > > > > fs/built-in.o: In function `gfs2_lock': > >

  1   2   3   4   >