From: Al Viro [EMAIL PROTECTED]
... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is
not a good way to handle them.
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dir.c |3 +++
1 files changed, 3 insertions(+), 0
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6d98cf9..5b82187 100644
--- a/fs/dlm/lock.c
Put lkb_astparam in a union with a dlm_user_args pointer to
eliminate a lot of type casting.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/debug_fs.c |6 ++
fs/dlm/dlm_internal.h |5 -
fs/dlm/lock.c | 14 ++
fs/dlm/memory.c |2
Use proper types for ast and bast functions, and use
consistent type for ast param.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/ast.c |9 +++
fs/dlm/dlm_internal.h | 14 +---
fs/dlm/lock.c | 50
are mostly relevant for other applications.
There are no new features, only fixes for various bugs or problems. They
stem mainly from mixed architecture testing, and new tests that overlap
recovery with userland stress tests.
Thanks,
Dave
Adrian Bunk (1):
dlm: proper prototypes
David
are mostly relevant for other applications.
There are no new features, only fixes for various bugs or problems. They
stem mainly from mixed architecture testing, and new tests that overlap
recovery with userland stress tests.
Thanks,
Dave
Adrian Bunk (1):
dlm: proper prototypes
David
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
> > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> > void dlm_rcom_in(struct dlm_rcom *rc)
> > {
> > struct dlm_header *hd = (struct dlm_header *) rc;
>
&g
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland [EMAIL PROTECTED] wrote:
void dlm_rcom_in(struct dlm_rcom *rc)
{
struct dlm_header *hd = (struct dlm_header *) rc;
aww, c'mon guys, this is nonsense.
struct
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
> > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> > void dlm_rcom_in(struct dlm_rcom *rc)
> > {
> > struct dlm_header *hd = (struct dlm_header *) rc;
>
&g
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland [EMAIL PROTECTED] wrote:
void dlm_rcom_in(struct dlm_rcom *rc)
{
struct dlm_header *hd = (struct dlm_header *) rc;
aww, c'mon guys, this is nonsense.
struct
From: Adrian Bunk <[EMAIL PROTECTED]>
This patch adds a proper prototype for some functions in
fs/dlm/dlm_internal.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h | 16
fs/dlm/loc
Non-forced unlocks should be rejected if the lock is waiting on the
rsb_lookup list for another lock to establish the master node.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/lo
The invalid lockspace messages are normal and can appear relatively
often. They should be suppressed without debugging enabled.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/
, the infinite loop is dangerous since some other
unknown condition may appear causing the loop to never break.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
keep rsb's in their
toss list that they are the master of. These rsb's need to be included
when the resource directory is rebuilt during recovery.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 66 +---
fs/dlm/lock.c
field).
This patch restricts the length of the name to the amount of data
actually passed into the call.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/user.c | 12 +---
1 files changed, 9 insertions(+), 3 deleti
The dlm_put_lkb() can free the lkb and its associated ua structure,
so we can't depend on using the ua struct after the put.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/user.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/user.c b/
for an old message to be processed and caught
by these checks.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c | 139 ++--
1 files changed, 104 insertions(+), 35 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
an error message, and could in some cases change some state, causing
problems.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |9 -
fs/dlm/member.c |4 ++--
fs/dlm/member.h |3 ++-
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of
retried, there may be other lkb's waiting on the rsb_lookup list for it
to complete. A call to confirm_master() is needed to move on to the next
waiting lkb since the current one won't be retried.
Signed-off-by: David
From: Fabio M. Di Nitto <[EMAIL PROTECTED]>
gcc does not guarantee that a static buffer is 64bit aligned. This change
allows sparc64 to work.
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/midcomms.c |2 +
start doing recovery in the presence of a many overlapping
unlock/cancel ops.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c | 37 -
1 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 4
onn': Can't free all
objects"
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lowcom
From: Fabio M. Di Nitto <[EMAIL PROTECTED]>
DLM_RCOM_LOCK_REPLY messages need byte swapping.
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/util.c |9 ++---
1 files changed, 6 insertions(+), 3 deleti
the platform-specific ones at the other end.
Many thanks to Fabio for testing this patch.
Initial patch from Patrick.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs
time.
Appears when process calls libdlm dlm_release_lockspace() which first
closes the ls dev triggering clear_proc_locks, and then removes the ls
(a write to control dev) causing release_lockspace().
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |1 +
1 files chan
Change log_error() to log_debug() for conditions that can occur in
large number in normal operation.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 7bc6ad9..6
The dlm functions in memory.c should use the dlm_ prefix. Also, use
kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 10 +-
fs/dlm/lock.c | 26 +-
(+), 191 deletions(-)
Adrian Bunk (1):
dlm: proper prototypes
David Teigland (13):
dlm: don't print common non-errors
dlm: use dlm prefix on alloc and free functions
dlm: use fixed errno values in messages
dlm: clear ast_type when removing from astqueue
dlm
rators to "fix" their systems or use clever routing
tricks.
Signed-off-by: Lon Hohberger <[EMAIL PROTECTED]>
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lowcomms.c | 13 -
1 files chan
(+), 191 deletions(-)
Adrian Bunk (1):
dlm: proper prototypes
David Teigland (13):
dlm: don't print common non-errors
dlm: use dlm prefix on alloc and free functions
dlm: use fixed errno values in messages
dlm: clear ast_type when removing from astqueue
dlm
to fix their systems or use clever routing
tricks.
Signed-off-by: Lon Hohberger [EMAIL PROTECTED]
Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lowcomms.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
Change log_error() to log_debug() for conditions that can occur in
large number in normal operation.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 7bc6ad9..63fe74d
The dlm functions in memory.c should use the dlm_ prefix. Also, use
kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dir.c | 10 +-
fs/dlm/lock.c | 26 +-
fs/dlm
the platform-specific ones at the other end.
Many thanks to Fabio for testing this patch.
Initial patch from Patrick.
Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]
Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/util.c | 57
time.
Appears when process calls libdlm dlm_release_lockspace() which first
closes the ls dev triggering clear_proc_locks, and then removes the ls
(a write to control dev) causing release_lockspace().
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |1 +
1 files changed, 1
all
objects
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]
Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lowcomms.c |2 ++
1 files changed, 2 insertions
From: Fabio M. Di Nitto [EMAIL PROTECTED]
DLM_RCOM_LOCK_REPLY messages need byte swapping.
Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/util.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dlm
From: Fabio M. Di Nitto [EMAIL PROTECTED]
gcc does not guarantee that a static buffer is 64bit aligned. This change
allows sparc64 to work.
Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/midcomms.c |2 +-
1 files changed, 1
start doing recovery in the presence of a many overlapping
unlock/cancel ops.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c | 37 -
1 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 43ca2a3
an error message, and could in some cases change some state, causing
problems.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |9 -
fs/dlm/member.c |4 ++--
fs/dlm/member.h |3 ++-
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/lock.c b
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of
retried, there may be other lkb's waiting on the rsb_lookup list for it
to complete. A call to confirm_master() is needed to move on to the next
waiting lkb since the current one won't be retried.
Signed-off-by: David
The dlm_put_lkb() can free the lkb and its associated ua structure,
so we can't depend on using the ua struct after the put.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/user.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/user.c b/fs/dlm/user.c
for an old message to be processed and caught
by these checks.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c | 139 ++--
1 files changed, 104 insertions(+), 35 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index c3b9fca
in their
toss list that they are the master of. These rsb's need to be included
when the resource directory is rebuilt during recovery.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dir.c | 66 +---
fs/dlm/lock.c |6 -
fs/dlm
).
This patch restricts the length of the name to the amount of data
actually passed into the call.
Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/user.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/fs
The invalid lockspace messages are normal and can appear relatively
often. They should be suppressed without debugging enabled.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm
, the infinite loop is dangerous since some other
unknown condition may appear causing the loop to never break.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index fa68e9b
From: Adrian Bunk [EMAIL PROTECTED]
This patch adds a proper prototype for some functions in
fs/dlm/dlm_internal.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dlm_internal.h | 16
fs/dlm/lock.c |1 -
fs
Non-forced unlocks should be rejected if the lock is waiting on the
rsb_lookup list for another lock to establish the master node.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/lock.c b/fs
On Sat, Nov 03, 2007 at 01:04:30AM +0100, Adrian Bunk wrote:
> This patch adds a proper prototype for some functions in
> fs/dlm/dlm_internal.h
Acked-by: David Teigland <[EMAIL PROTECTED]>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> ---
>
&
On Sat, Nov 03, 2007 at 01:04:30AM +0100, Adrian Bunk wrote:
This patch adds a proper prototype for some functions in
fs/dlm/dlm_internal.h
Acked-by: David Teigland [EMAIL PROTECTED]
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
fs/dlm/dlm_internal.h | 16
fs
On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote:
> Greetings,
>
> There's a memory leak in fs/dlm/member.c::dlm_add_member().
>
> If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then
> we'll return without freeing the memory allocated to the (at
> that point yet unused)
On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote:
Greetings,
There's a memory leak in fs/dlm/member.c::dlm_add_member().
If dlm_node_weight(ls-ls_name, nodeid) returns 0, then
we'll return without freeing the memory allocated to the (at
that point yet unused) 'memb'.
This
On Wed, Jul 04, 2007 at 11:30:08PM -0700, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [0/3] configfs: Miscellaneous cleanups
> >
> > Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
On Wed, Jul 04, 2007 at 11:30:08PM -0700, Joel Becker wrote:
On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[0/3] configfs: Miscellaneous cleanups
Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
This is
On Fri, Jun 22, 2007 at 04:06:15PM +0200, Andreas Herrmann wrote:
> Avoid kernel build error (as DLM depends on SYSFS)
>
> LD vmlinux
> fs/built-in.o: In function `dlm_lockspace_init':
> : undefined reference to `kernel_subsys'
> fs/built-in.o: In function `configfs_init':
>
On Fri, Jun 22, 2007 at 04:06:15PM +0200, Andreas Herrmann wrote:
Avoid kernel build error (as DLM depends on SYSFS)
LD vmlinux
fs/built-in.o: In function `dlm_lockspace_init':
: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
On Fri, May 04, 2007 at 09:49:45PM +0530, Satyam Sharma wrote:
> Hi,
>
> There are the following two trivially-fixed races in fs/dlm/config.c:
>
> 1. The configfs subsystem semaphore must be held by the caller when
> calling config_group_find_obj(). It's needed to walk the subsystem
>
On Fri, May 04, 2007 at 09:49:45PM +0530, Satyam Sharma wrote:
Hi,
There are the following two trivially-fixed races in fs/dlm/config.c:
1. The configfs subsystem semaphore must be held by the caller when
calling config_group_find_obj(). It's needed to walk the subsystem
hierarchy
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> +static inline void glock_put(struct gfs2_glock *gl)
> +{
> + if (atomic_read(>gl_count) == 1)
> + gfs2_glock_schedule_for_reclaim(gl);
> + gfs2_assert(gl->gl_sbd, atomic_read(>gl_count) > 0,);
> +
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
+static inline void glock_put(struct gfs2_glock *gl)
+{
+ if (atomic_read(gl-gl_count) == 1)
+ gfs2_glock_schedule_for_reclaim(gl);
+ gfs2_assert(gl-gl_sbd, atomic_read(gl-gl_count) 0,);
+
On Mon, Sep 05, 2005 at 02:19:48AM -0700, Andrew Morton wrote:
> David Teigland <[EMAIL PROTECTED]> wrote:
> > Four functions:
> > create_lockspace()
> > release_lockspace()
> > lock()
> > unlock()
>
> Neat. I'd be inclined to make them sysca
On Mon, Sep 05, 2005 at 01:54:08AM -0700, Andrew Morton wrote:
> David Teigland <[EMAIL PROTECTED]> wrote:
> >
> > We export our full dlm API through read/write/poll on a misc device.
> >
>
> inotify did that for a while, but we ended up going with a straight
On Mon, Sep 05, 2005 at 10:58:08AM +0200, J?rn Engel wrote:
> #define gfs2_assert(sdp, assertion) do { \
> if (unlikely(!(assertion))) { \
> printk(KERN_ERR "GFS2: fsid=\n", (sdp)->sd_fsname); \
> BUG();
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> +static unsigned int handle_roll(atomic_t *a)
> +{
> + int x = atomic_read(a);
> + if (x < 0) {
> + atomic_set(a, 0);
> + return 0;
> + }
> + return (unsigned int)x;
> +}
>
> this is just
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
+static unsigned int handle_roll(atomic_t *a)
+{
+ int x = atomic_read(a);
+ if (x 0) {
+ atomic_set(a, 0);
+ return 0;
+ }
+ return (unsigned int)x;
+}
this is just plain scary.
On Mon, Sep 05, 2005 at 10:58:08AM +0200, J?rn Engel wrote:
#define gfs2_assert(sdp, assertion) do { \
if (unlikely(!(assertion))) { \
printk(KERN_ERR GFS2: fsid=\n, (sdp)-sd_fsname); \
BUG();
On Mon, Sep 05, 2005 at 01:54:08AM -0700, Andrew Morton wrote:
David Teigland [EMAIL PROTECTED] wrote:
We export our full dlm API through read/write/poll on a misc device.
inotify did that for a while, but we ended up going with a straight syscall
interface.
How fat is the dlm
On Mon, Sep 05, 2005 at 02:19:48AM -0700, Andrew Morton wrote:
David Teigland [EMAIL PROTECTED] wrote:
Four functions:
create_lockspace()
release_lockspace()
lock()
unlock()
Neat. I'd be inclined to make them syscalls then. I don't suppose anyone
is likely to object if we
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> +void gfs2_glock_hold(struct gfs2_glock *gl)
> +{
> + glock_hold(gl);
> +}
>
> eh why?
You removed the comment stating exactly why, see below. If that's not a
accepted technique in the kernel, say so and I'll be happy to
On Sat, Sep 03, 2005 at 10:41:40PM -0700, Andrew Morton wrote:
> Joel Becker <[EMAIL PROTECTED]> wrote:
> >
> > > What happens when we want to add some new primitive which has no
> > > posix-file analog?
> >
> > The point of dlmfs is not to express every primitive that the
> > DLM has.
On Fri, Sep 02, 2005 at 10:28:21PM -0700, Greg KH wrote:
> On Fri, Sep 02, 2005 at 05:44:03PM +0800, David Teigland wrote:
> > On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> >
> > > + gfs2_assert(gl->gl_sbd, atomic_read(>gl_count) > 0,);
>
On Fri, Sep 02, 2005 at 10:28:21PM -0700, Greg KH wrote:
On Fri, Sep 02, 2005 at 05:44:03PM +0800, David Teigland wrote:
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
+ gfs2_assert(gl-gl_sbd, atomic_read(gl-gl_count) 0,);
what is gfs2_assert() about anyway
On Sat, Sep 03, 2005 at 10:41:40PM -0700, Andrew Morton wrote:
Joel Becker [EMAIL PROTECTED] wrote:
What happens when we want to add some new primitive which has no
posix-file analog?
The point of dlmfs is not to express every primitive that the
DLM has. dlmfs cannot
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
+void gfs2_glock_hold(struct gfs2_glock *gl)
+{
+ glock_hold(gl);
+}
eh why?
You removed the comment stating exactly why, see below. If that's not a
accepted technique in the kernel, say so and I'll be happy to change
On Sat, Sep 03, 2005 at 08:14:00AM +0200, Arjan van de Ven wrote:
> On Sat, 2005-09-03 at 13:18 +0800, David Teigland wrote:
> > On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote:
> > > Alan Cox <[EMAIL PROTECTED]> wrote:
> > > > > - Why GFS is
On Sat, Sep 03, 2005 at 08:14:00AM +0200, Arjan van de Ven wrote:
On Sat, 2005-09-03 at 13:18 +0800, David Teigland wrote:
On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote:
Alan Cox [EMAIL PROTECTED] wrote:
- Why GFS is better than OCFS2, or has functionality which OCFS2
On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote:
> Alan Cox <[EMAIL PROTECTED]> wrote:
> > > - Why GFS is better than OCFS2, or has functionality which OCFS2 cannot
> > > possibly gain (or vice versa)
> > >
> > > - Relative merits of the two offerings
> >
> > You missed the
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> + gfs2_assert(gl->gl_sbd, atomic_read(>gl_count) > 0,);
> what is gfs2_assert() about anyway? please just use BUG_ON directly
> everywhere
When a machine has many gfs file systems mounted at once it can be useful
to know
On Thu, Sep 01, 2005 at 06:56:03PM +0100, Christoph Hellwig wrote:
> Whether the gfs2 code is mergeable is a completely different question,
> and it seems at least debatable to submit a filesystem for inclusion
I actually asked what needs to be done for merging. We appreciate the
feedback and
On Thu, Sep 01, 2005 at 06:56:03PM +0100, Christoph Hellwig wrote:
Whether the gfs2 code is mergeable is a completely different question,
and it seems at least debatable to submit a filesystem for inclusion
I actually asked what needs to be done for merging. We appreciate the
feedback and are
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
+ gfs2_assert(gl-gl_sbd, atomic_read(gl-gl_count) 0,);
what is gfs2_assert() about anyway? please just use BUG_ON directly
everywhere
When a machine has many gfs file systems mounted at once it can be useful
to know which
On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote:
Alan Cox [EMAIL PROTECTED] wrote:
- Why GFS is better than OCFS2, or has functionality which OCFS2 cannot
possibly gain (or vice versa)
- Relative merits of the two offerings
You missed the important one - people
On Thu, Sep 01, 2005 at 04:19:34PM +0200, Arjan van de Ven wrote:
> > +/* Endian functions */
>
> e again why??
> Why is this a compiletime hack?
> Either you care about either-endian on disk, at which point it has to be
> a runtime thing, or you make the on disk layout fixed endian, at
Code that handles directory operations.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/dir.c | 2158 ++
fs/gfs2/dir.h | 51 +
2 files changed, 2209 insertions(
Code that manages block allocation.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/bits.c | 179 +++
fs/gfs2/bits.h | 28 +
fs/gfs2/rgrp.c | 1374 +
fs
Central header files that are widely used.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/gfs2.h | 77 +++
fs/gfs2/incore.h| 691 +++
include/linux/gfs2_ioctl.h | 3
Code that handles extended attributes and ACL's.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/acl.c | 313 ++
fs/gfs2/acl.h | 37 +
fs/gfs2/eaops.c | 179 ++
fs/gfs2/eaops.h | 30 +
fs/gfs2/ea
There are a variety of mount options, tunable parameters, internal
statistics, and methods of online file system manipulation.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/ioc
Add gfs to the build system and gfs2.txt to Documentation.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
Documentation/filesystems/gfs2.txt | 194 +
fs/Kconfig |
Code that deals with quotas.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/lvb.c | 61 ++
fs/gfs2/lvb.h | 28 +
fs/gfs2/quota.c | 1209
fs/gfs2/quota.h
A per-node on-disk log is used for recovery.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/log.c | 670 +
fs/gfs2/log.h | 68 +
fs/gfs2/recov
The lock_harness module allows a gfs file system to connect to a given
lock module.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/locking/harness/Makefile |3
fs/gfs2/locking/harness/lm_interf
The lock_dlm module uses the DLM in linux/drivers/dlm/ for inter-node
locking.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/locking/dlm/Makefile |3
fs/gfs2/locking/dlm/lock.
The lock_nolock module does no inter-node locking and allows gfs to be
used as a local file system.
Signed-off-by: Ken Preslan <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/gfs2/locking/nolock/Makefile |3
fs/gfs2/locking/nolock/mai
Hi, this is the latest set of gfs patches, it includes some minor munging
since the previous set. Andrew, could this be added to -mm? there's not
much in the way of pending changes.
http://redhat.com/~teigland/gfs2/20050901/gfs2-full.patch
http://redhat.com/~teigland/gfs2/20050901/broken-out/
Hi, this is the latest set of gfs patches, it includes some minor munging
since the previous set. Andrew, could this be added to -mm? there's not
much in the way of pending changes.
http://redhat.com/~teigland/gfs2/20050901/gfs2-full.patch
http://redhat.com/~teigland/gfs2/20050901/broken-out/
The lock_nolock module does no inter-node locking and allows gfs to be
used as a local file system.
Signed-off-by: Ken Preslan [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/gfs2/locking/nolock/Makefile |3
fs/gfs2/locking/nolock/main.c | 267
The lock_dlm module uses the DLM in linux/drivers/dlm/ for inter-node
locking.
Signed-off-by: Ken Preslan [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/gfs2/locking/dlm/Makefile |3
fs/gfs2/locking/dlm/lock.c | 533
201 - 300 of 389 matches
Mail list logo
