On 11/2/2020 11:45 PM, Alex Williamson wrote:
Thanks, Dan.
Diana, can I get an ack for this? Thanks,
Yes, sure, I apologize for not doing it earlier.
Thanks,
Diana
Alex
On Fri, 23 Oct 2020 14:34:50 +0300
Dan Carpenter wrote:
The copy_to_user() function returns the number of bytes
Hi,
The warning is fixed by this patch:
https://www.spinics.net/lists/kvm/msg227575.html
The errors are caused by the fact that the vfio fsl-mc patches have a
dependency on the fsl-mc bus series. For this particular error the
missing patch is: bus/fsl-mc: Export IRQ pool handling functions
Acked-by: Diana Craciun
On 10/23/2020 2:29 PM, Dan Carpenter wrote:
My static analsysis tool complains that the "index" can be negative.
There are some checks in do_mmap() which try to prevent underflows but
I don't know if they are sufficient for this situation. Either way,
making "index"
Acked-by: Diana Craciun
On 10/23/2020 2:34 PM, Dan Carpenter wrote:
The copy_to_user() function returns the number of bytes remaining to be
copied, but this code should return -EFAULT.
Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement VFIO_DEVICE_GET_REGION_INFO ioctl
call")
Signed-off-by: Dan
On 10/15/2020 9:52 PM, Alex Williamson wrote:
On Thu, 15 Oct 2020 13:22:26 +0100
Colin King wrote:
From: Colin Ian King
Currently the success path in function vfio_fsl_mc_reflck_attach is
returning an uninitialized value in variable ret. Fix this by setting
this to zero to indicate success.
/14/2020 1:16 AM, Stephen Rothwell wrote:
Hi Diana,
On Tue, 13 Oct 2020 18:56:07 +0300 Diana Craciun OSS
wrote:
Hi,
How does it fail? What's the error?
Sorry about that:
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c: In function
'vfio_fsl_mc_set_irq_trigger':
drivers/vfio/fsl-mc
Hi,
How does it fail? What's the error?
Thanks,
Diana
On 10/13/2020 6:07 AM, Stephen Rothwell wrote:
Hi all,
After merging the vfio tree, today's linux-next build (x86_64
allmodconfig) failed like this:
Caused by commit
cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
On 10/2/2020 11:50 PM, Alex Williamson wrote:
On Tue, 29 Sep 2020 12:03:38 +0300
Diana Craciun wrote:
The software uses a memory-mapped I/O command interface (MC portals) to
communicate with the MC hardware. This command interface is used to
discover, enumerate, configure and remove DPAA2
On 10/2/2020 8:24 PM, Alex Williamson wrote:
On Tue, 29 Sep 2020 12:03:31 +0300
Diana Craciun wrote:
The DPRC (Data Path Resource Container) device is a bus device and has
child devices attached to it. When the vfio-fsl-mc driver is probed
the DPRC is scanned and the child devices discovered
Hi Eric,
On 9/10/2020 11:20 AM, Auger Eric wrote:
Hi Diana,
On 9/7/20 4:34 PM, Diana Craciun OSS wrote:
Hi Eric,
On 9/4/2020 11:18 AM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
The software uses a memory-mapped I/O command interface (MC portals) to
communicate
Hi Eric,
On 9/3/2020 11:15 PM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
This patch adds the skeleton for interrupt support
for fsl-mc devices. The interrupts are not yet functional,
the functionality will be added by subsequent patches.
Signed-off-by: Bharat
Hi Eric,
On 9/4/2020 11:02 AM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
This patch allows to set an eventfd for fsl-mc device interrupts
and also to trigger the interrupt eventfd from userspace for testing.
All fsl-mc device interrupts are MSIs. The MSIs are
Hi Eric,
On 9/4/2020 11:21 AM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
Currently only resetting the DPRC container is supported which
will reset all the objects inside it. Resetting individual
objects is possible from the userspace by issueing commands
towards MC
Hi Eric,
On 9/3/2020 5:06 PM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
The DPRC (Data Path Resource Container) device is a bus device and has
child devices attached to it. When the vfio-fsl-mc driver is probed
the DPRC is scanned and the child devices discovered
Hi Eric,
On 9/4/2020 11:18 AM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
The software uses a memory-mapped I/O command interface (MC portals) to
communicate with the MC hardware. This command interface is used to
discover, enumerate, configure and remove DPAA2
Hi Eric,
On 9/3/2020 7:05 PM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
Allow userspace to mmap device regions for direct access of
fsl-mc devices.
Signed-off-by: Bharat Bhushan
Signed-off-by: Diana Craciun
---
drivers/vfio/fsl-mc/vfio_fsl_mc.c | 60
Hi Eric,
On 9/3/2020 5:06 PM, Auger Eric wrote:
Hi Diana,
On 8/26/20 11:33 AM, Diana Craciun wrote:
From: Bharat Bhushan
DPAA2 (Data Path Acceleration Architecture) consists in
mechanisms for processing Ethernet packets, queue management,
accelerators, etc.
The Management Complex (mc) is a
Hi Eric,
On 9/3/2020 4:40 PM, Auger Eric wrote:
The patches are dependent on some changes in the mc-bus (bus/fsl-mc)
driver. The changes were needed in order to re-use code and to export
some more functions that are needed by the VFIO driver. Currenlty the
mc-bus patches are under review:
Hi Andrew,
I apologize, I somehow missed you previous comment.
OK, I see that there are a number of drivers using the same code. In
case we share the code, probably we need to store the driver_override
value in the struct device (not in the particular driver device
structure as it is done
On 7/6/2020 4:14 PM, Laurentiu Tudor wrote:
On 7/6/2020 3:42 PM, Diana Craciun wrote:
From: Diana Craciun
The region size reported by the firmware for mc and software
portals was less than allocated by the hardware. This may be
problematic when mmapping the region in user space because the
On 6/2/2020 7:12 AM, Alex Williamson wrote:
On Fri, 8 May 2020 10:20:34 +0300
Diana Craciun wrote:
Expose to userspace information about the memory regions.
Signed-off-by: Bharat Bhushan
Signed-off-by: Diana Craciun
---
drivers/vfio/fsl-mc/vfio_fsl_mc.c | 77
On 6/2/2020 7:12 AM, Alex Williamson wrote:
On Fri, 8 May 2020 10:20:35 +0300
Diana Craciun wrote:
Allow userspace to mmap device regions for direct access of
fsl-mc devices.
Signed-off-by: Bharat Bhushan
Signed-off-by: Diana Craciun
---
drivers/vfio/fsl-mc/vfio_fsl_mc.c | 60
22 matches
Mail list logo