Re: [PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2021-03-18 Thread Ding Hui
manage), so report the problem and don't attach. Not attaching also fixes an oops which could occur if the driver tries to manage a zero component enclosure. Reported-by: Ding Hui Cc: sta...@vger.kernel.org Signed-off-by: James Bottomley --- drivers/scsi/ses.c | 5 + 1 file changed, 5 inserti

Re: [PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-29 Thread Ding Hui
On 2020/11/29 13:12, Douglas Gilbert wrote: On 2020-11-28 6:27 p.m., James Bottomley wrote: On Sat, 2020-11-28 at 20:23 +0800, Ding Hui wrote: We can get a crash when disconnecting the iSCSI session, the call trace like this:    [2a00fb70] kfree at 0830e224

[PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-28 Thread Ding Hui
ount is 0 We also need check index when use edev->component[] array in ses_enclosure_data_process Tested-by: Zeng Zhicong Cc: stable # 2.6.25+ Signed-off-by: Ding Hui --- drivers/scsi/ses.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/

[PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-06 Thread Ding Hui
nts count is 0 We also need check index when use edev->component[] array in ses_enclosure_data_process Tested-by: Zeng Zhicong Cc: stable # 2.6.25+ Signed-off-by: Ding Hui --- drivers/scsi/ses.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/

Re: [PATCH] xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed

2020-08-21 Thread Ding Hui
On 2020/8/21 4:44 下午, Mathias Nyman wrote: On 21.8.2020 10.31, Greg KH wrote: On Fri, Aug 21, 2020 at 03:06:52PM +0800, Ding Hui wrote: Some devices driver call libusb_clear_halt when target ep queue is not empty. (eg. spice client connected to qemu for usb redir) Before commit f5249461b504

[PATCH] xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed

2020-08-21 Thread Ding Hui
bit after xhci_endpoint_reset, even if it is failed. Signed-off-by: Ding Hui --- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 3c41b14ecce7..e9884ae9c77d 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/h