On 18:31 Чтв 14 Июн , Christoph Hellwig wrote:
> On Wed, Jun 13, 2007 at 05:57:59PM +0400, Dmitriy Monakhov wrote:
> > Function prerform check for signgle region, with out respect to
> > segment nature of iovec, For example writev no longer works :)
>
> Btw, could
Nick's "write_begin/write_end" patch set, and let's it
behave the same way after.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
---
drivers/block/loop.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index
Nick's write_begin/write_end patch set, and let's it
behave the same way after.
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
---
drivers/block/loop.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4bab9b1..de122f3
On 18:31 Чтв 14 Июн , Christoph Hellwig wrote:
On Wed, Jun 13, 2007 at 05:57:59PM +0400, Dmitriy Monakhov wrote:
Function prerform check for signgle region, with out respect to
segment nature of iovec, For example writev no longer works :)
Btw, could someone please start
ust typo because:
a) In fact this is 100% ENOSPC situation
b) simular function ext4_reserve_local() returns -ENOSPC
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
---
fs/ext4/balloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/ball
function ext4_reserve_local() returns -ENOSPC
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
---
fs/ext4/balloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 4d7bfd2..43ae8f8 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
On 13:43 Срд 13 Июн , Nick Piggin wrote:
> On Wed, Jun 13, 2007 at 05:40:05PM +0400, Dmitriy Monakhov wrote:
> > On 14:19 ?? 29 ?? , [EMAIL PROTECTED] wrote:
> > >
> > > The patch titled
> > > fs: introduce write_begin, write_end, and per
On 14:36 Срд 13 Июн , Hugh Dickins wrote:
> On Wed, 13 Jun 2007, Dmitriy Monakhov wrote:
>
> > loop.c code itself is not perfect. In fact before Nick's patch
> > partial write was't possible. Assumption what write chunks are
> > always page aligned is
"..., 8192}], 2) = -1 EFAULT (Bad
address)
this is hidden bug, and it was invisiable because _fault_in_readable
return value was ignored before. Lets iov_iter_fault_in_readable
perform checks for all segments.
Signed-off-by: Dmitriy Monakhov <[EMAIL
code:
ret = block_write_begin(..., pagep,...)
if (ret && *pagep != NULL) {
unlock_page(*pagep);
page_cache_release(*pagep);
}
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
diff --git
loop.c code itself is not perfect. In fact before Nick's patch
partial write was't possible. Assumption what write chunks are
always page aligned is realy weird ( see "index++" line).
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
diff --git a/driver
On 14:19 Втр 29 Май , [EMAIL PROTECTED] wrote:
>
> The patch titled
> fs: introduce write_begin, write_end, and perform_write aops
> has been added to the -mm tree. Its filename is
> fs-introduce-write_begin-write_end-and-perform_write-aops.patch
>
> *** Remember to use
On 14:19 Втр 29 Май , [EMAIL PROTECTED] wrote:
The patch titled
fs: introduce write_begin, write_end, and perform_write aops
has been added to the -mm tree. Its filename is
fs-introduce-write_begin-write_end-and-perform_write-aops.patch
*** Remember to use
loop.c code itself is not perfect. In fact before Nick's patch
partial write was't possible. Assumption what write chunks are
always page aligned is realy weird ( see index++ line).
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
diff --git a/drivers/block/loop.c b
code:
ret = block_write_begin(..., pagep,...)
if (ret *pagep != NULL) {
unlock_page(*pagep);
page_cache_release(*pagep);
}
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
diff --git a/fs/buffer.c b
-by: Dmitriy Monakhov [EMAIL PROTECTED]
diff --git a/include/linux/fs.h b/include/linux/fs.h
index fef19fc..7e025ea 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -433,7 +433,7 @@ size_t iov_iter_copy_from_user_atomic(struct page *page,
size_t iov_iter_copy_from_user(struct page *page
On 14:36 Срд 13 Июн , Hugh Dickins wrote:
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote:
loop.c code itself is not perfect. In fact before Nick's patch
partial write was't possible. Assumption what write chunks are
always page aligned is realy weird ( see index++ line
On 13:43 Срд 13 Июн , Nick Piggin wrote:
On Wed, Jun 13, 2007 at 05:40:05PM +0400, Dmitriy Monakhov wrote:
On 14:19 ?? 29 ?? , [EMAIL PROTECTED] wrote:
The patch titled
fs: introduce write_begin, write_end, and perform_write aops
has been added to the -mm tree
"Jesper Juhl" <[EMAIL PROTECTED]> writes:
> On 20/03/07, Mikael Pettersson <[EMAIL PROTECTED]> wrote:
>> On Mon, 19 Mar 2007 18:42:22 +0100, Jesper Juhl wrote:
>> > --- a/drivers/block/floppy.c
>> > +++ b/drivers/block/floppy.c
>> > @@ -4302,7 +4302,12 @@ static int __init floppy_init(void)
>> >
Jesper Juhl [EMAIL PROTECTED] writes:
On 20/03/07, Mikael Pettersson [EMAIL PROTECTED] wrote:
On Mon, 19 Mar 2007 18:42:22 +0100, Jesper Juhl wrote:
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4302,7 +4302,12 @@ static int __init floppy_init(void)
if
Where are several places where the same code used for iovec checks.
This patch just move this code to separate helper function, and replace
duplicated code with it. IMHO it is better because these are checks that
we want for all filesystems/drivers that use vectored I/O.
Signed-off-by: Dmitriy
4 20:03:38.0 +0300
Change: 2007-01-24 20:03:39.0 +0300
#fsck.ext3 -f /dev/VG/test
e2fsck 1.39 (29-May-2006)
Pass 1: Checking inodes, blocks, and sizes
Inode 14, i_size is 0, should be 56556544. Fix? yes
Pass 2: Checking directory structure
#TESTCASE_EN
1: Checking inodes, blocks, and sizes
Inode 14, i_size is 0, should be 56556544. Fixy? yes
Pass 2: Checking directory structure
#TESTCASE_END
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
---
mm/filemap.c | 24
1 files changed, 20 insertions(+), 4
Where are several places where the same code used for iovec checks.
This patch just move this code to separate helper function, and replace
duplicated code with it. IMHO it is better because these are checks that
we want for all filesystems/drivers that use vectored I/O.
Signed-off-by: Dmitriy
Jens Axboe <[EMAIL PROTECTED]> writes:
> On Wed, Mar 14 2007, Dmitriy Monakhov wrote:
>> currently if partial write has happened while ->commit_write() then page
>> wasn't marked as accessed and rebalanced.
>
> The ->commit_write() return values aren't very
Nick Piggin <[EMAIL PROTECTED]> writes:
> Index: linux-2.6/fs/splice.c
> ===
> --- linux-2.6.orig/fs/splice.c
> +++ linux-2.6/fs/splice.c
> @@ -559,7 +559,7 @@ static int pipe_to_file(struct pipe_inod
> struct address_space
Nick Piggin [EMAIL PROTECTED] writes:
Index: linux-2.6/fs/splice.c
===
--- linux-2.6.orig/fs/splice.c
+++ linux-2.6/fs/splice.c
@@ -559,7 +559,7 @@ static int pipe_to_file(struct pipe_inod
struct address_space *mapping =
Jens Axboe [EMAIL PROTECTED] writes:
On Wed, Mar 14 2007, Dmitriy Monakhov wrote:
currently if partial write has happened while -commit_write() then page
wasn't marked as accessed and rebalanced.
The -commit_write() return values aren't very well designed imho. Is
your fix correct getting
Nick Piggin <[EMAIL PROTECTED]> writes:
> Introduce write_begin, write_end, and perform_write aops.
>
> These are intended to replace prepare_write and commit_write with more
> flexible alternatives that are also able to avoid the buffered write
> deadlock problems efficiently (which
currently if partial write has happened while ->commit_write() then page
wasn't marked as accessed and rebalanced.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
diff --git a/fs/splice.c b/fs/splice.c
index 2fca6eb..bb1bf62 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -682,18 +682,25 @@
currently if partial write has happened while -commit_write() then page
wasn't marked as accessed and rebalanced.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
diff --git a/fs/splice.c b/fs/splice.c
index 2fca6eb..bb1bf62 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -682,18 +682,25 @@
Nick Piggin [EMAIL PROTECTED] writes:
Introduce write_begin, write_end, and perform_write aops.
These are intended to replace prepare_write and commit_write with more
flexible alternatives that are also able to avoid the buffered write
deadlock problems efficiently (which prepare_write is
Changes against v6:
- Handle direct_io failure inside generic_file_direct_write() as it was
recommend by Andrew (during discussion v1), and by Nick (during
discussion v6).
- change comments, make it more clear.
- one more time check what __generic_file_aio_write_nolock() always called
Changes against v6
- remove duplicated code from xfs,ntfs
- export generic_segment_checks, because it used by xfs,nfs now.
- change arguments initialization pocily according to Nick's comments.
Tested with: ltp readv/writev tests
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
Nick Piggin <[EMAIL PROTECTED]> writes:
> On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote:
>> I realy don't want to be annoying by sending this patcheset over and over
>> again. If anyone think this patch is realy cappy, please comment what
>>
Nick Piggin <[EMAIL PROTECTED]> writes:
> On Mon, Mar 12, 2007 at 11:55:30AM +0300, Dmitriy Monakhov wrote:
>> Nick Piggin <[EMAIL PROTECTED]> writes:
>>
>> > On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote:
>
>> >> @@ -2240,
Nick Piggin <[EMAIL PROTECTED]> writes:
> On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote:
>> I realy don't want to be annoying by sending this patcheset over and over
>> again, i just want the issue to be solved. If anyone think this solution
>> is
I realy don't want to be annoying by sending this patcheset over and over
again. If anyone think this patch is realy cappy, please comment what
exectly is bad. Thank you.
Changes:
- patch was split in two patches.
- comments added. I think now it is clearly describe things.
- make
I realy don't want to be annoying by sending this patcheset over and over
again, i just want the issue to be solved. If anyone think this solution
is realy cappy, please comment what exectly is bad. Thank you.
Changes:
- patch was split in two patches.
- comments added. I think now it is
Dmitriy Monakhov <[EMAIL PROTECTED]> writes:
> - ext3_dx_find_entry() exit with out setting proper error pointer
> - do_split() exit with out setting proper error pointer
>it is realy painful because many callers contain folowing code:
>de = do_split(h
Dmitriy Monakhov [EMAIL PROTECTED] writes:
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code:
de = do_split(handle,dir, bh, frame, hinfo
I realy don't want to be annoying by sending this patcheset over and over
again. If anyone think this patch is realy cappy, please comment what
exectly is bad. Thank you.
Changes:
- patch was split in two patches.
- comments added. I think now it is clearly describe things.
- make
I realy don't want to be annoying by sending this patcheset over and over
again, i just want the issue to be solved. If anyone think this solution
is realy cappy, please comment what exectly is bad. Thank you.
Changes:
- patch was split in two patches.
- comments added. I think now it is
Nick Piggin [EMAIL PROTECTED] writes:
On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote:
I realy don't want to be annoying by sending this patcheset over and over
again, i just want the issue to be solved. If anyone think this solution
is realy cappy, please comment what
Nick Piggin [EMAIL PROTECTED] writes:
On Mon, Mar 12, 2007 at 11:55:30AM +0300, Dmitriy Monakhov wrote:
Nick Piggin [EMAIL PROTECTED] writes:
On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote:
@@ -2240,6 +2241,29 @@ ssize_t generic_file_aio_write(struct kiocb *iocb
Nick Piggin [EMAIL PROTECTED] writes:
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote:
I realy don't want to be annoying by sending this patcheset over and over
again. If anyone think this patch is realy cappy, please comment what
exectly is bad. Thank you.
Doesn't seem
Changes against v6:
- Handle direct_io failure inside generic_file_direct_write() as it was
recommend by Andrew (during discussion v1), and by Nick (during
discussion v6).
- change comments, make it more clear.
- one more time check what __generic_file_aio_write_nolock() always called
Changes against v6
- remove duplicated code from xfs,ntfs
- export generic_segment_checks, because it used by xfs,nfs now.
- change arguments initialization pocily according to Nick's comments.
Tested with: ltp readv/writev tests
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/base/core.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 142c222..da73012 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -630,8
depends on: "[PATCH] driver core: fix device_add error path"
- rearrange error path sequence, in order to make it more correct.
In fact if initial sequance was doA(); doB(); doC();
we should undo it with folowing sequance undoC(); undoB(); undoA();
- handle sysfs_ops failure
This patch
Dmitriy Monakhov <[EMAIL PROTECTED]> writes:
> Greg Kroah-Hartman <[EMAIL PROTECTED]> writes:
>
>> From: James Simmons <[EMAIL PROTECTED]>
>>
>> When a device fails to register the class symlinks where not cleaned up.
>> This left a symlink in
Dmitriy Monakhov [EMAIL PROTECTED] writes:
Greg Kroah-Hartman [EMAIL PROTECTED] writes:
From: James Simmons [EMAIL PROTECTED]
When a device fails to register the class symlinks where not cleaned up.
This left a symlink in the /sys/class/device/ directory that pointed
to no where
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/base/core.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 142c222..da73012 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -630,8 +630,11
depends on: [PATCH] driver core: fix device_add error path
- rearrange error path sequence, in order to make it more correct.
In fact if initial sequance was doA(); doB(); doC();
we should undo it with folowing sequance undoC(); undoB(); undoA();
- handle sysfs_ops failure
This patch
Greg Kroah-Hartman <[EMAIL PROTECTED]> writes:
> From: James Simmons <[EMAIL PROTECTED]>
>
> When a device fails to register the class symlinks where not cleaned up.
> This left a symlink in the /sys/class/"device"/ directory that pointed
> to no where. This caused the sysfs_follow_link Oops I
- correct function name in comments
- parrent assignment does metter only inside "if" block,
so move it inside this block.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
diff --git a/lib/kobject.c b/lib/kobject.c
index b94f208..e4b477d 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@
- correct function name in comments
- parrent assignment does metter only inside if block,
so move it inside this block.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
diff --git a/lib/kobject.c b/lib/kobject.c
index b94f208..e4b477d 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@
Greg Kroah-Hartman [EMAIL PROTECTED] writes:
From: James Simmons [EMAIL PROTECTED]
When a device fails to register the class symlinks where not cleaned up.
This left a symlink in the /sys/class/device/ directory that pointed
to no where. This caused the sysfs_follow_link Oops I reported
Mimi Zohar <[EMAIL PROTECTED]> writes:
> This patch places calls to the new integrity hooks in the appropriate
> places in the fs directory. It is not meant in any way to be viewed
> as a complete set, but used as a basis for an initial discussion.
>
> Index:
Mimi Zohar [EMAIL PROTECTED] writes:
This patch places calls to the new integrity hooks in the appropriate
places in the fs directory. It is not meant in any way to be viewed
as a complete set, but used as a basis for an initial discussion.
Index:
"young dave" <[EMAIL PROTECTED]> writes:
> Hi,
> As I compile the linux-2.6.21-rc2 (gcc version 3.4.6), there's some
> warning messages:
you should probably check -mm tree may be some issues already fixed where.
>
> drivers/video/Kconfig:1622:warning: 'select' used by config symbol
> 'FB_PS3'
young dave [EMAIL PROTECTED] writes:
Hi,
As I compile the linux-2.6.21-rc2 (gcc version 3.4.6), there's some
warning messages:
you should probably check -mm tree may be some issues already fixed where.
drivers/video/Kconfig:1622:warning: 'select' used by config symbol
'FB_PS3' refer to
Andreas Dilger <[EMAIL PROTECTED]> writes:
> On Mar 04, 2007 17:18 +0300, Dmitriy Monakhov wrote:
>> - ext3_dx_find_entry() exit with out setting proper error pointer
>> - do_split() exit with out setting proper error pointer
>>it is realy painful because many ca
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code:
de = do_split(handle,dir, , frame, , );
if (!(de))
return
sb_read may return NULL, let's explicitly check it.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
diff --git a/fs/udf/super.c b/fs/udf/super.c
index f4b3265..951b85d 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1407,6 +1407,8 @@ udf_load_partition(struct super_blo
sb_read may return NULL, let's explicitly check it.
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
diff --git a/fs/udf/super.c b/fs/udf/super.c
index f4b3265..951b85d 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1407,6 +1407,8 @@ udf_load_partition(struct super_block *sb
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code:
de = do_split(handle,dir, bh, frame, hinfo, retval);
if (!(de))
Andreas Dilger [EMAIL PROTECTED] writes:
On Mar 04, 2007 17:18 +0300, Dmitriy Monakhov wrote:
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code
Dmitriy Monakhov <[EMAIL PROTECTED]> writes:
> Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index b94f208..b11f7b2 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -432,6 +432,7 @@ int kobject_move(str
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
diff --git a/lib/kobject.c b/lib/kobject.c
index b94f208..b11f7b2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -432,6 +432,7 @@ int kobject_move(struct kobject *kobj, struct kobject
*new_parent)
kobject_put(old_parent);
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
diff --git a/lib/kobject.c b/lib/kobject.c
index b94f208..b11f7b2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -432,6 +432,7 @@ int kobject_move(struct kobject *kobj, struct kobject
*new_parent)
kobject_put(old_parent);
Dmitriy Monakhov [EMAIL PROTECTED] writes:
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
diff --git a/lib/kobject.c b/lib/kobject.c
index b94f208..b11f7b2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -432,6 +432,7 @@ int kobject_move(struct kobject *kobj, struct kobject
This patch kills the "ignoring return value of 'device_create_file'"
warning message.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/block/floppy.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
This patch kills the ignoring return value of 'device_create_file'
warning message.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/block/floppy.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index
- ecryptfs_write_inode_size_to_metadata() error code was ignored.
- i_op->setxattr() must be supported by lower fs because used below.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
fs/ecryptfs/inode.c |6 +++---
fs/ecryptfs/mmap.c |3 ++-
2 files changed, 5 insertions(+),
Where are many places where _journal_stop() return code wasn't
checked. Off cause _journal_stop() failed very rarely (and usually
with fatal consequences), but this does'n meen it should not be checked.
For example most retry loops looks like follows:
ext3_journal_stop(handle);
This is updated version of patch aimed to fix direct_io error handling issue
i've previously sent 2 wheeks ago. If you don't like anything in this patch
plese let me know.
Changes:
- comments added. I think now it is clearly describe things.
- patch prepared against 2.6.20-mm2
How this patch
This is updated version of patch aimed to fix direct_io error handling issue
i've previously sent 2 wheeks ago. If you don't like anything in this patch
plese let me know.
Changes:
- comments added. I think now it is clearly describe things.
- patch prepared against 2.6.20-mm2
How this patch
- ecryptfs_write_inode_size_to_metadata() error code was ignored.
- i_op-setxattr() must be supported by lower fs because used below.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
fs/ecryptfs/inode.c |6 +++---
fs/ecryptfs/mmap.c |3 ++-
2 files changed, 5 insertions(+), 4
Where are many places where _journal_stop() return code wasn't
checked. Off cause _journal_stop() failed very rarely (and usually
with fatal consequences), but this does'n meen it should not be checked.
For example most retry loops looks like follows:
ext3_journal_stop(handle);
patch against lastest mm tree.
- Currently after path_lookup succeed we dot't have any guarantie what
it is DIR. This must be explicitly demanded.
- path_lookup can't return negative dentry, So inode check is useless.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]>
diff --gi
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/net/sk98lin/skge.c | 20 +++-
1 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
index e94ab25..eea753a 100644
--- a/drivers/net/sk98lin/skge.c
patch against lastest mm tree.
- Currently after path_lookup succeed we dot't have any guarantie what
it is DIR. This must be explicitly demanded.
- path_lookup can't return negative dentry, So inode check is useless.
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
diff --git a/fs/ecryptfs
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/net/sk98lin/skge.c | 20 +++-
1 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
index e94ab25..eea753a 100644
--- a/drivers/net/sk98lin/skge.c
+++
Monakhov Dmitriy <[EMAIL PROTECTED]> writes:
> Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
> ---
> drivers/net/pcmcia/axnet_cs.c |8 +++-
> drivers/net/pcmcia/pcnet_cs.c |8 +++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git
Monakhov Dmitriy [EMAIL PROTECTED] writes:
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/net/pcmcia/axnet_cs.c |8 +++-
drivers/net/pcmcia/pcnet_cs.c |8 +++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcmcia/axnet_cs.c
Randy Dunlap <[EMAIL PROTECTED]> writes:
> On Sat, 24 Feb 2007 00:43:18 +0300 Dmitriy Monakhov wrote:
>
>> Since commit:553c4aa630af7bc885e056d0436e4eb7f238579b
>> ata_pci_device_do_resume() can return error code, all callers was updated
>> except this one.
>>
Randy Dunlap [EMAIL PROTECTED] writes:
On Sat, 24 Feb 2007 00:43:18 +0300 Dmitriy Monakhov wrote:
Since commit:553c4aa630af7bc885e056d0436e4eb7f238579b
ata_pci_device_do_resume() can return error code, all callers was updated
except this one.
Signed-off-by: Monakhov Dmitriy [EMAIL
Dmitriy Monakhov <[EMAIL PROTECTED]> writes:
> This thread looks dead but issue was't fixed.
>
> Jiri Kosina <[EMAIL PROTECTED]> writes:
>>> > - pci_enable_device(pdev);
>>> > + ret = pci_enable_device(pdev);
>>> > + if (ret) {
>>>
Dmitriy Monakhov [EMAIL PROTECTED] writes:
This thread looks dead but issue was't fixed.
Jiri Kosina [EMAIL PROTECTED] writes:
- pci_enable_device(pdev);
+ ret = pci_enable_device(pdev);
+ if (ret) {
+ printk(KERN_ERR sk98lin: Cannot enable PCI device %s during
resume\n
This thread looks dead but issue was't fixed.
Jiri Kosina <[EMAIL PROTECTED]> writes:
>> > - pci_enable_device(pdev);
>> > + ret = pci_enable_device(pdev);
>> > + if (ret) {
>> > + printk(KERN_ERR "sk98lin: Cannot enable PCI device %s during
>> > resume\n",
>> > +
Since commit:553c4aa630af7bc885e056d0436e4eb7f238579b
ata_pci_device_do_resume() can return error code, all callers was updated
except this one.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/ata/sata_inic162x.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
Since mpt-fusion-handle-pci-layer-error-on-resume.patch
function mpt_resume() can return error code.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptscsih.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git
Handle pci_enable_device() failure while resuming, we can safely exit here.
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]>
---
drivers/net/3c59x.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 2b750bd..ea4a78f
- In fact we don't have to fail if AOP_TRUNCATED_PAGE was returned from
prepare_write or commit_write. It is beter to retry attempt where it
is possible.
- Rearange ecryptfs_get_lower_page() error handling logic, make it more clean.
Signed-off-by: Dmitriy Monakhov <[EMAIL PROTEC
Since mpt-fusion-handle-pci-layer-error-on-resume.patch
function mpt_resume() can return error code.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/message/fusion/mptscsih.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git
Since commit:553c4aa630af7bc885e056d0436e4eb7f238579b
ata_pci_device_do_resume() can return error code, all callers was updated
except this one.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/ata/sata_inic162x.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff
- In fact we don't have to fail if AOP_TRUNCATED_PAGE was returned from
prepare_write or commit_write. It is beter to retry attempt where it
is possible.
- Rearange ecryptfs_get_lower_page() error handling logic, make it more clean.
Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED]
---
fs
Handle pci_enable_device() failure while resuming, we can safely exit here.
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED]
---
drivers/net/3c59x.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 2b750bd..ea4a78f
This thread looks dead but issue was't fixed.
Jiri Kosina [EMAIL PROTECTED] writes:
- pci_enable_device(pdev);
+ ret = pci_enable_device(pdev);
+ if (ret) {
+ printk(KERN_ERR sk98lin: Cannot enable PCI device %s during
resume\n,
+ dev-name);
+
1 - 100 of 194 matches
Mail list logo
