Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of pci_dma_supported

On Wed, 2015-11-11 at 12:58 +0100, Christoph Hellwig wrote: > Can you try the patch below? Acked-by: Don Fry -- Since pci_set_dma_mask() returns the opposite of pci_dma_supported(), this fix is required for proper operation. The original patch in October was faulty. > > diff --git

Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask

as not good enough. I missed that pci_dma_supported returns 1 on success and pci_set_dma_mask returns 0 on success. The original patch needs to have the ! removed as Geliang Tang points out. Acked-by: Don Fry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported

ertion(+), 1 deletion(-) > Acked-by: Don Fry > diff --git a/drivers/net/ethernet/amd/pcnet32.c > b/drivers/net/ethernet/amd/pcnet32.c > index bc8b04f..e2afabf 100644 > --- a/drivers/net/ethernet/amd/pcnet32.c > +++ b/drivers/net/ethernet/amd/pcnet32.c > @@ -1500,7 +1500,7

Re: [PATCH] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}

One little change to the comment is needed. See below Don On Wed, 2015-03-18 at 20:10 +, Markos Chandras wrote: > On a MIPS Malta board, tons of fifo underflow errors have been observed > when using u-boot as bootloader instead of YAMON. The reason for that > is that YAMON used to set the pc

Re: [PATCH net-next 02/14] ethernet: Use eth__addr instead of memset

On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: > Use the built-in function instead of memset. > > Signed-off-by: Joe Perches Acked-by: Don Fry for pcnet32.c > --- > drivers/net/ethernet/amd/pcnet32.c | 2 +- > drivers/net/ethernet/broadcom/bnx2x/b

Re: [PATCH] amd: Neaten and remove unnecessary OOM messages

t_device > *dev, > dma_addr_t *new_dma_addr_list; Acked-By: Don Fry > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH V2 08/22] amd: Use pci_zalloc_consistent

On Mon, 2014-06-23 at 14:05 -0700, Joe Perches wrote: > Remove the now unnecessary memset too. > > Signed-off-by: Joe Perches > --- > On Mon, 2014-06-23 at 12:15 -0700, Joe Perches wrote: > > On Mon, 2014-06-23 at 11:02 -0700, Don Fry wrote: > > > This causes the

Re: [PATCH 08/22] amd: Use pci_zalloc_consistent

On Mon, 2014-06-23 at 06:41 -0700, Joe Perches wrote: > Remove the now unnecessary memset too. > > Signed-off-by: Joe Perches > --- > drivers/net/ethernet/amd/pcnet32.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/amd/pcnet32.c

Re: Strange soft lockup detected message (looks like spin_lock bug in pcnet32)

All instances of obtaining the lock in pcnet32 are done as spin_lock_irqsave except the interrupt handler itself. The interrupt mask needs to be saved everywhere else, but the interrupt handler is known not to need to save the flags. If the lock is held and the same CPU tries to get the lock agai