Re: [PATCH v4 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-08-07 Thread Dong Aisheng
On Fri, Aug 07, 2015 at 05:53:01PM +0800, Chen Haibo-B51421 wrote: > > > > -Original Message- > > From: Dong Aisheng [mailto:aisheng.d...@freescale.com] > > Sent: Friday, August 07, 2015 3:39 PM > > To: Chen Haibo-B51421 > > Cc: robh...@kerne

Re: [PATCH v4 6/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1

2015-08-07 Thread Dong Aisheng
gth Other than that, this patch looks good to me. Regards Dong Aisheng > Signed-off-by: Haibo Chen > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c > b/drivers/mmc/

Re: [PATCH v4 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support

2015-08-07 Thread Dong Aisheng
t;boarddata.tuning_step) > + tuning_ctrl |= > imx_data->boarddata.tuning_step << ESDHC_TUNING_STEP_SHIFT; > + writel(tuning_ctrl, host->ioaddr + > ESDHC_TUNING_CTRL); Is there a code indent i

Re: [PATCH v4 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-08-07 Thread Dong Aisheng
@@ static void esdhc_set_uhs_signaling(struct sdhci_host > *host, unsigned timing) > case MMC_TIMING_UHS_SDR25: > case MMC_TIMING_UHS_SDR50: > case MMC_TIMING_UHS_SDR104: > + break; > case MMC_TIMING_MMC_HS200: > +

Re: [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-08-05 Thread Dong Aisheng
On Wed, Aug 05, 2015 at 03:39:29PM +0800, Chen Haibo-B51421 wrote: > > > > -Original Message- > > From: Dong Aisheng [mailto:aisheng.d...@freescale.com] > > Sent: Monday, August 03, 2015 8:10 PM > > To: Chen Haibo-B51421 > > Cc: robh...@kerne

Re: [PATCH V3 0/5] clk: support clocks which requires parent clock on during operation

2015-08-04 Thread Dong Aisheng
On Tue, Jul 28, 2015 at 10:38:25PM +0800, Dong Aisheng wrote: > On Tue, Jul 28, 2015 at 09:19:40PM +0800, Dong Aisheng wrote: > > This patch series adds support in clock framework for clocks which > > operations > > requires its parent clock is on. > > > > Su

Re: [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-08-03 Thread Dong Aisheng
esdhc_soc_data { > u32 flags; > @@ -156,6 +169,12 @@ static struct esdhc_soc_data usdhc_imx6sx_data = { > | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200, > }; > > +static struct esdhc_soc_data usdhc_imx7d_data = { > + .flags = ESDHC_FLAG_USDHC |

Re: [PATCH v3 6/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1

2015-08-03 Thread Dong Aisheng
On Mon, Aug 03, 2015 at 09:08:28AM +0800, Chen Haibo-B51421 wrote: > > > > -Original Message- > > From: Dong Aisheng [mailto:aisheng.d...@freescale.com] > > Sent: Friday, July 31, 2015 10:58 PM > > To: Chen Haibo-B51421 > > Cc: robh...@kernel.org; pawe

Re: [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-08-03 Thread Dong Aisheng
On Sun, Aug 02, 2015 at 04:59:04PM +0800, Chen Haibo-B51421 wrote: > > > > -Original Message- > > From: Dong Aisheng [mailto:aisheng.d...@freescale.com] > > Sent: Friday, July 31, 2015 10:15 PM > > To: Chen Haibo-B51421 > > Cc: robh...@kernel.org; pawe

Re: [PATCH v3 5/6] mmc: sdhci-esdhc-imx: config watermark level and burst length

2015-08-03 Thread Dong Aisheng
On Fri, Jul 31, 2015 at 04:13:45PM +0100, Russell King - ARM Linux wrote: > On Fri, Jul 31, 2015 at 10:51:41PM +0800, Dong Aisheng wrote: > > On Wed, Jul 29, 2015 at 05:03:56PM +0800, Haibo Chen wrote: > > > i.MX7D support eMMC HS400 mode, this mode can run in 8 bit,200MHZ > &

Re: [PATCH v3 6/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1

2015-07-31 Thread Dong Aisheng
* zero if this usdhc is choosed to boot system. Change it > + * back here, otherwise it will impact the performance a > + * lot if the burst length is 16. Can you clarify a bit more on why performance drops a lot if burst length is 16? Caused by the b

Re: [PATCH v3 5/6] mmc: sdhci-esdhc-imx: config watermark level and burst length

2015-07-31 Thread Dong Aisheng
+ writel(0x10401040, host->ioaddr + ESDHC_WTMK_LVL); > + else > + writel(0x08100810, host->ioaddr + ESDHC_WTMK_LVL); > + > host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN; > host->mmc->caps |= MMC_CAP_

Re: [PATCH v3 5/6] mmc: sdhci-esdhc-imx: config watermark level and burst length

2015-07-31 Thread Dong Aisheng
ctually for mx7d: mmc: sdhci-esdhc-imx: change watermark level and burst length for imx7d Regards Dong Aisheng > Signed-off-by: Haibo Chen > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/

Re: [PATCH v3 3/6] ARM: dts: imx7d-sdb: add eMMC5.0 support

2015-07-31 Thread Dong Aisheng
On Wed, Jul 29, 2015 at 05:03:54PM +0800, Haibo Chen wrote: > imx7d-sdb board has a eMMC5.0 on usdhc3. This eMMC support HS400. > This patch add usdhc3 support for HS400 > It seems this patch should be after [PATCH v3 4/6] mmc: sdhci-esdhc-imx: add compatible string in bingding doc Reg

Re: [PATCH v3 4/6] mmc: sdhci-esdhc-imx: add compatible string in bingding doc

2015-07-31 Thread Dong Aisheng
in about this property for better understanding: e.g. The uSDHC is using one delay cell as default increasing step to do tuning process. This property allows user to change the tuning step to more than one delay cells which is useful for some special boards or cards when the default tuning step ca

Re: [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400

2015-07-31 Thread Dong Aisheng
+ host->ioaddr + ESDHC_MIX_CTRL); > + imx_data->is_ddr = 1; > + if (host->clock == 2) I can't remember, but could this be a range required by SoC? > + esdhc_set_strobe_dll(host); > + break; &

Re: [PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support

2015-07-30 Thread Dong Aisheng
scription, the correct tuning-step value only depends on the > SoC. Why not derive it from the compatible string? > 'tuning-step' actually depends on board and card. The commit message should be reformed a bit. Regards Dong Aisheng > Regards, > Jan Lübbe > -- > Pen

Re: [PATCH v3 0/6] mmc: imx: a few fixes and new feature

2015-07-29 Thread Dong Aisheng
view it ASAP, maybe can do it tomorrow. Regards Dong Aisheng > .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 2 + > arch/arm/boot/dts/imx7d-sdb.dts| 13 +++ > drivers/mmc/host/sdhci-esdhc-imx.c | 97 > +- > include/l

Re: [PATCH V3 0/5] clk: support clocks which requires parent clock on during operation

2015-07-28 Thread Dong Aisheng
On Tue, Jul 28, 2015 at 09:19:40PM +0800, Dong Aisheng wrote: > This patch series adds support in clock framework for clocks which operations > requires its parent clock is on. > > Such clock type is initially met on Freescale i.MX7D platform that all clocks > operations, including

[PATCH 1/4] clk: imx: move imx_clk_gate_x into one place

2015-07-28 Thread Dong Aisheng
move imx_clk_gate_x api into one place for better code maintenance. Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index 1049b0c..cda8756

[PATCH V3 5/5] clk: core: add CLK_OPS_PARENT_ON flags to support clocks require parent on

2015-07-28 Thread Dong Aisheng
the operation. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index cf31dc4..93eb9e3 100644 --- a

[PATCH 4/4] clk: imx7d: only enable minimum required clocks

2015-07-28 Thread Dong Aisheng
imum clocks are already enabled. Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk-imx7d.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index 8b0b023..dc54622 100644 --- a/drivers/clk/imx/clk-imx7d.

[PATCH 3/4] clk: imx7d: using api with flag CLK_OPS_PARENT_ON

2015-07-28 Thread Dong Aisheng
i.MX7D requires all clocks operations including enable/disable, rate change and re-parent with its parent clock on. Changing to the correct APIs to tell clk core such requirement. Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk-imx7d.c | 712 ++-- 1

[PATCH 2/4] clk: imx: add clk api for supporting clk_OPS_PARENT_ON clocks

2015-07-28 Thread Dong Aisheng
Some IMX SoC like i.MX7D requires using clk_OPS_PARENT_ON flags, adding the corresponding clock APIs variants for easy use. Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk.h | 32 1 file changed, 32 insertions(+) diff --git a/drivers/clk/imx/clk.h b/drivers

[PATCH 0/4] clk: imx7d: switch to clk api with CLK_OPS_PARENT_ON enabled

2015-07-28 Thread Dong Aisheng
clock on during operation http://www.spinics.net/lists/arm-kernel/msg435136.html Dong Aisheng (4): clk: imx: move imx_clk_gate_x into one place clk: imx: add clk api for supporting clk_OPS_PARENT_ON clocks clk: imx7d: using api with flag CLK_OPS_PARENT_ON clk: imx7d: only enable minimum req

[PATCH V3 3/5] clk: move clk_disable_unused after clk_core_disable_unprepare function

2015-07-28 Thread Dong Aisheng
Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 196 +++--- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index c2310d5..ac158c4 100644 --- a/drivers/clk/clk.c +++ b/drivers

[PATCH V3 4/5] clk: core: add CLK_OPS_PARENT_ON flags to support clocks require parent on

2015-07-28 Thread Dong Aisheng
e Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c| 5 + include/linux/clk-provider.h | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index ac158c4..cf31dc4 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -

[PATCH V3 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-28 Thread Dong Aisheng
__clk_set_parent_after() actually used the second argument then we could put this duplicate logic in there and call it with a different order of arguments in the success vs. error paths in this function. Cc: Mike Turquette Cc: Stephen Boyd Suggested-by: Stephen Boyd Signed-off-by: Dong Aisheng

[PATCH V3 0/5] clk: support clocks which requires parent clock on during operation

2015-07-28 Thread Dong Aisheng
and easily read Dong Aisheng (5): clk: remove duplicated code with __clk_set_parent_after clk: introduce clk_core_enable_lock and clk_core_disable_lock functions clk: move clk_disable_unused after clk_core_disable_unprepare function clk: core: add CLK_OPS_PARENT_ON flags to suppor

[PATCH V3 2/5] clk: introduce clk_core_enable_lock and clk_core_disable_lock functions

2015-07-28 Thread Dong Aisheng
sable a bit. As well as clk_core_{enable|disable}_lock, we also added clk_core_{prepare|unprepare}_lock and clk_core_prepare_enable/ clk_core_unprepare_disable for clock core to easily use. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-23 Thread Dong Aisheng
On Thu, Jul 23, 2015 at 05:11:35PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-07-22 07:08:10) > > Ping... > > > > On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > > > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-22 Thread Dong Aisheng
Ping... On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > > Hi Mike, > > > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > > Quoting Don

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-15 Thread Dong Aisheng
On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > Hi Mike, > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > __clk_set_parent_after() actually used the second argument then we > &

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-15 Thread Dong Aisheng
Hi Mike, On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > orde

Re: [PATCH] drivers: mmc: sdhci: update max frequency only if undefined

2015-06-18 Thread Dong Aisheng
obably not going to work properly. mmc->f_max will be overwritten again if host->clk_mul enabled. And you did not do sanity check if f_max from device tree is valid. Please see: http://www.spinics.net/lists/arm-kernel/msg426167.html I already sent a proper fix. Regards Dong Aisheng &g

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-05-28 Thread Dong Aisheng
On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > order of argume

Re: [PATCH v3 1/2] mmc: sdhci: fix abort due to missing runtime PM

2015-05-27 Thread Dong Aisheng
+257,41 @@ const struct dev_pm_ops sdhci_pltfm_pmops = { > .resume = sdhci_pltfm_resume, > }; > EXPORT_SYMBOL_GPL(sdhci_pltfm_pmops); > + > +int sdhci_pltfm_rpm_suspend(struct device *dev) Why invent a new API? Can't put into sdhci_p

Re: [PATCH v2 0/5] clk: support clocks which requires parent clock on during operation

2015-05-20 Thread Dong Aisheng
Hi Stephen, On Thu, May 14, 2015 at 09:28:58PM +0800, Dong Aisheng wrote: > This patch series adds support in clock framework for clocks which operations > requires its parent clock is on. > > Such clock type is initially met on Freescale i.MX7D platform that all clocks > operat

[PATCH v2 5/5] clk: core: add CLK_OPS_PARENT_ON flags to support clocks require parent on

2015-05-14 Thread Dong Aisheng
the operation. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 44a2f55..348f371 100644 --- a

[PATCH v2 2/5] clk: introduce clk_core_enable_lock and clk_core_disable_lock functions

2015-05-14 Thread Dong Aisheng
sable a bit. As well as clk_core_{enable|disable}_lock, we also added clk_core_{prepare|unprepare}_lock and clk_core_prepare_enable/ clk_core_unprepare_disable for clock core to easily use. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c

[PATCH v2 3/5] clk: move clk_disable_unused after clk_core_disable_unprepare function

2015-05-14 Thread Dong Aisheng
Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 196 +++--- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2f44c8c..597d6d2 100644 --- a/drivers/clk/clk.c +++ b/drivers

[PATCH v2 4/5] clk: core: add CLK_OPS_PARENT_ON flags to support clocks require parent on

2015-05-14 Thread Dong Aisheng
e Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c| 5 + include/linux/clk-provider.h | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 597d6d2..44a2f55 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -

[PATCH v2 0/5] clk: support clocks which requires parent clock on during operation

2015-05-14 Thread Dong Aisheng
1->v2: Mainly addressed Stephen Boyd's comments * remove dupliciated code with __clk_set_parent_after * introduce more clk_core_x APIs for core easily use * move clk_disable_unused code position * use clk_core_x API to make code more clean and easily read Dong Aisheng (5): clk: remove du

[PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-05-14 Thread Dong Aisheng
__clk_set_parent_after() actually used the second argument then we could put this duplicate logic in there and call it with a different order of arguments in the success vs. error paths in this function. Cc: Mike Turquette Cc: Stephen Boyd Suggested-by: Stephen Boyd Signed-off-by: Dong Aisheng

Re: [PATCH RFC v1 2/5] clk: add missing lock when call clk_core_enable in clk_set_parent

2015-05-13 Thread Dong Aisheng
On Wed, May 06, 2015 at 05:01:54PM -0700, Stephen Boyd wrote: > On 05/04, Dong Aisheng wrote: > > On Thu, Apr 30, 2015 at 12:07:47PM -0700, Stephen Boyd wrote: > > > On 04/15/15 07:26, Dong Aisheng wrote: > > > > clk_core_enable is executed without &enable_clock i

Re: [PATCH RFC v1 4/5] clk: core: add CLK_SET_PARENT_ON flags to support clocks require parent on

2015-05-13 Thread Dong Aisheng
On Wed, May 06, 2015 at 04:34:47PM -0700, Stephen Boyd wrote: > On 05/04, Dong Aisheng wrote: > > On Thu, Apr 30, 2015 at 06:09:38PM -0700, Stephen Boyd wrote: > > > On 04/15, Dong Aisheng wrote: > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > &g

Re: [PATCH RFC v1 5/5] clk: introduce clk_core_enable_lock and clk_core_disable_lock functions

2015-05-04 Thread Dong Aisheng
On Thu, Apr 30, 2015 at 06:10:43PM -0700, Stephen Boyd wrote: > On 04/15, Dong Aisheng wrote: > > This can be usefully when clock core wants to enable/disable clocks. > > Then we don't have to convert the struct clk_core to struct clk to call > > clk_enable/clk_disable wh

Re: [PATCH RFC v1 4/5] clk: core: add CLK_SET_PARENT_ON flags to support clocks require parent on

2015-05-04 Thread Dong Aisheng
On Thu, Apr 30, 2015 at 06:09:38PM -0700, Stephen Boyd wrote: > On 04/15, Dong Aisheng wrote: > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index 7af553d..f2470e5 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -43,6 +43,11 @@ sta

Re: [PATCH RFC v1 2/5] clk: add missing lock when call clk_core_enable in clk_set_parent

2015-05-04 Thread Dong Aisheng
On Thu, Apr 30, 2015 at 12:07:47PM -0700, Stephen Boyd wrote: > On 04/15/15 07:26, Dong Aisheng wrote: > > clk_core_enable is executed without &enable_clock in clk_set_parent > > function. > > Adding it to avoid potential race condition issue. > > > > Fi

Re: [PATCH RFC v1 3/5] clk: remove unneeded __clk_enable and __clk_disable

2015-05-04 Thread Dong Aisheng
On Thu, Apr 30, 2015 at 03:05:48PM -0700, Stephen Boyd wrote: > On 04/30, Stephen Boyd wrote: > > On 04/15/15 07:26, Dong Aisheng wrote: > > > The only thing __clk_enable/__clk_disable does is NULL pointer checking > > > of clk except calling clk_core_{enable|disabl

Re: [PATCH RFC v1 1/5] clk: change clk_core name of __clk_set_parent_after

2015-05-04 Thread Dong Aisheng
On Thu, Apr 30, 2015 at 12:06:13PM -0700, Stephen Boyd wrote: > On 04/15/15 07:26, Dong Aisheng wrote: > > To align with __clk_set_parent_before and some others functions, > > change the host clk name to 'clk' instead of 'core'. > > > > Cc: Mike Tur

Re: [PATCH RFC v1 0/5] clk: support clocks which requires parent clock on during operation

2015-04-29 Thread Dong Aisheng
Hi Guys, On Wed, Apr 22, 2015 at 02:12:43PM +0800, Dong Aisheng wrote: > On Wed, Apr 15, 2015 at 10:26:34PM +0800, Dong Aisheng wrote: > > This patch series adds support in clock framework for clocks which > > operations > > requires its parent clock is on. > > >

Re: Broadcom 43340 module on iMX6DL

2015-04-26 Thread Dong Aisheng
ver to skip changing the clock?. > > Or any work around for the problem?. > It is a feature implemented by MMC core that re-try a slower clock when enumerate fails. See: drivers/mmc/core/core.c mmc_claim_host(host); for (i = 0; i < ARRAY_SIZE(freqs); i++) { if (!mmc_rescan_t

Re: Broadcom 43340 module on iMX6DL

2015-04-26 Thread Dong Aisheng
; One simple question: Does the brcmfmac driver in upstream kernel also work? I mean this one: drivers/net/wireless/brcm80211 Regards Dong Aisheng > Regards, > Arend > > >Regards, > > > >John > > > > > >On Fri, Apr 24, 2015 at 11:14 AM, Arend van Sp

Re: Broadcom 43340 module on iMX6DL

2015-04-26 Thread Dong Aisheng
t; Freescale does not provide Broadcom driver currently. It might provide it for MX7D release in the future due to MX7D SDB board integrated a Broadcom WiFi chip. But it depends on whether the SLA signed with Broadcom can be ready before the release. Regards Dong Aisheng > Regards, > Arend

Re: [RFC] i.MX25/35/SDHCI: switch off DMA usage

2015-04-22 Thread Dong Aisheng
On Tue, Apr 14, 2015 at 11:42:00AM +0200, Juergen Borleis wrote: > Hi, > > On Friday 27 March 2015 12:44:03 Dong Aisheng wrote: > > On Fri, Mar 27, 2015 at 11:52:04AM +0100, Juergen Borleis wrote: > > > DMA and the required overhead on very small data blocks seems an &

Re: [PATCH RFC v1 0/5] clk: support clocks which requires parent clock on during operation

2015-04-21 Thread Dong Aisheng
On Wed, Apr 15, 2015 at 10:26:34PM +0800, Dong Aisheng wrote: > This patch series adds support in clock framework for clocks which operations > requires its parent clock is on. > > Such clock type is initially met on Freescale i.MX7D platform that all clocks > operations, including

[PATCH RFC v1 0/5] clk: support clocks which requires parent clock on during operation

2015-04-15 Thread Dong Aisheng
d of introducing clk_core_enable_lock and clk_core_disable_lock to easily use and reduce duplicated code. It can be merged into patch 4 if required. The patch series is based on for-next branch of Michael's git: git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git Dong A

[PATCH RFC v1 2/5] clk: add missing lock when call clk_core_enable in clk_set_parent

2015-04-15 Thread Dong Aisheng
clk_core_enable is executed without &enable_clock in clk_set_parent function. Adding it to avoid potential race condition issue. Fixes: 035a61c314eb ("clk: Make clk API return per-user struct clk instances") Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- dri

[PATCH RFC v1 4/5] clk: core: add CLK_SET_PARENT_ON flags to support clocks require parent on

2015-04-15 Thread Dong Aisheng
clock firstly for each operation and disable it later after operation complete. The most special case is for set_parent() operation which requires both parent, old one and new one, to be enabled at the same time during the operation. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng

[PATCH RFC v1 1/5] clk: change clk_core name of __clk_set_parent_after

2015-04-15 Thread Dong Aisheng
To align with __clk_set_parent_before and some others functions, change the host clk name to 'clk' instead of 'core'. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/clk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH RFC v1 5/5] clk: introduce clk_core_enable_lock and clk_core_disable_lock functions

2015-04-15 Thread Dong Aisheng
This can be usefully when clock core wants to enable/disable clocks. Then we don't have to convert the struct clk_core to struct clk to call clk_enable/clk_disable which is a bit un-align with exist using. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk/

[PATCH RFC v1 3/5] clk: remove unneeded __clk_enable and __clk_disable

2015-04-15 Thread Dong Aisheng
The only thing __clk_enable/__clk_disable does is NULL pointer checking of clk except calling clk_core_{enable|disable} which is already handled by clk_core_{enable|disable}. So remove this unneeded function. Cc: Mike Turquette Cc: Stephen Boyd Signed-off-by: Dong Aisheng --- drivers/clk

Re: [RFC] i.MX25/35/SDHCI: switch off DMA usage

2015-03-27 Thread Dong Aisheng
sp/doc/errata/IMX35CE.pdf I could double check with our IC guys to confirm it. Regards Dong Aisheng > --- > drivers/mmc/host/sdhci-esdhc-imx.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c > b/drivers/mmc/

Re: WARNING: at fs/fs-writeback.c when plug out SD card after system suspend/resume

2014-12-04 Thread Dong Aisheng
On Thu, Dec 04, 2014 at 01:41:39PM +0100, Jan Kara wrote: > On Thu 04-12-14 11:43:17, Dong Aisheng wrote: > > Hi ALL, > > > > We met an filesystem issue when do stable kernel upgrade from 3.10.31 to > > 3.10.53. And we found it's caused by the following commit b

WARNING: at fs/fs-writeback.c when plug out SD card after system suspend/resume

2014-12-03 Thread Dong Aisheng
hing work. Fixes: 839a8e8660b6777e7fe4e80af1a048aebe2b5977 Reviewed-by: Tejun Heo Signed-off-by: Jan Kara Cc: Derek Basehore Cc: Jens Axboe Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman Regards Dong A

WARNING: at fs/fs-writeback.c when plug out SD card after system suspend/resume

2014-12-03 Thread Dong Aisheng
hing work. Fixes: 839a8e8660b6777e7fe4e80af1a048aebe2b5977 Reviewed-by: Tejun Heo Signed-off-by: Jan Kara Cc: Derek Basehore Cc: Jens Axboe Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman Regards Dong A

Re: [PATCH v5] mfd: syscon: Decouple syscon interface from platform devices

2014-09-22 Thread Dong Aisheng
it */ > + pdev = of_find_device_by_node(np); > + if (!pdev) { > + /* for early users create dummy syscon device and use it */ > + pdev = platform_device_alloc("dummy-syscon", -1); Can we create specific devices for each sysc

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread Dong Aisheng
t; Before it, we may not be able to get it's device, isn't it? > > > > Yes, right. > > For this case, we'd better create the pdev or dev manually for the first time > We use it, right ? Yes, that's my understanding. Regards Dong Aisheng >

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread Dong Aisheng
hild: /dcsr@2000/dcsr-etm@37c000 >create child: /dcsr@2000/dcsr-hugorom@3a >create child: /dcsr@2000/dcsr-etf@3a1000 >create child: /dcsr@2000/dcsr-etr@3a3000 >create child: /dcsr@2000/dcsr-cti@3a4000 >create child: /dcsr@2000/dcsr

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread Dong Aisheng
On Thu, Sep 18, 2014 at 03:06:59PM +0530, Pankaj Dubey wrote: > Hi, > > On September 18, 2014 1:26, Dong Aisheng wrote > > On Thu, Sep 18, 2014 at 11:33:26AM +0530, Pankaj Dubey wrote: > > > Hi, > > > > > > Adding CC to Xiubo Li, Geert Uytterhoeven a

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread Dong Aisheng
On Thu, Sep 18, 2014 at 11:33:26AM +0530, Pankaj Dubey wrote: > Hi, > > Adding CC to Xiubo Li, Geert Uytterhoeven and Stephen Warren. > > On Thursday, September 18, 2014, Dong Aisheng wrote, > > On Wed, Sep 17, 2014 at 04:50:50PM +0530, Pankaj Dubey wrote: > > >

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-17 Thread Dong Aisheng
On Thu, Sep 18, 2014 at 08:59:32AM +0530, Pankaj Dubey wrote: > +CC: Dong Aisheng > > Hi Arnd, > > On Wednesday, September 17, 2014, Arnd Bergmann wrote, > > > V2 of this patchset and related discussion can be found here [1]. > > > > > > Changes sin

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-17 Thread Dong Aisheng
On Wed, Sep 17, 2014 at 04:50:50PM +0530, Pankaj Dubey wrote: > Hi, > > On Wednesday, September 17, 2014, Dong Aisheng Wrote, > > > > > > +static struct syscon *of_syscon_register(struct device_node *np) { > > > + struct syscon *syscon; > > > + stru

Re: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-17 Thread Dong Aisheng
.val_bits = 32, > .reg_stride = 4, > }; > > +static struct syscon *of_syscon_register(struct device_node *np) > +{ > + struct syscon *syscon; > + struct regmap *regmap; > + void __iomem *base; > + > + if (!of_device_is_compatible(np, "sys

Re: [PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-02 Thread Dong Aisheng
of_parse. And since sdhci-esdhc-imx is not using mmc_of_parse currently, maybe it's time to convert to it. Regards Dong Aisheng > > *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers > line > polarity properties, we have to fix the meaning of the "norm

Re: ARM,sdhci_esdhc_imx: INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected

2014-01-07 Thread Dong Aisheng
t; > > Thanks. That fixed the problem. Will that go to 3.13 final ? > > > > That's a question for Chris. > > It seems that it has now been superseded by > http://thread.gmane.org/gmane.linux.kernel.mmc/24371 > > Will those ones go in 3.13-rc8 and final ?

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Dong Aisheng
On Mon, Jan 6, 2014 at 2:46 PM, Shawn Guo wrote: > On Mon, Jan 06, 2014 at 02:30:00PM +0800, Dong Aisheng wrote: >> Hi Shawn, >> >> How do you suggest to fix this issue? >> Can we cook a patch for it directly based on linux-next tree? > > No, we can not. No pat

Re: linux-next: build failure after merge of the mmc tree

2014-01-05 Thread Dong Aisheng
Hi Shawn, How do you suggest to fix this issue? Can we cook a patch for it directly based on linux-next tree? Regards Dong Aisheng On Mon, Jan 6, 2014 at 2:22 PM, Stephen Rothwell wrote: > Hi all, > > On Tue, 17 Dec 2013 16:06:19 +0800 Dong Aisheng wrote: >> >> I tested

Re: [RFC/PATCH 0/2] mmc: sdhci: Workaround Intel Merrifield issue for HS200

2013-12-19 Thread Dong Aisheng
On Fri, Dec 20, 2013 at 11:25 AM, David Cohen wrote: > On Fri, Dec 20, 2013 at 11:00:23AM +0800, Dong Aisheng wrote: >> On Wed, Nov 13, 2013 at 5:49 AM, David Cohen >> wrote: >> > On 10/29/2013 10:58 AM, David Cohen wrote: >> >> >> >> Hi, >>

Re: [RFC/PATCH 0/2] mmc: sdhci: Workaround Intel Merrifield issue for HS200

2013-12-19 Thread Dong Aisheng
gt; Is it acceptable to have the quirk I'm proposing to workaround the issue? > > > Ping. Any comments here? > Chris, Can you pick this one? IMX also needs this quirk for imx6q/dl since it can not meet HS200 timing requirement. David, Is the unkonwn hw issue in your patch #2

Re: linux-next: build failure after merge of the mmc tree

2013-12-17 Thread Dong Aisheng
I tested that Chris tree does not have problem. It's caused by IMX tree updates. Chris, Is the way Shawn suggested OK for you? Regards Dong Aisheng On Tue, Dec 17, 2013 at 11:16 AM, Shawn Guo wrote: > Hi Chris, > > Please drop fc4fafac9656 ("ARM: dts: sabresd: add usdhc4 su

Re: linux-next: build failure after merge of the mmc tree

2013-12-16 Thread Dong Aisheng
Hi Stephen, Sorry, i just see this mail. It seems the imx pinctrl dt binding has changes since Chris pick my patch. I will fix it ASAP. Regards Dong Aisheng On Tue, Dec 17, 2013 at 10:28 AM, Stephen Rothwell wrote: > Hi Chris, > > ping? > > On Fri, 13 Dec 2013 12:57:16 +1100 S

Re: [PATCH] Avoid needless loop in sdhci_irq()

2013-11-05 Thread Dong Aisheng
t; and doing nothing. > > Signed-off-by: Alexey Neyman You need improve the patch title a bit, like: mmc: sdhci: avoid needless loop for handle SDIO interrupts in sdhci_irq Otherwise, Acked-by: Dong Aisheng You could resend with my ack. Regards Dong Aisheng > --- > driv

Re: Avoid needless loop in sdhci_irq() for Card Interrupt

2013-11-04 Thread Dong Aisheng
-by: Alexey Neyman I also noticed this issue. Your fix looks correct to me. But as following community working way, you need send out patches formerly, not attach a diff file. You can refer to 'git send-email' or try with gmail. BTW, please enrich your patch commit message. Regards Dong

Re: [PATCH 0/3] of: add update device node status via cmdline feature

2013-08-23 Thread Dong Aisheng
On Fri, Aug 23, 2013 at 03:51:07PM +0800, Shawn Guo wrote: > The device tree mailing list is changed to devicet...@vger.kernel.org. > > On Fri, Aug 23, 2013 at 03:09:08PM +0800, Dong Aisheng wrote: > > I tried the uboot way with fdt command to change the node status, it can > &

Re: [PATCH 0/3] of: add update device node status via cmdline feature

2013-08-23 Thread Dong Aisheng
nd it works. However it seems using uboot fdt commands is much complicated than kernel command line way as i did in this patch. We probably may would rather using add more board dts way if can not accept this patch series. I already replied that concern in last mail, can you help check it and provi

Re: [PATCH 0/3] of: add update device node status via cmdline feature

2013-08-23 Thread Dong Aisheng
Hi Grant, On Wed, Aug 21, 2013 at 08:37:09PM +0800, Dong Aisheng wrote: > On Thu, Aug 15, 2013 at 01:45:48PM +0100, Grant Likely wrote: > > On Thu, Aug 15, 2013 at 11:55 AM, Dong Aisheng wrote: > > > We meet some boards having a lot of pin conflicts between different > &g

Re: [PATCH 0/3] of: add update device node status via cmdline feature

2013-08-21 Thread Dong Aisheng
On Thu, Aug 15, 2013 at 07:37:04AM -0500, Rob Herring wrote: > On 08/15/2013 05:55 AM, Dong Aisheng wrote: > > We meet some boards having a lot of pin conflicts between different devices, > > only one of them can be enabled to run at one time. > > > > e.g. imx6q sabr

Re: [PATCH 0/3] of: add update device node status via cmdline feature

2013-08-21 Thread Dong Aisheng
On Thu, Aug 15, 2013 at 01:45:48PM +0100, Grant Likely wrote: > On Thu, Aug 15, 2013 at 11:55 AM, Dong Aisheng wrote: > > We meet some boards having a lot of pin conflicts between different devices, > > only one of them can be enabled to run at one time. > > > > e.g.

[PATCH 0/3] of: add update device node status via cmdline feature

2013-08-15 Thread Dong Aisheng
e pin conflicts issue. The patch series is based on v3.11-rc5. Dong Aisheng (3): of: add device node status update APIs of: add update device node status via cmdline feature of: add node status update via name format with cmdline Documentation/kernel-parameters.txt | 10 +++ drivers/of/b

[PATCH 2/3] of: add update device node status via cmdline feature

2013-08-15 Thread Dong Aisheng
command line, then those devices involved with pin conflict can be enabled or disabled dynamically. Signed-off-by: Dong Aisheng --- Documentation/kernel-parameters.txt |9 + drivers/of/fdt.c| 69 +++ 2 files changed, 78 insertions(+), 0

[PATCH 1/3] of: add device node status update APIs

2013-08-15 Thread Dong Aisheng
Used for convineniently update the device node status. Signed-off-by: Dong Aisheng --- drivers/of/base.c | 74 include/linux/of.h |5 +++ 2 files changed, 79 insertions(+), 0 deletions(-) diff --git a/drivers/of/base.c b/drivers/of

[PATCH 3/3] of: add node status update via name format with cmdline

2013-08-15 Thread Dong Aisheng
-bus@0210/weim@021b8000 now: fdt.enable=i2c@021a8000,weim@021b8000 fdt.disable=weim@021b8000 Signed-off-by: Dong Aisheng --- Documentation/kernel-parameters.txt |3 +- drivers/of/base.c | 33 + drivers/of/fdt.c| 66

Re: [PATCH] mfd: syscon: Add missing struct device_node declaration

2013-03-26 Thread Dong Aisheng
list > include/linux/mfd/syscon.h:20: warning: its scope is only this > definition or declaration, which is probably not what you want > > Fix it by adding a forward declaration of struct device_node. > > Cc: Dong Aisheng > Signed-off-by: Sylwester Nawrocki > Signed-of

Re: [PATCH v7 2/2] mfd: syscon: Add non-DT support

2013-03-13 Thread Dong Aisheng
was added. > > Signed-off-by: Alexander Shiyan Actually i've acked this series before, usually you can send out the updated series with my tag if no other big changes except the minor comments fix i pointed out. Here again, for this series: Acked-by: Dong Aisheng Regards Dong Aish

Re: [PATCH v6 2/2] mfd: syscon: Add non-DT support

2013-03-11 Thread Dong Aisheng
RESOURCE_MEM, 0); > > > + if (!res) > > > + return -ENOENT; > > > > > > - ret = of_address_to_resource(np, 0, &res); > > > - if (ret) > > > - return ret; > > > + syscon->base = devm_ioremap(dev, res->start, res

Re: [PATCH v6 2/2] mfd: syscon: Add non-DT support

2013-03-11 Thread Dong Aisheng
eturn 0; > -} > +static const struct platform_device_id syscon_ids[] = { > + { "syscon", }, > + { } > +}; > > static struct platform_driver syscon_driver = { > .driver = { > @@ -154,7 +169,7 @@ static struct platform_driver syscon_driver = { &g

Re: [PATCH v6 1/2] mfd: syscon: Removed unneeded field "dev" from private driver structure

2013-03-11 Thread Dong Aisheng
On Thu, Feb 28, 2013 at 06:57:13PM +0400, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan Acked-by: Dong Aisheng Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v4] mfd: syscon: Add non-DT support

2013-02-22 Thread Dong Aisheng
gt; prototype is in include/linux/device.h and the implementation in > lib/devres.c. > Got it. Thanks. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

<    1   2   3   4   5   6   7   >