Re: [PATCH] RDMA/cxgb3: Convert timers to use timer_setup()

. Also removes an unused timer. > > > > Cc: Steve Wise > > Cc: Doug Ledford > > Cc: Sean Hefty > > Cc: Hal Rosenstock > > Cc: linux-r...@vger.kernel.org > > Signed-off-by: Kees Cook > > Acked-by: Steve Wise Thanks, applied. -- Doug Ledford GP

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

ed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Doug Ledford <dledf...@redhat.com> -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

Bhumika Goyal Acked-by: Doug Ledford -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH][next] RDMA/hns: fix spelling mistake: "Reseved" -> "Reserved"

On Tue, 2017-10-10 at 16:14 +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dled

Re: [PATCH][next] RDMA/hns: fix spelling mistake: "Reseved" -> "Reserved"

On Tue, 2017-10-10 at 16:14 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, 2017-10-11 at 14:41 +0200, Thomas Bogendoerfer wrote: > Provide information about used firmware files via modinfo. > > Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse.de> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FD

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, 2017-10-11 at 14:41 +0200, Thomas Bogendoerfer wrote: > Provide information about used firmware files via modinfo. > > Signed-off-by: Thomas Bogendoerfer Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274

Re: [PATCH] IB/core: remove redundant check on prot_sg_cnt

the code by removing the non > -zero check on prot_sg_cnt and redundant else statement. > > Detected by CoverityScan, COD#1357188 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dledf

Re: [PATCH] IB/core: remove redundant check on prot_sg_cnt

n > -zero check on prot_sg_cnt and redundant else statement. > > Detected by CoverityScan, COD#1357188 ("Logically dead code") > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] infiniband: add MMU dependency for user_mem

931bc0d91639 ("IB: Move PCI dependency from root KConfig to > HW's KConfigs") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] infiniband: add MMU dependency for user_mem

931bc0d91639 ("IB: Move PCI dependency from root KConfig to > HW's KConfigs") > Signed-off-by: Arnd Bergmann Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

t; callback argument type") in v4.14-rc3, but should be otherwise > stand-alone. Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

riq Toukan > Cc: net...@vger.kernel.org > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-al

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Doug Ledford

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Doug Ledford &

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

s_timer, > i40iw_hw_stats_timeout, Since I took the first patch, this will need to be as an incremental change. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

s_timer, > i40iw_hw_stats_timeout, Since I took the first patch, this will need to be as an incremental change. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

t;faisal.la...@intel.com> > Cc: Shiraz Saleem <shiraz.sal...@intel.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: linux-r...@vger.kernel.org > Cc: T

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

> Cc: Shiraz Saleem > Cc: Doug Ledford > Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument ty

Re: [PATCH] IB/qib: Convert timers to use timer_setup()

Marciniszyn <infinip...@intel.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner <t...@linutronix.de> > Signed-o

Re: [PATCH] IB/qib: Convert timers to use timer_setup()

v4.14-rc3, but should be otherwise > stand-alone. Thanks, applied (to the same standalone branch). -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

k > to > nesdev was added. > > Cc: Faisal Latif <faisal.la...@intel.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: linux-r...@vger.kernel.org > Cc: Thom

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

k > to > nesdev was added. > > Cc: Faisal Latif > Cc: Doug Ledford > Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Mon, 2017-10-09 at 14:18 +0100, Colin Ian King wrote: > On 09/10/17 14:16, Doug Ledford wrote: > > > > > > Since Colin is non-responsive in this thread, I went ahead and took > > his > > patch, but then applied a fixup of my own: > > Sorry, I somehow

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Mon, 2017-10-09 at 14:18 +0100, Colin Ian King wrote: > On 09/10/17 14:16, Doug Ledford wrote: > > > > > > Since Colin is non-responsive in this thread, I went ahead and took > > his > > patch, but then applied a fixup of my own: > > Sorry, I somehow

Re: [PATCH] IB/rxe: check for allocation failure on elem

gt; >GFP_ATOMIC : GFP_KERNEL); > > > + if (!elem) > > > + return NULL; > > > > > > > It is not enough to simply return NULL, you also should release > > "pool" too. > > Colin, > do you plan t

Re: [PATCH] IB/rxe: check for allocation failure on elem

; > > + if (!elem) > > > + return NULL; > > > > > > > It is not enough to simply return NULL, you also should release > > "pool" too. > > Colin, > do you plan to fix the comment and resend it? Since Colin is non-responsive in thi

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

ded. > > Cc: Faisal Latif <faisal.la...@intel.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner <t...@linu

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

ded. > > Cc: Faisal Latif > Cc: Doug Ledford > Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback arg

Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

for this specific return condition. > > Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD

Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

ion. > > Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable") > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

s as they interrupt the output of git log --oneline when using the kernel standard 12 digit hex output for commit hashes. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

s as they interrupt the output of git log --oneline when using the kernel standard 12 digit hex output for commit hashes. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou <ouli...@huawei.com> > > When only set IB_QP_DEST_QPN flag for attr_mask, the operation of > assigning the dest_qp_num for dest_qp field of qp context is valid. This commit message reads poorly. I rewo

Re: [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > When only set IB_QP_DEST_QPN flag for attr_mask, the operation of > assigning the dest_qp_num for dest_qp field of qp context is valid. This commit message reads poorly. I reworded it. -- Doug Ledf

Re: [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

; > Ihis patch fixes the smatch error as below: Typo, but I can fix it, no need to respin. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

; > Ihis patch fixes the smatch error as below: Typo, but I can fix it, no need to respin. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j

> > Cleans up clang warning: > warning: Value stored to 'j' is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j

ing: > warning: Value stored to 'j' is never read > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings

; symbol 'hns_roce_cmq_send' was not declared. Should it be static? > symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings

ce_cmq_send' was not declared. Should it be static? > symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/qib: Use setup_timer and mod_timer

mer (); > +setup_timer (, y, z); > +mod_timer (, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(); > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD

Re: [PATCH] IB/qib: Use setup_timer and mod_timer

mer (); > +setup_timer (, y, z); > +mod_timer (, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(); > > Signed-off-by: Himanshu Jha Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines

On Tue, 2017-09-26 at 12:21 +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG

Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines

On Tue, 2017-09-26 at 12:21 +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 12

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

ld" on a quiescent system. I agree here. The newlines are still worthwhile as they remove any unnecessary stalls in the printk output while the printk engine decides whether or not you are going to do a KERN_CONT print next. Thanks, applied. -- Doug Ledford <dledf...@redhat.com>

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

ld" on a quiescent system. I agree here. The newlines are still worthwhile as they remove any unnecessary stalls in the printk output while the printk engine decides whether or not you are going to do a KERN_CONT print next. Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572F

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

tch that I applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

On Tue, 2017-09-26 at 12:59 +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav Sorry, I replied in the wrong thread last time. It is the v2 patch that I applied. -- Doug Ledf

Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

tializing ptr and sqp at their declaration. > > Cleans up warning: "warning: Value stored to 'sqp' during its > initialization is never read" > > Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue > pointer as needed on flush") > Signed-off-by: Colin Ian King

Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

> > Cleans up warning: "warning: Value stored to 'sqp' during its > initialization is never read" > > Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue > pointer as needed on flush") > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledf

Re: [PATCH 2/2] IB/uverbs: clean up INIT_UDATA() macro usage

ther than adding lots of new type casts. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH 2/2] IB/uverbs: clean up INIT_UDATA() macro usage

ther than adding lots of new type casts. > > Signed-off-by: Arnd Bergmann Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH 1/2] [v2] IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage

n in place of > the macro. > > Fixes: a96e4e2ffe43 ("IB/uverbs: New macro to set pointers to NULL if > length is 0 in INIT_UDATA()") > Suggested-by: Christoph Hellwig <h...@infradead.org> > Link: https://patchwork.kernel.org/patch/9940777/ > Signed-off-by: Arnd Ber

Re: [PATCH 1/2] [v2] IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage

n in place of > the macro. > > Fixes: a96e4e2ffe43 ("IB/uverbs: New macro to set pointers to NULL if > length is 0 in INIT_UDATA()") > Suggested-by: Christoph Hellwig > Link: https://patchwork.kernel.org/patch/9940777/ > Signed-off-by: Arnd Bergmann Thanks, applied

Re: [PATCH][next] IB/core: fix spelling mistake: "aceess" -> "access"

On Fri, 2017-09-01 at 09:22 +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in WARN message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dled

Re: [PATCH][next] IB/core: fix spelling mistake: "aceess" -> "access"

On Fri, 2017-09-01 at 09:22 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in WARN message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B

Re: [PATCH for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

.@huawei.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

On Fri, 2017-09-15 at 10:49 +0800, Wei Hu (Xavier) wrote: > It deletes the unnecessary initializing enum to zero. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Shaobo Xu > Signed-off-by: Lijun Ou Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On Wed, 2017-09-27 at 08:21 -0400, Doug Ledford wrote: > > And if you argee, after this patchset has been accepted we will > send a > > following up patch : > > In hns_roce_cmq_send function, replace > > usleep_range(1000, 2000); > >

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On Wed, 2017-09-27 at 08:21 -0400, Doug Ledford wrote: > > And if you argee, after this patchset has been accepted we will > send a > > following up patch : > > In hns_roce_cmq_send function, replace > > usleep_range(1000, 2000); > >

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On 9/26/2017 10:46 PM, Wei Hu (Xavier) wrote: > > > On 2017/9/27 0:18, Doug Ledford wrote: >> On 9/26/2017 9:13 AM, Wei Hu (Xavier) wrote: >>> >>> On 2017/9/26 1:36, Doug Ledford wrote: >>>> On Mon, 2017-09-25 at 20:18 +0300, Leon Romanovsky wrote: &

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On 9/26/2017 10:46 PM, Wei Hu (Xavier) wrote: > > > On 2017/9/27 0:18, Doug Ledford wrote: >> On 9/26/2017 9:13 AM, Wei Hu (Xavier) wrote: >>> >>> On 2017/9/26 1:36, Doug Ledford wrote: >>>> On Mon, 2017-09-25 at 20:18 +0300, Leon Romanovsky wrote: &

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

gnment") > Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> Thanks, applied to rc. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

'dbg' and since > we have not yet pointed 'dbg' to the debugfs we need to cleanup, the > cleanup fails and we are left with stray debugfs elements and also a > memory leak. > > Fixes: 4a5fd5d2965c ("IB/mlx5: Add necessary delay drop assignment") > Signed-off-by: Sudip M

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

> Signed-off-by: Colin Ian King <colin.k...@canonical.com> > > --- > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Except the wrong title: IB/core -> IB/ocrdma > > Reviewed-by: Leon Romanovsky <leo...@

Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

t; > --- > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Except the wrong title: IB/core -> IB/ocrdma > > Reviewed-by: Leon Romanovsky Thanks, patch (with fixed subject) applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/qedr: fix build error without ipv6

hat configuration is already prohibited by CONFIG_INFINIBAND > depending on "m || IPV6 != m". > > Fixes: e411e0587e0d ("RDMA/qedr: Add iWARP connection management > functions") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to for-next area. -- Doug Ledford

Re: [PATCH] RDMA/qedr: fix build error without ipv6

hat configuration is already prohibited by CONFIG_INFINIBAND > depending on "m || IPV6 != m". > > Fixes: e411e0587e0d ("RDMA/qedr: Add iWARP connection management > functions") > Signed-off-by: Arnd Bergmann Thanks, applied to for-next area. -- Doug Ledford GPG KeyID: B826A

Re: linux-next: Signed-off-by missing for commit in the rdma tree

s hates that. What about git note? -- Doug Ledford <dledf...@redhat.com> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the rdma tree

s hates that. What about git note? -- Doug Ledford GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] i40iw: make some structures const

On Mon, 2017-08-28 at 21:51 +0530, Bhumika Goyal wrote: > Make some structures const as they are only used during a copy > operation. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E57

Re: [PATCH] i40iw: make some structures const

On Mon, 2017-08-28 at 21:51 +0530, Bhumika Goyal wrote: > Make some structures const as they are only used during a copy > operation. > > Signed-off-by: Bhumika Goyal Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265

Re: [PATCH] IB/rxe: constify vm_operations_struct

v <arvind.yadav...@gmail.com> Sorry, this bug had already been fixed by a previous patch. Thanks for your submission though. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/rxe: constify vm_operations_struct

Sorry, this bug had already been fixed by a previous patch. Thanks for your submission though. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/hfi1: constify vm_operations_struct

v <arvind.yadav...@gmail.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/hfi1: constify vm_operations_struct

Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset

> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset

On Fri, 2017-08-25 at 21:41 +0530, Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Signed-off-by: Himanshu Jha Thanks, applied. -- Doug Ledford

Re: [PATCH] RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid"

On Thu, 2017-08-24 at 09:25 +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in DP_ERR error message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dled

Re: [PATCH] RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid"

On Thu, 2017-08-24 at 09:25 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DP_ERR error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH] IB/hfi1: fix spelling mistake: "Maximim" -> "Maximum"

atelimited("hfi1: Maximum trap > > limit reached for 0x%0x traps\n", > > trap- > > >data.generic_type); > > kfree(trap); > > } > > > > Thanks! > > Acked-by: Dennis Dalessandro <dennis.dalessan...@intel.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/hfi1: fix spelling mistake: "Maximim" -> "Maximum"

aps\n", > > trap- > > >data.generic_type); > > kfree(trap); > > } > > > > Thanks! > > Acked-by: Dennis Dalessandro Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v12 0/8] Replace PCI pool by DMA pool API

mthca, mlx4, and mlx5 patches). Thanks. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v12 0/8] Replace PCI pool by DMA pool API

mthca, mlx4, and mlx5 patches). Thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH 0/2] IB: add const to bin_attribute structures

finiband/hw/hfi1/sysfs.c| 4 ++-- > drivers/infiniband/hw/qib/qib_sysfs.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Thanks, series applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH 0/2] IB: add const to bin_attribute structures

finiband/hw/hfi1/sysfs.c| 4 ++-- > drivers/infiniband/hw/qib/qib_sysfs.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Thanks, series applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] infiniband: avoid overflow warning

the memcpy() call and instead > replace it with a struct assignment. > > Fixes: 6974f0c4555e ("include/linux/string.h: add the option of > fortified string.h functions") > Cc: Daniel Micay <danielmi...@gmail.com> > Cc: Kees Cook <keesc...@chromium.

Re: [PATCH] infiniband: avoid overflow warning

the memcpy() call and instead > replace it with a struct assignment. > > Fixes: 6974f0c4555e ("include/linux/string.h: add the option of > fortified string.h functions") > Cc: Daniel Micay > Cc: Kees Cook > Signed-off-by: Arnd Bergmann Thanks, applied. -- Doug

Re: [PATCH] i40iw: fix spelling mistake: "allloc_buf" -> "alloc_buf"

by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] i40iw: fix spelling mistake: "allloc_buf" -> "alloc_buf"

On Fri, 2017-07-21 at 23:19 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in i40iw_debug message and > also split up a couple of lines that are too long and cause > checkpatch warnings > > Signed-off-by: Colin Ian King Thanks, appli

Re: [PATCH] i40iw: Simplify code

<shiraz.sal...@intel.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH] i40iw: Simplify code

On Mon, 2017-07-17 at 14:31 -0500, Shiraz Saleem wrote: > On Sun, Jul 16, 2017 at 01:09:23PM +0200, Christophe JAILLET wrote: > > Axe a few lines of code and re-use existing error handling path to > > avoid > > code duplication. > > > > Acked-by: Shiraz Sa

Re: [PATCH 0/3] constify infiniband pci_device_id.

t; drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Thanks, series applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH 0/3] constify infiniband pci_device_id.

t; drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Thanks, series applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: PCI/IB: add support for pci driver attribute groups

d vs. when the kobject is announced, so any > > script/tool > > that actually wanted to use these files will not have to poll > > waiting > > for them to show up. > > > > Cc: Faisal Latif <faisal.la...@intel.com> > > Cc: Doug Ledford <dledf...@red

Re: PCI/IB: add support for pci driver attribute groups

announced, so any > > script/tool > > that actually wanted to use these files will not have to poll > > waiting > > for them to show up. > > > > Cc: Faisal Latif > > Cc: Doug Ledford > > Cc: Sean Hefty > > Cc: Hal Rosenstock > > Cc: Bjorn Helg

Re: [PATCH][-next] RDMA/bnxt_re: fix spelling mistake: "Deallocte" -> "Deallocate"

On Fri, 2017-07-14 at 08:30 +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied. -- Doug Ledford <dled

Re: [PATCH][-next] RDMA/bnxt_re: fix spelling mistake: "Deallocte" -> "Deallocate"

On Fri, 2017-07-14 at 08:30 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH] IB/hfi1: fix spelling mistake in variable name continious

us' > > > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > > --- > > Thanks! > > Acked-by: Dennis Dalessandro <dennis.dalessan...@intel.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

<    1   2   3   4   5   6   7   8   9   10   >