Re: [PATCH v1 1/1] pinctrl: core: Show pin numbers for the controllers with base = 0

is positive number. This, > in particular, excluded chips where base is 0 for the historical or backward > compatibility reasons. Refactor the code to include the latter as well. > > Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file") > Cc: Drew Fustini > S

Re: [PATCH v1 1/1] pinctrl: core: Show pin numbers for the controllers with base = 0

On Mon, Apr 19, 2021 at 3:04 AM Andy Shevchenko wrote: > > On Thu, Apr 15, 2021 at 4:07 PM Andy Shevchenko > wrote: > > > > The commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file") > > enabled GPIO pin number and label in debugfs for pin controller. However, > > it limited that

[tip: timers/core] clocksource/drivers/pistachio: Fix trivial typo

The following commit has been merged into the timers/core branch of tip: Commit-ID: a47d7ef4550d08fb428ea4c3f1a9c71674212208 Gitweb: https://git.kernel.org/tip/a47d7ef4550d08fb428ea4c3f1a9c71674212208 Author:Drew Fustini AuthorDate:Fri, 05 Mar 2021 01:03:17 -08:00

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

On Wed, Mar 24, 2021 at 02:00:52PM +0200, Tony Lindgren wrote: > Hi, > > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > &g

[PATCH] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

uot;NC" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- Tony - I have fixed the conflict so this now applies against mainline. arch/arm/boot/dts/am335x-boneblack.dts | 132 ---

Re: [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show()

trl-single pin 140 (PIN140) 0:? 44e10a30 0028 pinctrl-single pin 141 (PIN141) 13:gpio-64-95 44e10a34 0020 pinctrl-single Reviewed-by: Drew Fustini Thanks, Drew

Re: [PATCH v9 2/4] pinctrl: pinmux: Add pinmux-select debugfs file

On Fri, Mar 12, 2021 at 02:57:54PM +0100, Enrico Weigelt, metux IT consult wrote: > On 02.03.21 06:30, Drew Fustini wrote: > > Hi folks, > > > Add "pinmux-select" to debugfs which will activate a pin function for a > > given pin group: > > > >

[PATCH] scripts/spelling.txt: add "overflw"

Add typo "overflw" for "overflow". This typo was found and fixed in drivers/clocksource/timer-pistachio.c. Link: https://lore.kernel.org/lkml/20210305090315.384547-1-d...@beagleboard.org/ Suggested-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- scripts/spelli

[PATCH] clocksource/drivers: fix typo in timer-pistachio

Fix trivial typo, rename local variable from 'overflw' to 'overflow' in pistachio_clocksource_read_cycles(). Reported-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- drivers/clocksource/timer-pistachio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] scripts/spelling.txt: add "overlfow"

Add typo "overlfow" for "overflow". This typo was found and fixed in net/sctp/tsnmap.c. Link: https://lore.kernel.org/netdev/20210304055548.56829-1-d...@beagleboard.org/ Suggested-by: Kees Cook Signed-off-by: Drew Fustini --- scripts/spelling.txt | 1 + 1 file changed,

[PATCH] net: sctp: trivial: fix typo in comment

Fix typo of 'overflow' for comment in sctp_tsnmap_check(). Reported-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- net/sctp/tsnmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/tsnmap.c b/net/sctp/tsnmap.c index a9c6af5795d8..5ba456727f63 100644

Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files

On Tue, Mar 02, 2021 at 05:22:37PM +0100, Linus Walleij wrote: > On Tue, Mar 2, 2021 at 11:23 AM Andy Shevchenko > wrote: > > On Tue, Mar 2, 2021 at 10:36 AM Linus Walleij > > wrote: > > > > Patch applied, thanks for fixing this! > > > > I guess we are at v9 of this. > > Yeah I took it out

[PATCH v9 0/4] pinctrl: pinmux: Add pinmux-select debugfs file

g/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (4): pinctrl: use to octal permissions for debugfs files pinctrl: pi

[PATCH v9 1/4] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

[PATCH v9 4/4] docs/pinctrl: document debugfs files

Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pin-control.rst | 37 1 file changed, 37 insertions

[PATCH v9 3/4] Documentation: rename pinctl to pin-control

pinctl is not ideal as pinctrl (with an 'r') is much more common. Linus state that pin-control.rst would be the best name for the documentation. Link: https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/#t Suggested-by: Linus Walleij Signed-off-by: Drew Fustini --- Documentation

[PATCH v9 2/4] pinctrl: pinmux: Add pinmux-select debugfs file

o Reviewed-by: Tony Lindgren Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/pinmux.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c inde

Re: [PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

On Sat, Feb 20, 2021 at 12:27:47PM -0800, Drew Fustini wrote: > This series first converts the debugfs files in the pinctrl subsystem to > octal permissions and then adds a new debugfs file "pinmux-select". > > Group name and function name can be written to "pinmux

[PATCH v8 3/3] docs/pinctrl: document debugfs files

Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions

[PATCH v8 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

o Reviewed-by: Tony Lindgren Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/pinmux.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c inde

[PATCH v8 1/3] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

[PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

set_write() to pinmux_select() - switch from memdup_user_nul() to strncpy_from_user() - switch from pr_warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/li

Re: [PATCH v7 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

On Fri, Feb 19, 2021 at 10:06:51AM +0100, Geert Uytterhoeven wrote: > Hi Drew, > > On Wed, Feb 17, 2021 at 11:15 PM Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group: > > > > echo "" > pinmu

[PATCH v7 3/3] docs/pinctrl: document debugfs files

Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions

[PATCH v7 1/3] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

[PATCH v7 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Reviewed-by: Andy Shevchenko Review

[PATCH v7 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (3): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file docs/pinctrl: document debugfs files Documentation/driver-api/pinctl.rst | 37 ++ drivers/pinct

[PATCH v6 1/3] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files c

[PATCH v6 3/3] docs/pinctrl: document debugfs files

Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/pinctl.rst b

[PATCH v6 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by:

[PATCH v6 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (3): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file docs/pinctrl: document debugfs files Documentation/dr

Re: [PATCH v5 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Mon, Feb 15, 2021 at 09:04:20PM +0200, Andy Shevchenko wrote: > On Sat, Feb 13, 2021 at 12:30 AM Drew Fustini wrote: > > > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The write > >

[PATCH v5 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by: Dr

[PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinc

[PATCH v5 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions fo

Re: [PATCH] pinctrl: use to octal permissions for debugfs files

On Fri, Feb 12, 2021 at 08:58:58AM +0100, Linus Walleij wrote: > On Tue, Jan 26, 2021 at 5:55 AM Drew Fustini wrote: > > > Switch over pinctrl debugfs files to use octal permissions as they are > > preferred over symbolic permissions. Refer to commit f90774e1fd27 >

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Thu, Feb 11, 2021 at 03:00:51PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 02:28:54PM -0800, Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The write &g

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Thu, Feb 11, 2021 at 11:53:24AM +0200, Andy Shevchenko wrote: > On Thu, Feb 11, 2021 at 10:09 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 10, 2021 at 11:33 PM Drew Fustini wrote: > > > > > +#define PINMUX_MAX_NAME 64 > > > >

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Thu, Feb 11, 2021 at 09:09:03AM +0100, Geert Uytterhoeven wrote: > Hi Drew, > > On Wed, Feb 10, 2021 at 11:33 PM Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The wr

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Thu, Feb 11, 2021 at 10:39:38AM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 11:24:23PM -0800, Joe Perches wrote: > > On Thu, 2021-02-11 at 10:11 +0300, Dan Carpenter wrote: > > > On Wed, Feb 10, 2021 at 02:28:54PM -0800, Drew Fustini wrote: > > > > +

Re: [PATCH v4 1/2] pinctrl: use to octal permissions for debugfs files

On Wed, Feb 10, 2021 at 11:36:39PM -0800, Joe Perches wrote: > On Wed, 2021-02-10 at 14:28 -0800, Drew Fustini wrote: > > Switch over pinctrl debugfs files to use octal permissions as they are > > preferred over symbolic permissions. Refer to commit f90774e1fd27 > > ("che

[PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by: Dre

[PATCH v4 1/2] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/co

[PATCH v4 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file drivers/pinctrl/core.c| 6 +-- drivers/pinctrl/pinconf.c | 4 +- drivers/pinctrl/pinmux.c | 111

[PATCH v3 1/2] pinctrl: use to octal permissions for debugfs files

fs/debugfs/inode.c Thank you, Drew Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/core.c b/drive

[PATCH v3 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

nmux-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo pinmux-i2c1 pinmux-i2c1-pins > mux-select Signed-off-by: Drew Fustini

[PATCH v3 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for deb

Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

On Wed, Feb 10, 2021 at 04:36:00AM -0800, Joe Perches wrote: > On Wed, 2021-02-10 at 12:18 +0200, Andy Shevchenko wrote: > > On Wed, Feb 10, 2021 at 10:30 AM Joe Perches wrote: > > > On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote: > > > > > > -

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Wed, Feb 10, 2021 at 10:05:29PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 07:39:16PM +0100, Geert Uytterhoeven wrote: > > Hi Dan, > > > > On Wed, Feb 10, 2021 at 7:21 PM Dan Carpenter > > wrote: > > > 99b2f99aa41aa7 Drew Fustini 2021-02-

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Wed, Feb 10, 2021 at 09:20:44PM +0300, Dan Carpenter wrote: > Hi Drew, > > url: > https://github.com/0day-ci/linux/commits/Drew-Fustini/pinctrl-pinmux-Add-pinmux-select-debugfs-file/20210210-160108 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

On Wed, Feb 10, 2021 at 11:56:49AM +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2021 at 9:50 AM Drew Fustini wrote: > > > > Add "pinmux-select" to debugfs which will activate a function and group > > when 2 integers " " are written to > > the fi

[PATCH v2 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

eboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file drivers/pinctrl/co

[PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drive

[PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

nmux-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 (fsel 4) and group pinmux-i2c1-pins (gsel 4): echo '4 4' > pinmux-select Signed-off-by: Drew Fustini

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

On Thu, Feb 04, 2021 at 08:58:20AM +0200, Tony Lindgren wrote: > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > > with the name of the

[PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

uot;NC" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am335x-boneblack.dts | 130 - 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/arch/arm/b

[PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

uot;NC" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am335x-pocketbeagle.dts | 140 +++--- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/arch/arm/

pinctl.rst instead of pinctrl.rst?

I was having trouble finding the pinctrl rst documentation until I realized it is named pinctl with no 'r': Documentation/driver-api/pinctl.rst Is there a reason for this? Is it worth me submitting a patch to rename and change tree-wide references? Thanks, Drew

[PATCH] pinctrl: use to octal permissions for debugfs files

Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- Patch note: - I learned about this preferenc

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

On Mon, Jan 11, 2021 at 12:03:18PM +0200, Tony Lindgren wrote: > Hi, > > * Linus Walleij [210109 21:14]: > > On Sat, Jan 9, 2021 at 3:55 AM Drew Fustini wrote: > > > > > I discussed my use case and this patch on #armlinux earlier this week > > >

[PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

y Lindgren Signed-off-by: Drew Fustini --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single

Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2

On Fri, Jan 15, 2021 at 07:02:01PM +0100, Emmanuel Vadot wrote: > > Hello Drew, > > On Wed, 1 Jul 2020 03:33:20 +0200 > Drew Fustini wrote: > > > Increase #pinctrl-cells to 2 so that mux and conf be kept separate. This > > requires the AM33XX_PADCONF macro

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

On Sat, Jan 09, 2021 at 02:22:07AM +0100, Linus Walleij wrote: > Hi Drew, > > sorry for belated review. The approach is so uncommon so it had me > confused. > > On Thu, Dec 24, 2020 at 9:36 PM Drew Fustini wrote: > > > > > I used the compatible string

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

On Thu, Dec 24, 2020 at 02:36:03PM -0600, Drew Fustini wrote: > On Fri, Dec 18, 2020 at 06:01:25PM +0200, Andy Shevchenko wrote: > > On Fri, Dec 18, 2020 at 6:52 AM Drew Fustini wrote: > > > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

On Fri, Dec 18, 2020 at 06:01:25PM +0200, Andy Shevchenko wrote: > On Fri, Dec 18, 2020 at 6:52 AM Drew Fustini wrote: > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called > > bone-pinmux-helper [1] developed by Pantelis Antoniou [2] back in 2013. > &g

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

On Fri, Dec 18, 2020 at 06:00:49PM +0200, Andy Shevchenko wrote: > On Wed, Dec 16, 2020 at 12:42 AM Drew Fustini wrote: > > On Tue, Dec 15, 2020 at 09:39:18PM +0200, Andy Shevchenko wrote: > > > On Tue, Dec 15, 2020 at 9:36 PM Andy Shevchenko > > > wrote: > > >

[RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

rence-Manual#section-7-1 [5] https://github.com/beagleboard/bb.org-overlays/blob/master/tools/beaglebone-universal-io/config-pin [6] https://beagleboard.org/Support/bone101/#headers Cc: Pantelis Antoniou Cc: Pantelis Antoniou Cc: Pantelis Antoniou Cc: Jason Kridner Cc: Robert Nelson Cc: Linus Wall

Re: [PATCH] gpiolib: Allow name duplicates of "" and "NC"

On Tue, Dec 15, 2020 at 09:03:08AM -0800, Bjorn Andersson wrote: > Not all GPIO pins are exposed to the world and this is typically > described by not giving these lines particular names, commonly "" or > "NC". > > With the recent introduction of '2cd64ae98f35 ("gpiolib: Disallow > identical line

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

On Tue, Dec 15, 2020 at 09:39:18PM +0200, Andy Shevchenko wrote: > On Tue, Dec 15, 2020 at 9:36 PM Andy Shevchenko > wrote: > > On Mon, Dec 14, 2020 at 11:44 PM Drew Fustini wrote: > > > On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > > ... >

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

On Tue, Dec 15, 2020 at 09:36:33PM +0200, Andy Shevchenko wrote: > On Mon, Dec 14, 2020 at 11:44 PM Drew Fustini wrote: > > On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > > > On Sat, Dec 12, 2020 at 1:43 AM Drew Fustini wrote: > > > > On Fri, De

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > On Sat, Dec 12, 2020 at 1:43 AM Drew Fustini wrote: > > On Fri, Dec 11, 2020 at 11:15:21PM +0200, Andy Shevchenko wrote: > > > On Fri, Dec 11, 2020 at 1:54 PM Drew Fustini wrote: > > > > > > &g

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

On Fri, Dec 11, 2020 at 11:15:21PM +0200, Andy Shevchenko wrote: > On Fri, Dec 11, 2020 at 1:54 PM Drew Fustini wrote: > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called > > bone-pinmux-helper [1] developed by Pantelis Antoniou [2] back in 2013. >

[RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

verlays/blob/master/tools/beaglebone-universal-io/config-pin [6] https://beagleboard.org/Support/bone101/#headers Cc: Pantelis Antoniou Cc: Linus Walleij Cc: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/Kconfig| 10 ++ drivers/pinctrl/Makefile

Re: [PATCH] pinctrl: core: Fix unused variable build warnings

On Mon, Nov 23, 2020 at 11:51:29PM -0800, Pawan Gupta wrote: > On Mon, Nov 23, 2020 at 09:06:18PM -0800, Drew Fustini wrote: > > On Mon, Nov 23, 2020 at 02:33:33PM -0800, Pawan Gupta wrote: > > > A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs &

Re: [PATCH] pinctrl: core: Fix unused variable build warnings

On Mon, Nov 23, 2020 at 02:33:33PM -0800, Pawan Gupta wrote: > A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs > file") added build warnings when CONFIG_GPIOLIB=n. Offcourse the kernel > fails to build when warnings are treated as errors. Below is the error > message: > >

Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3

On Wed, Sep 30, 2020 at 08:16:59AM +0300, Tony Lindgren wrote: > * Linus Walleij [200929 12:51]: > > On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini wrote: > > > > > The property #pinctrl-cells can either be 2 or 3. There is currently > > > only a check to m

[PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check

lower bound. Fixes: a1339541 ("pinctrl: single: parse #pinctrl-cells = 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- v2 change: - correct the description as I had previously been mistakenly usi

[PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2

mide.com/ Signed-off-by: Drew Fustini --- NOTE: checkpatch complains "Macros with complex values should be enclosed in parentheses" but all the other marcos in that section have the same format so it seems appropriate to ignore checkpatch and maintain the style. include/dt-bindings/pin

Re: [PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF

On Mon, Sep 21, 2020 at 09:47:07AM +0300, Tony Lindgren wrote: > * Drew Fustini [200919 19:53]: > > Change the pin defintions from AM33XX_IOPAD to AM33XX_PADCONF macro so > > that it correctly handles changes to #pinctrl-cells. > > Thanks for fixing this. I wonder if we s

[PATCH v2] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

Document the values in pinctrl-single,pins when #pinctrl-cells = <2> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustin

[PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF

CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am335x-guardian.dts | 172 +- 1 file changed, 86 insertions(+), 86 deletions(-) diff --git a/arch/arm/boot/dts/am335x-guardian.dts b/arch/arm/boot/dts/am335x-guardian.dts index 1918766c1f80..56c9cd674

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

On Thu, Sep 17, 2020 at 03:00:36AM -0700, Trent Piepho wrote: > On Thu, Sep 17, 2020 at 2:20 AM Drew Fustini wrote: > > > > On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > > > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > > > > &

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > > > + > > +When #pinctrl-cells = 2, then setting a pin for a device could be done > > with: > > + > > + pinctrl-single,pins =

[PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

Document the values in pinctrl-single,pins when #pinctrl-cells = <2> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini -

Re: [PATCH v4 1/2] pinctrl: single: parse #pinctrl-cells = 2

On Sun, Sep 13, 2020 at 09:42:33PM +0200, Drew Fustini wrote: > On Tue, Sep 08, 2020 at 04:52:58PM -0700, Trent Piepho wrote: > > On Tuesday, June 30, 2020 6:33:19 PM PDT Drew Fustini wrote: > > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux), then >

[PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3

s = 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- v2 change: - this is a fix to my prior email where I referred to #pinctrl-cells exceeding 3 which is incorrect. It is pinctrl_spec.args_count which must

[PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- v2 change: this is a fix to my prior email where I referred to #pinctrl-cells = 3 which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2 https://lore.kernel.org/linux-omap/20200913224746.2048603-1-d...@beagleboard.org/ drive

[PATCH] pinctrl: single: fix debug output when #pinctrl-cells = 3

CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 5cbf0e55087c..f3cd7e296712 100644 --- a/drivers/pinctrl/pinctrl-sing

[PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3

epho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index efe41abc5d47..5c

Re: [PATCH v4 1/2] pinctrl: single: parse #pinctrl-cells = 2

On Tue, Sep 08, 2020 at 04:52:58PM -0700, Trent Piepho wrote: > On Tuesday, June 30, 2020 6:33:19 PM PDT Drew Fustini wrote: > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux), then > > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to &

Re: [PATCH] gpio: omap: improve coding style for pin config flags

On Wed, Aug 19, 2020 at 09:31:27AM +0300, Tony Lindgren wrote: > Hi, > > * Drew Fustini [200722 12:09]: > > Change the handling of pin config flags from if/else to switch > > statement to make the code more readable and cleaner. > > > > Suggested-by: Gustavo A.

[PATCH] ARM: dts: am33xx: add ocp label

Add label to the ocp node in the AM33xx SoC include so that it can be referenced in board-level files like am335x-pocketbeagle.dts Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b

[PATCH v5] pinctrl: core: print gpio in pins debugfs file

37 pinctrl-single pin 35 (PIN35) 1:gpio-64-95 44e1088c 0037 pinctrl-single Suggested-by: Andy Shevchenko Suggested-by: Tony Lindgren Reviewed-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c | 21 + 1 file changed, 21 insertions(+) v4 chang

[PATCH] gpio: omap: improve coding style for pin config flags

Change the handling of pin config flags from if/else to switch statement to make the code more readable and cleaner. Suggested-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- drivers/gpio/gpio-omap.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[PATCH v4] pinctrl: core: print gpio in pins debugfs file

5 44e10888 0037 pinctrl-single pin 35 (PIN35) 1:gpio-64-95 44e1088c 0037 pinctrl-single Suggested-by: Andy Shevchenko Suggested-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c | 21 + 1 file changed, 21 insertions(+) v4 change: -

Re: [PATCH v3] pinctrl: core: print gpio in pins debugfs file

On Tue, Jul 21, 2020 at 04:02:34PM +0200, Drew Fustini wrote: > If there is a gpio range mapping for the pin, then print out the gpio > chip and line index for the pin in the debugfs 'pins' file with the > format: "[gpiochip-label]:line-[index] " > > For example, h

[PATCH v3] pinctrl: core: print gpio in pins debugfs file

le pin 34 (PIN34) gpio-64-95:line-0 44e10888 0037 pinctrl-single pin 35 (PIN35) gpio-64-95:line-1 44e1088c 0037 pinctrl-single Suggested-by: Andy Shevchenko Suggested-by: Tony Lindgren Signed-off-by: Drew Fustini v3 changes: - gpio column is now gpiochip label and line index

Re: [PATCH] pinctrl: core: print gpio in pins debugfs file

On Mon, Jul 20, 2020 at 04:26:21PM +0200, Linus Walleij wrote: > Hi Drew, > > thanks for this patch, we're going the right direction here > and creating things that are generically useful. > > On Sat, Jul 18, 2020 at 5:53 PM Drew Fustini wrote: > > > pin 103 (PIN103)

[PATCH v2] pinctrl: core: print gpio in pins debugfs file

(PIN115) NA 44e109cc 0028 pinctrl-single Suggested-by: Andy Shevchenko Suggested-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c | 30 ++ 1 file changed, 30 insertions(+) v2 changes: - only include GPIO information if CONFIG_GPIOLIB - print

Re: [PATCH v2] pinctrl: core: print gpio in pins debugfs file

On Sun, Jul 19, 2020 at 03:22:01PM +0200, Drew Fustini wrote: > If there is a gpio range mapping for the pin, then print out the gpio > number for the pin in the debugfs 'pins' file. > > Here is an example output on the BeagleBone Black from: > /sys/kernel/debug/pinctrl/44e10800

  1   2   >