On Mon, Mar 01, 2021 at 10:33:14AM -0500, Michael S. Tsirkin wrote:
> On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote:
> >
> > On 2021/3/1 2:28 下午, Eli Cohen wrote:
> > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask
> > >
VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask
conditionals.
Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with
the rest of the code.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
drivers
Hi Michael,
I see that you did not include these in your latest pull request.
https://lkml.org/lkml/2021/2/10/1386
https://lkml.org/lkml/2021/2/10/1383
https://lkml.org/lkml/2021/2/18/124
Are you going to merge them?
On Wed, Feb 24, 2021 at 02:12:01AM -0500, Michael S. Tsirkin wrote:
> On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote:
> >
> > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote:
> > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote:
> > > >
On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote:
>
> On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote:
> > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote:
> > > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote:
> > > > On Wed,
On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote:
> On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote:
> >
> > On 2021/2/24 3:35 上午, Si-Wei Liu wrote:
> > >
> > >
> > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote:
> > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800,
On Tue, Feb 23, 2021 at 07:56:16AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 23, 2021 at 02:54:42PM +0200, Eli Cohen wrote:
> > On Tue, Feb 23, 2021 at 07:52:34AM -0500, Michael S. Tsirkin wrote:
> > >
> > > I think I have them in the linux next branch, no?
>
On Tue, Feb 23, 2021 at 07:52:34AM -0500, Michael S. Tsirkin wrote:
>
> I think I have them in the linux next branch, no?
>
You do.
On Tue, Feb 23, 2021 at 07:32:49AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 16, 2021 at 07:50:21AM +0200, Eli Cohen wrote:
> > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well
> > in mlx5v_remove().
> >
> > Fixes: 74c9729dd892 (&q
On Tue, Feb 23, 2021 at 07:29:32AM -0500, Michael S. Tsirkin wrote:
> On Thu, Feb 18, 2021 at 09:41:57AM +0200, Eli Cohen wrote:
> > Allow to control vdpa device creation and destruction using the vdpa
> > management tool.
> >
> > Examples:
> > 1. List the mana
On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote:
> On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote:
> > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote:
> > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
> > >
On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote:
> Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
> for legacy") made an exception for legacy guests to reset
> features to 0, when config space is accessed before features
> are set. We should relieve the
of hardware
used index.
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change
map")
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
v0->v1:
Fix subject prefix
drivers/vdpa/ml
show
vdpa0: type network mgmtdev pci/:3b:00.1 vendor_id max_vqs 16 \
max_vq_size 256
Signed-off-by: Eli Cohen
Reviewed-by: Parav Pandit
---
v0->v1:
set mgtdev->ndev NULL on dev delete
v1->v2: Resend
drivers/vdpa/mlx5/net/mlx5_vnet.c | 79 +++
1 fil
On Wed, Feb 17, 2021 at 04:20:14PM -0500, Michael S. Tsirkin wrote:
> On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote:
> >
> >
> > On 2/16/2021 8:20 AM, Eli Cohen wrote:
> > > When we suspend the VM, the VDPA interface will be reset. When
On Wed, Feb 17, 2021 at 12:13:37PM -0500, Michael S. Tsirkin wrote:
> On Wed, Feb 17, 2021 at 01:31:36PM +0200, Eli Cohen wrote:
> > Allow to control vdpa device creation and destruction using the vdpa
> > management tool.
> >
> > Examples:
> > 1. List the mana
show
vdpa0: type network mgmtdev pci/:3b:00.1 vendor_id max_vqs 16 \
max_vq_size 256
Signed-off-by: Eli Cohen
Reviewed-by: Parav Pandit
---
v0->v1:
set mgtdev->ndev NULL on dev delete
drivers/vdpa/mlx5/net/mlx5_vnet.c | 79 +++
1 file chang
On Tue, Feb 16, 2021 at 04:25:20PM -0800, Si-Wei Liu wrote:
>
> > > The saved mvq->avail_idx will be used to recreate hardware virtq object
> > > and
> > > the used index in create_virtqueue(), once status DRIVER_OK is set. I
> > > suspect we should pass the index to mvq->used_idx in
> > >
show
vdpa0: type network mgmtdev pci/:3b:00.1 vendor_id max_vqs 16 \
max_vq_size 256
Signed-off-by: Eli Cohen
Reviewed-by: Parav Pandit
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 76 +++
1 file changed, 67 insertions(+), 9 deletions(-)
diff --git a/drivers
of hardware
used index.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote:
> On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote:
> > While virtq is stopped, get_vq_state() is supposed to
> > be called to get sync'ed with the latest internal
> > avail_index from device. The save
On Tue, Feb 16, 2021 at 09:37:34AM +0200, Leon Romanovsky wrote:
> On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote:
> > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote:
> > > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote:
> > > >
On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote:
> On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote:
> > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well
> > in mlx5v_remove().
> >
> > Fixes: 74c9729dd892 ("vdpa/mlx5
struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well
in mlx5v_remove().
Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well
in mlx5v_remove().
Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
map")
> Signed-off-by: Si-Wei Liu
> Acked-by: Jason Wang
Acked-by: Eli Cohen
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> b/drivers/vdpa/mlx5/net/mlx
sume tx checksum offload
> is available after reset and feature negotiation,
> causing frames with bogus (incomplete) checksum
> transmitted on the wire.
>
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> Signed-off-by: Si-
On Wed, Feb 10, 2021 at 12:59:03AM -0800, Si-Wei Liu wrote:
>
>
> On 2/9/2021 7:53 PM, Jason Wang wrote:
> >
> > On 2021/2/10 上午10:30, Si-Wei Liu wrote:
> > >
> > >
> > > On 2/8/2021 10:37 PM, Jason Wang wrote:
> > > >
> >
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午6:04, Eli Cohen wrote:
> > On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
> > > On 2021/2/8 下午2:37, Eli Cohen wrote:
> > > > On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason
: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Stefano Garzarella
Acked-by: Eli Cohen
BTW, same error in vdpa_sim you may want to fix.
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file ch
On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午2:37, Eli Cohen wrote:
> > On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:
> > > On 2021/2/6 上午7:07, Si-Wei Liu wrote:
> > > >
> > > > On 2/3/2021 11:36
On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:
>
> On 2021/2/6 上午7:07, Si-Wei Liu wrote:
> >
> >
> > On 2/3/2021 11:36 PM, Eli Cohen wrote:
> > > When a change of memory map occurs, the hardware resources are destroyed
> > > and the
On Sat, Feb 06, 2021 at 04:29:24AM -0800, Si-Wei Liu wrote:
> While virtq is stopped, get_vq_state() is supposed to
> be called to get sync'ed with the latest internal
> avail_index from device. The saved avail_index is used
> to restate the virtq once device is started. Commit
>
does not just contain the
> Ethernet payload, but includes extra lengths starting
> from the Ethernet header up to the FCS altogether.
>
> Fix the MTU so packets won't get dropped silently.
>
> Signed-off-by: Si-Wei Liu
Acked-by: Eli Cohen
> ---
> drivers/vdpa/mlx5/core/
On Sat, Feb 06, 2021 at 04:29:23AM -0800, Si-Wei Liu wrote:
> The mlx_features denotes the capability for which
> set of virtio features is supported by device. In
> principle, this field needs not be cleared during
> virtio device reset, as this capability is static
> and does not change across
to reset the available and used
indices upon device reset, fix this here to avoid regression caused by
the fact that used index may not be zero upon device reset.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
v0 -> v1:
Clear
On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote:
> On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote:
> >
> > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote:
> > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote:
> > > >
> &
On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote:
> On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote:
> >
> > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote:
> > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote:
> > > >
> &
On Wed, Feb 03, 2021 at 03:19:40PM -0800, Si-Wei Liu wrote:
> On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote:
> >
> >
> > On 2021/2/3 上午1:54, Si-Wei Liu wrote:
> > > On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote:
> > >> On Tue, Feb 02, 2021 at 12:38:51
On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote:
> On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote:
> >
> > When a change of memory map occurs, the hardware resources are destroyed
> > and then re-created again with the new memory map. In such case, we need
> &
/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
This patch is being sent again a single patch the fixes hot memory
addtion to a qemy process.
drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5
On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote:
> Thanks Eli and Jason for clarifications. See inline.
>
> On Mon, Feb 1, 2021 at 11:06 PM Eli Cohen wrote:
> >
> > On Tue, Feb 02, 2021 at 02:02:25PM +0800, Jason Wang wrote:
> > >
> > >
Liu
> > > > wrote:
> > > > > On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote:
> > > > > > suspend_vq should only suspend the VQ on not save the current
> > > > > > available
> > > > > > index. This is done when a ch
On Mon, Feb 01, 2021 at 08:15:29PM -0800, Si-Wei Liu wrote:
> On Mon, Feb 1, 2021 at 7:13 PM Jason Wang wrote:
> >
> >
> > On 2021/2/2 上午3:17, Si-Wei Liu wrote:
> > > On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu
> > > wrote:
> > >&g
On Tue, Feb 02, 2021 at 11:12:51AM +0800, Jason Wang wrote:
>
> On 2021/2/2 上午3:17, Si-Wei Liu wrote:
> > On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote:
> > > On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote:
> > > > suspend_vq should only suspend the VQ
On Mon, Feb 01, 2021 at 02:00:35PM +0800, Jason Wang wrote:
>
> On 2021/2/1 下午1:52, Eli Cohen wrote:
> > On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote:
> > > On 2021/2/1 上午2:55, Eli Cohen wrote:
> > > > On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jaso
On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote:
>
> On 2021/2/1 上午2:55, Eli Cohen wrote:
> > On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote:
> > > On 2021/1/28 下午9:41, Eli Cohen wrote:
> > > > When a change of memory map occurs, the
On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote:
>
> On 2021/1/28 下午9:41, Eli Cohen wrote:
> > When a change of memory map occurs, the hardware resources are destroyed
> > and then re-created again with the new memory map. In such case, we need
> > to restor
/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 549ded074ff3..3fc8588cecae 100644
--- a/dr
suspend_vq should only suspend the VQ on not save the current available
index. This is done when a change of map occurs when the driver calls
save_channel_info().
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers
code. The second on is the
actual fix.
Eli Cohen (2):
vdpa/mlx5: Avoid unnecessary query virtqueue
vdpa/mlx5: Restore the hardware used index after change map
drivers/vdpa/mlx5/net/mlx5_vnet.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
--
2.29.2
On Wed, Jan 20, 2021 at 03:52:00AM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 20, 2021 at 10:11:54AM +0200, Eli Cohen wrote:
> > On Wed, Jan 20, 2021 at 02:57:05AM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Jan 20, 2021 at 07:36:19AM +0200, Eli Cohen wrote:
> >
On Wed, Jan 20, 2021 at 02:57:05AM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 20, 2021 at 07:36:19AM +0200, Eli Cohen wrote:
> > On Fri, Jan 08, 2021 at 04:38:55PM +0800, Jason Wang wrote:
> >
> > Hi Michael,
> > this patch is a fix. Are you going to merge it?
On Fri, Jan 08, 2021 at 04:38:55PM +0800, Jason Wang wrote:
Hi Michael,
this patch is a fix. Are you going to merge it?
>
> On 2021/1/7 下午3:18, Eli Cohen wrote:
> > map_direct_mr() assumed that the number of scatter/gather entries
> > returned by dma_map_sg_attrs() was e
On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 18.01.21 um 10:13 schrieb Eli Cohen:
> > On Mon, Jan 18, 2021 at 08:54:07AM +0100, Thomas Zimmermann wrote:
> > > Hi
> > >
> > > Am 18.01.21 um 08:43 schrieb Christian König:
On Mon, Jan 18, 2021 at 02:20:49PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 18.01.21 um 14:16 schrieb Eli Cohen:
> > On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
> > >
> > > Here's the patch against the latest DRM tree. v5.
On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
>
> Here's the patch against the latest DRM tree. v5.11-rc3 should work as well.
>
> I was able to reproduce the memory leak locally and found that the patch
> fixes it. Please give it a try.
>
As far as I am concerned, this
> still be around. I'll send out a test patch later today.
>
Great! Looking forward to test it.
> Best regards
> Thomas
>
> >
> > Regards,
> > Christian.
> >
> > Am 17.01.21 um 06:08 schrieb Eli Cohen:
> > > On Fri, Jan 15, 2021 at 10:03:50AM
On Mon, Jan 18, 2021 at 08:57:26AM +0100, Christian König wrote:
> Am 18.01.21 um 08:49 schrieb Eli Cohen:
> > On Mon, Jan 18, 2021 at 08:43:12AM +0100, Christian König wrote:
> > > Hi Eli,
> > >
> > > have you already tried using kmemleak?
> > >
>
On Mon, Jan 18, 2021 at 08:43:12AM +0100, Christian König wrote:
> Hi Eli,
>
> have you already tried using kmemleak?
>
> This sounds like a leak of memory allocated using kmalloc(), so kmemleak
> should be able to catch it.
>
Hi Christian,
I have the following configured but I did not see
On Fri, Jan 15, 2021 at 10:03:50AM +0100, Thomas Zimmermann wrote:
>
> Could you please double-check that 3fb91f56aea4 ("drm/udl: Retrieve USB
> device from struct drm_device.dev") works correctly
Checked again, it does not seem to leak.
> and that 823efa922102
> ("drm/cma-helper: Remove empty
Hi Thomas,
After long bisecting I found that this patch,
commit 1086db71a1dbbfb32ffb42cf0d540b69956f951e
Author: Thomas Zimmermann
Date: Tue Nov 3 10:30:06 2020 +0100
drm/vram-helper: Remove invariant parameters from internal kmap function
is the offending patch causing the kernel to
On Thu, Jan 14, 2021 at 03:09:04PM +0800, Jason Wang wrote:
> When compiling with -Werror=maybe-uninitialized, gcc may complains the
Maybe you want to fix to: gcc may complain about possible...
Other than that:
Acked-by: Eli Cohen
> possible uninitialized umem. Since the callers won'
On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote:
> This patch introduces the control virtqueue support for vDPA
> simulator. This is a requirement for supporting advanced features like
> multiqueue.
>
> A requirement for control virtqueue is to isolate its memory access
> from the
On Fri, Jan 08, 2021 at 04:24:43PM +0800, Jason Wang wrote:
> Upstream: posted
>
> When compiling with -Werror=maybe-uninitialized, gcc may complains the
> possible uninitialized umem. Fix that.
>
> Signed-off-by: Jason Wang
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++
> 1 file changed,
f fill_sg() which effect is overwritten by
populate_mtts().
Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
Signed-off-by: Eli Cohen
---
V0->V1:
1. Fix typos
2. Improve changelog
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 +
drivers/vdpa/mlx5
On Thu, Jan 07, 2021 at 12:15:53PM +0800, Jason Wang wrote:
>
> On 2021/1/6 下午5:05, Eli Cohen wrote:
> > map_direct_mr() assumed that the number of scatter/gather entries
> > returned by dma_map_sg_attrs() was equal to the number of segments in
> > the sgl list. This
effect is overwritten bu
populate_mtts().
Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 +
drivers/vdpa/mlx5/core/mr.c| 28
2 files changed, 13 inserti
On Wed, Dec 16, 2020 at 02:48:09PM +0800, Jason Wang wrote:
> Follows the vDPA support for multiple address spaces, this patch
> introduce uAPI for the userspace to know the number of virtqueue
> groups supported by the vDPA device.
>
> Signed-off-by: Jason Wang
> ---
> drivers/vhost/vdpa.c
On Wed, Dec 30, 2020 at 12:04:30PM +0800, Jason Wang wrote:
>
> On 2020/12/29 下午3:28, Eli Cohen wrote:
> > > @@ -43,6 +43,8 @@ struct vdpa_vq_state {
> > >* @index: device index
> > >* @features_valid: were features initialized? for legacy guests
> >
On Wed, Dec 16, 2020 at 02:48:09PM +0800, Jason Wang wrote:
> Follows the vDPA support for multiple address spaces, this patch
> introduce uAPI for the userspace to know the number of virtqueue
> groups supported by the vDPA device.
Can you explain what exactly you mean be userspace? Is it just
On Wed, Dec 16, 2020 at 02:48:08PM +0800, Jason Wang wrote:
> This patch converts the vhost-vDPA device to support multiple IOTLBs
> tagged via ASID via hlist. This will be used for supporting multiple
> address spaces in the following patches.
>
> Signed-off-by: Jason Wang
> ---
>
On Wed, Dec 16, 2020 at 02:48:08PM +0800, Jason Wang wrote:
> This patch converts the vhost-vDPA device to support multiple IOTLBs
> tagged via ASID via hlist. This will be used for supporting multiple
> address spaces in the following patches.
>
> Signed-off-by: Jason Wang
> ---
>
On Wed, Dec 16, 2020 at 02:48:08PM +0800, Jason Wang wrote:
> This patch converts the vhost-vDPA device to support multiple IOTLBs
> tagged via ASID via hlist. This will be used for supporting multiple
> address spaces in the following patches.
>
> Signed-off-by: Jason Wang
> ---
>
On Wed, Dec 16, 2020 at 02:48:07PM +0800, Jason Wang wrote:
> This patches allows userspace to send ASID based IOTLB message to
> vhost. This idea is to use the reserved u32 field in the existing V2
> IOTLB message. Vhost device should advertise this capability via
> VHOST_BACKEND_F_IOTLB_ASID
On Wed, Dec 16, 2020 at 02:48:04PM +0800, Jason Wang wrote:
> This patches introduces the multiple address spaces support for vDPA
> device. This idea is to identify a specific address space via an
> dedicated identifier - ASID.
>
> During vDPA device allocation, vDPA device driver needs to
On Wed, Dec 16, 2020 at 02:47:57PM +0800, Jason Wang wrote:
Hi Jason,
I saw the patchset and will start reviewing it starting Dec 27. I am out
of office next week.
> Hi All:
>
> This series tries to add the support for control virtqueue in vDPA.
>
> Control virtqueue is used by networking
: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
V0 -> V1
Use dma_wmb() instead of wmb()
drivers/vdpa/mlx5/net/mlx5_vnet.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/drivers/vdpa/mlx5/ne
On Wed, Dec 09, 2020 at 03:05:42AM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 09, 2020 at 08:58:46AM +0200, Eli Cohen wrote:
> > On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote:
> >
On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote:
> > On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote:
> > > On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote:
> > &g
On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote:
> On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote:
> > Make sure to put write memory barrier after updating CQ consumer index
> > so the hardware knows that there are available CQE slots in the queue.
&
On Mon, Dec 07, 2020 at 10:51:44AM +0800, Jason Wang wrote:
>
> On 2020/12/6 下午6:57, Eli Cohen wrote:
> > Make sure to put write memory barrier after updating CQ consumer index
> > so the hardware knows that there are available CQE slots in the queue.
> >
> >
: Ib0ae4c118cce524c9f492b32569179f3c1f04cc1
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/drivers/vdp
On Fri, Dec 04, 2020 at 10:53:28AM +0800, Jason Wang wrote:
>
> On 2020/12/3 下午8:24, Eli Cohen wrote:
> > > > It is mentioned in Parav's patchset that this will be coming in a
> > > > subsequent patch to his vdpa tool.
> > > So I think kernel has two opt
On Thu, Dec 03, 2020 at 07:15:37AM -0500, Michael S. Tsirkin wrote:
> On Thu, Dec 03, 2020 at 02:09:29PM +0200, Eli Cohen wrote:
> > On Thu, Dec 03, 2020 at 05:44:17AM -0500, Michael S. Tsirkin wrote:
> > > On Thu, Dec 03, 2020 at 08:49:28AM +0200, Eli Cohen wrote:
> >
On Thu, Dec 03, 2020 at 05:44:17AM -0500, Michael S. Tsirkin wrote:
> On Thu, Dec 03, 2020 at 08:49:28AM +0200, Eli Cohen wrote:
> > On Wed, Dec 02, 2020 at 05:00:22PM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Dec 02, 2020 at 09:48:25PM +0800, Jason Wang wrote:
> > >
On Wed, Dec 02, 2020 at 05:00:22PM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 02, 2020 at 09:48:25PM +0800, Jason Wang wrote:
> >
> > On 2020/12/2 下午5:23, Michael S. Tsirkin wrote:
> > > On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote:
> > > >
On Wed, Dec 02, 2020 at 04:23:11AM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 02, 2020 at 07:57:14AM +0200, Eli Cohen wrote:
> > On Wed, Dec 02, 2020 at 12:18:36PM +0800, Jason Wang wrote:
> > >
> > > On 2020/12/1 下午5:23, Cindy Lu wrote:
> > > > On
020 at 5:33 PM Michael S. Tsirkin
> > > > wrote:
> > > > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote:
> > > > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote:
> > > > > > > On Mon, Nov 30, 2020 at 08:
On Mon, Nov 30, 2020 at 04:33:09AM -0500, Michael S. Tsirkin wrote:
> On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote:
> > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote:
> > > On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote:
> >
On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote:
> On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote:
> > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote:
> > > On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote:
> > >
On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote:
> On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote:
> > We should not try to use the VF MAC address as that is used by the
> > regular (e.g. mlx5_core) NIC implementation. Instead, use a random
> >
We should not try to use the VF MAC address as that is used by the
regular (e.g. mlx5_core) NIC implementation. Instead, use a random
generated MAC address.
Suggested by: Cindy Lu
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
--
On Mon, Oct 26, 2020 at 03:06:37PM +0800, Jing Xiangfeng wrote:
> Fix to return the variable "err" from the error handling case instead
> of "ret".
>
> Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
> Signed-off-by: Jing Xiang
On Sun, Oct 25, 2020 at 11:32:39AM +0200, Eli Cohen wrote:
Ignore this. I did not notice it's v3. For some reason I don't see V4 of
this patch in my mailbox.
Anyways, for V4:
Reviewed-by: Eli Cohen
> On Fri, Oct 23, 2020 at 10:24:53AM +0800, Jason Wang wrote
> > This patch introdu
On Fri, Oct 23, 2020 at 05:00:43PM +0800, Jason Wang wrote:
> This implements a sample get_iova_range() for the simulator which
> advertise [0, ULLONG_MAX] as the valid range.
>
> Signed-off-by: Jason Wang
Reviewed-by: Eli Cohen
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 12
On Fri, Oct 23, 2020 at 09:00:41AM +, Jason Wang wrote:
> This patch introduce a config op to get valid iova range from the vDPA
> device.
>
> Signed-off-by: Jason Wang
Reviewed-by: Eli Cohen
> ---
> include/linux/vdpa.h | 15 +++
> 1 file changed, 15 in
On Fri, Oct 23, 2020 at 10:24:53AM +0800, Jason Wang wrote:
> This patch introduces a new ioctl for vhost-vdpa device that can
> report the iova range by the device.
>
> For device that implements get_iova_range() method, we fetch it from
> the vDPA device. If device doesn't implement
On Mon, Oct 12, 2020 at 03:45:10PM +0800, Jason Wang wrote:
> > >
> > So in theory we can have several asid's (for different virtqueues), each
> > one should be followed by a specific set_map call. If this is so, how do
> > I know if I met all the conditions run my driver? Maybe we need another
>
On Fri, Oct 09, 2020 at 11:56:45AM +0800, Jason Wang wrote:
>
> On 2020/10/1 下午9:29, Eli Cohen wrote:
> > On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote:
> > > This patch introduces a new bus operation to allow the vDPA bus driver
> > > to associat
1 - 100 of 272 matches
Mail list logo
