[PATCH] vdpa/mlx5: Fix dependency on MLX5_CORE

2020-10-06 Thread Eli Cohen
by: kernel test robot Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 device")s Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index a8c7607fdc90.

Re: [PATCH] vdpa/mlx5: should keep avail_index despite device status

2020-10-05 Thread Eli Cohen
On Tue, Oct 06, 2020 at 02:22:15AM -0400, Michael S. Tsirkin wrote: Acked-by: Eli Cohen > On Fri, Oct 02, 2020 at 01:17:00PM -0700, Si-Wei Liu wrote: > > + Eli. > > > > On Thu, Oct 1, 2020 at 2:02 PM Si-Wei Liu wrote: > > > > > > A VM with mlx5 vD

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote: > This patch introduces a new bus operation to allow the vDPA bus driver > to associate an ASID to a virtqueue group. > So in case of virtio_net, I would expect that all the data virtqueues will be associated with the same address space i

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:10AM +0800, Jason Wang wrote: > This patches introduces the multiple address spaces support for vDPA > device. This idea is to identify a specific address space via an > dedicated identifier - ASID. > > During vDPA device allocation, vDPA device driver needs to report

Re: [RFC PATCH 09/24] vdpa: multiple address spaces support

2020-10-01 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:10AM +0800, Jason Wang wrote: > This patches introduces the multiple address spaces support for vDPA > device. This idea is to identify a specific address space via an > dedicated identifier - ASID. > > During vDPA device allocation, vDPA device driver needs to report

Re: [RFC PATCH 06/24] vhost-vdpa: switch to use vhost-vdpa specific IOTLB

2020-09-30 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:07AM +0800, Jason Wang wrote: > To ease the implementation of per group ASID support for vDPA > device. This patch switches to use a vhost-vdpa specific IOTLB to > avoid the unnecessary refactoring of the vhost core. > > Signed-off-by: Jason Wang > --- > drivers/vho

Re: [RFC PATCH 05/24] vhost-vdpa: passing iotlb to IOMMU mapping helpers

2020-09-30 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:06AM +0800, Jason Wang wrote: > To prepare for the ASID support for vhost-vdpa, try to pass IOTLB > object to dma helpers. Maybe it's worth mentioning here that this patch does not change any functionality and is presented as a preparation for passing different iotlb'

Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-29 Thread Eli Cohen
On Tue, Sep 29, 2020 at 03:17:05AM -0400, Michael S. Tsirkin wrote: > > > > Use "select MLX5_CORE" > > instead of "depends on MLX5_CORE" > > > > Wasn't this agreed upon? > > Hmm I don't know. I recall a similar discussion around VHOST_IOTLB. > That's different ... I see. > > I see > > [linux

Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-28 Thread Eli Cohen
On Tue, Sep 29, 2020 at 02:51:12AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 09:34:33AM +0300, Eli Cohen wrote: > > On Tue, Sep 29, 2020 at 02:26:44AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Sep 29, 2020 at 09:20:26AM +0300, Eli Cohen wrote: > > >

Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-28 Thread Eli Cohen
On Tue, Sep 29, 2020 at 02:26:44AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 09:20:26AM +0300, Eli Cohen wrote: > > On Mon, Sep 28, 2020 at 03:55:09PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > &

Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-28 Thread Eli Cohen
On Mon, Sep 28, 2020 at 03:55:09PM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > > Change core vdpa functionality into a loadbale module such that upcoming > > block implementation will be able to use it. > > > > Signed-

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-28 Thread Eli Cohen
On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote: > > > > > > Hmm other drivers select VHOST_IOTLB, why not do the same? > > > > I can't see another driver doing that. > > Well grep VHOST_IOTLB and you will see some examples. $ git grep -wn VHOST_IOTLB drivers/vhost/Kconfig:2:

[PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module

2020-09-24 Thread Eli Cohen
Change core vdpa functionality into a loadbale module such that upcoming block implementation will be able to use it. Signed-off-by: Eli Cohen --- V0 --> V1: Removed "default n" for configu options as 'n' is the default drivers/vdpa/Kconfig | 8 +++-

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: > > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig > > > +++ linux-next-20200917/drivers/vdpa/Kconfig > > > @@ -31,7 +31,7 @@ config IFCVF > > > > > > config MLX5_VDPA > > > bool "MLX5 VDPA support library for ConnectX devi

Re: [RFC PATCH 02/24] vhost-vdpa: fix vqs leak in vhost_vdpa_open()

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote: > We need to free vqs during the err path after it has been allocated > since vhost won't do that for us. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vdpa.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) >

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Eli Cohen
On Thu, Sep 24, 2020 at 03:26:08PM +0800, Jason Wang wrote: > > On 2020/9/24 下午3:16, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: > > > Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") > > > introduces

Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

2020-09-24 Thread Eli Cohen
device >ioctl > 2) vhost_set_backend_features() was called when dev mutex has already >been held which will lead a deadlock > I assume this patch requires some patch in qemu as well. Do you have such patch? > This patch fixes the above issues. > > Cc: Eli Cohen > Reported-by: Zh

[vhost next 2/2] vdpa/mlx5: Fix failure to bring link up

2020-09-17 Thread Eli Cohen
Set VIRTIO_NET_S_LINK_UP in config status to allow the get the bring the net device's link up. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 + 1 file changed, 1 insertion(+) diff

[vhost next 1/2] vdpa/mlx5: Make use of a specific 16 bit endianness API

2020-09-17 Thread Eli Cohen
Introduce a dedicated function to be used for setting 16 bit fields per virio endianness requirements and use it to set the mtu field. Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net

[vhost next 0/2] mlx5 vdpa fix netdev status

2020-09-17 Thread Eli Cohen
bit Eli Cohen (2): vdpa/mlx5: Make use of a specific 16 bit endianness API vdpa/mlx5: Fix failure to bring link up drivers/vdpa/mlx5/net/mlx5_vnet.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.27.0

[PATCH] vdpa/mlx5: Make vdpa core driver a distinct module

2020-08-27 Thread Eli Cohen
Change core vdpa functionality into a loadbale module such that upcoming block implementation will be able to use it. Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 6 +++--- drivers/vdpa/Makefile | 2 +- drivers/vdpa/mlx5/Makefile | 7 +-- drivers

Re: [PATCH] vdpa/mlx5: Remove duplicate include

2020-08-27 Thread Eli Cohen
On Thu, Aug 27, 2020 at 08:05:47PM +0800, Jing Xiangfeng wrote: > Remove linux/mlx5/device.h which is included more than once > > Signed-off-by: Jing Xiangfeng Acked-by: Eli Cohen > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - > 1 file changed, 1 deletion(-) > > d

Re: [PATCH V2 2/3] vhost: vdpa: report iova range

2020-08-22 Thread Eli Cohen
On Fri, Aug 21, 2020 at 05:28:12AM -0400, Jason Wang wrote: > This patch introduces a new ioctl for vhost-vdpa device that can > report the iova range by the device. > > For device that implements get_iova_range() method, we fetch it from > the vDPA device. If device doesn't implement get_iova_ran

Re: [PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-22 Thread Eli Cohen
"vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > Link: https://github.com/ClangBuiltLinux/linux/issues/1140 > Signed-off-by: Nathan Chancellor > --- Acked-by: Eli Cohen > drivers/vdpa/mlx5/net/mlx5_vnet.c | 50 +++ > 1 file cha

RE: VDPA Debug/Statistics

2020-08-11 Thread Eli Cohen
On Tue, Aug 11, 2020 at 11:26:20AM +, Eli Cohen wrote: > Hi All > > Currently, the only statistics we get for a VDPA instance comes from the > virtio_net device instance. Since VDPA involves hardware acceleration, there > can be quite a lot of information that can be f

VDPA Debug/Statistics

2020-08-11 Thread Eli Cohen
Hi All Currently, the only statistics we get for a VDPA instance comes from the virtio_net device instance. Since VDPA involves hardware acceleration, there can be quite a lot of information that can be fetched from the underlying device. Currently there is no generic method to fetch this infor

RE: [PATCH] vdpa/mlx5: Fix pointer math in mlx5_vdpa_get_config()

2020-08-08 Thread Eli Cohen
Acked-by: Eli Cohen BTW, vdpa_sim has the same bug. -Original Message- From: Dan Carpenter Sent: Saturday, August 8, 2020 12:33 PM To: Michael S. Tsirkin ; Eli Cohen Cc: Jason Wang ; Parav Pandit ; virtualizat...@lists.linux-foundation.org; linux-kernel@vger.kernel.org; kernel

Re: [PATCH][next] vdpa/mlx5: fix memory allocation failure checks

2020-08-08 Thread Eli Cohen
On Thu, Aug 06, 2020 at 05:08:28PM +0100, Colin King wrote: Acked by: Eli Cohen > From: Colin Ian King > > The memory allocation failure checking for in and out is currently > checking if the pointers are valid rather than the contents of what > they point to. Hence the null

RE: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-08 Thread Eli Cohen
After all this patch is not fixing it all. If we get to default of the switch statement we will free invalid pointer so removing ack-ed by me. The previous patch by Colin King fixes it. -Original Message- From: Eli Cohen Sent: Sunday, August 9, 2020 8:53 AM To: Alex Dewar Cc

Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-08 Thread Eli Cohen
Acked-by: Eli Cohen On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote: > In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory > is allocated to *in and *out, but only the values of in and out are > null-checked (i.e. there is a missing dereference).

Re: [PATCH] vdpa/mlx5: Fix uninitialised variable in core/mr.c

2020-08-08 Thread Eli Cohen
On Thu, Aug 06, 2020 at 07:56:15PM +0100, Alex Dewar wrote: Acked-by: Eli Cohen > If the kernel is unable to allocate memory for the variable dmr then > err will be returned without being set. Set err to -ENOMEM in this > case. > > Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared

Re: [PATCH 1/4] vdpa: introduce config op to get valid iova range

2020-08-06 Thread Eli Cohen
On Wed, Aug 05, 2020 at 08:51:56AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2020 at 11:29:44AM +0800, Jason Wang wrote: > > This patch introduce a config op to get valid iova range from the vDPA > > device. > > > > Signed-off-by: Jason Wang > > --- > > include/linux/vdpa.h | 14 +++

Re: [PATCH 1/4] vdpa: introduce config op to get valid iova range

2020-08-06 Thread Eli Cohen
On Thu, Aug 06, 2020 at 08:29:22AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 06, 2020 at 03:03:55PM +0300, Eli Cohen wrote: > > On Wed, Aug 05, 2020 at 08:51:56AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Jun 17, 2020 at 11:29:44AM +0800, Jason Wang wrote: > > &g

Re: [PATCH 1/4] vdpa: introduce config op to get valid iova range

2020-08-06 Thread Eli Cohen
On Wed, Jun 17, 2020 at 06:29:44AM +0300, Jason Wang wrote: > This patch introduce a config op to get valid iova range from the vDPA > device. > > Signed-off-by: Jason Wang > --- > include/linux/vdpa.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/vdpa.h

Re: [PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-05 Thread Eli Cohen
On Wed, Aug 05, 2020 at 08:48:52AM -0400, Michael S. Tsirkin wrote: > > > > Did you merge this?: > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git > > mlx5-next > > > I can only merge this tree if no one else will. Linus does not like > getting same patches through t

Re: [PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-05 Thread Eli Cohen
On Wed, Aug 05, 2020 at 08:00:55AM -0400, Michael S. Tsirkin wrote: > On Tue, Aug 04, 2020 at 07:20:36PM +0300, Eli Cohen wrote: > > Hi Michael, > > please note that this series depends on mlx5 core device driver patches > > in mlx5-next branch in > > git://git.kernel.o

Re: [PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-05 Thread Eli Cohen
On Wed, Aug 05, 2020 at 04:12:46PM +0800, Jason Wang wrote: > > > >BTW, for some reason I did not get all the patches into my mailbox and I > >suspect they were not all sent. Did you get all the series 0-13? > > > I can see patch 0 to patch 12 but not patch 13 (I guess 12 is all). > > Thanks >

Re: [PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-04 Thread Eli Cohen
On Tue, Aug 04, 2020 at 05:29:09PM -0400, Michael S. Tsirkin wrote: > On Tue, Aug 04, 2020 at 07:20:36PM +0300, Eli Cohen wrote: > > Hi Michael, > > please note that this series depends on mlx5 core device driver patches > > in mlx5-next branch in > > git://git.kernel.o

[PATCH V4 linux-next 12/12] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-08-04 Thread Eli Cohen
. In subsequent patches we will have devlink support to control which VF is used for VDPA and which function is used for regular networking. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 10 + drivers/vdpa/mlx5/Makefile|5 +- drivers

[PATCH V4 linux-next 08/12] vdpa: Modify get_vq_state() to return error code

2020-08-04 Thread Eli Cohen
Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++-- drivers/vdpa

[PATCH V4 linux-next 01/12] vhost-vdpa: refine ioctl pre-processing

2020-08-04 Thread Eli Cohen
From: Jason Wang Switch to use 'switch' to make the codes more easier to be extended. Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 16e0ffb115be..563ae6204052 100

[PATCH V4 linux-next 02/12] vhost: generialize backend features setting/getting

2020-08-04 Thread Eli Cohen
From: Jason Wang Move the backend features setting/getting from net.c to vhost.c to be reused by vhost-vdpa. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 18 ++ drivers/vhost/vhost.c | 15 +++ drivers/vhost/vhost.h | 2 ++ 3 files changed, 19 insertions(+)

[PATCH V4 linux-next 11/12] vdpa/mlx5: Add shared memory registration code

2020-08-04 Thread Eli Cohen
code will be shared by network or block driver implementations. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/Makefile | 2 +- drivers/vdpa/mlx5/core/Makefile| 1 - drivers/vdpa/mlx5/core/mlx5_vdpa.h | 34 ++ drivers/vdpa/mlx5/core/mr.c| 484

[PATCH V4 linux-next 04/12] vhost-vdpa: support IOTLB batching hints

2020-08-04 Thread Eli Cohen
From: Jason Wang This patches extend the vhost IOTLB API to accept batch updating hints form userspace. When userspace wants update the device IOTLB in a batch, it may do: 1) Write vhost_iotlb_msg with VHOST_IOTLB_BATCH_BEGIN flag 2) Perform a batch of IOTLB updating via VHOST_IOTLB_UPDATE/INVAL

[PATCH V4 linux-next 06/12] vdpa: remove hard coded virtq num

2020-08-04 Thread Eli Cohen
From: Max Gurtovoy This will enable vdpa providers to add support for multi queue feature and publish it to upper layers (vhost and virtio). Signed-off-by: Max Gurtovoy Reviewed-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++- drivers/vdpa/vdpa.c | 3 +++ drivers/vdpa

[PATCH V4 linux-next 09/12] vdpa/mlx5: Add hardware descriptive header file

2020-08-04 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a

[PATCH V4 linux-next 10/12] vdpa/mlx5: Add support library for mlx5 VDPA implementation

2020-08-04 Thread Eli Cohen
Following patches introduce VDPA network driver for Mellanox Connectx6 devices. This patch provides functionality that will be used by those patches. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 9 + drivers/vdpa/Makefile | 1

[PATCH V4 linux-next 05/12] vdpasim: support batch updating

2020-08-04 Thread Eli Cohen
From: Jason Wang The vDPA simulator support both set_map() and dma_map()/dma_unmap() operations. But vhost-vdpa can only use one of them. So this patch introduce a module parameter (batch_mapping) that let vpda_sim to support only one of those dma operations. The batched mapping via set_map() is

[PATCH V4 linux-next 07/12] net/vdpa: Use struct for set/get vq state

2020-08-04 Thread Eli Cohen
Pandit Acked-by: Jason Wang Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 4 ++-- drivers/vdpa/ifcvf/ifcvf_main.c | 9 + drivers/vdpa/vdpa_sim/vdpa_sim.c | 10 ++ drivers/vhost/vdpa.c | 7

[PATCH V4 linux-next 03/12] vhost-vdpa: support get/set backend features

2020-08-04 Thread Eli Cohen
From: Jason Wang This patch makes userspace can get and set backend features to vhost-vdpa. Signed-off-by: Cindy Lu Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 563a

[PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-04 Thread Eli Cohen
arch Make use of the free callback to destroy resoruces on unload Use VIRTIO_F_ACCESS_PLATFORM instead of legacy VIRTIO_F_IOMMU_PLATFORM Add empty implementations for get_vq_notification() and get_vq_irq() Eli Cohen (6): net/vdpa: Use struct for set/get vq state vdpa: Modify get_vq_state() to

Re: [PATCH V3 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-08-04 Thread Eli Cohen
On Tue, Jul 28, 2020 at 04:43:00PM +0300, kernel test robot wrote: > Hi Eli, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on next-20200727] > > url: > https://github.com/0day-ci/linux/commits/Eli-Cohen/VDPA-support-for-Mellanox-C

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-08-03 Thread Eli Cohen
On Mon, Aug 03, 2020 at 04:51:27PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 28, 2020 at 09:05:29AM +0300, Eli Cohen wrote: > > Hi Michael, > > please note that this series depends on mlx5 core device driver patches > > in mlx5-next branch in > > git://git.kernel.o

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-08-03 Thread Eli Cohen
On Mon, Aug 03, 2020 at 04:34:50PM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 29, 2020 at 08:54:52AM +0300, Eli Cohen wrote: > > On Tue, Jul 28, 2020 at 02:53:34PM +0800, Jason Wang wrote: > > > > > > Just notice Michael's vhost branch can not compile due to

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-28 Thread Eli Cohen
On Tue, Jul 28, 2020 at 02:53:34PM +0800, Jason Wang wrote: > > Just notice Michael's vhost branch can not compile due to this commit: > > commit fee8fe6bd8ccacd27e963b71b4f943be3721779e > Author: Michael S. Tsirkin > Date:   Mon Jul 27 10:51:55 2020 -0400 > >     vdpa: make sure set_features i

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
On Tue, Jul 28, 2020 at 02:53:34PM +0800, Jason Wang wrote: > > On 2020/7/28 下午2:40, Jason Wang wrote: > > > >On 2020/7/28 下午2:32, Eli Cohen wrote: > >>On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: > >>>On 2020/7/28 下午2:05, Eli Cohen wrote: &

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: > > On 2020/7/28 下午2:05, Eli Cohen wrote: > >Hi Michael, > >please note that this series depends on mlx5 core device driver patches > >in mlx5-next branch in > >git://git.kernel.org/pub/scm/linux/kernel/git/

[PATCH V3 vhost next 02/10] vdpa_sim: use the batching API

2020-07-27 Thread Eli Cohen
From: Jason Wang Change-Id: I3751f1aecce285e0f61530c69616852d49e5f547 Signed-off-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 20 drivers/vhost/vdpa.c | 1 - 2 files changed, 21 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa

[PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
y the following quemu version: url: https://github.com/jasowang/qemu.git branch: vdpa Commit ID: 6f4e59b807db V2->V3 Fix makefile to use include path relative to the root of the kernel Eli Cohen (7): net/vdpa: Use struct for set/get vq state vhost: Fix documentation vdpa: Modify get_vq_st

[PATCH V3 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-27 Thread Eli Cohen
. In subsequent patches we will have devlink support to control which VF is used for VDPA and which function is used for regular networking. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- V2->V3 Fix makefile to use include path relative to the root of the kernel drivers/vdpa/Kcon

[PATCH V3 vhost next 04/10] net/vdpa: Use struct for set/get vq state

2020-07-27 Thread Eli Cohen
Pandit Acked-by: Jason Wang Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 4 ++-- drivers/vdpa/ifcvf/ifcvf_main.c | 9 + drivers/vdpa/vdpa_sim/vdpa_sim.c | 10 ++ drivers/vhost/vdpa.c | 10

[PATCH V3 vhost next 08/10] vdpa/mlx5: Add support library for mlx5 VDPA implementation

2020-07-27 Thread Eli Cohen
Following patches introduce VDPA network driver for Mellanox Connectx6 devices. This patch provides functionality that will be used by those patches. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 8 + drivers/vdpa/Makefile | 1

[PATCH V3 vhost next 03/10] vdpa: remove hard coded virtq num

2020-07-27 Thread Eli Cohen
From: Max Gurtovoy This will enable vdpa providers to add support for multi queue feature and publish it to upper layers (vhost and virtio). Signed-off-by: Max Gurtovoy Reviewed-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++- drivers/vdpa/vdpa.c | 3 +++ drivers/vdpa

[PATCH V3 vhost next 07/10] vdpa/mlx5: Add hardware descriptive header file

2020-07-27 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a

[PATCH V3 vhost next 01/10] vhost-vdpa: support batch updating

2020-07-27 Thread Eli Cohen
From: Jason Wang Change-Id: Ifd7139cfbd122dc22493f4bb93fa884f8edbddb6 Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 23 +-- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/vhost/vdpa.c b/dri

[PATCH V3 vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-27 Thread Eli Cohen
code will be shared by network or block driver implementations. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/Makefile | 2 +- drivers/vdpa/mlx5/core/Makefile| 1 - drivers/vdpa/mlx5/core/mlx5_vdpa.h | 34 +++ drivers/vdpa/mlx5/core/mr.c| 473

[PATCH V3 vhost next 05/10] vhost: Fix documentation

2020-07-27 Thread Eli Cohen
Fix documentation to match actual function prototypes. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c index 1f0ca6e44410..0d4213a54a88 100644

[PATCH V3 vhost next 06/10] vdpa: Modify get_vq_state() to return error code

2020-07-27 Thread Eli Cohen
Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++-- drivers/vdpa

Re: [PATCH V2 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-22 Thread Eli Cohen
On Mon, Jul 20, 2020 at 08:55:54PM +0800, kernel test robot wrote: > Hi Eli, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on next-20200717] > > url: > https://github.com/0day-ci/linux/commits/Eli-Cohen/VDPA-support-for-Mellanox-C

[PATCH V2 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-20 Thread Eli Cohen
. In subsequent patches we will have devlink support to control which VF is used for VDPA and which function is used for regular networking. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- Changes from V0: 1. Fix include path usage 2. Fix use after free in qp_create() 3. Consistently use

[PATCH V2 vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-20 Thread Eli Cohen
code will be shared by network or block driver implementations. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- V0 -> V2: 1. Improve changelog 2. Fix static checker warning drivers/vdpa/mlx5/Makefile | 2 +- drivers/vdpa/mlx5/core/Makefile| 1 - drivers/vdpa/mlx5/c

[PATCH V2 vhost next 01/10] vhost-vdpa: support batch updating

2020-07-20 Thread Eli Cohen
From: Jason Wang Change-Id: Ifd7139cfbd122dc22493f4bb93fa884f8edbddb6 Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 23 +-- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/vhost/vdpa.c b/dri

[PATCH V2 vhost next 03/10] vdpa: remove hard coded virtq num

2020-07-20 Thread Eli Cohen
From: Max Gurtovoy This will enable vdpa providers to add support for multi queue feature and publish it to upper layers (vhost and virtio). Signed-off-by: Max Gurtovoy Reviewed-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++- drivers/vdpa/vdpa.c | 3 +++ drivers/vdpa

[PATCH V2 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-20 Thread Eli Cohen
. In subsequent patches we will have devlink support to control which VF is used for VDPA and which function is used for regular networking. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- Changes from V0: 1. Fix include path usage 2. Fix use after free in qp_create() 3. Consistently use

[PATCH V2 vhost next 02/10] vdpa_sim: use the batching API

2020-07-20 Thread Eli Cohen
From: Jason Wang Change-Id: I3751f1aecce285e0f61530c69616852d49e5f547 Signed-off-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 20 drivers/vhost/vdpa.c | 1 - 2 files changed, 21 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa

[PATCH V2 vhost next 08/10] vdpa/mlx5: Add support library for mlx5 VDPA implementation

2020-07-20 Thread Eli Cohen
Following patches introduce VDPA network driver for Mellanox Connectx6 devices. This patch provides functionality that will be used by those patches. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 8 + drivers/vdpa/Makefile | 1

[PATCH V2 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-20 Thread Eli Cohen
y the following quemu version: url: https://github.com/jasowang/qemu.git branch: vdpa Commit ID: 6f4e59b807db Eli Cohen (7): net/vdpa: Use struct for set/get vq state vhost: Fix documentation vdpa: Modify get_vq_state() to return error code vdpa/mlx5: Add hardware descriptive header file

[PATCH V2 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-20 Thread Eli Cohen
y the following quemu version: url: https://github.com/jasowang/qemu.git branch: vdpa Commit ID: 6f4e59b807db Eli Cohen (7): net/vdpa: Use struct for set/get vq state vhost: Fix documentation vdpa: Modify get_vq_state() to return error code vdpa/mlx5: Add hardware descriptive header file

[PATCH V2 vhost next 05/10] vhost: Fix documentation

2020-07-20 Thread Eli Cohen
Fix documentation to match actual function prototypes. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c index 1f0ca6e44410..0d4213a54a88 100644

[PATCH V2 vhost next 05/10] vhost: Fix documentation

2020-07-20 Thread Eli Cohen
Fix documentation to match actual function prototypes. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c index 1f0ca6e44410..0d4213a54a88 100644

[PATCH V2 vhost next 06/10] vdpa: Modify get_vq_state() to return error code

2020-07-20 Thread Eli Cohen
Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++-- drivers/vdpa

[PATCH V2 vhost next 04/10] net/vdpa: Use struct for set/get vq state

2020-07-20 Thread Eli Cohen
Pandit Acked-by: Jason Wang Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 4 ++-- drivers/vdpa/ifcvf/ifcvf_main.c | 9 + drivers/vdpa/vdpa_sim/vdpa_sim.c | 10 ++ drivers/vhost/vdpa.c | 10

[PATCH V2 vhost next 07/10] vdpa/mlx5: Add hardware descriptive header file

2020-07-20 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a

[PATCH V2 vhost next 03/10] vdpa: remove hard coded virtq num

2020-07-20 Thread Eli Cohen
From: Max Gurtovoy This will enable vdpa providers to add support for multi queue feature and publish it to upper layers (vhost and virtio). Signed-off-by: Max Gurtovoy Reviewed-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++- drivers/vdpa/vdpa.c | 3 +++ drivers/vdpa

[PATCH V2 vhost next 04/10] net/vdpa: Use struct for set/get vq state

2020-07-20 Thread Eli Cohen
Pandit Acked-by: Jason Wang Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 4 ++-- drivers/vdpa/ifcvf/ifcvf_main.c | 9 + drivers/vdpa/vdpa_sim/vdpa_sim.c | 10 ++ drivers/vhost/vdpa.c | 10

[PATCH V2 vhost next 01/10] vhost-vdpa: support batch updating

2020-07-20 Thread Eli Cohen
From: Jason Wang Change-Id: Ifd7139cfbd122dc22493f4bb93fa884f8edbddb6 Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 23 +-- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/vhost/vdpa.c b/dri

[PATCH V2 vhost next 07/10] vdpa/mlx5: Add hardware descriptive header file

2020-07-20 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a

[PATCH V2 vhost next 08/10] vdpa/mlx5: Add support library for mlx5 VDPA implementation

2020-07-20 Thread Eli Cohen
Following patches introduce VDPA network driver for Mellanox Connectx6 devices. This patch provides functionality that will be used by those patches. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 8 + drivers/vdpa/Makefile | 1

[PATCH V2 vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-20 Thread Eli Cohen
code will be shared by network or block driver implementations. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- V0 -> V2: 1. Improve changelog 2. Fix static checker warning drivers/vdpa/mlx5/Makefile | 2 +- drivers/vdpa/mlx5/core/Makefile| 1 - drivers/vdpa/mlx5/c

[PATCH V2 vhost next 02/10] vdpa_sim: use the batching API

2020-07-20 Thread Eli Cohen
From: Jason Wang Change-Id: I3751f1aecce285e0f61530c69616852d49e5f547 Signed-off-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 20 drivers/vhost/vdpa.c | 1 - 2 files changed, 21 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa

[PATCH V2 vhost next 06/10] vdpa: Modify get_vq_state() to return error code

2020-07-20 Thread Eli Cohen
Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++-- drivers/vdpa

Re: [PATCH vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-19 Thread Eli Cohen
On Mon, Jul 20, 2020 at 12:12:30PM +0800, Jason Wang wrote: > > On 2020/7/19 上午3:49, Eli Cohen wrote: > >On Fri, Jul 17, 2020 at 04:57:29PM +0800, Jason Wang wrote: > >>>Looks like checking intialized is enough. Will fix this. > >>>>>+ > >>>&g

Re: [PATCH vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-18 Thread Eli Cohen
On Fri, Jul 17, 2020 at 04:57:29PM +0800, Jason Wang wrote: > >Looks like checking intialized is enough. Will fix this. > >>>+ > >>>+static void mlx5_vdpa_set_vq_ready(struct vdpa_device *vdev, u16 idx, > >>>bool ready) > >>>+{ > >>>+ struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); > >>>+ struct m

Re: [PATCH vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-16 Thread Eli Cohen
On Thu, Jul 16, 2020 at 05:14:32PM +0800, Jason Wang wrote: > > >+static void suspend_vqs(struct mlx5_vdpa_net *ndev) > >+{ > >+int i; > >+ > >+for (i = 0; i < MLX5_MAX_SUPPORTED_VQS; i++) > >+suspend_vq(ndev, &ndev->vqs[i]); > > > In teardown_virtqueues() it has a check of m

Re: [PATCH vhost next 06/10] vdpa: Add means to communicate vq status on get_vq_state

2020-07-16 Thread Eli Cohen
On Thu, Jul 16, 2020 at 05:35:18PM +0800, Jason Wang wrote: > > On 2020/7/16 下午4:21, Eli Cohen wrote: > >On Thu, Jul 16, 2020 at 04:11:00PM +0800, Jason Wang wrote: > >>On 2020/7/16 下午3:23, Eli Cohen wrote: > >>>Currently, get_vq_state() is used only to pass the a

Re: [PATCH vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-16 Thread Eli Cohen
On Thu, Jul 16, 2020 at 04:13:21PM +0800, Jason Wang wrote: > > On 2020/7/16 下午3:23, Eli Cohen wrote: > >Add code to support registering guest's memory region for the device. > > > It would be better to use "userspace" memory here since vhost-vDPA > could

Re: [PATCH vhost next 06/10] vdpa: Add means to communicate vq status on get_vq_state

2020-07-16 Thread Eli Cohen
On Thu, Jul 16, 2020 at 04:11:00PM +0800, Jason Wang wrote: > > On 2020/7/16 下午3:23, Eli Cohen wrote: > >Currently, get_vq_state() is used only to pass the available index value > >of a vq. Extend the struct to return status on the VQ to the caller. > >For now, define VQ

[PATCH vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-16 Thread Eli Cohen
. In subsequent patches we will have devlink support to control which VF is used for VDPA and which function is used for regular networking. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 10 + drivers/vdpa/mlx5/Makefile|5 +- drivers

[PATCH vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-16 Thread Eli Cohen
Add code to support registering guest's memory region for the device. This code will be shared by network or block driver implementations. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/Makefile | 2 +- drivers/vdpa/mlx5/core/Makefile| 1 - dr

[PATCH vhost next 07/10] vdpa/mlx5: Add hardware descriptive header file

2020-07-16 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a

<    1   2   3   >